Re: [x265] [PATCH] Edge Aware Quad Tree Establishment

2020-02-21 Thread Mario *LigH* Rohkrämer
srikanth.kurap...@multicorewareinc.com schrieb am 19.02.2020 um 07:45: @@ -457,7 +457,9 @@ > ... +H0(" --rskip Set mode for early exit from recursion. Mode 1: exit using rdcost. Mode 2: exit using edge density. Mode 3: exit using edge density with forceful skip for

Re: [x265] [PATCH] Edge Aware Quad Tree Establishment

2020-02-20 Thread Mario *LigH* Rohkrämer
srikanth.kurap...@multicorewareinc.com schrieb am 19.02.2020 um 07:45: @@ -457,7 +457,9 @@ ... +H0(" --rskip Set mode for early exit from recursion. Mode 1: exit using rdcost. Mode 2: exit using edge density. Mode 3: exit using edge density with forceful skip for small

Re: [x265] [PATCH] Edge Aware Quad Tree Establishment

2020-02-19 Thread Aruna Matheswaran
Pushed to default. On Wed, Feb 19, 2020 at 12:15 PM wrote: > # HG changeset patch > # User Srikanth Kurapati > # Date 1580280547 -19800 > # Wed Jan 29 12:19:07 2020 +0530 > # Node ID ecf19726600a3218c10eb28dcfded16d2a18c301 > # Parent c2769ac5fa9d6776317e720d19f5f8b0eab4 > Edge Aware

Re: [x265] [PATCH] Edge Aware Quad Tree Establishment

2020-02-18 Thread Srikanth Kurapati
Hi Aruna, 1. addressed all the cosmetic changes. 2. Regarding the question for threshold datatype. I have justified this in the external review itself. reiterating the same here. [Srikanth] The purpose is to make it easily configurable by naive users for providing the threshold and then

Re: [x265] [PATCH] Edge Aware Quad Tree Establishment

2020-02-18 Thread Aruna Matheswaran
On Fri, Feb 7, 2020 at 3:37 PM wrote: > # HG changeset patch > # User Srikanth Kurapati > # Date 1580280547 -19800 > # Wed Jan 29 12:19:07 2020 +0530 > # Node ID 30d303b38c7bd1733aedd01a3f738fb08ec1488c > # Parent fdbd4e4a2aff93bfc14b10efcd9e681a7ebae311 > Edge Aware Quad Tree

Re: [x265] [PATCH] Edge Aware Quad Tree Establishment

2020-02-10 Thread Srikanth Kurapati
Thank you. @Aruna Matheswaran please push the above patch to the repo. On Mon, Feb 10, 2020 at 3:00 PM Kavitha Sampath < kavi...@multicorewareinc.com> wrote: > Looks good to me. > > On Fri, Feb 7, 2020 at 3:37 PM > wrote: > >> # HG changeset patch >> # User Srikanth Kurapati >> # Date

Re: [x265] [PATCH] Edge Aware Quad Tree Establishment

2020-02-10 Thread Kavitha Sampath
Looks good to me. On Fri, Feb 7, 2020 at 3:37 PM wrote: > # HG changeset patch > # User Srikanth Kurapati > # Date 1580280547 -19800 > # Wed Jan 29 12:19:07 2020 +0530 > # Node ID 30d303b38c7bd1733aedd01a3f738fb08ec1488c > # Parent fdbd4e4a2aff93bfc14b10efcd9e681a7ebae311 > Edge Aware

Re: [x265] [PATCH] Edge Aware Quad Tree Establishment

2020-02-07 Thread Srikanth Kurapati
On Tue, Feb 4, 2020 at 5:10 PM Srikanth Kurapati < srikanth.kurap...@multicorewareinc.com> wrote: > On Wed, Jan 29, 2020 at 12:20 PM > wrote: > >> # HG changeset patch >> # User Srikanth Kurapati >> # Date 1580280547 -19800 >> # Wed Jan 29 12:19:07 2020 +0530 >> # Node ID

Re: [x265] [PATCH] Edge Aware Quad Tree Establishment

2020-02-04 Thread Kavitha Sampath
On Tue, Feb 4, 2020 at 5:10 PM Srikanth Kurapati < srikanth.kurap...@multicorewareinc.com> wrote: > On Wed, Jan 29, 2020 at 12:20 PM > wrote: > >> # HG changeset patch >> # User Srikanth Kurapati >> # Date 1580280547 -19800 >> # Wed Jan 29 12:19:07 2020 +0530 >> # Node ID

Re: [x265] [PATCH] Edge Aware Quad Tree Establishment

2020-02-04 Thread Srikanth Kurapati
On Wed, Jan 29, 2020 at 12:20 PM wrote: > # HG changeset patch > # User Srikanth Kurapati > # Date 1580280547 -19800 > # Wed Jan 29 12:19:07 2020 +0530 > # Node ID e9c8c0089bddc9e9e47774b5fda1f4dff1fb45e4 > # Parent fdbd4e4a2aff93bfc14b10efcd9e681a7ebae311 > Edge Aware Quad Tree

Re: [x265] [PATCH] Edge Aware Quad Tree Establishment

2020-02-03 Thread Kavitha Sampath
On Wed, Jan 29, 2020 at 12:20 PM wrote: > # HG changeset patch > # User Srikanth Kurapati > # Date 1580280547 -19800 > # Wed Jan 29 12:19:07 2020 +0530 > # Node ID e9c8c0089bddc9e9e47774b5fda1f4dff1fb45e4 > # Parent fdbd4e4a2aff93bfc14b10efcd9e681a7ebae311 > Edge Aware Quad Tree

Re: [x265] [PATCH] Edge Aware Quad Tree Establishment

2020-02-03 Thread Srikanth Kurapati
[KS] 4500 CUs covering contents with varied level of complexity ? [Srikanth] Yes. The variance for the set of CUs varies from (0,0.25) which is the maximum range i have observed so far in the tests. On Mon, Feb 3, 2020 at 2:38 PM Kavitha Sampath wrote: > > > On Wed, Jan 29, 2020 at 12:38 PM

Re: [x265] [PATCH] Edge Aware Quad Tree Establishment

2020-02-03 Thread Kavitha Sampath
On Wed, Jan 29, 2020 at 12:38 PM Srikanth Kurapati < srikanth.kurap...@multicorewareinc.com> wrote: > [KS] Are we going to have the same default threshold for both flows - > (a)histogram based scenecut =1 && aqmode=0 (b) histogram based scenecut =0 > && aqmode=1 > When the variance of the two

Re: [x265] [PATCH] Edge Aware Quad Tree Establishment

2020-01-28 Thread Srikanth Kurapati
[KS] Are we going to have the same default threshold for both flows - (a)histogram based scenecut =1 && aqmode=0 (b) histogram based scenecut =0 && aqmode=1 When the variance of the two flows can vary, shouldn't the thresholds vary? [KS] The docs isn't giving much guidance to users on how to set

Re: [x265] [PATCH] Edge Aware Quad Tree Establishment

2020-01-22 Thread Srikanth Kurapati
This patch provided rskip=2 for rd levels 0 to 4. For rd levels 5 and 6 it will be provided through a subsequent patch. On Wed, Jan 22, 2020 at 5:53 PM Alex Giladi wrote: > Why would rskip=2 not work on rd > 4? > Is there a technical reason, or is there an implicit assumption that the > users

Re: [x265] [PATCH] Edge Aware Quad Tree Establishment

2020-01-22 Thread Alex Giladi
Why would rskip=2 not work on rd > 4? Is there a technical reason, or is there an implicit assumption that the users won't want to use rskip at rd > 4? On Wed, Jan 22, 2020, 04:00 Kavitha Sampath wrote: > > > On Tue, Jan 21, 2020 at 11:32 AM > wrote: > >> # HG changeset patch >> # User

Re: [x265] [PATCH] Edge Aware Quad Tree Establishment

2020-01-22 Thread Kavitha Sampath
On Tue, Jan 21, 2020 at 11:32 AM wrote: > # HG changeset patch > # User Srikanth Kurapati > # Date 1579584229 -19800 > # Tue Jan 21 10:53:49 2020 +0530 > # Node ID e0e0270ead4189a545821b00011c47d61e6b817a > # Parent acc5d16999e2faf6e75ecc1df9a01c1953ebaf8c > Edge Aware Quad Tree

Re: [x265] [PATCH] Edge Aware Quad Tree Establishment

2020-01-20 Thread Srikanth Kurapati
[KS] That is not the only requirement. pelx and pely provides the starting offset of the buffer for which variance should be computed. parentCTU's pelx and pely do not return the correct x,y coordinates of the CU undergoing analysis. I once again insist you to debug, understand the computation of

Re: [x265] [PATCH] Edge Aware Quad Tree Establishment

2020-01-20 Thread Kavitha Sampath
On Mon, Jan 20, 2020 at 12:12 PM Srikanth Kurapati < srikanth.kurap...@multicorewareinc.com> wrote: > Patch does not apply on current x265 tip, please fix. > [Srikanth] - resolved > I am assuming the following will be sent as follow up patches > 1. Edge aware quadtree feature for Rd levels 5, 6 >

Re: [x265] [PATCH] Edge Aware Quad Tree Establishment

2020-01-19 Thread Srikanth Kurapati
Patch does not apply on current x265 tip, please fix. [Srikanth] - resolved I am assuming the following will be sent as follow up patches 1. Edge aware quadtree feature for Rd levels 5, 6 2. Asm version of planecopy used for this feature [Srikanth] - Yes, they will be addressed in follow up

Re: [x265] [PATCH] Edge Aware Quad Tree Establishment

2020-01-13 Thread Kavitha Sampath
Patch does not apply on current x265 tip, please fix. I am assuming the following will be sent as follow up patches 1. Edge aware quadtree feature for Rd levels 5, 6 2. Asm version of planecopy used for this feature Check comments below On Fri, Jan 10, 2020 at 5:46 PM wrote: > # HG changeset

Re: [x265] [PATCH] Edge Aware Quad Tree Establishment

2020-01-10 Thread Srikanth Kurapati
[Srikanth] rephrased. > There is no mention that this patch introduces rkip 2 only to rd0_4 > [Srikanth] The above is clear in the documentation. Adding the same to commit message. > + Default: 1, disabled when :option:`--tune grain` is used. >> + >> +.. option:: --edge-threshold

Re: [x265] [PATCH] Edge Aware Quad Tree Establishment

2020-01-07 Thread Kavitha Sampath
On Tue, Jan 7, 2020 at 8:16 AM wrote: > # HG changeset patch > # User Srikanth Kurapati > # Date 1577432829 -19800 > # Fri Dec 27 13:17:09 2019 +0530 > # Node ID 3d60a9a728b37f14cbb9cb2332a1aebf87e66334 > # Parent 19f6ed1659197aaa4bd78b69eb58139e879230d9 > Edge Aware Quad Tree

Re: [x265] [PATCH] Edge Aware Quad Tree Establishment

2020-01-07 Thread Srikanth Kurapati
Hi Kavitha, Please provide your feedback for the above patch. On Tue, Jan 7, 2020 at 8:16 AM wrote: > # HG changeset patch > # User Srikanth Kurapati > # Date 1577432829 -19800 > # Fri Dec 27 13:17:09 2019 +0530 > # Node ID 3d60a9a728b37f14cbb9cb2332a1aebf87e66334 > # Parent

Re: [x265] [PATCH] Edge Aware Quad Tree Establishment

2020-01-06 Thread Srikanth Kurapati
Please ignore this email. I will resend the final one immediately. On Mon, Jan 6, 2020 at 4:02 PM wrote: > # HG changeset patch > # User Srikanth Kurapati > # Date 1577432829 -19800 > # Fri Dec 27 13:17:09 2019 +0530 > # Node ID 99c608bd88538ca77556fed672bc6302625dfdf0 > # Parent

Re: [x265] [PATCH] Edge Aware Quad Tree Establishment

2020-01-06 Thread Srikanth Kurapati
Please ignore this email. On Mon, Jan 6, 2020 at 12:44 PM wrote: > # HG changeset patch > # User Srikanth Kurapati > # Date 1577432829 -19800 > # Fri Dec 27 13:17:09 2019 +0530 > # Node ID 27d66318e16e7f522f2d01067629cd9f24c07f66 > # Parent 19f6ed1659197aaa4bd78b69eb58139e879230d9 > Edge