Re: [X2Go-Dev] Bug#522: X2Go issue (in src:x2goclient) has been marked as pending for release

2014-06-29 Thread Mike Gabriel
Hi Alex, On So 29 Jun 2014 20:02:57 CEST, Mihai Moldovan wrote: Hi Alex, * On 27.06.2014 09:36 pm, Oleksandr Shneyder wrote: The list is never empty, it have at least 1. argument - it is always executable name. args will be empty on OS X and Linux, if no argument has been passed to x2gocli

Re: [X2Go-Dev] Bug#522: X2Go issue (in src:x2goclient) has been marked as pending for release

2014-06-29 Thread Mihai Moldovan
Hi Alex, * On 27.06.2014 09:36 pm, Oleksandr Shneyder wrote: > The list is never empty, it have at least 1. argument - it is always > executable name. args will be empty on OS X and Linux, if no argument has been passed to x2goclient.exe. > I'll leave my solution here, because in a case of linux

Re: [X2Go-Dev] Bug#522: X2Go issue (in src:x2goclient) has been marked as pending for release

2014-06-27 Thread Oleksandr Shneyder
Hello Mihai, The list is never empty, it have at least 1. argument - it is always executable name. I'll leave my solution here, because in a case of linux or mac if x2goclient started without arguments list don't need to be initialized. Actually, I can change argc<=1 to argc ==1 but in this case i

Re: [X2Go-Dev] Bug#522: X2Go issue (in src:x2goclient) has been marked as pending for release

2014-06-27 Thread Oleksandr Shneyder
Hallo Mike, this is how x2goclient know if it running as parent or child process. Am 27.06.2014 15:38, schrieb Michael DePaulo: > Alex, > > Thank you for fixing this quickly. I can confirm it is fixed in the > nightly build: > http://code.x2go.org/releases/binary-win32/x2goclient/heuler/mingw32-

Re: [X2Go-Dev] Bug#522: X2Go issue (in src:x2goclient) has been marked as pending for release

2014-06-27 Thread Mihai Moldovan
I would so reject this patch. It's logically flawed. First: 106 QStringList args; 107 if ( argc > 1 ) 108 args=app.arguments(); Later: 154 if(argc <=1) 155 { 156 args=app.arguments(); 157 } Remove those two occurrences and use: 106 QStringL

Re: [X2Go-Dev] Bug#522: X2Go issue (in src:x2goclient) has been marked as pending for release

2014-06-27 Thread Michael DePaulo
Alex, Thank you for fixing this quickly. I can confirm it is fixed in the nightly build: http://code.x2go.org/releases/binary-win32/x2goclient/heuler/mingw32-4.4/qt-4.8/x2goclient-4.0.2.1-2014.06.27-setup.exe However, Ionic and I were taking a look at the code last night, and we did not understan

[X2Go-Dev] Bug#522: X2Go issue (in src:x2goclient) has been marked as pending for release

2014-06-27 Thread Oleksandr Shneyder
tag #522 pending fixed #522 4.0.2.1 thanks Hello, X2Go issue #522 (src:x2goclient) reported by you has been fixed in X2Go Git. You can see the changelog below, and you can check the diff of the fix at: http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=093543e The issue will most l