Re: [XBoard-devel] [Patch] Fix cairo segfault when playing shogi

2018-02-09 Thread H.G. Muller
Thanks for tracking this down, but the proposed fix doesn't completely solve all out-of-bounds accesses. The problem here is that BlankSquare is also called with square_color = 2, for blacking out a square. And in that case it should never involve any texture bitmap. So the fundamentally corre

Re: [XBoard-devel] [Patch] Fix cairo segfault when playing shogi

2018-02-05 Thread Adrian Petrescu
Thank you! This fixes the crash I reported back in December :) On Sun, Feb 4, 2018 at 3:24 PM, Justin Vreeland wrote: > There's an off-by-one error caused when selecting square colors for held > pieces > that frequently causes pngBoardBitmap to access a value past it's bounds, > which > also is