Re: [xcat-user] Change breaking backword compatibility
On 12/08/15 16:28, Yuan Y Bai wrote: Christopher, Hi there, Thanks for your comments. My pleasure! I add old flag '-m' to avoid breaking backwards compatibility. Thanks for that, very much appreciated. All the best, Chris -- Christopher SamuelSenior Systems Administrator VLSCI - Victorian Life Sciences Computation Initiative Email: sam...@unimelb.edu.au Phone: +61 (0)3 903 55545 http://www.vlsci.org.au/ http://twitter.com/vlsci -- ___ xCAT-user mailing list xCAT-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xcat-user
Re: [xcat-user] Change breaking backword compatibility
Christopher, Thanks for your comments. I add old flag '-m' to avoid breaking backwards compatibility. Best Regards -- Yuan Bai (白媛) CSTL HPC System Management Development Tel:86-10-82451401 E-mail: by...@cn.ibm.com Address: IBM ZGC Campus. Ring Building 28, ZhongGuanCun Software Park,No.8 Dong Bei Wang West Road, Haidian District, Beijing P.R.China 100193 IBM环宇大厦 北京市海淀区东北旺西路8号，中关村软件园28号楼 邮编:100193 | | From: | | --| |Christopher Samuel sam...@unimelb.edu.au | --| | | To:| | --| |xCAT Users Mailing list xcat-user@lists.sourceforge.net | --| | | Date: | | --| |08/12/2015 01:10 PM | --| | | Subject: | | --| |Re: [xcat-user] Change breaking backword compatibility | --| Hiya, On 12/08/15 14:51, Yuan Y Bai wrote: It is ugly if support both old flag '-m' and new flag '-s'; Do you have important justification to keep old flag '-m'? Not breaking existing installations setups. It's good practice to mark options scheduled for removal as deprecated in documentation first, then provide warnings about impending removal when they are used, and only after that's been in place for a release or two commit the change to remove them. All the best, Chris -- Christopher SamuelSenior Systems Administrator VLSCI - Victorian Life Sciences Computation Initiative Email: sam...@unimelb.edu.au Phone: +61 (0)3 903 55545 http://www.vlsci.org.au/ http://twitter.com/vlsci -- ___ xCAT-user mailing list xCAT-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xcat-user -- ___ xCAT-user mailing list xCAT-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xcat-user
Re: [xcat-user] Change breaking backword compatibility
Samveen, Thanks for letting us know. We are trying to make bmcdiscover and switchdiscover use the same flags for consistentcy. But you are right, we should maintain backward compatibility. Yuan, Could you please make sure the bmcdiscover command accepts both -s and -m for methods. You can document -s, but -m should also work for backward compatibility. Thanks, Ling Gao Poughkeepsie Unix Development Lab IBM Systems and Technology Group Internal: T/L 293-5692 External: ling...@us.ibm.com, 845-433-5692 I never worry about the future. It comes soon enough. --- Albert Einstein From: Samveen ListReceipient list-u...@samveen.in To: xCAT xcat-user@lists.sourceforge.net Date: 08/11/2015 06:30 AM Subject:[xcat-user] Change breaking backword compatibility The change https://github.com/xcat2/xcat-core/commit/eefaaad91e263048d7c5be914f9ed456f57d0c3d changes the command line option of the bmcdicover command from `-m method` to `-s method`. This will break my scripts (and other automations) that use the bmcdiscover command. Please consider reverting the option back to `-m`. Regards, -- Samveen S. Gulati http://samveen.in The best-laid schemes o' mice an 'men Gang aft agley, An'lea'e us nought but grief an' pain, For promis'd joy! -- Robert Burns (The best laid plans of mice and men often go awry, and bring nothing but grief and pain instead of ..) -- ___ xCAT-user mailing list xCAT-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xcat-user -- ___ xCAT-user mailing list xCAT-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xcat-user
Re: [xcat-user] Change breaking backword compatibility
On 12/08/15 12:53, Yuan Y Bai wrote: Could you change your scripts to use `-s method` ? Is it not possible to also support the old flag too to avoid breaking backwards compatibility? All the best, Chris -- Christopher SamuelSenior Systems Administrator VLSCI - Victorian Life Sciences Computation Initiative Email: sam...@unimelb.edu.au Phone: +61 (0)3 903 55545 http://www.vlsci.org.au/ http://twitter.com/vlsci -- ___ xCAT-user mailing list xCAT-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xcat-user
Re: [xcat-user] Change breaking backword compatibility
Hiya, On 12/08/15 14:51, Yuan Y Bai wrote: It is ugly if support both old flag '-m' and new flag '-s'; Do you have important justification to keep old flag '-m'? Not breaking existing installations setups. It's good practice to mark options scheduled for removal as deprecated in documentation first, then provide warnings about impending removal when they are used, and only after that's been in place for a release or two commit the change to remove them. All the best, Chris -- Christopher SamuelSenior Systems Administrator VLSCI - Victorian Life Sciences Computation Initiative Email: sam...@unimelb.edu.au Phone: +61 (0)3 903 55545 http://www.vlsci.org.au/ http://twitter.com/vlsci -- ___ xCAT-user mailing list xCAT-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xcat-user
