Re: Specifying thumbnailers as a service

2008-09-04 Thread Philip Van Hoof
On Fri, 2008-08-29 at 20:14 +0200, Kevin Krammer wrote: On Friday 29 August 2008, Philip Van Hoof wrote: What do others think about having a signal like this signal name=Created arg type=as name=thumbnails / /signal I know that Create is annotated as async but the client might

Re: Specifying thumbnailers as a service

2008-09-01 Thread Philip Van Hoof
On Sat, 2008-08-30 at 01:12 +0200, David Faure wrote: On Friday 29 August 2008, Brian J. Tarricone wrote: [cut] This sounds overly complicated to me. Now you're assuming that any app that wants to load thumbnails is also capable of figuring out the mime-type of the file it wants to

Re: Specifying thumbnailers as a service

2008-09-01 Thread Lubos Lunak
On Friday 29 of August 2008, Philip Van Hoof wrote: Hi there, Not only filemanagers want to request the creation of a thumbnail. For example desktop search engines like Strigi and Tracker want to schedule the creation of thumbnails for certain of the contents that they find, ahead of time

Re: Specifying thumbnailers as a service

2008-09-01 Thread Philip Van Hoof
On Mon, 2008-09-01 at 10:25 +0200, Lubos Lunak wrote: On Friday 29 of August 2008, Philip Van Hoof wrote: Is this API also intended to be used by filemanagers? It appears to have several performance problems for use in those: - there is no notification about progress (i.e. when a

Re: Specifying thumbnailers as a service

2008-09-01 Thread Lubos Lunak
On Monday 01 of September 2008, Philip Van Hoof wrote: On Mon, 2008-09-01 at 10:25 +0200, Lubos Lunak wrote: On Friday 29 of August 2008, Philip Van Hoof wrote: Is this API also intended to be used by filemanagers? It appears to have several performance problems for use in those: -

Re: Specifying thumbnailers as a service

2008-09-01 Thread Philip Van Hoof
On Mon, 2008-09-01 at 13:59 +0200, Lubos Lunak wrote: I think canceling is overkill. Making a thumbnail doesn't take longer than a minute (and a minute is an extreme case). Users don't cancel that. It wasn't meant for a user. If the user scrolls the view, then the visible files should

Re: Specifying thumbnailers as a service

2008-09-01 Thread Brian J. Tarricone
On Mon, 01 Sep 2008 10:49:31 +0200 Philip Van Hoof wrote: I think canceling is overkill. Making a thumbnail doesn't take longer than a minute (and a minute is an extreme case). Users don't cancel that. Strongly disagree. I have a laptop, and say I'm on battery power. If I'm scrolling

Re: Specifying thumbnailers as a service

2008-09-01 Thread Philip Van Hoof
On Mon, 2008-09-01 at 09:53 -0700, Brian J. Tarricone wrote: On Mon, 01 Sep 2008 10:49:31 +0200 Philip Van Hoof wrote: I think canceling is overkill. Making a thumbnail doesn't take longer than a minute (and a minute is an extreme case). Users don't cancel that. Strongly disagree. I

Re: Specifying thumbnailers as a service

2008-09-01 Thread Brian J. Tarricone
On Tue, 02 Sep 2008 00:09:53 +0200 Philip Van Hoof wrote: On Mon, 2008-09-01 at 09:53 -0700, Brian J. Tarricone wrote: On Mon, 01 Sep 2008 10:49:31 +0200 Philip Van Hoof wrote: I think canceling is overkill. Making a thumbnail doesn't take longer than a minute (and a minute is an

Re: Specifying thumbnailers as a service

2008-08-29 Thread Bastien Nocera
On Fri, 2008-08-29 at 11:25 +0200, Philip Van Hoof wrote: arg type=i name=size_x direction=in / arg type=i name=size_y direction=in / In the libgnomeui API, you only set one of those, and aspect ratio is preserved. The size passed is the maximum width and height.

Re: Specifying thumbnailers as a service

2008-08-29 Thread Adrien BUSTANY
Bastien Nocera a écrit : On Fri, 2008-08-29 at 11:25 +0200, Philip Van Hoof wrote: arg type=i name=size_x direction=in / arg type=i name=size_y direction=in / In the libgnomeui API, you only set one of those, and aspect ratio is preserved. The size passed is the maximum

Re: Specifying thumbnailers as a service

2008-08-29 Thread Bastien Nocera
On Fri, 2008-08-29 at 12:14 +0200, Adrien BUSTANY wrote: Bastien Nocera a écrit : On Fri, 2008-08-29 at 11:25 +0200, Philip Van Hoof wrote: arg type=i name=size_x direction=in / arg type=i name=size_y direction=in / In the libgnomeui API, you only set one of

Re: Specifying thumbnailers as a service

2008-08-29 Thread Rob Taylor
Philip Van Hoof wrote: Hi there, Not only filemanagers want to request the creation of a thumbnail. For example desktop search engines like Strigi and Tracker want to schedule the creation of thumbnails for certain of the contents that they find, ahead of time (not sure about Strigi, as one

Re: Specifying thumbnailers as a service

2008-08-29 Thread Adrien BUSTANY
Bastien Nocera a écrit : On Fri, 2008-08-29 at 12:14 +0200, Adrien BUSTANY wrote: Bastien Nocera a écrit : On Fri, 2008-08-29 at 11:25 +0200, Philip Van Hoof wrote: arg type=i name=size_x direction=in / arg type=i name=size_y direction=in / In the

Re: Specifying thumbnailers as a service

2008-08-29 Thread Philip Van Hoof
On Fri, 2008-08-29 at 11:22 +0100, Rob Taylor wrote: I wonder if it'd make sense to allow multiple services to provide thumbnailing for different mime types. This could be done by having the thumbnailing service(s) register bus names of the form org.freedesktop.thumbnailer.mime type, and

Re: Specifying thumbnailers as a service

2008-08-29 Thread Philip Van Hoof
On Fri, 2008-08-29 at 11:03 +0100, Bastien Nocera wrote: On Fri, 2008-08-29 at 11:25 +0200, Philip Van Hoof wrote: arg type=i name=size_x direction=in / arg type=i name=size_y direction=in / In the libgnomeui API, you only set one of those, and aspect ratio is preserved.

Re: Specifying thumbnailers as a service

2008-08-29 Thread Philip Van Hoof
On Fri, 2008-08-29 at 13:59 +0200, Philip Van Hoof wrote: On Fri, 2008-08-29 at 11:03 +0100, Bastien Nocera wrote: On Fri, 2008-08-29 at 11:25 +0200, Philip Van Hoof wrote: arg type=i name=size_x direction=in / arg type=i name=size_y direction=in / In the libgnomeui

Re: Specifying thumbnailers as a service

2008-08-29 Thread David Zeuthen
On Fri, 2008-08-29 at 14:34 +0200, Philip Van Hoof wrote: interface name=org.freedesktop.Thumbnailer.[mime-part] It seems odd to include the mime type in the _interface_ name; shouldn't this be generic instead? (Also keep in mind that both object paths and interface names in D-Bus are

Re: Specifying thumbnailers as a service

2008-08-29 Thread Kevin Krammer
On Friday 29 August 2008, Philip Van Hoof wrote: [snip] That, combined with Rob Taylor's proposal, brings me to this DBus API: node name=/ foreach ([mime-part] in supported_mime_parts) { interface name=org.freedesktop.Thumbnailer.[mime-part] I am not sure you need a separate interface