RE: [Xdoclet-devel] xrai

2002-11-12 Thread Ara Abrahamian
Silly mistake :-) Corrected. Ara. > -Original Message- > From: Konstantin Priblouda [mailto:kpriblouda@;yahoo.com] > Sent: Tuesday, November 12, 2002 10:34 PM > To: Ara Abrahamian > Cc: [EMAIL PROTECTED] > Subject: RE: [Xdoclet-devel] xrai > > > --- Ara A

RE: [Xdoclet-devel] xrai

2002-11-12 Thread Konstantin Priblouda
--- Ara Abrahamian <[EMAIL PROTECTED]> wrote: > See the target/test-report folder. What's there? --%< Testsuite: xdoclet.xrai.ant.TestAttributesTask Tests run: 1, Failures: 1, Errors: 0, Time elapsed: 0.345 sec Testcase: testSerializationDeserialization took 0.212 sec FAIL

RE: [Xdoclet-devel] xrai

2002-11-12 Thread Ara Abrahamian
See the target/test-report folder. What's there? Ara. > -Original Message- > From: Konstantin Priblouda [mailto:kpriblouda@;yahoo.com] > Sent: Tuesday, November 12, 2002 10:18 PM > To: Ara Abrahamian > Cc: [EMAIL PROTECTED] > Subject: RE: [Xdoclet-devel] xrai >

RE: [Xdoclet-devel] xrai

2002-11-12 Thread Konstantin Priblouda
--- Ara Abrahamian <[EMAIL PROTECTED]> wrote: > > I haven't had time to look at it in detail, but I > have some comments > about > > style: > > 1) The test class is named TestAttributesTask. I > believe > > AttributesTaskTest > > is a more common naming convention for JUnit. > > OK. I'll change i

RE: [Xdoclet-devel] xrai

2002-11-12 Thread Ara Abrahamian
> I haven't had time to look at it in detail, but I have some comments about > style: > 1) The test class is named TestAttributesTask. I believe > AttributesTaskTest > is a more common naming convention for JUnit. OK. I'll change it. > 3) The AttributeSerializerTask seems to have a lot of logic.

Re: [Xdoclet-devel] xrai

2002-11-12 Thread Dmitri Colebatch
> We can use PMD to enforce this convention... > ( or at least to croak loud ) yeah... I suppose I was just letting my mind think of further steps (o: cheers dim --- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://th

Re: [Xdoclet-devel] xrai

2002-11-12 Thread Konstantin Priblouda
--- Dmitri Colebatch <[EMAIL PROTECTED]> wrote: > > It's not extension, it's coding convention... > > I find this is usefull, because you can easily > tell > > class members from method locals. > > yeah, but we run pretty to enforce formatting, it > would be feasible to have > something that enfo

Re: [Xdoclet-devel] xrai

2002-11-12 Thread Dmitri Colebatch
w of (o: cheers dim > > Aslak > > Dmitri Colebatch wrote: > > > From: "Dmitri Colebatch" <[EMAIL PROTECTED]> > > To: <[EMAIL PROTECTED]>, > > "Aslak_Hellesoy" <[EMAIL PROTECTED]> > > Subject: Re: [Xdoclet-devel] xrai >

Re: [Xdoclet-devel] xrai

2002-11-12 Thread Aslak Hellesøy
Tree comparator? Pretty? You lost me completely on this one Dim. Did you hit reply on the wrong mail? Aslak Dmitri Colebatch wrote: From: "Dmitri Colebatch" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]>, "Aslak_Hellesoy" <[EMAIL PROTECTED]> Subject: Re:

Re: [Xdoclet-devel] xrai

2002-11-12 Thread Dmitri Colebatch
build yes? obviously a > > hefty extension (o: but really thats all it is... > > > > > > > > - Original Message - > > From: "Konstantin Priblouda" <[EMAIL PROTECTED]> > > To: "Aslak_Hellesoy" <[EMAIL PROTECTED]> >

Re: [Xdoclet-devel] xrai

2002-11-12 Thread Konstantin Priblouda
OTECTED]> > Cc: <[EMAIL PROTECTED]> > Sent: Tuesday, November 12, 2002 9:17 PM > Subject: RE: [Xdoclet-devel] xrai > > > > > > > As you've seen (in xjavadoc) I'm using > > > _underscorePrefixedVariableNames. > > > This is to be abl

Re: [Xdoclet-devel] xrai

2002-11-12 Thread Dmitri Colebatch
ROTECTED]> To: "Aslak_Hellesoy" <[EMAIL PROTECTED]> Cc: <[EMAIL PROTECTED]> Sent: Tuesday, November 12, 2002 9:17 PM Subject: RE: [Xdoclet-devel] xrai > > > As you've seen (in xjavadoc) I'm using > > _underscorePrefixedVariableNames. > > This is t

RE: [Xdoclet-devel] xrai

2002-11-12 Thread Konstantin Priblouda
> As you've seen (in xjavadoc) I'm using > _underscorePrefixedVariableNames. > This is to be able to distinguish class members from > method parameters and > local variables. Do you think that's a good or bad > convention? We should > agree on a coding convention. +1000 This is really good conven

RE: [Xdoclet-devel] xrai

2002-11-11 Thread Aslak Hellesoy
Nice work Ara! I have been asking for a feature in Nanning, but now that XRAI is here, I'll pass it over to you ;-) http://tinyurl.com/2mcj XRAI comes in very handy right now. It will play an important role in the new xdoclet2 core I think! I haven't had time to look at it in detail, but I have