Re: [Xen-API] [PATCH v4 6/7] Add guide on Communication Best Practice

2020-01-15 Thread George Dunlap
On 1/15/20 12:22 PM, Lars Kurth wrote: > @George, @Ian: let me know whether this is better and addresses your > concerns This looks good to me. One side note: > The way how a reviewer expresses feedback, has a big impact on how the author "The way how X happens" isn't grammatically correct;

Re: [Xen-API] [PATCH v4 6/7] Add guide on Communication Best Practice

2020-01-15 Thread Lars Kurth
On 15/01/2020, 10:47, "George Dunlap" wrote: On 1/13/20 9:21 PM, Lars Kurth wrote: > > > On 13/01/2020, 19:54, "George Dunlap" wrote: > > > > On Dec 30, 2019, at 7:32 PM, Lars Kurth wrote: > > > > From: Lars Kurth > > >

Re: [Xen-API] [PATCH v4 6/7] Add guide on Communication Best Practice

2020-01-15 Thread George Dunlap
On 1/13/20 9:21 PM, Lars Kurth wrote: > > > On 13/01/2020, 19:54, "George Dunlap" wrote: > > > > On Dec 30, 2019, at 7:32 PM, Lars Kurth > wrote: > > > > From: Lars Kurth > > > > This guide covers the bulk on Best Practice related to code review > > It

Re: [Xen-API] [PATCH v4 6/7] Add guide on Communication Best Practice

2020-01-13 Thread Lars Kurth
On 13/01/2020, 19:54, "George Dunlap" wrote: > On Dec 30, 2019, at 7:32 PM, Lars Kurth wrote: > > From: Lars Kurth > > This guide covers the bulk on Best Practice related to code review > It primarily focusses on code review interactions > It also covers

Re: [Xen-API] [PATCH v4 6/7] Add guide on Communication Best Practice

2020-01-13 Thread George Dunlap
> On Dec 30, 2019, at 7:32 PM, Lars Kurth wrote: > > From: Lars Kurth > > This guide covers the bulk on Best Practice related to code review > It primarily focusses on code review interactions > It also covers how to deal with Misunderstandings and Cultural > Differences > > +### Avoid