Re: [Xen-devel] [PATCH v3 6/7] libxl/libxc: Move libxl_get_numainfo()'s hypercall buffer management to libxc

2015-02-10 Thread Boris Ostrovsky
On 02/10/2015 06:45 AM, Andrew Cooper wrote: -memcpy(sysctl.u.numainfo, put_info, sizeof(*put_info)); +sysctl.u.numainfo.max_node_index = *max_nodes - 1; As you have you have already changed these hypercalls, can we fix the length handling so it doesn't require +1 or -1. Xen

Re: [Xen-devel] [GIT PULL] (xen) for-jens-3.20 for v3.20 Xen blk driver updates

2015-02-10 Thread Jens Axboe
On 02/10/2015 05:58 AM, Roger Pau Monné wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello Jens, There are 3 fixes for Xen blk drivers. One adds myself as a maintainer (together with Konrad). There's also one to improve compatibility with older xen-blkfront versions that did not

Re: [Xen-devel] dom0 kernel - irq nobody cared ... the continuing saga ..

2015-02-10 Thread Sander Eikelenboom
Tuesday, February 10, 2015, 2:26:43 PM, you wrote: On 10.02.15 at 14:07, li...@eikelenboom.it wrote: Tuesday, February 10, 2015, 10:35:36 AM, you wrote: On 10.02.15 at 10:19, li...@eikelenboom.it wrote: I would have thought that xen-pciback would install an interrupt handler here too when a

Re: [Xen-devel] [PATCH RFC V2 3/5] libxl: add pvusb API

2015-02-10 Thread Jürgen Groß
Just found other issues: On 01/19/2015 09:28 AM, Chunyan Liu wrote: Add pvusb APIs, including: - attach/detach (create/destroy) virtual usb controller. - attach/detach usb device - list assignable usb devices in host - some other helper functions Signed-off-by: Chunyan Liu

Re: [Xen-devel] dom0 kernel - irq nobody cared ... the continuing saga ..

2015-02-10 Thread Konrad Rzeszutek Wilk
On Tue, Feb 10, 2015 at 04:35:47PM +0100, Sander Eikelenboom wrote: Tuesday, February 10, 2015, 2:26:43 PM, you wrote: On 10.02.15 at 14:07, li...@eikelenboom.it wrote: Tuesday, February 10, 2015, 10:35:36 AM, you wrote: On 10.02.15 at 10:19, li...@eikelenboom.it wrote: I would have

Re: [Xen-devel] [GIT PULL] (xen) for-jens-3.20 for v3.20 Xen blk driver updates

2015-02-10 Thread Jens Axboe
On 02/10/2015 09:10 AM, David Vrabel wrote: On 10/02/15 15:27, Jens Axboe wrote: On 02/10/2015 05:58 AM, Roger Pau Monné wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello Jens, There are 3 fixes for Xen blk drivers. One adds myself as a maintainer (together with Konrad). There's

Re: [Xen-devel] [GIT PULL] (xen) for-jens-3.20 for v3.20 Xen blk driver updates

2015-02-10 Thread David Vrabel
On 10/02/15 15:27, Jens Axboe wrote: On 02/10/2015 05:58 AM, Roger Pau Monné wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello Jens, There are 3 fixes for Xen blk drivers. One adds myself as a maintainer (together with Konrad). There's also one to improve compatibility with older

Re: [Xen-devel] [PATCH v3 4/7] sysctl: Add sysctl interface for querying PCI topology

2015-02-10 Thread Andrew Cooper
On 10/02/15 14:45, Boris Ostrovsky wrote: On 02/10/2015 06:13 AM, Andrew Cooper wrote: On 09/02/15 20:04, Boris Ostrovsky wrote: Signed-off-by: Boris Ostrovsky boris.ostrov...@oracle.com --- xen/common/sysctl.c | 73 +++

Re: [Xen-devel] [PATCH v3 4/7] sysctl: Add sysctl interface for querying PCI topology

2015-02-10 Thread Boris Ostrovsky
On 02/10/2015 05:26 AM, Robert Elz wrote: Date:Mon, 9 Feb 2015 15:04:32 -0500 From:Boris Ostrovsky boris.ostrov...@oracle.com Message-ID: 1423512275-6531-5-git-send-email-boris.ostrov...@oracle.com | +num_devs = ti-num_devs - ti-first_dev; | +

Re: [Xen-devel] [PATCH] x86 spinlock: Fix memory corruption on completing completions

2015-02-10 Thread Oleg Nesterov
On 02/10, Denys Vlasenko wrote: # define HEAD_MASK (TICKET_SLOWPATH_FLAG-1) ... unlock_again: val = xadd((lock-ticket.head_tail, TICKET_LOCK_INC); if (unlikely(!(val HEAD_MASK))) { /* overflow. we inadvertently incremented the tail word. * tail's lsb is TICKET_SLOWPATH_FLAG.

Re: [Xen-devel] [PATCH v3 1/7] x86/numa: Make use of NUMA_NO_NODE consistent

2015-02-10 Thread Boris Ostrovsky
On 02/10/2015 06:39 AM, Jan Beulich wrote: On 09.02.15 at 21:04, boris.ostrov...@oracle.com wrote: --- a/xen/include/asm-x86/numa.h +++ b/xen/include/asm-x86/numa.h @@ -21,7 +21,7 @@ struct node { extern int compute_hash_shift(struct node *nodes, int numnodes,

[Xen-devel] [RFC] Tweaking the release process for Xen 4.6

2015-02-10 Thread Wei Liu
Hi, all With Xen 4.5 released on Jan 14 and the open of Xen 4.6 (commit 0082626f35, Jan 6), we are now one month into 4.6 development window. This is an email to kick off a discussion with regard to our release process.The goal is to create a smoother workflow for everyone involved. Emails to

Re: [Xen-devel] [PATCH] tools/hotplug: introduce XENSTORED_ARGS= in sysconfig file.

2015-02-10 Thread Olaf Hering
Ping? On Tue, Feb 03, Olaf Hering wrote: It is already used in the runlevel script and the service file. It is supposed to replace XENSTORED_TRACE= boolean, which cant be easily supported in the xenstored.service file. Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian Jackson

Re: [Xen-devel] [PATCH v3 5/7] libxl/libxc: Move libxl_get_cpu_topology()'s hypercall buffer management to libxc

2015-02-10 Thread Boris Ostrovsky
On 02/10/2015 06:23 AM, Andrew Cooper wrote: diff --git a/tools/libxc/include/xenctrl.h b/tools/libxc/include/xenctrl.h index 0cb6743..d94571d 100644 --- a/tools/libxc/include/xenctrl.h +++ b/tools/libxc/include/xenctrl.h @@ -1226,7 +1226,7 @@ int xc_readconsolering(xc_interface *xch, int

Re: [Xen-devel] dom0 kernel - irq nobody cared ... the continuing saga ..

2015-02-10 Thread Konrad Rzeszutek Wilk
On Tue, Feb 10, 2015 at 02:07:05PM +0100, Sander Eikelenboom wrote: Tuesday, February 10, 2015, 10:35:36 AM, you wrote: On 10.02.15 at 10:19, li...@eikelenboom.it wrote: Coming back to the /proc/interrupts output you posted earlier: /proc/interrupts shows the high count:

Re: [Xen-devel] [PATCH] x86 spinlock: Fix memory corruption on completing completions

2015-02-10 Thread Jeremy Fitzhardinge
On 02/10/2015 05:26 AM, Oleg Nesterov wrote: On 02/10, Raghavendra K T wrote: On 02/10/2015 06:23 AM, Linus Torvalds wrote: add_smp(lock-tickets.head, TICKET_LOCK_INC); if (READ_ONCE(lock-tickets.tail) TICKET_SLOWPATH_FLAG) .. into something like val =

[Xen-devel] [libvirt test] 34420: tolerable all pass - PUSHED

2015-02-10 Thread xen . org
flight 34420 libvirt real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/34420/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt 10 migrate-support-checkfail never pass test-armhf-armhf-libvirt 10

Re: [Xen-devel] [PATCH v4 2/2] x86, arm, platform, xen, kconfig: add xen defconfig helper

2015-02-10 Thread David Rientjes
On Tue, 10 Feb 2015, Luis R. Rodriguez wrote: From: Luis R. Rodriguez mcg...@suse.com This lets you build a kernel which can support xen dom0 or xen guests by just using: make xenconfig on both x86 and arm64 kernels. This also splits out the options which are available currently to

Re: [Xen-devel] [PATCH 02/29] libxl: Comment cleanups

2015-02-10 Thread Hongyang Yang
在 02/11/2015 04:09 AM, Ian Jackson 写道: * Add two comments in libxl_remus_disk_drbd documenting buggy handling of the hotplug script exit status. * Add a section heading for async exec in libxl_aoutils.c * Mention the right function name (libxl__ev_child_fork, not libxl__ev_fork) in

Re: [Xen-devel] [Qemu-devel] [v2][PATCH] libxl: add one machine property to support IGD GFX passthrough

2015-02-10 Thread Chen, Tiejun
On 2015/2/9 19:05, Ian Campbell wrote: On Mon, 2015-02-09 at 14:28 +0800, Chen, Tiejun wrote: What about this? I've not read the code in detail,since I'm travelling but from a quick glance it looks to be implementing the sort of thing I meant, thanks. Thanks for your time. A couple of

Re: [Xen-devel] [PATCH v3 12/27] ArmVirtualizationPkg: Xen/PV relocatable platformlib instance

2015-02-10 Thread Olivier Martin
On 03/02/15 19:19, Ard Biesheuvel wrote: Add a ArmPlatformLib instance that can deal with the self relocation and truly dynamic discovery of system RAM base and size. Contributed-under: TianoCore Contribution Agreement 1.0 Acked-by: Laszlo Ersek ler...@redhat.com Signed-off-by: Ard Biesheuvel

[Xen-devel] [Block dev] : Qemu block ide_dma_read call routine

2015-02-10 Thread Shailesh Kumar
Hi, I am implementing read equivalent routine in qemu. Can some one help me understand control flow of the qemu read/write implementation. I am using xen-4.2.0 and qemu-1.6.1 My requirement is simple: I have a 1024*1024 buffer already filled with some useful data. Now when windows (my

Re: [Xen-devel] [PATCH v3] libxl: Wait for ballooning if free memory is increasing

2015-02-10 Thread Mike Latimer
On Thursday, February 05, 2015 12:45:53 PM Ian Campbell wrote: On Mon, 2015-02-02 at 08:17 -0700, Mike Latimer wrote: On Monday, February 02, 2015 02:35:39 PM Ian Campbell wrote: On Fri, 2015-01-30 at 14:01 -0700, Mike Latimer wrote: During domain startup, all required memory ballooning

[Xen-devel] [linux-next test] 34382: regressions - FAIL

2015-02-10 Thread xen . org
flight 34382 linux-next real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/34382/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-win7-amd64 5 xen-boot fail REGR. vs. 34127

Re: [Xen-devel] [PATCH V4 01/13] xen/mem_event: Cleanup of mem_event structures

2015-02-10 Thread Tamas K Lengyel
On Tue, Feb 10, 2015 at 5:17 PM, Jan Beulich jbeul...@suse.com wrote: Tamas K Lengyel tamas.leng...@zentific.com 02/10/15 2:51 PM On Tue, Feb 10, 2015 at 1:52 PM, Jan Beulich jbeul...@suse.com wrote: On 09.02.15 at 19:53, tamas.leng...@zentific.com wrote: @@ -598,6 +600,12 @@ int

Re: [Xen-devel] [PATCH V4 01/13] xen/mem_event: Cleanup of mem_event structures

2015-02-10 Thread Tamas K Lengyel
On Tue, Feb 10, 2015 at 6:39 PM, Jan Beulich jbeul...@suse.com wrote: Tamas K Lengyel tamas.leng...@zentific.com 02/10/15 5:38 PM On Tue, Feb 10, 2015 at 5:17 PM, Jan Beulich jbeul...@suse.com wrote: Tamas K Lengyel tamas.leng...@zentific.com 02/10/15 2:51 PM On Tue, Feb 10, 2015 at 1:52 PM,

[Xen-devel] [PATCH 0/3] Fixes to NMI shootdown

2015-02-10 Thread Andrew Cooper
This series fixes an issue introduced by c/s 7dd3b06ff On my testbox I can observe the cpu which doesn't get shot down to still be executing after the crash kernel has finished running. [ 25.806178] sd 2:0:0:0: [sda] Synchronizing SCSI cache [ 25.812038] Restarting system. [ 25.815121]

Re: [Xen-devel] dom0 kernel - irq nobody cared ... the continuing saga ..

2015-02-10 Thread Sander Eikelenboom
Tuesday, February 10, 2015, 5:22:16 PM, you wrote: Sander Eikelenboom li...@eikelenboom.it 02/10/15 5:01 PM Tuesday, February 10, 2015, 2:26:43 PM, you wrote: On 10.02.15 at 14:07, li...@eikelenboom.it wrote: I don't really know how this code is supposed to work (we don't use it in our

Re: [Xen-devel] dom0 kernel - irq nobody cared ... the continuing saga ..

2015-02-10 Thread Jan Beulich
Sander Eikelenboom li...@eikelenboom.it 02/10/15 6:30 PM Tuesday, February 10, 2015, 5:22:16 PM, you wrote: Sander Eikelenboom li...@eikelenboom.it 02/10/15 5:01 PM I haven't checked the call chain of xen_pcibk_do_op .. but that could be a side effect of libxl not imitating pci-front good

Re: [Xen-devel] dom0 kernel - irq nobody cared ... the continuing saga ..

2015-02-10 Thread Jan Beulich
Sander Eikelenboom li...@eikelenboom.it 02/10/15 5:01 PM Tuesday, February 10, 2015, 2:26:43 PM, you wrote: On 10.02.15 at 14:07, li...@eikelenboom.it wrote: I don't really know how this code is supposed to work (we don't use it in our kernels), but it seems the more interesting question is

Re: [Xen-devel] [RFC] Tweaking the release process for Xen 4.6

2015-02-10 Thread George Dunlap
On Tue, Feb 10, 2015 at 11:47 AM, Dario Faggioli dario.faggi...@citrix.com wrote: On Tue, 2015-02-10 at 11:11 -0500, George Dunlap wrote: On Tue, Feb 10, 2015 at 10:04 AM, Wei Liu wei.l...@citrix.com wrote: # Scrapping soft freeze I think existing model (development + freeze) works well

[Xen-devel] [PATCH 3/3] x86/nmi: Fix shootdown of pcpus running in VMX non-root mode

2015-02-10 Thread Andrew Cooper
c/s 7dd3b06ff vmx: fix handling of NMI VMEXIT fixed one issue but inadvertently introduced a regression when it came to the NMI shootdown. The shootdown code worked by patching vector 2 in each IDT, but the introduced direct call to do_nmi() bypassed this. Instead of patching each IDT, take a

[Xen-devel] [PATCH 2/3] x86/traps: Use write_atomic() when updating potentially-live descriptors

2015-02-10 Thread Andrew Cooper
Signed-off-by: Andrew Cooper andrew.coop...@citrix.com CC: Jan Beulich jbeul...@suse.com CC: Tim Deegan t...@xen.org --- atomic.h currently can't be included in either location because of dependency issues. As this is part of a bugfix series which needs backporting, I opted to opencode

Re: [Xen-devel] [PATCH v3 4/7] sysctl: Add sysctl interface for querying PCI topology

2015-02-10 Thread Jan Beulich
Boris Ostrovsky boris.ostrov...@oracle.com 02/10/15 4:07 PM On 02/10/2015 09:54 AM, Andrew Cooper wrote: copy_to/from_guest() is not expensive. It is a straight memcpy with an extable guards for pagefaults. True, but still why do this inside a loop? xmalloc() of less than a page is not that

Re: [Xen-devel] [PATCH v3 4/7] sysctl: Add sysctl interface for querying PCI topology

2015-02-10 Thread Andrew Cooper
On 10/02/15 16:30, Jan Beulich wrote: Boris Ostrovsky boris.ostrov...@oracle.com 02/10/15 4:07 PM On 02/10/2015 09:54 AM, Andrew Cooper wrote: copy_to/from_guest() is not expensive. It is a straight memcpy with an extable guards for pagefaults. True, but still why do this inside a loop?

Re: [Xen-devel] [PATCH V4 01/13] xen/mem_event: Cleanup of mem_event structures

2015-02-10 Thread Jan Beulich
Tamas K Lengyel tamas.leng...@zentific.com 02/10/15 2:51 PM On Tue, Feb 10, 2015 at 1:52 PM, Jan Beulich jbeul...@suse.com wrote: On 09.02.15 at 19:53, tamas.leng...@zentific.com wrote: @@ -598,6 +600,12 @@ int mem_sharing_sharing_resume(struct domain *d) { struct vcpu *v; +

Re: [Xen-devel] [RFC] Tweaking the release process for Xen 4.6

2015-02-10 Thread Dario Faggioli
On Tue, 2015-02-10 at 11:11 -0500, George Dunlap wrote: On Tue, Feb 10, 2015 at 10:04 AM, Wei Liu wei.l...@citrix.com wrote: # Scrapping soft freeze I think existing model (development + freeze) works well in general, but it would be better if we can shorten the time frame a bit, or try

Re: [Xen-devel] [PATCH V4 01/13] xen/mem_event: Cleanup of mem_event structures

2015-02-10 Thread Jan Beulich
Tamas K Lengyel tamas.leng...@zentific.com 02/10/15 5:38 PM On Tue, Feb 10, 2015 at 5:17 PM, Jan Beulich jbeul...@suse.com wrote: Tamas K Lengyel tamas.leng...@zentific.com 02/10/15 2:51 PM On Tue, Feb 10, 2015 at 1:52 PM, Jan Beulich jbeul...@suse.com wrote: On 09.02.15 at 19:53,

Re: [Xen-devel] [PATCH] xen/arm: allow console=hvc0 to be omitted for guests

2015-02-10 Thread Ian Campbell
On Tue, 2015-02-10 at 15:51 +0800, Ard Biesheuvel wrote: FWIW on x86 this doesn't depend on console_set_on_cmdline, does it need to here? I didn't check the code, but it seems inappropriate to add a preferred console implicitly if the user has set 'console=' on the command line. I had

Re: [Xen-devel] [PATCH v3 11/27] ArmVirtualizationPkg: allow patchable PCD for FV and DT base addresses

2015-02-10 Thread Olivier Martin
Reviewed-By: Olivier Martin olivier.mar...@arm.com From: Ard Biesheuvel [ard.biesheu...@linaro.org] Sent: 03 February 2015 19:19 To: edk2-de...@lists.sourceforge.net; ler...@redhat.com; Olivier Martin; roy.fr...@linaro.org; leif.lindh...@linaro.org;

Re: [Xen-devel] dom0 kernel - irq nobody cared ... the continuing saga ..

2015-02-10 Thread Jan Beulich
On 09.02.15 at 18:13, li...@eikelenboom.it wrote: Yes the device that tries to handle the interrupt seems to change .. however that device is always not actively used. This time it was an unused IDE controller with driver loaded in dom0 and a mini-pcie wifi card passed through to a guest.

[Xen-devel] [qemu-mainline test] 34355: regressions - trouble: broken/fail/pass

2015-02-10 Thread xen . org
flight 34355 qemu-mainline real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/34355/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-winxpsp3-vcpus1 7 windows-install fail REGR. vs. 33480

Re: [Xen-devel] dom0 kernel - irq nobody cared ... the continuing saga ..

2015-02-10 Thread Sander Eikelenboom
Tuesday, February 10, 2015, 9:48:09 AM, you wrote: On 09.02.15 at 18:13, li...@eikelenboom.it wrote: Yes the device that tries to handle the interrupt seems to change .. however that device is always not actively used. This time it was an unused IDE controller with driver loaded in dom0

Re: [Xen-devel] [PATCH v3 0/7] Display IO topology when PXM data is available (plus some cleanup)

2015-02-10 Thread Jan Beulich
On 09.02.15 at 21:04, boris.ostrov...@oracle.com wrote: * Make changes to xen_sysctl_numainfo, similar to those made to xen_sysctl_topologyinfo. (Q: I kept both sets of changes in the same patch #3 to avoid bumping interface version twice. Perhaps it's better to split it into two?)

Re: [Xen-devel] [PATCH 00/18] x86: multiboot2 protocol support

2015-02-10 Thread Jan Beulich
On 09.02.15 at 18:59, daniel.ki...@oracle.com wrote: On Fri, Jan 30, 2015 at 06:54:04PM +0100, Daniel Kiper wrote: I am sending, long awaited, first version of multiboot2 protocol support for legacy BIOS and EFI platforms. The final goal is xen.efi binary file which could be loaded by EFI

Re: [Xen-devel] dom0 kernel - irq nobody cared ... the continuing saga ..

2015-02-10 Thread Sander Eikelenboom
Tuesday, February 10, 2015, 11:36:48 AM, you wrote: On 10.02.15 at 11:03, li...@eikelenboom.it wrote: Tuesday, February 10, 2015, 10:35:36 AM, you wrote: I suppose that's because there's no handler installed by pciback, yet IRQs generated by the passed through device also arrive in Dom0,

Re: [Xen-devel] dom0 kernel - irq nobody cared ... the continuing saga ..

2015-02-10 Thread Jan Beulich
On 10.02.15 at 10:19, li...@eikelenboom.it wrote: Coming back to the /proc/interrupts output you posted earlier: /proc/interrupts shows the high count: CPU0 CPU1 CPU2 CPU3 8: 0 0 0 0 xen-pirq-ioapic-edge rtc0 9:

Re: [Xen-devel] [PATCH v3 2/7] pci: Do not ignore device's PXM information

2015-02-10 Thread Andrew Cooper
On 09/02/15 20:04, Boris Ostrovsky wrote: If ACPI provides PXM data for IO devices then dom0 will pass it to hypervisor during PHYSDEVOP_pci_device_add call. This information, however, is currently ignored. We will store this information (in the form of nodeID) in pci_dev structure so that

Re: [Xen-devel] [PATCH 2/3] libxl: factor out libxl__disk_backend_from_xs_be

2015-02-10 Thread Ian Jackson
Wei Liu writes ([PATCH 2/3] libxl: factor out libxl__disk_backend_from_xs_be): Signed-off-by: Wei Liu wei.l...@citrix.com Commit messages should include the phrase No functional change where appropriate. I think it is in this case. Thanks, Ian. ___

Re: [Xen-devel] dom0 kernel - irq nobody cared ... the continuing saga ..

2015-02-10 Thread Jan Beulich
On 10.02.15 at 11:47, li...@eikelenboom.it wrote: Tuesday, February 10, 2015, 11:36:48 AM, you wrote: No - such a shared IRQ gets sent to both domains. There's no notion of one domain claiming it and the other then not seeing it, as any instance of the interrupt may mean more than one of the

Re: [Xen-devel] [PATCH] x86 spinlock: Fix memory corruption on completing completions

2015-02-10 Thread Raghavendra K T
On 02/10/2015 06:23 AM, Linus Torvalds wrote: On Mon, Feb 9, 2015 at 4:02 AM, Peter Zijlstra pet...@infradead.org wrote: On Mon, Feb 09, 2015 at 03:04:22PM +0530, Raghavendra K T wrote: So we have 3 choices, 1. xadd 2. continue with current approach. 3. a read before unlock and also after

Re: [Xen-devel] [PATCH] modify the IO_TLB_SEGSIZE to io_tlb_segsize configurable as flexible requirement about SW-IOMMU.

2015-02-10 Thread David Vrabel
On 06/02/15 00:10, Wang, Xiaoming wrote: -Original Message- From: Konrad Rzeszutek Wilk [mailto:konrad.w...@oracle.com] Sent: Friday, February 6, 2015 3:33 AM To: Wang, Xiaoming Cc: r...@linux-mips.org; boris.ostrov...@oracle.com; david.vra...@citrix.com;

Re: [Xen-devel] dom0 kernel - irq nobody cared ... the continuing saga ..

2015-02-10 Thread Sander Eikelenboom
Tuesday, February 10, 2015, 10:35:36 AM, you wrote: On 10.02.15 at 10:19, li...@eikelenboom.it wrote: Coming back to the /proc/interrupts output you posted earlier: /proc/interrupts shows the high count: CPU0 CPU1 CPU2 CPU3 8: 0 0

Re: [Xen-devel] [PATCH RFC V2 3/5] libxl: add pvusb API

2015-02-10 Thread Jürgen Groß
On 01/19/2015 09:28 AM, Chunyan Liu wrote: Add pvusb APIs, including: - attach/detach (create/destroy) virtual usb controller. - attach/detach usb device - list assignable usb devices in host - some other helper functions Signed-off-by: Chunyan Liu cy...@suse.com Signed-off-by: Simon

Re: [Xen-devel] [PATCH RFC 34/35] arm : acpi workarounds for firmware/linux dependencies

2015-02-10 Thread Julien Grall
Hi Jan, On 10/02/2015 18:01, Jan Beulich wrote: On 10.02.15 at 10:38, julien.gr...@linaro.org wrote: Why it's working on x86? This big allocation is done via the boot allocator memory (because the system state is early boot). Hopefully, we never have to resize it. On ARM64, ACPI is

Re: [Xen-devel] [PATCH v3 1/7] x86/numa: Make use of NUMA_NO_NODE consistent

2015-02-10 Thread Andrew Cooper
On 09/02/15 20:04, Boris Ostrovsky wrote: Various pieces of code test whether node value is NUMA_NO_NODE even though pxm_to_node() may return (int)-1 for an invalid node. Make pxm_to_node() and setup_node() return u8 and have them return NUMA_NO_NODE when necessary. Adjust code that tests

Re: [Xen-devel] [PATCH RFC 34/35] arm : acpi workarounds for firmware/linux dependencies

2015-02-10 Thread Julien Grall
Hi Parth, On 05/02/2015 22:59, Julien Grall wrote: +#ifdef CONFIG_X86 #define is_xmalloc_memory(ptr) ((unsigned long)(ptr) (PAGE_SIZE - 1)) +#else +#define is_xmalloc_memory(ptr) 1 +#endif Why? I though this was resolved? i am not aware what was the resolution on it? I didn't have

Re: [Xen-devel] [PATCH RFC 34/35] arm : acpi workarounds for firmware/linux dependencies

2015-02-10 Thread Jan Beulich
On 10.02.15 at 10:38, julien.gr...@linaro.org wrote: Why it's working on x86? This big allocation is done via the boot allocator memory (because the system state is early boot). Hopefully, we never have to resize it. On ARM64, ACPI is initialized after the boot allocator has ended, so we

Re: [Xen-devel] dom0 kernel - irq nobody cared ... the continuing saga ..

2015-02-10 Thread Jan Beulich
On 10.02.15 at 11:03, li...@eikelenboom.it wrote: Tuesday, February 10, 2015, 10:35:36 AM, you wrote: I suppose that's because there's no handler installed by pciback, yet IRQs generated by the passed through device also arrive in Dom0, and the driver for the device left in Dom0 doesn't claim

Re: [Xen-devel] [PATCH v3 4/7] sysctl: Add sysctl interface for querying PCI topology

2015-02-10 Thread Robert Elz
Date:Mon, 9 Feb 2015 15:04:32 -0500 From:Boris Ostrovsky boris.ostrov...@oracle.com Message-ID: 1423512275-6531-5-git-send-email-boris.ostrov...@oracle.com | +num_devs = ti-num_devs - ti-first_dev; | + | +if ( guest_handle_is_null(ti-devs) ||

Re: [Xen-devel] [OSSTEST PATCH 2/2] sg-report-job-history: Show which host test ran on

2015-02-10 Thread Ian Jackson
Ian Campbell writes (Re: [OSSTEST PATCH 2/2] sg-report-job-history: Show which host test ran on): On Mon, 2015-02-09 at 18:07 +, Ian Jackson wrote: Add a column Did you mean row? (looks to be in the HTML, as opposed to the email) No, this is in the job history page. Ie changing this:

Re: [Xen-devel] [PATCH v3 1/7] x86/numa: Make use of NUMA_NO_NODE consistent

2015-02-10 Thread Jan Beulich
On 09.02.15 at 21:04, boris.ostrov...@oracle.com wrote: --- a/xen/include/asm-x86/numa.h +++ b/xen/include/asm-x86/numa.h @@ -21,7 +21,7 @@ struct node { extern int compute_hash_shift(struct node *nodes, int numnodes, int *nodeids); -extern int

Re: [Xen-devel] [PATCH v3 6/7] libxl/libxc: Move libxl_get_numainfo()'s hypercall buffer management to libxc

2015-02-10 Thread Andrew Cooper
On 09/02/15 20:04, Boris Ostrovsky wrote: Signed-off-by: Boris Ostrovsky boris.ostrov...@oracle.com --- tools/libxc/include/xenctrl.h |4 ++- tools/libxc/xc_misc.c | 29 -- tools/libxl/libxl.c | 36

Re: [Xen-devel] [PATCH] x86/HVM: also separate kernel/user vTSC statistics

2015-02-10 Thread Andrew Cooper
On 10/02/15 11:32, Jan Beulich wrote: It is unclear why this got done for PV only originally. While at it, limit this statistics collection to debug or performance counter enabled builds. Signed-off-by: Jan Beulich jbeul...@suse.com Reviewed-by: Andrew Cooper andrew.coop...@citrix.com

Re: [Xen-devel] [PATCH 1/3] libxl, xl: don't init/dispose when not necessary

2015-02-10 Thread Wei Liu
On Tue, Feb 10, 2015 at 10:54:47AM +, Ian Jackson wrote: Wei Liu writes ([PATCH 1/3] libxl, xl: don't init/dispose when not necessary): Functions like libxl__device_disk_from_xs_be and libxl_vdev_to_device_disk should not touch the disk struct passed in. It's caller's responsibility

Re: [Xen-devel] [PATCH 2/3] libxl: factor out libxl__disk_backend_from_xs_be

2015-02-10 Thread Wei Liu
On Tue, Feb 10, 2015 at 10:56:24AM +, Ian Jackson wrote: Wei Liu writes ([PATCH 2/3] libxl: factor out libxl__disk_backend_from_xs_be): Signed-off-by: Wei Liu wei.l...@citrix.com Commit messages should include the phrase No functional change where appropriate. I think it is in this

Re: [Xen-devel] [PATCH v2] x86: re-order struct arch_domain fields

2015-02-10 Thread Andrew Cooper
On 10/02/15 11:34, Jan Beulich wrote: ... to reduce padding holes. Signed-off-by: Jan Beulich jbeul...@suse.com Reviewed-by: Andrew Cooper andrew.coop...@citrix.com --- v2: Drop vtsc_usercount movement to struct pv_domain. --- a/xen/include/asm-x86/domain.h +++

Re: [Xen-devel] [PATCH v3 18/27] Ovmf/Xen: add separate driver for Xen PCI device

2015-02-10 Thread Laszlo Ersek
On 02/03/15 20:20, Ard Biesheuvel wrote: Prepare for making XenBusDxe suitable for use with non-PCI devices (such as the DT node exposed by Xen on ARM) by introducing a separate DXE driver that binds to the Xen virtual PCI device and exposes the abstract XENIO_PROTOCOL for XenBusDxe to bind

[Xen-devel] [ovmf test] 34360: regressions - FAIL

2015-02-10 Thread xen . org
flight 34360 ovmf real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/34360/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ovmf-amd64 7 debian-hvm-install fail REGR. vs. 33686

Re: [Xen-devel] [PATCH v3 0/7] Display IO topology when PXM data is available (plus some cleanup)

2015-02-10 Thread Andrew Cooper
On 10/02/15 08:52, Jan Beulich wrote: On 09.02.15 at 21:04, boris.ostrov...@oracle.com wrote: * Make changes to xen_sysctl_numainfo, similar to those made to xen_sysctl_topologyinfo. (Q: I kept both sets of changes in the same patch #3 to avoid bumping interface version twice. Perhaps it's

Re: [Xen-devel] [PATCH v3 4/7] sysctl: Add sysctl interface for querying PCI topology

2015-02-10 Thread Andrew Cooper
On 09/02/15 20:04, Boris Ostrovsky wrote: Signed-off-by: Boris Ostrovsky boris.ostrov...@oracle.com --- xen/common/sysctl.c | 73 +++ xen/include/public/sysctl.h | 29 + 2 files changed, 102 insertions(+), 0 deletions(-)

Re: [Xen-devel] dom0 kernel - irq nobody cared ... the continuing saga ..

2015-02-10 Thread Jan Beulich
On 10.02.15 at 11:59, andrew.coop...@citrix.com wrote: I presume the irq handler pciback registers will not claim the line level interrupts, as it cant know for certain whether the interrupt was for the passed-through device. This in turn will (presumably) cause the dom0 kernel to declare

Re: [Xen-devel] [PATCH v3 5/7] libxl/libxc: Move libxl_get_cpu_topology()'s hypercall buffer management to libxc

2015-02-10 Thread Andrew Cooper
On 09/02/15 20:04, Boris Ostrovsky wrote: Signed-off-by: Boris Ostrovsky boris.ostrov...@oracle.com --- tools/libxc/include/xenctrl.h |4 +- tools/libxc/xc_misc.c | 23 +++- tools/libxl/libxl.c | 32 +--

[Xen-devel] [PATCH v2] x86: re-order struct arch_domain fields

2015-02-10 Thread Jan Beulich
... to reduce padding holes. Signed-off-by: Jan Beulich jbeul...@suse.com --- v2: Drop vtsc_usercount movement to struct pv_domain. --- a/xen/include/asm-x86/domain.h +++ b/xen/include/asm-x86/domain.h @@ -255,13 +255,16 @@ struct arch_domain unsigned int hv_compat_vstart; -bool_t

Re: [Xen-devel] [PATCH v3 2/7] pci: Do not ignore device's PXM information

2015-02-10 Thread Jan Beulich
On 09.02.15 at 21:04, boris.ostrov...@oracle.com wrote: If ACPI provides PXM data for IO devices then dom0 will pass it to hypervisor during PHYSDEVOP_pci_device_add call. This information, however, is currently ignored. We will store this information (in the form of nodeID) in pci_dev

Re: [Xen-devel] [PATCH 3/3] libxl: libxl__device_from_disk should retrieve backend from xenstore

2015-02-10 Thread Wei Liu
On Tue, Feb 10, 2015 at 11:01:46AM +, Ian Jackson wrote: Wei Liu writes ([PATCH 3/3] libxl: libxl__device_from_disk should retrieve backend from xenstore): ... if backend is not set by caller. Acked-by: Ian Jackson ian.jack...@eu.citrix.com as far as it goes, but I think you may

[Xen-devel] [linux-3.16 test] 34363: regressions - FAIL

2015-02-10 Thread xen . org
flight 34363 linux-3.16 real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/34363/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit2 15 guest-localmigrate/x10fail REGR. vs. 34167 Tests which are

Re: [Xen-devel] [PATCH] x86 spinlock: Fix memory corruption on completing completions

2015-02-10 Thread Oleg Nesterov
On 02/10, Raghavendra K T wrote: On 02/10/2015 06:23 AM, Linus Torvalds wrote: add_smp(lock-tickets.head, TICKET_LOCK_INC); if (READ_ONCE(lock-tickets.tail) TICKET_SLOWPATH_FLAG) .. into something like val = xadd((lock-ticket.head_tail, TICKET_LOCK_INC

Re: [Xen-devel] [PATCH] x86 spinlock: Fix memory corruption on completing completions

2015-02-10 Thread Denys Vlasenko
On Tue, Feb 10, 2015 at 10:30 AM, Raghavendra K T raghavendra...@linux.vnet.ibm.com wrote: On 02/10/2015 06:23 AM, Linus Torvalds wrote: add_smp(lock-tickets.head, TICKET_LOCK_INC); if (READ_ONCE(lock-tickets.tail) TICKET_SLOWPATH_FLAG) .. into something like val

Re: [Xen-devel] [PATCH V4 01/13] xen/mem_event: Cleanup of mem_event structures

2015-02-10 Thread Tamas K Lengyel
On Tue, Feb 10, 2015 at 1:52 PM, Jan Beulich jbeul...@suse.com wrote: On 09.02.15 at 19:53, tamas.leng...@zentific.com wrote: +static void hvm_memory_event_cr(uint32_t reason, unsigned long value, +unsigned long old) +{ +mem_event_request_t req = { +

Re: [Xen-devel] [PATCH v3 25/27] ArmVirtualizationPkg: add XenIoMmioLib

2015-02-10 Thread Laszlo Ersek
On 02/03/15 20:20, Ard Biesheuvel wrote: This adds a XenIoMmioLib declaration and implementation that can be invoked to install the XENIO_PROTOCOL and a corresponding grant table address on a EFI handle. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel

Re: [Xen-devel] [RFC] Tweaking the release process for Xen 4.6

2015-02-10 Thread Lars Kurth
Wei, could you explain what you mean by soft freeze and hard freeze. Regards Lars On 10 Feb 2015, at 15:04, Wei Liu wei.l...@citrix.com wrote: Hi, all With Xen 4.5 released on Jan 14 and the open of Xen 4.6 (commit 0082626f35, Jan 6), we are now one month into 4.6 development window.

Re: [Xen-devel] [PATCH v8 4/7] xen: Add vmware_port support

2015-02-10 Thread Don Slutz
On 01/26/15 10:58, Don Slutz wrote: On 01/22/15 03:32, Jan Beulich wrote: On 21.01.15 at 18:52, dsl...@verizon.com wrote: On 01/16/15 05:09, Jan Beulich wrote: On 03.10.14 at 00:40, dsl...@verizon.com wrote: This is a new domain_create() flag, DOMCRF_vmware_port. It is passed to domctl as

Re: [Xen-devel] [RFC] Tweaking the release process for Xen 4.6

2015-02-10 Thread Lars Kurth
Wei, thanks for clarifying. I don't think you answered all the practical implications of your proposal though. A) Do we start making RC's straight after the Feature Freeze? B) Will there still be exceptions? I am assuming yes C) Do you expect a gradual decrease of what bug fixes are allowed after

[Xen-devel] [rumpuserxen test] 34400: regressions - FAIL

2015-02-10 Thread xen . org
flight 34400 rumpuserxen real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/34400/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-rumpuserxen6 xen-build fail REGR. vs. 33866

[Xen-devel] [rumpuserxen bisection] complete build-i386-rumpuserxen

2015-02-10 Thread xen . org
branch xen-unstable xen branch xen-unstable job build-i386-rumpuserxen test xen-build Tree: qemu git://xenbits.xen.org/staging/qemu-xen-unstable.git Tree: qemuu git://xenbits.xen.org/staging/qemu-upstream-unstable.git Tree: rumpuserxen https://github.com/rumpkernel/rumprun-xen Tree:

Re: [Xen-devel] dom0 kernel - irq nobody cared ... the continuing saga ..

2015-02-10 Thread Sander Eikelenboom
Tuesday, February 10, 2015, 6:47:46 PM, you wrote: Sander Eikelenboom li...@eikelenboom.it 02/10/15 6:30 PM Tuesday, February 10, 2015, 5:22:16 PM, you wrote: Sander Eikelenboom li...@eikelenboom.it 02/10/15 5:01 PM I haven't checked the call chain of xen_pcibk_do_op .. but that could be a

Re: [Xen-devel] [RFC] Tweaking the release process for Xen 4.6

2015-02-10 Thread Wei Liu
On Tue, Feb 10, 2015 at 06:04:10PM +, Lars Kurth wrote: Wei, could you explain what you mean by soft freeze and hard freeze. Regards They correspond to feature freeze and code freeze respectively. A bit more background information for developers that are new to the community. In 4.5 and

Re: [Xen-devel] [RFC] Tweaking the release process for Xen 4.6

2015-02-10 Thread George Dunlap
On Tue, Feb 10, 2015 at 10:04 AM, Wei Liu wei.l...@citrix.com wrote: Hi, all With Xen 4.5 released on Jan 14 and the open of Xen 4.6 (commit 0082626f35, Jan 6), we are now one month into 4.6 development window. This is an email to kick off a discussion with regard to our release process.The

Re: [Xen-devel] [PATCH 18/18] x86: add multiboot2 protocol support for EFI platforms

2015-02-10 Thread Daniel Kiper
On Fri, Jan 30, 2015 at 06:54:22PM +0100, Daniel Kiper wrote: Signed-off-by: Daniel Kiper daniel.ki...@oracle.com --- xen/arch/x86/boot/head.S | 174 +++-- xen/arch/x86/efi/efi-boot.h | 29 +++ xen/arch/x86/setup.c | 23

Re: [Xen-devel] freemem-slack and large memory environments

2015-02-10 Thread Mike Latimer
On Monday, February 09, 2015 06:27:54 PM Mike Latimer wrote: While testing commit 2563bca1, I found that libxl_get_free_memory returns 0 until there is more free memory than required for freemem-slack. This means that during the domain creation process, freed memory is first set aside for

[Xen-devel] [PATCH] vsprintf: Make sure argument to %*ph/%pv is valid

2015-02-10 Thread Boris Ostrovsky
If NULL pointer is passed for these specifiers then print '-' or 'd-v-'. Signed-off-by: Boris Ostrovsky boris.ostrov...@oracle.com --- xen/common/vsprintf.c | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/xen/common/vsprintf.c b/xen/common/vsprintf.c

Re: [Xen-devel] [PATCH] vsprintf: Make sure argument to %*ph/%pv is valid

2015-02-10 Thread Andrew Cooper
On 10/02/2015 21:44, Boris Ostrovsky wrote: If NULL pointer is passed for these specifiers then print '-' or 'd-v-'. Signed-off-by: Boris Ostrovsky boris.ostrov...@oracle.com Instead of special casing each custom format, I would be tempted just to put the switch() in an if(arg) conditional,

Re: [Xen-devel] [PATCH] vsprintf: Make sure argument to %*ph/%pv is valid

2015-02-10 Thread Boris Ostrovsky
On 02/10/2015 04:49 PM, Andrew Cooper wrote: On 10/02/2015 21:44, Boris Ostrovsky wrote: If NULL pointer is passed for these specifiers then print '-' or 'd-v-'. Signed-off-by: Boris Ostrovsky boris.ostrov...@oracle.com Instead of special casing each custom format, I would be tempted just to

[Xen-devel] [PATCH 28/29] libxl: ao: datacopier callback gets an rc

2015-02-10 Thread Ian Jackson
libxl__datacopier_* now provides its caller's callback function with an rc value. This relieves the caller of the need to figure out an appropriate rc value. Arrange that the `other internal failure' cases now get a valid positive errno value (EIO). In a few places, assert that errno is nonzero

[Xen-devel] [PATCH 08/29] libxl: devstate: Use libxl__xswait*

2015-02-10 Thread Ian Jackson
Signed-off-by: Ian Jackson ian.jack...@eu.citrix.com --- tools/libxl/libxl_device.c |4 +-- tools/libxl/libxl_event.c| 78 ++ tools/libxl/libxl_internal.h | 11 +++--- 3 files changed, 40 insertions(+), 53 deletions(-) diff --git

[Xen-devel] [PATCH 07/29] libxl: xswait/devstate: Move xswait to before devstate

2015-02-10 Thread Ian Jackson
Pure code motion. We are going to make devstate use xswait. Signed-off-by: Ian Jackson ian.jack...@eu.citrix.com --- tools/libxl/libxl_internal.h | 109 +- 1 file changed, 55 insertions(+), 54 deletions(-) diff --git a/tools/libxl/libxl_internal.h

[Xen-devel] [PATCH 24/29] libxl: Introduce FILLZERO

2015-02-10 Thread Ian Jackson
FILLZERO is a macro for memset(foo,0,sizeof(foo)). It eliminates the possiblity to make the error memset(foo,0,sizeof(foo)). No callers yet, but document it in CODING_STYLE. (In accordance with existing libxl policy, I haven't gone through all existing possible call sites.) Signed-off-by: Ian

[Xen-devel] [PATCH 25/29] libxl: cancellation: Preparations for save/restore cancellation

2015-02-10 Thread Ian Jackson
Two unrelated non-functional changes, broken out into a pre-patch for easier review: Break out a function sendsig() in libxl_save_callout.c. Move io_fd to be a global variable in libxl_save_helper.c. Signed-off-by: Ian Jackson ian.jack...@eu.citrix.com --- v2: New in this version of the series.

[Xen-devel] [PATCH 27/29] libxl: cancellation: Cancel libxc save/restore

2015-02-10 Thread Ian Jackson
Register the the save/restore helper interface with the cancellation machinery. When we are informed that save/restore should be cancelled, we make a note of the that in our rc variable, and send the helper a SIGTERM. It will die in due course. Signed-off-by: Ian Jackson

  1   2   >