On 22.04.15 at 17:36, ian.campb...@citrix.com wrote:
On Wed, 2015-04-22 at 15:41 +0100, Jan Beulich wrote:
On 22.04.15 at 16:01, ian.campb...@citrix.com wrote:
On Wed, 2015-04-22 at 13:02 +0100, Jan Beulich wrote:
Said commit (libxl_set_memory_target: retain the same maxmem offset on
top
On Thu, Mar 26, 2015 at 9:48 AM, Justin T. Weaver jtwea...@hawaii.edu wrote:
[snip]
Added a function to determine the number of soft cpus gained (or lost) by a
given vcpu if it is migrated from a given source run queue to a given
destination run queue.
Modified algorithm in balance_load and
Ian Campbell writes (Re: [OSSTEST Nested PATCH v8 3/7] Edit some APIs in
TestSupport.pm for nested test):
It will, I think, need to be integrated with the existing assignment to
$ho-{Ip} in select host, so something like:
if ( $r{${ident}_ip} ) {
$ho-{Ip}=
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Xen Security Advisory CVE-2015-3340 / XSA-132
version 2
Information leak through XEN_DOMCTL_gettscinfo
UPDATES IN VERSION 2
CVE assigned.
ISSUE DESCRIPTION
On Tue, Apr 21, 2015 at 05:15:15PM +0200, Dario Faggioli wrote:
On Tue, 2015-04-21 at 17:49 +0800, Chao Peng wrote:
On Tue, Apr 21, 2015 at 03:24:37AM +0200, Dario Faggioli wrote:
On Fri, 2015-04-17 at 22:33 +0800, Chao Peng wrote:
This is the xc/xl changes to support Intel Cache
From: Matt Wilson m...@amazon.com
The grant table locking is becomes more fine-grained in subsequent
commits. Describe how it will work.
Signed-off-by: Matt Wilson m...@amazon.com
Signed-off-by: David Vrabel david.vra...@citrix.com
---
docs/misc/grant-tables.txt | 35
From: Malcolm Crossley malcolm.cross...@citrix.com
Performance analysis of aggregate network throughput with many VMs
shows that performance is signficantly limited by contention on the
maptrack lock when obtaining/releasing maptrack handles from the free
list.
Instead of a single free list use
On 04/22/2015 04:21 PM, Ian Campbell wrote:
On Fri, 2015-04-17 at 17:36 +0200, Giuseppe Mazzotta wrote:
Acked + applied.
For next time please use git send-email or git format-patch so that your
mail can be fed to git am directly, I did it by hand this time.
Thanks. I will comply next
On Wed, 22 Apr 2015, George Dunlap wrote:
On 04/22/2015 03:15 PM, Stefano Stabellini wrote:
On Wed, 22 Apr 2015, Ian Campbell wrote:
On Tue, 2015-04-21 at 17:48 +0100, Stefano Stabellini wrote:
Detect whether we have built seabios and only pass the relative command
line argument to Xen if
If the user disabled seabios in the raisin config, disable seabios in
Xen.
Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com
diff --git a/components/xen b/components/xen
index 9ff0222..add8136 100644
--- a/components/xen
+++ b/components/xen
@@ -24,7 +24,7 @@ function
From: Aurelien Jarno aurel...@aurel32.net
Commit d85d0d3883f5a567fa2969a0396e42e0a662b3fa introduces a regression
with Windows ME that leads to a division by 0 and a crash.
It uses the color expansion rop with the source pitch set to 0. This is
something allowed, as the manual explicitely says
Backport of qemu-upstream:
* c1b886c45dc70f247300f549dce9833f3fa2def5
Signed-off-by: Andrew Cooper andrew.coop...@citrix.com
---
hw/vga.c | 154 ++
1 file changed, 95 insertions(+), 59 deletions(-)
diff --git a/hw/vga.c b/hw/vga.c
Backport of qemu-upstream:
* e6908bfe8e07f2b452e78e677da1b45b1c0f6829
Signed-off-by: Andrew Cooper andrew.coop...@citrix.com
---
vnc.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/vnc.c b/vnc.c
index 7629dfa..7006a34 100644
--- a/vnc.c
+++ b/vnc.c
@@ -1616,6 +1616,16 @@
From: Jim Paris j...@jtan.com
In usb-linux.c:usb_host_handle_control, we pass a 1024-byte buffer and
length to the kernel. However, the length was provided by the caller
of dev-handle_packet, and is not checked, so the kernel might provide
too much data and overflow our buffer.
For example,
From: Yunlei Ding yunlei.d...@citrix.com
Newer GCC warns about memcpy()ing uninitialised data.
Signed-off-by: Yunlei Ding yunlei.d...@citrix.com
Coverity-ID: 1056088
Reviewed-by: Andrew Cooper andrew.coop...@citrix.com
---
hw/virtio-blk.c |1 +
1 file changed, 1 insertion(+)
diff --git
Saving and restoring an lm832x record would overrun the pwm.file array
since pwm.file is uint16_t elements and sizeof(pwm.file) twice as many
elements.
To ensure compatibility, padding bytes are added to the record.
Signed-off-by: Andrew Cooper andrew.coop...@citrix.com
Coverity-IDs: 1055728
From: Aurelien Jarno aurel...@aurel32.net
Commit d85d0d3883f5a567fa2969a0396e42e0a662b3fa introduces a regression
with Windows ME that leads to a division by 0 and a crash.
It uses the color expansion rop with the source pitch set to 0. This is
something allowed, as the manual explicitely says
From: Chunjie Zhu chunjie@citrix.com
Otherwise, a guest can cause Qemu to reuse an active aio structure.
Signed-off-by: Chunjie Zhu chunjie@citrix.com
Reviewed-by: Andrew Cooper andrew.coop...@citrix.com
---
hw/ide.c |7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff
Backport of qemu-upstream:
* bf25983345ca44aec3dd92c57142be45452bd38a
* d3532a0db02296e687711b8cdc7791924efccea0
Signed-off-by: Andrew Cooper andrew.coop...@citrix.com
---
hw/cirrus_vga.c | 66 +--
1 file changed, 49 insertions(+), 17
On Wed, 2015-04-01 at 14:41 +0800, Yang Hongyang wrote:
From: Wen Congyang we...@cn.fujitsu.com
This is the same set used by libxc.
What is this for?
libxl already exposes a fairly complete libxl_bitmap type and helpers
for use in its own interfaces and by its users.
For libxl's internal
Some error paths in vga_ioport_read() would return undefined values.
Always default the result to 0xff.
Signed-off-by: Andrew Cooper andrew.coop...@citrix.com
---
hw/cirrus_vga.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c
index
On Wed, 22 Apr 2015, Jan Beulich wrote:
On 22.04.15 at 15:57, stefano.stabell...@eu.citrix.com wrote:
From the description of the problem above, we have two issues:
1) we don't detect that maxmem is already UINT_MAX*4, so we shouldn't try
to increase it
2) unsigned int /
From: Kaifeng Zhu kaifeng@citrix.com
The momery pointed by s and chr could be leaked if openpty return a value
less then 0.
Signed-off-by: Kaifeng Zhu kaifeng@citrix.com
Coverity-IDs: 1055926 1055927
Reviewed-by: Andrew Cooper andrew.coop...@citrix.com
---
qemu-char.c |2 ++
1 file
From: Yunlei Ding yunlei.d...@citrix.com
Signed-off-by: Yunlei Ding yunlei.d...@citrix.com
Coverity-IDs: 1055920 1055921
Reviewed-by: Andrew Cooper andrew.coop...@citrix.com
---
block-vvfat.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/block-vvfat.c b/block-vvfat.c
index
In 64bit builds, setting sival_int to 0 doesn't clear the upper half of the
sival_ptr pointer. Valgrind does not like this.
Signed-off-by: Andrew Cooper andrew.coop...@citrix.com
---
vl.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/vl.c b/vl.c
index 67d9d86..c864e7d
From: Yunlei Ding yunlei.d...@citrix.com
Call qemu_allocate_irq() twice instead of qemu_allocate_irqs to
allocate memory.
Signed-off-by: Yunlei Ding yunlei.d...@citrix.com
(defects not identified by Coverity Scan)
Reviewed-by: Andrew Cooper andrew.coop...@citrix.com
---
hw/ide.c |6 ++
From: Yunlei Ding yunlei.d...@citrix.com
Signed-off-by: Yunlei Ding yunlei.d...@citrix.com
Coverity-IDs: 1005339 1005340
Reviewed-by: Andrew Cooper andrew.coop...@citrix.com
---
net.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/net.c b/net.c
index 33460d8..8aba3c2
From: Kaifeng Zhu kaifeng@citrix.com
Signed-off-by: Kaifeng Zhu kaifeng@citrix.com
Coverity-ID: 1056200
Reviewed-by: Andrew Cooper andrew.coop...@citrix.com
---
block-cow.c |1 -
1 file changed, 1 deletion(-)
diff --git a/block-cow.c b/block-cow.c
index 777d8a5..9ad0a32 100644
---
In 64bit builds, setting sival_int to 0 doesn't clear the upper half of the
sival_ptr pointer. Valgrind does not like this.
Signed-off-by: Andrew Cooper andrew.coop...@citrix.com
---
vl.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/vl.c b/vl.c
index 67d9d86..c864e7d
From: Yunlei Ding yunlei.d...@citrix.com
msmouse_chr_close is only pointed by chr-chr_close in qemu_chr_close
function. After calling chr-chr_close, chr will be freed. So we don't
need to free it again here.
Signed-off-by: Yunlei Ding yunlei.d...@citrix.com
(defect not identified by Coverity
On Wed, Apr 22, 2015 at 3:49 PM, Stefano Stabellini
stefano.stabell...@eu.citrix.com wrote:
Re stubdoms, I think that we should let the xen component do it until
it's possible to do it out of tree (i.e., no regression in functionality).
On the other hands current stubdoms are not even tested
On Tue, 2015-04-21 at 14:50 -0700, Luis R. Rodriguez wrote:
This:
+ /* MTRR was used if this is non-zero */
+ if (!dd-wc_cookie)
vma-vm_page_prot = pgprot_writecombine(vma-vm_page_prot);
And this:
+ dd-wc_cookie = arch_phys_wc_add(pioaddr, piolen);
+
On Wed, 2015-04-22 at 13:02 +0100, Jan Beulich wrote:
Said commit (libxl_set_memory_target: retain the same maxmem offset on
top of the current target) caused a regression for xl mem-set
against Dom0: While prior to creation of the first domain this works,
the first domain creation involving
On Fri, 2015-04-17 at 17:36 +0200, Giuseppe Mazzotta wrote:
Acked + applied.
For next time please use git send-email or git format-patch so that your
mail can be fed to git am directly, I did it by hand this time.
Do you fancy also adding -F to docs/man/xl.pod.1?
Ian.
On Thu, 2015-04-16 at 19:24 +0100, Ian Jackson wrote:
Ian Jackson writes
(21807.61130.841852.546...@mariner.uk.xensource.com):
Gah, mangled the subject line.
I've applied this series with Jim's Tested-by and my ack.
Thanks,
Ian.
___
Xen-devel
On Fri, 2015-04-17 at 12:31 +0100, Wei Liu wrote:
Make libxl less noisy when destroying a domain.
Signed-off-by: Wei Liu wei.l...@citrix.com
Cc: Ian Campbell ian.campb...@citrix.com
Cc: Ian Jackson ian.jack...@eu.citrix.com
Acked + applied, thanks.
---
tools/libxl/libxl.c | 2 +-
1
On Mon, 2015-04-20 at 11:49 +0100, Andrew Cooper wrote:
This is the results of shaving a yak which started while introducing a pandoc
document in the Migration v2 libxc series
Applied with the replacement v2 patches for the last two.
___
Xen-devel
On Mon, 2015-04-20 at 17:06 +0200, Tamas K Lengyel wrote:
I've now applied everything except:
xen: Make gpfn related memops compatible with wider return values
Which was the subject of some discussion and which you told me on IRC
wasn't critical in this round.
I also updated one of the
On Wed, 22 Apr 2015, Ian Campbell wrote:
On Tue, 2015-04-21 at 17:48 +0100, Stefano Stabellini wrote:
Detect whether we have built seabios and only pass the relative command
line argument to Xen if we actually did.
For this and the following ovmf if we didn't build seabios/ovmf here
then
On Thu, 2015-04-16 at 10:49 -0600, Linda wrote:
On 4/16/2015 8:45 AM, Wei Liu wrote:
On Thu, Apr 16, 2015 at 08:40:52AM -0600, Linda wrote:
On 4/16/2015 8:34 AM, Ian Campbell wrote:
On Wed, 2015-04-15 at 11:02 -0600, Linda Jacobson wrote:
New functions to provide logical and and or of two
On Mon, 2015-04-20 at 13:40 +, Olaf Hering wrote:
Prepare device-model setup functions to pass also environment variables
to the spawned process. This is required for upcoming changes which will
set DISPLAY and XAUTHORITY for SDL.
Signed-off-by: Olaf Hering o...@aepfle.de
Cc: Ian
Lars Kurth writes (Re: Archiving Xen on ARM and PVOPS subprojects):
Any other votes by committers (in the TO list) before I tally the votes?
+1 to both.
Ian.
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
On Mon, 2015-04-20 at 13:40 +, Olaf Hering wrote:
With this change the following domU.cfg will show the VM window on the
local dom0 display, instead of the remote side (it via ssh -X login):
vnc=0
sdl=1
display=:0
xauthority=/run/gdm/auth-for-olaf-nMXhOi/database
ISTR thinking
On Tue, 21 Apr 2015, George Dunlap wrote:
1. Switch local variables to lower-case and declare them local.
This is good.
2. Cloning git trees from remote repos is often a very long operation.
Allow the user to specify a faster git cache as a prefix.
3. At the moment you can either check
On Tue, Apr 21, 2015 at 04:39:05PM +0200, Dario Faggioli wrote:
On Tue, 2015-04-21 at 15:01 +0100, Ian Campbell wrote:
On Tue, 2015-04-21 at 17:49 +0800, Chao Peng wrote:
I do like this suggestion and I have ever considered it actually. The
only thing prevents me is that we need an
On Wed, 22 Apr 2015, Jan Beulich wrote:
Said commit (libxl_set_memory_target: retain the same maxmem offset on
top of the current target) caused a regression for xl mem-set
against Dom0: While prior to creation of the first domain this works,
the first domain creation involving ballooning
On Mon, 2015-04-20 at 12:21 +0200, Gustau Pérez wrote:
On 20/04/2015 12:01, Wei Liu wrote:
On Mon, Apr 20, 2015 at 11:25:36AM +0200, Roger Pau Monné wrote:
El 20/04/15 a les 9.12, Gustau Perez ha escrit:
On creation time, tap and xnb interfaces are created with an mtu of
1500 bytes,
On Wed, 2015-04-22 at 15:15 +0100, Stefano Stabellini wrote:
On Wed, 22 Apr 2015, Ian Campbell wrote:
On Tue, 2015-04-21 at 17:48 +0100, Stefano Stabellini wrote:
Detect whether we have built seabios and only pass the relative command
line argument to Xen if we actually did.
For this
On Wed, 22 Apr 2015, Ian Campbell wrote:
On Wed, 2015-04-22 at 15:15 +0100, Stefano Stabellini wrote:
On Wed, 22 Apr 2015, Ian Campbell wrote:
On Tue, 2015-04-21 at 17:48 +0100, Stefano Stabellini wrote:
Detect whether we have built seabios and only pass the relative command
line
On Wed, 22 Apr 2015, George Dunlap wrote:
On 04/22/2015 03:54 PM, Stefano Stabellini wrote:
On Wed, 22 Apr 2015, George Dunlap wrote:
On 04/22/2015 03:11 PM, Stefano Stabellini wrote:
On Tue, 21 Apr 2015, George Dunlap wrote:
1. Switch local variables to lower-case and declare them local.
From: Yunlei Ding yunlei.d...@citrix.com
s-rq should be set with req instead of req-next.
Signed-off-by: Yunlei Ding yunlei.d...@citrix.com
Coverity-ID: 1055910
Reviewed-by: Andrew Cooper andrew.coop...@citrix.com
---
hw/virtio-blk.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Kaifeng Zhu kaifeng@citrix.com
The momery pointed by s and chr could be leaked if openpty return a value
less then 0.
Signed-off-by: Kaifeng Zhu kaifeng@citrix.com
Coverity-IDs: 1055926 1055927
Reviewed-by: Andrew Cooper andrew.coop...@citrix.com
---
qemu-char.c |2 ++
1 file
smbus_eeprom_device_init() has been disabled since 2007. The #define turns
the actual function call into a comma expression with no effect.
Removing the leaked allocation also makes Valgrind happier.
Signed-off-by: Andrew Cooper andrew.coop...@citrix.com
Coverity-ID: 1090387
---
hw/pc.c | 12
On Wed, 2015-04-01 at 14:41 +0800, Yang Hongyang wrote:
From: Wen Congyang we...@cn.fujitsu.com
I think this is just tidying up after the previous automatic renaming,
if that is the case please can you say so.
Signed-off-by: Wen Congyang we...@cn.fujitsu.com
---
On Wed, Apr 22, 2015 at 09:54:38AM -0400, Doug Ledford wrote:
On Tue, 2015-04-21 at 14:50 -0700, Luis R. Rodriguez wrote:
This:
+ /* MTRR was used if this is non-zero */
+ if (!dd-wc_cookie)
vma-vm_page_prot = pgprot_writecombine(vma-vm_page_prot);
And this:
+
On Wed, 22 Apr 2015, George Dunlap wrote:
On Wed, Apr 22, 2015 at 3:49 PM, Stefano Stabellini
stefano.stabell...@eu.citrix.com wrote:
Re stubdoms, I think that we should let the xen component do it until
it's possible to do it out of tree (i.e., no regression in functionality).
On the
On Wed, 2015-04-01 at 14:41 +0800, Yang Hongyang wrote:
From: Wen Congyang we...@cn.fujitsu.com
For PVHVM, the hypercall return code is 0, and it can be resumed
in a new domain context.
For HVM, do nothing.
Signed-off-by: Wen Congyang we...@cn.fujitsu.com
---
tools/libxc/xc_resume.c
On 04/22/2015 03:54 PM, Stefano Stabellini wrote:
On Wed, 22 Apr 2015, George Dunlap wrote:
On 04/22/2015 03:11 PM, Stefano Stabellini wrote:
On Tue, 21 Apr 2015, George Dunlap wrote:
1. Switch local variables to lower-case and declare them local.
This is good.
2. Cloning git trees from
From: Yunlei Ding yunlei.d...@citrix.com
Close sock handle before return.
Signed-off-by: Yunlei Ding yunlei.d...@citrix.com
Coverity-ID: 1055914
Reviewed-by: Andrew Cooper andrew.coop...@citrix.com
---
block-nbd.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/block-nbd.c
From: Kaifeng Zhu kaifeng@citrix.com
fd and s could be leaked in case bind/listen failed.
Signed-off-by: Kaifeng Zhu kaifeng@citrix.com
Coverity-IDs: 1055923 1055924
Reviewed-by: Andrew Cooper andrew.coop...@citrix.com
---
net.c |5 +
1 file changed, 5 insertions(+)
diff --git
From: Kaifeng Zhu kaifeng@citrix.com
Some handles and memory in commit_one_file are going to be leaked if
certain function calls failed.
Signed-off-by: Kaifeng Zhu kaifeng@citrix.com
Coverity-IDs: 1055918 1055919
Reviewed-by: Andrew Cooper andrew.coop...@citrix.com
---
block-vvfat.c |
From: Yunlei Ding yunlei.d...@citrix.com
msmouse_chr_close is only pointed by chr-chr_close in qemu_chr_close
function. After calling chr-chr_close, chr will be freed. So we don't
need to free it again here.
Signed-off-by: Yunlei Ding yunlei.d...@citrix.com
(defect not identified by Coverity
From: Kaifeng Zhu kaifeng@citrix.com
Memory pointed by cluster leaks in error handling code.
Signed-off-by: Kaifeng Zhu kaifeng@citrix.com
Coverity-ID: 1055917
Reviewed-by: Andrew Cooper andrew.coop...@citrix.com
---
block-vvfat.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Kaifeng Zhu kaifeng@citrix.com
idx can be down to 0, so TERM_MAX_CMDS-idx+1 could be TERM_MAX_CMDS+1, which
exceeds the size of term_history.
Signed-off-by: Kaifeng Zhu kaifeng@citrix.com
Coverity-ID: 1055739
Reviewed-by: Andrew Cooper andrew.coop...@citrix.com
---
readline.c |
From: Kaifeng Zhu kaifeng@citrix.com
drive_opt_idx could be -1 in case error occurs inside drive_add, so the error
check should be if (drive_opt_idx 0) instead of original
if (!drive_opt_idx).
Signed-off-by: Kaifeng Zhu kaifeng@citrix.com
Coverity-ID: 1055574
Reviewed-by: Andrew Cooper
From: Kaifeng Zhu kaifeng@citrix.com
drive_opt_idx could be -1 in case error occurs inside drive_add, so the error
check should be if (drive_opt_idx 0) instead of original
if (!drive_opt_idx).
Signed-off-by: Kaifeng Zhu kaifeng@citrix.com
Coverity-ID: 1055574
Reviewed-by: Andrew Cooper
From: Yunlei Ding yunlei.d...@citrix.com
Call qemu_allocate_irq() twice instead of qemu_allocate_irqs to
allocate memory.
Signed-off-by: Yunlei Ding yunlei.d...@citrix.com
(defects not identified by Coverity Scan)
Reviewed-by: Andrew Cooper andrew.coop...@citrix.com
---
hw/ide.c |6 ++
From: Chunjie Zhu chunjie@citrix.com
The following 2 cases should be avoided:
1. DMAAIOCB has been released but continue_after_map_failure
schedules a bh for it.
2. Multiple bh calls are schduled on the same DMAAIOCB.
Signed-off-by: Chunjie Zhu chunjie@citrix.com
Reviewed-by:
From: Kaifeng Zhu kaifeng@citrix.com
The valide range of font_data should be [0, 0xFF].
Signed-off-by: Kaifeng Zhu kaifeng@citrix.com
(defects not identified by Coverity Scan)
Reviewed-by: Andrew Cooper andrew.coop...@citrix.com
---
console.c |9 +
1 file changed, 5
From: Kaifeng Zhu kaifeng@citrix.com
Some handles and memory in commit_one_file are going to be leaked if
certain function calls failed.
Signed-off-by: Kaifeng Zhu kaifeng@citrix.com
Coverity-IDs: 1055918 1055919
Reviewed-by: Andrew Cooper andrew.coop...@citrix.com
---
block-vvfat.c |
i8259_init() doesn't inspect its argument at all, causing the allocation to
be leaked and never used.
Signed-off-by: Andrew Cooper andrew.coop...@citrix.com
---
hw/pc.c |4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/hw/pc.c b/hw/pc.c
index 7359338..09b4af4 100644
---
From: Yunlei Ding yunlei.d...@citrix.com
Free allocated memory s before return.
Signed-off-by: Yunlei Ding yunlei.d...@citrix.com
Coverity-ID: 1055915
Reviewed-by: Andrew Cooper andrew.coop...@citrix.com
---
block-raw-posix.c |1 +
1 file changed, 1 insertion(+)
diff --git
On Mon, 2015-04-20 at 14:15 +0100, Andrew Cooper wrote:
On 15/04/15 11:55, Ian Campbell wrote:
On Fri, 2015-04-10 at 18:15 +0100, Andrew Cooper wrote:
Not everything which needs reporting as progress comes with a range.
Extend
the interface to allow reporting of a single statement.
Ping on the patches themselves?
On 13/04/15 17:37, Andrew Cooper wrote:
On 13/04/15 17:33, Ian Jackson wrote:
Andrew Cooper writes ([Xen-devel] [PATCH] tools/libxc: Fix build of 32bit
toolstacks on CentOS 5.x following XSA-125):
gcc 4.1 of CentOS 5.x era does not like the typecheck in min()
On 22.04.15 at 16:01, ian.campb...@citrix.com wrote:
On Wed, 2015-04-22 at 13:02 +0100, Jan Beulich wrote:
Said commit (libxl_set_memory_target: retain the same maxmem offset on
top of the current target) caused a regression for xl mem-set
against Dom0: While prior to creation of the first
On 22.04.15 at 15:57, stefano.stabell...@eu.citrix.com wrote:
From the description of the problem above, we have two issues:
1) we don't detect that maxmem is already UINT_MAX*4, so we shouldn't try
to increase it
2) unsigned int / uint64_t mismatch
1) is pretty easy and might
On 04/22/2015 03:11 PM, Stefano Stabellini wrote:
On Tue, 21 Apr 2015, George Dunlap wrote:
1. Switch local variables to lower-case and declare them local.
This is good.
2. Cloning git trees from remote repos is often a very long operation.
Allow the user to specify a faster git cache
Here is a set of bugfixes against Qemu Traditional, which are from the
XenServer patch queue.
Patches 1 to 4 are build fixes in a CentOS environment
Patches 5 to 8 are backports of public CVEs, including two remote code
execution vulnerabilities.
Patches 9 to 11 are fixes for crashes which guest
From: Jim Paris j...@jtan.com
In usb-linux.c:usb_host_handle_control, we pass a 1024-byte buffer and
length to the kernel. However, the length was provided by the caller
of dev-handle_packet, and is not checked, so the kernel might provide
too much data and overflow our buffer.
For example,
Some error paths in vga_ioport_read() would return undefined values.
Always default the result to 0xff.
Signed-off-by: Andrew Cooper andrew.coop...@citrix.com
---
hw/cirrus_vga.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c
index
Newer GCC versions raise an undefined behaviour warning in
fat_chksum() because it overruns the name buffer. However, this is
intentional behaviour because the extension array immediately follows.
Refactor this function to avoid the warning and make it clear it's
checksumming both parts.
From: Yunlei Ding yunlei.d...@citrix.com
Signed-off-by: Yunlei Ding yunlei.d...@citrix.com
Coverity-IDs: 1005339 1005340
Reviewed-by: Andrew Cooper andrew.coop...@citrix.com
---
net.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/net.c b/net.c
index 33460d8..8aba3c2
From: Kaifeng Zhu kaifeng@citrix.com
Signed-off-by: Kaifeng Zhu kaifeng@citrix.com
Coverity-ID: 1056200
Reviewed-by: Andrew Cooper andrew.coop...@citrix.com
---
block-cow.c |1 -
1 file changed, 1 deletion(-)
diff --git a/block-cow.c b/block-cow.c
index 777d8a5..9ad0a32 100644
---
From: Chunjie Zhu chunjie@citrix.com
The following 2 cases should be avoided:
1. DMAAIOCB has been released but continue_after_map_failure
schedules a bh for it.
2. Multiple bh calls are schduled on the same DMAAIOCB.
Signed-off-by: Chunjie Zhu chunjie@citrix.com
Reviewed-by:
On Wed, 2015-04-22 at 15:41 +0100, Jan Beulich wrote:
On 22.04.15 at 16:01, ian.campb...@citrix.com wrote:
On Wed, 2015-04-22 at 13:02 +0100, Jan Beulich wrote:
Said commit (libxl_set_memory_target: retain the same maxmem offset on
top of the current target) caused a regression for xl
From: Yunlei Ding yunlei.d...@citrix.com
s-rq should be set with req instead of req-next.
Signed-off-by: Yunlei Ding yunlei.d...@citrix.com
Coverity-ID: 1055910
Reviewed-by: Andrew Cooper andrew.coop...@citrix.com
---
hw/virtio-blk.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
On Wed, 2015-04-22 at 15:49 +0100, Stefano Stabellini wrote:
On Wed, 22 Apr 2015, George Dunlap wrote:
Re stubdoms, I think that we should let the xen component do it until
it's possible to do it out of tree (i.e., no regression in functionality).
On the other hands current stubdoms are
smbus_eeprom_device_init() has been disabled since 2007. The #define turns
the actual function call into a comma expression with no effect.
Removing the leaked allocation also makes Valgrind happier.
Signed-off-by: Andrew Cooper andrew.coop...@citrix.com
Coverity-ID: 1090387
---
hw/pc.c | 12
From: Kaifeng Zhu kaifeng@citrix.com
qemu_allocate_irqs would return an array of irqs, not store the allocated
array pointer, and subsequently leak it.
Signed-off-by: Kaifeng Zhu kaifeng@citrix.com
(defects not identified by Coverity Scan)
Reviewed-by: Andrew Cooper
On Wed, 2015-04-22 at 15:43 +0100, George Dunlap wrote:
Also wouldn't it be possible to achieve the same goal with the GIT
environmental variable?
A brief scan of the git man page, combined with a brief survey of
Google, didn't turn up anything...
It's not an env variable, but in
From: Kaifeng Zhu kaifeng@citrix.com
idx can be down to 0, so TERM_MAX_CMDS-idx+1 could be TERM_MAX_CMDS+1, which
exceeds the size of term_history.
Signed-off-by: Kaifeng Zhu kaifeng@citrix.com
Coverity-ID: 1055739
Reviewed-by: Andrew Cooper andrew.coop...@citrix.com
---
readline.c |
On Wed, 2015-04-01 at 14:41 +0800, Yang Hongyang wrote:
The core function to suspend vm is domain_suspend_callback_common().
So use a new structure libxl__domain_suspend_state2 to
instead of libxl__domain_suspend_state. The dss's members that
will be used in domain_suspend_callback_common()
On Wed, 22 Apr 2015, George Dunlap wrote:
On 04/22/2015 03:11 PM, Stefano Stabellini wrote:
On Tue, 21 Apr 2015, George Dunlap wrote:
1. Switch local variables to lower-case and declare them local.
This is good.
2. Cloning git trees from remote repos is often a very long
Newer GCC versions raise an undefined behaviour warning in
fat_chksum() because it overruns the name buffer. However, this is
intentional behaviour because the extension array immediately follows.
Refactor this function to avoid the warning and make it clear it's
checksumming both parts.
From: Chunjie Zhu chunjie@citrix.com
Otherwise, a guest can cause Qemu to reuse an active aio structure.
Signed-off-by: Chunjie Zhu chunjie@citrix.com
Reviewed-by: Andrew Cooper andrew.coop...@citrix.com
---
hw/ide.c |7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff
Backport of qemu-upstream:
* c1b886c45dc70f247300f549dce9833f3fa2def5
Signed-off-by: Andrew Cooper andrew.coop...@citrix.com
---
hw/vga.c | 154 ++
1 file changed, 95 insertions(+), 59 deletions(-)
diff --git a/hw/vga.c b/hw/vga.c
From: Yunlei Ding yunlei.d...@citrix.com
Newer GCC warns about memcpy()ing uninitialised data.
Signed-off-by: Yunlei Ding yunlei.d...@citrix.com
Coverity-ID: 1056088
Reviewed-by: Andrew Cooper andrew.coop...@citrix.com
---
hw/virtio-blk.c |1 +
1 file changed, 1 insertion(+)
diff --git
Backport of qemu-upstream:
* bf25983345ca44aec3dd92c57142be45452bd38a
* d3532a0db02296e687711b8cdc7791924efccea0
Signed-off-by: Andrew Cooper andrew.coop...@citrix.com
---
hw/cirrus_vga.c | 66 +--
1 file changed, 49 insertions(+), 17
Backport of qemu-upstream:
* e6908bfe8e07f2b452e78e677da1b45b1c0f6829
Signed-off-by: Andrew Cooper andrew.coop...@citrix.com
---
vnc.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/vnc.c b/vnc.c
index 7629dfa..7006a34 100644
--- a/vnc.c
+++ b/vnc.c
@@ -1616,6 +1616,16 @@
Saving and restoring an lm832x record would overrun the pwm.file array
since pwm.file is uint16_t elements and sizeof(pwm.file) twice as many
elements.
To ensure compatibility, padding bytes are added to the record.
Signed-off-by: Andrew Cooper andrew.coop...@citrix.com
Coverity-IDs: 1055728
1 - 100 of 150 matches
Mail list logo
