[Xen-devel] [PATCH] x86/hvm: Fix deadlock in emulation of rep mov to or from VRAM.

2015-07-13 Thread Paul Durrant
Razvan Cojocaru reported a hypervisor deadlock with the following stack: (XEN)[82d08012c3f1] _spin_lock+0x31/0x54 (XEN)[82d0801d09b6] stdvga_mem_accept+0x3b/0x125 (XEN)[82d0801cb23a] hvm_find_io_handler+0x68/0x8a (XEN)[82d0801cb410] hvm_mmio_internal+0x37/0x67

Re: [Xen-devel] [PATCH v4 11/17] xen/arm: ITS: Add GICR register emulation

2015-07-13 Thread Ian Campbell
On Sat, 2015-07-11 at 20:25 +0200, Julien Grall wrote: Hi, On 10/07/2015 17:10, Ian Campbell wrote: Extra space after the . @@ -694,6 +755,14 @@ static int vgic_v3_distr_mmio_read(struct vcpu *v, mmio_info_t *info) *r = ((ncpus - 1) GICD_TYPE_CPUS_SHIFT |

Re: [Xen-devel] Deadlock in stdvga_mem_accept() with emulation

2015-07-13 Thread Jan Beulich
On 13.07.15 at 11:05, paul.durr...@citrix.com wrote: --- a/xen/arch/x86/hvm/stdvga.c +++ b/xen/arch/x86/hvm/stdvga.c @@ -490,11 +490,18 @@ static bool_t stdvga_mem_accept(const struct hvm_io_handle { struct hvm_hw_stdvga *s = current-domain-arch.hvm_domain.stdvga; +/* + *

[Xen-devel] [linux-3.4 test] 59477: regressions - trouble: broken/fail/pass

2015-07-13 Thread osstest service owner
flight 59477 linux-3.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/59477/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-win7-amd64 6 xen-boot fail in 58831 REGR. vs. 30511 Tests which are

Re: [Xen-devel] [PATCH 3/9] libxl: json string object can be NULL

2015-07-13 Thread Ian Campbell
On Fri, 2015-07-10 at 19:00 +0100, Wei Liu wrote: Signed-off-by: Wei Liu wei.l...@citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com It occurs to me that since libxl__strdup can never return NULL due to allocation failure we could consider make libxl__strdup(gc, NULL) be well defined as

Re: [Xen-devel] [PATCH V2 1/1] libxl: set stub domain size based on VRAM size

2015-07-13 Thread Ian Jackson
Ian Jackson writes (Re: [PATCH V2 1/1] libxl: set stub domain size based on VRAM size): Eric Shelton writes ([PATCH V2 1/1] libxl: set stub domain size based on VRAM size): Allocate additional memory to the stub domain for qemu-traditional if more than 4 MB is assigned to the video adapter

[Xen-devel] [PATCH for-4.6 v3] libxl: set stub domain size based on VRAM size

2015-07-13 Thread Ian Jackson
From: Eric Shelton eshel...@pobox.com Allocate additional memory to the stub domain for qemu-traditional if more than 4 MB is assigned to the video adapter to avoid out of memory condition for QEMU. Signed-off-by: Eric Shelton eshel...@pobox.com Signed-off-by: Ian Jackson

Re: [Xen-devel] [PATCH OSSTEST v2 04/13] toolstack: distinguish local and remote migration support

2015-07-13 Thread Ian Campbell
On Sun, 2015-07-12 at 17:20 +0100, Wei Liu wrote: @@ -23,5 +23,9 @@ use Osstest::TestSupport; tsreadconfig(); our $ho = selecthost($ARGV[0]); +# $ARGV[1] is guest name, $ARG[2] indicates whether it is checking for +# local migration or remote migration +# Mode should be either 1 (local)

Re: [Xen-devel] [PATCH v4 RFC 0/6] x86/MSI: XSA-120, 126, 128-131 follow-up

2015-07-13 Thread Jan Beulich
On 22.06.15 at 16:38, jbeul...@suse.com wrote: Only patches 1, 2, and 6 are really RFC (with some debugging code still left in), the others (hence v4) have been submitted before. 1: PCI: add config space write abstract intercept logic 2: MSI-X: track host and guest mask-all requests

Re: [Xen-devel] [PATCH OSSTEST v8 2/2] mg-all-branch-statuses: Show how up to date each branch is

2015-07-13 Thread Ian Campbell
On Thu, 2015-07-09 at 15:30 +0100, Ian Campbell wrote: Using report_find_push_age_info allows us to provide counts of attempts since the last baseline on current tip as well as the first attempt of each of those. Since everything serialises on the repo lock I didn't bother trying to

Re: [Xen-devel] Requesting for freeze exception for RMRR

2015-07-13 Thread Wei Liu
On Mon, Jul 13, 2015 at 02:31:58PM +0800, Chen, Tiejun wrote: Hi Wei, Here I'm trying to request the freeze exception for RMRR. 1. clarify the state of patch series / feature. Reviewed Acked RMRR series v7 Y Y [v7][PATCH 01/16] xen: introduce

Re: [Xen-devel] Deadlock in stdvga_mem_accept() with emulation

2015-07-13 Thread Paul Durrant
-Original Message- From: xen-devel-boun...@lists.xen.org [mailto:xen-devel- boun...@lists.xen.org] On Behalf Of Paul Durrant Sent: 13 July 2015 11:12 To: Razvan Cojocaru; Andrew Cooper; xen-devel@lists.xen.org Cc: Keir (Xen.org); Jan Beulich Subject: Re: [Xen-devel] Deadlock in

[Xen-devel] [PATCH v3 22/28] tools/libxc+libxl+xl: Save v2 streams

2015-07-13 Thread Andrew Cooper
This is a complicated set of changes which must be done together for bisectability. * libxl-save-helper is updated to unconditionally use libxc migration v2. * libxl compatibility workarounds in libxc are disabled for save operations. * libxl__stream_write_start() is logically spliced into the

[Xen-devel] [PATCH v3 27/28] tools/libxc: Drop all XG_LIBXL_HVM_COMPAT code from libxc

2015-07-13 Thread Andrew Cooper
Libxl has now been fully adjusted not to need it. Signed-off-by: Andrew Cooper andrew.coop...@citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com CC: Ian Jackson ian.jack...@eu.citrix.com CC: Wei Liu wei.l...@citrix.com --- tools/libxc/xc_sr_common.h |5 --

[Xen-devel] [PATCH v3 20/28] tools/libxc+libxl+xl: Restore v2 streams

2015-07-13 Thread Andrew Cooper
This is a complicated set of changes which must be done together for bisectability. * libxl-save-helper is updated to unconditionally use libxc migration v2. * libxl compatibility workarounds in libxc are disabled for restore operations. * libxl__stream_read_start() is logically spliced

[Xen-devel] [PATCH v3 15/28] tools/python: Conversion utility for legacy migration streams

2015-07-13 Thread Andrew Cooper
This utility will take a legacy stream as in input, and produce a v2 stream as an output. It is exec()'d by libxl to provide backwards compatibility. Signed-off-by: Andrew Cooper andrew.coop...@citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com CC: Ian Jackson ian.jack...@eu.citrix.com

[Xen-devel] [PATCH v3 16/28] tools/libxl: Migration v2 stream format

2015-07-13 Thread Andrew Cooper
From: Ross Lagerwall ross.lagerw...@citrix.com C structures describing the Libxl migration v2 stream format Signed-off-by: Ross Lagerwall ross.lagerw...@citrix.com Signed-off-by: Andrew Cooper andrew.coop...@citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com CC: Ian Jackson

[Xen-devel] [PATCH v3 18/28] tools/libxl: Infrastructure to convert a legacy stream

2015-07-13 Thread Andrew Cooper
Provide a thin wrapper around exec()ing the python conversion utility, and a stub implementation for cases where conversion is not wanted (i.e. not x86). One complication is that the caller of this interface needs to assume ownership of the output fd, to prevent it being closed while still in use

[Xen-devel] [PATCH v3 25/28] tools/libx{c, l}: Introduce restore_callbacks.checkpoint()

2015-07-13 Thread Andrew Cooper
And call it when a checkpoint record is found in the libxc stream. Some parts of this patch have been based on patches from the COLO series. Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: Yang Hongyang yan...@cn.fujitsu.com Signed-off-by: Andrew Cooper andrew.coop...@citrix.com

[Xen-devel] [PATCH v3 12/28] tools/python: Libxl migration v2 infrastructure

2015-07-13 Thread Andrew Cooper
Contains: * Python implementation of the libxl migration v2 records * Verification code for spec compliance * Unit tests Signed-off-by: Andrew Cooper andrew.coop...@citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com CC: Ian Jackson ian.jack...@eu.citrix.com CC: Wei Liu

[Xen-devel] [PATCH v2 0/3] arm64: Add multiboot support (via fdt) for Xen boot

2015-07-13 Thread fu . wei
From: Fu Wei fu@linaro.org - This adds support for the Xen boot on ARM specification for arm64. - The implementation for Xen is following Multiboot on ARM Specification: http://wiki.xen.org/wiki/Xen_ARM_with_Virtualization_Extensions/Multiboot and

Re: [Xen-devel] [PATCH] x86: avoid invalid phys_proc_id reference

2015-07-13 Thread Jan Beulich
On 13.07.15 at 05:36, chao.p.p...@linux.intel.com wrote: phys_proc_id is invalidated in remove_siblinginfo() which gets called before cpu_smpboot_free(). This means calling cpu_to_socket(cpu) in cpu_smpboot_free() is not possible to be correct. This patch invokes remove_siblinginfo() in

[Xen-devel] [PATCH v2 2/3] util/grub.d/20_linux_xen.in: Add arm64 support

2015-07-13 Thread fu . wei
From: Fu Wei fu@linaro.org This patch adds the support of boot command on arm64 for XEN: xen_hypervisor xen_module Signed-off-by: Fu Wei fu@linaro.org --- util/grub.d/20_linux_xen.in | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git

Re: [Xen-devel] [PATCH v4 06/17] xen/arm: ITS: Add virtual ITS driver

2015-07-13 Thread Ian Campbell
On Sat, 2015-07-11 at 20:18 +0530, Vijay Kilari wrote: On Fri, Jul 10, 2015 at 7:45 PM, Ian Campbell i...@xen.org wrote: On Fri, 2015-07-10 at 13:12 +0530, vijay.kil...@gmail.com wrote: +static int vits_entry(struct domain *d, paddr_t entry, void *addr, + uint32_t size,

Re: [Xen-devel] [PATCH v4 06/17] xen/arm: ITS: Add virtual ITS driver

2015-07-13 Thread Ian Campbell
On Sat, 2015-07-11 at 20:18 +0530, Vijay Kilari wrote: Hi Ian, On Fri, Jul 10, 2015 at 7:24 PM, Ian Campbell ian.campb...@citrix.com wrote: On Fri, 2015-07-10 at 13:12 +0530, vijay.kil...@gmail.com wrote: +/* RB-tree helpers for vits_device attached to a domain */ In the rest of the

Re: [Xen-devel] [PATCH 1/9] libxl: fix libxl__abs_path

2015-07-13 Thread Ian Campbell
On Fri, 2015-07-10 at 19:00 +0100, Wei Liu wrote: I rather dislike subjects of the form fix $function, since it gives very little clue to someone reading the shortlog what is going on. In this case I think libxl: make libxl__abs_path correctly handle a NULL argument would be an accurate

Re: [Xen-devel] [PATCH 4/9] libxl: dispose dominfo to avoid leaking resource

2015-07-13 Thread Ian Campbell
On Fri, 2015-07-10 at 19:00 +0100, Wei Liu wrote: Add libxl_dominfo_dispose to one return path that doesn't have it. Signed-off-by: Wei Liu wei.l...@citrix.com That return is a bit at odds with the generally correct error handling in that function, but this improves things at least a little

Re: [Xen-devel] [PATCH 9/9] xl: fix main_config_update

2015-07-13 Thread Ian Campbell
On Fri, 2015-07-10 at 19:00 +0100, Wei Liu wrote: Don't dereference NULL. Subject: xl: correctly handle null extra config in main_config_update Signed-off-by: Wei Liu wei.l...@citrix.com --- tools/libxl/xl_cmdimpl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Xen-devel] [PATCH v4 for Xen 4.6 0/4] Enable per-VCPU parameter settings for RTDS scheduler

2015-07-13 Thread Dario Faggioli
On Sat, 2015-07-11 at 15:33 +0100, Wei Liu wrote: Hi Chong This series is marked as for 4.6, but we just hit feature freeze yesterday. Yeah, I wanted to reply myself about this, but Wei beat me... Good job as release manager, I would say. :-) Given the status of this series (missing many

Re: [Xen-devel] [PATCH OSSTEST v2 10/13] TestSupport: don't put kernel='hvmloader' in HVM config

2015-07-13 Thread Ian Campbell
On Sun, 2015-07-12 at 17:20 +0100, Wei Liu wrote: Setting kernel to hvmloader is ignored in xl but not in libvirt. Libvirt config converter will translate that then pass it to QEMU. QEMU complains there is no kernel called hvmloader and exits. Just remove this option. Xl is not affected and

[Xen-devel] [PATCH v3 14/28] tools/python: Verification utility for v2 stream spec compliance

2015-07-13 Thread Andrew Cooper
Signed-off-by: Andrew Cooper andrew.coop...@citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com CC: Ian Jackson ian.jack...@eu.citrix.com CC: Wei Liu wei.l...@citrix.com --- This is exceedingly useful for development, but not of practical use being installed into a production dom0. ---

[Xen-devel] [PATCH v3 21/28] tools/libxl: Infrastructure for writing a v2 stream

2015-07-13 Thread Andrew Cooper
From: Ross Lagerwall ross.lagerw...@citrix.com This contains the event machinery and state machines to write non-checkpointed migration v2 stream (with the exception of the xc_domain_save() handling which is spliced later in a bisectable way). Signed-off-by: Ross Lagerwall

[Xen-devel] [PATCH v3 26/28] tools/libxl: Handle checkpoint records in a libxl migration v2 stream

2015-07-13 Thread Andrew Cooper
This is the final bit of untangling for Remus. When libxc issues a checkpoint callback, start reading and buffering all libxl records from the stream. Once a CHECKPOINT_END record is encountered, start processing all records. Signed-off-by: Andrew Cooper andrew.coop...@citrix.com CC: Ian

[Xen-devel] [PATCH v3 24/28] tools/libxl: Write checkpoint records into the stream

2015-07-13 Thread Andrew Cooper
when signalled to do so by libxl__remus_domain_checkpoint_callback() Signed-off-by: Andrew Cooper andrew.coop...@citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com CC: Ian Jackson ian.jack...@eu.citrix.com CC: Wei Liu wei.l...@citrix.com --- v3: Corrections to comments This patch has

[Xen-devel] [PATCH v3 13/28] tools/python: Other migration infrastructure

2015-07-13 Thread Andrew Cooper
Contains: * Reverse-engineered notes of the legacy format from xg_save_restore.h * Python implementation of the legacy format * Public HVM Params used in the legacy stream * XL header format Signed-off-by: Andrew Cooper andrew.coop...@citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com

[Xen-devel] [PATCH v3 10/28] docs: Libxl migration v2 stream specification

2015-07-13 Thread Andrew Cooper
Signed-off-by: Andrew Cooper andrew.coop...@citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com CC: Ian Jackson ian.jack...@eu.citrix.com CC: Wei Liu wei.l...@citrix.com --- v3: Spelling fixes --- docs/specs/libxl-migration-stream.pandoc | 205 ++ 1 file

[Xen-devel] [PATCH v3 19/28] tools/libxl: Convert a legacy stream if needed

2015-07-13 Thread Andrew Cooper
For backwards compatibility, a legacy stream needs converting before it can be read by the v2 stream logic. This causes the v2 stream logic to need to juggle two parallel tasks. check_all_finished() is introduced for the purpose of joining the tasks in both success and error cases.

[Xen-devel] [PATCH v3 11/28] tools/python: Libxc migration v2 infrastructure

2015-07-13 Thread Andrew Cooper
Contains: * Python implementation of the libxc migration v2 records * Verification code for spec compliance * Unit tests Signed-off-by: Andrew Cooper andrew.coop...@citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com CC: Ian Jackson ian.jack...@eu.citrix.com CC: Wei Liu

[Xen-devel] [PATCH v3 17/28] tools/libxl: Infrastructure for reading a libxl migration v2 stream

2015-07-13 Thread Andrew Cooper
From: Ross Lagerwall ross.lagerw...@citrix.com This contains the event machinery and state machines to read an act on a non-checkpointed migration v2 stream (with the exception of the xc_domain_restore() handling which is spliced later in a bisectable way). It also contains some boilerplate to

[Xen-devel] [PATCH v3 23/28] docs/libxl: Introduce CHECKPOINT_END to support migration v2 remus streams

2015-07-13 Thread Andrew Cooper
In a remus scenario, libxc will write a CHECKPOINT record, then hand ownership of the fd to libxl. Libxl then writes any records required and finishes with a CHECKPOINT_END record, then hands ownership of the fd back to libxc. Signed-off-by: Andrew Cooper andrew.coop...@citrix.com Acked-by: Ian

[Xen-devel] [PATCH v3 28/28] tools/libxl: Drop all knowledge of toolstack callbacks

2015-07-13 Thread Andrew Cooper
Libxl has now been fully adjusted not to need them. Signed-off-by: Andrew Cooper andrew.coop...@citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com CC: Ian Jackson ian.jack...@eu.citrix.com CC: Wei Liu wei.l...@citrix.com --- tools/libxl/libxl_dom.c|1 -

[Xen-devel] [libvirt test] 59488: regressions - FAIL

2015-07-13 Thread osstest service owner
flight 59488 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/59488/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt5 libvirt-build fail REGR. vs. 58842 build-i386-pvops

[Xen-devel] [PATCH v2 1/3] arm64: Add Xen boot support file

2015-07-13 Thread fu . wei
From: Fu Wei fu@linaro.org This patch adds Xen boot support file: grub-core/loader/arm64/xen_boot.c include/grub/arm64/xen_boot.h This patch also adds commands register code and hearder file into grub-core/loader/arm64/linux.c - This adds support for the Xen boot on ARM specification for

[Xen-devel] [PATCH v2 3/3] arm64: Add the introduction of Xen boot command

2015-07-13 Thread fu . wei
From: Fu Wei fu@linaro.org This patch adds the introduction of xen_hypervisor/xen_module commands in docs/grub.texi Signed-off-by: Fu Wei fu@linaro.org --- docs/grub.texi | 27 +++ 1 file changed, 27 insertions(+) diff --git a/docs/grub.texi b/docs/grub.texi

Re: [Xen-devel] [v7][PATCH 16/16] tools: parse to enable new rdm policy parameters

2015-07-13 Thread Chen, Tiejun
On 2015/7/13 17:40, Ian Campbell wrote: On Mon, 2015-07-13 at 17:31 +0800, Chen, Tiejun wrote: I still can't understand what I'm missing here after compared to other contexts inside xlu_pci_parse_bdf(). Perhaps comparing to the CODING_STYLE document would help? Looks the whole

Re: [Xen-devel] [v7][PATCH 16/16] tools: parse to enable new rdm policy parameters

2015-07-13 Thread Ian Campbell
On Mon, 2015-07-13 at 17:55 +0800, Chen, Tiejun wrote: On 2015/7/13 17:40, Ian Campbell wrote: On Mon, 2015-07-13 at 17:31 +0800, Chen, Tiejun wrote: I still can't understand what I'm missing here after compared to other contexts inside xlu_pci_parse_bdf(). Perhaps comparing to the

Re: [Xen-devel] [PATCH OSSTEST v2 06/13] toolstack/libvirt: guest migrate, save and restore support

2015-07-13 Thread Ian Campbell
On Sun, 2015-07-12 at 17:20 +0100, Wei Liu wrote: Perhaps the libvirt part of the check_for_command stuff ought to be moved here? Otherwise we are claiming support before the code is actually willing to try to do so. Signed-off-by: Wei Liu wei.l...@citrix.com Cc: Ian Campbell

Re: [Xen-devel] Deadlock in stdvga_mem_accept() with emulation

2015-07-13 Thread Paul Durrant
-Original Message- From: Razvan Cojocaru [mailto:rcojoc...@bitdefender.com] Sent: 13 July 2015 13:08 To: Paul Durrant; Andrew Cooper; xen-devel@lists.xen.org Cc: Keir (Xen.org); Jan Beulich Subject: Re: [Xen-devel] Deadlock in stdvga_mem_accept() with emulation On 07/13/2015 03:04

[Xen-devel] [rumpuserxen test] 59489: regressions - FAIL

2015-07-13 Thread osstest service owner
flight 59489 rumpuserxen real [real] http://logs.test-lab.xenproject.org/osstest/logs/59489/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-rumpuserxen 5 rumpuserxen-build fail REGR. vs. 33866

Re: [Xen-devel] [PATCH v4 for Xen 4.6 1/4] xen: enable per-VCPU parameter settings for RTDS scheduler

2015-07-13 Thread Jan Beulich
On 11.07.15 at 06:52, lichong...@gmail.com wrote: @@ -1162,8 +1176,82 @@ rt_dom_cntl( } spin_unlock_irqrestore(prv-lock, flags); break; +case XEN_DOMCTL_SCHEDOP_getvcpuinfo: +spin_lock_irqsave(prv-lock, flags); +for ( index = 0; index

Re: [Xen-devel] [PATCH v8 05/11] xen: grant_table: implement grant_table_warn_active_grants()

2015-07-13 Thread Ian Campbell
On Mon, 2015-07-13 at 09:45 +0100, Jan Beulich wrote: On 10.07.15 at 18:24, konrad.w...@oracle.com wrote: On Tue, Jun 23, 2015 at 06:11:47PM +0200, Vitaly Kuznetsov wrote: Log first 10 active grants of a domain. This function is going to be used for soft reset, active grants on this path

Re: [Xen-devel] [PATCH v8 05/11] xen: grant_table: implement grant_table_warn_active_grants()

2015-07-13 Thread Vitaly Kuznetsov
Jan Beulich jbeul...@suse.com writes: On 13.07.15 at 11:08, ian.campb...@citrix.com wrote: On Mon, 2015-07-13 at 09:45 +0100, Jan Beulich wrote: On 10.07.15 at 18:24, konrad.w...@oracle.com wrote: On Tue, Jun 23, 2015 at 06:11:47PM +0200, Vitaly Kuznetsov wrote: Log first 10 active grants

Re: [Xen-devel] [PATCH 8/9] xl: fix main_cpupoolcreate

2015-07-13 Thread Ian Campbell
On Fri, 2015-07-10 at 19:00 +0100, Wei Liu wrote: Don't dereference extra_config if it's NULL. Don't leak extra_config in the end. Subject should be more descriptive. xl: correct handling of extra_config in main_cpupoolcreate perhaps? (It's a lot easier to write non-vague messages for patches

Re: [Xen-devel] Deadlock in stdvga_mem_accept() with emulation

2015-07-13 Thread Paul Durrant
-Original Message- From: Razvan Cojocaru [mailto:rcojoc...@bitdefender.com] Sent: 13 July 2015 10:42 To: Paul Durrant; Andrew Cooper; xen-devel@lists.xen.org Cc: Keir (Xen.org); Jan Beulich Subject: Re: [Xen-devel] Deadlock in stdvga_mem_accept() with emulation On 07/13/2015 12:05

Re: [Xen-devel] [PATCH 7/9] libxl: qmp_init_handler can return NULL

2015-07-13 Thread Ian Campbell
On Fri, 2015-07-10 at 19:00 +0100, Wei Liu wrote: Signed-off-by: Wei Liu wei.l...@citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com (although the only actual reason for a failure today is a memory allocation failure, which ought to abort really). --- tools/libxl/libxl_qmp.c | 1 +

Re: [Xen-devel] [PATCH V2 1/1] libxl: set stub domain size based on VRAM size

2015-07-13 Thread Ian Campbell
On Mon, 2015-07-13 at 11:22 +0100, Ian Jackson wrote: Ian Jackson writes (Re: [PATCH V2 1/1] libxl: set stub domain size based on VRAM size): Eric Shelton writes ([PATCH V2 1/1] libxl: set stub domain size based on VRAM size): Allocate additional memory to the stub domain for

[Xen-devel] [qemu-mainline test] 59483: regressions - FAIL

2015-07-13 Thread osstest service owner
flight 59483 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/59483/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-debianhvm-amd64-xsm 11 guest-saverestore fail REGR. vs. 59059

Re: [Xen-devel] [PATCH V2 1/1] libxl: set stub domain size based on VRAM size

2015-07-13 Thread Ian Jackson
Ian Campbell writes (Re: [PATCH V2 1/1] libxl: set stub domain size based on VRAM size): On Mon, 2015-07-13 at 11:22 +0100, Ian Jackson wrote: In a moment I am going to send a v3 which uses max_t and uint64_t (which is the type of the memkb fields and also obviously correct). Eric already

Re: [Xen-devel] [PATCH OSSTEST v2 03/13] osstest migrate support check catch - variables

2015-07-13 Thread Ian Campbell
On Sun, 2015-07-12 at 17:20 +0100, Wei Liu wrote: @@ -300,7 +300,9 @@ proc run-job/test-pair {} { } proc test-guest-migr {g} { -if {[catch { run-ts . = ts-migrate-support-check + host $g }]} return +set to_reap [spawn-ts . = ts-migrate-support-check + host $g] Most other uses of

[Xen-devel] [PATCH for-4.6] tools: libxl: Handle failure to create qemu dm logfile

2015-07-13 Thread Ian Campbell
If libxl_create_logfile fails for some reason then libxl__create_qemu_logfile previously just carried on and dereferenced the uninitialised logfile. Check for the error from libxl_create_logfile, which has already logged for us. This was reported as Debian bug #784880. Reported-by: Russell

Re: [Xen-devel] Deadlock in stdvga_mem_accept() with emulation

2015-07-13 Thread Razvan Cojocaru
On 07/13/2015 11:10 AM, Andrew Cooper wrote: On 13/07/2015 08:48, Razvan Cojocaru wrote: Hello, I'm battling the following hypervisor crash with current staging: (d2) Invoking ROMBIOS ... (XEN) stdvga.c:147:d2v0 entering stdvga and caching modes (d2) VGABios $Id: vgabios.c,v 1.67

Re: [Xen-devel] [PATCH v2] x86/hvm: add support for broadcast of buffered ioreqs...

2015-07-13 Thread Paul Durrant
-Original Message- From: Jan Beulich [mailto:jbeul...@suse.com] Sent: 13 July 2015 09:44 To: Paul Durrant Cc: Andrew Cooper; xen-devel@lists.xen.org; Keir (Xen.org) Subject: Re: [PATCH v2] x86/hvm: add support for broadcast of buffered ioreqs... On 10.07.15 at 18:07,

Re: [Xen-devel] [v7][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

2015-07-13 Thread Chen, Tiejun
Do you mean I should merge them as one as possible? Factor it out means to break out into a separate function (or maybe a macro or something, but in this case a function is appropriate). So in this case take the two sets of similar code, combine them into a function with appropriate arguments,

Re: [Xen-devel] [PATCH v4 11/17] xen/arm: ITS: Add GICR register emulation

2015-07-13 Thread Ian Campbell
On Mon, 2015-07-13 at 10:28 +0100, Ian Campbell wrote: On Sat, 2015-07-11 at 20:25 +0200, Julien Grall wrote: Hi, On 10/07/2015 17:10, Ian Campbell wrote: Extra space after the . @@ -694,6 +755,14 @@ static int vgic_v3_distr_mmio_read(struct vcpu *v, mmio_info_t *info)

Re: [Xen-devel] [PATCH] x86: avoid invalid phys_proc_id reference

2015-07-13 Thread Chao Peng
On Mon, Jul 13, 2015 at 09:55:39AM +0100, Jan Beulich wrote: On 13.07.15 at 05:36, chao.p.p...@linux.intel.com wrote: phys_proc_id is invalidated in remove_siblinginfo() which gets called before cpu_smpboot_free(). This means calling cpu_to_socket(cpu) in cpu_smpboot_free() is not possible

Re: [Xen-devel] [PATCH] MAINTAINERS: support for xen-access and email change

2015-07-13 Thread Ian Campbell
On Fri, 2015-07-10 at 16:39 +0100, Jan Beulich wrote: On 10.07.15 at 17:29, tleng...@novetta.com wrote: Add tools/tests/xen-acess to the supported list under VM EVENT/MEM ACCESS. Also, changing my e-mail to the preferred one, as it is in many of the headers already. Signed-off-by:

Re: [Xen-devel] [PATCH v4 07/17] xen/arm: ITS: Add virtual ITS commands support

2015-07-13 Thread Vijay Kilari
On Mon, Jul 13, 2015 at 2:52 PM, Ian Campbell ian.campb...@citrix.com wrote: On Sat, 2015-07-11 at 20:19 +0530, Vijay Kilari wrote: +int vgic_its_process_cmd(struct vcpu *v, struct vgic_its *vits) +{ +its_cmd_block virt_cmd; + +ASSERT(spin_is_locked(vits-lock)); + +do {

Re: [Xen-devel] [PATCH OSSTEST v2 09/13] ts-debian-hvm-install: stub out libvirt + ovmf / rombios

2015-07-13 Thread Ian Campbell
On Sun, 2015-07-12 at 17:20 +0100, Wei Liu wrote: Libvirt's configuration converter doesn't know how to deal with BIOS selection. The end result is it always use the default one (seabios). Stub out ovmf and rombios to avoid false positive results. It's worth mentioning here whether or not we

Re: [Xen-devel] [PATCH v4 07/17] xen/arm: ITS: Add virtual ITS commands support

2015-07-13 Thread Ian Campbell
On Mon, 2015-07-13 at 16:45 +0530, Vijay Kilari wrote: BTW, I want to know if atomic_t supports 64-bit access?. I don't know off the top of my head. I'm sure it would be apparent in the code. Ian. ___ Xen-devel mailing list Xen-devel@lists.xen.org

[Xen-devel] [PATCH v3 09/28] tools/xl: Mandatory flag indicating the format of the migration stream

2015-07-13 Thread Andrew Cooper
Introduced at this point so the python stream conversion code has a concrete ABI to use. Later when libxl itself starts supporting a v2 stream, it will be added to XL_MANDATORY_FLAG_ALL. Signed-off-by: Andrew Cooper andrew.coop...@citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com CC: Ian

[Xen-devel] [PATCH v3 06/28] tools/libxl: Split libxl__domain_create_state.restore_fd in two

2015-07-13 Thread Andrew Cooper
In a future patch, we shall support automatically converting a legacy stream to a v2 stream, in which case libxc needs to read from a different fd. Simply overwriting restore_fd does not work; the two fd's have different circumstances. The restore_fd needs to be returned to its original state

[Xen-devel] [PATCH v3 00/27] Libxl migration v2

2015-07-13 Thread Andrew Cooper
This series adds support for the libxl migration v2 stream, and untangles the existing layering violations of the toolstack and qemu records. It can be found on the branch libxl-migv2-v3 git://xenbits.xen.org/people/andrewcoop/xen.git http://xenbits.xen.org/git-http/people/andrewcoop/xen.git

[Xen-devel] [PATCH v3 03/28] tools/libxl: Introduce ROUNDUP()

2015-07-13 Thread Andrew Cooper
This is the same as is used by libxc. Signed-off-by: Andrew Cooper andrew.coop...@citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com CC: Ian Jackson ian.jack...@eu.citrix.com CC: Wei Liu wei.l...@citrix.com --- tools/libxl/libxl_internal.h |3 +++ 1 file changed, 3 insertions(+) diff

[Xen-devel] [PATCH v3 07/28] tools/libxl: Extra management APIs for the save helper

2015-07-13 Thread Andrew Cooper
With migration v2, there are several moving parts needing to be juggled at once. This requires the error handling logic to be able to query the state of each moving part, possibly before they have been started, and be able to cancel them. Signed-off-by: Andrew Cooper andrew.coop...@citrix.com

[Xen-devel] [PATCH v3 01/28] bsd-sys-queue-h-seddery: Massage `offsetof'

2015-07-13 Thread Andrew Cooper
From: Ian Jackson ian.jack...@eu.citrix.com For some reason BSD's queue.h uses `__offsetof'. It expects it to work just like offsetof. So use offsetof. Reported-by: Andrew Cooper andrew.coop...@citrix.com Signed-off-by: Ian Jackson ian.jack...@eu.citrix.com Acked-by: Ian Campbell

[Xen-devel] [PATCH v3 04/28] tools/libxl: Introduce libxl__kill()

2015-07-13 Thread Andrew Cooper
as a wrapper to kill(2), and use it in preference to sendsig in libxl_save_callout.c. Signed-off-by: Andrew Cooper andrew.coop...@citrix.com Acked-by: Wei Liu wei.l...@citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com CC: Ian Jackson ian.jack...@eu.citrix.com --- v3: Fix typo, add

[Xen-devel] [PATCH v3 08/28] tools/libxl: Add save_helper_state pointers to libxl__xc_domain_{save, restore}()

2015-07-13 Thread Andrew Cooper
Currently, libxl__xc_domain_{save,restore}() have specific knowledge of where the libxl__save_helper_state lives inside a libxl__domain_{create,save}_state object. In later changes, the logical ownership of the libxl__save_helper_state will change and will no longer be d{c,s}s-shs. No functional

[Xen-devel] [PATCH v3 02/28] tools/libxc: Always compile the compat qemu variables into xc_sr_context

2015-07-13 Thread Andrew Cooper
This is safe (as the variables will simply be unused), and is required for correct compilation when midway through untangling the libxc/libxl interaction. The #define is left in place to highlight that the variables can be removed once the untangling is complete. Signed-off-by: Andrew Cooper

[Xen-devel] [PATCH v3 05/28] tools/libxl: Stash all restore parameters in domain_create_state

2015-07-13 Thread Andrew Cooper
Shortly more parameters will appear, and this saves unboxing each one. libxl_domain_restore_params is mandatory for restore streams, and ignored for plain creation. The old 'checkpointed_stream' was incorrectly identified as a private parameter when it was infact public. No functional change.

[Xen-devel] [xen-unstable test] 59485: regressions - trouble: broken/fail/pass

2015-07-13 Thread osstest service owner
flight 59485 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/59485/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 9 debian-hvm-install fail REGR. vs. 58965

Re: [Xen-devel] Requesting for freeze exception for VT-d posted-interrupts

2015-07-13 Thread Jan Beulich
On 13.07.15 at 08:55, feng...@intel.com wrote: There are two main outstanding issues so far: 1. Jan's security concern. I have proposed some solutions but Jan still has some problems with my proposals. It would be great if Jan can give a clear proposal so that we can discuss and keep making

Re: [Xen-devel] Deadlock in stdvga_mem_accept() with emulation

2015-07-13 Thread Paul Durrant
-Original Message- From: Razvan Cojocaru [mailto:rcojoc...@bitdefender.com] Sent: 13 July 2015 10:03 To: Paul Durrant; Andrew Cooper; xen-devel@lists.xen.org Cc: Keir (Xen.org); Jan Beulich Subject: Re: [Xen-devel] Deadlock in stdvga_mem_accept() with emulation On 07/13/2015 12:01

Re: [Xen-devel] Question about mapping between domains

2015-07-13 Thread Ian Campbell
On Thu, 2015-07-09 at 16:31 +0300, Oleksandr Dmytryshyn wrote: I have some questions: 1. Is this a correct solution? 2. Could this solution be considered as a normal (not hack)? 3. If not then could anybody help me to implement this in the right way? The way we deal with this elsewhere in the

Re: [Xen-devel] [PATCH v4 05/17] xen/arm: ITS: implement hw_irq_controller for LPIs

2015-07-13 Thread Ian Campbell
On Sat, 2015-07-11 at 20:10 +0530, Vijay Kilari wrote: On Fri, Jul 10, 2015 at 7:16 PM, Ian Campbell ian.campb...@citrix.com wrote: On Fri, 2015-07-10 at 13:12 +0530, vijay.kil...@gmail.com wrote: From: Vijaya Kumar K vijaya.ku...@caviumnetworks.com Implements hw_irq_controller api's

Re: [Xen-devel] Deadlock in stdvga_mem_accept() with emulation

2015-07-13 Thread Razvan Cojocaru
On 07/13/2015 12:05 PM, Paul Durrant wrote: -Original Message- From: Razvan Cojocaru [mailto:rcojoc...@bitdefender.com] Sent: 13 July 2015 10:03 To: Paul Durrant; Andrew Cooper; xen-devel@lists.xen.org Cc: Keir (Xen.org); Jan Beulich Subject: Re: [Xen-devel] Deadlock in

Re: [Xen-devel] [v7][PATCH 16/16] tools: parse to enable new rdm policy parameters

2015-07-13 Thread Ian Campbell
On Mon, 2015-07-13 at 17:31 +0800, Chen, Tiejun wrote: I still can't understand what I'm missing here after compared to other contexts inside xlu_pci_parse_bdf(). Perhaps comparing to the CODING_STYLE document would help? So I have to paste this entirely, }else if (

Re: [Xen-devel] Deadlock in stdvga_mem_accept() with emulation

2015-07-13 Thread Jan Beulich
On 13.07.15 at 11:30, paul.durr...@citrix.com wrote: -Original Message- From: Jan Beulich [mailto:jbeul...@suse.com] Sent: 13 July 2015 10:28 To: Paul Durrant Cc: Razvan Cojocaru; Andrew Cooper; xen-devel@lists.xen.org; Keir (Xen.org) Subject: RE: [Xen-devel] Deadlock in

Re: [Xen-devel] [PATCH V5 0/7] xen pvusb toolstack work

2015-07-13 Thread Juergen Gross
On 06/25/2015 12:07 PM, Chunyan Liu wrote: This patch series is to add pvusb toolstack work, supporting hot add|remove USB device to|from guest and specify USB device in domain configuration file. Patches 1-6: Tested-by: Juergen Gross jgr...@suse.com Juergen Changes to v4: * use

Re: [Xen-devel] [PATCH V5 7/7] domcreate: support pvusb in configuration file

2015-07-13 Thread Juergen Gross
On 06/25/2015 12:07 PM, Chunyan Liu wrote: Add code to support pvusb in domain config file. One could specify usbctrl and usb in domain's configuration file and create domain, then usb controllers will be created and usb device would be attached to guest automatically. One could specify usb

Re: [Xen-devel] [PATCH 6/9] libxl: localtime(3) can return NULL

2015-07-13 Thread Ian Campbell
On Fri, 2015-07-10 at 19:00 +0100, Wei Liu wrote: Signed-off-by: Wei Liu wei.l...@citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] Requesting for freeze exception for VT-d posted-interrupts

2015-07-13 Thread Wei Liu
On Mon, Jul 13, 2015 at 06:55:30AM +, Wu, Feng wrote: Hi maintainers, We would like to request an extension for freeze exception for VT-d posted-interrupts patch-set. 1. clarify the state of patch series / feature. [v3 01/15] Vt-d Posted-interrupt (PI) design Reviewed-by: Kevin Tian

Re: [Xen-devel] [PATCH v2] x86/hvm: add support for broadcast of buffered ioreqs...

2015-07-13 Thread Jan Beulich
On 10.07.15 at 18:07, paul.durr...@citrix.com wrote: @@ -2710,17 +2711,21 @@ int hvm_send_assist_req(struct hvm_ioreq_server *s, ioreq_t *proto_p) return X86EMUL_UNHANDLEABLE; } -void hvm_broadcast_assist_req(ioreq_t *p) +int hvm_broadcast_ioreq(ioreq_t *p, bool_t buffered) {

Re: [Xen-devel] [PATCH v8 05/11] xen: grant_table: implement grant_table_warn_active_grants()

2015-07-13 Thread Jan Beulich
On 10.07.15 at 18:24, konrad.w...@oracle.com wrote: On Tue, Jun 23, 2015 at 06:11:47PM +0200, Vitaly Kuznetsov wrote: Log first 10 active grants of a domain. This function is going to be used for soft reset, active grants on this path usually mean misbehaving backends refusing to release

Re: [Xen-devel] Deadlock in stdvga_mem_accept() with emulation

2015-07-13 Thread Razvan Cojocaru
On 07/13/2015 12:01 PM, Paul Durrant wrote: -Original Message- From: Razvan Cojocaru [mailto:rcojoc...@bitdefender.com] Sent: 13 July 2015 09:50 To: Andrew Cooper; xen-devel@lists.xen.org Cc: Keir (Xen.org); Jan Beulich; Paul Durrant Subject: Re: Deadlock in stdvga_mem_accept() with

Re: [Xen-devel] [PATCH v4 07/17] xen/arm: ITS: Add virtual ITS commands support

2015-07-13 Thread Ian Campbell
On Sat, 2015-07-11 at 20:19 +0530, Vijay Kilari wrote: +int vgic_its_process_cmd(struct vcpu *v, struct vgic_its *vits) +{ +its_cmd_block virt_cmd; + +ASSERT(spin_is_locked(vits-lock)); + +do { +if ( vgic_its_read_virt_cmd(v, vits, virt_cmd) ) +

Re: [Xen-devel] Interested in taking up a project

2015-07-13 Thread Dario Faggioli
On Sat, 2015-07-11 at 02:03 +0530, Abhinav Gupta wrote: Hi everyone, Hey, :-) I'm sorry for the late update. Actually I had another project going on in parallel, didn't want to distribute efforts. Sure, no problem. I went through the implementation approach of powerclamp, it controls

Re: [Xen-devel] [PATCH 5/9] libxl: avoid leaking string in cpupool_info

2015-07-13 Thread Ian Campbell
On Fri, 2015-07-10 at 19:00 +0100, Wei Liu wrote: Signed-off-by: Wei Liu wei.l...@citrix.com Would an if (rc) libxl_cpupoolinfo_dispose(info) on the exit path be a more robust alternative? Might require the addition of a libxl_cpupoolinfo_init() somewhere before any possible error. ---

Re: [Xen-devel] [xen-unstable test] 59472: regressions - FAIL

2015-07-13 Thread Jan Beulich
On 13.07.15 at 03:43, osstest-ad...@xenproject.org wrote: flight 59472 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/59472/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run:

[Xen-devel] [PATCH v2] x86: avoid invalid phys_proc_id reference

2015-07-13 Thread Chao Peng
phys_proc_id is invalidated in remove_siblinginfo() which gets called before cpu_smpboot_free(). This means calling cpu_to_socket(cpu) in cpu_smpboot_free() is not possible to be correct. This patch moves the invalidating of phys_proc_id from remove_siblinginfo() to cpu_smpboot_free() so that

Re: [Xen-devel] [PATCH OSSTEST v2 08/13] ts-libvirt-build: run libvirt test suite

2015-07-13 Thread Ian Campbell
On Sun, 2015-07-12 at 17:20 +0100, Wei Liu wrote: We're interested in xlconfigtest. Signed-off-by: Wei Liu wei.l...@citrix.com Cc: Ian Campbell ian.campb...@citrix.com Cc: Ian Jackson ian.jack...@eu.citrix.com [...] + | tee ../libvirt-test-suite-log Should something be

  1   2   3   >