Re: [Xen-devel] [PATCH v2 21/23] x86/boot: implement early command line parser in C

2015-08-27 Thread Jan Beulich
On 20.07.15 at 16:29, daniel.ki...@oracle.com wrote: Current early command line parser implementation in assembler is very difficult to change to relocatable stuff using segment registers. This requires a lot of changes in very weird and fragile code. So, reimplement this functionality in C.

Re: [Xen-devel] [PATCH v2 4/8] tmem: Remove xc_tmem_control mystical arg3

2015-08-27 Thread Andrew Cooper
On 27/08/15 12:01, Konrad Rzeszutek Wilk wrote: It mentions it but it is never used. The hypercall interface knows nothing of this sort of thing either. Lets just remove it. Signed-off-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com It would be nice if you could take the opportunity of

Re: [Xen-devel] [PATCH v2] Tmem bug-fixes and cleanups.

2015-08-27 Thread Andrew Cooper
On 27/08/15 12:01, Konrad Rzeszutek Wilk wrote: Hey! At the Xenhackathon we spoke that the tmem code needs a bit of cleanups and simplification. One of the things that Andrew mentioned was that the TMEM_CONTROL should really be part of the sysctl hypercall. As I ventured this path I realized

Re: [Xen-devel] [PATCH v2 5/8] tmem: Move TMEM_CONTROL subop of tmem hypercall to sysctl.

2015-08-27 Thread Andrew Cooper
On 27/08/15 12:02, Konrad Rzeszutek Wilk wrote: --- a/tools/python/xen/lowlevel/xc/xc.c +++ b/tools/python/xen/lowlevel/xc/xc.c @@ -1808,25 +1808,25 @@ static PyObject *pyxc_tmem_control(XcObject *self, pool_id, subop, cli_id, arg1, arg2, buf) ) return NULL;

[Xen-devel] [linux-linus test] 60877: regressions - FAIL

2015-08-27 Thread osstest service owner
flight 60877 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/60877/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl 14 guest-saverestore fail REGR. vs. 59254

Re: [Xen-devel] [PATCH v2] Tmem bug-fixes and cleanups.

2015-08-27 Thread Wei Liu
On Thu, Aug 27, 2015 at 07:01:55AM -0400, Konrad Rzeszutek Wilk wrote: Hey! At the Xenhackathon we spoke that the tmem code needs a bit of cleanups and simplification. One of the things that Andrew mentioned was that the TMEM_CONTROL should really be part of the sysctl hypercall. As I

Re: [Xen-devel] xen 4.6 regression: xl create fails if domU have custom vifname

2015-08-27 Thread Wei Liu
On Thu, Aug 27, 2015 at 04:41:46PM +0200, Fabio Fantoni wrote: Today trying xen 4.6.0-rc2 with all things needed for future production server I found a regression: xl create fails if domU have custom vifname. xl create test.cfg Parsing config from test.cfg libxl: error:

[Xen-devel] [PATCH] IOMMU: skip domains without page tables when dumping

2015-08-27 Thread Jan Beulich
Reported-by: Roger Pau Monné roger@citrix.com Signed-off-by: Jan Beulich jbeul...@suse.com --- a/xen/drivers/passthrough/iommu.c +++ b/xen/drivers/passthrough/iommu.c @@ -411,7 +411,7 @@ static void iommu_dump_p2m_table(unsigne ops = iommu_get_ops(); for_each_domain(d) { -

Re: [Xen-devel] [PATCH] IOMMU: skip domains without page tables when dumping

2015-08-27 Thread Roger Pau Monné
Thanks, this solves the problem. El 27/08/15 a les 16.04, Jan Beulich ha escrit: Reported-by: Roger Pau Monné roger@citrix.com Signed-off-by: Jan Beulich jbeul...@suse.com Tested-by: Roger Pau Monné roger@citrix.com Acked-by: Roger Pau Monné roger@citrix.com ---

Re: [Xen-devel] [URGENT RFC] Branching and reopening -unstable

2015-08-27 Thread George Dunlap
On Tue, Aug 11, 2015 at 12:13 PM, Ian Jackson ian.jack...@eu.citrix.com wrote: B 1(c)(maintainer)/2(a)/3(a) Branch. Maintainers may choose to defer patch series based on risk of conflicts with bugfixes required for 4.6. Clear communication with submitters is required. Bugfixes

Re: [Xen-devel] [PATCH] x86/NUMA: make init_node_heap() respect Xen heap limit

2015-08-27 Thread Wei Liu
On Thu, Aug 27, 2015 at 02:37:17AM -0600, Jan Beulich wrote: On NUMA systems, where we try to use node local memory for the basic control structures of the buddy allocator, this special case needs to take into consideration a possible address width limit placed on the Xen heap. In turn this

Re: [Xen-devel] [PATCH v2 7/8] tmem: Remove extra spaces at end and some hard tabbing.

2015-08-27 Thread Andrew Cooper
On 27/08/15 12:02, Konrad Rzeszutek Wilk wrote: @@ -1559,7 +1559,7 @@ refind: { /* no puts allowed into a frozen pool (except dup puts) */ if ( client-frozen ) - goto unlock_obj; + goto unlock_obj; Need to lose 3 spaces here.

Re: [Xen-devel] [BUG] 'o' debug key panics the hypervisor

2015-08-27 Thread Roger Pau Monné
El 27/08/15 a les 14.02, Andrew Cooper ha escrit: On 27/08/15 12:29, Roger Pau Monné wrote: Hello, When using Intel hardware without shared page tables between the IOMMU and EPT (I have not tried if the same happens when sharing the page tables), the following crash happens if I press the

Re: [Xen-devel] Design doc of adding ACPI support for arm64 on Xen - version 4

2015-08-27 Thread Shannon Zhao
On 2015/8/27 15:52, Jan Beulich wrote: On 27.08.15 at 02:37, julien.gr...@citrix.com wrote: On 20/08/2015 19:25, Shannon Zhao wrote: On 2015/8/20 22:06, Jan Beulich wrote: So can the two of you please sort out whether these are Linux internal tags (which Xen has no business generating, or

Re: [Xen-devel] [BUG] 'o' debug key panics the hypervisor

2015-08-27 Thread Jan Beulich
On 27.08.15 at 13:29, roger@citrix.com wrote: When using Intel hardware without shared page tables between the IOMMU and EPT (I have not tried if the same happens when sharing the page tables), the following crash happens if I press the 'o' debug key with a HVM guest running. The guest

Re: [Xen-devel] Design doc of adding ACPI support for arm64 on Xen - version 4

2015-08-27 Thread Shannon Zhao
On 2015/8/27 22:13, Jan Beulich wrote: On 27.08.15 at 15:50, shannon.z...@linaro.org wrote: On 2015/8/27 15:52, Jan Beulich wrote: One other aspect completely left off so far is that of proper isolation: What x86 exposes to Dom0 is specifically limited to what Dom0 is supposed to know. I'm

[Xen-devel] xen 4.6 regression: xl create fails if domU have custom vifname

2015-08-27 Thread Fabio Fantoni
Today trying xen 4.6.0-rc2 with all things needed for future production server I found a regression: xl create fails if domU have custom vifname. xl create test.cfg Parsing config from test.cfg libxl: error: libxl_exec.c:118:libxl_report_child_exitstatus: /etc/xen/scripts/vif-bridge add [14581]

[Xen-devel] [PATCH v2] libxenstore: prefer using the character device

2015-08-27 Thread Jonathan Creekmore
With the addition of FMODE_ATOMIC_POS in the Linux 3.14 kernel, concurrent blocking file accesses to a single open file descriptor can cause a deadlock trying to grab the file position lock. If a watch has been set up, causing a read_thread to blocking read on the file descriptor, then future

Re: [Xen-devel] Design doc of adding ACPI support for arm64 on Xen - version 4

2015-08-27 Thread Jan Beulich
On 27.08.15 at 15:50, shannon.z...@linaro.org wrote: On 2015/8/27 15:52, Jan Beulich wrote: One other aspect completely left off so far is that of proper isolation: What x86 exposes to Dom0 is specifically limited to what Dom0 is supposed to know. I'm getting the impression that by exposing

Re: [Xen-devel] [PATCH v2 22/23] x86: make Xen early boot code relocatable

2015-08-27 Thread Jan Beulich
On 20.07.15 at 16:29, daniel.ki...@oracle.com wrote: - %fs register is filled with segment descriptor which describes memory region with Xen image (it could be relocated or not); This is too fuzzy. Please be very precise which region it is that %fs is supposed to point to (so that

Re: [Xen-devel] [BUG] 'o' debug key panics the hypervisor

2015-08-27 Thread Roger Pau Monné
El 27/08/15 a les 16.01, Jan Beulich ha escrit: On 27.08.15 at 13:29, roger@citrix.com wrote: When using Intel hardware without shared page tables between the IOMMU and EPT (I have not tried if the same happens when sharing the page tables), the following crash happens if I press the 'o'

Re: [Xen-devel] [PATCH v2 22/23] x86: make Xen early boot code relocatable

2015-08-27 Thread Ben Hildred
On Thu, Aug 27, 2015 at 9:29 AM, Jan Beulich jbeul...@suse.com wrote: On 27.08.15 at 17:10, daniel.ki...@oracle.com wrote: On Thu, Aug 27, 2015 at 07:12:38AM -0600, Jan Beulich wrote: On 20.07.15 at 16:29, daniel.ki...@oracle.com wrote: /* Copy bootstrap trampoline to low

Re: [Xen-devel] [PATCH] x86: wrap kexec feature with CONFIG_KEXEC

2015-08-27 Thread Jan Beulich
On 27.08.15 at 17:22, andrew.coop...@citrix.com wrote: On 27/08/15 15:47, Jonathan Creekmore wrote: @@ -812,7 +816,11 @@ ENTRY(hypercall_args_table) .byte 2 /* do_hvm_op*/ .byte 1 /* do_sysctl*/ /* 35 */ .byte 1 /* do_domctl*/

Re: [Xen-devel] [PATCH RFC] xen: if on Xen, flatten the scheduling domain hierarchy

2015-08-27 Thread George Dunlap
On Thu, Aug 27, 2015 at 11:24 AM, George Dunlap george.dun...@citrix.com wrote: On 08/18/2015 04:55 PM, Dario Faggioli wrote: Hey everyone, So, as a followup of what we were discussing in this thread: [Xen-devel] PV-vNUMA issue: topology is misinterpreted by the guest

Re: [Xen-devel] [RFC v2 for-4.6 0/2] In-tree feature documentation

2015-08-27 Thread Ian Jackson
Andrew Cooper writes (Re: [RFC v2 for-4.6 0/2] In-tree feature documentation): On 27/08/15 15:52, Ian Jackson wrote: I do wonder whether cross-referencing all the issues is a good idea. It seems like it might be a lot of work to keep them in step. I don't expect all the issues to be

Re: [Xen-devel] [PATCH v2] libxenstore: prefer using the character device

2015-08-27 Thread Wei Liu
On Thu, Aug 27, 2015 at 09:04:38AM -0500, Jonathan Creekmore wrote: With the addition of FMODE_ATOMIC_POS in the Linux 3.14 kernel, concurrent blocking file accesses to a single open file descriptor can cause a deadlock trying to grab the file position lock. If a watch has been set up, causing

Re: [Xen-devel] PAGE_SIZE (64KB), while block driver 'struct request' deals with PAGE_SIZE (up to 44Kb). Was:Re: [RFC] Support of non-indirect grant backend on 64KB guest

2015-08-27 Thread Julien Grall
Hi, On 21/08/15 18:10, Konrad Rzeszutek Wilk wrote: On Fri, Aug 21, 2015 at 05:08:35PM +0100, David Vrabel wrote: On 21/08/15 17:05, Konrad Rzeszutek Wilk wrote: I have to concur with that. We can't mandate that ARM 64k page MUST use indirect descriptors. Then it has to be fixed in the

Re: [Xen-devel] [PATCH for 4.6] build: fix tarball stubdom build

2015-08-27 Thread Ian Jackson
Wei Liu writes ([PATCH for 4.6] build: fix tarball stubdom build): When we create a source code tarball, mini-os is extracted to extras/mini-os directory. When building a source code tarball, we shouldn't clone mini-os again. Only clone mini-os when that directory doesn't exist. This fixes

Re: [Xen-devel] [PATCH v2] libxenstore: prefer using the character device

2015-08-27 Thread Ian Jackson
Wei Liu writes (Re: [Xen-devel] [PATCH v2] libxenstore: prefer using the character device): On Thu, Aug 27, 2015 at 09:04:38AM -0500, Jonathan Creekmore wrote: With the addition of FMODE_ATOMIC_POS in the Linux 3.14 kernel, concurrent blocking file accesses to a single open file descriptor

Re: [Xen-devel] [PATCH v2 22/23] x86: make Xen early boot code relocatable

2015-08-27 Thread Andrew Cooper
On 27/08/15 16:29, Jan Beulich wrote: On 27.08.15 at 17:10, daniel.ki...@oracle.com wrote: On Thu, Aug 27, 2015 at 07:12:38AM -0600, Jan Beulich wrote: On 20.07.15 at 16:29, daniel.ki...@oracle.com wrote: /* Copy bootstrap trampoline to low memory, below 1MB. */ -mov

Re: [Xen-devel] [PATCH] build: use correct qemu emulator binary

2015-08-27 Thread Ian Jackson
Wei Liu writes (Re: [Xen-devel] [PATCH] build: use correct qemu emulator binary): On Tue, Aug 25, 2015 at 08:45:07AM -0500, Doug Goldstein wrote: Per http://wiki.qemu.org/ChangeLog/1.0 and the fact that no currently supported distro ships the x86 system emulator binary as 'qemu', this

Re: [Xen-devel] [DOCS DAY] [PATCH for-4.6 0/5] Cleanup of docs spread throughout the tree

2015-08-27 Thread Ian Jackson
Wei Liu writes (Re: [Xen-devel] [DOCS DAY] [PATCH for-4.6 0/5] Cleanup of docs spread throughout the tree): On Wed, Aug 26, 2015 at 10:09:46AM +0100, Andrew Cooper wrote: Whole series: Acked-by: Wei Liu wei.l...@citrix.com Committed-by: Ian Jackson ian.jack...@eu.citrix.com Thanks, Ian.

Re: [Xen-devel] [RFC v2 for-4.6 0/2] In-tree feature documentation

2015-08-27 Thread Andrew Cooper
On 27/08/15 18:58, Ian Jackson wrote: Andrew Cooper writes (Re: [RFC v2 for-4.6 0/2] In-tree feature documentation): On 27/08/15 15:52, Ian Jackson wrote: I do wonder whether cross-referencing all the issues is a good idea. It seems like it might be a lot of work to keep them in step. I

Re: [Xen-devel] [PATCH v4 2/4] x86/compat: Test both PV and PVH guests for compat mode

2015-08-27 Thread Jan Beulich
On 13.08.15 at 20:12, boris.ostrov...@oracle.com wrote: @@ -777,7 +777,7 @@ int arch_set_info_guest( /* The context is a compat-mode one if the target domain is compat-mode; * we expect the tools to DTRT even in compat-mode callers. */ -compat = is_pv_32bit_domain(d); +

Re: [Xen-devel] [PATCH for 4.6] build: fix tarball stubdom build

2015-08-27 Thread Wei Liu
On Thu, Aug 27, 2015 at 10:05:56AM -0600, Jan Beulich wrote: On 27.08.15 at 17:54, wei.l...@citrix.com wrote: When we create a source code tarball, mini-os is extracted to extras/mini-os directory. When building a source code tarball, we shouldn't clone mini-os again. Only clone

Re: [Xen-devel] [PATCH v2 22/23] x86: make Xen early boot code relocatable

2015-08-27 Thread Daniel Kiper
On Thu, Aug 27, 2015 at 07:12:38AM -0600, Jan Beulich wrote: On 20.07.15 at 16:29, daniel.ki...@oracle.com wrote: [...] /* Copy bootstrap trampoline to low memory, below 1MB. */ -mov $sym_phys(trampoline_start),%esi +lea

Re: [Xen-devel] [PATCH v2 5/8] tmem: Move TMEM_CONTROL subop of tmem hypercall to sysctl.

2015-08-27 Thread Jan Beulich
On 27.08.15 at 13:02, konrad.w...@oracle.com wrote: @@ -2666,9 +2662,9 @@ long do_tmem_op(tmem_cli_op_t uops) /* Acquire wirte lock for all command at first */ write_lock(tmem_rwlock); -if ( op.cmd == TMEM_CONTROL ) +if ( op.cmd == TMEM_CONTROL_MOVED ) { -

Re: [Xen-devel] [RFC v2 for-4.6 0/2] In-tree feature documentation

2015-08-27 Thread Andrew Cooper
On 27/08/15 15:52, Ian Jackson wrote: Andrew Cooper writes ([RFC v2 for-4.6 0/2] In-tree feature documentation): An issue which Xen has is an uncertain support statement for features. Given the success seen with docs/misc/xen-command-line.markdown, and in particular keeping it up to date,

Re: [Xen-devel] [PATCH] x86: wrap kexec feature with CONFIG_KEXEC

2015-08-27 Thread Andrew Cooper
On 27/08/15 16:34, Jan Beulich wrote: On 27.08.15 at 17:22, andrew.coop...@citrix.com wrote: On 27/08/15 15:47, Jonathan Creekmore wrote: @@ -812,7 +816,11 @@ ENTRY(hypercall_args_table) .byte 2 /* do_hvm_op*/ .byte 1 /* do_sysctl*/ /* 35 */

Re: [Xen-devel] [PATCH] x86: wrap kexec feature with CONFIG_KEXEC

2015-08-27 Thread David Vrabel
On 27/08/15 15:47, Jonathan Creekmore wrote: Add the appropriate #if checks around the kexec code in the x86 codebase so that the feature can actually be turned off by the flag instead of always required to be enabled on x86. What's your use case for this? I think you should consider

[Xen-devel] [added to the 3.18 stable tree] x86/xen: Probe target addresses in set_aliased_prot() before the hypercall

2015-08-27 Thread Sasha Levin
From: Andy Lutomirski l...@kernel.org This patch has been added to the 3.18 stable tree. If you have any objections, please let us know. === [ Upstream commit aa1acff356bbedfd03b544051f5b371746735d89 ] The update_va_mapping hypercall can fail if the VA isn't present in the guest's

Re: [Xen-devel] [PATCH] x86: wrap kexec feature with CONFIG_KEXEC

2015-08-27 Thread Jonathan Creekmore
On Aug 27, 2015, at 10:27 AM, David Vrabel david.vra...@citrix.com wrote: On 27/08/15 15:47, Jonathan Creekmore wrote: Add the appropriate #if checks around the kexec code in the x86 codebase so that the feature can actually be turned off by the flag instead of always required to be

Re: [Xen-devel] [PATCH for 4.6] build: fix tarball stubdom build

2015-08-27 Thread Jan Beulich
On 27.08.15 at 17:54, wei.l...@citrix.com wrote: When we create a source code tarball, mini-os is extracted to extras/mini-os directory. When building a source code tarball, we shouldn't clone mini-os again. Only clone mini-os when that directory doesn't exist. This fixes tarball build and

Re: [Xen-devel] [RFC v2 for-4.6 0/2] In-tree feature documentation

2015-08-27 Thread Ian Jackson
Andrew Cooper writes ([RFC v2 for-4.6 0/2] In-tree feature documentation): An issue which Xen has is an uncertain support statement for features. Given the success seen with docs/misc/xen-command-line.markdown, and in particular keeping it up to date, introduce a similar system for features.

Re: [Xen-devel] [PATCH v2 5/8] tmem: Move TMEM_CONTROL subop of tmem hypercall to sysctl.

2015-08-27 Thread Jan Beulich
On 27.08.15 at 15:12, andrew.coop...@citrix.com wrote: On 27/08/15 12:02, Konrad Rzeszutek Wilk wrote: --- a/xen/include/xen/tmem.h +++ b/xen/include/xen/tmem.h @@ -9,6 +9,9 @@ #ifndef __XEN_TMEM_H__ #define __XEN_TMEM_H__ +struct xen_sysctl_tmem_op; #includepublic/sysctl.h please.

Re: [Xen-devel] [PATCH v2 8/8] tmem: Spelling mistakes.

2015-08-27 Thread Jan Beulich
On 27.08.15 at 13:02, konrad.w...@oracle.com wrote: Signed-off-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com --- xen/common/tmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/common/tmem.c b/xen/common/tmem.c index 66d2852..9bd75d8 100644 ---

Re: [Xen-devel] [PATCH] x86: wrap kexec feature with CONFIG_KEXEC

2015-08-27 Thread Jan Beulich
On 27.08.15 at 16:47, jonathan.creekm...@gmail.com wrote: Add the appropriate #if checks around the kexec code in the x86 codebase so that the feature can actually be turned off by the flag instead of always required to be enabled on x86. But you realize that these HAVE_* variables aren't

Re: [Xen-devel] [PATCH] x86: wrap kexec feature with CONFIG_KEXEC

2015-08-27 Thread Andrew Cooper
On 27/08/15 15:47, Jonathan Creekmore wrote: Add the appropriate #if checks around the kexec code in the x86 codebase so that the feature can actually be turned off by the flag instead of always required to be enabled on x86. Signed-off-by: Jonathan Creekmore jonathan.creekm...@gmail.com In

Re: [Xen-devel] [PATCH] x86: wrap kexec feature with CONFIG_KEXEC

2015-08-27 Thread Jan Beulich
On 27.08.15 at 17:27, david.vra...@citrix.com wrote: On 27/08/15 15:47, Jonathan Creekmore wrote: @@ -125,6 +126,22 @@ do {\ cpu_relax();\ }

Re: [Xen-devel] [PATCH v4 3/4] x86/pvh: Handle hypercalls for 32b PVH guests

2015-08-27 Thread Jan Beulich
On 13.08.15 at 20:12, boris.ostrov...@oracle.com wrote: Signed-off-by: Boris Ostrovsky boris.ostrov...@oracle.com Reviewed-by: Jan Beulich jbeul...@suse.com ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2 22/23] x86: make Xen early boot code relocatable

2015-08-27 Thread Jan Beulich
On 27.08.15 at 17:10, daniel.ki...@oracle.com wrote: On Thu, Aug 27, 2015 at 07:12:38AM -0600, Jan Beulich wrote: On 20.07.15 at 16:29, daniel.ki...@oracle.com wrote: /* Copy bootstrap trampoline to low memory, below 1MB. */ -mov $sym_phys(trampoline_start),%esi +

Re: [Xen-devel] [PATCH v2 2/8] tmem: Add ASSERT in obj_rb_insert for pool-rwlock lock.

2015-08-27 Thread Jan Beulich
On 27.08.15 at 13:01, konrad.w...@oracle.com wrote: --- a/xen/common/tmem.c +++ b/xen/common/tmem.c @@ -915,6 +915,11 @@ static int obj_rb_insert(struct rb_root *root, struct tmem_object_root *obj) { struct rb_node **new, *parent = NULL; struct tmem_object_root *this; +

[Xen-devel] [PATCH for 4.6] build: fix tarball stubdom build

2015-08-27 Thread Wei Liu
When we create a source code tarball, mini-os is extracted to extras/mini-os directory. When building a source code tarball, we shouldn't clone mini-os again. Only clone mini-os when that directory doesn't exist. This fixes tarball build and doesn't affect non-tarball build. Signed-off-by: Wei

Re: [Xen-devel] [PATCH v2 5/8] tmem: Move TMEM_CONTROL subop of tmem hypercall to sysctl.

2015-08-27 Thread Konrad Rzeszutek Wilk
On Thu, Aug 27, 2015 at 09:11:35AM -0600, Jan Beulich wrote: On 27.08.15 at 13:02, konrad.w...@oracle.com wrote: @@ -2666,9 +2662,9 @@ long do_tmem_op(tmem_cli_op_t uops) /* Acquire wirte lock for all command at first */ write_lock(tmem_rwlock); -if ( op.cmd ==

Re: [Xen-devel] [PATCH v2 5/8] tmem: Move TMEM_CONTROL subop of tmem hypercall to sysctl.

2015-08-27 Thread Konrad Rzeszutek Wilk
On Thu, Aug 27, 2015 at 02:12:35PM +0100, Andrew Cooper wrote: On 27/08/15 12:02, Konrad Rzeszutek Wilk wrote: --- a/tools/python/xen/lowlevel/xc/xc.c +++ b/tools/python/xen/lowlevel/xc/xc.c @@ -1808,25 +1808,25 @@ static PyObject *pyxc_tmem_control(XcObject *self,

Re: [Xen-devel] [PATCH v2 5/8] tmem: Move TMEM_CONTROL subop of tmem hypercall to sysctl.

2015-08-27 Thread Andrew Cooper
On 27/08/15 19:43, Konrad Rzeszutek Wilk wrote: --- a/xen/include/public/sysctl.h +++ b/xen/include/public/sysctl.h @@ -710,6 +710,48 @@ struct xen_sysctl_psr_cat_op { typedef struct xen_sysctl_psr_cat_op xen_sysctl_psr_cat_op_t; DEFINE_XEN_GUEST_HANDLE(xen_sysctl_psr_cat_op_t);

Re: [Xen-devel] [BUG] 'o' debug key panics the hypervisor

2015-08-27 Thread Konrad Rzeszutek Wilk
On Thu, Aug 27, 2015 at 04:07:36PM +0200, Roger Pau Monné wrote: El 27/08/15 a les 16.01, Jan Beulich ha escrit: On 27.08.15 at 13:29, roger@citrix.com wrote: When using Intel hardware without shared page tables between the IOMMU and EPT (I have not tried if the same happens when

Re: [Xen-devel] [PATCH v2 4/8] tmem: Remove xc_tmem_control mystical arg3

2015-08-27 Thread Konrad Rzeszutek Wilk
On Thu, Aug 27, 2015 at 01:53:17PM +0100, Andrew Cooper wrote: On 27/08/15 12:01, Konrad Rzeszutek Wilk wrote: It mentions it but it is never used. The hypercall interface knows nothing of this sort of thing either. Lets just remove it. Signed-off-by: Konrad Rzeszutek Wilk

[Xen-devel] [DOCSDAY PATCH for-4.6] docs: Fix installation of man8 pages

2015-08-27 Thread Andrew Cooper
c/s a430436 docs: Support for generating man(8) pages accidentally failed to update to the install and clean rules for man8 pages, meaning that c/s 7b21214 docs: Move xentrace.8 to docs/man/xentrace.pod.8 caused a packaging regression when it came to xentop.8 To avoid similar bugs in the future,

[Xen-devel] [xen-4.4-testing test] 60873: regressions - FAIL

2015-08-27 Thread osstest service owner
flight 60873 xen-4.4-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/60873/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-debianhvm-amd64 19 guest-start/debianhvm.repeat fail REGR. vs. 60727

Re: [Xen-devel] [PATCH v2 5/8] tmem: Move TMEM_CONTROL subop of tmem hypercall to sysctl.

2015-08-27 Thread Andrew Cooper
On 27/08/15 19:47, Konrad Rzeszutek Wilk wrote: --- a/xen/include/public/sysctl.h +++ b/xen/include/public/sysctl.h @@ -710,6 +710,48 @@ struct xen_sysctl_psr_cat_op { typedef struct xen_sysctl_psr_cat_op xen_sysctl_psr_cat_op_t; DEFINE_XEN_GUEST_HANDLE(xen_sysctl_psr_cat_op_t);

Re: [Xen-devel] [PATCH v2 5/8] tmem: Move TMEM_CONTROL subop of tmem hypercall to sysctl.

2015-08-27 Thread Konrad Rzeszutek Wilk
+struct xen_sysctl_tmem_op { +uint32_t cmd; /* IN: XEN_SYSCTL_TMEM_OP_* . */ +int32_t pool_id;/* IN: 0 by default unless _SAVE_*, RESTORE_* .*/ +uint32_t cli_id;/* IN: client id, 0 for XEN_SYSCTL_TMEM_QUERY_FREEABLE_MB + for all

[Xen-devel] [xen-unstable baseline test] 60878: regressions - FAIL

2015-08-27 Thread osstest service owner
Old tested version had not actually been tested; therefore in this flight we test it, rather than a new candidate. The baseline, if any, is the most recent actually tested revision. flight 60878 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/60878/ Regressions :-(

Re: [Xen-devel] [PATCH v2 6/8] tmem: Remove the old tmem control XSM checks as it is part of sysctl hypercall.

2015-08-27 Thread Daniel De Graaf
On 27/08/15 07:02, Konrad Rzeszutek Wilk wrote: The sysctl is where the tmem control operations are done and the XSM checks are done via there. The old mechanism (to check for control tmem op XSM from do_tmem_op) is not needed anymore. CC: Daniel De Graaf dgde...@tycho.nsa.gov Signed-off-by:

[Xen-devel] [qemu-mainline test] 60879: regressions - FAIL

2015-08-27 Thread osstest service owner
flight 60879 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/60879/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-multivcpu 11 guest-start fail REGR. vs. 60846 Regressions which

Re: [Xen-devel] [PATCH v2] libxenstore: prefer using the character device

2015-08-27 Thread Jonathan Creekmore
Ian Jackson ian.jack...@eu.citrix.com writes: Wei Liu writes (Re: [Xen-devel] [PATCH v2] libxenstore: prefer using the character device): On Thu, Aug 27, 2015 at 09:04:38AM -0500, Jonathan Creekmore wrote: With the addition of FMODE_ATOMIC_POS in the Linux 3.14 kernel, concurrent blocking

[Xen-devel] [3.19.y-ckt stable] Patch x86/xen: Probe target addresses in set_aliased_prot() before the hypercall has been added to staging queue

2015-08-27 Thread Kamal Mostafa
This is a note to let you know that I have just added a patch titled x86/xen: Probe target addresses in set_aliased_prot() before the hypercall to the linux-3.19.y-queue branch of the 3.19.y-ckt extended stable tree which can be found at:

[Xen-devel] [PATCH 3.19.y-ckt 111/130] x86/xen: Probe target addresses in set_aliased_prot() before the hypercall

2015-08-27 Thread Kamal Mostafa
3.19.8-ckt6 -stable review patch. If anyone has any objections, please let me know. -- From: Andy Lutomirski l...@kernel.org commit aa1acff356bbedfd03b544051f5b371746735d89 upstream. The update_va_mapping hypercall can fail if the VA isn't present in the guest's page tables.

[Xen-devel] [libvirt test] 60880: regressions - FAIL

2015-08-27 Thread osstest service owner
flight 60880 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/60880/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 16 guest-start/debianhvm.repeat fail REGR. vs. 60848

Re: [Xen-devel] [PATCH V4 2/4] x86/xsaves: enable xsaves/xrstors in xen

2015-08-27 Thread Shuai Ruan
On Wed, Aug 26, 2015 at 06:35:51AM -0600, Jan Beulich wrote: On 26.08.15 at 14:05, andrew.coop...@citrix.com wrote: On 26/08/15 12:50, Jan Beulich wrote: On 26.08.15 at 12:12, andrew.coop...@citrix.com wrote: On 25/08/15 11:54, Shuai Ruan wrote: --- a/xen/arch/x86/traps.c +++

Re: [Xen-devel] [BUG] 'o' debug key panics the hypervisor

2015-08-27 Thread Tian, Kevin
From: Roger Pau Monné [mailto:roger@citrix.com] Sent: Thursday, August 27, 2015 10:08 PM El 27/08/15 a les 16.01, Jan Beulich ha escrit: On 27.08.15 at 13:29, roger@citrix.com wrote: When using Intel hardware without shared page tables between the IOMMU and EPT (I have not tried

Re: [Xen-devel] [PATCH V4 2/4] x86/xsaves: enable xsaves/xrstors in xen

2015-08-27 Thread Shuai Ruan
On Wed, Aug 26, 2015 at 11:12:02AM +0100, Andrew Cooper wrote: On 25/08/15 11:54, Shuai Ruan wrote: This patch uses xsaves/xrstors instead of xsaveopt/xrstor to perform the xsave_area switching so that xen itself can benefit from them when available. For xsaves/xrstors only use compact

Re: [Xen-devel] [PATCH] x86/vmx: fix vmx_is_singlestep_supported return value

2015-08-27 Thread Tian, Kevin
From: Tamas K Lengyel [mailto:ta...@tklengyel.com] Sent: Tuesday, August 25, 2015 3:56 AM The function supposed to return a boolean but instead it returned the value 0x800 which is the Intel internal flag for MTF. This has caused various checks using this function to falsely report no

Re: [Xen-devel] [PATCH V4 1/4] x86/xsaves: add basic definitions/helpers to support xsaves

2015-08-27 Thread Shuai Ruan
On Wed, Aug 26, 2015 at 10:47:22AM +0100, Andrew Cooper wrote: On 25/08/2015 11:54, Shuai Ruan wrote: This patch add basic definitions/helpers which will be used in later patches. Signed-off-by: Shuai Ruan shuai.r...@linux.intel.com Thankyou - this series is looking far better now.

Re: [Xen-devel] [PATCH V4 3/4] x86/xsaves: enable xsaves/xrstors for hvm guest

2015-08-27 Thread Shuai Ruan
On Wed, Aug 26, 2015 at 11:36:53AM +0100, Andrew Cooper wrote: On 25/08/15 11:54, Shuai Ruan wrote: This patch enables xsaves for hvm guest, includes: 1.handle xsaves vmcs init and vmexit. 2.add logic to write/read the XSS msr. Signed-off-by: Shuai Ruan shuai.r...@linux.intel.com

Re: [Xen-devel] [PATCH] x86/vmx: fix vmx_is_singlestep_supported return value

2015-08-27 Thread Tian, Kevin
From: Jan Beulich [mailto:jbeul...@suse.com] Sent: Tuesday, August 25, 2015 3:59 PM Tamas K Lengyel tamas.leng...@zentific.com 08/25/15 1:51 AM @@ -1768,7 +1768,7 @@ static void vmx_enable_msr_exit_interception(struct domain *d) static bool_t vmx_is_singlestep_supported(void) {

Re: [Xen-devel] [PATCH v8 2/3] Differentiate IO/mem resources tracked by ioreq server

2015-08-27 Thread Yu, Zhang
On 8/25/2015 5:40 PM, Wei Liu wrote: On Sun, Aug 23, 2015 at 05:33:17PM +0800, Yu Zhang wrote: Currently in ioreq server, guest write-protected ram pages are tracked in the same rangeset with device mmio resources. Yet unlike device mmio, which can be in big chunks, the guest write- protected

Re: [Xen-devel] [PATCH for 4.6] VT-d: Create IOMMU mappings for RMRR regions if shared EPT is not being used

2015-08-27 Thread Tian, Kevin
From: Chen, Tiejun Sent: Thursday, August 27, 2015 5:05 PM On 8/27/2015 4:40 PM, Malcolm Crossley wrote: On 27/08/15 03:59, Chen, Tiejun wrote: This kind of issue is already gone. https://www.mail-archive.com/xen-devel@lists.xen.org/msg32464.html There is a bug in the code you

Re: [Xen-devel] VT-d faults with Integrated Intel graphics on 4.6

2015-08-27 Thread Chen, Tiejun
On 8/27/2015 7:03 PM, Konrad Rzeszutek Wilk wrote: On Thu, Aug 27, 2015 at 11:06:30AM +0800, Chen, Tiejun wrote: On 8/25/2015 10:43 PM, Konrad Rzeszutek Wilk wrote: On Tue, Aug 25, 2015 at 02:55:31PM +0800, Chen, Tiejun wrote: On 8/25/2015 8:19 AM, Tamas K Lengyel wrote: Hi everyone, I saw some

Re: [Xen-devel] [PATCH V4 1/4] x86/xsaves: add basic definitions/helpers to support xsaves

2015-08-27 Thread Shuai Ruan
On Wed, Aug 26, 2015 at 06:53:06AM -0600, Jan Beulich wrote: On 26.08.15 at 13:41, jbeul...@suse.com wrote: On 26.08.15 at 11:47, andrew.coop...@citrix.com wrote: On 25/08/2015 11:54, Shuai Ruan wrote: --- a/xen/include/asm-x86/cpufeature.h +++ b/xen/include/asm-x86/cpufeature.h @@

Re: [Xen-devel] [Draft B] Boot ABI for HVM guests without a device-model

2015-08-27 Thread Andrew Cooper
On 27/08/15 09:04, Jan Beulich wrote: On 26.08.15 at 16:44, roger@citrix.com wrote: El 26/08/15 a les 14.12, Andrew Cooper ha escrit: On 26/08/15 13:00, Jan Beulich wrote: This structure is guaranteed to always be placed in memory after the DYM These structures are ...? loaded kernel

Re: [Xen-devel] [Draft B] Boot ABI for HVM guests without a device-model

2015-08-27 Thread Roger Pau Monné
El 27/08/15 a les 11.43, Andrew Cooper ha escrit: On 27/08/15 09:04, Jan Beulich wrote: On 26.08.15 at 16:44, roger@citrix.com wrote: El 26/08/15 a les 14.12, Andrew Cooper ha escrit: On 26/08/15 13:00, Jan Beulich wrote: This structure is guaranteed to always be placed in memory after

Re: [Xen-devel] [PATCH] x86/NUMA: make init_node_heap() respect Xen heap limit

2015-08-27 Thread Andrew Cooper
On 27/08/15 09:37, Jan Beulich wrote: On NUMA systems, where we try to use node local memory for the basic control structures of the buddy allocator, this special case needs to take into consideration a possible address width limit placed on the Xen heap. In turn this (but also other, more

[Xen-devel] tmem vs Xen 4.6

2015-08-27 Thread Jan Beulich
Konrad, I thought I'd remind you of the some progress per release criteria to avoid it becoming subject to removal. The most recent changes date back to spring 2014 afaics... Jan ___ Xen-devel mailing list Xen-devel@lists.xen.org

Re: [Xen-devel] [RFC v2 for-4.6 0/2] In-tree feature documentation

2015-08-27 Thread Andrew Cooper
On 27/08/15 03:44, Jim Fehlig wrote: On 08/25/2015 04:40 AM, Andrew Cooper wrote: An issue which Xen has is an uncertain support statement for features. Given the success seen with docs/misc/xen-command-line.markdown, and in particular keeping it up to date, introduce a similar system for

[Xen-devel] [PATCH v2 6/8] tmem: Remove the old tmem control XSM checks as it is part of sysctl hypercall.

2015-08-27 Thread Konrad Rzeszutek Wilk
The sysctl is where the tmem control operations are done and the XSM checks are done via there. The old mechanism (to check for control tmem op XSM from do_tmem_op) is not needed anymore. CC: Daniel De Graaf dgde...@tycho.nsa.gov Signed-off-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com ---

[Xen-devel] [PATCH v2 7/8] tmem: Remove extra spaces at end and some hard tabbing.

2015-08-27 Thread Konrad Rzeszutek Wilk
My editor marks these in red glowing red so removing them to make it easier to focus on code. Signed-off-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com --- xen/common/tmem.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/xen/common/tmem.c

[Xen-devel] [PATCH v2 5/8] tmem: Move TMEM_CONTROL subop of tmem hypercall to sysctl.

2015-08-27 Thread Konrad Rzeszutek Wilk
The operations are to be used by an control domain to set parameters, list pools, clients, and to be used during migration. There is no need to have them in the tmem hypercall path. This patch moves code without adding fixes - and in fact in some cases makes the parameters soo long that they

[Xen-devel] [PATCH v2 3/8] tmem: remove in xc_tmem_control_oid duplicate set_xen_guest_handle call

2015-08-27 Thread Konrad Rzeszutek Wilk
We are doing another call to set_xen_guest_handle right after the xc_hypercall_bounce_pre (the correct place to do it). Signed-off-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com --- tools/libxc/xc_tmem.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/libxc/xc_tmem.c

[Xen-devel] [PATCH v2 2/8] tmem: Add ASSERT in obj_rb_insert for pool-rwlock lock.

2015-08-27 Thread Konrad Rzeszutek Wilk
Manipulating the obj- structures requires us to hold the pool-rwlock lock. Lets make that obvious in this function to catch any errant users (none found, but we may in future). Signed-off-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com --- xen/common/tmem.c | 5 + 1 file changed, 5

[Xen-devel] [PATCH v2 8/8] tmem: Spelling mistakes.

2015-08-27 Thread Konrad Rzeszutek Wilk
Signed-off-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com --- xen/common/tmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/common/tmem.c b/xen/common/tmem.c index 66d2852..9bd75d8 100644 --- a/xen/common/tmem.c +++ b/xen/common/tmem.c @@ -2659,7 +2659,7 @@ long

[Xen-devel] [PATCH v2 4/8] tmem: Remove xc_tmem_control mystical arg3

2015-08-27 Thread Konrad Rzeszutek Wilk
It mentions it but it is never used. The hypercall interface knows nothing of this sort of thing either. Lets just remove it. Signed-off-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com --- tools/libxc/include/xenctrl.h | 2 +- tools/libxc/xc_tmem.c | 38

[Xen-devel] [PATCH v2] Tmem bug-fixes and cleanups.

2015-08-27 Thread Konrad Rzeszutek Wilk
Hey! At the Xenhackathon we spoke that the tmem code needs a bit of cleanups and simplification. One of the things that Andrew mentioned was that the TMEM_CONTROL should really be part of the sysctl hypercall. As I ventured this path I realized there were some other issues that need to be taken

Re: [Xen-devel] VT-d faults with Integrated Intel graphics on 4.6

2015-08-27 Thread Konrad Rzeszutek Wilk
On Thu, Aug 27, 2015 at 11:06:30AM +0800, Chen, Tiejun wrote: On 8/25/2015 10:43 PM, Konrad Rzeszutek Wilk wrote: On Tue, Aug 25, 2015 at 02:55:31PM +0800, Chen, Tiejun wrote: On 8/25/2015 8:19 AM, Tamas K Lengyel wrote: Hi everyone, I saw some people passingly mention this on the list before

Re: [Xen-devel] [PATCH v3] xen/blkfront: convert to blk-mq APIs

2015-08-27 Thread Rafal Mielniczuk
On 25/08/15 03:14, Bob Liu wrote: Hi Rafal, Please have a try adding --iodepth_batch=32 --iodepth_batch_complete=32 to the fio command line. I didn't see this issue any more, neither for domU. Thanks, -Bob Hello, Using 4.2-rc8 kernel, I can confirm that merges are happening after adding

Re: [Xen-devel] [PATCH RFC] xen: if on Xen, flatten the scheduling domain hierarchy

2015-08-27 Thread George Dunlap
On 08/18/2015 04:55 PM, Dario Faggioli wrote: Hey everyone, So, as a followup of what we were discussing in this thread: [Xen-devel] PV-vNUMA issue: topology is misinterpreted by the guest http://lists.xenproject.org/archives/html/xen-devel/2015-07/msg03241.html I started looking in

Re: [Xen-devel] [PATCH v2 for-4.6 2/2] docs: Migration feature document

2015-08-27 Thread Andrew Cooper
On 27/08/15 03:15, Jim Fehlig wrote: On 08/25/2015 04:40 AM, Andrew Cooper wrote: Signed-off-by: Andrew Cooper andrew.coop...@citrix.com --- v2: * %Revision and #History, following template review * Grammar fixes --- docs/features/migration.pandoc | 100

[Xen-devel] [PATCH v2 1/8] tmem: Don't crash/hang/leak hypervisor when using shared pools within an guest.

2015-08-27 Thread Konrad Rzeszutek Wilk
When we are using shared pools we have an global array (on which we put the pool), and an array of pools per domain. We also have an shared list of clients (guests) _except_ for the very first domain that created the shared pool. To deal with multiple guests using an shared pool we have an ref

Re: [Xen-devel] tmem vs Xen 4.6

2015-08-27 Thread Konrad Rzeszutek Wilk
On Thu, Aug 27, 2015 at 04:02:08PM +0800, Bob Liu wrote: On 08/27/2015 02:55 PM, Jan Beulich wrote: Konrad, I thought I'd remind you of the some progress per release criteria to avoid it becoming subject to removal. The most recent changes date back to spring 2014 afaics... Jan

Re: [Xen-devel] [Draft B] Boot ABI for HVM guests without a device-model

2015-08-27 Thread Jan Beulich
On 27.08.15 at 11:57, roger@citrix.com wrote: El 27/08/15 a les 11.43, Andrew Cooper ha escrit: On 27/08/15 09:04, Jan Beulich wrote: On 26.08.15 at 16:44, roger@citrix.com wrote: El 26/08/15 a les 14.12, Andrew Cooper ha escrit: On 26/08/15 13:00, Jan Beulich wrote: This structure

  1   2   >