Re: [Xen-devel] xen 4.6 regression: xl create fails if domU have custom vifname

2015-08-28 Thread Fabio Fantoni
Il 27/08/2015 16:46, Wei Liu ha scritto: On Thu, Aug 27, 2015 at 04:41:46PM +0200, Fabio Fantoni wrote: Today trying xen 4.6.0-rc2 with all things needed for future production server I found a regression: xl create fails if domU have custom vifname. xl create test.cfg Parsing config from

Re: [Xen-devel] [PATCH] x86/vmx: fix vmx_is_singlestep_supported return value

2015-08-28 Thread Jan Beulich
On 28.08.15 at 04:01, kevin.t...@intel.com wrote: From: Jan Beulich [mailto:jbeul...@suse.com] Sent: Tuesday, August 25, 2015 3:59 PM Tamas K Lengyel tamas.leng...@zentific.com 08/25/15 1:51 AM @@ -1768,7 +1768,7 @@ static void vmx_enable_msr_exit_interception(struct domain *d)

Re: [Xen-devel] [PATCH v2 22/23] x86: make Xen early boot code relocatable

2015-08-28 Thread Jan Beulich
On 27.08.15 at 20:04, andrew.coop...@citrix.com wrote: On 27/08/15 16:29, Jan Beulich wrote: On 27.08.15 at 17:10, daniel.ki...@oracle.com wrote: On Thu, Aug 27, 2015 at 07:12:38AM -0600, Jan Beulich wrote: On 20.07.15 at 16:29, daniel.ki...@oracle.com wrote: /* Copy bootstrap

[Xen-devel] [linux-3.18 test] 60882: regressions - FAIL

2015-08-28 Thread osstest service owner
flight 60882 linux-3.18 real [real] http://logs.test-lab.xenproject.org/osstest/logs/60882/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-pvh-intel 11 guest-start fail REGR. vs. 58581 Regressions which are

Re: [Xen-devel] [PATCH v2 5/8] tmem: Move TMEM_CONTROL subop of tmem hypercall to sysctl.

2015-08-28 Thread Jan Beulich
On 27.08.15 at 20:43, konrad.w...@oracle.com wrote: On Thu, Aug 27, 2015 at 09:11:35AM -0600, Jan Beulich wrote: On 27.08.15 at 13:02, konrad.w...@oracle.com wrote: --- a/xen/include/public/sysctl.h +++ b/xen/include/public/sysctl.h @@ -710,6 +710,48 @@ struct xen_sysctl_psr_cat_op {

Re: [Xen-devel] [PATCH for 4.6] build: fix tarball stubdom build

2015-08-28 Thread Jan Beulich
On 27.08.15 at 18:24, wei.l...@citrix.com wrote: On Thu, Aug 27, 2015 at 10:05:56AM -0600, Jan Beulich wrote: On 27.08.15 at 17:54, wei.l...@citrix.com wrote: When we create a source code tarball, mini-os is extracted to extras/mini-os directory. When building a source code tarball, we

Re: [Xen-devel] [PATCH v8 2/3] Differentiate IO/mem resources tracked by ioreq server

2015-08-28 Thread Jan Beulich
On 28.08.15 at 05:11, yu.c.zh...@linux.intel.com wrote: To other maintainers, do you have any question or suggestion? I certainly intend to get to reviewing these patches, but my originally huge backlog hasn't shrunk enough yet. Jan ___ Xen-devel

Re: [Xen-devel] [PATCH for 4.6] build: fix tarball stubdom build

2015-08-28 Thread Wei Liu
On Fri, Aug 28, 2015 at 12:41:15AM -0600, Jan Beulich wrote: On 27.08.15 at 18:24, wei.l...@citrix.com wrote: On Thu, Aug 27, 2015 at 10:05:56AM -0600, Jan Beulich wrote: On 27.08.15 at 17:54, wei.l...@citrix.com wrote: When we create a source code tarball, mini-os is extracted to

Re: [Xen-devel] [xen-unstable baseline test] 60878: regressions - FAIL

2015-08-28 Thread Ian Jackson
osstest service owner writes ([xen-unstable baseline test] 60878: regressions - FAIL): Old tested version had not actually been tested; therefore in this flight we test it, rather than a new candidate. The baseline, if any, is the most recent actually tested revision. The above paragraph is

Re: [Xen-devel] [PATCH] xen: avoid early crash of memory limited dom0

2015-08-28 Thread David Vrabel
On 19/08/15 17:52, Juergen Gross wrote: Commit b1c9f169047b (xen: split counting of extra memory pages...) introduced an error when dom0 was started with limited memory. The problem arises in case dom0 is started with initial memory and maximum memory being the same and exactly a multiple of

Re: [Xen-devel] [PATCH] xen: avoid another early crash of memory limited dom0

2015-08-28 Thread David Vrabel
On 19/08/15 17:53, Juergen Gross wrote: Commit b1c9f169047b (xen: split counting of extra memory pages...) introduced an error when dom0 was started with limited memory occurring only on some hardware. The problem arises in case dom0 is started with initial memory and maximum memory being

[Xen-devel] [PATCH resend] xen: avoid early crash of memory limited dom0

2015-08-28 Thread Juergen Gross
Commit b1c9f169047b (xen: split counting of extra memory pages...) introduced an error when dom0 was started with limited memory. The problem arises in case dom0 is started with initial memory and maximum memory being the same and exactly a multiple of 1 GB. The kernel must be configured without

[Xen-devel] [PATCH resend] xen: avoid another early crash of memory limited dom0

2015-08-28 Thread Juergen Gross
Commit b1c9f169047b (xen: split counting of extra memory pages...) introduced an error when dom0 was started with limited memory occurring only on some hardware. The problem arises in case dom0 is started with initial memory and maximum memory being the same. The kernel must be configured

Re: [Xen-devel] [PATCH for 4.6] build: fix tarball stubdom build

2015-08-28 Thread Jan Beulich
On 28.08.15 at 10:47, wei.l...@citrix.com wrote: On Fri, Aug 28, 2015 at 12:41:15AM -0600, Jan Beulich wrote: On 27.08.15 at 18:24, wei.l...@citrix.com wrote: On Thu, Aug 27, 2015 at 10:05:56AM -0600, Jan Beulich wrote: On 27.08.15 at 17:54, wei.l...@citrix.com wrote: When we create a

Re: [Xen-devel] [DOCSDAY PATCH for-4.6] docs: Fix installation of man8 pages

2015-08-28 Thread Ian Jackson
Andrew Cooper writes ([DOCSDAY PATCH for-4.6] docs: Fix installation of man8 pages): c/s a430436 docs: Support for generating man(8) pages accidentally failed to update to the install and clean rules for man8 pages, meaning that c/s 7b21214 docs: Move xentrace.8 to docs/man/xentrace.pod.8

Re: [Xen-devel] xen 4.6 regression: xl create fails if domU have custom vifname

2015-08-28 Thread Wei Liu
On Fri, Aug 28, 2015 at 09:50:22AM +0200, Fabio Fantoni wrote: Il 27/08/2015 16:46, Wei Liu ha scritto: On Thu, Aug 27, 2015 at 04:41:46PM +0200, Fabio Fantoni wrote: Today trying xen 4.6.0-rc2 with all things needed for future production server I found a regression: xl create fails if domU

Re: [Xen-devel] [BUG] 'o' debug key panics the hypervisor

2015-08-28 Thread Jan Beulich
On 27.08.15 at 20:33, konrad.w...@oracle.com wrote: On Thu, Aug 27, 2015 at 04:07:36PM +0200, Roger Pau Monné wrote: El 27/08/15 a les 16.01, Jan Beulich ha escrit: On 27.08.15 at 13:29, roger@citrix.com wrote: When using Intel hardware without shared page tables between the IOMMU

Re: [Xen-devel] [PATCH v8 2/3] Differentiate IO/mem resources tracked by ioreq server

2015-08-28 Thread Yu, Zhang
On 8/28/2015 4:38 PM, Jan Beulich wrote: On 28.08.15 at 05:11, yu.c.zh...@linux.intel.com wrote: To other maintainers, do you have any question or suggestion? I certainly intend to get to reviewing these patches, but my originally huge backlog hasn't shrunk enough yet. Jan Thanks for

Re: [Xen-devel] [PATCH V4 2/4] x86/xsaves: enable xsaves/xrstors in xen

2015-08-28 Thread Jan Beulich
On 28.08.15 at 12:54, shuai.r...@linux.intel.com wrote: On Wed, Aug 26, 2015 at 07:06:00AM -0600, Jan Beulich wrote: On 25.08.15 at 12:54, shuai.r...@linux.intel.com wrote: +++ b/xen/arch/x86/xstate.c @@ -214,6 +214,11 @@ void xsave(struct vcpu *v, uint64_t mask)

Re: [Xen-devel] [PATCH for 4.6] build: fix tarball stubdom build

2015-08-28 Thread Wei Liu
On Fri, Aug 28, 2015 at 03:49:06AM -0600, Jan Beulich wrote: On 28.08.15 at 10:47, wei.l...@citrix.com wrote: On Fri, Aug 28, 2015 at 12:41:15AM -0600, Jan Beulich wrote: On 27.08.15 at 18:24, wei.l...@citrix.com wrote: On Thu, Aug 27, 2015 at 10:05:56AM -0600, Jan Beulich wrote: On

Re: [Xen-devel] [PATCH v2 22/23] x86: make Xen early boot code relocatable

2015-08-28 Thread Jan Beulich
On 27.08.15 at 19:56, 426...@gmail.com wrote: If you advocate direct booting ( no boot loader) on production machines I wont argue much, as long as there is good recovery tools to deal with failed boots (grub does this very well, I am not aware of anything comparable that is pure efi).

Re: [Xen-devel] [PATCH v2] libxenstore: prefer using the character device

2015-08-28 Thread David Vrabel
On 27/08/15 19:03, Ian Jackson wrote: Wei Liu writes (Re: [Xen-devel] [PATCH v2] libxenstore: prefer using the character device): On Thu, Aug 27, 2015 at 09:04:38AM -0500, Jonathan Creekmore wrote: With the addition of FMODE_ATOMIC_POS in the Linux 3.14 kernel, concurrent blocking file

Re: [Xen-devel] [PATCH V4 2/4] x86/xsaves: enable xsaves/xrstors in xen

2015-08-28 Thread Shuai Ruan
On Wed, Aug 26, 2015 at 07:06:00AM -0600, Jan Beulich wrote: On 25.08.15 at 12:54, shuai.r...@linux.intel.com wrote: +++ b/xen/arch/x86/xstate.c @@ -214,6 +214,11 @@ void xsave(struct vcpu *v, uint64_t mask) typeof(ptr-fpu_sse.fip.sel) fcs = ptr-fpu_sse.fip.sel;

Re: [Xen-devel] [PATCH v2 5/8] tmem: Move TMEM_CONTROL subop of tmem hypercall to sysctl.

2015-08-28 Thread Jan Beulich
On 27.08.15 at 21:20, konrad.w...@oracle.com wrote: --- a/xen/include/public/tmem.h +++ b/xen/include/public/tmem.h @@ -33,7 +33,7 @@ #define TMEM_SPEC_VERSION 1 /* Commands to HYPERVISOR_tmem_op() */ -#define TMEM_CONTROL 0 +#define TMEM_CONTROL_MOVED

[Xen-devel] [distros-debian-sid test] 37845: tolerable FAIL

2015-08-28 Thread Platform Team regression test user
flight 37845 distros-debian-sid real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/37845/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-i386-amd64-sid-netboot-pygrub 13 guest-saverestore fail blocked in 37840 Tests which

[Xen-devel] Design doc of adding ACPI support for arm64 on Xen - version 5

2015-08-28 Thread Shannon Zhao
This document is going to explain the design details of Xen booting with ACPI on ARM. Maybe parts of it may not be appropriate. Any comments are welcome. Changes v4-v5: * change the description of section 4 to make it more generic * place EFI and ACPI tables at non-RAM space of Dom0 Changes

Re: [Xen-devel] [PATCH v2 22/23] x86: make Xen early boot code relocatable

2015-08-28 Thread Andrew Cooper
On 28/08/15 07:54, Jan Beulich wrote: Therefore I am very much +1 get grub working. Then you kind of misunderstood: I'm not against getting grub2 working (i.e. patches prior to this one are fine in principle). What I'm against is hacking around firmware+grub2 combinations not suitable for

[Xen-devel] [xen 4.6 retrospective] [good] Feedback from developer meeting Wed 19th : What went well in 4.6

2015-08-28 Thread Lars Kurth
Hi folks, we did run a retrospective at the developer meeting and I am writing up some of my notes. Regards Lars So what did go well * Best ever code quality (see Andrew Coopers mail) * New Release Process: fewer release exceptions compared to the past * This means that most likely the release

[Xen-devel] [PATCH] x86: adjustments to memory_add()

2015-08-28 Thread Jan Beulich
The function should clean up after a failed map_pages_to_xen(). Sharing the M2P table with Dom0 needs to happen before adding the new pages to the heap. Avoid the IOMMU mapping loop whenever possible. Drop a redundant setting of 'ret'. Signed-off-by: Jan Beulich jbeul...@suse.com ---

Re: [Xen-devel] [PATCH for 4.7] xen: Replace alloc_vcpu_guest_context() with vmalloc()

2015-08-28 Thread Julien Grall
Hi Andrew, On 21/08/15 18:51, Andrew Cooper wrote: This essentially reverts c/s 2037f2adb x86: introduce alloc_vcpu_guest_context(), including the newer arm bits, but achieves the same end goal by using the newer vmalloc() infrastructure. I would keep alloc_vcpu_guest_context and replace the

Re: [Xen-devel] [PATCH v2 22/23] x86: make Xen early boot code relocatable

2015-08-28 Thread Konrad Rzeszutek Wilk
On Fri, Aug 28, 2015 at 02:22:46AM -0600, Jan Beulich wrote: On 27.08.15 at 19:56, 426...@gmail.com wrote: If you advocate direct booting ( no boot loader) on production machines I wont argue much, as long as there is good recovery tools to deal with failed boots (grub does this very

[Xen-devel] [PATCH] x86/NUMA: fix setup_node()

2015-08-28 Thread Jan Beulich
The function referenced an __initdata object (nodes_found). Since this being a node mask was more complicated than needed, the variable gets replaced by a simple counter. Check at once that the count of nodes doesn't go beyond MAX_NUMNODES. Also consolidate four printk()s related to the

Re: [Xen-devel] Design doc of adding ACPI support for arm64 on Xen - version 5

2015-08-28 Thread Julien Grall
Hi Shannon, On 28/08/15 10:45, Shannon Zhao wrote: 2. Copy and change some EFI and ACPI tables --- [..] All above tables will be mapped to Dom0 non-RAM space(e.g. the space after Dom0 RAM). If I understand correctly what you are saying, you plan to

Re: [Xen-devel] [PATCH for 4.7] xen: Replace alloc_vcpu_guest_context() with vmalloc()

2015-08-28 Thread Andrew Cooper
On 28/08/15 13:41, Julien Grall wrote: Hi Andrew, On 21/08/15 18:51, Andrew Cooper wrote: This essentially reverts c/s 2037f2adb x86: introduce alloc_vcpu_guest_context(), including the newer arm bits, but achieves the same end goal by using the newer vmalloc() infrastructure. I would keep

[Xen-devel] [ovmf test] 60904: regressions - FAIL

2015-08-28 Thread osstest service owner
flight 60904 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/60904/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ovmf-amd64 19 guest-start/debianhvm.repeat fail REGR. vs. 60869 version

Re: [Xen-devel] [PATCH v2 1/2] xen/arm: vgic: Introduce helpers to read/write/clear/set vGIC register ...

2015-08-28 Thread Julien Grall
Hi Vijay, You took over this series without asking me if I was still working on it... You don't even address all the TODOs I mentioned in the cover letter of v1 [1] which you didn't bother to retain. If I didn't send a new version of the patch series it's because I was waiting reviews from the

[Xen-devel] [PATCH] x86/NUMA: don't account hotplug regions

2015-08-28 Thread Jan Beulich
... except in cases where they really matter: node_memblk_range[] now is the only place all regions get stored. nodes[] and NODE_DATA() track present memory only. This improves the reporting when nodes have disjoint normal and hotplug regions, with the hotplug region sitting above the highest

[Xen-devel] [linux-mingo-tip-master test] 60884: regressions - FAIL

2015-08-28 Thread osstest service owner
flight 60884 linux-mingo-tip-master real [real] http://logs.test-lab.xenproject.org/osstest/logs/60884/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 13 guest-localmigrate fail REGR.

[Xen-devel] [seabios test] 60888: tolerable FAIL - PUSHED

2015-08-28 Thread osstest service owner
flight 60888 seabios real [real] http://logs.test-lab.xenproject.org/osstest/logs/60888/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stop fail like 60761 Tests which did not succeed, but

Re: [Xen-devel] [PATCH for 4.7] xen: Replace alloc_vcpu_guest_context() with vmalloc()

2015-08-28 Thread Andrew Cooper
On 28/08/15 13:57, Julien Grall wrote: On 28/08/15 13:56, Andrew Cooper wrote: On 28/08/15 13:41, Julien Grall wrote: Hi Andrew, On 21/08/15 18:51, Andrew Cooper wrote: This essentially reverts c/s 2037f2adb x86: introduce alloc_vcpu_guest_context(), including the newer arm bits, but

Re: [Xen-devel] [PATCH for 4.7] xen: Replace alloc_vcpu_guest_context() with vmalloc()

2015-08-28 Thread Julien Grall
On 28/08/15 14:07, Andrew Cooper wrote: On 28/08/15 13:57, Julien Grall wrote: On 28/08/15 13:56, Andrew Cooper wrote: On 28/08/15 13:41, Julien Grall wrote: Hi Andrew, On 21/08/15 18:51, Andrew Cooper wrote: This essentially reverts c/s 2037f2adb x86: introduce alloc_vcpu_guest_context(),

[Xen-devel] [PATCH v2 2/2] xen/arm: vgic-v3: Support 32-bit access for 64-bit registers

2015-08-28 Thread vijay . kilari
From: Julien Grall julien.gr...@citrix.com Based on 8.1.3 (IHI 0069A), unless stated otherwise, the 64-bit registers supports both 32-bit and 64-bits access. All the registers we properly emulate (i.e not RAZ/WI) supports 32-bit access. For RAZ/WI, it's also seems to be the case but I'm not

[Xen-devel] [PATCH v2 1/2] xen/arm: vgic: Introduce helpers to read/write/clear/set vGIC register ...

2015-08-28 Thread vijay . kilari
From: Julien Grall julien.gr...@citrix.com and use them in the vGIC emulation. The GIC registers may support different access sizes. Rather than open coding the access for every registers, provide a set of helpers to access them. The caller will have to call vgic_regN_* where N is the size of

Re: [Xen-devel] [PATCH] x86: adjustments to memory_add()

2015-08-28 Thread Andrew Cooper
On 28/08/15 15:29, Jan Beulich wrote: On 28.08.15 at 16:11, andrew.coop...@citrix.com wrote: On 28/08/15 14:54, Jan Beulich wrote: The function should clean up after a failed map_pages_to_xen(). Sharing the M2P table with Dom0 needs to happen before adding the new pages to the heap. Why?

Re: [Xen-devel] [xen 4.6 retrospective] [bad] review load near freeze point

2015-08-28 Thread Jan Beulich
On 28.08.15 at 17:05, lars.kurth@gmail.com wrote: On 12 Aug 2015, at 09:00, Jan Beulich jbeul...@suse.com wrote: On 04.08.15 at 14:52, lars.kurth@gmail.com wrote: = Issue / Observation = Maybe my memory regarding the 4.5 release has faded, but I'm having the impression that 4.6

Re: [Xen-devel] [PATCH] x86: adjustments to memory_add()

2015-08-28 Thread Andrew Cooper
On 28/08/15 14:54, Jan Beulich wrote: The function should clean up after a failed map_pages_to_xen(). Sharing the M2P table with Dom0 needs to happen before adding the new pages to the heap. Why? Does this not create a race where dom0 can observe the new mfns before they are ready to use?

Re: [Xen-devel] [PATCH v2 22/23] x86: make Xen early boot code relocatable

2015-08-28 Thread Jan Beulich
On 27.08.15 at 17:29, jbeul...@suse.com wrote: You're right, there's no such requirement on memory use in the spec. But you're missing the point. Supporting grub2 on UEFI is already a hack (ignoring all intentions EFI had from its first days). And now you've found an environment where that

Re: [Xen-devel] [PATCH v2 5/8] tmem: Move TMEM_CONTROL subop of tmem hypercall to sysctl.

2015-08-28 Thread Jan Beulich
On 28.08.15 at 16:15, konrad.w...@oracle.com wrote: Then I decided to see if I can expand that to also be part of the 'tmem_op', which looked legit (as it is the same size and offset and pahole wise it looks right). But sadly the compat layer is not happy with me: In file included from

[Xen-devel] [OSSTest Nested v12 00/21] Introduction of netsted HVM test job

2015-08-28 Thread Robert Ho
This patch set adds nested HVM test case for osstest. In this test case, a Xen hypervisor (L1) runs on top of another Xen hypervisor (L0). Upon L1 hypervisor, we will then create a nested guest (L2), and test if the Linux guest can then be installed and run well. About nested Xen virtualization,

[Xen-devel] [OSSTest Nested v12 08/21] Add new script to customize nested test configuration

2015-08-28 Thread Robert Ho
1. In this script, make some appropriate runvars which selecthost would recognise. 2. Prepare the configurations for installing L2 guest VM. 3. Create a lv disk (and create vg inside) in L0 and hot-attach it to L1. The VG which will later be used for installing L2

[Xen-devel] [OSSTest Nested v12 19/21] Selecthost uses dynamic IP address if the host is not configured static IP.

2015-08-28 Thread Robert Ho
In this patch 1. in check_ip(), we change $lstash to use {Name} key-value, rather than {Guest}, because {Name} is both usable by $ho and $gho hash. 2. $ho-{Ether} assignment: if configured in host property, good, use it; otherwise, try to see if runvar has the assignment (this is the case of

[Xen-devel] [OSSTest Nested v12 04/21] Comment out CDROM entry in HVM guest VM

2015-08-28 Thread Robert Ho
Comment out CDROM entry in sources.list to make HTTP URL entry available for L1 HVM guest VM. Signed-off-by: Robert Ho robert...@intel.com --- ts-debian-hvm-install | 7 +++ 1 file changed, 7 insertions(+) diff --git a/ts-debian-hvm-install b/ts-debian-hvm-install index

[Xen-devel] [OSSTest Nested v12 02/21] Correct a mistake in setboot_grup2() of Xen entry parsing pattern

2015-08-28 Thread Robert Ho
In previous adding of 'submenu' parsing code, a mistake was made. Now restore the match pattern to original. Signed-off-by: Robert Ho robert...@intel.com --- Osstest/Debian.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm index

[Xen-devel] [OSSTest Nested v12 11/21] Tcl: Provide lunappend

2015-08-28 Thread Robert Ho
From: Ian Jackson ian.jack...@eu.citrix.com Signed-off-by: Ian Jackson ian.jack...@eu.citrix.com Tested-by: Robert Ho robert...@intel.com --- tcl/osstestlib.tcl | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tcl/osstestlib.tcl b/tcl/osstestlib.tcl index 61a6a09..b5a52d3 100644 ---

[Xen-devel] [OSSTest Nested v12 05/21] Honour $xopts{ExtraConfig} and use it to enable nestedhvm

2015-08-28 Thread Robert Ho
Signed-off-by: Robert Ho robert...@intel.com --- ts-debian-hvm-install | 5 + 1 file changed, 5 insertions(+) diff --git a/ts-debian-hvm-install b/ts-debian-hvm-install index 2ec4717..e271af8 100755 --- a/ts-debian-hvm-install +++ b/ts-debian-hvm-install @@ -202,6 +202,10 @@ sub prep () {

[Xen-devel] [OSSTest Nested v12 21/21] await_tcp(): check_ip for each loop iteration

2015-08-28 Thread Robert Ho
await_tcp usually invoked after a reboot, $ho IP may change, especially when $ho 'client name' of DHCP request changes. Therefore, await_tcp() check will fail if we don't update $ho-{IP} accordingly. But, if $ho has static IP, this won't apply. Also, this patch add $ho-{Ip} in its $what message,

[Xen-devel] [OSSTest Nested v12 20/21] Don't lvextend if actually no more space to extend

2015-08-28 Thread Robert Ho
Though passes if judgement, the overall_limit_pe(\$vg_more_free_pe); may final judge no more free_pe to extend. So, check if $vg_more_free_pe is 0, if so, we don't lvextend, otherwise lvextend will report error on nonsense operation. Signed-off-by: Robert Ho robert...@intel.com ---

[Xen-devel] [OSSTest Nested v12 18/21] After Xen install, configure its xenbr0 interface as dhcp.

2015-08-28 Thread Robert Ho
This is more idiomatic because, even if host is fixed IP in DHCP server side, client side shall still be dhcp mode, rather than fixed self. And if it is not configured fixed in DHCP server side, it shall more necessarily use dhcp mode. This applies for both nested test and other test cases.

[Xen-devel] [OSSTest Nested v12 06/21] Add new function of 'host_install_postboot_complete'

2015-08-28 Thread Robert Ho
This function is called to add 'osstest-confirm-booted' service in target's start up services. Previously, this was dircetly done by target_cmd_root($ho, update-rc.d osstest-confirm-booted start 99 2 .) Here wrapper it because more than one place (ts-host-install and ts-nested-setup) will need

Re: [Xen-devel] [PATCH v3 11/20] tty/hvc: xen: Use xen page definition

2015-08-28 Thread Julien Grall
Hi David, On 20/08/15 10:55, David Vrabel wrote: On 07/08/15 17:46, Julien Grall wrote: The console ring is always based on the page granularity of Xen. [...] --- a/drivers/tty/hvc/hvc_xen.c +++ b/drivers/tty/hvc/hvc_xen.c @@ -230,7 +230,7 @@ static int xen_hvm_console_init(void) if

[Xen-devel] [OSSTest Nested v12 07/21] Replace 'start osstest-confirm-booted' code by function

2015-08-28 Thread Robert Ho
Schedul start osstest-confirm-booted script via call `host_install_postboot_complete' fucntion; in order to avoid open code. Signed-off-by: Robert Ho robert...@intel.com --- ts-host-install | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ts-host-install

[Xen-devel] [OSSTest Nested v12 12/21] sg-run-job: Declare Tcl (for the benefit of Emacs)

2015-08-28 Thread Robert Ho
From: Ian Jackson ian.jack...@eu.citrix.com Signed-off-by: Ian Jackson ian.jack...@eu.citrix.com Tested-by: Robert Ho robert...@intel.com Resolve conflicts: sg-run-job --- sg-run-job | 1 + 1 file changed, 1 insertion(+) diff --git a/sg-run-job b/sg-run-job index e4ebc22..ec03cce 100755

[Xen-devel] [OSSTest Nested v12 15/21] Integrate Ian J. code and small corrections.

2015-08-28 Thread Robert Ho
Signed-off-by: Robert Ho robert...@intel.com --- sg-run-job | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sg-run-job b/sg-run-job index 7cb6cac..4ae651d 100755 --- a/sg-run-job +++ b/sg-run-job @@ -69,14 +69,14 @@ proc run-job {job} { per-host-ts broken

Re: [Xen-devel] [PATCH v2 22/23] x86: make Xen early boot code relocatable

2015-08-28 Thread Jan Beulich
On 28.08.15 at 15:42, konrad.w...@oracle.com wrote: And I am not comfortable to say 'GRUB2+Xen cannot run on this hardware because your firmware vendor is not following the EFI spec in spirit.' Well, not the least since I don't really agree with this (albeit I can see where you're coming from)

Re: [Xen-devel] [PATCH] x86/NUMA: don't account hotplug regions

2015-08-28 Thread Andrew Cooper
On 28/08/15 14:59, Jan Beulich wrote: ... except in cases where they really matter: node_memblk_range[] now is the only place all regions get stored. nodes[] and NODE_DATA() track present memory only. This improves the reporting when nodes have disjoint normal and hotplug regions, with the

Re: [Xen-devel] [xen 4.6 retrospective] [good] Feedback from developer meeting Wed 19th : What went well in 4.6

2015-08-28 Thread Andrew Cooper
On 28/08/15 15:43, Jan Beulich wrote: On 28.08.15 at 14:28, lars.kurth@gmail.com wrote: * Testing: staging and master being close together for most of the cycle This was observed or said by whom? I've certainly got - not infrequently - a different impression. I second the query. The 4.6

Re: [Xen-devel] [PATCH v2 5/8] tmem: Move TMEM_CONTROL subop of tmem hypercall to sysctl.

2015-08-28 Thread Konrad Rzeszutek Wilk
+struct xen_sysctl_tmem_op { +uint32_t cmd; /* IN: XEN_SYSCTL_TMEM_OP_* . */ +int32_t pool_id;/* IN: 0 by default unless _SAVE_*, RESTORE_* .*/ +uint32_t cli_id;/* IN: client id, 0 for XEN_SYSCTL_TMEM_QUERY_FREEABLE_MB + for all

Re: [Xen-devel] [PATCH] x86/NUMA: fix setup_node()

2015-08-28 Thread Andrew Cooper
On 28/08/15 14:58, Jan Beulich wrote: The function referenced an __initdata object (nodes_found). Since this being a node mask was more complicated than needed, the variable gets replaced by a simple counter. Check at once that the count of nodes doesn't go beyond MAX_NUMNODES. Also

[Xen-devel] [xen-unstable baseline test] 60957: regressions - trouble: fail/pass/preparing

2015-08-28 Thread osstest service owner
Old tested version had not actually been tested; therefore in this flight we test it, rather than a new candidate. The baseline, if any, is the most recent actually tested revision. flight 60957 xen-unstable running [real] http://logs.test-lab.xenproject.org/osstest/logs/60957/ Regressions :-(

[Xen-devel] [PATCH v2] x86: wrap kexec feature with CONFIG_KEXEC

2015-08-28 Thread Jonathan Creekmore
Add the appropriate #if checks around the kexec code in the x86 codebase so that the feature can actually be turned off by the flag instead of always required to be enabled on x86. Signed-off-by: Jonathan Creekmore jonathan.creekm...@gmail.com --- Changed since v1: * Reorder kexec files to be

Re: [Xen-devel] [PATCH v3 12/20] xen/balloon: Don't rely on the page granularity is the same for Xen and Linux

2015-08-28 Thread Julien Grall
On 20/08/15 10:59, David Vrabel wrote: On 07/08/15 17:46, Julien Grall wrote: For ARM64 guests, Linux is able to support either 64K or 4K page granularity. Although, the hypercall interface is always based on 4K page granularity. With 64K page granularity, a single page will be spread over

Re: [Xen-devel] [PATCH v3 15/20] block/xen-blkfront: Make it running on 64KB page granularity

2015-08-28 Thread Julien Grall
On 20/08/15 09:10, Roger Pau Monné wrote: Hello, Hi, I have some comments regarding the commit message, IMHO it would be good that a native English speaker reviews it too. El 07/08/15 a les 18.46, Julien Grall ha escrit: The PV block protocol is using 4KB page granularity. The goal of

Re: [Xen-devel] [xen 4.6 retrospective] [good] Feedback from developer meeting Wed 19th : What went well in 4.6

2015-08-28 Thread Jan Beulich
On 28.08.15 at 14:28, lars.kurth@gmail.com wrote: * Testing: staging and master being close together for most of the cycle This was observed or said by whom? I've certainly got - not infrequently - a different impression. Jan ___ Xen-devel

[Xen-devel] [OSSTest Nested v12 17/21] Compose the main recipe of nested test job

2015-08-28 Thread Robert Ho
After integrated Ian J.'s code of nested infrasture changes, re- write the nested job's recipe. Signed-off-by: Robert Ho robert...@intel.com --- sg-run-job | 10 ++ 1 file changed, 10 insertions(+) diff --git a/sg-run-job b/sg-run-job index 4ae651d..3f24fd6 100755 --- a/sg-run-job +++

[Xen-devel] [OSSTest Nested v12 09/21] Wrapper and use core_dump_setup() for nested host and normal host to setup coredump sysctl

2015-08-28 Thread Robert Ho
This patch does these 4 things: 1. wrapper coredump setup code from original ts-host-install into TestSupport.pm 2. replace ts-host-install original code with this wrapper function 3. in debian-hvm-install, create '/var/core' in hvm host post installation. 4. in ts-nested-setup, call this function

[Xen-devel] [OSSTest Nested v12 10/21] Add test job for nest test case

2015-08-28 Thread Robert Ho
1. This patch adds creation of the nested test job, when job creation procedure is invoked. 2. Set nested L1's vif model, nestedhvm feature, set specific disk size and memory size for nested test by make-flight. Changes since last version: 1. '\' right aligned 2. remove some unnecessary '' 3. no

Re: [Xen-devel] Design doc of adding ACPI support for arm64 on Xen - version 5

2015-08-28 Thread Jan Beulich
On 28.08.15 at 11:45, zhaoshengl...@huawei.com wrote: 2. Copy and change some EFI and ACPI tables --- a) Create EFI_SYSTEM_TABLE table Copy the header from the origin and change the value of FirmwareVendor. Careful: The version in the header may imply

[Xen-devel] [OSSTest Nested v12 16/21] Add PDU power method for nested L1 and L2 guest

2015-08-28 Thread Robert Ho
For nested host/guest, its power on/off method shall be its host invoke $(toolstack)-create/destroy method. --- Osstest/PDU/guest.pm | 63 ++ Osstest/TestSupport.pm | 3 +++ 2 files changed, 66 insertions(+) create mode 100755

[Xen-devel] [OSSTest Nested v12 13/21] sg-run-job: Break out per-host-prep and per-host-finish

2015-08-28 Thread Robert Ho
From: Ian Jackson ian.jack...@eu.citrix.com No functional change. We now call the per-host-ts finish steps unconditionally, rather than only if !$need_build_host, per-host-ts is (complicated) no-op if $need_build_host, since in that case $need_xen_hosts is {}. Signed-off-by: Ian Jackson

Re: [Xen-devel] [xen 4.6 retrospective] [bad] review load near freeze point

2015-08-28 Thread Lars Kurth
Jan, I wanted to pick this one up again, as this also came up in the developer meeting (where we did a face-2-face retrospective). A few other possible solutions were bounced regarding this problem. Regards Lars On 12 Aug 2015, at 09:00, Jan Beulich jbeul...@suse.com wrote: On 04.08.15 at

[Xen-devel] [xen 4.6 retrospective] [bad] Code style checking takes up too much time

2015-08-28 Thread Lars Kurth
Another one from the developer meeting = Issue / Observation = Code style checking takes up too much time. This affects both reviewers who spend a significant amount commenting on style issues and also makes it harder to for contributors to focus on non-style issues. What I mean by the latter

[Xen-devel] [qemu-upstream-4.3-testing test] 60903: tolerable FAIL - PUSHED

2015-08-28 Thread osstest service owner
flight 60903 qemu-upstream-4.3-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/60903/ Failures :-/ but no regressions. Tests which did not succeed, including tests which could not be run: test-amd64-i386-xl-raw9 debian-di-install fail baseline untested

Re: [Xen-devel] [PATCH v3 04/20] xen/grant: Introduce helpers to split a page into grant

2015-08-28 Thread Julien Grall
Hi David, On 20/08/15 10:51, David Vrabel wrote: On 07/08/15 17:46, Julien Grall wrote: Currently, a grant is always based on the Xen page granularity (i.e 4KB). When Linux is using a different page granularity, a single page will be split between multiple grants. The new helpers will be in

Re: [Xen-devel] [PATCH] x86: adjustments to memory_add()

2015-08-28 Thread Jan Beulich
On 28.08.15 at 16:11, andrew.coop...@citrix.com wrote: On 28/08/15 14:54, Jan Beulich wrote: The function should clean up after a failed map_pages_to_xen(). Sharing the M2P table with Dom0 needs to happen before adding the new pages to the heap. Why? Does this not create a race where dom0

Re: [Xen-devel] [xen 4.6 retrospective] [good] Feedback from developer meeting Wed 19th : What went well in 4.6

2015-08-28 Thread Lars Kurth
On 28 Aug 2015, at 15:43, Jan Beulich jbeul...@suse.com wrote: On 28.08.15 at 14:28, lars.kurth@gmail.com wrote: * Testing: staging and master being close together for most of the cycle This was observed or said by whom? I've certainly got - not infrequently - a different impression.

Re: [Xen-devel] [PATCH v2 qemu-trad] HVM: atomically access pointers in bufioreq handling

2015-08-28 Thread Ian Jackson
Jan Beulich writes ([PATCH v2 qemu-trad] HVM: atomically access pointers in bufioreq handling): The number of slots per page being 511 (i.e. not a power of two) means that the (32-bit) read and write indexes going beyond 2^32 will likely disturb operation. The hypervisor side gets I/O req

[Xen-devel] Xen on ARM: Read SP_usr and SP_svc in HYP mode

2015-08-28 Thread harry
Hi, Now I want to implement some functions in other hypervisor, so I need to read SP_usr and SP_svc in HYP mode. I know Xen has implemented this function. But I use it with regs-sp_usr/svc to achieve this. But I don't know how to achieve it. I have read the entry.S file and get the process to

Re: [Xen-devel] Design doc of adding ACPI support for arm64 on Xen - version 5

2015-08-28 Thread Shannon Zhao
On 2015/8/28 23:06, Jan Beulich wrote: On 28.08.15 at 11:45, zhaoshengl...@huawei.com wrote: 2. Copy and change some EFI and ACPI tables --- a) Create EFI_SYSTEM_TABLE table Copy the header from the origin and change the value of FirmwareVendor.

[Xen-devel] [PATCH] x86/mm: make {set, clear}_identity_p2m_mapping() work for PV guests

2015-08-28 Thread Jan Beulich
Namely Dom0 suffers from commit 5ae03990c1 (xen/vtd: create RMRR mapping) having removed the creation of such mappings for non- translated guests. Reported-by: Malcolm Crossley malcolm.cross...@citrix.com Signed-off-by: Jan Beulich jbeul...@suse.com --- a/xen/arch/x86/mm/p2m.c +++

Re: [Xen-devel] [PATCH] iommu/quirk: disable shared EPT for Sandybridge and earlier processors.

2015-08-28 Thread Andrew Cooper
On 28/08/15 16:41, Anshul Makkar anshul.makkar@citrix.com wrote: From: anshulma anshul.mak...@citrix.com Sandybridge or earlier processors don't have huge page support for IOTLB which leads to fallback on 4k pages and causes performance issues. Shared EPT will be disabled only if the user

[Xen-devel] [OSSTEST PATCH 1/6] Other-revision-jobs: Provide central test

2015-08-28 Thread Ian Jackson
Since 75fbbc19 Arrange to test migration from the previous Xen version, some flights have contained additional jobs build-*-prev, which build a different revision of xen.git. However, this violates an existing assumption in several of the automatic archaeologists, namely that a flight should

[Xen-devel] [OSSTEST PATCH 2/6] Other-revision-jobs: Update report__find_test

2015-08-28 Thread Ian Jackson
This is straightforward. We simply don't look at the revision runvars in non-main-revision jobs, when searching for suitable flights. Signed-off-by: Ian Jackson ian.jack...@eu.citrix.com --- Osstest/Executive.pm |1 + 1 file changed, 1 insertion(+) diff --git a/Osstest/Executive.pm

Re: [Xen-devel] [OSSTEST PATCH 1/6] Other-revision-jobs: Provide central test

2015-08-28 Thread Ian Jackson
Ian Jackson writes ([OSSTEST PATCH 1/6] Other-revision-jobs: Provide central test): Since 75fbbc19 Arrange to test migration from the previous Xen version, some flights have contained additional jobs build-*-prev, which build a different revision of xen.git. I have force pushed all these.

Re: [Xen-devel] VT-d faults with Integrated Intel graphics on 4.6

2015-08-28 Thread Konrad Rzeszutek Wilk
On Fri, Aug 28, 2015 at 10:05:09AM +0800, Chen, Tiejun wrote: On 8/27/2015 7:03 PM, Konrad Rzeszutek Wilk wrote: On Thu, Aug 27, 2015 at 11:06:30AM +0800, Chen, Tiejun wrote: On 8/25/2015 10:43 PM, Konrad Rzeszutek Wilk wrote: On Tue, Aug 25, 2015 at 02:55:31PM +0800, Chen, Tiejun wrote: On

[Xen-devel] [xen 4.6 retrospective] [bad] Unclear support status of features

2015-08-28 Thread Lars Kurth
Again, this came up in the developer meeting. This is my last one for today. More next week = Issue / Observation = Sometimes it is difficult to find out whether a feature is supported (or in experimental or other state) This has an impact on the security team It also makes life hard for Xen

[Xen-devel] [OSSTEST PATCH 6/6] Other-revision-jobs: Update cs-bisection-step

2015-08-28 Thread Ian Jackson
This is rather more subtle. We want to be able to bisect over all the relevant inputs. What we actually want to do if one of the *prev* tests fail is to treat the previous Xen branch as a separate tree when bisecting, so each revision tuple has both current and old Xen versions. That way if the

[Xen-devel] [OSSTEST PATCH 4/6] Other-revision-jobs: Update sg-report-flight and -job-history

2015-08-28 Thread Ian Jackson
We need adjust only the regression analysis. The other occurrences of special treatment for revision fields are for reporting output, and are in the context of a specific job. Signed-off-by: Ian Jackson ian.jack...@eu.citrix.com --- sg-report-flight |4 sg-report-job-history |

[Xen-devel] [OSSTEST PATCH 5/6] Other-revision-jobs: Provide other_revision_job_suffix

2015-08-28 Thread Ian Jackson
This is a string, a function of the job name, that identifies the class of `other revisions'. It is empty for main-revision jobs and currently there is only `delimiterprev' for build-*-prev. We are going to use this in the bisector. Reimplement main_revision_job_cond in terms of this. No

Re: [Xen-devel] [xen 4.6 retrospective] [bad] review load near freeze point

2015-08-28 Thread Lars Kurth
On 28 Aug 2015, at 17:22, Jan Beulich jbeul...@suse.com wrote: On 28.08.15 at 18:04, lars.kurth@gmail.com wrote: On 28 Aug 2015, at 16:21, Jan Beulich jbeul...@suse.com wrote: B) Not enough coordination amongst committers Can you be more specific (perhaps with examples) about this

[Xen-devel] [xen 4.6 retrospective] [bad] Not enough review capacity

2015-08-28 Thread Lars Kurth
This also came up at the developer meeting = Issue / Observation = See https://www.youtube.com/watch?v=7XdKyykk1-8 https://www.youtube.com/watch?v=7XdKyykk1-8 from 35 There was also an item, called Not enough reviewer/committer coverage - I wasn't in the room at the time. Maybe the person which

  1   2   >