Re: [Xen-devel] [PATCH v7 15/17] vmx: VT-d posted-interrupt core logic handling

2015-09-22 Thread Dario Faggioli
On Tue, 2015-09-22 at 15:15 +0100, George Dunlap wrote: > On 09/22/2015 02:52 PM, Wu, Feng wrote: > > > > > > > -Original Message- > > > From: Dario Faggioli [mailto:dario.faggi...@citrix.com] > > > Yes, the idle to vCPUB switch is covered by __context_switch(), > > > but > > it cannot c

Re: [Xen-devel] [PATCH] xen/mcfg: Call PHYSDEVOP_pci_mmcfg_reserved before PCI enumeration

2015-09-22 Thread Konrad Rzeszutek Wilk
On Tue, Sep 22, 2015 at 08:11:41AM -0600, Jan Beulich wrote: > >>> On 22.09.15 at 16:03, wrote: > > On Tue, Sep 22, 2015 at 07:52:19AM -0600, Jan Beulich wrote: > >> >>> On 22.09.15 at 15:39, wrote: > >> > On Tue, Sep 22, 2015 at 06:26:11AM -0700, Ed Swierk wrote: > >> >> Any other ideas? > >> >

Re: [Xen-devel] [PATCH] xen/mcfg: Call PHYSDEVOP_pci_mmcfg_reserved before PCI enumeration

2015-09-22 Thread Konrad Rzeszutek Wilk
On Tue, Sep 22, 2015 at 08:12:56AM -0600, Jan Beulich wrote: > >>> On 22.09.15 at 16:09, wrote: > > On Tue, Sep 22, 2015 at 07:57:29AM -0600, Jan Beulich wrote: > >> >>> On 22.09.15 at 15:36, wrote: > >> > The best I could come up with is to do two loops: > >> > 1) for 0:0:0 -> ff:ff:ff call PHY

Re: [Xen-devel] [PATCH v7 17/28] xen/arm: ITS: Add GITS registers emulation

2015-09-22 Thread Julien Grall
Hi Vijay, On 18/09/15 14:09, vijay.kil...@gmail.com wrote: > From: Vijaya Kumar K > > Emulate GITS* registers > > Signed-off-by: Vijaya Kumar K > --- > v7: - Fixed wrong usage of vgic_regN* helpers > - coding styles and comments > - GITS_BASER0 is always overwritten with new value ever

Re: [Xen-devel] [PATCH] memory: polish populate_physmap()

2015-09-22 Thread Ian Campbell
On Tue, 2015-09-22 at 15:13 +0100, Andrew Cooper wrote: > On 22/09/15 13:50, Jan Beulich wrote: > > Adjust types, avoid a NULL check for a case where it's not needed, and > > simplify setting a variable on the alternative path. > > > > Signed-off-by: Jan Beulich > > Reviewed-by: Andrew Cooper A

Re: [Xen-devel] [PATCH v7 09/17] VT-d: Remove pointless casts

2015-09-22 Thread Jan Beulich
>>> On 11.09.15 at 10:28, wrote: > Remove pointless casts. > Suggested-by: Jan Beulich > Signed-off-by: Feng Wu > Reviewed-by: Konrad Rzeszutek Wilk ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v7 10/17] vt-d: Extend struct iremap_entry to support VT-d Posted-Interrupts

2015-09-22 Thread Jan Beulich
>>> On 11.09.15 at 10:28, wrote: > Extend struct iremap_entry according to VT-d Posted-Interrupts Spec. > > CC: Yang Zhang > CC: Kevin Tian > Signed-off-by: Feng Wu > Acked-by: Kevin Tian > --- > v7: > - Add a __uint128_t member to the union in struct iremap_entry How about making use of thi

Re: [Xen-devel] [PATCH v7 15/17] vmx: VT-d posted-interrupt core logic handling

2015-09-22 Thread George Dunlap
On 09/22/2015 02:25 PM, Wu, Feng wrote: >>> But if we want to avoid spurious PI interrupts when running idle, then >>> yes, we need *some* kind of a hook on the lazy context switch path. >>> >>> /me does some more thinking... >> >> To be honest, since we'll be get spurious PI interrupts in the >> h

Re: [Xen-devel] [PATCH v7 08/17] vmx: Suppress posting interrupts when 'SN' is set

2015-09-22 Thread Jan Beulich
>>> On 11.09.15 at 10:28, wrote: > --- a/xen/arch/x86/hvm/vmx/vmx.c > +++ b/xen/arch/x86/hvm/vmx/vmx.c > @@ -1701,8 +1701,35 @@ static void vmx_deliver_posted_intr(struct vcpu *v, u8 > vector) > */ > pi_set_on(&v->arch.hvm_vmx.pi_desc); > } > -else if ( !pi_test_and_se

Re: [Xen-devel] [PATCH 1/3] x86/p2m: tighten conditions of IOMMU mapping updates

2015-09-22 Thread Jan Beulich
>>> On 21.09.15 at 16:02, wrote: > In the EPT case permission changes should also result in updates or > TLB flushes. > > In the NPT case the old MFN does not depend on the new entry being > valid (but solely on the old one), and the need to update or TLB-flush > again also depends on permission

Re: [Xen-devel] [PATCH v7 05/17] vmx: Extend struct pi_desc to support VT-d Posted-Interrupts

2015-09-22 Thread Jan Beulich
>>> On 11.09.15 at 10:28, wrote: > Extend struct pi_desc according to VT-d Posted-Interrupts Spec. > > Signed-off-by: Feng Wu > Reviewed-by: Andrew Cooper > Acked-by: Kevin Tian > Reviewed-by: Konrad Rzeszutek Wilk > --- > v7: > - Coding style. Are you sure? > --- a/xen/include/asm-x86/hvm/

Re: [Xen-devel] [PATCH v7 04/17] vt-d: VT-d Posted-Interrupts feature detection

2015-09-22 Thread Jan Beulich
>>> On 11.09.15 at 10:28, wrote: > VT-d Posted-Interrupts is an enhancement to CPU side Posted-Interrupt. > With VT-d Posted-Interrupts enabled, external interrupts from > direct-assigned devices can be delivered to guests without VMM > intervention when guest is running in non-root mode. > > Sig

Re: [Xen-devel] [PATCH v7 15/17] vmx: VT-d posted-interrupt core logic handling

2015-09-22 Thread George Dunlap
On 09/22/2015 02:52 PM, Wu, Feng wrote: > > >> -Original Message- >> From: Dario Faggioli [mailto:dario.faggi...@citrix.com] >> Sent: Tuesday, September 22, 2015 9:40 PM >> To: Wu, Feng; George Dunlap >> Cc: xen-devel@lists.xen.org; Tian, Kevin; Keir Fraser; George Dunlap; Andrew >> Coope

Re: [Xen-devel] Second regression due to libxl: Remove linux udev rules (2ba368d13893402b2f1fb3c283ddcc714659dd9b)

2015-09-22 Thread Konrad Rzeszutek Wilk
On Tue, Aug 18, 2015 at 09:49:43AM +0200, Roger Pau Monné wrote: > El 12/08/15 a les 16.09, Konrad Rzeszutek Wilk ha escrit: > > On Fri, Aug 07, 2015 at 04:58:57PM +0200, Roger Pau Monné wrote: > >> El 07/08/15 a les 16.54, Konrad Rzeszutek Wilk ha escrit: > >>> Ok. I hadn't run your patch yet. Do

Re: [Xen-devel] [PATCH] xen/mcfg: Call PHYSDEVOP_pci_mmcfg_reserved before PCI enumeration

2015-09-22 Thread Jan Beulich
>>> On 22.09.15 at 16:09, wrote: > On Tue, Sep 22, 2015 at 07:57:29AM -0600, Jan Beulich wrote: >> >>> On 22.09.15 at 15:36, wrote: >> > The best I could come up with is to do two loops: >> > 1) for 0:0:0 -> ff:ff:ff call PHYSDEVOP_pci_device_remove >> > (so blow away what Xen has for its PC

Re: [Xen-devel] [PATCH] memory: polish populate_physmap()

2015-09-22 Thread Andrew Cooper
On 22/09/15 13:50, Jan Beulich wrote: Adjust types, avoid a NULL check for a case where it's not needed, and simplify setting a variable on the alternative path. Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper ___ Xen-devel mailing list Xen-d

Re: [Xen-devel] [PATCH] xen/mcfg: Call PHYSDEVOP_pci_mmcfg_reserved before PCI enumeration

2015-09-22 Thread Jan Beulich
>>> On 22.09.15 at 16:03, wrote: > On Tue, Sep 22, 2015 at 07:52:19AM -0600, Jan Beulich wrote: >> >>> On 22.09.15 at 15:39, wrote: >> > On Tue, Sep 22, 2015 at 06:26:11AM -0700, Ed Swierk wrote: >> >> Any other ideas? >> > >> > I like it - as it will update it right away. However we would need

Re: [Xen-devel] [PATCH] xen/mcfg: Call PHYSDEVOP_pci_mmcfg_reserved before PCI enumeration

2015-09-22 Thread Konrad Rzeszutek Wilk
On Tue, Sep 22, 2015 at 07:57:29AM -0600, Jan Beulich wrote: > >>> On 22.09.15 at 15:36, wrote: > > The best I could come up with is to do two loops: > > 1) for 0:0:0 -> ff:ff:ff call PHYSDEVOP_pci_device_remove > > (so blow away what Xen has for its PCI devices.. except for the AMD > > IOMM

Re: [Xen-devel] [PATCH] Add missing license and copyright statements to public interface headers.

2015-09-22 Thread Mike Belopuhov
On Tue, Sep 22, 2015 at 09:00 -0400, Konrad Rzeszutek Wilk wrote: > On Tue, Sep 22, 2015 at 01:42:14PM +0200, Mike Belopuhov wrote: > > On Fri, Sep 18, 2015 at 10:13 -0400, Konrad Rzeszutek Wilk wrote: > > > On Fri, Sep 18, 2015 at 08:00:28AM -0400, Boris Ostrovsky wrote: > > > > > > > > > > > >

[Xen-devel] [PATCH] Add missing license and copyright statements to public interface headers.

2015-09-22 Thread Mike Belopuhov
The copyright line indicates a person, a group of people and/or a company granting rights stated in the license text and is a required part of the license. The year of the copyright is chosen to be the same as when the license has been applied to the file or when the file has been created in case

Re: [Xen-devel] [PATCH] xen/mcfg: Call PHYSDEVOP_pci_mmcfg_reserved before PCI enumeration

2015-09-22 Thread Konrad Rzeszutek Wilk
On Tue, Sep 22, 2015 at 07:52:19AM -0600, Jan Beulich wrote: > >>> On 22.09.15 at 15:39, wrote: > > On Tue, Sep 22, 2015 at 06:26:11AM -0700, Ed Swierk wrote: > >> Any other ideas? > > > > I like it - as it will update it right away. However we would need some > > extra smarts in Xen to reconfigu

Re: [Xen-devel] [PATCH v7 15/17] vmx: VT-d posted-interrupt core logic handling

2015-09-22 Thread Jan Beulich
>>> On 22.09.15 at 15:40, wrote: > >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: Tuesday, September 22, 2015 5:00 PM >> To: Wu, Feng >> Cc: Andrew Cooper; Dario Faggioli; George Dunlap; George Dunlap; Tian, > Kevin; >> xen-devel@lists.xen.org; Keir Frase

Re: [Xen-devel] [PATCH] xen/mcfg: Call PHYSDEVOP_pci_mmcfg_reserved before PCI enumeration

2015-09-22 Thread Jan Beulich
>>> On 22.09.15 at 15:36, wrote: > The best I could come up with is to do two loops: > 1) for 0:0:0 -> ff:ff:ff call PHYSDEVOP_pci_device_remove > (so blow away what Xen has for its PCI devices.. except for the AMD > IOMMU) > 2) list_for_each_pci_device PHYSDEVOP_pci_device_add (or other va

Re: [Xen-devel] [PATCH v7 02/17] Add cmpxchg16b support for x86-64

2015-09-22 Thread Wu, Feng
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Tuesday, September 22, 2015 9:51 PM > To: Wu, Feng > Cc: Andrew Cooper; xen-devel@lists.xen.org; Keir Fraser > Subject: Re: [PATCH v7 02/17] Add cmpxchg16b support for x86-64 > > +#define cmpxchg16b(ptr,o,n) > \ >

Re: [Xen-devel] [PATCH] xen/mcfg: Call PHYSDEVOP_pci_mmcfg_reserved before PCI enumeration

2015-09-22 Thread Jan Beulich
>>> On 22.09.15 at 15:39, wrote: > On Tue, Sep 22, 2015 at 06:26:11AM -0700, Ed Swierk wrote: >> Any other ideas? > > I like it - as it will update it right away. However we would need some > extra smarts in Xen to reconfigure its view of the PCI device now that the > extended configuration space

Re: [Xen-devel] [PATCH v7 15/17] vmx: VT-d posted-interrupt core logic handling

2015-09-22 Thread Wu, Feng
> -Original Message- > From: Dario Faggioli [mailto:dario.faggi...@citrix.com] > Sent: Tuesday, September 22, 2015 9:40 PM > To: Wu, Feng; George Dunlap > Cc: xen-devel@lists.xen.org; Tian, Kevin; Keir Fraser; George Dunlap; Andrew > Cooper; Jan Beulich > Subject: Re: [Xen-devel] [PATCH v

Re: [Xen-devel] [PATCH v7 02/17] Add cmpxchg16b support for x86-64

2015-09-22 Thread Jan Beulich
>>> On 11.09.15 at 10:28, wrote: > --- a/xen/include/asm-x86/x86_64/system.h > +++ b/xen/include/asm-x86/x86_64/system.h > @@ -6,6 +6,37 @@ > (unsigned long)(n),sizeof(*(ptr > > /* > + * Atomic 16 bytes compare and exchange. Compare OLD with MEM, if > +

Re: [Xen-devel] [PATCH v7 16/28] xen/arm: ITS: Add virtual ITS commands support

2015-09-22 Thread Julien Grall
Hi Vijay, On 18/09/15 14:09, vijay.kil...@gmail.com wrote: > From: Vijaya Kumar K > > Add Virtual ITS command processing support to Virtual ITS driver > > Signed-off-by: Vijaya Kumar K I've got minor comments in vits_get_max_collections. With that addressed: Reviewed-by: Julien Grall [...

Re: [Xen-devel] Is: Make XENVER_* use XSM, seperate the different ops in smaller security domains. Was:Re: [PATCH v1 5/5] xsplice: Use ld-embedded build-ids

2015-09-22 Thread Konrad Rzeszutek Wilk
On Tue, Sep 22, 2015 at 02:33:23PM +0100, Andrew Cooper wrote: > On 22/09/15 14:22, Konrad Rzeszutek Wilk wrote: > >On Fri, Sep 18, 2015 at 12:40:46PM +0100, Andrew Cooper wrote: > >>On 17/09/15 19:45, Konrad Rzeszutek Wilk wrote: > >>>. snip.. > The build id of the current running hypervis

Re: [Xen-devel] [PATCH] console: allow log level threshold adjustments from serial console

2015-09-22 Thread Andrew Cooper
On 22/09/15 14:24, Jan Beulich wrote: On 22.09.15 at 15:17, wrote: On 22/09/15 13:45, Jan Beulich wrote: +static void do_adj_thresh(unsigned char key) +{ +if ( *upper_thresh_adj < *lower_thresh_adj ) +*upper_thresh_adj = *lower_thresh_adj; +printk("'%c' pressed -> %s log level:

Re: [Xen-devel] [PATCH v7 15/17] vmx: VT-d posted-interrupt core logic handling

2015-09-22 Thread Dario Faggioli
On Tue, 2015-09-22 at 13:25 +, Wu, Feng wrote: > > > -Original Message- > > From: George Dunlap [mailto:george.dun...@citrix.com] > Specifically, consider the following scheduling case happened on > pCPUA: > vCPUA --> idle --> vCPUB > > 1. First, vCPUA is running on pCPUA, so the ND

Re: [Xen-devel] [PATCH v7 15/17] vmx: VT-d posted-interrupt core logic handling

2015-09-22 Thread Wu, Feng
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Tuesday, September 22, 2015 5:00 PM > To: Wu, Feng > Cc: Andrew Cooper; Dario Faggioli; George Dunlap; George Dunlap; Tian, Kevin; > xen-devel@lists.xen.org; Keir Fraser > Subject: RE: [Xen-devel] [PATCH v7 15/17]

Re: [Xen-devel] [PATCH] xen/mcfg: Call PHYSDEVOP_pci_mmcfg_reserved before PCI enumeration

2015-09-22 Thread Konrad Rzeszutek Wilk
On Tue, Sep 22, 2015 at 06:26:11AM -0700, Ed Swierk wrote: > On Tue, Sep 22, 2015 at 5:35 AM, Ed Swierk wrote: > > So if the contract is that Dom0 tells Xen about mmcfgs before the > > devices they cover, then Linux ought to call pci_mmcfg_reserved from > > (or immediately after) both pci_mmcfg_ea

Re: [Xen-devel] [PATCH] Add missing license and copyright statements to public interface headers.

2015-09-22 Thread Mike Belopuhov
On Fri, Sep 18, 2015 at 10:13 -0400, Konrad Rzeszutek Wilk wrote: > On Fri, Sep 18, 2015 at 08:00:28AM -0400, Boris Ostrovsky wrote: > > > > > > On 09/18/2015 04:44 AM, Ian Campbell wrote: > > >On Thu, 2015-09-17 at 13:53 +0200, Mike Belopuhov wrote: > > > > > >A few words here about the methodol

Re: [Xen-devel] Fwd: Fwd: LibXL

2015-09-22 Thread kumara rathnavel
Hello Ian, As requested I have attached the gdb output of the code. On 22 September 2015 at 15:21, Ian Campbell wrote: > On Tue, 2015-09-22 at 14:50 +0530, kumara rathnavel wrote: > > > > I have attached my code. I have also attached the system call traces > file > > > which was generated by th

Re: [Xen-devel] [PATCH] xen/mcfg: Call PHYSDEVOP_pci_mmcfg_reserved before PCI enumeration

2015-09-22 Thread Konrad Rzeszutek Wilk
On Mon, Sep 21, 2015 at 11:23:03PM -0600, Jan Beulich wrote: > >>> Konrad Rzeszutek Wilk 09/21/15 8:06 PM >>> > >- Never figured out how much data we should save in the Xen's > >struct pci_device to see if we are 'stale'. Looking back I think > >we just need to do the interogation of the PCI capab

Re: [Xen-devel] [BUG] XEN domU crash when PV grub chainloads 32-bit domU grub

2015-09-22 Thread Andreas Sundstrom
Citerar Andrew Cooper : On 21/09/2015 21:03, Andreas Sundstrom wrote: Using 64-bit dom0 and 32-bit domU PV (para-virtualized) grub sometimes fail when chainloading the domU's grub. 64-bit domU seem to work 100% of the time. You say sometimes. Do you mean that repeated attempts to boot a 32b

Re: [Xen-devel] [PATCH] xen/mcfg: Call PHYSDEVOP_pci_mmcfg_reserved before PCI enumeration

2015-09-22 Thread Jan Beulich
>>> On 22.09.15 at 15:26, wrote: > On Tue, Sep 22, 2015 at 5:35 AM, Ed Swierk wrote: >> So if the contract is that Dom0 tells Xen about mmcfgs before the >> devices they cover, then Linux ought to call pci_mmcfg_reserved from >> (or immediately after) both pci_mmcfg_early_init() and >> pci_mmcfg_

Re: [Xen-devel] Is: Make XENVER_* use XSM, seperate the different ops in smaller security domains. Was:Re: [PATCH v1 5/5] xsplice: Use ld-embedded build-ids

2015-09-22 Thread Andrew Cooper
On 22/09/15 14:22, Konrad Rzeszutek Wilk wrote: On Fri, Sep 18, 2015 at 12:40:46PM +0100, Andrew Cooper wrote: On 17/09/15 19:45, Konrad Rzeszutek Wilk wrote: . snip.. The build id of the current running hypervisor should belong in the xeninfo hypercall. It is not specific to xsplice. Howeve

Re: [Xen-devel] [PATCH v2] x86/HVM: correct page dirty marking in hvm_map_guest_frame_rw()

2015-09-22 Thread Jan Beulich
>>> On 22.09.15 at 15:02, wrote: > On 22/09/15 13:53, Jan Beulich wrote: >> Rather than dirtying a page when establishing a (permanent) mapping, >> dirty it when the page gets unmapped, or - if still mapped - on the >> final iteration of a save operation (or in other cases where the guest >> is pa

Re: [Xen-devel] [PATCH] xen/mcfg: Call PHYSDEVOP_pci_mmcfg_reserved before PCI enumeration

2015-09-22 Thread Ed Swierk
On Tue, Sep 22, 2015 at 5:35 AM, Ed Swierk wrote: > So if the contract is that Dom0 tells Xen about mmcfgs before the > devices they cover, then Linux ought to call pci_mmcfg_reserved from > (or immediately after) both pci_mmcfg_early_init() and > pci_mmcfg_late_init(). Brainstorming possible app

Re: [Xen-devel] [PATCH v7 09/28] xen/arm: ITS: Introduce gic_is_lpi helper function

2015-09-22 Thread Julien Grall
On 22/09/15 10:10, Vijay Kilari wrote: > On Mon, Sep 21, 2015 at 7:50 PM, Julien Grall wrote: >> That's really ugly and you still let GICv2 hardware with nr_lpis != 0. >> As said on v6 I don't want to see any usage of nr_lpis in code except >> for letting the user restricting the number of LPIs su

Re: [Xen-devel] [PATCH v7 15/17] vmx: VT-d posted-interrupt core logic handling

2015-09-22 Thread Wu, Feng
> -Original Message- > From: George Dunlap [mailto:george.dun...@citrix.com] > Sent: Tuesday, September 22, 2015 6:46 PM > To: Wu, Feng; Dario Faggioli > Cc: xen-devel@lists.xen.org; Tian, Kevin; Keir Fraser; George Dunlap; Andrew > Cooper; Jan Beulich > Subject: Re: [Xen-devel] [PATCH v7

Re: [Xen-devel] [PATCH] console: allow log level threshold adjustments from serial console

2015-09-22 Thread Jan Beulich
>>> On 22.09.15 at 15:17, wrote: > On 22/09/15 13:45, Jan Beulich wrote: >> +static void do_adj_thresh(unsigned char key) >> +{ >> +if ( *upper_thresh_adj < *lower_thresh_adj ) >> +*upper_thresh_adj = *lower_thresh_adj; >> +printk("'%c' pressed -> %s log level: %s (rate limited %s)

Re: [Xen-devel] Is: Make XENVER_* use XSM, seperate the different ops in smaller security domains. Was:Re: [PATCH v1 5/5] xsplice: Use ld-embedded build-ids

2015-09-22 Thread Konrad Rzeszutek Wilk
On Fri, Sep 18, 2015 at 12:40:46PM +0100, Andrew Cooper wrote: > On 17/09/15 19:45, Konrad Rzeszutek Wilk wrote: > > . snip.. > >> The build id of the current running hypervisor should belong in the > >> xeninfo hypercall. It is not specific to xsplice. > > However in the previous revi

Re: [Xen-devel] [PATCH v7 08/28] xen/arm: ITS: Add APIs to add and assign device

2015-09-22 Thread Julien Grall
On 22/09/15 08:33, Vijay Kilari wrote: > On Mon, Sep 21, 2015 at 7:17 PM, Julien Grall wrote: >> On 18/09/15 14:08, vijay.kil...@gmail.com wrote: >>> From: Vijaya Kumar K >>> >>> Add APIs to add devices to RB-tree, assign and remove >>> devices to domain. >>> > [...] >>> + >>> +static void its_fr

Re: [Xen-devel] [PATCH] console: allow log level threshold adjustments from serial console

2015-09-22 Thread Andrew Cooper
On 22/09/15 13:45, Jan Beulich wrote: ... so that one doesn't always need to reboot to see more / fewer messages. Note that upper thresholds are sticky, i.e. while they get adjusted upwards when the lower threshold would otherwise end up above the upper one, they don't get adjusted when reducing

[Xen-devel] [PATCH] x86: detect CMOS aliasing on ports other then 0x70/0x71

2015-09-22 Thread Jan Beulich
... in order to also intercept accesses through the alias ports. Also stop intercepting accesses to the CMOS ports if we won't ourselves use the CMOS RTC. Signed-off-by: Jan Beulich --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -1544,42 +1544,6 @@ int __hwdom_init xen_in_range(unsign

[Xen-devel] [PATCH] x86emul: support clzero

2015-09-22 Thread Jan Beulich
... in anticipation of this possibly going to get used by guests for basic thinks like memset() or clearing or pages. Since the emulation doesn't use clzero itself, checking the guest's CPUID for the feature to be exposed is (intentionally) being avoided here. All that's required is sensible guest

Re: [Xen-devel] [PATCH] x86/p2m: add PoD accounting to set_typed_p2m_entry()

2015-09-22 Thread Andrew Cooper
On 22/09/15 14:01, Jan Beulich wrote: While neither PoD together with pass-through nor PVH are currently supported we still shouldn't leave in place such latent issues. Signed-off-by: Jan Beulich Reviewed-by: Tim Deegan Reviewed-by: Andrew Cooper ___

Re: [Xen-devel] [PATCH] x86: shorten debug key 'u' output

2015-09-22 Thread Andrew Cooper
On 22/09/15 13:59, Jan Beulich wrote: ... by grouping sequences of contiguous CPUs. Signed-off-by: Jan Beulich Much nicer. Reviewed-by: Andrew Cooper ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2] x86/HVM: correct page dirty marking in hvm_map_guest_frame_rw()

2015-09-22 Thread Andrew Cooper
On 22/09/15 13:53, Jan Beulich wrote: Rather than dirtying a page when establishing a (permanent) mapping, dirty it when the page gets unmapped, or - if still mapped - on the final iteration of a save operation (or in other cases where the guest is paused or already shut down). (Transient mapping

[Xen-devel] [PATCH] x86/p2m: add PoD accounting to set_typed_p2m_entry()

2015-09-22 Thread Jan Beulich
While neither PoD together with pass-through nor PVH are currently supported we still shouldn't leave in place such latent issues. Signed-off-by: Jan Beulich Reviewed-by: Tim Deegan --- To apply cleanly this needs to have http://lists.xenproject.org/archives/html/xen-devel/2015-09/msg02719.html

Re: [Xen-devel] [PATCH] Add missing license and copyright statements to public interface headers.

2015-09-22 Thread Konrad Rzeszutek Wilk
On Tue, Sep 22, 2015 at 01:42:14PM +0200, Mike Belopuhov wrote: > On Fri, Sep 18, 2015 at 10:13 -0400, Konrad Rzeszutek Wilk wrote: > > On Fri, Sep 18, 2015 at 08:00:28AM -0400, Boris Ostrovsky wrote: > > > > > > > > > On 09/18/2015 04:44 AM, Ian Campbell wrote: > > > >On Thu, 2015-09-17 at 13:53

[Xen-devel] [PATCH] x86: shorten debug key 'u' output

2015-09-22 Thread Jan Beulich
... by grouping sequences of contiguous CPUs. Signed-off-by: Jan Beulich --- a/xen/arch/x86/numa.c +++ b/xen/arch/x86/numa.c @@ -365,7 +365,7 @@ EXPORT_SYMBOL(node_data); static void dump_numa(unsigned char key) { s_time_t now = NOW(); -unsigned int i, j; +unsigned int i, j, n;

[Xen-devel] [PATCH RFC v2] x86/p2m: use large pages for MMIO mappings

2015-09-22 Thread Jan Beulich
When mapping large BARs (e.g. the frame buffer of a graphics card) the overhead of establishing such mappings using only 4k pages has, particularly after the XSA-125 fix, become unacceptable. Alter the XEN_DOMCTL_memory_mapping semantics once again, so that there's no longer a fixed amount of guest

[Xen-devel] [PATCH v2] x86/HVM: correct page dirty marking in hvm_map_guest_frame_rw()

2015-09-22 Thread Jan Beulich
Rather than dirtying a page when establishing a (permanent) mapping, dirty it when the page gets unmapped, or - if still mapped - on the final iteration of a save operation (or in other cases where the guest is paused or already shut down). (Transient mappings continue to get dirtied upon getting m

Re: [Xen-devel] [PATCH XEN v2 08/15] tools: Refactor /dev/xen/gnt{dev, shr} wrappers into libxengnttab.

2015-09-22 Thread Ian Campbell
On Tue, 2015-09-22 at 13:41 +0100, Ian Jackson wrote: > Andrew Cooper writes ("Re: [Xen-devel] [PATCH XEN v2 08/15] tools: > Refactor /dev/xen/gnt{dev, shr} wrappers into libxengnttab."): > > On 22/09/15 12:25, Ian Campbell wrote: > > > Any thoughts/preferences on this library interface regarding:

[Xen-devel] [PATCH v2] x86/bigmem: eliminate struct domain address width restriction

2015-09-22 Thread Jan Beulich
PDX-es are 64 bits wide in that case, and hence no limit needs to be enforced. Reported-by: Andrew Cooper Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper --- v2: Use "const unsigned int bits = 0" instead of #define / #undef (as suggested by IanC). --- unstable.orig/xen/arch/x86/domai

[Xen-devel] [PATCH] memory: polish populate_physmap()

2015-09-22 Thread Jan Beulich
Adjust types, avoid a NULL check for a case where it's not needed, and simplify setting a variable on the alternative path. Signed-off-by: Jan Beulich --- a/xen/common/memory.c +++ b/xen/common/memory.c @@ -92,7 +92,7 @@ static void increase_reservation(struct static void populate_physmap(stru

[Xen-devel] [PATCH] console: allow log level threshold adjustments from serial console

2015-09-22 Thread Jan Beulich
... so that one doesn't always need to reboot to see more / fewer messages. Note that upper thresholds are sticky, i.e. while they get adjusted upwards when the lower threshold would otherwise end up above the upper one, they don't get adjusted when reducing the lower one. Signed-off-by: Jan Beul

[Xen-devel] Processed: Re: Formal Vote for changes to Xen Project Security Policy encoded in [PATCH v2 SECURITY-POLICY */9] (vote ends next Wed, Feb 11th)

2015-09-22 Thread xen
Processing commands for x...@bugs.xenproject.org: > close 44 Closing bug #44 > thanks Finished processing. Modified/created Bugs: - 44: http://bugs.xenproject.org/xen/bug/44 --- Xen Hypervisor Bug Tracker See http://wiki.xen.org/wiki/Reporting_Bugs_against_Xen for information on reporting bugs

Re: [Xen-devel] [PATCH XEN v2 08/15] tools: Refactor /dev/xen/gnt{dev, shr} wrappers into libxengnttab.

2015-09-22 Thread Ian Jackson
Andrew Cooper writes ("Re: [Xen-devel] [PATCH XEN v2 08/15] tools: Refactor /dev/xen/gnt{dev, shr} wrappers into libxengnttab."): > On 22/09/15 12:25, Ian Campbell wrote: > > Any thoughts/preferences on this library interface regarding: > > > > The use of a (perhaps to be added) grant_ref_t in pre

Re: [Xen-devel] [PATCH] xen/mcfg: Call PHYSDEVOP_pci_mmcfg_reserved before PCI enumeration

2015-09-22 Thread Jan Beulich
>>> On 22.09.15 at 14:35, wrote: > On Mon, Sep 21, 2015 at 10:21 PM, Jan Beulich wrote: >> I don't follow: Surely Dom0 first establishes MCFG areas to be used, and >> only then scans the buses for devices, resulting in them to be reported to >> the hypervisor? > > That seems like a reasonable ex

Re: [Xen-devel] [PATCH v7 05/28] xen/arm: ITS: Port ITS driver to Xen

2015-09-22 Thread Julien Grall
On 22/09/15 11:34, Vijay Kilari wrote: > On Mon, Sep 21, 2015 at 4:53 PM, Julien Grall wrote: >> Maybe you want to add the suffix _cmd to everyone to avoid having only >> one because of C spec issue. > > suffixing _cmd will look ugly ( as below ex) where "cmd" is repeated twice. Well, you alread

Re: [Xen-devel] [PATCH] xen/mcfg: Call PHYSDEVOP_pci_mmcfg_reserved before PCI enumeration

2015-09-22 Thread Ed Swierk
On Mon, Sep 21, 2015 at 10:21 PM, Jan Beulich wrote: > I don't follow: Surely Dom0 first establishes MCFG areas to be used, and > only then scans the buses for devices, resulting in them to be reported to > the hypervisor? That seems like a reasonable expectation, but while Linux 4.2 finds the mm

Re: [Xen-devel] [PATCH OSSTEST] production-config-cambridge: Use git-cache.daemon.osstest.xs.citrite.net

2015-09-22 Thread Ian Jackson
Ian Campbell writes ("[PATCH OSSTEST] production-config-cambridge: Use git-cache.daemon.osstest.xs.citrite.net"): > This currently points to drall, so no actual change, but it decouples > the service from the host which happens to run it. Acked-by: Ian Jackson __

Re: [Xen-devel] Fwd: Fwd: LibXL

2015-09-22 Thread Ian Campbell
On Tue, 2015-09-22 at 17:19 +0530, kumara rathnavel wrote: > Hello Ian, > > As requested I have attached the gdb output of the code. You need to build with debugging symbols included, or to avoid stripping them, otherwise the stack trace just contains interpretable. If you are unfamiliar with d

Re: [Xen-devel] [PATCH v7 14/28] xen/arm: ITS: Initialize physical ITS and export lpi support

2015-09-22 Thread Julien Grall
On 22/09/15 11:44, Ian Campbell wrote: > On Tue, 2015-09-22 at 11:29 +0100, Julien Grall wrote: >> >> On 22/09/2015 11:05, Ian Campbell wrote: >>> On Tue, 2015-09-22 at 10:45 +0100, Julien Grall wrote: On 22/09/2015 10:17, Vijay Kilari wrote: >> Why do you need a command line option t

Re: [Xen-devel] Formal Vote for changes to Xen Project Security Policy encoded in [PATCH v2 SECURITY-POLICY */9] (vote ends next Wed, Feb 11th)

2015-09-22 Thread Ian Campbell
close 44 thanks On Tue, 2015-09-22 at 13:12 +0100, Lars Kurth wrote: > Folks, > this bug should probably be closed. I think you meant #44. I've closed that here. Anyone can close any bug, no special privilege is required See http://wiki.xen.org/wiki/Xen_Bug_Management_Interface. Ian.

[Xen-devel] [Patch V2] libxc: remove useless stuff from domain builder

2015-09-22 Thread Juergen Gross
Remove unused fields from the domain builder and associated functions. Signed-off-by: Juergen Gross --- V2: correct python keyword parsing (Wei Liu) --- tools/libxc/include/xc_dom.h | 2 -- tools/python/xen/lowlevel/xc/xc.c | 10 +++--- 2 files changed, 3 insertions(+), 9 deletions(-)

Re: [Xen-devel] [PATCH 0/5] libxc: support building large pv-domains

2015-09-22 Thread Juergen Gross
Hi tools maintainers, On 09/11/2015 02:32 PM, Juergen Gross wrote: The Xen hypervisor supports starting a dom0 with large memory (up to the TB range) by not including the initrd and p2m list in the initial kernel mapping. Especially the p2m list can grow larger than the available virtual space i

Re: [Xen-devel] Formal Vote for changes to Xen Project Security Policy encoded in [PATCH v2 SECURITY-POLICY */9] (vote ends next Wed, Feb 11th)

2015-09-22 Thread Lars Kurth
Folks, this bug should probably be closed. Lars ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH XEN v2 08/15] tools: Refactor /dev/xen/gnt{dev, shr} wrappers into libxengnttab.

2015-09-22 Thread Andrew Cooper
On 22/09/15 12:25, Ian Campbell wrote: Any thoughts/preferences on this library interface regarding: The use of a (perhaps to be added) grant_ref_t in preference to uint32_t as it is now? Probably a good idea. We should also introduce/use domid_t consistently through the new API as well.

[Xen-devel] [PATCH OSSTEST] production-config-cambridge: Use git-cache.daemon.osstest.xs.citrite.net

2015-09-22 Thread Ian Campbell
This currently points to drall, so no actual change, but it decouples the service from the host which happens to run it. Signed-off-by: Ian Campbell --- production-config-cambridge | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/production-config-cambridge b/production-config

Re: [Xen-devel] [PATCH XEN v2 08/15] tools: Refactor /dev/xen/gnt{dev, shr} wrappers into libxengnttab.

2015-09-22 Thread Ian Campbell
Any thoughts/preferences on this library interface regarding: The use of a (perhaps to be added) grant_ref_t in preference to uint32_t as it is now? The use of bool rather than int for "writeable"? Mapping functions returning NULL on failure (rather than e.g MAP_FAILED)? (current code squashes a

Re: [Xen-devel] [PATCH] xen/keyhandler: Rework keyhandler infrastructure

2015-09-22 Thread Andrew Cooper
On 22/09/15 11:35, Jan Beulich wrote: --- a/xen/arch/x86/hvm/vmx/vmcs.c +++ b/xen/arch/x86/hvm/vmx/vmcs.c @@ -1858,15 +1858,9 @@ static void vmcs_dump(unsigned char ch) printk("**\n"); } -static struct keyhandler vmcs_dump_keyhandler = { -.dia

Re: [Xen-devel] [PATCH v4 00/20] xen/arm64: Add support for 64KB page in Linux

2015-09-22 Thread Ian Campbell
On Mon, 2015-09-14 at 17:23 +0200, Roger Pau Monné wrote: > I'm not saying that we shouldn't take those patches, I'm just saying > that IMHO this is a workaround, and I would like to see a plan and > somebody committed to have it fixed in a proper way, by introducing a > 64KB PV block protocol. In

Re: [Xen-devel] [PATCH v7 15/17] vmx: VT-d posted-interrupt core logic handling

2015-09-22 Thread George Dunlap
On 09/22/2015 11:43 AM, George Dunlap wrote: > On 09/22/2015 06:10 AM, Wu, Feng wrote: >> >> >>> -Original Message- >>> From: Dario Faggioli [mailto:dario.faggi...@citrix.com] >>> Sent: Monday, September 21, 2015 10:12 PM >>> To: Wu, Feng; George Dunlap >>> Cc: xen-devel@lists.xen.org; Tian

Re: [Xen-devel] [PATCH v7 14/28] xen/arm: ITS: Initialize physical ITS and export lpi support

2015-09-22 Thread Ian Campbell
On Tue, 2015-09-22 at 11:29 +0100, Julien Grall wrote: > > On 22/09/2015 11:05, Ian Campbell wrote: > > On Tue, 2015-09-22 at 10:45 +0100, Julien Grall wrote: > > > > > > On 22/09/2015 10:17, Vijay Kilari wrote: > > > > > Why do you need a command line option to enable/disable the > > > > > physi

Re: [Xen-devel] [PATCH v7 15/17] vmx: VT-d posted-interrupt core logic handling

2015-09-22 Thread George Dunlap
On 09/22/2015 06:10 AM, Wu, Feng wrote: > > >> -Original Message- >> From: Dario Faggioli [mailto:dario.faggi...@citrix.com] >> Sent: Monday, September 21, 2015 10:12 PM >> To: Wu, Feng; George Dunlap >> Cc: xen-devel@lists.xen.org; Tian, Kevin; Keir Fraser; George Dunlap; Andrew >> Coope

Re: [Xen-devel] [linux-3.4 test] 62189: trouble: pass/preparing/queued

2015-09-22 Thread Ian Campbell
On Tue, 2015-09-22 at 10:34 +, osstest service owner wrote: > flight 62189 linux-3.4 running [real] > http://logs.test-lab.xenproject.org/osstest/logs/62189/ > > Failures and problems with tests :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: >

Re: [Xen-devel] [PATCH] xen/keyhandler: Rework keyhandler infrastructure

2015-09-22 Thread Jan Beulich
>>> On 14.09.15 at 15:49, wrote: > key_table doesn't need to contain 256 entries; all keys are ASCII > which limits them to 7 bits of index, rather than 8. It can also > become a straight array, rather than an array of pointers. struct > keyhandler itself can become smaller simply via reordering

Re: [Xen-devel] [xen-unstable test] 62156: regressions - FAIL

2015-09-22 Thread Ian Campbell
On Tue, 2015-09-22 at 10:05 +0100, Ian Campbell wrote: > On Tue, 2015-09-22 at 00:23 +, osstest service owner wrote: > > flight 62156 xen-unstable real [real] > > http://logs.test-lab.xenproject.org/osstest/logs/62156/ > > > > Regressions :-( > > > > Tests which did not succeed and are blocki

[Xen-devel] [linux-3.4 test] 62189: trouble: pass/preparing/queued

2015-09-22 Thread osstest service owner
flight 62189 linux-3.4 running [real] http://logs.test-lab.xenproject.org/osstest/logs/62189/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-i386-pvgrub queued test-amd64-amd64-xl-qemuu

Re: [Xen-devel] [PATCH v7 05/28] xen/arm: ITS: Port ITS driver to Xen

2015-09-22 Thread Vijay Kilari
On Mon, Sep 21, 2015 at 4:53 PM, Julien Grall wrote: > Hi Vijay, > > The only things I haven't check on this patch was the ITS command structure. > > On 18/09/15 14:08, vijay.kil...@gmail.com wrote: >> +/* ITS command structure */ >> +typedef union { > > Can you please sort this union by command n

Re: [Xen-devel] [PATCH v7 14/28] xen/arm: ITS: Initialize physical ITS and export lpi support

2015-09-22 Thread Julien Grall
On 22/09/2015 11:05, Ian Campbell wrote: On Tue, 2015-09-22 at 10:45 +0100, Julien Grall wrote: On 22/09/2015 10:17, Vijay Kilari wrote: Why do you need a command line option to enable/disable the physical ITS? I have added this to remove ITS support?. Did I misunderstood it. May be I have

Re: [Xen-devel] [PATCH v7 15/17] vmx: VT-d posted-interrupt core logic handling

2015-09-22 Thread George Dunlap
On 09/22/2015 08:19 AM, Wu, Feng wrote: > > >> -Original Message- >> From: Dario Faggioli [mailto:dario.faggi...@citrix.com] >> Sent: Monday, September 21, 2015 10:25 PM >> To: Wu, Feng; George Dunlap; George Dunlap >> Cc: Jan Beulich; Tian, Kevin; Keir Fraser; Andrew Cooper; >> xen-devel

[Xen-devel] Xen Security Advisory 142 - libxl fails to honour readonly flag on disks with qemu-xen

2015-09-22 Thread Xen . org security team
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Xen Security Advisory XSA-142 libxl fails to honour readonly flag on disks with qemu-xen ISSUE DESCRIPTION = Callers of libxl can specify that a disk should be read-only to the guest. However, there is no

Re: [Xen-devel] [PATCH v7 14/28] xen/arm: ITS: Initialize physical ITS and export lpi support

2015-09-22 Thread Ian Campbell
On Tue, 2015-09-22 at 10:45 +0100, Julien Grall wrote: > > On 22/09/2015 10:17, Vijay Kilari wrote: > > > Why do you need a command line option to enable/disable the physical > > > ITS? > > > > I have added this to remove ITS support?. > > Did I misunderstood it. May be I have to avoid generating

Re: [Xen-devel] [PATCH v7 05/28] xen/arm: ITS: Port ITS driver to Xen

2015-09-22 Thread Julien Grall
Hi Vijay, On 22/09/2015 10:55, Vijay Kilari wrote: On Mon, Sep 21, 2015 at 4:53 PM, Julien Grall wrote: Hi Vijay, The only things I haven't check on this patch was the ITS command structure. [...] Why a padding of only 56 bits? Shouldn't it be 248 bits (i.e 31 * 8 bits) to fit all the comm

Re: [Xen-devel] [PATCH v7 05/28] xen/arm: ITS: Port ITS driver to Xen

2015-09-22 Thread Vijay Kilari
On Mon, Sep 21, 2015 at 4:53 PM, Julien Grall wrote: > Hi Vijay, > > The only things I haven't check on this patch was the ITS command structure. [...] > Why a padding of only 56 bits? Shouldn't it be 248 bits (i.e 31 * 8 > bits) to fit all the command? > >> +} hdr; >> +struct __packed { >

Re: [Xen-devel] Fwd: Fwd: LibXL

2015-09-22 Thread Ian Campbell
On Tue, 2015-09-22 at 14:50 +0530, kumara rathnavel wrote: > > I have attached my code. I have also attached the system call traces file > > which was generated by the command truss for the command that was > > successful through XL and the other one that failed where I used the call > > directly.

Re: [Xen-devel] [PATCH v7 14/28] xen/arm: ITS: Initialize physical ITS and export lpi support

2015-09-22 Thread Julien Grall
On 22/09/2015 10:17, Vijay Kilari wrote: Why do you need a command line option to enable/disable the physical ITS? I have added this to remove ITS support?. Did I misunderstood it. May be I have to avoid generating its dt node to disable its for dom0? My question is why do you want to let t

Re: [Xen-devel] [xen-unstable test] 62156: regressions - FAIL

2015-09-22 Thread Jan Beulich
>>> On 22.09.15 at 11:05, wrote: > On Tue, 2015-09-22 at 00:23 +, osstest service owner wrote: >> flight 62156 xen-unstable real [real] >> http://logs.test-lab.xenproject.org/osstest/logs/62156/ >> >> Regressions :-( >> >> Tests which did not succeed and are blocking, >> including tests whi

[Xen-devel] xl: insufficient ballooning when starting certain guests

2015-09-22 Thread Jan Beulich
Tools maintainers, it looks as if changes in the memory requirements of the hypervisor have pushed things over the border of not working anymore when passing through a device and not sharing page tables (between VT-d and EPT, or unconditionally on AMD). Since this has always been a latent issue (a

[Xen-devel] Fwd: Fwd: LibXL

2015-09-22 Thread kumara rathnavel
> > > Hello All, > > I am not able to use the library functions provided by the LibXenlight > though I am able to use it through XL. I am in need to develop my own CLI > . I am able to perform few basic operations like listing the VM, reboot > and all. But the calls that require a structure to be f

Re: [Xen-devel] [PATCH] IOMMU: complete/correct comment explaining "iommu=" sub-options

2015-09-22 Thread Julien Grall
Hi, On 22/09/2015 08:15, Andrew Cooper wrote: On 22/09/2015 08:04, Jan Beulich wrote: Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper Some of these are overly Intel-specific, but while AMD has no implementation, this isn't much of a problem. Note that on ARM, we are only using off|

Re: [Xen-devel] [PATCH v7 14/28] xen/arm: ITS: Initialize physical ITS and export lpi support

2015-09-22 Thread Vijay Kilari
On Mon, Sep 21, 2015 at 8:50 PM, Julien Grall wrote: > Hi Vijay, > > On 18/09/15 14:09, vijay.kil...@gmail.com wrote: >> From: Vijaya Kumar K >> >> Initialize physical ITS if HW supports LPIs. >> >> Signed-off-by: Vijaya Kumar K >> --- >> v7: - Export lpi support information to vgic-v3 driver fr

Re: [Xen-devel] [PATCH v7 09/28] xen/arm: ITS: Introduce gic_is_lpi helper function

2015-09-22 Thread Vijay Kilari
On Mon, Sep 21, 2015 at 7:50 PM, Julien Grall wrote: > Hi Vijay, > > On 18/09/15 14:08, vijay.kil...@gmail.com wrote: >> From: Vijaya Kumar K >> >> Helper function gic_is_lpi() is used to find >> if irq is lpi or not. For GICv2 platforms this function >> returns number of irq ids which represents

<    1   2   3   >