Re: [Xen-devel] [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-16 Thread Laszlo Ersek
On 10/16/15 13:34, Fabio Fantoni wrote: > Il 16/10/2015 12:47, Stefano Stabellini ha scritto: >> On Fri, 16 Oct 2015, Fabio Fantoni wrote: >>> Il 16/10/2015 12:13, Anthony PERARD ha scritto: On Fri, Oct 16, 2015 at 10:32:44AM +0200, Fabio Fantoni wrote: > Il 15/10/2015 20:02, Anthony

Re: [Xen-devel] [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-16 Thread Eric Blake
On 10/16/2015 10:20 AM, Paul Durrant wrote: >> -Original Message- >>> On 10/13/2015 11:55 AM, Fabio Fantoni wrote: I added ahci disk support in libxl and using it for week seems Do we really need this many levels of quoting... that >> was ok,

Re: [Xen-devel] [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-16 Thread Paul Durrant
> -Original Message- > From: Kevin Wolf [mailto:kw...@redhat.com] > Sent: 16 October 2015 17:43 > To: Paul Durrant > Cc: Fabio Fantoni; Stefano Stabellini; John Snow; Anthony Perard; qemu- > de...@nongnu.org; xen-devel@lists.xen.org; qemu-bl...@nongnu.org > Subject: Re: [Qemu-devel]

[Xen-devel] [xen-unstable-smoke test] 63011: tolerable all pass - PUSHED

2015-10-16 Thread osstest service owner
flight 63011 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/63011/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 12 migrate-support-checkfail never pass test-armhf-armhf-xl 12

Re: [Xen-devel] [PATCH v3] raisin: enable ovmf build for arm64

2015-10-16 Thread Julien Grall
On 16/10/15 12:42, Stefano Stabellini wrote: > function ovmf_check_package() { > -local DEP_Debian_common="build-essential nasm uuid-dev python iasl" > -local DEP_Debian_x86_32="$DEP_Debian_common" > -local DEP_Debian_x86_64="$DEP_Debian_common" > -local

Re: [Xen-devel] [PATCH v2 3/3] xen/arm: don't try to re-register vcpu_info on cpu_hotplug.

2015-10-16 Thread Julien Grall
Hi Stefano, On 16/10/15 17:35, Stefano Stabellini wrote: > Signed-off-by: Stefano Stabellini > --- > arch/arm/xen/enlighten.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c > index

Re: [Xen-devel] [PATCH v3 1/2] x86/mem-sharing: Bulk mem-sharing entire domains

2015-10-16 Thread Tamas K Lengyel
On Fri, Oct 16, 2015 at 12:46 AM, Jan Beulich wrote: > >>> On 15.10.15 at 20:09, wrote: > > --- a/xen/arch/x86/mm/mem_sharing.c > > +++ b/xen/arch/x86/mm/mem_sharing.c > > @@ -1293,6 +1293,42 @@ int relinquish_shared_pages(struct domain *d) > >

Re: [Xen-devel] [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-16 Thread Kevin Wolf
Am 16.10.2015 um 18:53 hat Paul Durrant geschrieben: > > > > > > Just tell your admin what virtual hardware you really need. (Or tell > > > > > > them to give you a proper interface to configure your VMs yourself.) > > > > > > > > > > > > > > > > My point is that the virtual hardware that the OS

Re: [Xen-devel] [RFC] Results of Phase 1 of the Review Process study

2015-10-16 Thread Lars Kurth
> On 16 Oct 2015, at 12:06, Stefano Stabellini > wrote: > > On Wed, 14 Oct 2015, Lars Kurth wrote: >> Hi everyone, >> >> I wanted to walk you through some of the results of the Review Process study >>

Re: [Xen-devel] [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-16 Thread John Snow
On 10/13/2015 01:10 PM, Stefano Stabellini wrote: > On Tue, 13 Oct 2015, John Snow wrote: >> On 10/13/2015 11:55 AM, Fabio Fantoni wrote: >>> I added ahci disk support in libxl and using it for week seems that was >>> ok, after a reply of Stefano Stabellini seems that xen disk unplug >>> support

[Xen-devel] [linux-4.1 test] 63000: regressions - FAIL

2015-10-16 Thread osstest service owner
flight 63000 linux-4.1 real [real] http://logs.test-lab.xenproject.org/osstest/logs/63000/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 15 guest-localmigrate.2 fail in 62951 REGR. vs.

Re: [Xen-devel] [PATCH] x86/ept: defer enabling of EPT A/D bit until PML get enabled.

2015-10-16 Thread Jan Beulich
>>> On 16.10.15 at 04:21, wrote: > Existing PML implementation turns on EPT A/D bit unconditionally if PML is > supported by hardware. This works but enabling of EPT A/D bit can be > deferred > until PML get enabled. There's no point in enabling the extra feature for

Re: [Xen-devel] [PATCH v7 2/3] x86: add domctl cmd to set/get CDP code/data CBM

2015-10-16 Thread Jan Beulich
>>> On 16.10.15 at 10:24, wrote: > On Thu, Oct 15, 2015 at 09:47:37AM -0600, Jan Beulich wrote: >> >> Ah, yes, in cases like this it should always be followed by return >> (or whatever else is suitable). Sorry for not having spotted this >> during review. >> > Sorry for

[Xen-devel] [libvirt test] 62995: tolerable FAIL - PUSHED

2015-10-16 Thread osstest service owner
flight 62995 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/62995/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-raw 9 debian-di-installfail never pass test-armhf-armhf-libvirt-qcow2 9

Re: [Xen-devel] [PATCH v7 2/3] x86: add domctl cmd to set/get CDP code/data CBM

2015-10-16 Thread He Chen
On Thu, Oct 15, 2015 at 09:47:37AM -0600, Jan Beulich wrote: > > Ah, yes, in cases like this it should always be followed by return > (or whatever else is suitable). Sorry for not having spotted this > during review. > Sorry for this bug. Is it proper to fix this bug by just adding a return

Re: [Xen-devel] [PATCH v2] libxc: fix the types used in xc_dom_image to build HVM guests

2015-10-16 Thread Wei Liu
On Fri, Oct 16, 2015 at 09:48:34AM +0100, Ian Campbell wrote: > On Thu, 2015-10-15 at 19:23 +0200, Roger Pau Monne wrote: > > Fix the types used to store the memory parameters of an HVM guest, > > previously they defaulted to unsigned long on 32bit toolstack builds, > > which > > is wrong because

Re: [Xen-devel] [RFC] Results of Phase 1 of the Review Process study

2015-10-16 Thread Ian Campbell
On Thu, 2015-10-15 at 22:18 +0100, Lars Kurth wrote: > > > On 15 Oct 2015, at 10:06, Ian Campbell wrote: > > > > On Wed, 2015-10-14 at 18:32 +0100, Lars Kurth wrote: > >> C1) Only 60% percent of the reviews on the mailing list could be matched > >> to commits. This can

Re: [Xen-devel] [RFC] Results of Phase 1 of the Review Process study

2015-10-16 Thread Ian Campbell
On Thu, 2015-10-15 at 22:18 +0100, Lars Kurth wrote: > > Separately, I suppose it is impossible to distinguish stalled from > > abandoned (and perhaps in some senses they are the same thing so we don't > > need to distinguish). > > Agreed. Unless we come up with some sort of convention, marking a

Re: [Xen-devel] [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-16 Thread Laszlo Ersek
On 10/16/15 11:06, Stefano Stabellini wrote: > On Thu, 15 Oct 2015, Kevin O'Connor wrote: >> On Fri, Oct 16, 2015 at 01:10:54AM +0200, Laszlo Ersek wrote: >>> On 10/14/15 13:27, Ian Campbell wrote: On Wed, 2015-10-14 at 12:06 +0100, Stefano Stabellini wrote: >> Can't you just teach

Re: [Xen-devel] [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-16 Thread Stefano Stabellini
On Fri, 16 Oct 2015, Laszlo Ersek wrote: > On 10/16/15 11:06, Stefano Stabellini wrote: > > On Thu, 15 Oct 2015, Kevin O'Connor wrote: > >> On Fri, Oct 16, 2015 at 01:10:54AM +0200, Laszlo Ersek wrote: > >>> On 10/14/15 13:27, Ian Campbell wrote: > On Wed, 2015-10-14 at 12:06 +0100, Stefano

Re: [Xen-devel] [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-16 Thread Ian Campbell
On Fri, 2015-10-16 at 10:06 +0100, Stefano Stabellini wrote: > > What's the reason for the "stumbling block" that requires the BIOS to > > tear down the Xen ring prior to the OS being able to replace it? The > > BIOS disk calls are all synchronous, so the ring wont be active when > > the OS

Re: [Xen-devel] [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-16 Thread Anthony PERARD
On Fri, Oct 16, 2015 at 10:32:44AM +0200, Fabio Fantoni wrote: > Il 15/10/2015 20:02, Anthony PERARD ha scritto: > >On Thu, Oct 15, 2015 at 06:27:17PM +0200, Fabio Fantoni wrote: > >>Il 14/10/2015 13:06, Stefano Stabellini ha scritto: > >>>I would suggest Fabio to avoid AHCI disks altogether and

Re: [Xen-devel] Survey Results - Part 1 : Improving Xen Project Governance and Conventions

2015-10-16 Thread Lars Kurth
> On 6 Oct 2015, at 10:29, Ian Campbell wrote: > > On Mon, 2015-10-05 at 23:31 +0100, Lars Kurth wrote: >> I am not sure whether the hierarchy would require everyone to ACK. As far >> as I understand Linux does this without (but I suppose the ACK is >> replaced by a

[Xen-devel] [PATCH] tools: libxl: CODING_STYLE: GC* cannot be used with NOGC

2015-10-16 Thread Ian Campbell
GC* assume an existing gc in scope, which means they can't be passed NOGC. Instead recommend the use of the underlying functions with NOGC, noting that this is excepitonal. Signed-off-by: Ian Campbell --- tools/libxl/CODING_STYLE | 3 ++- 1 file changed, 2

Re: [Xen-devel] [PATCH] tools: libxl: CODING_STYLE: GC* cannot be used with NOGC

2015-10-16 Thread Wei Liu
On Fri, Oct 16, 2015 at 11:33:12AM +0100, Ian Campbell wrote: > GC* assume an existing gc in scope, which means they can't be passed > NOGC. Instead recommend the use of the underlying functions with NOGC, > noting that this is excepitonal. > > Signed-off-by: Ian Campbell

Re: [Xen-devel] [PATCH v2] libxc: fix the types used in xc_dom_image to build HVM guests

2015-10-16 Thread Ian Campbell
On Thu, 2015-10-15 at 19:23 +0200, Roger Pau Monne wrote: > Fix the types used to store the memory parameters of an HVM guest, > previously they defaulted to unsigned long on 32bit toolstack builds, > which > is wrong because a 32bit value cannot hold a 64bit memory address that > crosses the 4GB

Re: [Xen-devel] [PATCH v2] libxc: fix the types used in xc_dom_image to build HVM guests

2015-10-16 Thread Ian Campbell
On Thu, 2015-10-15 at 19:23 +0200, Roger Pau Monne wrote: > Fix the types used to store the memory parameters of an HVM guest, > previously they defaulted to unsigned long on 32bit toolstack builds, which > is wrong because a 32bit value cannot hold a 64bit memory address that > crosses the 4GB

Re: [Xen-devel] [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-16 Thread Laszlo Ersek
On 10/16/15 04:38, Kevin O'Connor wrote: > On Fri, Oct 16, 2015 at 01:10:54AM +0200, Laszlo Ersek wrote: >> On 10/14/15 13:27, Ian Campbell wrote: >>> On Wed, 2015-10-14 at 12:06 +0100, Stefano Stabellini wrote: > Can't you just teach SeaBIOS how to deal with your PV disks and then > only

Re: [Xen-devel] [RFC] Results of Phase 1 of the Review Process study

2015-10-16 Thread Ian Campbell
On Fri, 2015-10-16 at 00:32 +0200, Jesus M. Gonzalez-Barahona wrote: > On Thu, 2015-10-15 at 22:36 +0100, Lars Kurth wrote: > > > On 15 Oct 2015, at 10:26, Ian Campbell > > > wrote: > > > > > > On Thu, 2015-10-15 at 10:06 +0100, Ian Campbell wrote: > > > > > On Wed,

[Xen-devel] [distros-debian-jessie test] 38174: regressions - FAIL

2015-10-16 Thread Platform Team regression test user
flight 38174 distros-debian-jessie real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/38174/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-i386-jessie-netboot-pvgrub 9 debian-di-install fail REGR. vs. 38142

Re: [Xen-devel] [PATCH] xen-netback: correctly check failed allocation

2015-10-16 Thread Wei Liu
On Thu, Oct 15, 2015 at 02:02:47PM -0400, Insu Yun wrote: > I changed patch with valid format. > > On Thu, Oct 15, 2015 at 2:02 PM, Insu Yun wrote: > > > Since vzalloc can be failed in memory pressure, > > writes -ENOMEM to xenstore to indicate error. > > > > Signed-off-by:

Re: [Xen-devel] [PATCH v7 2/3] x86: add domctl cmd to set/get CDP code/data CBM

2015-10-16 Thread Olaf Hering
On Thu, Oct 15, Wei Liu wrote: > No, because 1) staging is not using GCC5, 2) staging has debug=y. Are there enough resources to address #2? Build once with debug=y and once without? Olaf ___ Xen-devel mailing list Xen-devel@lists.xen.org

Re: [Xen-devel] [PATCH v2] libxc: fix the types used in xc_dom_image to build HVM guests

2015-10-16 Thread Ian Campbell
On Fri, 2015-10-16 at 11:03 +0200, Roger Pau Monné wrote: > El 16/10/15 a les 11.00, Wei Liu ha escrit: > > On Fri, Oct 16, 2015 at 09:57:02AM +0100, Ian Campbell wrote: > > > On Thu, 2015-10-15 at 19:23 +0200, Roger Pau Monne wrote: > > > > Fix the types used to store the memory parameters of an

Re: [Xen-devel] [PATCH] x86/ept: defer enabling of EPT A/D bit until PML get enabled.

2015-10-16 Thread Kai Huang
On 10/16/2015 04:17 PM, Jan Beulich wrote: On 16.10.15 at 04:21, wrote: Existing PML implementation turns on EPT A/D bit unconditionally if PML is supported by hardware. This works but enabling of EPT A/D bit can be deferred until PML get enabled. There's no point

Re: [Xen-devel] [PATCH] x86/ept: defer enabling of EPT A/D bit until PML get enabled.

2015-10-16 Thread Jan Beulich
>>> On 16.10.15 at 11:17, wrote: > On 10/16/2015 04:17 PM, Jan Beulich wrote: > On 16.10.15 at 04:21, wrote: >>> +void vmx_domain_update_eptp(struct domain *d) >>> +{ >>> +struct p2m_domain *p2m = p2m_get_hostp2m(d); >>> +struct

[Xen-devel] [linux-4.1 test] 62987: regressions - FAIL

2015-10-16 Thread osstest service owner
flight 62987 linux-4.1 real [real] http://logs.test-lab.xenproject.org/osstest/logs/62987/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 15 guest-localmigrate.2 fail in 62951 REGR. vs.

Re: [Xen-devel] [PATCH for staging] fix compile error

2015-10-16 Thread Wei Liu
On Fri, Oct 16, 2015 at 06:03:36PM +0800, He Chen wrote: > In non-debug build ASSERT_UNREACHABLE is nop and some compilers will > complain that cbm_code/cbm_data may be used uninitialized in function > psr_set_l3_cbm. Add return after ASSERT_UNREACHABLE to fix it. > > Signed-off-by: He Chen

[Xen-devel] [PATCH v2 for staging] fix compile error

2015-10-16 Thread He Chen
In non-debug build ASSERT_UNREACHABLE is nop and some compilers will complain that cbm_code/cbm_data may be used uninitialized in function psr_set_l3_cbm. Add return after ASSERT_UNREACHABLE to fix it. Signed-off-by: He Chen --- Changes in v2: Sorry for mistake in first

Re: [Xen-devel] [PATCH v2] libxc: fix the types used in xc_dom_image to build HVM guests

2015-10-16 Thread Roger Pau Monné
El 16/10/15 a les 11.00, Wei Liu ha escrit: > On Fri, Oct 16, 2015 at 09:57:02AM +0100, Ian Campbell wrote: >> On Thu, 2015-10-15 at 19:23 +0200, Roger Pau Monne wrote: >>> Fix the types used to store the memory parameters of an HVM guest, >>> previously they defaulted to unsigned long on 32bit

Re: [Xen-devel] [RFC] Results of Phase 1 of the Review Process study

2015-10-16 Thread Lars Kurth
> On 16 Oct 2015, at 10:19, Ian Campbell wrote: > >> * To consider that when there is no activity for a certain period, the >> review is no longer going to progress, and can be considered abandoned. >> The main trouble with this could be that we have seen some patch

Re: [Xen-devel] [RFC] Results of Phase 1 of the Review Process study

2015-10-16 Thread Ian Campbell
On Fri, 2015-10-16 at 10:29 +0100, Lars Kurth wrote: > > On 16 Oct 2015, at 10:19, Ian Campbell wrote: > > > > > * To consider that when there is no activity for a certain period, > > > the > > > review is no longer going to progress, and can be considered > > >

[Xen-devel] [PATCH for staging] fix compile error

2015-10-16 Thread He Chen
In non-debug build ASSERT_UNREACHABLE is nop and some compilers will complain that cbm_code/cbm_data may be used uninitialized in function psr_set_l3_cbm. Add return after ASSERT_UNREACHABLE to fix it. Signed-off-by: He Chen --- xen/arch/x86/psr.c | 1 + 1 file changed,

Re: [Xen-devel] [PATCH v2 for staging] fix compile error

2015-10-16 Thread Julien Grall
Hi, "fix compiler error" is too vast. The commit title should be more meaningful. Something like: "x86: psr: fix compilation on non-debug build after 44f126d" On 16/10/15 11:16, He Chen wrote: > In non-debug build ASSERT_UNREACHABLE is nop and some compilers will > complain that

Re: [Xen-devel] [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-16 Thread Stefano Stabellini
On Fri, 16 Oct 2015, Fabio Fantoni wrote: > Il 16/10/2015 12:13, Anthony PERARD ha scritto: > > On Fri, Oct 16, 2015 at 10:32:44AM +0200, Fabio Fantoni wrote: > > > Il 15/10/2015 20:02, Anthony PERARD ha scritto: > > > > On Thu, Oct 15, 2015 at 06:27:17PM +0200, Fabio Fantoni wrote: > > > > > Il

Re: [Xen-devel] [PATCH] x86/ept: defer enabling of EPT A/D bit until PML get enabled.

2015-10-16 Thread Andrew Cooper
On 16/10/15 10:27, Jan Beulich wrote: On 16.10.15 at 11:17, wrote: >> On 10/16/2015 04:17 PM, Jan Beulich wrote: >> On 16.10.15 at 04:21, wrote: +void vmx_domain_update_eptp(struct domain *d) +{ +struct p2m_domain

Re: [Xen-devel] [PATCH v2] libxc: fix the types used in xc_dom_image to build HVM guests

2015-10-16 Thread Ian Campbell
On Fri, 2015-10-16 at 09:50 +0100, Wei Liu wrote: > On Fri, Oct 16, 2015 at 09:48:34AM +0100, Ian Campbell wrote: > > On Thu, 2015-10-15 at 19:23 +0200, Roger Pau Monne wrote: > > > Fix the types used to store the memory parameters of an HVM guest, > > > previously they defaulted to unsigned long

Re: [Xen-devel] Survey Results - Part 1 : Improving Xen Project Governance and Conventions

2015-10-16 Thread Lars Kurth
> On 6 Oct 2015, at 10:19, George Dunlap wrote: > > On Mon, Oct 5, 2015 at 11:31 PM, Lars Kurth wrote: >> >>> On 5 Oct 2015, at 15:32, Jan Beulich wrote: >>> ! We do appear to have some issues in this area, which will need

Re: [Xen-devel] [PATCH v2] libxc: fix the types used in xc_dom_image to build HVM guests

2015-10-16 Thread Wei Liu
On Fri, Oct 16, 2015 at 09:57:02AM +0100, Ian Campbell wrote: > On Thu, 2015-10-15 at 19:23 +0200, Roger Pau Monne wrote: > > Fix the types used to store the memory parameters of an HVM guest, > > previously they defaulted to unsigned long on 32bit toolstack builds, which > > is wrong because a

Re: [Xen-devel] [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-16 Thread Stefano Stabellini
On Thu, 15 Oct 2015, Kevin O'Connor wrote: > On Fri, Oct 16, 2015 at 01:10:54AM +0200, Laszlo Ersek wrote: > > On 10/14/15 13:27, Ian Campbell wrote: > > > On Wed, 2015-10-14 at 12:06 +0100, Stefano Stabellini wrote: > > >>> Can't you just teach SeaBIOS how to deal with your PV disks and then > >

Re: [Xen-devel] [PATCH] xen-netback: correctly check failed allocation

2015-10-16 Thread Wei Liu
On Fri, Oct 16, 2015 at 10:05:21AM +0100, Wei Liu wrote: > On Thu, Oct 15, 2015 at 02:02:47PM -0400, Insu Yun wrote: > > I changed patch with valid format. > > > > On Thu, Oct 15, 2015 at 2:02 PM, Insu Yun wrote: > > > > > Since vzalloc can be failed in memory pressure, > > >

Re: [Xen-devel] [PATCH for staging] fix compile error

2015-10-16 Thread Olaf Hering
Am 16.10.2015 um 12:15 schrieb Wei Liu: > On Fri, Oct 16, 2015 at 06:03:36PM +0800, He Chen wrote: >> In non-debug build ASSERT_UNREACHABLE is nop and some compilers will Should be "all compilers" ;-) Olaf ___ Xen-devel mailing list

Re: [Xen-devel] [PATCH 1/1] xen-netfront: update num_queues to real created

2015-10-16 Thread Wei Liu
CC David and Boris (Konrad was already a recipient). On Thu, Oct 15, 2015 at 10:34:15AM +0800, Joe Jin wrote: > Sometimes xennet_create_queues() may failed to created all requested > queues, we need to update num_queues to real created to avoid NULL > pointer dereference. > > Signed-off-by: Joe

Re: [Xen-devel] [PATCH] xen-netback: correctly check failed allocation

2015-10-16 Thread David Vrabel
On 16/10/15 10:05, Wei Liu wrote: > On Thu, Oct 15, 2015 at 02:02:47PM -0400, Insu Yun wrote: >> I changed patch with valid format. >> >> On Thu, Oct 15, 2015 at 2:02 PM, Insu Yun wrote: >> >>> Since vzalloc can be failed in memory pressure, >>> writes -ENOMEM to xenstore to

Re: [Xen-devel] [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-16 Thread Fabio Fantoni
Il 16/10/2015 12:13, Anthony PERARD ha scritto: On Fri, Oct 16, 2015 at 10:32:44AM +0200, Fabio Fantoni wrote: Il 15/10/2015 20:02, Anthony PERARD ha scritto: On Thu, Oct 15, 2015 at 06:27:17PM +0200, Fabio Fantoni wrote: Il 14/10/2015 13:06, Stefano Stabellini ha scritto: I would suggest

Re: [Xen-devel] Survey Results - Part 1 : Improving Xen Project Governance and Conventions

2015-10-16 Thread Lars Kurth
> On 6 Oct 2015, at 11:26, Ian Campbell wrote: > > On Mon, 2015-10-05 at 08:32 -0600, Jan Beulich wrote: > >> By formalizing nested maintainership and requiring ack-s from >> each one in the hierarchy we will just further slow down things. >> If a maintainer doesn't

Re: [Xen-devel] [RFC] Results of Phase 1 of the Review Process study

2015-10-16 Thread Stefano Stabellini
On Wed, 14 Oct 2015, Lars Kurth wrote: > Hi everyone, > > I wanted to walk you through some of the results of the Review Process study > https://github.com/dicortazar/ipython-notebooks/blob/master/projects/xen-analysis/Code-Review-Metrics.ipynb > > I noticed that the "time to ack" doesn't

Re: [Xen-devel] [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-16 Thread Fabio Fantoni
Il 16/10/2015 12:47, Stefano Stabellini ha scritto: On Fri, 16 Oct 2015, Fabio Fantoni wrote: Il 16/10/2015 12:13, Anthony PERARD ha scritto: On Fri, Oct 16, 2015 at 10:32:44AM +0200, Fabio Fantoni wrote: Il 15/10/2015 20:02, Anthony PERARD ha scritto: On Thu, Oct 15, 2015 at 06:27:17PM

Re: [Xen-devel] [PATCH XEN] Config: Switch to unified qemu trees.

2015-10-16 Thread Ian Jackson
Ian Campbell writes ("Re: [PATCH XEN] Config: Switch to unified qemu trees."): > >From dff5c395c1d23c21238ce17ddcd6f7abe2efd08d Mon Sep 17 00:00:00 2001 > From: Ian Campbell > Date: Thu, 10 Sep 2015 14:31:34 +0100 > Subject: [PATCH] Config: Switch to unified qemu trees. >

Re: [Xen-devel] [PATCH] tools: libxl: CODING_STYLE: GC* cannot be used with NOGC

2015-10-16 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH] tools: libxl: CODING_STYLE: GC* cannot be used with NOGC"): > On Fri, Oct 16, 2015 at 12:14:05PM +0100, Ian Campbell wrote: > > On Fri, 2015-10-16 at 11:39 +0100, Wei Liu wrote: > > > There is no libxl__alloc. DYM libxl__malloc? > > > > I meant libxl__calloc. Right,

Re: [Xen-devel] [PATCH 0/4] Updates to public/io/netif.h

2015-10-16 Thread Paul Durrant
> -Original Message- > From: Paul Durrant [mailto:paul.durr...@citrix.com] > Sent: 16 October 2015 13:36 > To: xen-de...@lists.xenproject.org > Cc: Paul Durrant > Subject: [PATCH 0/4] Updates to public/io/netif.h > Apologies. I forgot to cc the maintainer list on the individual patches.

[Xen-devel] [PATCH 0/4] Updates to public/io/netif.h

2015-10-16 Thread Paul Durrant
This series makes several modifications to netif.h in anticipation of implementing NDIS RSS support in the Windows frontend driver. Patch #1 documents the (sad) reality of the netif_rx_request/response id field, which has been long overdue. Patch #2 adds a definition of the NETRXF_gso_prefix

[Xen-devel] [PATCH v2 4/4] public/io/netif.h: add extra info slots for passing hash values

2015-10-16 Thread Paul Durrant
To properly support NDIS RSS, the Windows frontend PV driver needs the Toeplitz hash value calculated by the backend (otherwise it would have to duplicate the calculation). This patch adds documentation for "feature-hash" and a definition of a new XEN_NETIF_EXTRA_TYPE_HASH extra info segment.

[Xen-devel] [PATCH v2 1/4] public/io/netif.h: document the reality of netif_rx_request/reponse id

2015-10-16 Thread Paul Durrant
The id field of the netif_rx_request_t abd netif_rx_response_t structures is actually useless. Because GSO metadata is passed from backend to frontend using netif_extra_info segments, which do not carry information stating which netif_rx_request_t was consumed to free up their slot, frontends

[Xen-devel] [PATCH v2 2/4] public/io/netif.h: add definition of gso_prefix flag

2015-10-16 Thread Paul Durrant
This flag is defined here only for compatibility with the Linux variant of this header. The feature has never been documented and should be considered deprecated. Signed-off-by: Paul Durrant Cc: Ian Campbell Cc: Ian Jackson

[Xen-devel] [PATCH v3] raisin: enable ovmf build for arm64

2015-10-16 Thread Stefano Stabellini
nasm is not a dependency on arm64. print out a message that on x86_32 we are building ovmf x86_64. --- Changes in v3: - allow x86_64 build on x86_32 - print out a message that on x86_32 we are building ovmf x86_64 - add a comment on the usage of large model on arm64 Changes in v2: - disable

Re: [Xen-devel] Regression: qemu crash of hvm domUs with spice (backtrace included) - patch backport propose

2015-10-16 Thread Fabio Fantoni
Il 09/10/2015 09:56, Fabio Fantoni ha scritto: Il 08/10/2015 17:58, Andreas Kinzler ha scritto: Is this still current? I made an interesting observation: I had no problems with SPICE and vanilla Xen 4.5.1 when using it on Gentoo with glibc 2.19/gcc 4.6.4. Segfaults started when I switched to

Re: [Xen-devel] [PATCH 1/1] xen-netfront: update num_queues to real created

2015-10-16 Thread Boris Ostrovsky
On 10/16/2015 06:56 AM, Wei Liu wrote: CC David and Boris (Konrad was already a recipient). On Thu, Oct 15, 2015 at 10:34:15AM +0800, Joe Jin wrote: Sometimes xennet_create_queues() may failed to created all requested queues, we need to update num_queues to real created to avoid NULL pointer

[Xen-devel] [PATCH 2/4] public/io/netif.h: add definition of gso_prefix flag

2015-10-16 Thread Paul Durrant
This flag is defined here only for compatibility with the Linux variant of this header. The feature has never been documented and should be considered deprecated. Signed-off-by: Paul Durrant --- xen/include/public/io/netif.h | 4 1 file changed, 4 insertions(+)

[Xen-devel] [PATCH 4/4] public/io/netif.h: add extra info slots for passing hash values

2015-10-16 Thread Paul Durrant
To properly support NDIS RSS, the Windows frontend PV driver needs the Toeplitz hash value calculated by the backend (otherwise it would have to duplicate the calculation). This patch adds documentation for "feature-hash" and a definition of a new XEN_NETIF_EXTRA_TYPE_HASH extra info segment.

[Xen-devel] [PATCH 3/4] public/io/netif.h: add documentation for hash negotiation and mapping

2015-10-16 Thread Paul Durrant
This patch specifies the xenstore keys that should be used by frontends and backends to negotiate a particular hash algorithm and queue mapping to be used for mult-queue packet steering on the guest receive side. Signed-off-by: Paul Durrant ---

[Xen-devel] [PATCH 1/4] public/io/netif.h: document the reality of netif_rx_request/reponse id

2015-10-16 Thread Paul Durrant
The id field of the netif_rx_request_t abd netif_rx_response_t structures is actually useless. Because GSO metadata is passed from backend to frontend using netif_extra_info segments, which do not carry information stating which netif_rx_request_t was consumed to free up their slot, frontends

Re: [Xen-devel] Survey Results - Part 1 : Improving Xen Project Governance and Conventions

2015-10-16 Thread Ian Campbell
On Fri, 2015-10-16 at 11:33 +0100, Lars Kurth wrote: > > On 6 Oct 2015, at 10:29, Ian Campbell wrote: > > > > On Mon, 2015-10-05 at 23:31 +0100, Lars Kurth wrote: > > > I am not sure whether the hierarchy would require everyone to ACK. As > > > far > > > as I understand

Re: [Xen-devel] [PATCH v2] raisin: enable ovmf build for arm64

2015-10-16 Thread Stefano Stabellini
On Wed, 14 Oct 2015, Ian Campbell wrote: > On Wed, 2015-10-14 at 16:57 +0100, Stefano Stabellini wrote: > > Disable ovmf build on x86_32: it does not work, the code was already > > forcing a x86_64 build. > > FYI osstest builds OVMF (64-bit) in its build-i386 jobs just fine. e.g. in > [0]. That's

Re: [Xen-devel] [PATCH] tools: libxl: CODING_STYLE: GC* cannot be used with NOGC

2015-10-16 Thread Ian Campbell
On Fri, 2015-10-16 at 11:39 +0100, Wei Liu wrote: > On Fri, Oct 16, 2015 at 11:33:12AM +0100, Ian Campbell wrote: > > GC* assume an existing gc in scope, which means they can't be passed > > NOGC. Instead recommend the use of the underlying functions with NOGC, > > noting that this is excepitonal.

Re: [Xen-devel] [PATCH] xen-netback: correctly check failed allocation

2015-10-16 Thread Insu Yun
For me, it seems more consistent using xen_bus_dev_fatal(); return; Because other codes also use them. If you want to use goto, then feel free to make a patch for this issue. On Fri, Oct 16, 2015 at 5:40 AM, David Vrabel wrote: > On 16/10/15 10:05, Wei Liu wrote: > >

Re: [Xen-devel] [PATCH] tools: libxl: CODING_STYLE: GC* cannot be used with NOGC

2015-10-16 Thread Wei Liu
On Fri, Oct 16, 2015 at 12:14:05PM +0100, Ian Campbell wrote: > On Fri, 2015-10-16 at 11:39 +0100, Wei Liu wrote: > > On Fri, Oct 16, 2015 at 11:33:12AM +0100, Ian Campbell wrote: > > > GC* assume an existing gc in scope, which means they can't be passed > > > NOGC. Instead recommend the use of

[Xen-devel] [xen-unstable-smoke test] 63001: trouble: broken/pass

2015-10-16 Thread osstest service owner
flight 63001 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/63001/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-debianhvm-i386 3 host-install(3) broken REGR.

[Xen-devel] [PATCH v2 3/4] public/io/netif.h: add documentation for hash negotiation and mapping

2015-10-16 Thread Paul Durrant
This patch specifies the xenstore keys that should be used by frontends and backends to negotiate a particular hash algorithm and queue mapping to be used for mult-queue packet steering on the guest receive side. Signed-off-by: Paul Durrant Cc: Ian Campbell

[Xen-devel] [PATCH v2 0/4] Updates to public/io/netif.h

2015-10-16 Thread Paul Durrant
This series makes several modifications to netif.h in anticipation of implementing NDIS RSS support in the Windows frontend driver. Patch #1 documents the (sad) reality of the netif_rx_request/response id field, which has been long overdue. Patch #2 adds a definition of the NETRXF_gso_prefix

Re: [Xen-devel] [PATCH 1/5] raisin: Handle aliases for packages, add pciutils-dev / libpci-dev alias

2015-10-16 Thread Stefano Stabellini
On Wed, 14 Oct 2015, George Dunlap wrote: > It's not uncommon for packages to be renamed, and for package managers > to know the translation from old packages to new packages. For > example: > > # apt-get install pciutils-dev > Reading package lists... Done > Building dependency tree > Reading

Re: [Xen-devel] [PATCH 2/5] raisin: Detect systemd

2015-10-16 Thread Ian Campbell
On Fri, 2015-10-16 at 14:39 +0100, Stefano Stabellini wrote: > On Wed, 14 Oct 2015, George Dunlap wrote: > > Add systemd development libraries if we detect systemd present on the > > system > > > > Signed-off-by: George Dunlap > > Please use spaces for indentation > >

Re: [Xen-devel] [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-16 Thread Kevin O'Connor
On Fri, Oct 16, 2015 at 10:06:48AM +0100, Stefano Stabellini wrote: > On Thu, 15 Oct 2015, Kevin O'Connor wrote: > > What's the reason for the "stumbling block" that requires the BIOS to > > tear down the Xen ring prior to the OS being able to replace it? The > > BIOS disk calls are all

[Xen-devel] [xen-unstable test] 62990: regressions - FAIL

2015-10-16 Thread osstest service owner
flight 62990 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/62990/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-debianhvm-amd64-xsm 9 debian-hvm-install fail REGR. vs. 62711

[Xen-devel] [ovmf test] 62997: regressions - FAIL

2015-10-16 Thread osstest service owner
flight 62997 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/62997/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 9 debian-hvm-install fail REGR. vs. 62978

Re: [Xen-devel] [PATCH 3/5] raisin: Allow iasl to alias acpica-tools, unify Fedora and CentOS deps for xen

2015-10-16 Thread Stefano Stabellini
On Wed, 14 Oct 2015, George Dunlap wrote: > CentOS 7 now aliases acpica-tools instead of iasl, making its deps > essentially the same as Fedora. Add iasl|acpica-tools as an alias in > the Fedora deps, and make the CentOS deps a straight clone of the > Fedora deps (as they are for the other

Re: [Xen-devel] [PATCH 2/5] raisin: Detect systemd

2015-10-16 Thread Stefano Stabellini
On Wed, 14 Oct 2015, George Dunlap wrote: > On 14/10/15 17:21, George Dunlap wrote: > > Add systemd development libraries if we detect systemd present on the system > > > > Signed-off-by: George Dunlap > > Sorry, meant to add a comment here... > > > --- > >

Re: [Xen-devel] [PATCH 5/5] raisin: Add XEN_CONFIG_EXTRA to config file

2015-10-16 Thread Stefano Stabellini
On Wed, 14 Oct 2015, George Dunlap wrote: > Allowing the user to enable or disable specific functionality, such as > stubdoms. > > Signed-off-by: George Dunlap I don't like this very much: if we want to disable stubdoms by default with all configs, then I would

Re: [Xen-devel] Regression: qemu crash of hvm domUs with spice (backtrace included) - patch backport propose

2015-10-16 Thread Stefano Stabellini
On Fri, 16 Oct 2015, Fabio Fantoni wrote: > Il 09/10/2015 09:56, Fabio Fantoni ha scritto: > > Il 08/10/2015 17:58, Andreas Kinzler ha scritto: > > > Is this still current? I made an interesting observation: > > > > > > I had no problems with SPICE and vanilla Xen 4.5.1 when using it on Gentoo >

Re: [Xen-devel] [PATCH 2/5] raisin: Detect systemd

2015-10-16 Thread Stefano Stabellini
On Wed, 14 Oct 2015, George Dunlap wrote: > Add systemd development libraries if we detect systemd present on the system > > Signed-off-by: George Dunlap Please use spaces for indentation > components/xen | 10 ++ > 1 file changed, 10 insertions(+) > >

Re: [Xen-devel] [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-16 Thread Kevin Wolf
Am 14.10.2015 um 14:48 hat Paul Durrant geschrieben: > > -Original Message- > > From: Fabio Fantoni [mailto:fabio.fant...@m2r.biz] > > Sent: 14 October 2015 12:12 > > To: Kevin Wolf; Stefano Stabellini > > Cc: John Snow; Anthony Perard; qemu-de...@nongnu.org; xen- > > de...@lists.xen.org;

Re: [Xen-devel] [PATCH 2/5] raisin: Detect systemd

2015-10-16 Thread Stefano Stabellini
On Fri, 16 Oct 2015, Ian Campbell wrote: > On Fri, 2015-10-16 at 14:39 +0100, Stefano Stabellini wrote: > > On Wed, 14 Oct 2015, George Dunlap wrote: > > > Add systemd development libraries if we detect systemd present on the > > > system > > > > > > Signed-off-by: George Dunlap

Re: [Xen-devel] [PATCH 4/5] raisin: Change update/release parsing OSes

2015-10-16 Thread Stefano Stabellini
On Wed, 14 Oct 2015, George Dunlap wrote: > At the moment, something like 7.1.1503 will be parsed as RELEASE=7.1 > UPDATE=1503. Change the bash string so that RELEASE=7 UPDATE=1.1503 > in this case. > > Also add an example CentOS 7 release string, and add the RELEASE / > UPDATE parsing to

[Xen-devel] [OSSTEST PATCH] crontab: Run smoke tests every 1h if one not already running

2015-10-16 Thread Ian Jackson
And move the attempt to the top of the hour. 62985 took ~1h40 so we would normally run one every couple of hours. We have a reasonable amount of capacity right now. Signed-off-by: Ian Jackson --- crontab |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [Xen-devel] [PATCH] libxl: No emulated disk driver for xvdX disk

2015-10-16 Thread Ian Jackson
Anthony PERARD writes ("[PATCH] libxl: No emulated disk driver for xvdX disk"): > When a guest configuration list xvdX for its disks, there is no need to > provide an emulated driver for the same target. > > Such configuration can work with the OVMF firmware, as it supports PV > disk. Acked-by:

Re: [Xen-devel] [OSSTEST PATCH] crontab: Run smoke tests every 1h if one not already running

2015-10-16 Thread Ian Campbell
On Fri, 2015-10-16 at 14:52 +0100, Ian Jackson wrote: > And move the attempt to the top of the hour. > > 62985 took ~1h40 so we would normally run one every couple of hours. > We have a reasonable amount of capacity right now. > > Signed-off-by: Ian Jackson Acked-by:

Re: [Xen-devel] [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-16 Thread Paul Durrant
> -Original Message- > From: Kevin Wolf [mailto:kw...@redhat.com] > Sent: 16 October 2015 16:02 > To: Paul Durrant > Cc: Fabio Fantoni; Stefano Stabellini; John Snow; Anthony Perard; qemu- > de...@nongnu.org; xen-devel@lists.xen.org; qemu-bl...@nongnu.org > Subject: Re: [Qemu-devel]

[Xen-devel] [PATCH v3 1/4] public/io/netif.h: document the reality of netif_rx_request/reponse id

2015-10-16 Thread Paul Durrant
The id field of the netif_rx_request_t abd netif_rx_response_t structures is actually useless. Because GSO metadata is passed from backend to frontend using netif_extra_info segments, which do not carry information stating which netif_rx_request_t was consumed to free up their slot, frontends

[Xen-devel] [PATCH v3 4/4] public/io/netif.h: add extra info slots for passing hash values

2015-10-16 Thread Paul Durrant
To properly support NDIS RSS, the Windows frontend PV driver needs the Toeplitz hash value calculated by the backend (otherwise it would have to duplicate the calculation). This patch adds documentation for "feature-hash" and a definition of a new XEN_NETIF_EXTRA_TYPE_HASH extra info segment.

[Xen-devel] [PATCH v3 0/4] Updates to public/io/netif.h

2015-10-16 Thread Paul Durrant
This series makes several modifications to netif.h in anticipation of implementing NDIS RSS support in the Windows frontend driver. Patch #1 documents the (sad) reality of the netif_rx_request/response id field, which has been long overdue. Patch #2 adds a definition of the NETRXF_gso_prefix

[Xen-devel] [PATCH v3 3/4] public/io/netif.h: add documentation for hash negotiation and mapping

2015-10-16 Thread Paul Durrant
This patch specifies the xenstore keys that should be used by frontends and backends to negotiate a particular hash algorithm and queue mapping to be used for mult-queue packet steering on the guest receive side. Signed-off-by: Paul Durrant Cc: Ian Campbell

  1   2   >