Re: [Xen-devel] [PATCH] x86/emulate: Check current->arch.vm_event in hvmemul_virtual_to_linear()

On 04/08/16 00:17, Jan Beulich wrote: On 07.04.16 at 19:54, wrote: >> On 04/07/16 20:27, Jan Beulich wrote: >> On 07.04.16 at 10:39, wrote: Theoretically it is possible for mem_access_emulate_each_rep to be true even when

Re: [Xen-devel] [PATCH v4 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk

On 08/04/16 02:32, Luis R. Rodriguez wrote: > On Thu, Apr 07, 2016 at 08:55:54AM -0400, Boris Ostrovsky wrote: >> On 04/06/2016 08:06 PM, Luis R. Rodriguez wrote: >>> We have 4 types of x86 platforms that disable RTC: >>> >>> * Intel MID >>> * Lguest - uses paravirt >>> * Xen dom-U - uses

Re: [Xen-devel] [RFC Design Doc] Add vNVDIMM support for Xen

On 03/29/16 04:49, Jan Beulich wrote: > >>> On 29.03.16 at 12:10, wrote: > > On 03/29/16 03:11, Jan Beulich wrote: > >> >>> On 29.03.16 at 10:47, wrote: [..] > >> > I still cannot find a neat approach to manage guest permissions for > >> >

[Xen-devel] [linux-mingo-tip-master test] 89303: regressions - FAIL

flight 89303 linux-mingo-tip-master real [real] http://logs.test-lab.xenproject.org/osstest/logs/89303/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-xsm 15 guest-localmigratefail REGR. vs. 60684

Re: [Xen-devel] [PATCH v3 08/11] xen: sched: allow for choosing credit2 runqueues configuration at boot

On 08/04/16 03:24, Dario Faggioli wrote: > In fact, credit2 uses CPU topology to decide how to arrange > its internal runqueues. Before this change, only 'one runqueue > per socket' was allowed. However, experiments have shown that, > for instance, having one runqueue per physical core improves >

Re: [Xen-devel] [PATCH] bind_usbintf: do not reuse 'path'

>>> On 4/8/2016 at 12:52 AM, in message <22278.36941.470901.631...@mariner.uk.xensource.com>, Ian Jackson wrote: > Chunyan Liu writes ("[PATCH] bind_usbintf: do not reuse 'path'"): > > To avoid confusion, add a new variable "intf_path" to indicate > >

[Xen-devel] [PATCH V2] bind_usbintf: do not reuse 'path'

To avoid confusion, use "intf_path" to indicate driver/interface path, and "bind_path" indicate driver/bind path. Signed-off-by: Chunyan Liu CC: Simon Cao CC: George Dunlap CC: Ian Jackson ---

Re: [Xen-devel] [RFC PATCH] Data integrity extension support for xen-block

On 08/04/16 03:24, Bob Liu wrote: > > On 04/07/2016 11:55 PM, Juergen Gross wrote: >> On 07/04/16 12:00, Bob Liu wrote: >>> * What's data integrity extension and why? >>> Modern filesystems feature checksumming of data and metadata to protect >>> against >>> data corruption. However, the

Re: [Xen-devel] [PATCH 1/2] libxl: Set rc on failure of usbdev_busaddr_to_busid

>>> On 4/8/2016 at 01:04 AM, in message <22278.37677.975595.101...@mariner.uk.xensource.com>, Ian Jackson wrote: > Chun Yan Liu writes ("Re: [PATCH 1/2] libxl: Set rc on failure of > usbdev_busaddr_to_busid"): > > Thanks, Ian! > > Should I take that as a

Re: [Xen-devel] [PATCH 1/4] a fix in libxl_device_usbdev_list

>>> On 4/8/2016 at 12:45 AM, in message <22278.36492.245114.295...@mariner.uk.xensource.com>, Ian Jackson wrote: > Chunyan Liu writes ("[PATCH 1/4] a fix in libxl_device_usbdev_list"): > > In testing with libvirt pvusb functionality, found a rc check > > error in

[Xen-devel] [PATCH v3 6/6] xl: improve exit codes of domain creation related functions

by making them more consistent with other examples in xl. Signed-off-by: Dario Faggioli Signed-off-by: Harmandeep Kaur --- Cc: Ian Jackson Cc: Wei Liu --- v3: In create_domain(), only deal

[Xen-devel] [PATCH v3 4/6] xl : improve exit codes of debug related functions

From: Harmandeep Kaur by making them more consistent with other examples in xl. Signed-off-by: Harmandeep Kaur Signed-off-by: Dario Faggioli --- Cc: Ian Jackson Cc: Wei Liu

[Xen-devel] [PATCH v3 2/6] xl: improve exit codes of save/restore and migration functions

From: Harmandeep Kaur by making them more consistent with other examples in xl. Macros CHK_ERRNOVAL, CHK_SYSCALL, MUST are also updated. Signed-off-by: Harmandeep Kaur Signed-off-by: Dario Faggioli --- Cc: Ian

[Xen-devel] [PATCH v3 5/6] xl: make return type of create_domain() more consistent.

create_domain() is of uint32_t return type, because on success it returns the domid of the new domain, and uint32_t is what we typically use for domid-s. However, on failure, it returns ERROR_FAIL or ERROR_INVAL, which are -3 and -6. Callers assign the return value to an 'int rc' variable and

[Xen-devel] [PATCH v3 3/6] xl: improve exit codes of some of the domain handling functions

From: Harmandeep Kaur by making them more consistent with other examples in xl. Affected functions are the ones related to console, vnc, dump, destroy, shutdown, list, domid and domname. Signed-off-by: Harmandeep Kaur Signed-off-by:

[Xen-devel] [PATCH v3 1/6] xl: improve return and exit codes of memory related functions

From: Harmandeep Kaur by making them more consistent with other examples in xl. While there, make freemem() of boolean return type, which looks more natural, and add comment explaining why parse_mem_size_kb() needs to diverge from the pattern. Signed-off-by:

[Xen-devel] [PATCH v3 0/6] xl: convert exit codes related to domain subcommands to EXIT_[SUCCESS|FAILURE]

Hi tools maintainers, So, this series from Harmandeep seems to have fallen through the cracks (and that's my fault, as I said I'd have handled it). In any case, it was posted before last posting day, it looks simple enough to me and it's a nice cleanup. This is about using EXIT_SUCCESS or

Re: [Xen-devel] [PATCH v9 2/3] VT-d: wrap a _sync version for all VT-d flush interfaces

On April 07, 2016 11:29pm, Jan Beulich wrote: > >>> On 07.04.16 at 09:44, wrote: > > On April 05, 2016 5:35pm, Jan Beulich wrote: > >> >>> On 01.04.16 at 16:47, wrote: > >> > +{ > >> > +

Re: [Xen-devel] [PATCH v5 19/28] build_id: Provide ld-embedded build-ids

On Thu, Apr 07, 2016 at 08:18:27PM -0400, Konrad Rzeszutek Wilk wrote: > > > +build_id.o: $(TARGET)-syms > > > + $(OBJCOPY) -O binary --only-section=.note $(BASEDIR)/xen-syms $@.bin > > > > Considering your xen.lds.S changes, won't this potentially copy quite > > a bit more than just the build ID

Re: [Xen-devel] Bug in x86 instruction emulator?

On 2016-04-07 04:04, Jan Beulich wrote: We'd need to know which exact exception (including error code and, in the case of #PF, CR2 value) gets raised to the guest by what specific piece of code in the hypervisor. That'll likely mean some instrumentation of the hypervisor code. Jan No problem

Re: [Xen-devel] [PATCH v5 13/28] xsplice, symbols: Implement symbol name resolution on address.

On Thu, Apr 07, 2016 at 09:46:49AM -0600, Jan Beulich wrote: > >>> On 07.04.16 at 05:14, wrote: > > On Fri, Apr 01, 2016 at 09:11:40AM -0600, Jan Beulich wrote: > >> >>> On 24.03.16 at 21:00, wrote: > >> > --- a/xen/arch/x86/Makefile > >> > +++

[Xen-devel] [PATCH v3 10/11] xen: sched: privde some scratch space for not putting cpumasks on stack

directly, from schedule.c, for any scheduler that needs it to use it. In fact, Credit1 and RTDS needs this already. Credit2 is also going to need it, for supporting hard affinity (which is, typically, what requires a lot of cpumask manipulations, inside various functions). Therefore, let's

[Xen-devel] [PATCH v3 11/11] xen: sched: implement vcpu hard affinity in Credit2

From: Justin Weaver as it was still missing. Note that this patch "only" implements hard affinity, i.e., the possibility of specifying on what pCPUs a certain vCPU can run. Soft affinity (which express a preference for vCPUs to run on certain pCPUs) is still not supported

[Xen-devel] [PATCH v3 08/11] xen: sched: allow for choosing credit2 runqueues configuration at boot

In fact, credit2 uses CPU topology to decide how to arrange its internal runqueues. Before this change, only 'one runqueue per socket' was allowed. However, experiments have shown that, for instance, having one runqueue per physical core improves performance, especially in case hyperthreading is

[Xen-devel] [PATCH v3 09/11] xen: sched: per-core runqueues as default in credit2

Experiments have shown that arranging the scheduing runqueues on a per-core basis yields better results, in most cases. Such evaluation has been done, for the first time, by Uma Sharma, during her participation to OPW. Some of the results she got are summarized here:

[Xen-devel] [PATCH v3 05/11] xen: sched: improve credit2 bootparams' scope, placement and signedness

From: Uma Sharma and, while we are adjusting signedness of opt_load_window_shift, make also prv->load_window_shift unsigned, as approapriate. Signed-off-by: Uma Sharma Signed-off-by: Dario Faggioli Reviewed-by:

[Xen-devel] [PATCH v3 04/11] xen: sched: close potential races when switching scheduler to CPUs

In short, the point is making sure that the actual switch of scheduler and the remapping of the scheduler's runqueue lock occur in the same critical section, protected by the "old" scheduler's lock (and not, e.g., in the free_pdata hook, as it is now for Credit2 and RTDS). Not doing so, is (at

[Xen-devel] [PATCH v3 03/11] xen: sched: move pCPU initialization in an helper

That will turn out useful in following patches, where such code will need to be called more than just once. Create an helper now, and move the code there, to avoid mixing code motion and functional changes later. In Credit2, some style cleanup is also done. No functional change intended.

[Xen-devel] [PATCH v3 01/11] xen: sched: make implementing .alloc_pdata optional

The .alloc_pdata scheduler hook must, before this change, be implemented by all schedulers --even those ones that don't need to allocate anything. Make it possible to just use the SCHED_OP(), like for the other hooks, by using ERR_PTR() and IS_ERR() for error reporting. This: - makes NULL a

Re: [Xen-devel] [RFC PATCH] Data integrity extension support for xen-block

On 04/07/2016 11:55 PM, Juergen Gross wrote: > On 07/04/16 12:00, Bob Liu wrote: >> * What's data integrity extension and why? >> Modern filesystems feature checksumming of data and metadata to protect >> against >> data corruption. However, the detection of the corruption is done at read >>

[Xen-devel] [PATCH v3 07/11] xen: sched: fix per-socket runqueue creation in credit2

The credit2 scheduler tries to setup runqueues in such a way that there is one of them per each socket. However, that does not work. The issue is described in bug #36 "credit2 only uses one runqueue instead of one runq per socket" (http://bugs.xenproject.org/xen/bug/36), and a solution has been

[Xen-devel] [PATCH v3 06/11] xen: sched: on Credit2, don't reprogram the timer if idle

as other schedulers are doing already: if the idle vcpu is picked and scheduled, there is no need to reprogram the scheduler timer to fire and invoke csched2_schedule() again in future. Tickling or external events will serve as pokes, when necessary, but until we can, we should just stay idle.

[Xen-devel] [PATCH v3 00/11] Fixes and improvement (including hard affinity!) for Credit2

And here it comes take 3. I've addressed George's review comments (and, indirectly, while doing that, Juergen's one as well). Now it's only these two patches that need being Acked: 04/11 xen: sched: close potential races when switching scheduler to CPUs 08/11 xen: sched: allow for choosing

[Xen-devel] [PATCH v3 02/11] xen: sched: implement .init_pdata in Credit, Credit2 and RTDS

In fact, if a scheduler needs per-pCPU information, that needs to be initialized appropriately. So, we take the code that is performing initializations from (right now) .alloc_pdata, and use it for .init_pdata, leaving only actualy allocations in the former, if any (which is the case in RTDS and

Re: [Xen-devel] [PATCH v4 00/14] x86: remove paravirt_enabled

On Wed, Apr 06, 2016 at 05:06:20PM -0700, Luis R. Rodriguez wrote: > Now that Andy's ASM paravirt_enabled() use is merged Sorry I should have provided more context, I meant that now that Andy's ASM paravirt_enabled() removal is merged: This is the ASM hack that Andy removed:

[Xen-devel] [xen-unstable-smoke test] 89421: tolerable FAIL - PUSHED

flight 89421 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/89421/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): build-amd64-libvirt 5 libvirt-buildfail like 89383 Tests which did not

[Xen-devel] [qemu-mainline test] 89252: regressions - FAIL

flight 89252 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/89252/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-freebsd10-i386 10 guest-start fail REGR. vs. 86454

[Xen-devel] Does __KERNEL_DS serve a purpose?

I can't see any reason that we need the __KERNEL_DS segment at all -- I think that everything that uses __KERNEL_DS could use __USER_DS instead. Am I missing anything? This has been bugging me for a while. I mulled over this a bit when trying to understand the sysret_ss_attrs bug and then

Re: [Xen-devel] [PATCH v5 19/28] build_id: Provide ld-embedded build-ids

> > +build_id.o: $(TARGET)-syms > > + $(OBJCOPY) -O binary --only-section=.note $(BASEDIR)/xen-syms $@.bin > > Considering your xen.lds.S changes, won't this potentially copy quite > a bit more than just the build ID (i.e. all notes)? This may be okay, and > may be even intended, but then the

Re: [Xen-devel] [PATCH v2 04/11] xen: sched: close potential races when switching scheduler to CPUs

On Thu, 2016-04-07 at 15:54 +0100, George Dunlap wrote: > On 06/04/16 18:23, Dario Faggioli wrote: > >  > > This patch, therefore, introduces a new hook in the scheduler > > interface, called switch_sched, meant at being used when > > switching scheduler on a CPU, and implements it for the > >

Re: [Xen-devel] [PATCH v5 03/21] xen/x86: Generate deep dependencies of features

On 08/04/2016 00:18, Jan Beulich wrote: On 07.04.16 at 13:57, wrote: >> +deps = { >> +# FPU is taken to mean support for the x87 regisers as well as the >> +# instructions. MMX is documented to alias the %MM registers over >> the >> +#

Re: [Xen-devel] [PATCH v5 03/21] xen/x86: Generate deep dependencies of features

>>> On 07.04.16 at 13:57, wrote: > +deps = { > +# FPU is taken to mean support for the x87 regisers as well as the > +# instructions. MMX is documented to alias the %MM registers over > the > +# x87 %ST registers in hardware. > +

Re: [Xen-devel] [PATCH v5 02/21] xen/x86: Calculate maximum host and guest featuresets

>>> On 07.04.16 at 13:57, wrote: > All of this information will be used by the toolstack to make informed > levelling decisions for VMs, and by Xen to sanity check toolstack-provided > information. > > The split between the shadow and hap HVM masks is necessary due to

Re: [Xen-devel] [PATCH v5 01/21] xen/x86: Annotate VM applicability in featureset

>>> On 07.04.16 at 13:57, wrote: > Use attributes to specify whether a feature is applicable to be exposed to: > 1) All guests > 2) HVM guests > 3) HVM HAP guests > and, via absence of an attribute, to no guests. > > There is no current need for other categories

Re: [Xen-devel] [PATCH for-4.7 v2 2/2] xen/x86: Introduce a new VMASSIST for architectural behaviour of iopl

>>> On 08.04.16 at 00:30, wrote: > On 07/04/2016 22:55, Jan Beulich wrote: > On 07.04.16 at 23:39, wrote: >>> @@ -1763,7 +1765,8 @@ static void load_segments(struct vcpu *n) >>> vcpu_info(n, evtchn_upcall_mask) = 1; >>>

Re: [Xen-devel] [PATCH v2 08/11] xen: sched: allow for choosing credit2 runqueues configuration at boot

On Thu, 2016-04-07 at 16:04 +0100, George Dunlap wrote: > On 07/04/16 06:04, Juergen Gross wrote: > > On 06/04/16 19:23, Dario Faggioli wrote: > > > @@ -2170,6 +2234,8 @@ csched2_init(struct scheduler *ops) > > >  printk(" load_window_shift: %d\n", opt_load_window_shift); > > >  printk("

Re: [Xen-devel] abstract model of IOMMU unmaping/mapping failures

>>> On 06.04.16 at 09:38, wrote: > On April 01, 2016 7:57pm, wrote: >> >>> On 31.03.16 at 11:06, wrote: >> > 4. __gnttab_unmap_common():rollback (no change) >> > >> > (Existing code) >> >>>... >> > if ( !kind ) >> >

Re: [Xen-devel] [PATCH v4 01/14] x86/boot: enumerate documentation for the x86 hardware_subarch

On Thu, Apr 07, 2016 at 02:25:38PM +0300, Andy Shevchenko wrote: > On Wed, 2016-04-06 at 17:06 -0700, Luis R. Rodriguez wrote: > > Although hardware_subarch has been in place since the x86 boot > > protocol 2.07 it hasn't been used much. Enumerate current possible > > values to avoid misuses and

Re: [Xen-devel] [PATCH v4 08/14] apm32: remove paravirt_enabled() use

On Thu, Apr 07, 2016 at 09:08:36AM -0400, Boris Ostrovsky wrote: > On 04/06/2016 08:06 PM, Luis R. Rodriguez wrote: > >There is already a check for apm_info.bios == 0, the > >apm_info.bios is set from the boot_params.apm_bios_info. > >Both Xen and lguest, which are also the only ones that set >

Re: [Xen-devel] [PATCH for-4.7 v2 2/2] xen/x86: Introduce a new VMASSIST for architectural behaviour of iopl

On 07/04/2016 22:55, Jan Beulich wrote: On 07.04.16 at 23:39, wrote: >> @@ -1763,7 +1765,8 @@ static void load_segments(struct vcpu *n) >> vcpu_info(n, evtchn_upcall_mask) = 1; >> >> regs->entry_vector |= TRAP_syscall; >> -

[Xen-devel] [xen-unstable test] 89249: regressions - FAIL

flight 89249 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/89249/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 5 libvirt-build fail REGR. vs. 86491 build-i386-libvirt

Re: [Xen-devel] [PATCH for-4.7 v2 2/2] xen/x86: Introduce a new VMASSIST for architectural behaviour of iopl

>>> On 07.04.16 at 23:39, wrote: > @@ -1763,7 +1765,8 @@ static void load_segments(struct vcpu *n) > vcpu_info(n, evtchn_upcall_mask) = 1; > > regs->entry_vector |= TRAP_syscall; > -regs->_eflags &= 0xFFFCBEFFUL; > +

Re: [Xen-devel] [PATCH v4 11/14] pnpbios: replace paravirt_enabled() check with legacy device check

On Thu, Apr 07, 2016 at 10:46:11AM +0100, David Vrabel wrote: > On 07/04/16 01:06, Luis R. Rodriguez wrote: > > Since we are removing paravirt_enabled() replace it with a > > logical equivalent. Even though PNPBIOS is x86 specific we > > add an arch-specific type call, which can be implemented by

[Xen-devel] [PATCH for-4.7 v2 1/2] xen/x86: Remove the use of vm86_mode()

Xen, being 64bit only, cannot run PV guests in vm86 mode. HVM guests however can be running in vm86 mode, and common codepaths need to be able to cope. The definition of vm86_mode() in x86_64/regs.h is incorrect, as the predicate is used by non-PV codepaths. One buggy use is in hvm/emulate.c.

[Xen-devel] [PATCH for-4.7 v2 2/2] xen/x86: Introduce a new VMASSIST for architectural behaviour of iopl

The existing vIOPL interface is hard to use, and need not be. Introduce a VMASSIST with which a guest can opt-in to having vIOPL behaviour consistenly with native hardware. Specifically: - virtual iopl updated from do_iret() hypercalls. - virtual iopl reported in bounce frames. - guest

Re: [Xen-devel] [PATCH v2 6/6] x86/time: implement PVCLOCK_TSC_STABLE_BIT

>>> On 07.04.16 at 23:17, wrote: >> > The main >>> difference I see between both would be the base system time: >>> read_platform_stime >>> uses stime_platform_stamp as base, and computes a difference from the >>> read_counter (i.e. rdtsc() ) with previously saved

[Xen-devel] [PATCH v4 13/14] x86/init: rename ebda code file

This makes it clearer what this is. Signed-off-by: Luis R. Rodriguez --- arch/x86/Makefile | 2 +- arch/x86/kernel/Makefile | 2 +- arch/x86/kernel/{head.c => ebda.c} | 0 3 files changed, 2 insertions(+), 2 deletions(-) rename

Re: [Xen-devel] [PATCH] x86/emulate: Check current->arch.vm_event in hvmemul_virtual_to_linear()

>>> On 07.04.16 at 19:54, wrote: > On 04/07/16 20:27, Jan Beulich wrote: > On 07.04.16 at 10:39, wrote: >>> Theoretically it is possible for mem_access_emulate_each_rep to be >>> true even when current->arch.vm_event == NULL, so add an

Re: [Xen-devel] [PATCH v2 6/6] x86/time: implement PVCLOCK_TSC_STABLE_BIT

>> The main >> difference I see between both would be the base system time: >> read_platform_stime >> uses stime_platform_stamp as base, and computes a difference from the >> read_counter (i.e. rdtsc() ) with previously saved platform-wide stamp >> (platform_timer_stamp). get_s_time uses the

Re: [Xen-devel] [PATCH v4 06/14] x86/init: use a platform legacy quirk for ebda

On Thu, Apr 07, 2016 at 10:44:50AM +0100, David Vrabel wrote: > On 07/04/16 01:06, Luis R. Rodriguez wrote: > > > > --- a/arch/x86/kernel/platform-quirks.c > > +++ b/arch/x86/kernel/platform-quirks.c > > @@ -7,8 +7,12 @@ > > void __init x86_early_init_platform_quirks(void) > > { > >

Re: [Xen-devel] [PATCH v3 01/11] x86/boot: enumerate documentation for the x86 hardware_subarch

David, please note below the highlighted code. On Wed, Feb 24, 2016 at 09:32:59AM +0100, Ingo Molnar wrote: > > * Luis R. Rodriguez wrote: > For hard coded platform quirks I'd suggest we add x86_platform.quirks flags. > For > example the F00F hack for Xen could be done via:

Re: [Xen-devel] [PATCH for-4.7] xen/build: Fix build with Clang

On 4/7/16 2:21 PM, Jan Beulich wrote: On 07.04.16 at 21:16, wrote: >> On 07/04/16 20:12, Jan Beulich wrote: >> On 07.04.16 at 20:46, wrote: --- a/xen/Rules.mk +++ b/xen/Rules.mk @@ -50,9 +50,15 @@

Re: [Xen-devel] [PATCH v6 08/24] xsplice: Add helper elf routines

On Thu, Apr 07, 2016 at 05:19:37PM +0100, Ian Jackson wrote: > Konrad Rzeszutek Wilk writes ("[PATCH v6 08/24] xsplice: Add helper elf > routines"): > > From: Ross Lagerwall > > > > Add Elf routines and data structures in preparation for loading an > > xSplice

Re: [Xen-devel] [PATCH v6 08/24] xsplice: Add helper elf routines

On 07/04/16 17:19, Ian Jackson wrote: > Konrad Rzeszutek Wilk writes ("[PATCH v6 08/24] xsplice: Add helper elf > routines"): >> From: Ross Lagerwall >> >> Add Elf routines and data structures in preparation for loading an >> xSplice payload. >> >> We make an

Re: [Xen-devel] [PATCH v6 06/24] x86: Alter nmi_callback_t typedef

On 07/04/16 04:49, Konrad Rzeszutek Wilk wrote: > Drop paranthesis and function pointer on nmi_callback_t typedef. > > Make it more inline with how x86 maintainers want function > typedefs to be. > > Signed-off-by: Konrad Rzeszutek Wilk I don't see the point, but this

Re: [Xen-devel] [PATCH v6 05/24] arm/x86: Use struct virtual_region to do bug, symbol, and (x86) exception tables lookup.

On 07/04/16 04:49, Konrad Rzeszutek Wilk wrote: > @@ -80,8 +82,12 @@ search_one_table(const struct exception_table_entry *first, > unsigned long > search_exception_table(unsigned long addr) > { > -return search_one_table( > -__start___ex_table, __stop___ex_table-1, addr); > +

Re: [Xen-devel] [PATCH v6 03/24] libxc: Implementation of XEN_XSPLICE_op in libxc

On 07/04/16 04:49, Konrad Rzeszutek Wilk wrote: > diff --git a/tools/libxc/xc_misc.c b/tools/libxc/xc_misc.c > index 124537b..e09ac90 100644 > --- a/tools/libxc/xc_misc.c > +++ b/tools/libxc/xc_misc.c > @@ -693,6 +693,343 @@ int xc_hvm_inject_trap( > return rc; > } > > +int

Re: [Xen-devel] [PATCH for-4.7] xen/build: Fix build with Clang

On 07/04/16 20:21, Jan Beulich wrote: On 07.04.16 at 21:16, wrote: >> On 07/04/16 20:12, Jan Beulich wrote: >> On 07.04.16 at 20:46, wrote: --- a/xen/Rules.mk +++ b/xen/Rules.mk @@ -50,9 +50,15 @@

Re: [Xen-devel] live migration from legacy to staging fails

On 07/04/16 16:40, Olaf Hering wrote: > convert-legacy-stream.py fails to receive a HVM domU coming from xen-4.5. > It runs into legacy.CHUNK_enable_verify_mode "Unable to convert a debug > stream", but only if the '--debug' knob was passed to 'xl migrate'. > The comment there is clearly wrong. >

Re: [Xen-devel] [PATCH for-4.7] xen/build: Fix build with Clang

>>> On 07.04.16 at 21:16, wrote: > On 07/04/16 20:12, Jan Beulich wrote: > On 07.04.16 at 20:46, wrote: >>> --- a/xen/Rules.mk >>> +++ b/xen/Rules.mk >>> @@ -50,9 +50,15 @@ ALL_OBJS-$(CONFIG_X86) += $(BASEDIR)/crypto/built_in.o >>>

[Xen-devel] [xen-unstable-smoke test] 89383: tolerable FAIL - PUSHED

flight 89383 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/89383/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): build-amd64-libvirt 5 libvirt-buildfail like 89344 Tests which did not

Re: [Xen-devel] [PATCH for-4.7] xen/build: Fix build with Clang

On 07/04/16 20:12, Jan Beulich wrote: On 07.04.16 at 20:46, wrote: >> The clang build already has many duplicate symbols for some reason I have yet >> to identify, e.g. >> >> Duplicate symbol 'asid.c#get_cpu_info' (82d0801e6840 != >> 82d0801c8190) >>

Re: [Xen-devel] [PATCH] tools: handle xl migrate --debug in legacy stream

On 07/04/16 17:31, Olaf Hering wrote: > Doing a 'xl migrate --debug domU host' on xen-4.5 adds a > XC_SAVE_ID_ENABLE_VERIFY_MODE marker, which is not handled. > Since using --debug is valid usage, handle it by logging the fact > instead of aborting the migration. > > Signed-off-by: Olaf Hering

Re: [Xen-devel] HVMLite / PVHv2 - using x86 EFI boot entry

On Wed, Apr 06, 2016 at 01:11:30PM +0200, Daniel Kiper wrote: > On Wed, Apr 06, 2016 at 04:40:27AM +0200, Luis R. Rodriguez wrote: > > Boris sent out the first HVMLite series of patches to add a new Xen guest > > type > > February 1, 2016 [0]. We've been talking off list with a few folks now over

Re: [Xen-devel] [PATCH for-4.7] xen/build: Fix build with Clang

>>> On 07.04.16 at 20:46, wrote: > The clang build already has many duplicate symbols for some reason I have yet > to identify, e.g. > > Duplicate symbol 'asid.c#get_cpu_info' (82d0801e6840 != > 82d0801c8190) > Duplicate symbol 'ats.c#__list_add'

Re: [Xen-devel] HVMLite / PVHv2 - using x86 EFI boot entry

On Wed, Apr 06, 2016 at 12:07:36PM +0100, George Dunlap wrote: > On Wed, Apr 6, 2016 at 3:40 AM, Luis R. Rodriguez wrote: > > A huge summary of the discussion over EFI boot option for HVMLite is now on > > a > > wiki [2], below I'll just provide the outline of the discussion.

Re: [Xen-devel] [for-4.7] xen/arm64: correctly emulate the {w, x}zr registers

Hi Jan, On 07/04/2016 18:18, Jan Beulich wrote: On 07.04.16 at 12:53, wrote: --- Stefano, let me know the new helper corresponds to change you requested (see [1]) This patch is a bug fix for Xen 4.7. Without it, a MMIO register and sysreg will be set to a random value

[Xen-devel] [PATCH for-4.7] xen/build: Fix build with Clang

c/s 607044bf9 "build: avoid putting local absolute symbols in symbol tables" breaks the build with Clang, as the command line argument isn't understood. Clang does not appear to have any equivielent option, and already has outstanding issues with duplicate symbols. Excluding this option makes

Re: [Xen-devel] [PATCH] x86/emulate: Check current->arch.vm_event in hvmemul_virtual_to_linear()

On 04/07/16 20:54, Razvan Cojocaru wrote: > On 04/07/16 20:27, Jan Beulich wrote: > On 07.04.16 at 10:39, wrote: >>> Theoretically it is possible for mem_access_emulate_each_rep to be >>> true even when current->arch.vm_event == NULL, so add an extra >>> check to

Re: [Xen-devel] Regarding Outreachy project on Improving CR Dashboard

On Thu, 2016-04-07 at 17:57 +0530, Priya wrote: > Hello all, > > Thanks for the suggestions. I have updated the changes as u had > mentioned. I am sorry, but I could not find any errors while running  > > $ python3 createjson.py --mbox xen-devel-2016-03 --output new.json  > > command. I am

Re: [Xen-devel] [PATCH] x86/emulate: Check current->arch.vm_event in hvmemul_virtual_to_linear()

On 04/07/16 20:27, Jan Beulich wrote: On 07.04.16 at 10:39, wrote: >> Theoretically it is possible for mem_access_emulate_each_rep to be >> true even when current->arch.vm_event == NULL, so add an extra >> check to hvmemul_virtual_to_linear(). > > Mind saying what

[Xen-devel] [PATCH 2/4] libxl: set the backend type to Qdisk for CDROM devices on DM HVM guests

This is needed because the cd-{insert/eject} functions are not prepared to deal with blkback, which would be used by default if no backend was specified. Signed-off-by: Roger Pau Monné Cc: Ian Jackson Cc: Wei Liu ---

[Xen-devel] [PATCH 0/4] libxl: fix CDROM issues

Due to recent changes (and intended fixes) CDROM has become quite unstable recently. This series aims to fix the issues reported with having empty CDROM devices in the HVM guest configuration files. It also contains some cleanups of more generic code in order to ease the implementation. After

[Xen-devel] [PATCH 4/4] libxl: remove code added to use the 'phy' backend with CDROM devices

Signed-off-by: Roger Pau Monné Cc: Ian Jackson Cc: Wei Liu --- tools/libxl/libxl_device.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/tools/libxl/libxl_device.c b/tools/libxl/libxl_device.c

[Xen-devel] [PATCH 3/4] libxl: only allow guests with a device model to use cd-{eject/insert}

Signed-off-by: Roger Pau Monné Cc: Ian Jackson Cc: Wei Liu --- tools/libxl/libxl.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c index 9d785a4..232e2c1 100644 ---

[Xen-devel] [PATCH 1/4] libxl: set the device model version earlier in xenstore

So libxl doesn't have to pass the build info around just to get the device model used by the guest. This allows to simplify libxl__device_nic_setdefault. Signed-off-by: Roger Pau Monné Cc: Ian Jackson Cc: Wei Liu ---

Re: [Xen-devel] [libvirt] [PATCH] libxl: libxl_domain_create_restore has an extra argument

On Thu, Apr 07, 2016 at 05:35:33PM +0100, Daniel P. Berrange wrote: > On Wed, Apr 06, 2016 at 04:43:07PM -0500, Doug Goldstein wrote: > > On 4/5/16 9:20 AM, Wei Liu wrote: > > > In the latest libxenlight code, libxl_domain_create_restore accepts a > > > new argument. Update libvirt's libxl driver

Re: [Xen-devel] [PATCH v2] libxl: replace the usage of uuid_t with a char array

Wei Liu writes ("Re: [PATCH v2] libxl: replace the usage of uuid_t with a char array"): > A thought: maybe it is worth to have a #define LIBXL_HAVE_UNIFIED_UUID > in libxl.h? This is a good idea. > /* If this is defined, libxl_uuid is big endian 16-octet stream on all > * platform. The

Re: [Xen-devel] [PATCH] x86/emulate: Check current->arch.vm_event in hvmemul_virtual_to_linear()

>>> On 07.04.16 at 10:39, wrote: > Theoretically it is possible for mem_access_emulate_each_rep to be > true even when current->arch.vm_event == NULL, so add an extra > check to hvmemul_virtual_to_linear(). Mind saying what those theoretical conditions are when this

Re: [Xen-devel] [PATCH v6 08/24] xsplice: Add helper elf routines

>>> On 07.04.16 at 18:19, wrote: > Konrad Rzeszutek Wilk writes ("[PATCH v6 08/24] xsplice: Add helper elf > routines"): >> From: Ross Lagerwall >> >> Add Elf routines and data structures in preparation for loading an >> xSplice payload. >>

Re: [Xen-devel] [for-4.7] xen/arm64: correctly emulate the {w, x}zr registers

>>> On 07.04.16 at 12:53, wrote: > On AArch64, encoding 31 for an R in the HSR is used to represent > either {w,x}sp or {w,x}zr (See C1.2.4 in ARM DDI 0486A.d) depending on > how the register field is interpreted by the instruction. > > All the instructions trapped by Xen

Re: [Xen-devel] [PATCH 1/2] libxl: Set rc on failure of usbdev_busaddr_to_busid

Chun Yan Liu writes ("Re: [PATCH 1/2] libxl: Set rc on failure of usbdev_busaddr_to_busid"): > Thanks, Ian! Should I take that as a Reviewed-by ? Thanks, Ian. ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 2/2] libxl: Do not leak data on error path from libxl__read_sysfs_file_contents

Chun Yan Liu writes ("Re: [PATCH 2/2] libxl: Do not leak data on error path from libxl__read_sysfs_file_contents"): > <1459782600-16073-2-git-send-email-ian.jack...@eu.citrix.com>, Ian Jackson > wrote: > > +free(data); > > 'data' is malloced with 'gc', it'll be

Re: [Xen-devel] [PATCH 2/2] libfsimage: Add support for btrfs

Ross Lagerwall writes ("[PATCH 2/2] libfsimage: Add support for btrfs"): > Add support for booting from btrfs filesystems. All the code except > fsys_btrfs.c is imported from btrfs-progs 4.5.1. btrfs-progs is licensed > as GPLv2. The files have been imported with minimal modification. > Further

Re: [Xen-devel] [PATCH 1/2] pygrub: Ignore GRUB2 if statements

Ross Lagerwall writes ("[PATCH 1/2] pygrub: Ignore GRUB2 if statements"): > SLES 12's default GRUB config has the following code before any entries: > if [ -n "$extra_cmdline" ]; then > submenu "Bootable snapshot #$snapshot_num" { > menuentry "If OK, run 'snapper rollback' and reboot." {

Re: [Xen-devel] [PATCH] bind_usbintf: do not reuse 'path'

Chunyan Liu writes ("[PATCH] bind_usbintf: do not reuse 'path'"): > To avoid confusion, add a new variable "intf_path" to indicate > driver/interface path, let "path" indicate driver/bind path only. I think it would be better to rename both variables, as I suggested in my mail yesterday. That

Re: [Xen-devel] [PATCH v5 14/21] xen+tools: Export maximum host and guest cpu featuresets via SYSCTL

On 04/07/2016 07:57 AM, Andrew Cooper wrote: And provide stubs for toolstack use. Signed-off-by: Andrew Cooper Acked-by: Wei Liu Acked-by: David Scott Acked-by: Jan Beulich Acked-by: Daniel De Graaf

Re: [Xen-devel] [PATCH v5 08/21] x86/cpu: Sysctl and common infrastructure for levelling context switching

On 04/07/2016 07:57 AM, Andrew Cooper wrote: A toolstack needs to know how much control Xen has over the visible cpuid values in PV guests. Provide an explicit mechanism to query what Xen is capable of. This interface will currently report no capabilities. This change is scaffolding for

Re: [Xen-devel] Stub domain crash on Xen v4.6.1

I'm sorry but this is my first attempt to use stubdom. This is a test machine so feel free to propose xen recompilation adding printk's/obscured options or settings modification. With regards, Fanny 2016-04-07 18:13 GMT+02:00 Wei Liu : > On Wed, Apr 06, 2016 at 02:49:19PM

Re: [Xen-devel] [PATCH 1/4] a fix in libxl_device_usbdev_list

Chunyan Liu writes ("[PATCH 1/4] a fix in libxl_device_usbdev_list"): > In testing with libvirt pvusb functionality, found a rc check > error in libxl_device_usbdev_list. Correct it. This function > is not used by xl. Thanks for these. I have applied 2,3, and 4. But not 1, as I had comments on

  1   2   3   >