Re: [Xen-devel] [PATCH v3 2/2] swiotlb-xen: implement xen_swiotlb_get_sgtable callback

2017-02-01 Thread Julien Grall
Hi, On 01/02/2017 10:42, Andrii Anisov wrote: Ah! Ops :-) DEBUG_KERNEL? You said DEBUG_DRIVER last time. Both DEBUG_KERNEL and DEBUG_DRIVER are not used in code. DEBUG_KERNEL is used through Kconfigs to make available debug options to other different stuff, which consequently define DEBUG

Re: [Xen-devel] [early RFC] ARM PCI Passthrough design document

2017-02-01 Thread Roger Pau Monné
On Wed, Jan 25, 2017 at 06:53:20PM +, Julien Grall wrote: > Hi Stefano, > > On 24/01/17 20:07, Stefano Stabellini wrote: > > On Tue, 24 Jan 2017, Julien Grall wrote: > > > > > whilst for Device Tree the segment number is not available. > > > > > > > > > > So Xen needs to rely on DOM0 to

Re: [Xen-devel] [PATCH] x86/dmop: Fix compat_dm_op() ABI

2017-02-01 Thread Jan Beulich
>>> On 31.01.17 at 20:59, wrote: > What is the pupose of COMPAT_HANDLE_PARAM()? It is a packed structure of one > and a half pointers, so isn't safe at all for use in the hypercall function > APIs (depsite its naming making it look deceptively like it is the correct >

Re: [Xen-devel] [PATCH v3 2/2] swiotlb-xen: implement xen_swiotlb_get_sgtable callback

2017-02-01 Thread Andrii Anisov
Yup, Following is wrong: > DEBUG macro could be globally across drivers defined by > CONFIG_DEBUG_DRIVERS. See drivers/base/Makefile. DEBUG is not defined globally. And there is no debug option to enable DEBUG in drivers/xen/Makefile. Should it be added? Sincerely, Andrii Anisov.

Re: [Xen-devel] [PATCH] x86/dmop: Fix compat_dm_op() ABI

2017-02-01 Thread Jan Beulich
>>> On 31.01.17 at 20:59, wrote: > The parameter to compat_dm_op() is a pointer to an array of > compat_dm_op_buf_t's in guest RAM. > > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich with one question (see below).

Re: [Xen-devel] [PATCH 1/2] x86/VMX: introduce vmx_find_guest_msr()

2017-02-01 Thread Sergey Dyasli
On Wed, 2017-02-01 at 03:19 -0700, Jan Beulich wrote: > > > > > > > > > > > > > On 01.02.17 at 10:38, wrote: > > On Tue, 2017-01-31 at 05:43 -0700, Jan Beulich wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On 31.01.17 at

Re: [Xen-devel] [PATCH v3 2/2] swiotlb-xen: implement xen_swiotlb_get_sgtable callback

2017-02-01 Thread Andrii Anisov
Stefano, > Ah! Ops :-) > > DEBUG_KERNEL? You said DEBUG_DRIVER last time. Both DEBUG_KERNEL and DEBUG_DRIVER are not used in code. DEBUG_KERNEL is used through Kconfigs to make available debug options to other different stuff, which consequently define DEBUG through appropriate makefiles.

Re: [Xen-devel] [early RFC] ARM PCI Passthrough design document

2017-02-01 Thread Roger Pau Monné
On Tue, Jan 31, 2017 at 02:03:16PM -0800, Stefano Stabellini wrote: > On Tue, 31 Jan 2017, Julien Grall wrote: > > > > > > By default all the PCI devices will be assigned to DOM0. So Xen > > > > > > would > > > > > > have > > > > > > to configure the SMMU and Interrupt Controller to allow DOM0 to

Re: [Xen-devel] [PATCH 1/2] x86/VMX: introduce vmx_find_guest_msr()

2017-02-01 Thread Jan Beulich
>>> On 01.02.17 at 10:38, wrote: > On Tue, 2017-01-31 at 05:43 -0700, Jan Beulich wrote: >> > >> > > >> > > > >> > > > On 31.01.17 at 13:06, wrote: >> > On 31/01/17 11:54, Jan Beulich wrote: >> > > >> > > > >> > > > > >> > > > > > >> >

Re: [Xen-devel] [PATCH v3 2/2] swiotlb-xen: implement xen_swiotlb_get_sgtable callback

2017-02-01 Thread Andrii Anisov
Dear Konrad, You are not correct here: > But there are no Kconfig DEBUG - so you may as well just do > #if 0 > > around the code. DEBUG macro is widely used in the kernel, just try grepping it through the code. Elementary example is pr_debug definition which is resolved through DEBUG macro, also

Re: [Xen-devel] [PATCH] x86/dmop: Fix compat_dm_op() ABI

2017-02-01 Thread Paul Durrant
> -Original Message- > From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: 31 January 2017 19:59 > To: Xen-devel > Cc: Andrew Cooper ; Jan Beulich > ; Paul Durrant ; Ian Jackson >

Re: [Xen-devel] [PATCH] VT-d/RMRR: Avoid memory corruption in add_user_rmrr()

2017-02-01 Thread Jan Beulich
(adding VT-d maintainers to Cc) >>> On 31.01.17 at 18:00, wrote: > On Tue, Jan 31, 2017 at 08:56:09AM -0700, Jan Beulich wrote: >> >>> On 31.01.17 at 16:22, wrote: >> > On Tue, Jan 31, 2017 at 02:55:50AM -0700, Jan Beulich wrote: >> >> >>>

[Xen-devel] [distros-debian-squeeze test] 68503: regressions - trouble: blocked/broken/fail/pass

2017-02-01 Thread Platform Team regression test user
flight 68503 distros-debian-squeeze real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/68503/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 5 xen-build fail REGR. vs. 68479 Tests

Re: [Xen-devel] [PATCH 1/2] x86/VMX: introduce vmx_find_guest_msr()

2017-02-01 Thread Sergey Dyasli
On Tue, 2017-01-31 at 05:43 -0700, Jan Beulich wrote: > > > > > > > > > > > > > On 31.01.17 at 13:06, wrote: > > On 31/01/17 11:54, Jan Beulich wrote: > > > > > > > > > > > > > > > > > > > > > > > > On 31.01.17 at 12:49, wrote: > > > >

[Xen-devel] [xen-unstable test] 105169: regressions - FAIL

2017-02-01 Thread osstest service owner
flight 105169 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/105169/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-debianhvm-amd64 9 debian-hvm-install fail REGR. vs. 104681

Re: [Xen-devel] [PATCH v2 3/3] x86: Make the GDT remapping read-only on 64 bit

2017-02-01 Thread Ingo Molnar
* Thomas Garnier wrote: > This patch makes the GDT remapped pages read-only to prevent corruption. > This change is done only on 64 bit. Please spell '64-bit' consistently through the series. I've seen two variants: 64 bit 64bit > +/* > + * The LTR instruction marks

<    1   2