[Xen-devel] [PATCH v4 49/53] xen: add hypercall for setting parameters at runtime

2017-08-23 Thread Juergen Gross
Add a sysctl hypercall to support setting parameters similar to command line parameters, but at runtime. The parameters to set are specified as a string, just like the boot parameters. Cc: Daniel De Graaf Cc: Ian Jackson Cc: Wei Liu

[Xen-devel] [PATCH v4 27/53] xen/common/kexec.c: let custom parameter parsing routines return errno

2017-08-23 Thread Juergen Gross
Modify the custom parameter parsing routines in: xen/common/kexec.c to indicate whether the parameter value was parsed successfully. Cc: Andrew Cooper Signed-off-by: Juergen Gross Acked-by: Wei Liu --- xen/common/kexec.c | 30

[Xen-devel] [PATCH v4 39/53] xen/xsm/flask/flask_op.c: let custom parameter parsing routines return errno

2017-08-23 Thread Juergen Gross
Modify the custom parameter parsing routines in: xen/xsm/flask/flask_op.c to indicate whether the parameter value was parsed successfully. Cc: Daniel De Graaf Signed-off-by: Juergen Gross Acked-by: Daniel De Graaf Acked-by: Wei

[Xen-devel] [PATCH v4 26/53] xen/common/efi/boot.c: let custom parameter parsing routines return errno

2017-08-23 Thread Juergen Gross
Modify the custom parameter parsing routines in: xen/common/efi/boot.c to indicate whether the parameter value was parsed successfully. Cc: Jan Beulich Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich --- V3: - dont return out of

[Xen-devel] [PATCH v4 05/53] xen/arch/x86/apic.c: let custom parameter parsing routines return errno

2017-08-23 Thread Juergen Gross
Modify the custom parameter parsing routines in: xen/arch/x86/apic.c to indicate whether the parameter value was parsed successfully. Cc: Jan Beulich Cc: Andrew Cooper Signed-off-by: Juergen Gross Acked-by: Wei Liu

[Xen-devel] [PATCH v4 09/53] xen/arch/x86/genapic/probe.c: let custom parameter parsing routines return errno

2017-08-23 Thread Juergen Gross
Modify the custom parameter parsing routines in: xen/arch/x86/genapic/probe.c to indicate whether the parameter value was parsed successfully. Cc: Jan Beulich Cc: Andrew Cooper Signed-off-by: Juergen Gross Reviewed-by: Jan

[Xen-devel] [PATCH v4 23/53] xen/arch/x86/x86_64/mmconfig-shared.c: let custom parameter parsing routines return errno

2017-08-23 Thread Juergen Gross
Modify the custom parameter parsing routines in: xen/arch/x86/x86_64/mmconfig-shared.c to indicate whether the parameter value was parsed successfully. Cc: Jan Beulich Cc: Andrew Cooper Signed-off-by: Juergen Gross --- V4: -

[Xen-devel] [PATCH v4 13/53] xen/arch/x86/irq.c: let custom parameter parsing routines return errno

2017-08-23 Thread Juergen Gross
Modify the custom parameter parsing routines in: xen/arch/x86/irq.c to indicate whether the parameter value was parsed successfully. Cc: Jan Beulich Cc: Andrew Cooper Signed-off-by: Juergen Gross Acked-by: Wei Liu

[Xen-devel] [PATCH v4 36/53] xen/drivers/passthrough/vtd/dmar.c: let custom parameter parsing routines return errno

2017-08-23 Thread Juergen Gross
Modify the custom parameter parsing routines in: xen/drivers/passthrough/vtd/dmar.c to indicate whether the parameter value was parsed successfully. Cc: Kevin Tian Signed-off-by: Juergen Gross Acked-by: Wei Liu ---

[Xen-devel] [PATCH v4 33/53] xen/drivers/passthrough/amd/iommu_acpi.c: let custom parameter parsing routines return errno

2017-08-23 Thread Juergen Gross
Modify the custom parameter parsing routines in: xen/drivers/passthrough/amd/iommu_acpi.c to indicate whether the parameter value was parsed successfully. Cc: Suravee Suthikulpanit Signed-off-by: Juergen Gross Acked-by: Wei Liu

Re: [Xen-devel] [PATCH 4/6] xsm: flask: change the interface and default policy for xsm_map_gmfn_foregin

2017-08-23 Thread Stefano Stabellini
On Wed, 23 Aug 2017, Jan Beulich wrote: > >>> On 22.08.17 at 20:08, wrote: > > The original xsm_map_gmfn_foregin policy checks if source domain has the > > proper > > privileges over the target domain. Under this policy, it's not allowed if a > > Dom0 > > wants to map

Re: [Xen-devel] Regression PCI passthrough from 4.5.5 to 4.6.0-rc1

2017-08-23 Thread Andreas Kinzler
> From a brief look it looks like this would be doable, but the way these flags are being communicated is rather ugly (the values used here > aren't part of the public interface, and hence it wasn't immediately > clear whether using one of the unused bits would be an option, but > it looks like

Re: [Xen-devel] Difference between patch in XSA and patch checked in

2017-08-23 Thread George Dunlap
On 08/23/2017 05:39 PM, Andrew Cooper wrote: > On 23/08/17 17:35, George Dunlap wrote: >> Dear committers, >> >> I spent way to many hours this afternoon trying to rebase the CentOS >> patchqueue from 4.6.5 to 4.6.6. In theory "git rebase" should detect >> when duplicate patches are being merged

Re: [Xen-devel] Difference between patch in XSA and patch checked in

2017-08-23 Thread Andrew Cooper
On 23/08/17 17:35, George Dunlap wrote: > Dear committers, > > I spent way to many hours this afternoon trying to rebase the CentOS > patchqueue from 4.6.5 to 4.6.6. In theory "git rebase" should detect > when duplicate patches are being merged over and forget the patch > automatically. > >

[Xen-devel] Difference between patch in XSA and patch checked in

2017-08-23 Thread George Dunlap
Dear committers, I spent way to many hours this afternoon trying to rebase the CentOS patchqueue from 4.6.5 to 4.6.6. In theory "git rebase" should detect when duplicate patches are being merged over and forget the patch automatically. Unfortunately, this didn't work in a large number of cases

Re: [Xen-devel] [PATCH RFC 2/2] x86/mm: PG_translate implies PG_refcounts

2017-08-23 Thread Wei Liu
On Wed, Aug 23, 2017 at 04:58:24PM +0100, Wei Liu wrote: > After 404595352 ("x86/paging: Enforce PG_external == PG_translate == > PG_refcounts"), PG_refcounts and PG_translate always need to be set > together. > > Squash PG_refcounts to simplify code. All calls paging_mode_refcounts > are

Re: [Xen-devel] [PATCH 1/6] libxc: add xc_domain_remove_from_physmap to wrap XENMEM_remove_from_physmap

2017-08-23 Thread Wei Liu
On Wed, Aug 23, 2017 at 02:08:35AM +0800, Zhongze Liu wrote: > This is for the proposal "Allow setting up shared memory areas between VMs > from xl config file". See: > > https://lists.xenproject.org/archives/html/xen-devel/2017-07/msg03047.html > > Then plan is to use

Re: [Xen-devel] [PATCH RFC 1/2] xen: remove CONFIG_PAGING_ASSISTANCE

2017-08-23 Thread Jan Beulich
>>> On 23.08.17 at 17:58, wrote: > Arm should always set it, while on x86 xen can't build with it set to > 0, which means people haven't used it for years. > > Remove it and simplify xen/paging.h. > > Signed-off-by: Wei Liu This is something I

Re: [Xen-devel] [PATCH] xsm: policy hooks to require an IOMMU and interrupt remapping

2017-08-23 Thread Jan Beulich
>>> On 23.08.17 at 17:56, wrote: > On 08/22/2017 04:18 AM, Jan Beulich wrote: > On 18.08.17 at 23:55, wrote: >>> On 08/18/2017 05:02 PM, christopher.w.cl...@gmail.com wrote: From: Christopher Clark

[Xen-devel] [PATCH RFC 1/2] xen: remove CONFIG_PAGING_ASSISTANCE

2017-08-23 Thread Wei Liu
Arm should always set it, while on x86 xen can't build with it set to 0, which means people haven't used it for years. Remove it and simplify xen/paging.h. Signed-off-by: Wei Liu --- Cc: Jan Beulich Cc: Andrew Cooper Cc:

[Xen-devel] [PATCH RFC 2/2] x86/mm: PG_translate implies PG_refcounts

2017-08-23 Thread Wei Liu
After 404595352 ("x86/paging: Enforce PG_external == PG_translate == PG_refcounts"), PG_refcounts and PG_translate always need to be set together. Squash PG_refcounts to simplify code. All calls paging_mode_refcounts are replaced by calls to paging_mode_translate. Signed-off-by: Wei Liu

[Xen-devel] [PATCH RFC 0/2] Misc paging code clean up

2017-08-23 Thread Wei Liu
Wei Liu (2): xen: remove CONFIG_PAGING_ASSISTANCE x86/mm: PG_translate implies PG_refcounts xen/arch/x86/domain.c| 6 ++ xen/arch/x86/hvm/hvm.c | 2 +- xen/arch/x86/mm.c| 20 ++-- xen/arch/x86/mm/paging.c | 8 +++-

Re: [Xen-devel] [PATCH] xsm: policy hooks to require an IOMMU and interrupt remapping

2017-08-23 Thread Daniel De Graaf
On 08/22/2017 04:18 AM, Jan Beulich wrote: On 18.08.17 at 23:55, wrote: On 08/18/2017 05:02 PM, christopher.w.cl...@gmail.com wrote: From: Christopher Clark Isolation of devices passed through to domains usually requires an active

Re: [Xen-devel] [PATCH 4/6] xsm: flask: change the interface and default policy for xsm_map_gmfn_foregin

2017-08-23 Thread Daniel De Graaf
On 08/22/2017 10:18 PM, Zhongze Liu wrote: Hi Stefano, 2017-08-23 3:58 GMT+08:00 Stefano Stabellini : On Wed, 23 Aug 2017, Zhongze Liu wrote: The original xsm_map_gmfn_foregin policy checks if source domain has the proper privileges over the target domain. Under this

[Xen-devel] [ovmf test] 112837: all pass - PUSHED

2017-08-23 Thread osstest service owner
flight 112837 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/112837/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 27ee96701a9495644aefae3690ca6849a79f7631 baseline version: ovmf

[Xen-devel] [xen-4.8-testing test] 112835: regressions - trouble: blocked/broken/fail/pass

2017-08-23 Thread osstest service owner
flight 112835 xen-4.8-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/112835/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-xtf-amd64-amd64-3 48 xtf/test-hvm64-lbr-tsx-vmentry fail REGR. vs. 112664

[Xen-devel] [PATCH v2] hw/display/xenfb.c: Add trace_xenfb_key_event

2017-08-23 Thread Liang Yan
It may be better to add a trace event to monitor the last moment of a key event from QEMU to guest VM Signed-off-by: Liang Yan --- hw/display/trace-events | 1 + hw/display/xenfb.c | 1 + 2 files changed, 2 insertions(+) diff --git a/hw/display/trace-events

[Xen-devel] Xen Security Advisory 235 - add-to-physmap error paths fail to release lock on ARM

2017-08-23 Thread Xen . org security team
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory XSA-235 add-to-physmap error paths fail to release lock on ARM ISSUE DESCRIPTION = When dealing with the grant map space of add-to-physmap operations, ARM specific code recognizes

[Xen-devel] [PATCH] hw/display/xenfb.c: Add trace_xenfb_key_event

2017-08-23 Thread Liang Yan
It may be better to add a trace event to monitor the last moment of a key event from QEMU to guest VM Signed-off-by: Liang Yan --- hw/display/trace-events | 1 + hw/display/xenfb.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/hw/display/trace-events

Re: [Xen-devel] [PATCH RESEND1 00/12] ALSA: vsnd: Add Xen para-virtualized frontend driver

2017-08-23 Thread Oleksandr Grytsov
Hi, Thank you for detailed explanation. We understand that emulated interrupt on the frontend side is completely not acceptable and definitely we need to provide some feedback mechanism from Dom0 to DomU. In our case it is technically impossible to provide precise period interrupt (mostly

Re: [Xen-devel] [PATCH 00/27] xen/arm: Memory subsystem clean-up

2017-08-23 Thread Andre Przywara
Hi Julien, On 14/08/17 15:23, Julien Grall wrote: > Hi all, > > This patch series contains clean-up for the ARM Memory subsystem in > preparation of reworking the page tables handling. thanks for the work! I am done with the review, the series looks fine in general to me. Whenever there were

Re: [Xen-devel] [PATCH v3 39/52] xen: check parameter validity when parsing command line

2017-08-23 Thread Jan Beulich
>>> On 23.08.17 at 16:21, wrote: > On 23/08/17 15:18, Jan Beulich wrote: > On 23.08.17 at 14:42, wrote: >>> On 23/08/17 11:38, Jan Beulich wrote: >>> On 23.08.17 at 11:30, wrote: > On 22/08/17 13:24, Jan Beulich wrote: > On

Re: [Xen-devel] [PATCH 25/27] xen/arm: mm: Embed permission in the flags

2017-08-23 Thread Andre Przywara
Hi, On 23/08/17 15:26, Julien Grall wrote: > On 08/23/2017 03:08 PM, Andre Przywara wrote: >> Hi, > > Hi, > >> On 14/08/17 15:24, Julien Grall wrote: >>> Currently, it is not possible to specify the permission of a new >>> mapping. It would be necessary to use the function modify_xen_mappings

Re: [Xen-devel] [PATCH 26/27] xen/arm: mm: Handling permission flags when adding a new mapping

2017-08-23 Thread Julien Grall
On 08/23/2017 03:09 PM, Andre Przywara wrote: Hi, Hi, On 14/08/17 15:24, Julien Grall wrote: Currently, all the new mappings will be read-write non-executable. Allow the caller to use other permissions. Signed-off-by: Julien Grall --- xen/arch/arm/mm.c | 8

Re: [Xen-devel] [PATCH v2 3/3] tools/libxc: use superpages during restore of HVM guest

2017-08-23 Thread Olaf Hering
On Wed, Aug 23, Olaf Hering wrote: > The value of p2m_size does not represent the actual number of pages > assigned to a domU. This info is stored in getdomaininfo.max_pages, > which is currently not used by restore. I will see if using this value > will avoid triggering the Over-allocation

Re: [Xen-devel] [PATCH 24/27] xen/arm: page: Describe the layout of flags used to update page tables

2017-08-23 Thread Julien Grall
On 08/23/2017 03:08 PM, Andre Przywara wrote: Hi, On 14/08/17 15:24, Julien Grall wrote: Currently, the flags used to update page tables (i.e PAGE_HYPERVISOR_*) only contains the memory attribute index. Follow-up patches will add more information in it. At the same time introduce

Re: [Xen-devel] [PATCH 27/27] xen/arm: mm: Use memory flags for modify_xen_mappings rather than custom one

2017-08-23 Thread Julien Grall
On 08/23/2017 03:10 PM, Andre Przywara wrote: Hi, Hi, On 14/08/17 15:24, Julien Grall wrote: This will help to consolidate the page-table code and avoid different path depending on the action to perform. Signed-off-by: Julien Grall It could be worth to mention in

Re: [Xen-devel] [PATCH 25/27] xen/arm: mm: Embed permission in the flags

2017-08-23 Thread Julien Grall
On 08/23/2017 03:08 PM, Andre Przywara wrote: Hi, Hi, On 14/08/17 15:24, Julien Grall wrote: Currently, it is not possible to specify the permission of a new mapping. It would be necessary to use the function modify_xen_mappings with a different set of flags. Add introduce a couple of new

Re: [Xen-devel] [PATCH v3 39/52] xen: check parameter validity when parsing command line

2017-08-23 Thread Juergen Gross
On 23/08/17 15:18, Jan Beulich wrote: On 23.08.17 at 14:42, wrote: >> On 23/08/17 11:38, Jan Beulich wrote: >> On 23.08.17 at 11:30, wrote: On 22/08/17 13:24, Jan Beulich wrote: On 16.08.17 at 14:52, wrote: >> @@

Re: [Xen-devel] [PATCH V2 7/25] tools/libacpi: Add new fields in acpi_config for DMAR table

2017-08-23 Thread Roger Pau Monné
Small mistake in my message. On Wed, Aug 23, 2017 at 09:04:06AM +0100, Roger Pau Monné wrote: > On Wed, Aug 23, 2017 at 03:52:01PM +0800, Lan Tianyu wrote: > > On 2017年08月23日 00:41, Roger Pau Monné wrote: > > >> > +drhd = (struct acpi_dmar_hardware_unit *)((void*)dmar + > > >> >

Re: [Xen-devel] [PATCH 27/27] xen/arm: mm: Use memory flags for modify_xen_mappings rather than custom one

2017-08-23 Thread Andre Przywara
Hi, On 14/08/17 15:24, Julien Grall wrote: > This will help to consolidate the page-table code and avoid different > path depending on the action to perform. > > Signed-off-by: Julien Grall It could be worth to mention in the commit message that the removed ASSERT is now

Re: [Xen-devel] [PATCH 26/27] xen/arm: mm: Handling permission flags when adding a new mapping

2017-08-23 Thread Andre Przywara
Hi, On 14/08/17 15:24, Julien Grall wrote: > Currently, all the new mappings will be read-write non-executable. Allow the > caller to use other permissions. > > Signed-off-by: Julien Grall > --- > xen/arch/arm/mm.c | 8 > 1 file changed, 8 insertions(+) > > diff

Re: [Xen-devel] [PATCH 21/27] xen/arm: mm: Rename and clarify AP[1] in the stage-1 page table

2017-08-23 Thread Andre Przywara
Hi, On 14/08/17 15:24, Julien Grall wrote: > The description of AP[1] in Xen is based on testing rather than the ARM > ARM. > > Per the ARM ARM, on EL2 stage-1 page table, AP[1] is RES1 as the > translation regime applies to only one exception level (see D4.4.4 and > G4.6.1 in ARM DDI 0487B.a).

Re: [Xen-devel] [PATCH V2 1/25] DOMCTL: Introduce new DOMCTL commands for vIOMMU support

2017-08-23 Thread Roger Pau Monné
On Wed, Aug 23, 2017 at 11:19:01AM +0100, Julien Grall wrote: > Hi Roger, > > On 23/08/17 08:22, Roger Pau Monné wrote: > > On Wed, Aug 23, 2017 at 02:06:17PM +0800, Lan Tianyu wrote: > > > Hi Roger: > > > Thanks for your review. > > > > > > On 2017年08月22日 22:32, Roger Pau Monné wrote: > > > >

Re: [Xen-devel] [PATCH 25/27] xen/arm: mm: Embed permission in the flags

2017-08-23 Thread Andre Przywara
Hi, On 14/08/17 15:24, Julien Grall wrote: > Currently, it is not possible to specify the permission of a new > mapping. It would be necessary to use the function modify_xen_mappings > with a different set of flags. > > Add introduce a couple of new flags for the permissions (Non-eXecutable, >

Re: [Xen-devel] [PATCH 24/27] xen/arm: page: Describe the layout of flags used to update page tables

2017-08-23 Thread Andre Przywara
Hi, On 14/08/17 15:24, Julien Grall wrote: > Currently, the flags used to update page tables (i.e PAGE_HYPERVISOR_*) > only contains the memory attribute index. Follow-up patches will add > more information in it. > > At the same time introduce PAGE_AI_MASK to get the memory attribute > index

Re: [Xen-devel] [PATCH 23/27] xen/arm: mm: Rename 'ai' into 'flags' in create_xen_entries

2017-08-23 Thread Andre Przywara
Hi, On 14/08/17 15:24, Julien Grall wrote: > The parameter 'ai' is used either for attribute index or for > permissions. Follow-up patch will rework that parameters to carry more > information. So rename the parameter to 'flags'. > > Signed-off-by: Julien Grall

Re: [Xen-devel] [PATCH] xsm: policy hooks to require an IOMMU and interrupt remapping

2017-08-23 Thread Ross Philipson
I did test and review this submission back when I worked on the OpenXT project with Christopher so I can add a reviewed by. Reviewed-by: Ross Philipson On Tue, Aug 22, 2017 at 4:18 AM, Jan Beulich wrote: > >>> On 18.08.17 at 23:55,

Re: [Xen-devel] [PATCH V2 10/25] tools/libxl: create vIOMMU during domain construction

2017-08-23 Thread Roger Pau Monné
On Wed, Aug 23, 2017 at 04:02:40PM +0800, Lan Tianyu wrote: > On 2017年08月23日 15:45, Roger Pau Monné wrote: > > On Wed, Aug 09, 2017 at 04:34:11PM -0400, Lan Tianyu wrote: > >> From: Chao Gao > >> > >> If guest is configured to have a vIOMMU, create it during domain > >>

Re: [Xen-devel] [PATCH V2 4/25] Xen/doc: Add Xen virtual IOMMU doc

2017-08-23 Thread Roger Pau Monné
On Wed, Aug 23, 2017 at 03:36:19PM +0800, Lan Tianyu wrote: > On 2017年08月22日 23:55, Roger Pau Monné wrote: > > On Wed, Aug 09, 2017 at 04:34:05PM -0400, Lan Tianyu wrote: > >> This patch is to add Xen virtual IOMMU doc to introduce motivation, > >> framework, vIOMMU hypercall and xl configuration.

Re: [Xen-devel] [PATCH v2] hvmloader: add fields for SMBIOS 2.4 compliance

2017-08-23 Thread Wei Liu
On Wed, Aug 23, 2017 at 02:44:25PM +0100, Roger Pau Monne wrote: > The version of SMBIOS set in the entry point is 2.4, however several > structures are missing fields required by 2.4. Fix this by adding the > missing fields, this is based on the documents found at the DMTF site > [0]. > > Most

[Xen-devel] [PATCH] x86: enable RCU based table free when PARAVIRT

2017-08-23 Thread Vitaly Kuznetsov
On x86 software page-table walkers depend on the fact that remote TLB flush does an IPI: walk is performed lockless but with interrupts disabled and in case the pagetable is freed the freeing CPU will get blocked as remote TLB flush is required. On other architecture which don't require an IPI to

Re: [Xen-devel] [PATCH v2 3/3] tools/libxc: use superpages during restore of HVM guest

2017-08-23 Thread Olaf Hering
On Wed, Aug 23, Wei Liu wrote: > On Tue, Aug 22, 2017 at 05:53:25PM +0200, Olaf Hering wrote: > > In my testing I have seen the case of over-allocation. Thats why I > > implemented the freeing of unpopulated parts. It would be nice to know > > how many pages are actually coming. I think this info

[Xen-devel] [PATCH v2] hvmloader: add fields for SMBIOS 2.4 compliance

2017-08-23 Thread Roger Pau Monne
The version of SMBIOS set in the entry point is 2.4, however several structures are missing fields required by 2.4. Fix this by adding the missing fields, this is based on the documents found at the DMTF site [0]. Most fields are set to 0 (undefined/not specified), except for the cache related

[Xen-devel] [distros-debian-squeeze test] 72006: tolerable trouble: broken/fail/pass

2017-08-23 Thread Platform Team regression test user
flight 72006 distros-debian-squeeze real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/72006/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: build-arm64 2 hosts-allocate broken like 71980 build-arm64-pvops

[Xen-devel] [PATCH v2] xen: Emit RTC_CHANGE upon TIMEOFFSET ioreq

2017-08-23 Thread Ross Lagerwall
When the guest writes to the RTC, Xen emulates it and broadcasts a TIMEOFFSET ioreq. Emit an RTC_CHANGE QMP event to all QMP monitors when this happens rather than ignoring it so that something useful can be done with the information. This is the same event that QEMU generates when it emulates the

[Xen-devel] [xen-unstable-coverity test] 112842: all pass - PUSHED

2017-08-23 Thread osstest service owner
flight 112842 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/112842/ Perfect :-) All tests in this flight passed as required version targeted for testing: xen 4a0485c3d343e1c582fa824e4896b9b613a14efe baseline version: xen

[Xen-devel] [xen-4.6-testing test] 112829: tolerable FAIL - PUSHED

2017-08-23 Thread osstest service owner
flight 112829 xen-4.6-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/112829/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-i386-xl-qemuu-win7-amd64 17 guest-stopfail REGR. vs. 112661

Re: [Xen-devel] [PATCH v3 39/52] xen: check parameter validity when parsing command line

2017-08-23 Thread Jan Beulich
>>> On 23.08.17 at 14:42, wrote: > On 23/08/17 11:38, Jan Beulich wrote: > On 23.08.17 at 11:30, wrote: >>> On 22/08/17 13:24, Jan Beulich wrote: >>> On 16.08.17 at 14:52, wrote: > @@ -176,7 +210,8 @@ int __init parse_bool(const

[Xen-devel] [xen-unstable baseline-only test] 72005: regressions - trouble: blocked/broken/fail/pass

2017-08-23 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 72005 xen-unstable real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/72005/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-examine 10

Re: [Xen-devel] [PATCH v3 39/52] xen: check parameter validity when parsing command line

2017-08-23 Thread Juergen Gross
On 23/08/17 11:38, Jan Beulich wrote: On 23.08.17 at 11:30, wrote: >> On 22/08/17 13:24, Jan Beulich wrote: >> On 16.08.17 at 14:52, wrote: @@ -176,7 +210,8 @@ int __init parse_bool(const char *s) !strcmp("on", s) ||

Re: [Xen-devel] [PATCH V2 25/25] x86/vvtd: save and restore emulated VT-d

2017-08-23 Thread Roger Pau Monné
On Wed, Aug 09, 2017 at 04:34:26PM -0400, Lan Tianyu wrote: > From: Chao Gao > > Wrap some useful status in a new structure hvm_hw_vvtd, following > the customs of vlapic, vioapic and etc. Provide two save-restore > pairs to save/restore registers and non-register status. >

Re: [Xen-devel] [PATCH V2 22/25] x86/vmsi: Hook delivering remapping format msi to guest

2017-08-23 Thread Jan Beulich
>>> On 23.08.17 at 12:55, wrote: > On Wed, Aug 09, 2017 at 04:34:23PM -0400, Lan Tianyu wrote: >> From: Chao Gao >> >> In two situations, hypervisor delivers a msi to a hvm guest. One is >> when qemu sends a request to hypervisor through

Re: [Xen-devel] [PATCH V2 24/25] x86/vvtd: Add queued invalidation (QI) support

2017-08-23 Thread Roger Pau Monné
On Wed, Aug 09, 2017 at 04:34:25PM -0400, Lan Tianyu wrote: > From: Chao Gao > > Queued Invalidation Interface is an expanded invalidation interface with > extended capabilities. Hardware implementations report support for queued > invalidation interface through the Extended

Re: [Xen-devel] [PATCH] hvmloader: add fields for SMBIOS 2.4 compliance

2017-08-23 Thread Jan Beulich
>>> On 23.08.17 at 13:59, wrote: > On Wed, Aug 23, 2017 at 12:52:49PM +0100, Roger Pau Monne wrote: >> On Wed, Aug 23, 2017 at 11:51:49AM +0100, Wei Liu wrote: >> > On Tue, Aug 22, 2017 at 01:50:23PM +0100, Roger Pau Monne wrote: >> > [...] >> > > diff --git

[Xen-devel] [xen-4.9-testing test] 112820: tolerable trouble: blocked/broken/fail/pass - PUSHED

2017-08-23 Thread osstest service owner
flight 112820 xen-4.9-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/112820/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1

Re: [Xen-devel] [PATCH] hvmloader: add fields for SMBIOS 2.4 compliance

2017-08-23 Thread Wei Liu
On Wed, Aug 23, 2017 at 12:52:49PM +0100, Roger Pau Monne wrote: > On Wed, Aug 23, 2017 at 11:51:49AM +0100, Wei Liu wrote: > > On Tue, Aug 22, 2017 at 01:50:23PM +0100, Roger Pau Monne wrote: > > [...] > > > diff --git a/tools/firmware/hvmloader/smbios_types.h > > >

Re: [Xen-devel] [PATCH] hvmloader: add fields for SMBIOS 2.4 compliance

2017-08-23 Thread Roger Pau Monne
On Wed, Aug 23, 2017 at 11:51:49AM +0100, Wei Liu wrote: > On Tue, Aug 22, 2017 at 01:50:23PM +0100, Roger Pau Monne wrote: > [...] > > diff --git a/tools/firmware/hvmloader/smbios_types.h > > b/tools/firmware/hvmloader/smbios_types.h > > index e924f819b3..2bf1645bfa 100644 > > ---

Re: [Xen-devel] [PATCH V2 23/25] x86/vvtd: Handle interrupt translation faults

2017-08-23 Thread Roger Pau Monné
On Wed, Aug 09, 2017 at 04:34:24PM -0400, Lan Tianyu wrote: > From: Chao Gao > > Interrupt translation faults are non-recoverable fault. When faults ^ faults > are triggered, it needs to populate fault info to Fault Recording

Re: [Xen-devel] [PATCH v3 22/52] xen/arch/x86/x86_64/mmconfig-shared.c: let custom parameter parsing routines return errno

2017-08-23 Thread Juergen Gross
On 22/08/17 11:55, Jan Beulich wrote: On 16.08.17 at 14:51, wrote: >> --- a/xen/arch/x86/x86_64/mmconfig-shared.c >> +++ b/xen/arch/x86/x86_64/mmconfig-shared.c >> @@ -28,22 +28,35 @@ >> >> unsigned int pci_probe = PCI_PROBE_CONF1 | PCI_PROBE_MMCONF; >> >> -static void

Re: [Xen-devel] [PATCH 19/27] xen/arm: page: Clean-up the definition of MAIRVAL

2017-08-23 Thread Andre Przywara
Hi, On 14/08/17 15:24, Julien Grall wrote: > Currently MAIRVAL is defined in term of MAIR0VAL and MAIR1VAL which are > both hardcoded value. This makes quite difficult to understand the value > written in both registers. > > Rework the definition by using value of each attribute shifted by their

Re: [Xen-devel] [PATCH 18/27] xen/arm: page: Prefix memory types with MT_

2017-08-23 Thread Andre Przywara
Hi, On 14/08/17 15:24, Julien Grall wrote: > This will avoid confusion in the code when using them. > > Signed-off-by: Julien Grall > --- > xen/arch/arm/kernel.c | 2 +- > xen/arch/arm/mm.c | 28 +-- >

Re: [Xen-devel] [PATCH 20/27] xen/arm: page: Use ARMv8 naming to improve readability

2017-08-23 Thread Andre Przywara
Hi, On 14/08/17 15:24, Julien Grall wrote: > This is based on the Linux ARMv8 naming scheme (see arch/arm64/mm/proc.S). > Each > type will contain "NORMAL" or "DEVICE" to make clear whether each attribute > targets device or normal memory. Yes, that makes sense and improves readability as the

Re: [Xen-devel] [RFC PATCH v1 2/7] iommu/arm: ipmmu-vmsa: Add Xen changes for main driver

2017-08-23 Thread Julien Grall
Hi Oleksandr, On 21/08/17 16:53, Oleksandr Tyshchenko wrote: On Thu, Aug 10, 2017 at 6:13 PM, Julien Grall wrote: On 10/08/17 15:27, Oleksandr Tyshchenko wrote: I would like to clarify what need to be done from my side. Should I wait for the missing things reach upsteam

Re: [Xen-devel] [PATCH 16/27] xen/arm: page: Remove unused attributes DEV_NONSHARED and DEV_CACHED

2017-08-23 Thread Andre Przywara
Hi, On 14/08/17 15:24, Julien Grall wrote: > They were imported from non-LPAE Linux, but Xen is LPAE only. It is time > to do some clean-up in the memory attribute and keep only what make > sense for Xen. Follow-up patch will do more clean-up. > > Also, update the comment saying our attribute

Re: [Xen-devel] [PATCH v3 18/52] xen/arch/x86/psr.c: let custom parameter parsing routines return errno

2017-08-23 Thread Juergen Gross
On 22/08/17 11:51, Jan Beulich wrote: On 16.08.17 at 14:51, wrote: >> Modify the custom parameter parsing routines in: >> >> xen/arch/x86/psr.c >> >> to indicate whether the parameter value was parsed successfully. >> >> Cc: Jan Beulich >> Cc: Andrew

Re: [Xen-devel] [PATCH v4 03/11] public: xen.h: add definitions for UUID handling

2017-08-23 Thread Jan Beulich
>>> On 23.08.17 at 13:08, wrote: > On 23.08.17 11:10, Jan Beulich wrote: > On 22.08.17 at 16:37, wrote: >>> I can't see why you want to map UUID to a certain structure. >> >> This is so that the type cannot mistakenly be passed to a

Re: [Xen-devel] [PATCH v4 03/11] public: xen.h: add definitions for UUID handling

2017-08-23 Thread Volodymyr Babchuk
Hello Jan On 23.08.17 11:10, Jan Beulich wrote: On 22.08.17 at 16:37, wrote: I can't see why you want to map UUID to a certain structure. This is so that the type cannot mistakenly be passed to a function taking unsigned char *, or be assigned to a variable of

Re: [Xen-devel] [PATCH 3/6] libxl:xl: add parsing code to parse "libxl_static_sshm" from xl config files

2017-08-23 Thread Julien Grall
Hi, On 22/08/17 21:36, Stefano Stabellini wrote: On Wed, 23 Aug 2017, Zhongze Liu wrote: Add the parsing utils for the newly introduced libxl_static_sshm struct to the libxl/libxlu_* family. And add realated parsing code in xl to parse the struct from xl config files. This is for the proposal

Re: [Xen-devel] [PATCH 0/5] xen: better grant v2 support

2017-08-23 Thread Juergen Gross
On 23/08/17 11:41, Jan Beulich wrote: On 23.08.17 at 11:19, wrote: >> Just some thoughts on that topic from my side: >> >> This approach should be fine IMO for memory allocated while creating a >> domain. This is basically the same as a bare metal system where the BIOS >>

Re: [Xen-devel] [PATCH V2 22/25] x86/vmsi: Hook delivering remapping format msi to guest

2017-08-23 Thread Roger Pau Monné
On Wed, Aug 09, 2017 at 04:34:23PM -0400, Lan Tianyu wrote: > From: Chao Gao > > In two situations, hypervisor delivers a msi to a hvm guest. One is > when qemu sends a request to hypervisor through XEN_DMOP_inject_msi. > The other is when a physical interrupt arrives and it

Re: [Xen-devel] [PATCH] hvmloader: add fields for SMBIOS 2.4 compliance

2017-08-23 Thread Wei Liu
On Tue, Aug 22, 2017 at 01:50:23PM +0100, Roger Pau Monne wrote: [...] > diff --git a/tools/firmware/hvmloader/smbios_types.h > b/tools/firmware/hvmloader/smbios_types.h > index e924f819b3..2bf1645bfa 100644 > --- a/tools/firmware/hvmloader/smbios_types.h > +++

Re: [Xen-devel] [PATCH V2 21/25] tools/libxc: Add a new interface to bind remapping format msi with pirq

2017-08-23 Thread Roger Pau Monné
On Wed, Aug 09, 2017 at 04:34:22PM -0400, Lan Tianyu wrote: > From: Chao Gao > > Introduce a new binding relationship and provide a new interface to > manage the new relationship. > > Signed-off-by: Chao Gao > Signed-off-by: Lan Tianyu

Re: [Xen-devel] [PATCH v2 3/3] tools/libxc: use superpages during restore of HVM guest

2017-08-23 Thread Wei Liu
On Wed, Aug 23, 2017 at 10:05:37AM +0200, Olaf Hering wrote: > On Tue, Aug 22, Olaf Hering wrote: > > > In my testing I have seen the case of over-allocation. Thats why I > > implemented the freeing of unpopulated parts. It would be nice to know > > how many pages are actually coming. I think

Re: [Xen-devel] [PATCH v2 3/3] tools/libxc: use superpages during restore of HVM guest

2017-08-23 Thread Wei Liu
On Tue, Aug 22, 2017 at 05:53:25PM +0200, Olaf Hering wrote: > On Tue, Aug 22, Wei Liu wrote: > > > On Thu, Aug 17, 2017 at 07:01:33PM +0200, Olaf Hering wrote: > > > +/* No superpage in 1st 2MB due to VGA hole */ > > > +xc_sr_set_bit(0, >x86_hvm.restore.attempted_1g); > > > +

Re: [Xen-devel] [PATCH V2 1/25] DOMCTL: Introduce new DOMCTL commands for vIOMMU support

2017-08-23 Thread Julien Grall
Hi Roger, On 23/08/17 08:22, Roger Pau Monné wrote: On Wed, Aug 23, 2017 at 02:06:17PM +0800, Lan Tianyu wrote: Hi Roger: Thanks for your review. On 2017年08月22日 22:32, Roger Pau Monné wrote: On Wed, Aug 09, 2017 at 04:34:02PM -0400, Lan Tianyu wrote: + +/* vIOMMU capabilities */

Re: [Xen-devel] [PATCH V2 19/25] x86/vioapic: extend vioapic_get_vector() to support remapping format RTE

2017-08-23 Thread Roger Pau Monné
On Wed, Aug 09, 2017 at 04:34:20PM -0400, Lan Tianyu wrote: > From: Chao Gao > > When IOAPIC RTE is in remapping format, it doesn't contain the vector of > interrupt. For this case, the RTE contains an index of interrupt remapping > table where the vector of interrupt is

Re: [Xen-devel] [PATCH 0/5] xen: better grant v2 support

2017-08-23 Thread Juergen Gross
On 23/08/17 11:28, Paul Durrant wrote: >> -Original Message- >> From: Juergen Gross [mailto:jgr...@suse.com] >> Sent: 23 August 2017 10:23 >> To: Paul Durrant ; 'Jan Beulich' >> >> Cc: Tim (Xen.org) ; sstabell...@kernel.org; Wei

Re: [Xen-devel] [PATCH V2 18/25] x86/vvtd: Enable Interrupt Remapping through GCMD

2017-08-23 Thread Roger Pau Monné
On Wed, Aug 09, 2017 at 04:34:19PM -0400, Lan Tianyu wrote: > From: Chao Gao > > Software writes this field to enable/disable interrupt reampping. This patch > emulate IRES field of GCMD. > > Signed-off-by: Chao Gao > Signed-off-by: Lan Tianyu

Re: [Xen-devel] [PATCH 0/5] xen: better grant v2 support

2017-08-23 Thread Juergen Gross
On 23/08/17 11:43, Jan Beulich wrote: On 23.08.17 at 11:23, wrote: >> On 23/08/17 10:47, Paul Durrant wrote: >>> Making a the number of grant frames a per-vm-configurable quantity would >> seem like a reasonable first step. I'm not convinced of the need for >> separate >>

Re: [Xen-devel] [PATCH V2 17/25] x86/vvtd: Enable Queued Invalidation through GCMD

2017-08-23 Thread Roger Pau Monné
On Wed, Aug 09, 2017 at 04:34:18PM -0400, Lan Tianyu wrote: > From: Chao Gao > > Software writes to QIE fields of GCMD to enable or disable queued fields or field? > invalidations. This patch emulates QIE fields of GCMD. > > Signed-off-by: Chao Gao >

Re: [Xen-devel] [PATCH v3 48/52] xen: add hypercall for setting parameters at runtime

2017-08-23 Thread Jan Beulich
>>> On 23.08.17 at 11:52, wrote: > On 22/08/17 13:31, Jan Beulich wrote: > On 16.08.17 at 14:52, wrote: >>> --- a/xen/include/public/sysctl.h >>> +++ b/xen/include/public/sysctl.h >>> @@ -1096,6 +1096,21 @@ struct xen_sysctl_livepatch_op { >>> typedef

Re: [Xen-devel] [PATCH V2 16/25] x86/vioapic: Hook interrupt delivery of vIOAPIC

2017-08-23 Thread Roger Pau Monné
On Wed, Aug 09, 2017 at 04:34:17PM -0400, Lan Tianyu wrote: > From: Chao Gao > > When irq remapping is enabled, IOAPIC Redirection Entry may be in remapping > format. If that, generate an irq_remapping_request and call the common > VIOMMU abstraction's callback to handle this

Re: [Xen-devel] [PATCH V2 14/25] x86/vvtd: Process interrupt remapping request

2017-08-23 Thread Jan Beulich
>>> On 23.08.17 at 11:49, wrote: > On Wed, Aug 09, 2017 at 04:34:15PM -0400, Lan Tianyu wrote: >> @@ -384,6 +399,12 @@ struct iremap_entry { >> }; >> >> /* >> + * When VT-d doesn't enable Extended Interrupt Mode. Hardware only >> interprets >> + * only 8-bits ([15:8])

Re: [Xen-devel] [PATCH V2 15/25] x86/vvtd: decode interrupt attribute from IRTE

2017-08-23 Thread Roger Pau Monné
On Wed, Aug 09, 2017 at 04:34:16PM -0400, Lan Tianyu wrote: > From: Chao Gao > > Previously, interrupt attributes can be extracted from msi message or > IOAPIC RTE. However, with interrupt remapping enabled, the attributes > are enclosed in the associated IRTE. This callback

Re: [Xen-devel] [PATCH 4/6] xsm: flask: change the interface and default policy for xsm_map_gmfn_foregin

2017-08-23 Thread Jan Beulich
>>> On 22.08.17 at 20:08, wrote: > The original xsm_map_gmfn_foregin policy checks if source domain has the > proper > privileges over the target domain. Under this policy, it's not allowed if a > Dom0 > wants to map pages from one DomU to another, this restricts some

Re: [Xen-devel] [PATCH v3 48/52] xen: add hypercall for setting parameters at runtime

2017-08-23 Thread Juergen Gross
On 22/08/17 13:31, Jan Beulich wrote: On 16.08.17 at 14:52, wrote: >> --- a/xen/common/sysctl.c >> +++ b/xen/common/sysctl.c >> @@ -467,6 +467,42 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) >> u_sysctl) >> copyback = 1; >> break; >> >> +

Re: [Xen-devel] [PATCH V2 2/25] VIOMMU: Add irq request callback to deal with irq remapping

2017-08-23 Thread Lan Tianyu
On 2017年08月23日 17:24, Jan Beulich wrote: On 23.08.17 at 09:42, wrote: >> On 2017年08月22日 23:32, Roger Pau Monné wrote: >>> On Wed, Aug 09, 2017 at 04:34:03PM -0400, Lan Tianyu wrote: +static inline void irq_request_ioapic_fill(struct irq_remapping_request

Re: [Xen-devel] [PATCH V2 14/25] x86/vvtd: Process interrupt remapping request

2017-08-23 Thread Roger Pau Monné
On Wed, Aug 09, 2017 at 04:34:15PM -0400, Lan Tianyu wrote: > From: Chao Gao > > When a remapping interrupt request arrives, remapping hardware computes the > interrupt_index per the algorithm described in VTD spec > "Interrupt Remapping Table", interprets the IRTE and

Re: [Xen-devel] [PATCH v3 33/52] xen/drivers/passthrough/iommu.c: let custom parameter parsing routines return errno

2017-08-23 Thread Juergen Gross
On 23/08/17 11:37, Jan Beulich wrote: On 23.08.17 at 11:27, wrote: >> On 22/08/17 12:04, Jan Beulich wrote: >> On 16.08.17 at 14:52, wrote: @@ -89,44 +89,50 @@ static void __init parse_iommu_param(char *s) s += 3;

<    1   2   3   >