Re: [Xen-devel] [PATCH 0/5] xen: better grant v2 support

>>> On 23.08.17 at 11:23, wrote: > On 23/08/17 10:47, Paul Durrant wrote: >> Making a the number of grant frames a per-vm-configurable quantity would > seem like a reasonable first step. I'm not convinced of the need for separate > v1 and v2 limits if this were the case. > >

Re: [Xen-devel] [PATCH 0/5] xen: better grant v2 support

>>> On 23.08.17 at 11:19, wrote: > Just some thoughts on that topic from my side: > > This approach should be fine IMO for memory allocated while creating a > domain. This is basically the same as a bare metal system where the BIOS > needs some memory. > > Memory allocated

Re: [Xen-devel] [PATCH v3 39/52] xen: check parameter validity when parsing command line

>>> On 23.08.17 at 11:30, wrote: > On 22/08/17 13:24, Jan Beulich wrote: > On 16.08.17 at 14:52, wrote: >>> @@ -176,7 +210,8 @@ int __init parse_bool(const char *s) >>> !strcmp("on", s) || >>> !strcmp("true", s) || >>>

Re: [Xen-devel] [PATCH v3 33/52] xen/drivers/passthrough/iommu.c: let custom parameter parsing routines return errno

>>> On 23.08.17 at 11:27, wrote: > On 22/08/17 12:04, Jan Beulich wrote: > On 16.08.17 at 14:52, wrote: >>> @@ -89,44 +89,50 @@ static void __init parse_iommu_param(char *s) >>> s += 3; >>> >>> ss = strchr(s, ','); >>> -if (

Re: [Xen-devel] [PATCH v3 39/52] xen: check parameter validity when parsing command line

On 22/08/17 13:24, Jan Beulich wrote: On 16.08.17 at 14:52, wrote: >> static void __init _cmdline_parse(const char *cmdline) >> { >> char opt[128], *optval, *optkey, *q; >> -const char *p = cmdline; >> +const char *p = cmdline, *s, *key; >> const struct

Re: [Xen-devel] [PATCH 0/5] xen: better grant v2 support

> -Original Message- > From: Juergen Gross [mailto:jgr...@suse.com] > Sent: 23 August 2017 10:23 > To: Paul Durrant ; 'Jan Beulich' > > Cc: Tim (Xen.org) ; sstabell...@kernel.org; Wei Liu > ; George Dunlap

Re: [Xen-devel] [PATCH v3 34/52] xen/drivers/passthrough/pci.c: let custom parameter parsing routines return errno

On 22/08/17 12:07, Jan Beulich wrote: On 16.08.17 at 14:52, wrote: >> --- a/xen/drivers/passthrough/pci.c >> +++ b/xen/drivers/passthrough/pci.c >> @@ -149,17 +149,18 @@ static struct phantom_dev { >> } phantom_devs[8]; >> static unsigned int nr_phantom_devs; >> >>

Re: [Xen-devel] [PATCH v3 33/52] xen/drivers/passthrough/iommu.c: let custom parameter parsing routines return errno

On 22/08/17 12:04, Jan Beulich wrote: On 16.08.17 at 14:52, wrote: >> @@ -89,44 +89,50 @@ static void __init parse_iommu_param(char *s) >> s += 3; >> >> ss = strchr(s, ','); >> -if ( ss ) >> -*ss = '\0'; >> - >> -if (

Re: [Xen-devel] [PATCH V2 3/25] VIOMMU: Add get irq info callback to convert irq remapping request

>>> On 22.08.17 at 17:38, wrote: > On Wed, Aug 09, 2017 at 04:34:04PM -0400, Lan Tianyu wrote: >> --- a/xen/common/viommu.c >> +++ b/xen/common/viommu.c >> @@ -213,6 +213,22 @@ int viommu_handle_irq_request(struct domain *d, u32 >> viommu_id, >> return

Re: [Xen-devel] [PATCH V2 2/25] VIOMMU: Add irq request callback to deal with irq remapping

>>> On 23.08.17 at 09:42, wrote: > On 2017年08月22日 23:32, Roger Pau Monné wrote: >> On Wed, Aug 09, 2017 at 04:34:03PM -0400, Lan Tianyu wrote: >>> +static inline void irq_request_ioapic_fill(struct irq_remapping_request >>> *req, >>> + uint32_t

Re: [Xen-devel] [PATCH 0/5] xen: better grant v2 support

On 23/08/17 10:47, Paul Durrant wrote: >> -Original Message- >> From: Xen-devel [mailto:xen-devel-boun...@lists.xen.org] On Behalf Of Jan >> Beulich >> Sent: 23 August 2017 09:36 >> To: Juergen Gross >> Cc: Tim (Xen.org) ; sstabell...@kernel.org; Wei Liu >>

Re: [Xen-devel] [PATCH 0/5] xen: better grant v2 support

On 23/08/17 10:36, Jan Beulich wrote: On 23.08.17 at 09:49, wrote: >> On 22/08/17 14:48, Jan Beulich wrote: >> On 21.08.17 at 20:05, wrote: Currently Linux has no support for grant v2 as this would reduce the maximum number of active grants by

Re: [Xen-devel] [edk2] [PATCH] Maintainers.txt: update OvmfPkg maintainership

On Wed, Aug 23, 2017 at 11:04:06AM +0200, Laszlo Ersek wrote: > On 08/23/17 03:30, Konrad Rzeszutek Wilk wrote: > > It should be fairly simple to expand the 0-day OSSTest to build > > TianoCore and launch guests with it as a nice regression test. > > The point is to catch regressions before they

Re: [Xen-devel] [PATCH V2 1/25] DOMCTL: Introduce new DOMCTL commands for vIOMMU support

On 2017年08月23日 15:22, Roger Pau Monné wrote: > On Wed, Aug 23, 2017 at 02:06:17PM +0800, Lan Tianyu wrote: >> Hi Roger: >> Thanks for your review. >> >> On 2017年08月22日 22:32, Roger Pau Monné wrote: >>> On Wed, Aug 09, 2017 at 04:34:02PM -0400, Lan Tianyu wrote: + +/* vIOMMU

Re: [Xen-devel] [PATCH 1/2 v3] xenfb: Use Input Handlers directly

> -Original Message- > From: Stefano Stabellini [mailto:sstabell...@kernel.org] > Sent: 22 August 2017 00:12 > To: Owen Smith > Cc: qemu-de...@nongnu.org; xen-de...@lists.xenproject.org; > sstabell...@kernel.org; Anthony Perard > Subject:

Re: [Xen-devel] [edk2] [PATCH] Maintainers.txt: update OvmfPkg maintainership

Hello Konrad, On 08/23/17 03:30, Konrad Rzeszutek Wilk wrote: > On Thu, Aug 17, 2017 at 01:47:59AM +0200, Laszlo Ersek wrote: >> On 08/17/17 00:37, Jordan Justen wrote: >>> On 2017-08-16 12:23:49, Leif Lindholm wrote: >> >> [snip] >> - the value proposition for Linaro is that having

Re: [Xen-devel] [PATCH v7] VT-d: use correct BDF for VF to search VT-d unit

>>> On 23.08.17 at 09:42, wrote: > On Wed, Aug 23, 2017 at 09:01:07AM +0100, Roger Pau Monné wrote: >>On Wed, Aug 23, 2017 at 02:46:08PM +0800, Chao Gao wrote: >>> On Wed, Aug 23, 2017 at 08:31:51AM +0100, Roger Pau Monné wrote: >>> >On Wed, Aug 23, 2017 at 01:20:13AM -0600,

Re: [Xen-devel] [PATCH v7] VT-d: use correct BDF for VF to search VT-d unit

>>> On 23.08.17 at 09:39, wrote: > On Wed, Aug 23, 2017 at 02:04:24AM -0600, Jan Beulich wrote: > On 23.08.17 at 03:05, wrote: >>> Strictly speaking, the VF can be an extended function. The definition is >>> within ARI device (in this kind of device,

Re: [Xen-devel] [PATCH v3 20/52] xen/arch/x86/shutdown.c: let custom parameter parsing routines return errno

>>> On 23.08.17 at 10:40, wrote: > On 22/08/17 11:53, Jan Beulich wrote: > On 16.08.17 at 14:51, wrote: >>> @@ -82,6 +87,8 @@ static void __init set_reboot_type(char *str) >>> >>> if ( reboot_type == BOOT_EFI && !efi_enabled(EFI_RS) ) >>>

Re: [Xen-devel] [PATCH 0/5] xen: better grant v2 support

> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xen.org] On Behalf Of Jan > Beulich > Sent: 23 August 2017 09:36 > To: Juergen Gross > Cc: Tim (Xen.org) ; sstabell...@kernel.org; Wei Liu > ; George Dunlap

Re: [Xen-devel] [PATCH V2 13/25] x86/vvtd: Set Interrupt Remapping Table Pointer through GCMD

On Wed, Aug 09, 2017 at 04:34:14PM -0400, Lan Tianyu wrote: > From: Chao Gao > > Software sets this field to set/update the interrupt remapping table pointer > used by hardware. The interrupt remapping table pointer is specified through > the Interrupt Remapping Table Address

[Xen-devel] [linux-3.18 test] 112817: trouble: blocked/broken/fail/pass

flight 112817 linux-3.18 real [real] http://logs.test-lab.xenproject.org/osstest/logs/112817/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-pvops 3 capture-logs broken REGR. vs. 112102

Re: [Xen-devel] [PATCH v7] VT-d: use correct BDF for VF to search VT-d unit

On Wed, Aug 23, 2017 at 09:01:07AM +0100, Roger Pau Monné wrote: >On Wed, Aug 23, 2017 at 02:46:08PM +0800, Chao Gao wrote: >> On Wed, Aug 23, 2017 at 08:31:51AM +0100, Roger Pau Monné wrote: >> >On Wed, Aug 23, 2017 at 01:20:13AM -0600, Jan Beulich wrote: >> >> >>> On 23.08.17 at 09:16,

Re: [Xen-devel] [PATCH v7] VT-d: use correct BDF for VF to search VT-d unit

On Wed, Aug 23, 2017 at 02:04:24AM -0600, Jan Beulich wrote: On 23.08.17 at 03:05, wrote: >> Strictly speaking, the VF can be an extended function. The definition is >> within ARI device (in this kind of device, device field is treated as an >> extension of function

Re: [Xen-devel] [PATCH v3 20/52] xen/arch/x86/shutdown.c: let custom parameter parsing routines return errno

On 22/08/17 11:53, Jan Beulich wrote: On 16.08.17 at 14:51, wrote: >> --- a/xen/arch/x86/shutdown.c >> +++ b/xen/arch/x86/shutdown.c >> @@ -51,8 +51,11 @@ static int reboot_mode; >> * efiUse the EFI reboot (if running under EFI) >> */ >> static enum reboot_type

Re: [Xen-devel] [PATCH 0/5] xen: better grant v2 support

>>> On 23.08.17 at 09:49, wrote: > On 22/08/17 14:48, Jan Beulich wrote: > On 21.08.17 at 20:05, wrote: >>> Currently Linux has no support for grant v2 as this would reduce the >>> maximum number of active grants by a factor of 2 compared to v1, >>> because

Re: [Xen-devel] [PATCH V2 9/25] tools/libxl: build DMAR table for a guest with one virtual VTD

On Wed, Aug 23, 2017 at 01:35:17PM +0800, Lan Tianyu wrote: > On 2017年08月22日 21:48, Wei Liu wrote: > >> > Hi, Wei > >> > Thanks for your comments. > >> > > >> > iirc, HVM only supports one module; DMAR cannot be a new module. Joining > >> > to > >> > the existing one is the approach we are

Re: [Xen-devel] [PATCH V2 12/25] x86/vvtd: Add MMIO handler for VVTD

On Wed, Aug 09, 2017 at 04:34:13PM -0400, Lan Tianyu wrote: > From: Chao Gao > > This patch adds VVTD MMIO handler to deal with MMIO access. > > Signed-off-by: Chao Gao > Signed-off-by: Lan Tianyu > --- >

Re: [Xen-devel] [PATCH v2 4/4] x86/dom0: re-order DMA remapping enabling for PVH Dom0

>>> On 22.08.17 at 16:05, wrote: > On Tue, Aug 22, 2017 at 06:37:15AM -0600, Jan Beulich wrote: >> >>> On 11.08.17 at 18:43, wrote: >> > Make sure the reserved regions are setup before enabling the DMA >> > remapping in the IOMMU, by calling

Re: [Xen-devel] [PATCH v2 3/4] x86/vtd: introduce a PVH implementation of iommu_inclusive_mapping

>>> On 22.08.17 at 16:01, wrote: > On Tue, Aug 22, 2017 at 06:31:27AM -0600, Jan Beulich wrote: >> >>> On 11.08.17 at 18:43, wrote: >> > On certain Intel systems, as far as I can tell almost all pre-Haswell ones, >> > trying to boot a PVH Dom0 will

Re: [Xen-devel] [PATCH v2 1/4] x86/dom0: prevent access to MMCFG areas for PVH Dom0

>>> On 22.08.17 at 15:54, wrote: > On Tue, Aug 22, 2017 at 06:26:23AM -0600, Jan Beulich wrote: >> >>> On 11.08.17 at 18:43, wrote: >> > They are emulated by Xen, so they must not be mapped into Dom0 p2m. >> > Introduce a helper function to add the

Re: [Xen-devel] [PATCH v4 03/11] public: xen.h: add definitions for UUID handling

>>> On 22.08.17 at 16:37, wrote: > I can't see why you want to map UUID to a certain structure. This is so that the type cannot mistakenly be passed to a function taking unsigned char *, or be assigned to a variable of that type. Please see our TYPE_SAFE() macro which

Re: [Xen-devel] [PATCH V2 8/25] tools/libxl: Add a user configurable parameter to control vIOMMU attributes

On Wed, Aug 23, 2017 at 10:46:13AM +0800, Lan Tianyu wrote: > On 2017年08月22日 21:19, Wei Liu wrote: > >> +=over 4 > >> > + > >> > +=item

Re: [Xen-devel] [PATCH V2 7/25] tools/libacpi: Add new fields in acpi_config for DMAR table

On Wed, Aug 23, 2017 at 10:36:45AM +0800, Lan Tianyu wrote: > On 2017年08月22日 21:12, Wei Liu wrote: > > On Wed, Aug 09, 2017 at 04:34:08PM -0400, Lan Tianyu wrote: > >> From: Chao Gao > >> > >> The BIOS reports the remapping hardware units in a platform to system > >> software

Re: [Xen-devel] [PATCH V2 10/25] tools/libxl: create vIOMMU during domain construction

On 2017年08月23日 15:45, Roger Pau Monné wrote: > On Wed, Aug 09, 2017 at 04:34:11PM -0400, Lan Tianyu wrote: >> From: Chao Gao >> >> If guest is configured to have a vIOMMU, create it during domain >> construction. >> >> Signed-off-by: Chao Gao >>

Re: [Xen-devel] [PATCH v2 3/3] tools/libxc: use superpages during restore of HVM guest

On Tue, Aug 22, Olaf Hering wrote: > In my testing I have seen the case of over-allocation. Thats why I > implemented the freeing of unpopulated parts. It would be nice to know > how many pages are actually coming. I think this info is not available. If the receiving dom0 recognizes an

Re: [Xen-devel] [PATCH v7] VT-d: use correct BDF for VF to search VT-d unit

>>> On 23.08.17 at 03:05, wrote: > Strictly speaking, the VF can be an extended function. The definition is > within ARI device (in this kind of device, device field is treated as an > extension of function number) and function number is greater than 7. But > this field isn't

Re: [Xen-devel] [PATCH V2 7/25] tools/libacpi: Add new fields in acpi_config for DMAR table

On Wed, Aug 23, 2017 at 03:52:01PM +0800, Lan Tianyu wrote: > On 2017年08月23日 00:41, Roger Pau Monné wrote: > >> > +drhd = (struct acpi_dmar_hardware_unit *)((void*)dmar + > >> > sizeof(*dmar)); > >> > +drhd->type = ACPI_DMAR_TYPE_HARDWARE_UNIT; > >> > +drhd->length = sizeof(*drhd) +

Re: [Xen-devel] [PATCH v7] VT-d: use correct BDF for VF to search VT-d unit

On Wed, Aug 23, 2017 at 02:46:08PM +0800, Chao Gao wrote: > On Wed, Aug 23, 2017 at 08:31:51AM +0100, Roger Pau Monné wrote: > >On Wed, Aug 23, 2017 at 01:20:13AM -0600, Jan Beulich wrote: > >> >>> On 23.08.17 at 09:16, wrote: > >> > On Wed, Aug 23, 2017 at 09:05:14AM +0800,

Re: [Xen-devel] [PATCH v7] VT-d: use correct BDF for VF to search VT-d unit

>>> On 23.08.17 at 09:31, wrote: > Maybe what I'm missing is whether it is possible to have a device with > virtual functions that expand across several buses? The typical (non-ARI) arrangement I've seen is for all VFs to always live on buses different from the PF (which is

Re: [Xen-devel] [PATCH V2 11/25] x86/hvm: Introduce a emulated VTD for HVM

On Wed, Aug 09, 2017 at 04:34:12PM -0400, Lan Tianyu wrote: > From: Chao Gao > > This patch adds create/destroy/query function for the emulated VTD > and adapts it to the common VIOMMU abstraction. > > Signed-off-by: Chao Gao > Signed-off-by: Lan Tianyu

Re: [Xen-devel] [PATCH V2 7/25] tools/libacpi: Add new fields in acpi_config for DMAR table

On 2017年08月23日 00:41, Roger Pau Monné wrote: >> > +drhd = (struct acpi_dmar_hardware_unit *)((void*)dmar + >> > sizeof(*dmar)); >> > +drhd->type = ACPI_DMAR_TYPE_HARDWARE_UNIT; >> > +drhd->length = sizeof(*drhd) + ioapic_scope_size; >> > +drhd->flags = ACPI_DMAR_INCLUDE_PCI_ALL;

Re: [Xen-devel] [PATCH 0/5] xen: better grant v2 support

On 22/08/17 14:48, Jan Beulich wrote: On 21.08.17 at 20:05, wrote: >> Currently Linux has no support for grant v2 as this would reduce the >> maximum number of active grants by a factor of 2 compared to v1, >> because the number of possible grants are limited by the allowed

Re: [Xen-devel] [PATCH v7] VT-d: use correct BDF for VF to search VT-d unit

On Wed, Aug 23, 2017 at 08:31:51AM +0100, Roger Pau Monné wrote: >On Wed, Aug 23, 2017 at 01:20:13AM -0600, Jan Beulich wrote: >> >>> On 23.08.17 at 09:16, wrote: >> > On Wed, Aug 23, 2017 at 09:05:14AM +0800, Chao Gao wrote: >> >> On Tue, Aug 22, 2017 at 06:43:49AM -0600,

Re: [Xen-devel] [PATCH V2 10/25] tools/libxl: create vIOMMU during domain construction

On Wed, Aug 09, 2017 at 04:34:11PM -0400, Lan Tianyu wrote: > From: Chao Gao > > If guest is configured to have a vIOMMU, create it during domain construction. > > Signed-off-by: Chao Gao > Signed-off-by: Lan Tianyu > --- >

Re: [Xen-devel] [PATCH V2 3/25] VIOMMU: Add get irq info callback to convert irq remapping request

On 2017年08月22日 23:38, Roger Pau Monné wrote: > On Wed, Aug 09, 2017 at 04:34:04PM -0400, Lan Tianyu wrote: >> This patch is to add get_irq_info callback for platform implementation >> to convert irq remapping request to irq info (E,G vector, dest, dest_mode >> and so on). >> >> Signed-off-by: Lan

Re: [Xen-devel] [PATCH V2 2/25] VIOMMU: Add irq request callback to deal with irq remapping

On 2017年08月22日 23:32, Roger Pau Monné wrote: > On Wed, Aug 09, 2017 at 04:34:03PM -0400, Lan Tianyu wrote: >> This patch is to add irq request callback for platform implementation >> to deal with irq remapping request. >> >> Signed-off-by: Lan Tianyu >> --- >>

Re: [Xen-devel] [PATCH V2 4/25] Xen/doc: Add Xen virtual IOMMU doc

On 2017年08月22日 23:55, Roger Pau Monné wrote: > On Wed, Aug 09, 2017 at 04:34:05PM -0400, Lan Tianyu wrote: >> This patch is to add Xen virtual IOMMU doc to introduce motivation, >> framework, vIOMMU hypercall and xl configuration. >> >> Signed-off-by: Lan Tianyu >> --- >>

Re: [Xen-devel] [PATCH V2 1/25] VIOMMU: Add vIOMMU helper functions to create, destroy and query capabilities

On Wed, Aug 23, 2017 at 03:10:48PM +0800, Lan Tianyu wrote: > On 2017年08月22日 23:27, Roger Pau Monné wrote: > > On Thu, Aug 17, 2017 at 08:22:16PM -0400, Lan Tianyu wrote: > >> +int viommu_register_type(u64 type, struct viommu_ops * ops) > >> +{ > >> +struct viommu_type *viommu_type = NULL; >

Re: [Xen-devel] [PATCH v7] VT-d: use correct BDF for VF to search VT-d unit

On Wed, Aug 23, 2017 at 01:20:13AM -0600, Jan Beulich wrote: > >>> On 23.08.17 at 09:16, wrote: > > On Wed, Aug 23, 2017 at 09:05:14AM +0800, Chao Gao wrote: > >> On Tue, Aug 22, 2017 at 06:43:49AM -0600, Jan Beulich wrote: > >> On 21.08.17 at 23:52,

Re: [Xen-devel] [PATCH V2 1/25] DOMCTL: Introduce new DOMCTL commands for vIOMMU support

On Wed, Aug 23, 2017 at 02:06:17PM +0800, Lan Tianyu wrote: > Hi Roger: > Thanks for your review. > > On 2017年08月22日 22:32, Roger Pau Monné wrote: > > On Wed, Aug 09, 2017 at 04:34:02PM -0400, Lan Tianyu wrote: > >> + > >> +/* vIOMMU capabilities */ > >> +#define VIOMMU_CAP_IRQ_REMAPPING

Re: [Xen-devel] [PATCH v7] VT-d: use correct BDF for VF to search VT-d unit

>>> On 23.08.17 at 09:16, wrote: > On Wed, Aug 23, 2017 at 09:05:14AM +0800, Chao Gao wrote: >> On Tue, Aug 22, 2017 at 06:43:49AM -0600, Jan Beulich wrote: >> On 21.08.17 at 23:52, wrote: >> >> --- a/xen/include/xen/pci.h >> >> +++

Re: [Xen-devel] [PATCH v7] VT-d: use correct BDF for VF to search VT-d unit

On Wed, Aug 23, 2017 at 09:05:14AM +0800, Chao Gao wrote: > On Tue, Aug 22, 2017 at 06:43:49AM -0600, Jan Beulich wrote: > On 21.08.17 at 23:52, wrote: > >> --- a/xen/include/xen/pci.h > >> +++ b/xen/include/xen/pci.h > >> @@ -39,6 +39,10 @@ > >> #define

Re: [Xen-devel] [PATCH V2 1/25] VIOMMU: Add vIOMMU helper functions to create, destroy and query capabilities

On 2017年08月22日 23:27, Roger Pau Monné wrote: > On Thu, Aug 17, 2017 at 08:22:16PM -0400, Lan Tianyu wrote: >> This patch is to introduct an abstract layer for arch vIOMMU implementation >> to deal with requests from dom0. Arch vIOMMU code needs to provide callback >> to perform create, destroy and

[Xen-devel] [xen-4.7-testing baseline-only test] 72004: tolerable trouble: blocked/broken/fail/pass

This run is configured for baseline tests only. flight 72004 xen-4.7-testing real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/72004/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-amd64-rumprun-amd64 17

Re: [Xen-devel] [PATCH V2 1/25] DOMCTL: Introduce new DOMCTL commands for vIOMMU support

Hi Roger: Thanks for your review. On 2017年08月22日 22:32, Roger Pau Monné wrote: > On Wed, Aug 09, 2017 at 04:34:02PM -0400, Lan Tianyu wrote: >> This patch is to introduce create, destroy and query capabilities >> command for vIOMMU. vIOMMU layer will deal with requests and call >> arch

<    1   2   3