[Xen-devel] [PATCH 10/12] xen-blkback: Fix indentation

2017-08-17 Thread Bart Van Assche
Avoid that smatch reports the following warning when building with C=2 CHECK="smatch -p=kernel": drivers/block/xen-blkback/blkback.c:710 xen_blkbk_unmap_prepare() warn: inconsistent indenting Signed-off-by: Bart Van Assche <bart.vanass...@wdc.com> Cc: Konrad Rzeszute

[Xen-devel] [PATCH 12/12] xen-blkfront: Avoid that gcc 7 warns about fall-through when building with W=1

2017-08-17 Thread Bart Van Assche
Signed-off-by: Bart Van Assche <bart.vanass...@wdc.com> Cc: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> Cc: Roger Pau Monn303251 <roger@citrix.com> Cc: xen-de...@lists.xenproject.org --- drivers/block/xen-blkfront.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[Xen-devel] [PATCH 11/12] xen-blkback: Avoid that gcc 7 warns about fall-through when building with W=1

2017-08-17 Thread Bart Van Assche
Signed-off-by: Bart Van Assche <bart.vanass...@wdc.com> Cc: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> Cc: Roger Pau Monn303251 <roger@citrix.com> Cc: xen-de...@lists.xenproject.org --- drivers/block/xen-blkback/blkback.c | 1 + drivers/block/xen-blkback/xenbus.c | 3 ++

Re: [Xen-devel] [PATCH] xen-blkfront: Fix handling of non-supported operations

2017-07-24 Thread Bart Van Assche
On Mon, 2017-07-24 at 08:46 -0600, Jens Axboe wrote: > On 07/21/2017 11:11 AM, Bart Van Assche wrote: > > This patch fixes the following sparse warnings: > > > > drivers/block/xen-blkfront.c:916:45: warning: incorrect type in argument 2 > > (different base types) >

[Xen-devel] [PATCH] xen-blkfront: Fix handling of non-supported operations

2017-07-21 Thread Bart Van Assche
("block: introduce new block status code type") Signed-off-by: Bart Van Assche <bart.vanass...@wdc.com> Cc: Christoph Hellwig <h...@lst.de> Cc: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> Cc: Roger Pau Monné <roger@citrix.com> Cc: <xen-de...@lists.xenpro

Re: [Xen-devel] [PATCH 1/6] xen-blkfront: avoid to use start/stop queue

2017-07-11 Thread Bart Van Assche
On Wed, 2017-07-12 at 02:20 +0800, Ming Lei wrote: > This interfaces will be removed soon, so use quiesce and > unquiesce instead, which should be more safe. > > The only one usage will be removed in the following > congestion control patches. Hello Ming, The title of this patch is misleading

[Xen-devel] [PATCH v3 12/12] xen/scsifront: Remove code that zeroes driver-private command data

2017-06-02 Thread Bart Van Assche
Since the SCSI core zeroes driver-private command data, remove that code from the xen-scsifront driver. Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com> Reviewed-by: Hannes Reinecke <h...@suse.com> Reviewed-by: Juergen Gross <jgr...@suse.com> Reviewed-by: Christoph He

[Xen-devel] [PATCH v2 12/12] xen/scsifront: Remove code that zeroes driver-private command data

2017-06-01 Thread Bart Van Assche
Since the SCSI core zeroes driver-private command data, remove that code from the xen-scsifront driver. Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com> Reviewed-by: Hannes Reinecke <h...@suse.com> Reviewed-by: Juergen Gross <jgr...@suse.com> Cc: xen-de...@lists

[Xen-devel] [PATCH 31/31] xen/scsifront: Remove code that zeroes driver-private command data

2017-05-23 Thread Bart Van Assche
Since the SCSI core zeroes driver-private command data, remove that code from the xen-scsifront driver. Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com> Cc: Juergen Gross <jgr...@suse.com> Cc: xen-de...@lists.xenproject.org --- drivers/scsi/xen-scsifront.c | 1 - 1 fil

[Xen-devel] [PATCH 17/33] xen/scsiback: Make TMF processing slightly faster

2017-05-23 Thread Bart Van Assche
that the struct se_cmd that corresponds to the TMF exists as long as target_tmr_work() is in progress. Hence change the second argument of transport_generic_free_cmd() from 1 into 0. Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com> Cc: Juergen Gross <jgr...@suse.com> Cc: Christop

[Xen-devel] [PATCH 16/33] xen/scsiback: Replace a waitqueue and a counter by a completion

2017-05-23 Thread Bart Van Assche
This patch simplifies the implementation of the scsiback driver but does not change its behavior. Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com> Cc: Juergen Gross <jgr...@suse.com> Cc: Christoph Hellwig <h...@lst.de> Cc: Hannes Reinecke <h...@suse.com>

[Xen-devel] [PATCH 15/33] xen/scsiback: Fix a use-after-free

2017-05-23 Thread Bart Van Assche
scsiback_release_cmd() must not dereference se_cmd->se_tmr_req because that memory is freed by target_free_cmd_mem() before scsiback_release_cmd() is called. Fix this use-after-free by inlining struct scsiback_tmr into struct vscsibk_pend. Signed-off-by: Bart Van Assche <bart.

[Xen-devel] [PATCH 1/9] treewide: Constify most dma_map_ops structures

2017-01-10 Thread Bart Van Assche
ap_ops sn_dma_ops/' arch/ia64/sn/pci/pci_dma.c Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com> Reviewed-by: Christoph Hellwig <h...@lst.de> Cc: Aurelien Jacquiot <a-jacqu...@ti.com> Cc: Catalin Marinas <catalin.mari...@arm.com> Cc: Chris Zankel <ch...@zan