Re: [Xen-devel] [PATCH] ocaml/xs: prefer using character device

Looks fine to me. Acked-by: David Scott > On 1 Sep 2015, at 19:34, Doug Goldstein wrote: > > Since 9c89dc95201ffed5fead17b35754bf9440fdbdc0 libxenstore prefers using > /dev/xen/xenbus over /proc/xen/xenbus. This makes the OCaml xenstore > library

Re: [Xen-devel] [PATCH for-4.6 4/5] oxenstored: fix systemd socket activation

. Change sd_booted to booted_by_systemd to avoid confusion with systemd's API. Signed-off-by: Wei Liu wei.l...@citrix.com --- Cc: Dave Scott dave.sc...@eu.citrix.com For 4.6: without this oxenstored is broken when running on a system with systemd but not started by systemd. --- tools/ocaml

Re: [Xen-devel] [PATCH for-4.6 5/5] oxenstored: move sd_notify_ready out of main loop

-by: Wei Liu wei.l...@citrix.com --- Cc: Dave Scott dave.sc...@eu.citrix.com For 4.6: avoid wasting CPU cycles, easy to reason its correctness. There is a small risk that either I wrote the wrong code or I misunderstand the usage of systemd API. However I've tested the modified oxenstored

Re: [Xen-devel] [PATCH for-4.6 13/13] tools/ocaml: handle strdup failure in stub_xl_device_disk_of_vdev

On 23 Jul 2015, at 09:38, Andrew Cooper andrew.coop...@citrix.com wrote: On 23/07/2015 08:59, Wei Liu wrote: Signed-off-by: Wei Liu wei.l...@citrix.com --- Cc: dave.sc...@eu.citrix.com Please check if the use of caml_failwith is correct. This issue I have a different patch for, which

Re: [Xen-devel] [PATCH] oxenstored: link in the systemd system library

On 22 Jul 2015, at 23:02, Jonathan Creekmore jonathan.creekm...@gmail.com wrote: If systemd is configured for use AND you are building oxenstored, the C systemd library must be linked in to the oxenstored binary instead of just into the static ocaml stub. This sounds sensible to me,

Re: [Xen-devel] [PATCH for-4.6 13/13] tools/ocaml: handle strdup failure in stub_xl_device_disk_of_vdev

On 23 Jul 2015, at 08:59, Wei Liu wei.l...@citrix.com wrote: Signed-off-by: Wei Liu wei.l...@citrix.com --- Cc: dave.sc...@eu.citrix.com Please check if the use of caml_failwith is correct. This looks fine to me. Acked-by: David Scott dave.sc...@citrix.com ---

Re: [Xen-devel] [PATCH XEN v2 09/15] tools/libxc: Remove osdep indirection for privcmd

On 16 Jul 2015, at 05:57, David Scott (Sales UK) david.sc...@citrix.com wrote: One for you I think Dave? Sent from my iPhone Begin forwarded message: From: Ian Campbell ian.campb...@citrix.com To: Ian Jackson ian.jack...@citrix.com, Wei Liu wei.l...@citrix.com,

Re: [Xen-devel] [PATCH] tools: ocaml: Handle anonymous struct members of structs in libxl IDL

. gen_struct is refactored slightly to take the indent level as an argument, since it is now used at a different level. Signed-off-by: Ian Campbell ian.campb...@citrix.com Cc: Julien Grall julien.gr...@citrix.com Cc: Dave Scott dave.sc...@citrix.com Cc: Rob Hoes rob.h...@citrix.com --- tools

Re: [Xen-devel] Hyper and Xen Project

at a time - lots of IPs can bind the same port ~=~ lots of domains can bind the same name What do you think? Thanks, Dave On Thu, Jun 25, 2015 at 2:29 AM Dave Scott dave.sc...@citrix.com wrote: Hi Xu, On 24 Jun 2015, at 14:44, Wang Xu gna...@gmail.com wrote: Thank you Dave, I think I can

Re: [Xen-devel] Hyper and Xen Project

On 24 Jun 2015, at 12:48, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: Hi Wang, I don't know the answer, so I CCed xen-devel (the Xen development list) and a few people that I think will be able to help. Cheers, Stefano On Wed, 24 Jun 2015, Wang Xu wrote: A

Re: [Xen-devel] Hyper and Xen Project

code to check uniqueness. Thanks, Dave Cheers Xu On Wed, Jun 24, 2015 at 9:03 PM Dave Scott dave.sc...@citrix.com wrote: I don’t think the frontend driver in Linux knows about the name key. In my testing I wrote a udev script which looks up the ‘name’ key directly in xenstore

Re: [Xen-devel] [PATCH] oxenstored: fix del_watches and del_transactions

On 17 Jun 2015, at 20:39, Wei Liu wei.l...@citrix.com wrote: The statement to reset nb_watches should be in del_watches, not del_transactions. Signed-off-by: Wei Liu wei.l...@citrix.com Cc: David Scott dave.sc...@citrix.com --- It was only until Ian applied previous patch that I

Re: [Xen-devel] [PATCH RFC 0/4] 'reset everything' approach to PVHVM guest kexec

On 9 Jun 2015, at 10:38, Wei Liu wei.l...@citrix.com wrote: On Tue, Jun 09, 2015 at 10:29:56AM +0100, Wei Liu wrote: [...] + con.next_tid - initial_next_tid I couldn’t spot the part in the C version where the next transaction id is reset — is this a (minor) difference between the two

Re: [Xen-devel] [PATCH RFC 0/4] 'reset everything' approach to PVHVM guest kexec

On 8 Jun 2015, at 18:43, Wei Liu wei.l...@citrix.com wrote: On Mon, Jun 08, 2015 at 04:53:46PM +0100, Wei Liu wrote: On Wed, Jun 03, 2015 at 03:35:18PM +0200, Vitaly Kuznetsov wrote: Jan and Tim, last week you expressed some concerns about if the toolstack-based approach to PVHVM guest

Re: [Xen-devel] [PATCH 8/8] raisin: RFC Add blktap2 as an external tree

On 21 Apr 2015, at 12:01, Dave Scott dave.sc...@citrix.com wrote: On 21 Apr 2015, at 11:42, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: On Tue, 21 Apr 2015, George Dunlap wrote: On 04/21/2015 11:09 AM, Stefano Stabellini wrote: On Tue, 21 Apr 2015, George Dunlap wrote

Re: [Xen-devel] [PATCH 8/8] raisin: RFC Add blktap2 as an external tree

On 21 Apr 2015, at 12:06, George Dunlap george.dun...@eu.citrix.com wrote: On 04/21/2015 12:04 PM, Dave Scott wrote: FYI I’ve been sporadically building the blktap userspace on ARM and it seems to work, although last time I had to fix some format strings which assumed a 64-bit

Re: [Xen-devel] [PATCH] tools/ocaml: remove uint32 use added by 674ad2b

On 8 Feb 2015, at 17:11, M A Young m.a.yo...@durham.ac.uk wrote: From 73bab9cb1cb95f35080fadaf1193cbe45327a89c Mon Sep 17 00:00:00 2001 From: Michael Young m.a.yo...@durham.ac.uk Date: Sun, 8 Feb 2015 15:54:23 + Subject: [PATCH] tools/ocaml: remove uint32 use added by 674ad2b In

[Xen-devel] entropy for VMs

Hi, Mirage now has nice features like TLS[1] and therefore needs a good source of randomness to generate session keys. Mirage VMs are PV, so we can’t use virtio-rng. We've created a prototype entropy server which may be of interest to other people too: https://github.com/mirage/xentropyd

Re: [Xen-devel] [PATCH] ocaml/xenctrl: Check return values from hypercalls

...@citrix.com CC: Ian Jackson ian.jack...@eu.citrix.com CC: Wei Liu wei.l...@citrix.com CC: Dave Scott dave.sc...@eu.citrix.com --- Found with XenServers Coverity scanning. We have the sensitivity turned up higher than Coverity Scan, which does not flag these issues. --- tools/ocaml/libs/xc

Re: [Xen-devel] [PATCH for-4.5] tools/oxenstored: Fix | vs error in fd event handling

On 26 Nov 2014, at 15:38, Zheng Li d...@zheng.li wrote: On 26/11/2014 15:09, Andrew Cooper wrote: This makes fields 0 and 1 true more often than they should be, resulting problems when handling events. Indeed, looks like a mistake I made when rewriting the logic terms lately. The

Re: [Xen-devel] [PATCH for-4.5] tools/oxenstored: Fix | vs error in fd event handling

On 26 Nov 2014, at 18:41, Konrad Rzeszutek Wilk konrad.w...@oracle.com wrote: On Wed, Nov 26, 2014 at 06:24:11PM +, Dave Scott wrote: On 26 Nov 2014, at 15:38, Zheng Li d...@zheng.li wrote: On 26/11/2014 15:09, Andrew Cooper wrote: This makes fields 0 and 1 true more often than