Re: [Xen-devel] [PATCH] MAINTAINERS: Make Christian Lindig maintainer for ocaml tools

Hi, This is great! I don’t know if the protocol requires it, but if so then Acked-by: David Scott <d...@recoil.org <mailto:d...@recoil.org>> Cheers, Dave > On 17 Oct 2017, at 18:44, Ian Jackson <ian.jack...@eu.citrix.com> wrote: > > oxenstored is our default

Re: [Xen-devel] [PATCH v3 1/4] ocaml/gen: fix ocaml type/code generator from IDL

wn type name. >> >> Signed-off-by: Ian Jackson <ian.jack...@eu.citrix.com> > > Reviewed-by: Wei Liu <wei.l...@citrix.com> > Under the assumption that the generated code still compiles ;-) looks ok to me too. Acked-by: David Scott <d...@recoil.org> __

Re: [Xen-devel] [PATCH v3] xenstore: remove XS_RESTRICT support

>> work correctly. So this command is useless and should be removed. >> >> In order to avoid problems in the future remove all support for >> XS_RESTRICT from xenstore. >> >> Signed-off-by: Juergen Gross <jgr...@suse.com> > > Adding Dave Sco

Re: [Xen-devel] [PATCH 0/2] ocaml: Start on fixing brokenness when no ocamlopt

> On 24 Jan 2017, at 11:35, Ian Jackson wrote: > > Ian Jackson writes ("[PATCH 0/2] ocaml: Start on fixing brokenness when no > ocamlopt"): >> Debian jessie arm64 has Ocaml (in the package `ocaml-nox') but the >> package lacks ocamlopt. > ... >> This does not

Re: [Xen-devel] [PATCH] tools/tests: add xenstore testing framework

> On 18 Jan 2017, at 15:23, Wei Liu wrote: > > On Wed, Jan 18, 2017 at 04:16:22PM +0100, Juergen Gross wrote: >> On 18/01/17 13:33, Juergen Gross wrote: >>> Add tools/tests/xenstore for a framework to do tests of xenstore. >>> The aim is to test for correctness and

Re: [Xen-devel] [PATCH for-4.8] tools/oxenstored: Fix transaction handling in 32bit builds

eater than 0x7fff, it will not be clipped suitably into range. >> >> Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> > > Reviewed-by: Wei Liu <wei.l...@citrix.com> Acked-by: David Scott <d...@recoil.org> ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH for-4.8] tools/oxenstored: Avoid allocating invalid transaction ids

here is no chance of a collision, and after > that, the chance is at most 20 (the default open transaction quota) in 2 > billion. That makes sense to me. There seems little chance of the hash table filling up when the quota is set to 20 :-) Acked-by: David Scott <d...@recoil.org> Cheers, Dav

Re: [Xen-devel] [PATCH v4 1/4] tools: remove systemd xenstore socket definitions

our to be tolerated by systemd for the >> xenstore daemon by specifying the appropriate flags in the service >> file. >> >> A rerun of autogen.sh is required. >> >> Signed-off-by: Juergen Gross <jgr...@suse.com> > > Acked-by: Wei Liu <wei.l...@citrix.com

Re: [Xen-devel] Xen 4.3, armhf, ocamlopt, wheezy

o test this. > > In any case we use these old Debian suites when testing old Xen > branches, which were (when they were current) built without ocaml. > > This partially reverts "ts-xen-build-prep: Install Ocaml" bbe1a9b2a6c0. > > Signed-off-by: Ian Jackson <ia

Re: [Xen-devel] [PATCH 7/7] oxenstored: honour XEN_RUN_DIR

ult_pidfile = "/var/run/xenstored.pid" > +let default_pidfile = Paths.xen_run_dir ^ "/xenstored.pid" > > let ring_scan_interval = ref 20 > > -- > 2.1.4 > Looks fine to me. Acked-by: David Scott <d...@recoil.org> ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 14/17] ocaml/libxs: generate a paths.ml

> On 14 Jun 2016, at 10:36, Wei Liu <wei.l...@citrix.com> wrote: > > On Mon, Jun 13, 2016 at 08:50:02PM +0100, David Scott wrote: >> >>> On 13 Jun 2016, at 16:22, Wei Liu <wei.l...@citrix.com> wrote: >>> >>> On Mon, Jun 13, 2016 at 04

Re: [Xen-devel] [PATCH 17/17] oxenstored: honour XEN_RUN_STORED in systemd C stub

> On 13 Jun 2016, at 08:49, Wei Liu <wei.l...@citrix.com> wrote: > > Generate a _paths.h for that and add proper dependency. > > Signed-off-by: Wei Liu <wei.l...@citrix.com> > --- > Cc: Ian Jackson <ian.jack...@eu.citrix.com> > Cc: David

Re: [Xen-devel] [PATCH 16/17] oxenstored: honour XEN_RUN_STORED and XEN_CONFIG_DIR

> On 13 Jun 2016, at 08:49, Wei Liu <wei.l...@citrix.com> wrote: > > Only contain changes to ocaml source code. C stub files will be handled > separately. > > Signed-off-by: Wei Liu <wei.l...@citrix.com> > --- > Cc: Ian Jackson <ian.jack...@eu.citrix.

Re: [Xen-devel] [PATCH 15/17] ocaml/libxs: honour XEN_RUN_STORED

= > end; > unwatch () > > -let daemon_socket = "/var/run/xenstored/socket" > +let daemon_socket = Paths.xen_run_stored ^ "/socket" > > (** Throws this rather than a miscellaneous Unix.connect failed *)

Re: [Xen-devel] [PATCH 14/17] ocaml/libxs: generate a paths.ml

>> >> FAOD I don't consider myself qualified to review this. >> > > David gave his ack to a similar path so I presume he will be fine with > this, too. > > I will wait for his ack anyway. Looks fine to me. Acked-by: David Scott <d...@recoil.org> Cheers, D

Re: [Xen-devel] [PATCH 1/2] oxenstored: generate a paths module

Looks fine to me: Acked-by: David Scott <d...@recoil.org> > On 10 Jun 2016, at 15:25, Wei Liu <wei.l...@citrix.com> wrote: > > That file includes all paths generated by configure. It will be used to > get rid of hard-coded paths in code. > > Signed-off-by

Re: [Xen-devel] [PATCH 2/2] oxenstored: honour XEN_LOG_DIR defined by configure

Hi, Rather than (String.concat “” [a; b]) it’s simpler to write (a ^ b) With that small change, Acked-by: David Scott <d...@recoil.org> Cheers, Dave > On 10 Jun 2016, at 19:44, Wei Liu <wei.l...@citrix.com> wrote: > > CC Dave's correct email address. > > On

Re: [Xen-devel] [PATCH 11/11] oxenstored: honour XEN_{LOG, RUN}_DIR in oxenstored.conf

e.ac and rerun autogen.sh. >> >> Signed-off-by: Wei Liu <wei.l...@citrix.com> >> --- >> Cc: Ian Jackson <ian.jack...@eu.citrix.com> >> Cc: David Scott <d...@recoil.org> > > You should mention that autogen.sh should be rerun. > >

Re: [Xen-devel] [OSSTEST PATCH] ts-xen-build-prep: Install Ocaml

> On 22 Apr 2016, at 16:26, Ian Jackson <ian.jack...@eu.citrix.com> wrote: > > This will result in the Xen build system building, and then > preferring, oxenstored. > > Signed-off-by: Ian Jackson <ian.jack...@eu.citrix.com> > CC: David Scott <d...@recoil.org

Re: [Xen-devel] [PATCH 3/7] oxenstored: refactor request processing

> On 29 Mar 2016, at 17:38, Wei Liu wrote: > > On Tue, Mar 29, 2016 at 10:08:30AM +0100, Jonathan Davies wrote: >> On Thu, Mar 24, 2016 at 07:57:30PM -0400, Boris Ostrovsky wrote: >>> On 03/24/2016 06:49 PM, Andrew Cooper wrote: On 24/03/2016 22:22, Boris Ostrovsky

Re: [Xen-devel] [PATCH v3 21/28] xen+tools: Export maximum host and guest cpu featuresets via SYSCTL

> CC: Jan Beulich <jbeul...@suse.com> >> CC: Tim Deegan <t...@xen.org> >> CC: Wei Liu <wei.l...@citrix.com> >> CC: David Scott <d...@recoil.org> >> CC: Rob Hoes <rob.h...@citrix.com> >> >> v3: >> * Provide libxc implementatio

Re: [Xen-devel] [PATCH 0/7] oxenstored: improve transaction conflict handling

y by performing some >>> refactoring >>> and addition of infrastructure that allows for transactions to be replayed. >>> The >>> seventh patch adds some extra logging. >> >> All the patches have quite the Reviewed-by list already so I would think >

Re: [Xen-devel] [PATCH XEN v6 03/32] tools/ocaml: simplify compile/link of test apps

libxenctrl > becoming more than one word in the future. > > Since the tests are pure ocaml (no C components) CFLAGS and > LIBS_xenlight are not required. > > Signed-off-by: Ian Campbell <ian.campb...@citrix.com> > Cc: David Scott <d...@recoil.org> Looks fine to me:

Re: [Xen-devel] [PATCH v2] tools/ocaml/xb: Correct calculations of data/space the ring

t;andrew.coop...@citrix.com> > > Reviewed-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> Looks good to me too Reviewed-by: David Scott <d...@recoil.org> > >> --- >> CC: Ian Campbell <ian.campb...@citrix.com> >> CC: Ian Jackson <ia

Re: [Xen-devel] [PATCH] ocaml/xc: correct shutdown_reason enumeration

between what could be written to ‘control/shutdown’ in xenstore and legal arguments to `xc_domain_shutdown` and `SCHEDOP_shutdown`? Anyway you’re clearly right, `Watchdog` is the 5th value. So I think this is fine. Acked-by: David Scott <d...@recoil.org> I happen to notice there’s a

Re: [Xen-devel] [PATCH] oxenstored: fix short-write issue

> On 27 Oct 2015, at 17:31, Andrew Cooper wrote: > > On 27/10/15 17:28, Samuel Thibault wrote: >> Andrew Cooper, le Tue 27 Oct 2015 17:21:39 +, a écrit : >>> as the second attempted write could return short as well. >> That is fine. The second attempt will only

Re: [Xen-devel] Oxenstored short-write issue

Hi, > On 27 Oct 2015, at 15:37, Wei Liu wrote: > > Hi Dave > > We discovered an issue in oxenstored: when it writes to the ring, it writes > a chunk of contiguous data. When it tries to write across ring boundary, > it returns a short-write. That leads to stalling

Re: [Xen-devel] [PATCH] MAINTAINERS: fix David Scott's email

Hi All, I think you are looking for dave.sc...@citrix.com - cc'd -Original Message- From: Jan Beulich [mailto:jbeul...@suse.com] Sent: 02 September 2015 09:26 To: car...@cardoe.com; David Scott (Sales UK) <david.sc...@citrix.com> Cc: xen-devel@lists.xen.org Subject: Re: [Xen

[Xen-devel] [PATCH] MAINTAINERS: tools/ocaml: update David Scott's email address

From: David Scott <dave.sc...@eu.citrix.com> Replace my sometimes unreliable <dave.sc...@eu.citrix.com> address with my reliable permanent address. Signed-off-by: David Scott <d...@recoil.org> --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

Re: [Xen-devel] [PATCH] MAINTAINERS: tools/ocaml: update David Scott's email address

> On 2 Sep 2015, at 11:57, Ian Campbell <ian.campb...@citrix.com> wrote: > > On Wed, 2015-09-02 at 11:04 +0100, David Scott wrote: >> From: David Scott <dave.sc...@eu.citrix.com> >> >> Replace my sometimes unreliable <dave.sc...@eu.citrix.com>