[Xen-devel] [PATCH] gdbsx: prefer privcmd character device

2017-10-31 Thread Doug Goldstein
Prefer using the character device over the proc file if the character device exists. CC: Elena Ufimtseva <elena.ufimts...@oracle.com> CC: Ian Jackson <ian.jack...@eu.citrix.com> CC: Stefano Stabellini <stefano.stabell...@eu.citrix.com> CC: Wei Liu <wei.l...@citrix.com

Re: [Xen-devel] Xen 4.6 Hypervisor Fails to Boot and is Hanged in "Turning on Paging"

2017-10-27 Thread Doug Goldstein
- 14.04 14.04 here would imply he's running some Ubuntu for ARM build. Ubuntu 14.04 shipped with Xen 4.6. -- Doug Goldstein ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2 1/2] x86/boot: fix early error display

2017-10-27 Thread Doug Goldstein
ell? That's where we ran into the issue >> in the first place. > > That how I did understand it, so I've queued this already, but for > it to become eligible to applying to 4.9 it first needs to pass the > push gate on master. > > Jan > Of

Re: [Xen-devel] [PATCH v2 1/2] x86/boot: fix early error display

2017-10-26 Thread Doug Goldstein
an, Can you queue this for 4.9 as well? That's where we ran into the issue in the first place. -- Doug Goldstein ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] x86/boot: fix MB2 header to require EFI BS

2017-10-25 Thread Doug Goldstein
gt;>>> On Tue, Oct 24, 2017 at 02:40:41PM -0500, Doug Goldstein wrote: >>>>>> The EFI multiboot2 entry point currently requires EFI BootServices to >>>>>> not have been exited however the header currently tells the boot >>>>>> loader tha

Re: [Xen-devel] [PATCH] libxc: don't fail domain creation when unpacking initrd fails

2017-10-24 Thread Doug Goldstein
his. I do recall bringing this up at a meet up a while back and the concern was breaking someone's workflow. Maybe we can put a warning that the behavior is deprecated for X number of releases before deleting it. -- Doug Goldstein ___ Xen-devel mailing

Re: [Xen-devel] [PATCH] x86/boot: fix MB2 header to require EFI BS

2017-10-24 Thread Doug Goldstein
On 10/24/17 3:22 PM, Andrew Cooper wrote: > On 24/10/17 21:08, Daniel Kiper wrote: >> On Tue, Oct 24, 2017 at 02:40:41PM -0500, Doug Goldstein wrote: >>> The EFI multiboot2 entry point currently requires EFI BootServices to >>> not have been exited however the head

Re: [Xen-devel] [PATCH] x86/boot: fix MB2 header to require EFI BS

2017-10-24 Thread Doug Goldstein
On 10/24/17 3:08 PM, Daniel Kiper wrote: > On Tue, Oct 24, 2017 at 02:40:41PM -0500, Doug Goldstein wrote: >> >> Unfortunately the spec is a bit vague and how I am reading it is: >> - no tag = exit boot services in the boot loader >> - tag present marked optional = boo

Re: [Xen-devel] [PATCH] x86/boot: fix MB2 header to require EFI BS

2017-10-24 Thread Doug Goldstein
On 10/24/17 3:08 PM, Daniel Kiper wrote: > On Tue, Oct 24, 2017 at 02:40:41PM -0500, Doug Goldstein wrote: >> The EFI multiboot2 entry point currently requires EFI BootServices to >> not have been exited however the header currently tells the boot >> loader that Xen op

[Xen-devel] [PATCH] x86/boot: fix MB2 header to require EFI BS

2017-10-24 Thread Doug Goldstein
loader to report an error that it cannot boot Xen if it is unable to meet its needs. Signed-off-by: Doug Goldstein <car...@cardoe.com> --- This should likely be applied against Xen 4.9 and Xen 4.10 as well as staging. I am trying to get multiboot2 support for iPXE and upstream is con

Re: [Xen-devel] [PATCH v2 1/2] x86/boot: fix early error display

2017-10-18 Thread Doug Goldstein
vid and I are both ok with you changing the wording as necessary. I apologize for not updating the commit message. -- Doug Goldstein ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

[Xen-devel] [PATCH v2 1/2] x86/boot: fix early error display

2017-10-17 Thread Doug Goldstein
s loop of the first character. This adds a simple increment. Reviewed-by: Doug Goldstein <car...@cardoe.com> Signed-off-by: David Esler <drumandst...@gmail.com> --- xen/arch/x86/boot/head.S | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/boot/head.S b

[Xen-devel] [PATCH v2 2/2] x86/boot: rename send_chr to print_err

2017-10-17 Thread Doug Goldstein
From: David Esler <drumandst...@gmail.com> The send_chr function sends an entire C-string and not one character and doesn't necessarily just send it over the serial UART anymore so rename it to print_err so that its closer in name to what it does. Reviewed-by: Doug Goldstein <car...@c

Re: [Xen-devel] [PATCH 2/2] x86/boot: rename send_chr to print_err

2017-10-13 Thread Doug Goldstein
On 10/13/17 2:40 AM, Jan Beulich wrote: >>>> On 12.10.17 at 22:56, <andrew.coop...@citrix.com> wrote: >> On 12/10/2017 21:50, Doug Goldstein wrote: >>> From: David Esler <drumandst...@gmail.com> >>> >>> The send_chr function sends

Re: [Xen-devel] [PATCH 1/2] x86/boot: fix early error display

2017-10-12 Thread Doug Goldstein
> On Oct 12, 2017, at 4:27 PM, Daniel Kiper <daniel.ki...@oracle.com> wrote: > >> On Thu, Oct 12, 2017 at 03:50:06PM -0500, Doug Goldstein wrote: >> From: David Esler <drumandst...@gmail.com> >> >> In 9180f5365524 a change was made to the send_chr func

[Xen-devel] [PATCH 1/2] x86/boot: fix early error display

2017-10-12 Thread Doug Goldstein
s loop of the first character. This adds a simple increment. Reviewed-by: Doug Goldstein <car...@cardoe.com> Signed-off-by: David Esler <drumandst...@gmail.com> --- xen/arch/x86/boot/head.S | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.

[Xen-devel] [PATCH 2/2] x86/boot: rename send_chr to print_err

2017-10-12 Thread Doug Goldstein
From: David Esler <drumandst...@gmail.com> The send_chr function sends an entire C-string and not one character and doesn't necessarily just send it over the serial UART anymore so rename it to print_err so that its closer in name to what it does. Reviewed-by: Doug Goldstein <car...@c

Re: [Xen-devel] [PATCH for-4.10] travis: disable UBSAN

2017-10-10 Thread Doug Goldstein
On 10/10/17 4:15 AM, Wei Liu wrote: > The stock compiler in travis doesn't support -fsanitize=undefined. > > Signed-off-by: Wei Liu <wei.l...@citrix.com> > --- > Cc: Doug Goldstein <car...@cardoe.com> > --- > xen/tools/kconfig/allrandom.config | 1 + > 1 fi

Re: [Xen-devel] [PATCH] travis: install ghostscript

2017-06-27 Thread Doug Goldstein
On 6/27/17 4:53 AM, Wei Liu wrote: > Signed-off-by: Wei Liu <wei.l...@citrix.com> > --- > Cc: Doug Goldstein <car...@cardoe.com> > --- > .travis.yml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/.travis.yml b/.travis.yml > index 9121fcca40

[Xen-devel] XenStore protocol endianness

2017-05-07 Thread Doug Goldstein
. Thanks. -- Doug Goldstein ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v16 7/9] x86: make Xen early boot code relocatable

2017-04-13 Thread Doug Goldstein
ugh test gate and landed in master. > So, this way we have full multiboot2 support in Xen. This means that > you can boot Xen using GRUB2 on EFI platforms. > > I would like to thank everybody who helped me to make it happen. > Especially Jan who patiently reviewed whole series many times > and replied for my stupid questions. > > Daniel > Congrats Daniel. -- Doug Goldstein signature.asc Description: OpenPGP digital signature ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v16 4/9] x86: add multiboot2 protocol support for EFI platforms

2017-03-15 Thread Doug Goldstein
On 3/15/17 9:38 AM, Daniel Kiper wrote: > On Wed, Mar 15, 2017 at 09:27:27AM -0500, Doug Goldstein wrote: >> On 3/15/17 6:35 AM, Daniel Kiper wrote: >>> On Thu, Mar 09, 2017 at 02:02:49PM -0600, Doug Goldstein wrote: >>> >>> [...] >>> >>>&

Re: [Xen-devel] [PATCH v16 4/9] x86: add multiboot2 protocol support for EFI platforms

2017-03-15 Thread Doug Goldstein
On 3/15/17 6:35 AM, Daniel Kiper wrote: > On Thu, Mar 09, 2017 at 02:02:49PM -0600, Doug Goldstein wrote: > > [...] > >> Still missing 'xl info'. > > Got Intel NUC5i3MYHE (internally it is NUC5i3MYBE board) into my hands. > I have put 8 GiB RAM and 500 GB SATA

Re: [Xen-devel] [PATCH v16 4/9] x86: add multiboot2 protocol support for EFI platforms

2017-03-09 Thread Doug Goldstein
On 3/7/17 9:44 PM, Konrad Rzeszutek Wilk wrote: > On Tue, Mar 07, 2017 at 12:39:04AM +0100, Daniel Kiper wrote: >> On Wed, Feb 22, 2017 at 09:04:17AM -0800, Doug Goldstein wrote: >> >> [...] >> >>> I'm currently at ELC and then on vacation so I don't ha

Re: [Xen-devel] [PATCH] build: add --with-rundir option to configure

2017-02-24 Thread Doug Goldstein
On 2/24/17 10:14 AM, Juergen Gross wrote: > On 24/02/17 17:06, Doug Goldstein wrote: >> On 2/22/17 1:53 AM, Juergen Gross wrote: >>> On 20/02/17 16:19, Andrew Cooper wrote: >>>> On 20/02/17 14:43, Juergen Gross wrote: >>>>> On 20/02/17 15:31, Wei Li

Re: [Xen-devel] [PATCH] build: add --with-rundir option to configure

2017-02-24 Thread Doug Goldstein
witch over to --runstatedir when a new autoconf version is >available > > I'm in favor of (3.). > > > Juergen FWIW, many distros have already pulled the patch into their autoconf so its available so you wouldn't really have to do anything. Debian:

Re: [Xen-devel] [PATCH] build: add --with-rundir option to configure

2017-02-24 Thread Doug Goldstein
un instead of /var/run via configure >> 2. patch autoconf to support --runstatedir >> 3. take this patch adding support via --with-rundir and possibly >>switch over to --runstatedir when a new autoconf version is >>available > > Option 3 but we need to have that for

Re: [Xen-devel] [PATCH v16 4/9] x86: add multiboot2 protocol support for EFI platforms

2017-02-22 Thread Doug Goldstein
-chardev socket,host=127.0.0.1,port=25914,id=S0,server,nowait -device isa-serial,chardev=S0 -device piix3-usb-uhci -device usb-tablet -netdev id=net0,type=tap -device virtio-net-pci,netdev=net0,mac=52:54:00:12:34:56 -boot order=n -device qxl-vga -gdb tcp::14952 -- Doug Goldstein signature.asc Description: OpenPGP digital signature ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v16 4/9] x86: add multiboot2 protocol support for EFI platforms

2017-02-22 Thread Doug Goldstein
ever sees more than the boot CPU. I'd recommend using QEMU master since they landed some fixes so that the debugger can handle switching from 64-bit to 32-bit and back again. -- Doug Goldstein signature.asc Description: OpenPGP digital signature ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v15 05/10] x86: add multiboot2 protocol support for EFI platforms

2017-02-16 Thread Doug Goldstein
a bootloader called us using __efi64_mb2_start > we are sure that we are running on EFI platform and there is no VGA there. > It means that we can safely zap vga_text_buffer unconditionally in first steps > (we do that in second instruction). Then we do not need to take care about > th

[Xen-devel] [PATCH] x86/EFI: fix build when using GNU Make 4.1

2017-02-02 Thread Doug Goldstein
than I was going to originally submit, I had used runtime.o but while testing this I saw Daniel Kiper's v14 of his multiboot2 series come along and I modified my patch so that he would not have to rebase. Signed-off-by: Doug Goldstein <car...@cardoe.com> --- CC: Jan Beulich <jbeul...@sus

Re: [Xen-devel] [PATCH v14 2/9] efi: build xen.gz with EFI code

2017-02-02 Thread Doug Goldstein
> Xen binary which can be loaded by three boot protocols: EFI native loader, >> multiboot (v1) and multiboot2. >> >> Signed-off-by: Daniel Kiper <daniel.ki...@oracle.com> >> Acked-by: Jan Beulich <jbeul...@suse.com> >> Reviewed-by: Doug Goldstein <

Re: [Xen-devel] [PATCH v14 0/9] x86: multiboot2 protocol support

2017-02-02 Thread Doug Goldstein
last time? I know Jan and I appreciated that and it made it easier to review. -- Doug Goldstein signature.asc Description: OpenPGP digital signature ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v1 0/7] Make building xSplice patches easier

2017-01-30 Thread Doug Goldstein
ss, What happened with this series? Some of these patches still appear un-applied and they appear relevant still. -- Doug Goldstein signature.asc Description: OpenPGP digital signature ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v13 4/9] x86: add multiboot2 protocol support for EFI platforms

2017-01-25 Thread Doug Goldstein
change asm "g" constraint to "rm" in efi_multiboot2() > (suggested by Jan Beulich), > - improve comments > (suggested by Jan Beulich and Doug Goldstein). This is a huge change and would really be helpful to have

Re: [Xen-devel] [PATCH v12 00/10] x86: multiboot2 protocol support

2017-01-23 Thread Doug Goldstein
On 1/23/17 9:45 AM, Daniel Kiper wrote: > On Mon, Jan 23, 2017 at 09:35:55AM -0600, Doug Goldstein wrote: >> On 1/23/17 7:08 AM, Daniel Kiper wrote: >>> On Fri, Jan 20, 2017 at 10:54:12PM +0100, Daniel Kiper wrote: >>>> On Fri, Jan 20, 2017 at 02:42:30PM -0500, Doug

Re: [Xen-devel] [PATCH v12 00/10] x86: multiboot2 protocol support

2017-01-23 Thread Doug Goldstein
On 1/23/17 8:28 AM, Konrad Rzeszutek Wilk wrote: > On Mon, Jan 23, 2017 at 02:08:58PM +0100, Daniel Kiper wrote: >> On Fri, Jan 20, 2017 at 10:54:12PM +0100, Daniel Kiper wrote: >>> On Fri, Jan 20, 2017 at 02:42:30PM -0500, Doug Goldstein wrote: >>>> On 1/19/

Re: [Xen-devel] [PATCH v12 00/10] x86: multiboot2 protocol support

2017-01-23 Thread Doug Goldstein
On 1/23/17 7:08 AM, Daniel Kiper wrote: > On Fri, Jan 20, 2017 at 10:54:12PM +0100, Daniel Kiper wrote: >> On Fri, Jan 20, 2017 at 02:42:30PM -0500, Doug Goldstein wrote: >>> On 1/19/17 8:34 PM, Daniel Kiper wrote: >>>> Hi, >>>> >>>> I am

Re: [Xen-devel] [PATCH v12 00/10] x86: multiboot2 protocol support

2017-01-20 Thread Doug Goldstein
On 1/20/17 2:42 PM, Doug Goldstein wrote: > Effectively the fix to efi_multiboot2() gets us back to the same level > of hardware support that v11 + my v5 was at for 1-5. So I will extend my: > > Reviewed-by: Doug Goldstein <car...@cardoe.com> > Tested-by: Doug Goldste

Re: [Xen-devel] [PATCH v12 00/10] x86: multiboot2 protocol support

2017-01-20 Thread Doug Goldstein
(since patch 1 has already gone in) and apply the fix to efi_multiboot2() then all the machines I presently have access to boot. Effectively the fix to efi_multiboot2() gets us back to the same level of hardware support that v11 + my v5 was at for 1-5. So I will extend my: Reviewed-by: Doug

Re: [Xen-devel] [PATCH v12 05/10] x86: add multiboot2 protocol support for EFI platforms

2017-01-20 Thread Doug Goldstein
return cfg.addr + MBI_SIZE; I can't see how this booted for you with OVMF because for all the different versions I've tried with the original code its writing over reserved memory that QEMU uses for the graphics buffers. Which immediately results in the trampolines being overwritten with consol

Re: [Xen-devel] [PATCH v12 00/10] x86: multiboot2 protocol support

2017-01-20 Thread Doug Goldstein
On 1/20/17 12:21 PM, Daniel Kiper wrote: > On Fri, Jan 20, 2017 at 11:22:21AM -0500, Doug Goldstein wrote: >> On 1/19/17 8:34 PM, Daniel Kiper wrote: >>> Hi, >>> >>> I am sending twelfth version of multiboot2 protocol support for >>> legacy BIOS

Re: [Xen-devel] [PATCH v12 05/10] x86: add multiboot2 protocol support for EFI platforms

2017-01-20 Thread Doug Goldstein
- rename __efi64_start to __efi64_mb2_start > (suggested by Andrew Cooper), Andrew actually asked for __mb2_efi64_start > + > +__efi64_mb2_start: here. -- Doug Goldstein signature.asc Description: OpenPGP digital signature ___ Xen-devel mailin

Re: [Xen-devel] [PATCH v12 02/10] x86: add multiboot2 protocol support

2017-01-20 Thread Doug Goldstein
l Kiper <daniel.ki...@oracle.com> > Reviewed-by: Jan Beulich <jbeul...@suse.com> > Reviewed-by: Doug Goldstein <car...@cardoe.com> > --- > v12 - suggestions/fixes: > - replace TABs with spaces in xen/include/xen/multiboot2.h > (suggested by Doug Goldst

Re: [Xen-devel] [PATCH v12 00/10] x86: multiboot2 protocol support

2017-01-20 Thread Doug Goldstein
On 1/20/17 12:21 PM, Daniel Kiper wrote: > On Fri, Jan 20, 2017 at 11:22:21AM -0500, Doug Goldstein wrote: >> On 1/19/17 8:34 PM, Daniel Kiper wrote: >>> Hi, >>> >>> I am sending twelfth version of multiboot2 protocol support for >>> legacy BIOS

Re: [Xen-devel] [PATCH v12 01/10] x86/boot: implement early command line parser in C

2017-01-20 Thread Doug Goldstein
On 1/20/17 11:37 AM, Doug Goldstein wrote: > On 1/19/17 8:34 PM, Daniel Kiper wrote: >> diff --git a/xen/arch/x86/boot/Makefile b/xen/arch/x86/boot/Makefile >> index 5fdb5ae..6d20646 100644 >> --- a/xen/arch/x86/boot/Makefile >> +++ b/xen/arch/x86/boot/Makefile >&g

Re: [Xen-devel] [PATCH v12 01/10] x86/boot: implement early command line parser in C

2017-01-20 Thread Doug Goldstein
So when this was patch 8 this previously had: +RELOC_DEPS = $(DEFS_H_DEPS) $(BASEDIR)/include/xen/multiboot.h \ +$(BASEDIR)/include/xen/multiboot2.h Which its now moved to patch 1 so obviously can't include multiboot2.h but then patch 2 in this series fails to add this and patch 5 fails to a

Re: [Xen-devel] [PATCH v12 00/10] x86: multiboot2 protocol support

2017-01-20 Thread Doug Goldstein
boot with iPXE and grub on an Intel NUC and another board I've got. I've also just tried to apply 1-5 and it fails to boot as well. -- Doug Goldstein signature.asc Description: OpenPGP digital signature ___ Xen-devel mailing list Xen-devel@list

Re: [Xen-devel] [PATCH v12 05/10] x86: add multiboot2 protocol support for EFI platforms

2017-01-19 Thread Doug Goldstein
size = MB_TRAMPOLINE_SIZE + MB_TRAMPOLINE_STACK_SIZE + MBI_SIZE; Why MBI_SIZE? I don't see that being copied in that region or living there? -- Doug Goldstein signature.asc Description: OpenPGP digital signature ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v12 10/10] x86: add multiboot2 protocol support for relocatable images

2017-01-19 Thread Doug Goldstein
nore it and everything works as usual. > > Signed-off-by: Daniel Kiper <daniel.ki...@oracle.com> > Acked-by: Jan Beulich <jbeul...@suse.com> > Reviewed-by: Doug Goldstein <car...@cardoe.com> FWIW, I can't find where I offered my R-b for this patch. Its part of the series

Re: [Xen-devel] [PATCH v12 09/10] x86/boot: rename sym_phys() to sym_offs()

2017-01-19 Thread Doug Goldstein
hysical address. > > There is no functional change. > > Suggested-by: Jan Beulich <jbeul...@suse.com> > Signed-off-by: Daniel Kiper <daniel.ki...@oracle.com> > Acked-by: Jan Beulich <jbeul...@suse.com> > Reviewed-by: Doug Goldstein <car...@cardoe.com> F

Re: [Xen-devel] [PATCH v12 07/10] x86/setup: use XEN_IMG_OFFSET instead of...

2017-01-19 Thread Doug Goldstein
On 1/19/17 8:34 PM, Daniel Kiper wrote: > ..calculating its value during runtime. > > Signed-off-by: Daniel Kiper <daniel.ki...@oracle.com> > Acked-by: Jan Beulich <jbeul...@suse.com> > Reviewed-by: Doug Goldstein <car...@cardoe.com> FWIW, I can't find where I o

Re: [Xen-devel] [PATCH v12 06/10] x86: change default load address from 1 MiB to 2 MiB

2017-01-19 Thread Doug Goldstein
g. > It is no longer needed. > > Signed-off-by: Daniel Kiper <daniel.ki...@oracle.com> > Reviewed-by: Jan Beulich <jbeul...@suse.com> > Reviewed-by: Doug Goldstein <car...@cardoe.com> FWIW, I can't find where I offered my R-b for this patch. Its part of th

Re: [Xen-devel] [PATCH 0/4] multiboot2 protocol support

2017-01-19 Thread Doug Goldstein
nd some basic multiboot2 support since we've had this series outstanding for years. I was just trying to help this series move forward and believe we can do improvements after the fact. -- Doug Goldstein signature.asc Description: OpenPGP digital signature

Re: [Xen-devel] [PATCH v4 5/5] fix: add multiboot2 protocol support for EFI platforms

2017-01-19 Thread Doug Goldstein
Its about a dozen machines all together. They fail in two different ways: - the other CPUs are reported as stuck and the machine boots but 'xl info' reports 1 available CPU. - when the non-CPUs are brought up it dies when setting paging back into cr0. Every single machine fails in one of these t

[Xen-devel] [PATCH v2 1/3] x86/mtrr: drop positive_have_wrcomb()

2017-01-18 Thread Doug Goldstein
The only call to have_wrcomb() was always to the generic implementation. positive_have_wrcomb() was unused. Signed-off-by: Doug Goldstein <car...@cardoe.com> Acked-by: Jan Beulich <jbeul...@suse.com> --- Retaining ACK from <57b480fd027800106...@prv-mh.provo.novell.com> ---

[Xen-devel] [PATCH v2 2/3] x86/mtrr: drop unused func prototypes and struct

2017-01-18 Thread Doug Goldstein
These weren't used so drop them. Signed-off-by: Doug Goldstein <car...@cardoe.com> Reviewed-by: Jan Beulich <jbeul...@suse.com> --- Retained R-b from <57b48184027800106...@prv-mh.provo.novell.com> --- xen/arch/x86/cpu/mtrr/mtrr.h | 15 --- 1 file changed, 15

[Xen-devel] [PATCH v2 3/3] x86/mtrr: convert use_intel_if u32 to bool

2017-01-18 Thread Doug Goldstein
This field is always only 1 currently but may allow 0 in the future so convert it to a bool to provide proper range checking by the compiler. Signed-off-by: Doug Goldstein <car...@cardoe.com> --- xen/arch/x86/cpu/mtrr/generic.c | 2 +- xen/arch/x86/cpu/mtrr/mtrr.h| 4 ++-- 2 files chan

[Xen-devel] [PATCH v2 0/3] x86/mtrr: basic cleanups

2017-01-18 Thread Doug Goldstein
Retained the parts that were not objected to by plans to disable mtrrs on PVH containers. Doug Goldstein (3): x86/mtrr: drop positive_have_wrcomb() x86/mtrr: drop unused func prototypes and struct x86/mtrr: convert use_intel_if u32 to bool xen/arch/x86/cpu/mtrr/generic.c | 7 +-- xen

Re: [Xen-devel] [PATCH 6/6] x86/cpuid: Only recalculate the shared feature bits once

2017-01-18 Thread Doug Goldstein
lt;andrew.coop...@citrix.com> Reviewed-by: Doug Goldstein <car...@cardoe.com> -- Doug Goldstein signature.asc Description: OpenPGP digital signature ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 5/6] x86/cpuid: Handle the long vendor string in guest_cpuid()

2017-01-18 Thread Doug Goldstein
On 1/18/17 2:40 PM, Andrew Cooper wrote: > Leaves 0x8002 through 0x8004 are plain ASCII text, and require no > specific recalculation. > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> Reviewed-by: Doug Goldstein <car...@cardoe.com> -- Doug Go

Re: [Xen-devel] [PATCH 4/6] x86/cpuid: Handle leaf 0x80000000 in guest_cpuid()

2017-01-18 Thread Doug Goldstein
plicated according to the > chosen vendor. > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> Reviewed-by: Doug Goldstein <car...@cardoe.com> -- Doug Goldstein signature.asc Description: OpenPGP digital signature _

Re: [Xen-devel] [PATCH 3/6] x86/cpuid: Handle leaf 0 in guest_cpuid()

2017-01-18 Thread Doug Goldstein
On 1/18/17 2:40 PM, Andrew Cooper wrote: > Calculate a domains x86_vendor early in recalculate_cpuid_policy(); subsequent > patches need to make other recalculation decisions based on it. > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> Reviewed-by: Doug Goldstein

Re: [Xen-devel] [PATCH 2/6] x86/cpuid: Remove BUG_ON() condition from guest_cpuid()

2017-01-18 Thread Doug Goldstein
ew.coop...@citrix.com> Reviewed-by: Doug Goldstein <car...@cardoe.com> -- Doug Goldstein signature.asc Description: OpenPGP digital signature ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 1/6] x86/cpuid: Hide VT-x/SVM from HVM-based control domains

2017-01-18 Thread Doug Goldstein
au Monné <roger@citrix.com> > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> Reviewed-by: Doug Goldstein <car...@cardoe.com> -- Doug Goldstein signature.asc Description: OpenPGP digital signature ___ Xen-devel mailing

[Xen-devel] [PATCH v5 2/5] efi: build xen.gz with EFI code

2017-01-18 Thread Doug Goldstein
om Xen ELF using just simple objcopy or other tool. This way we will have one Xen binary which can be loaded by three boot protocols: EFI native loader, multiboot (v1) and multiboot2. Signed-off-by: Daniel Kiper <daniel.ki...@oracle.com> Acked-by: Jan Beulich <jbeul...@suse.com> Review

[Xen-devel] [PATCH v5 0/5] multiboot2 protocol support

2017-01-18 Thread Doug Goldstein
ed Daniel Kiper (4): x86: add multiboot2 protocol support efi: build xen.gz with EFI code efi: create new early memory allocator x86: add multiboot2 protocol support for EFI platforms Doug Goldstein (1): fix: add multiboot2 protocol support for EFI platforms xen/arch/x8

[Xen-devel] [PATCH v5 5/5] fix: add multiboot2 protocol support for EFI platforms

2017-01-18 Thread Doug Goldstein
not manifest as a crash while on others it did. Reworked the changes to always reserve 64kb for both the stack and the size of the trampolines. Added a build time assert to make sure we have enough room always. Signed-off-by: Doug Goldstein <car...@cardoe.com> Reviewed-by: Jan Beulich <jbeul...

[Xen-devel] [PATCH v5 3/5] efi: create new early memory allocator

2017-01-18 Thread Doug Goldstein
ulich <jbeul...@suse.com> Acked-by: Julien Grall <julien.gr...@arm.com> Reviewed-by: Doug Goldstein <car...@cardoe.com> --- Doug v1 - removed stale paragraph v11 - suggestions/fixes: - #ifdef only EBMALLOC_SIZE from ebmalloc machinery (suggested by Jan Beulich). v10 - s

[Xen-devel] [PATCH v5 4/5] x86: add multiboot2 protocol support for EFI platforms

2017-01-18 Thread Doug Goldstein
From: Daniel Kiper <daniel.ki...@oracle.com> This way Xen can be loaded on EFI platforms using GRUB2 and other boot loaders which support multiboot2 protocol. Signed-off-by: Daniel Kiper <daniel.ki...@oracle.com> Reviewed-by: Doug Goldstein <car...@cardoe.com> Tested-by: D

[Xen-devel] [PATCH v5 1/5] x86: add multiboot2 protocol support

2017-01-18 Thread Doug Goldstein
daniel.ki...@oracle.com> Reviewed-by: Jan Beulich <jbeul...@suse.com> Reviewed-by: Doug Goldstein <car...@cardoe.com> --- v9 - suggestions/fixes: - use .L label instead of numeric one in multiboot2 data scanning loop; I hope that this change does not invalidate Jan's Reviewed-b

Re: [Xen-devel] [PATCH v4 5/5] fix: add multiboot2 protocol support for EFI platforms

2017-01-18 Thread Doug Goldstein
sier than folding this into your larger series. Can you tell me what were the fixes to the relocation code? -- Doug Goldstein signature.asc Description: OpenPGP digital signature ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v4 4/5] x86: add multiboot2 protocol support for EFI platforms

2017-01-18 Thread Doug Goldstein
On 1/18/17 2:51 PM, Andrew Cooper wrote: > On 18/01/17 14:17, Doug Goldstein wrote: >> diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.S >> index d423fd8..ac93df0 100644 >> --- a/xen/arch/x86/boot/head.S >> +++ b/xen/arch/x86/boot/head.S >> @@ -89,6

Re: [Xen-devel] [PATCH] xen/common: Drop function calls for Xen compile/version information

2017-01-18 Thread Doug Goldstein
t; options used during boot. > > ~Andrew FWIW, some of the clang issues I reported against LTO and FPU bits are marked as fixed in 3.9 and 4.0. Not sure if things got backported. -- Doug Goldstein signature.asc Description: OpenPGP digital signature _

[Xen-devel] [PATCH v4 4/5] x86: add multiboot2 protocol support for EFI platforms

2017-01-18 Thread Doug Goldstein
From: Daniel Kiper <daniel.ki...@oracle.com> This way Xen can be loaded on EFI platforms using GRUB2 and other boot loaders which support multiboot2 protocol. Signed-off-by: Daniel Kiper <daniel.ki...@oracle.com> Reviewed-by: Doug Goldstein <car...@cardoe.com> Tested-by: D

[Xen-devel] [PATCH v4 3/5] efi: create new early memory allocator

2017-01-18 Thread Doug Goldstein
ulich <jbeul...@suse.com> Acked-by: Julien Grall <julien.gr...@arm.com> Reviewed-by: Doug Goldstein <car...@cardoe.com> --- Doug v1 - removed stale paragraph v11 - suggestions/fixes: - #ifdef only EBMALLOC_SIZE from ebmalloc machinery (suggested by Jan Beulich). v10 - s

[Xen-devel] [PATCH v4 5/5] fix: add multiboot2 protocol support for EFI platforms

2017-01-18 Thread Doug Goldstein
not manifest as a crash while on others it did. Reworked the changes to always reserve 64kb for both the stack and the size of the trampolines. Added a build time assert to make sure we have enough room always. Signed-off-by: Doug Goldstein <car...@cardoe.com> --- Doug v4 - change wording around

[Xen-devel] [PATCH v4 1/5] x86: add multiboot2 protocol support

2017-01-18 Thread Doug Goldstein
daniel.ki...@oracle.com> Reviewed-by: Jan Beulich <jbeul...@suse.com> Reviewed-by: Doug Goldstein <car...@cardoe.com> --- v9 - suggestions/fixes: - use .L label instead of numeric one in multiboot2 data scanning loop; I hope that this change does not invalidate Jan's Reviewed-b

[Xen-devel] [PATCH v4 2/5] efi: build xen.gz with EFI code

2017-01-18 Thread Doug Goldstein
om Xen ELF using just simple objcopy or other tool. This way we will have one Xen binary which can be loaded by three boot protocols: EFI native loader, multiboot (v1) and multiboot2. Signed-off-by: Daniel Kiper <daniel.ki...@oracle.com> Acked-by: Jan Beulich <jbeul...@suse.com> Review

[Xen-devel] [PATCH v4 0/5] multiboot2 protocol support

2017-01-18 Thread Doug Goldstein
ild xen.gz with EFI code efi: create new early memory allocator x86: add multiboot2 protocol support for EFI platforms Doug Goldstein (1): fix: add multiboot2 protocol support for EFI platforms xen/arch/x86/Makefile | 2 +- xen/arch/x86/boot/Makefile| 3 +- xen/arc

Re: [Xen-devel] [PATCH v3 5/5] fix: add multiboot2 protocol support for EFI platforms

2017-01-18 Thread Doug Goldstein
d >> just remove this. > > Well, I don't mind the max() (albeit it's not very useful, especially > if trampoline size would ever get pretty close to 64k). And as said > in reply to the earlier version - I think this would better be checked > at build time (see the various

Re: [Xen-devel] [PATCH v3 5/5] fix: add multiboot2 protocol support for EFI platforms

2017-01-18 Thread Doug Goldstein
>> +cfg.size = max_t(UINTN, 64 << 10, >> +(trampoline_end - trampoline_start) + 4096); > > Considering the consuming code further up, I don't understand the > reason for the addition of 4096 here. And if there is a reason, I'm > pretty sure you actually mean PAG

[Xen-devel] [PATCH v3 5/5] fix: add multiboot2 protocol support for EFI platforms

2017-01-17 Thread Doug Goldstein
not manifest as a crash while on others it did. Reworked the changes to always reserve 64kb for both the stack and the size of the trampolines. Signed-off-by: Doug Goldstein <car...@cardoe.com> Reviewed-by: Doug Goldstein <car...@cardoe.com> --- Doug v3 - drop ASSERTs since they are runtime

[Xen-devel] [PATCH v3 3/5] efi: create new early memory allocator

2017-01-17 Thread Doug Goldstein
ulich <jbeul...@suse.com> Acked-by: Julien Grall <julien.gr...@arm.com> Reviewed-by: Doug Goldstein <car...@cardoe.com> --- Doug v1 - removed stale paragraph v11 - suggestions/fixes: - #ifdef only EBMALLOC_SIZE from ebmalloc machinery (suggested by Jan Beulich). v10 - s

[Xen-devel] [PATCH v3 1/5] x86: add multiboot2 protocol support

2017-01-17 Thread Doug Goldstein
daniel.ki...@oracle.com> Reviewed-by: Jan Beulich <jbeul...@suse.com> Reviewed-by: Doug Goldstein <car...@cardoe.com> --- v9 - suggestions/fixes: - use .L label instead of numeric one in multiboot2 data scanning loop; I hope that this change does not invalidate Jan's Reviewed-b

[Xen-devel] [PATCH v3 4/5] x86: add multiboot2 protocol support for EFI platforms

2017-01-17 Thread Doug Goldstein
From: Daniel Kiper <daniel.ki...@oracle.com> This way Xen can be loaded on EFI platforms using GRUB2 and other boot loaders which support multiboot2 protocol. Signed-off-by: Daniel Kiper <daniel.ki...@oracle.com> Reviewed-by: Doug Goldstein <car...@cardoe.com> Tested-by: D

[Xen-devel] [PATCH v3 0/5] multiboot2 protocol support

2017-01-17 Thread Doug Goldstein
x86: add multiboot2 protocol support for EFI platforms Doug Goldstein (1): fix: add multiboot2 protocol support for EFI platforms xen/arch/x86/Makefile | 2 +- xen/arch/x86/boot/Makefile| 3 +- xen/arch/x86/boot/head.S | 361 +-- xen/arc

[Xen-devel] [PATCH v3 2/5] efi: build xen.gz with EFI code

2017-01-17 Thread Doug Goldstein
om Xen ELF using just simple objcopy or other tool. This way we will have one Xen binary which can be loaded by three boot protocols: EFI native loader, multiboot (v1) and multiboot2. Signed-off-by: Daniel Kiper <daniel.ki...@oracle.com> Acked-by: Jan Beulich <jbeul...@suse.com> Review

Re: [Xen-devel] [PATCH] xen/common: Drop function calls for Xen compile/version information

2017-01-16 Thread Doug Goldstein
rodata, > which allows all users to generate code referencing the data directly. > > No functional change, but causes smaller and more efficient compiled code. > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> Reviewed-by: Doug Goldstein <car...@cardoe.co

Re: [Xen-devel] [PATCH 4/4] x86: add multiboot2 protocol support for EFI platforms

2017-01-16 Thread Doug Goldstein
On 1/16/17 9:11 AM, Daniel Kiper wrote: > On Mon, Jan 16, 2017 at 08:41:08AM -0500, Doug Goldstein wrote: >> On 1/16/17 7:50 AM, Daniel Kiper wrote: >>> On Mon, Jan 16, 2017 at 05:02:05AM -0700, Jan Beulich wrote: >>>>>>> On 13.01.17 at 20:21, <car

[Xen-devel] [PATCH v2 5/5] fix: add multiboot2 protocol support for EFI platforms

2017-01-16 Thread Doug Goldstein
not manifest as a crash while on others it did. Reworked the changes to always reserve 64kb for both the stack and the size of the trampolines. Added an ASSERT to make sure we never blow through this size. Signed-off-by: Doug Goldstein <car...@cardoe.com> Reviewed-by: Doug Goldstein <car...@c

[Xen-devel] [PATCH v2 0/5] multiboot2 protocol support

2017-01-16 Thread Doug Goldstein
ly dropped Daniel Kiper (4): x86: add multiboot2 protocol support efi: build xen.gz with EFI code efi: create new early memory allocator x86: add multiboot2 protocol support for EFI platforms Doug Goldstein (1): fix: add multiboot2 protocol support for EFI platforms xen/arch/x8

[Xen-devel] [PATCH v2 4/5] x86: add multiboot2 protocol support for EFI platforms

2017-01-16 Thread Doug Goldstein
From: Daniel Kiper <daniel.ki...@oracle.com> This way Xen can be loaded on EFI platforms using GRUB2 and other boot loaders which support multiboot2 protocol. Signed-off-by: Daniel Kiper <daniel.ki...@oracle.com> Reviewed-by: Doug Goldstein <car...@cardoe.com> Tested-by: D

[Xen-devel] [PATCH v2 1/5] x86: add multiboot2 protocol support

2017-01-16 Thread Doug Goldstein
daniel.ki...@oracle.com> Reviewed-by: Jan Beulich <jbeul...@suse.com> Reviewed-by: Doug Goldstein <car...@cardoe.com> --- v9 - suggestions/fixes: - use .L label instead of numeric one in multiboot2 data scanning loop; I hope that this change does not invalidate Jan's Reviewed-b

[Xen-devel] [PATCH v2 2/5] efi: build xen.gz with EFI code

2017-01-16 Thread Doug Goldstein
om Xen ELF using just simple objcopy or other tool. This way we will have one Xen binary which can be loaded by three boot protocols: EFI native loader, multiboot (v1) and multiboot2. Signed-off-by: Daniel Kiper <daniel.ki...@oracle.com> Acked-by: Jan Beulich <jbeul...@suse.com> Review

[Xen-devel] [PATCH v2 3/5] efi: create new early memory allocator

2017-01-16 Thread Doug Goldstein
ulich <jbeul...@suse.com> Acked-by: Julien Grall <julien.gr...@arm.com> Reviewed-by: Doug Goldstein <car...@cardoe.com> --- Doug v1 - removed stale paragraph v11 - suggestions/fixes: - #ifdef only EBMALLOC_SIZE from ebmalloc machinery (suggested by Jan Beulich). v10 - s

Re: [Xen-devel] [PATCH 3/4] efi: create new early memory allocator

2017-01-16 Thread Doug Goldstein
y chunks starting from the lowest address. After init phase we can >> free unused portion of the memory pool as in case of .init.text or >> .init.data >> sections. This way we do not need to allocate any space in image file and >> freeing of unused area in the memor

Re: [Xen-devel] [PATCH 4/4] x86: add multiboot2 protocol support for EFI platforms

2017-01-16 Thread Doug Goldstein
n would require me to either inter-diff the patches, > or re-review the whole thing. For a large patch like this it would be > rather helpful to be quite a bit more specific as to where exactly in the > patch changes were made. > > Jan > I'll submit a diff against v11 to help s

Re: [Xen-devel] [PATCH 4/4] x86: add multiboot2 protocol support for EFI platforms

2017-01-16 Thread Doug Goldstein
comments posted by Doug for v11. > > Daniel > Why? They're the first 4 patches remaining of your series. It'll literally be the following commands: git fetch origin git rebase origin/staging -- Doug Goldstein signature.asc Description: OpenPGP digital signature ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

[Xen-devel] [PATCH 3/4] efi: create new early memory allocator

2017-01-13 Thread Doug Goldstein
y pool is very simple. Now #2a solution is implemented because it is quite simple and requires limited number of changes, especially in __start_xen(). The new allocator is quite generic and can be used on ARM platforms too. Signed-off-by: Daniel Kiper <daniel.ki...@oracle.com> Reviewed-by: Do

  1   2   3   4   5   6   7   8   9   10   >