Re: [Xen-devel] [PATCH v2 for-4.7 08/14] libxl: fix shutdown_reason type in list_domains

2016-04-26 Thread Doug Goldstein
On 4/26/16 9:52 AM, Roger Pau Monne wrote: > It should be an enum, not an unsigned. > > Signed-off-by: Roger Pau Monné <roger@citrix.com> Reviewed-by: Doug Goldstein <car...@cardoe.com> I had to drop the shutdown_reason >= 0 check a few lines below in my version of t

Re: [Xen-devel] [PATCH v2 for-4.7 06/14] xen/tools: fix substitution of __align8__ uint64_t inside of headers

2016-04-26 Thread Doug Goldstein
gned-off-by: Roger Pau Monné <roger@citrix.com> Reviewed-by: Doug Goldstein <car...@cardoe.com> -- Doug Goldstein signature.asc Description: OpenPGP digital signature ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2 for-4.7 05/14] tools/headers: prevent adding two __align8__ to uint64_t in ARM headers

2016-04-26 Thread Doug Goldstein
ecific types to uint64_t only, and then replacing all the > uint64_t types to __align8__ uint64_t. This relies on the fact that all > Xen-specific types will have longer names, so they will always be replaced > first. > > Signed-off-by: Roger Pau Monné <roger....@citrix.com>

Re: [Xen-devel] [PATCH v2 for-4.7 03/14] build: pass HOST{CC/CXX} value down to Kconfig

2016-04-26 Thread Doug Goldstein
On 4/26/16 9:52 AM, Roger Pau Monne wrote: > Signed-off-by: Roger Pau Monné <roger@citrix.com> > Acked-by: Ian Jackson <ian.jack...@eu.citrix.com> Reviewed-by: Doug Goldstein <car...@cardoe.com> -- Doug Goldstein signature.asc Description: O

Re: [Xen-devel] [PATCH v2 for-4.7 02/14] build: set HOSTCXX based on clang value for Kconfig xconfig target

2016-04-26 Thread Doug Goldstein
On 4/26/16 9:52 AM, Roger Pau Monne wrote: > The xconfig Kconfig target requires a C++ compiler because it uses Qt. > > Signed-off-by: Roger Pau Monné <roger@citrix.com> Reviewed-by: Doug Goldstein <car...@cardoe.com> -- Doug Goldstein signature.asc Descrip

Re: [Xen-devel] [PATCH v2 for-4.7 01/14] build: make HOSTCC conditional on the value of clang

2016-04-26 Thread Doug Goldstein
On 4/26/16 9:52 AM, Roger Pau Monne wrote: > Previously HOSTCC was always hardcoded to gcc > > Signed-off-by: Roger Pau Monné <roger@citrix.com> Reviewed-by: Doug Goldstein <car...@cardoe.com> -- Doug Goldstein signature.asc Description: Open

Re: [Xen-devel] [PATCH v2 for-4.7 14/14] tools/python: corrently use LDFLAGS and CFLAGS

2016-04-26 Thread Doug Goldstein
; > Signed-off-by: Roger Pau Monné <roger@citrix.com> > --- Reviewed-by: Doug Goldstein <car...@cardoe.com> -- Doug Goldstein signature.asc Description: OpenPGP digital signature ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2 for-4.7 04/14] build: remove Kconfig forced gcc selection

2016-04-26 Thread Doug Goldstein
On 4/26/16 9:52 AM, Roger Pau Monne wrote: > Signed-off-by: Roger Pau Monné <roger@citrix.com> > --- > Cc: Doug Goldstein <car...@cardoe.com> > --- > xen/tools/kconfig/Makefile.kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >

[Xen-devel] [PATCH v3] tools: detect appropriate debug optimization level

2016-04-26 Thread Doug Goldstein
When building debug use -Og as the optimization level if its available, otherwise retain the use of -O0. -Og has been added by GCC to enable all optimizations that to not affect debugging while retaining full debugability. Signed-off-by: Doug Goldstein <car...@cardoe.com> --- change si

Re: [Xen-devel] [PATCH] travis: enable building of the tools

2016-04-26 Thread Doug Goldstein
On 4/25/16 9:46 AM, Doug Goldstein wrote: > For native (non-cross compiles) we now only require bcc, ld86, as86 for > building rombios, we can build the toolstack sans rombios and using the > system SeaBIOS due to known build issues. At the same time capture the > output of the confi

[Xen-devel] [PATCH] blktap2: use abort() instead of custom crash

2016-04-26 Thread Doug Goldstein
Instead of trying to write a snippet of code that crashes the process just use abort() directly. This is to fix the build on clang which detects that the snippet of code will crash and fails to compile. At the same time removed extraneous whitespace in the macro. Signed-off-by: Doug Goldstein

Re: [Xen-devel] [PATCH] travis: enable building of the tools

2016-04-25 Thread Doug Goldstein
On 4/25/16 9:53 AM, Wei Liu wrote: > On Mon, Apr 25, 2016 at 09:46:18AM -0500, Doug Goldstein wrote: >> For native (non-cross compiles) we now only require bcc, ld86, as86 for >> building rombios, we can build the toolstack sans rombios and using the >> system SeaBIOS due

[Xen-devel] [PATCH] travis: enable building of the tools

2016-04-25 Thread Doug Goldstein
. This does not enable building of the toolstack with clang for now due to multiple failures. Signed-off-by: Doug Goldstein <car...@cardoe.com> --- .travis.yml | 8 scripts/travis-build | 31 +++ 2 files changed, 35 insertions(+), 4 deletions(-)

[Xen-devel] [PATCH] libfsimage: fix bad header guard

2016-04-25 Thread Doug Goldstein
The #ifndef / #define value used was not consistent so it did not function as a proper header guard. Signed-off-by: Doug Goldstein <car...@cardoe.com> --- tools/libfsimage/ufs/ufs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libfsimage/ufs/ufs.h b/tools/libf

Re: [Xen-devel] Xen 4.7 Headline Features (for PR)

2016-04-23 Thread Doug Goldstein
bedded / security-conscious vendors. > > -George Not really important but I figured I'd be clear about my motivations. For Gentoo I'll actually keep the stock settings. For Yocto I'll keep the stock settings but expose a way to run kconfig (like the linux kernel is in Yocto) for vend

[Xen-devel] [PATCH v2] tools: detect appropriate debug optimization level

2016-04-19 Thread Doug Goldstein
When building debug use -Og as the optimization level if its available, otherwise retain the use of -O0. -Og has been added by GCC to enable all optimizations that to not affect debugging while retaining full debugability. Signed-off-by: Doug Goldstein <car...@cardoe.com> --- tools/Rules.

Re: [Xen-devel] [Hackathon 16] Notes from Security Session

2016-04-19 Thread Doug Goldstein
called "dummy" that is the same as XSM disabled. To make XSM usage more smooth I propose we bake the default policy into .initdata so that when you boot Xen compiled with XSM you are no worse off than compiling XSM out. The rationale here is that

Re: [Xen-devel] [PATCH v4 04/14] firmware/makefile: install BIOS blob ...

2016-04-18 Thread Doug Goldstein
nk SeaBIOS and OVMF are a lot more low risk than something like QEMU since they have a very clear target so they're a lot more likely to remain stable. SeaBIOS also has a fairly low level of churn, especially on stable branches. Just a thought. -- Doug Goldstein signature.asc Description: OpenPGP digital signature ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] Update SeaBIOS to include 8a0df3

2016-04-18 Thread Doug Goldstein
ry important TBH, but it would be a "nice to have". > > Roger. > We could also ask Kevin to do a 1.9.2 from the 1.9-stable branch. There's one more commit on top of the one that Roger asked for in the 1.9-stable branch. -- Doug Goldstein signature.asc Description: OpenPGP digital signature ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH for-4.7] xen/build: Fix build with Clang

2016-04-07 Thread Doug Goldstein
will complicate the clang build quite a bit, and won't make much of a >> dent on the symbol table bloat. > > While this I'm unclear about: Istr Doug mentioning that simply > adding the option in suitable for to AFLAGS would do. > > Jan > I was trying to do exactly what you mentioned where we still passed it to gas and didn't pass it to llvm but unfortunately at some point the flags get combined together and passed to llvm and fails. -- Doug Goldstein signature.asc Description: OpenPGP digital signature ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] libxl: libxl_domain_create_restore has an extra argument

2016-04-06 Thread Doug Goldstein
; params.checkpointed_stream = 0; > ret = libxl_domain_create_restore(cfg->ctx, _config, , >restore_fd, , NULL, > ACK This fixes integration testing that Xen Project does with libvirt and Xen so it would be nice to get in for 1.3.3. -- Doug Goldst

Re: [Xen-devel] [PATCH 2/2] tools: detect appropriate debug optimization level

2016-03-30 Thread Doug Goldstein
On 3/30/16 11:00 AM, Ian Jackson wrote: > Doug Goldstein writes ("Re: [PATCH 2/2] tools: detect appropriate debug > optimization level"): >> On 3/8/16 9:38 AM, Wei Liu wrote: >>> On Mon, Mar 07, 2016 at 08:23:40PM -0600, Doug Goldstein wrote: >>>> T

Re: [Xen-devel] [RFC PATCH 2/2] build: convert crash_debug to Kconfig

2016-03-30 Thread Doug Goldstein
On 3/29/16 3:50 AM, Jan Beulich wrote: >>>> On 25.03.16 at 22:02, <car...@cardoe.com> wrote: >> On 3/25/16 2:49 PM, Konrad Rzeszutek Wilk wrote: >>> On Thu, Mar 24, 2016 at 11:48:19AM -0500, Doug Goldstein wrote: >>>> --- a/xen/Kconfig.debug &g

Re: [Xen-devel] [PATCH] Extending XL console command to take -e option that allows user to change escape character. Previously, Escape character was hardcoded as 0x1d i.e '^]'. Now, User has can provi

2016-03-29 Thread Doug Goldstein
;)) > type = LIBXL_CONSOLE_TYPE_PV; > @@ -3432,13 +3445,18 @@ int main_console(int argc, char **argv) > case 'n': > num = atoi(optarg); > break; > +case 'e': > +escapechar = getEscapeChar(optarg); > +break; > } > > domi

Re: [Xen-devel] [PATCH] build: avoid putting local absolute symbols in symbol tables

2016-03-29 Thread Doug Goldstein
__OBJECT_FILE__="$@"' > > CFLAGS-$(verbose) += -DVERBOSE > This was committed as 607044bf9a8c8a8b37666a3a64c0d9b005875b13 and breaks the build on clang. https://travis-ci.org/xen-project/xen/jobs/11981#L1004 https://travis-ci.org/xen-project/xen/jobs/11982#L1002 -- Doug G

Re: [Xen-devel] [PATCH 2/2] tools: detect appropriate debug optimization level

2016-03-29 Thread Doug Goldstein
On 3/29/16 6:44 AM, George Dunlap wrote: > On Mon, Mar 28, 2016 at 4:01 PM, Doug Goldstein <car...@cardoe.com> wrote: >> On 3/16/16 2:14 PM, Doug Goldstein wrote: >>> On 3/8/16 10:50 AM, Wei Liu wrote: >>>> On Tue, Mar 08, 2016 at 10:34:42AM -0600, Doug Gold

Re: [Xen-devel] [PATCH 2/2] tools: detect appropriate debug optimization level

2016-03-28 Thread Doug Goldstein
On 3/16/16 2:14 PM, Doug Goldstein wrote: > On 3/8/16 10:50 AM, Wei Liu wrote: >> On Tue, Mar 08, 2016 at 10:34:42AM -0600, Doug Goldstein wrote: >>> On 3/8/16 9:38 AM, Wei Liu wrote: >>>> On Mon, Mar 07, 2016 at 08:23:40PM -0600, Doug Goldstein wrote: >

Re: [Xen-devel] [RFC PATCH 2/2] build: convert crash_debug to Kconfig

2016-03-25 Thread Doug Goldstein
On 3/25/16 2:49 PM, Konrad Rzeszutek Wilk wrote: > On Thu, Mar 24, 2016 at 11:48:19AM -0500, Doug Goldstein wrote: >> Convert the crash_debug option to Kconfig as CONFIG_CRASH_DEBUG. This >> was previously togglable on the command line so this adds a message for >> u

Re: [Xen-devel] [RFC PATCH 1/2] build: add debug menu to Kconfig

2016-03-25 Thread Doug Goldstein
On 3/25/16 2:42 PM, Konrad Rzeszutek Wilk wrote: > On Thu, Mar 24, 2016 at 11:48:18AM -0500, Doug Goldstein wrote: >> There are a number of debugging options for Xen so the idea is to have a >> menu to group them all together. >> >> Signed-off-by: Doug G

[Xen-devel] [RFC PATCH 2/2] build: convert crash_debug to Kconfig

2016-03-24 Thread Doug Goldstein
Convert the crash_debug option to Kconfig as CONFIG_CRASH_DEBUG. This was previously togglable on the command line so this adds a message for users enabling it from the command line to tell them to enable it from make menuconfig. Signed-off-by: Doug Goldstein <car...@cardoe.

[Xen-devel] [RFC PATCH 1/2] build: add debug menu to Kconfig

2016-03-24 Thread Doug Goldstein
There are a number of debugging options for Xen so the idea is to have a menu to group them all together. Signed-off-by: Doug Goldstein <car...@cardoe.com> --- This is more of an RFC than a merge request. If this seems reasonable I'll add all the other debugging options under this menu a

Re: [Xen-devel] Interested to participate in Outreachy Program

2016-03-23 Thread Doug Goldstein
m = atoi(optarg); > break; > +case 'e': > +escapechar = getEscapeChar(optarg); > +break; > } > > domid = find_domain(argv[optind]); > if (!type) > -libxl_primary_console_exec(ctx, domid); > -else > -libxl_cons

Re: [Xen-devel] Interested to participate in Outreachy Program

2016-03-23 Thread Doug Goldstein
bout rust language. > > > Regards, > -Sabiya > ​ > Sabiya, I'll take a look but you will definitely want to take a look at the contributing guidelines [1] and resubmit the patch following the guidelines so that we can include it. [1] http://www.xenproject.org/help/contribution

Re: [Xen-devel] [PATCH v2 1/2] xsm: only define XSM_MAGIC in xsm.h

2016-03-22 Thread Doug Goldstein
On 3/16/16 2:18 PM, Doug Goldstein wrote: > Rather than have XSM_MAGIC set in the global xen/config.h and set in > xsm.h if it's unset, just set it once in xsm.h since its only used in > files that already include xsm.h > > Signed-off-by: Doug Goldstein <car...@cardoe.com>

[Xen-devel] [PATCH] xenconsole: update help message

2016-03-22 Thread Doug Goldstein
The help message did not include information about the --type parameter. Signed-off-by: Doug Goldstein <car...@cardoe.com> --- CC: Ian Jackson <ian.jack...@eu.citrix.com> CC: Stefano Stabellini <stefano.stabell...@eu.citrix.com> CC: Wei Liu <wei.l...@citrix.com> --- too

Re: [Xen-devel] Interested to participate in Outreachy Program

2016-03-22 Thread Doug Goldstein
;>> >>> I have attached logs for reference. >>> Before this step, I could not setup Linux Bridge Network for Guest >>> networking. >>> I am using my router for internet connection.Can this will be problem? >>> Ca

Re: [Xen-devel] [PATCH v3 01/28] xen/x86: Drop unused and non-useful feature definitions

2016-03-22 Thread Doug Goldstein
gt; > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> > --- Reviewed-by: Doug Goldstein <car...@cardoe.com> This patch seems to be a general improvement and doesn't cause other regressions without the rest of the series so can we merged this one. -- Doug

[Xen-devel] [PATCH v2] docs: update FLASK cmd line instructions

2016-03-20 Thread Doug Goldstein
The command line instructions for FLASK include a note on how to compile Xen with FLASK but the note was out of date after the change to Kconfig. Signed-off-by: Doug Goldstein <car...@cardoe.com> --- CC: Ian Jackson <ian.jack...@eu.citrix.com> CC: Jan Beulich <jbeul...@suse.com&g

[Xen-devel] [PATCH v2 2/2] xsm: move FLASK_AVC_STATS to Kconfig

2016-03-20 Thread Doug Goldstein
Have Kconfig set CONFIG_FLASK_AVC_STATS and prefix all uses with CONFIG_ to use the Kconfig variable. Signed-off-by: Doug Goldstein <car...@cardoe.com> Acked-by: Daniel De Graaf <dgde...@tycho.nsa.gov> --- CC: Daniel De Graaf <dgde...@tycho.nsa.gov> --- xen/common/Kc

[Xen-devel] [PATCH v3 2/3] tmem: drop direct usage of opt_tmem

2016-03-20 Thread Doug Goldstein
not directly check opt_tmem but instead use the tmem_enabled() helper function. Signed-off-by: Doug Goldstein <car...@cardoe.com> Acked-by: Jan Beulich <jbeul...@suse.com> --- CC: Keir Fraser <k...@xen.org> CC: Jan Beulich <jbeul...@suse.com> CC: Andrew Cooper <andrew.coo

Re: [Xen-devel] [PATCH 2/2] tools: detect appropriate debug optimization level

2016-03-19 Thread Doug Goldstein
On 3/8/16 10:50 AM, Wei Liu wrote: > On Tue, Mar 08, 2016 at 10:34:42AM -0600, Doug Goldstein wrote: >> On 3/8/16 9:38 AM, Wei Liu wrote: >>> On Mon, Mar 07, 2016 at 08:23:40PM -0600, Doug Goldstein wrote: >>>> The build should not use -O0 as t

[Xen-devel] [PATCH v3 0/3] Allow tmem to be disabled via Kconfig

2016-03-19 Thread Doug Goldstein
Allows expert users to disable tmem via Kconfig. Incorporates feedback from Jan and Konrad. Patch 2 & 3 from v1 were merged and patch 4 was dropped. Doug Goldstein (3): tmem: add tmem_disable() function tmem: drop direct usage of opt_tmem tmem: allow tmem to be disabled with Kconfig

Re: [Xen-devel] [PATCH v2 3/3] tmem: allow tmem to be disabled with Kconfig

2016-03-19 Thread Doug Goldstein
On 3/16/16 3:47 AM, Jan Beulich wrote: >>>> On 15.03.16 at 21:18, <car...@cardoe.com> wrote: >> Wrap the various tmem functions with the Kconfig generated CONFIG_TMEM >> option allowing users to build Xen without tmem support. >> >> Signed-off-by: Doug

[Xen-devel] [PATCH v3 1/3] tmem: add tmem_disable() function

2016-03-19 Thread Doug Goldstein
Instead of manipulating the opt_tmem variable directly utilize a wrapper function. Signed-off-by: Doug Goldstein <car...@cardoe.com> Acked-by: Jan Beulich <jbeul...@suse.com> --- CC: Keir Fraser <k...@xen.org> CC: Jan Beulich <jbeul...@suse.com> CC: Andrew Cooper <an

Re: [Xen-devel] [PATCH 2/2] xsm: move FLASK_AVC_STATS to Kconfig

2016-03-19 Thread Doug Goldstein
On 3/14/16 9:05 AM, Doug Goldstein wrote: > On 3/8/16 12:01 PM, Daniel De Graaf wrote: >> On 03/08/2016 11:51 AM, Jan Beulich wrote: >>>>>> On 08.03.16 at 17:22, <dgde...@tycho.nsa.gov> wrote: >>>> On 03/08/2016 04:46 AM, Jan Beulich wrote: >>>

[Xen-devel] [PATCH v2 1/2] xsm: only define XSM_MAGIC in xsm.h

2016-03-19 Thread Doug Goldstein
Rather than have XSM_MAGIC set in the global xen/config.h and set in xsm.h if it's unset, just set it once in xsm.h since its only used in files that already include xsm.h Signed-off-by: Doug Goldstein <car...@cardoe.com> --- CC: Daniel De Graaf <dgde...@tycho.nsa.gov> --- xen

Re: [Xen-devel] [PATCH] docs: update FLASK cmd line instructions

2016-03-19 Thread Doug Goldstein
On 3/15/16 3:43 PM, Konrad Rzeszutek Wilk wrote: > On Tue, Mar 15, 2016 at 03:40:19PM -0500, Doug Goldstein wrote: >> On 3/15/16 3:24 PM, Konrad Rzeszutek Wilk wrote: >>> On Mon, Mar 14, 2016 at 07:37:39PM -0500, Doug Goldstein wrote: >>>> The command line instruc

Re: [Xen-devel] [PATCH v4 04/14] firmware/makefile: install BIOS blob ...

2016-03-19 Thread Doug Goldstein
tall this as "seabios.bin" when the default is "bios.bin". Most distro's packages for SeaBIOS install it as "bios.bin" > +endif > +endif > +ifeq ($(CONFIG_OVMF),y) > +ifeq ($(OVMF_PATH),) > + $(INSTALL_DATA) $(OVMF_ROM) $

[Xen-devel] [PATCH v3 3/3] tmem: allow tmem to be disabled with Kconfig

2016-03-18 Thread Doug Goldstein
Wrap the various tmem functions with the Kconfig generated CONFIG_TMEM option allowing users to build Xen without tmem support. Signed-off-by: Doug Goldstein <car...@cardoe.com> Acked-by: Jan Beulich <jbeul...@suse.com> --- CC: Keir Fraser <k...@xen.org> CC: Jan Beulich <

Re: [Xen-devel] [PATCH v4 04/14] firmware/makefile: install BIOS blob ...

2016-03-18 Thread Doug Goldstein
On 3/17/16 1:33 PM, Anthony PERARD wrote: > On Thu, Mar 17, 2016 at 12:37:36PM -0500, Doug Goldstein wrote: >> On 3/14/16 12:55 PM, Anthony PERARD wrote: >>> ... into the firmware directory, along with hvmloader. >>> >>> Signed-off-by: Anthony PERARD <anthon

Re: [Xen-devel] help

2016-03-15 Thread Doug Goldstein
problems with the image you are using so you'll likely run into more but those look like Linux/distro related problems. Please make sure you reply to the list if you do reply to this. -- Doug Goldstein signature.asc Description: OpenPGP digital signature ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] docs: update FLASK cmd line instructions

2016-03-15 Thread Doug Goldstein
On 3/15/16 3:24 PM, Konrad Rzeszutek Wilk wrote: > On Mon, Mar 14, 2016 at 07:37:39PM -0500, Doug Goldstein wrote: >> The command line instructions for FLASK include a note on how to compile >> Xen with FLASK but the note was out of date after the change to Kconfig. >> &

[Xen-devel] [PATCH v2 3/3] tmem: allow tmem to be disabled with Kconfig

2016-03-15 Thread Doug Goldstein
Wrap the various tmem functions with the Kconfig generated CONFIG_TMEM option allowing users to build Xen without tmem support. Signed-off-by: Doug Goldstein <car...@cardoe.com> --- CC: Keir Fraser <k...@xen.org> CC: Jan Beulich <jbeul...@suse.com> CC: Andrew Cooper <andrew.c

[Xen-devel] [PATCH v2 1/3] tmem: add tmem_disable() function

2016-03-15 Thread Doug Goldstein
Instead of manipulating the opt_tmem variable directly utilize a wrapper function. Signed-off-by: Doug Goldstein <car...@cardoe.com> Acked-by: Jan Beulich <jbeul...@suse.com> --- CC: Keir Fraser <k...@xen.org> CC: Jan Beulich <jbeul...@suse.com> CC: Andrew Cooper <an

[Xen-devel] [PATCH v2 0/3] Allow tmem to be disabled via Kconfig

2016-03-15 Thread Doug Goldstein
Allows expert users to disable tmem via Kconfig. Incorporates feedback from Jan and Konrad. Patch 2 & 3 from v1 were merged and patch 4 was dropped. Doug Goldstein (3): tmem: add tmem_disable() function tmem: drop direct usage of opt_tmem tmem: allow tmem to be disabled with Kconfig

[Xen-devel] [PATCH v2 2/3] tmem: drop direct usage of opt_tmem

2016-03-15 Thread Doug Goldstein
Don't use the opt_tmem variable to check if tmem is enabled, instead use the tmem_enabled() helper function everywhere. Signed-off-by: Doug Goldstein <car...@cardoe.com> --- CC: Keir Fraser <k...@xen.org> CC: Jan Beulich <jbeul...@suse.com> CC: Andrew Cooper <andrew.coop...@c

Re: [Xen-devel] [PATCH 5/5] tmem: allow tmem to be disabled with Kconfig

2016-03-15 Thread Doug Goldstein
all.h, next to the function declaration? > Actually I tried this and it doesn't compile because that header isn't included. Including that header into the relevant files (entry.S) doesn't work either. Got a different suggestion? -- Doug Goldstein signature.asc Description: OpenPGP digital

Re: [Xen-devel] [PATCH 5/5] tmem: allow tmem to be disabled with Kconfig

2016-03-15 Thread Doug Goldstein
percall.h, next to the function declaration? We can do this but I'd like to move the other ones from entry.S into here as well in a follow on then. -- Doug Goldstein signature.asc Description: OpenPGP digital signature ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] Interested to participate in Outreachy Program

2016-03-15 Thread Doug Goldstein
ntly the escape sequence is hardcoded to "Ctrl-]". The input should be "-e escapechar" where the new escape sequence is "Ctrl-escapechar". Let me know if this makes sense and if it sounds like something you'd like to tackle and I can follow up with your further on a test env

[Xen-devel] [PATCH] docs: update FLASK cmd line instructions

2016-03-14 Thread Doug Goldstein
The command line instructions for FLASK include a note on how to compile Xen with FLASK but the note was out of date after the change to Kconfig. Signed-off-by: Doug Goldstein <car...@cardoe.com> --- CC: Ian Jackson <ian.jack...@eu.citrix.com> CC: Jan Beulich <jbeul...@suse.com&g

[Xen-devel] [PATCH 3/5] tmem: make tmem_freeable_pages() check tmem status

2016-03-14 Thread Doug Goldstein
Most callers of tmem_freeable_pages() checked to see if tmem was enabled before calling tmem_freeable_pages() but not all of them did. This seemed like an oversight and to avoid similar situations like that, stick the check of tmem into tmem_freeable_pages(). Signed-off-by: Doug Goldstein <

[Xen-devel] [PATCH 1/5] tmem: add tmem_disable() function

2016-03-14 Thread Doug Goldstein
Instead of manipulating the opt_tmem variable directly utilize a wrapper function. Signed-off-by: Doug Goldstein <car...@cardoe.com> --- CC: Keir Fraser <k...@xen.org> CC: Jan Beulich <jbeul...@suse.com> CC: Andrew Cooper <andrew.coop...@citrix.com> CC: Konrad

[Xen-devel] [PATCH 2/5] tmem: drop direct usage of opt_tmem

2016-03-14 Thread Doug Goldstein
Don't use the opt_tmem variable to check if tmem is enabled, instead use the tmem_enabled() helper function everywhere. Signed-off-by: Doug Goldstein <car...@cardoe.com> --- CC: Keir Fraser <k...@xen.org> CC: Jan Beulich <jbeul...@suse.com> CC: Andrew Cooper <andrew.coop...@c

[Xen-devel] [PATCH 4/5] tmem: don't assume stdbool.h is included

2016-03-14 Thread Doug Goldstein
tmem_xen.h assumes that all users will have already included stdbool.h which might not always be true. Signed-off-by: Doug Goldstein <car...@cardoe.com> --- CC: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> --- xen/include/xen/tmem_xen.h | 1 + 1 file changed, 1 insertion(+) diff

[Xen-devel] [PATCH 5/5] tmem: allow tmem to be disabled with Kconfig

2016-03-14 Thread Doug Goldstein
Wrap the various tmem functions with the Kconfig generated CONFIG_TMEM option allowing users to build Xen without tmem support. Signed-off-by: Doug Goldstein <car...@cardoe.com> --- CC: Keir Fraser <k...@xen.org> CC: Jan Beulich <jbeul...@suse.com> CC: Andrew Cooper <andrew.c

[Xen-devel] [PATCH 0/5] Allow tmem to be disabled via Kconfig

2016-03-14 Thread Doug Goldstein
. Doug Goldstein (5): tmem: add tmem_disable() function tmem: drop direct usage of opt_tmem tmem: make tmem_freeable_pages() check tmem status tmem: don't assume stdbool.h is included tmem: allow tmem to be disabled with Kconfig xen/arch/x86/hvm/hvm.c | 4 xen/arch/x86

Re: [Xen-devel] [PATCH 2/2] xsm: move FLASK_AVC_STATS to Kconfig

2016-03-14 Thread Doug Goldstein
s a Kconfig option in Linux. >>> >>> Acked-by: Daniel De Graaf <dgde...@tycho.nsa.gov> >> >> ... if you're fine with it, we'll put it in (once the mechanical issues >> got addressed). > Daniel, Would you like me to make this a real configuration option? Or proc

Re: [Xen-devel] XSM permissive by default.

2016-03-10 Thread Doug Goldstein
On 3/10/16 11:10 AM, Konrad Rzeszutek Wilk wrote: > On Wed, Mar 09, 2016 at 08:40:05PM -0600, Doug Goldstein wrote: >> On 3/9/16 4:09 PM, Daniel De Graaf wrote: >>> On 03/09/2016 04:17 PM, Konrad Rzeszutek Wilk wrote: >>>> On Wed, Mar 09, 2016 at 01:24:15PM +, An

Re: [Xen-devel] [PATCH 1/2] libxl: ensure var is inited in libxl__domain_firmware

2016-03-10 Thread Doug Goldstein
On 3/8/16 9:38 AM, Wei Liu wrote: > On Mon, Mar 07, 2016 at 08:23:39PM -0600, Doug Goldstein wrote: >> Some versions of GCC complain that the 'firmware' variable can be used >> uninitialized. It looks like the switch inside of the else case is just >> confusing GCC. >

Re: [Xen-devel] XSM permissive by default.

2016-03-09 Thread Doug Goldstein
h some domDs and one of them needs to be up to fetch your policy? Just a hypothetical. XSMs like LSMs just aren't meant to be swapped around at runtime and like Daniel points out if go down the road of swapping to the dummy module there could be further dragons and whose to say someone won't look at

Re: [Xen-devel] XSM permissive by default.

2016-03-08 Thread Doug Goldstein
t so I think that's the most sane default. Being in a worse state than if you had built without it. Machon, Something to consider for the Yocto builds as well. -- Doug Goldstein signature.asc Description: OpenPGP digital signature ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 2/2] tools: detect appropriate debug optimization level

2016-03-08 Thread Doug Goldstein
On 3/8/16 9:38 AM, Wei Liu wrote: > On Mon, Mar 07, 2016 at 08:23:40PM -0600, Doug Goldstein wrote: >> The build should not use -O0 as that results in miscompilations. There > > This needs some (concrete) references. Is that a known issue in gcc? If > so can you reference the b

Re: [Xen-devel] test

2016-03-08 Thread Doug Goldstein
> In case it makes it to the list: please ignore. :-) > > > Juergen FWIW, I've been getting a lot of bounces from SUSE's mail servers in general in the last 2 weeks. -- Doug Goldstein signature.asc Description: OpenPGP digital signature

[Xen-devel] [PATCH 2/2] tools: detect appropriate debug optimization level

2016-03-07 Thread Doug Goldstein
is the default. This change undoes the change from -O1 to -O0 in 1166ecf781b1016eaa61f8d5ba4fb1fde9d599b6. Signed-off-by: Doug Goldstein <car...@cardoe.com> --- CC: Ian Jackson <ian.jack...@eu.citrix.com> CC: Stefano Stabellini <stefano.stabell...@eu.citrix.com> CC: Wei Liu <wei.l...@c

[Xen-devel] [PATCH 1/2] libxl: ensure var is inited in libxl__domain_firmware

2016-03-07 Thread Doug Goldstein
Some versions of GCC complain that the 'firmware' variable can be used uninitialized. It looks like the switch inside of the else case is just confusing GCC. Signed-off-by: Doug Goldstein <car...@cardoe.com> --- CC: Ian Jackson <ian.jack...@eu.citrix.com> CC: Stefano Stabellini <

[Xen-devel] [PATCH 2/2] xsm: move FLASK_AVC_STATS to Kconfig

2016-03-07 Thread Doug Goldstein
Have Kconfig set CONFIG_FLASK_AVC_STATS and prefix all uses with CONFIG_ to use the Kconfig variable. Signed-off-by: Doug Goldstein <car...@cardoe.com> --- CC: Daniel De Graaf <dgde...@tycho.nsa.gov> --- xen/common/Kconfig | 8 +++- xen/include/xen/config.h| 5 --

[Xen-devel] [PATCH 1/2] xsm: move the XSM_MAGIC value to Kconfig

2016-03-07 Thread Doug Goldstein
Let Kconfig set the XSM_MAGIC value for us. Signed-off-by: Doug Goldstein <car...@cardoe.com> --- CC: Daniel De Graaf <dgde...@tycho.nsa.gov> --- xen/common/Kconfig | 8 xen/include/xen/config.h | 1 - xen/include/xsm/xsm.h| 5 + xen/xsm/xsm_core.c | 4 +

Re: [Xen-devel] [PATCH] libxc: simplify error handling in meminit_hvm

2016-03-07 Thread Doug Goldstein
On 3/3/16 10:09 AM, Wei Liu wrote: > The hunk that prints out error message can only be reached from the loop > that allocates memory. Move that hunk into the loop to avoid confusing > gcc. > > Reported-by: Doug Goldstein <car...@cardoe.com> > Signed-off-by: Wei

Re: [Xen-devel] [PATCH] xen/mm: Fix page_list_* helpers to evaluate all their arguments

2016-03-05 Thread Doug Goldstein
with an explicit typecast to remove constness. > > While editing this area, correct the return type of page_list_empty from int > to bool_t. > > Reported-by: Doug Goldstein <car...@cardoe.com> > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> Reviewed-by: Dou

[Xen-devel] [PATCH v2 3/3] travis: actually disable debug for non-debug

2016-03-04 Thread Doug Goldstein
Non-debug builds need to explicitly disable debug due to debug being defaulted to y in Config.mk Signed-off-by: Doug Goldstein <car...@cardoe.com> --- CC: Ian Jackson <ian.jack...@eu.citrix.com> CC: Jan Beulich <jbeul...@suse.com> CC: Keir Fraser <k...@xen.org> CC: Tim

[Xen-devel] [PATCH v2 2/3] travis: use matching C++ for GCC version

2016-03-04 Thread Doug Goldstein
support older versions of bash in use by the test machines. While we're at it simply how we select our compiler. Signed-off-by: Doug Goldstein <car...@cardoe.com> --- CC: Ian Jackson <ian.jack...@eu.citrix.com> CC: Jan Beulich <jbeul...@suse.com> CC: Keir Fraser <k...@xen.o

[Xen-devel] [PATCH v2 1/3] travis: skip building coverity, smoke, and master

2016-03-04 Thread Doug Goldstein
Skip building of the coverity, smoke, stable, and master branches since they just fast forward from staging. Suggested-by: Andrew Cooper <andrew.coop...@citrix.com> Signed-off-by: Doug Goldstein <car...@cardoe.com> --- CC: Ian Jackson <ian.jack...@eu.citrix.com> CC: Jan Beulich

Re: [Xen-devel] [PATCH 3/3] travis: actually disable debug for non-debug

2016-03-04 Thread Doug Goldstein
On 3/4/16 9:56 AM, Doug Goldstein wrote: > On 3/4/16 8:46 AM, Doug Goldstein wrote: >> Non-debug builds need to explicitly disable debug due to debug being >> defaulted to y in Config.mk >> >> Signed-off-by: Doug Goldstein <car...@cardoe.com> >> --- >&g

Re: [Xen-devel] [PATCH 3/3] travis: actually disable debug for non-debug

2016-03-04 Thread Doug Goldstein
On 3/4/16 8:46 AM, Doug Goldstein wrote: > Non-debug builds need to explicitly disable debug due to debug being > defaulted to y in Config.mk > > Signed-off-by: Doug Goldstein <car...@cardoe.com> > --- > CC: Ian Jackson <ian.jack...@eu.citrix.com> > CC: Jan Beuli

Re: [Xen-devel] [PATCH 1/3] travis: skip building coverity, smoke, and master

2016-03-04 Thread Doug Goldstein
On 3/4/16 9:30 AM, Andrew Cooper wrote: > On 04/03/16 14:46, Doug Goldstein wrote: >> Skip building of the coverity, smoke and master branches since they just >> fast forward from staging. >> >> Suggested-by: Andrew Cooper <andrew.coop...@citrix.com> >

Re: [Xen-devel] [PATCH 1/3] travis: skip building coverity, smoke, and master

2016-03-04 Thread Doug Goldstein
> > Jan > Yes. I can fix that up. Let me post a v2 and actually test it. They don't use globbing or wildcards but instead "Ruby regular expression syntax". I can't say I know Ruby so it might take one or two tries to get the pattern right. The other two patches in this series c

[Xen-devel] [PATCH 3/3] travis: actually disable debug for non-debug

2016-03-04 Thread Doug Goldstein
Non-debug builds need to explicitly disable debug due to debug being defaulted to y in Config.mk Signed-off-by: Doug Goldstein <car...@cardoe.com> --- CC: Ian Jackson <ian.jack...@eu.citrix.com> CC: Jan Beulich <jbeul...@suse.com> CC: Keir Fraser <k...@xen.org> CC: Tim

[Xen-devel] [PATCH 1/3] travis: skip building coverity, smoke, and master

2016-03-04 Thread Doug Goldstein
Skip building of the coverity, smoke and master branches since they just fast forward from staging. Suggested-by: Andrew Cooper <andrew.coop...@citrix.com> Signed-off-by: Doug Goldstein <car...@cardoe.com> --- CC: Ian Jackson <ian.jack...@eu.citrix.com> CC: Jan Beulich <

[Xen-devel] [PATCH 2/3] travis: use matching C++ for GCC version

2016-03-04 Thread Doug Goldstein
support older versions of bash in use by the test machines. While we're at it simply how we select our compiler. Signed-off-by: Doug Goldstein <car...@cardoe.com> --- CC: Ian Jackson <ian.jack...@eu.citrix.com> CC: Jan Beulich <jbeul...@suse.com> CC: Keir Fraser <k...@xen.o

Re: [Xen-devel] [PATCH 4/4] hvmloader: Use xen/errno.h rather than the host systems errno.h

2016-03-02 Thread Doug Goldstein
cter toolchains where requesting -fno-builtin does > reduce the include path as much as it can. > > Reported-by: Doug Goldstein <car...@cardoe.com> > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> Reviewed-by: Doug Goldstein <car...@cardoe.com> > --- > CC:

Re: [Xen-devel] [PATCH 3/4] xen/errno: Reduce complexity of inclusion

2016-03-01 Thread Doug Goldstein
t what is going on. > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> Reviewed-by: Doug Goldstein <car...@cardoe.com> > --- > CC: Jan Beulich <jbeul...@suse.com> > CC: Tim Deegan <t...@xen.org> > CC: Doug Goldstein <

Re: [Xen-devel] [PATCH 2/4] xen/errno: Declare aliases using XEN_ERRNO()

2016-03-01 Thread Doug Goldstein
On 3/1/16 12:57 PM, Andrew Cooper wrote: > Otherwise a custom XEN_ERRNO definition will not end up creating appropriately > namespaced constants for the aliases. > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> Reviewed-by: Doug Goldstein <car...@cardoe.com>

Re: [Xen-devel] [PATCH 1/4] xen/errno: Introduce EISDIR/EROFS/ENOTEMPTY to the ABI

2016-03-01 Thread Doug Goldstein
On 3/1/16 12:57 PM, Andrew Cooper wrote: > These POSIX errnos are expected by other areas of the Xen public interface, > specifically public/io/xs_wire.h > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> Reviewed-by: Doug Goldstein <car...@cardoe.com> > -

Re: [Xen-devel] [PATCH] travis: add IRC notifications

2016-02-29 Thread Doug Goldstein
On 2/23/16 3:33 AM, George Dunlap wrote: > On Mon, Feb 22, 2016 at 7:03 PM, Konrad Rzeszutek Wilk > <konrad.w...@oracle.com> wrote: >> On Mon, Feb 22, 2016 at 06:39:26PM +, Lars Kurth wrote: >>> >>>> On 22 Feb 2016, at 18:34, Doug Goldstein <car...@car

[Xen-devel] [PATCH] config: remove unused EXPORT_SYMBOL_GPL

2016-02-29 Thread Doug Goldstein
EXPORT_SYMBOL_GPL is unused in the source tree so just remove it. If something gets imported that needs it, it can be added back then. Signed-off-by: Doug Goldstein <car...@cardoe.com> --- CC: Ian Jackson <ian.jack...@eu.citrix.com> CC: Jan Beulich <jbeul...@suse.com>

Re: [Xen-devel] [PATCH] libxc: Expose the MPX cpuid flag to guest

2016-02-29 Thread Doug Goldstein
ers. >> >> Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com> >> >> Looks like the hypervisor side is all present. >> >> ~Andrew > > Is there anyone who can help to make this patch merged? It's pending for a > long time. > > Liang > Ping

[Xen-devel] [PATCH 2/2] build: consolidate CONFIG_HAS_VIDEO and CONFIG_VIDEO

2016-02-29 Thread Doug Goldstein
No real advantage to keeping these separate. The use case of this from Linux is when the platform or target board has support for something but the user wants to be given the option to disable it. Signed-off-by: Doug Goldstein <car...@cardoe.com> --- CC: Ian Campbell <ian.campb...@citri

[Xen-devel] [PATCH 1/2] build: consolidate CONFIG_HAS_VGA and CONFIG_VGA

2016-02-29 Thread Doug Goldstein
No real advantage to keeping these separate. The use case of this from Linux is when the platform or target board has support for something but the user wants to be given the option to disable it. Signed-off-by: Doug Goldstein <car...@cardoe.com> --- CC: Keir Fraser <k...@xen.org> CC:

Re: [Xen-devel] staging: libxl compile error in libxl__domain_save

2016-02-28 Thread Doug Goldstein
On 2/28/16 8:10 AM, Andrew Cooper wrote: > On 28/02/16 02:01, Doug Goldstein wrote: >> On 2/27/16 2:14 AM, Olaf Hering wrote: >> The relevant patch is here and still waiting for an ACK: >> >> http://lists.xen.org/archives/html/xen-devel/2016-02/msg02715.html >> &

Re: [Xen-devel] staging: libxl compile error in libxl__domain_save

2016-02-27 Thread Doug Goldstein
g/archives/html/xen-devel/2016-02/msg02715.html Once that gets merged and I can enable tools building on Travis then yes it would catch it. -- Doug Goldstein signature.asc Description: OpenPGP digital signature ___ Xen-devel mailing list Xen-devel@l

<    1   2   3   4   5   6   7   8   9   10   >