Re: [Xen-devel] [PATCH RFC 02/12] x86/np2m: add np2m_flush_eptp()

On 18.07.17 12:34, Sergey Dyasli wrote: > The new function finds all np2m objects with the specified eptp and > flushes them. p2m_flush_table_locked() is added in order not to release > the p2m lock after np2m_base check. > > Signed-off-by: Sergey Dyasli > --- >

Re: [Xen-devel] [PATCH] MAINTAINERS: drop Christoph Egger

On 08.03.17 09:45, Jan Beulich wrote: > Other Amazon folks indicate he's not available as a maintainer anymore > at this point in time. Maintenance of the MCE sub-component will fall > back to the x86 maintainers. > > Signed-off-by: Jan Beulich Acked-by: Christoph Egger

Re: [Xen-devel] [PATCH v3] x86/mce: handle reserved domain ID in XEN_MC_msrinject

On 27.05.16 15:30, Haozhong Zhang wrote: > Commit 26646f3 "x86/mce: translate passed-in GPA to host machine > address" and commit 4ddf474 "tools/xen-mceinj: Pass in GPA when > injecting through MSR_MCI_ADDR" forgot to consider reserved domain > ID and mistakenly add MC_MSRINJ_F_GPADDR flag for

Re: [Xen-devel] [PATCH] x86/mce: handle DOMID_XEN properly in XEN_MC_msrinject

On 26/05/16 03:07, Haozhong Zhang wrote: > Commit 26646f3 "x86/mce: translate passed-in GPA to host machine > address" forgot to consider dom_xen, which fails tools/xen-mceinj when > it's going to inject into domain DOMID_XEN (e.g. when -d option is not > used) via XEN_MC_msrinject. Use dom_xen

Re: [Xen-devel] hap_invlpg() vs INVLPGA

On 01/02/16 09:04, Jan Beulich wrote: >>> This, otoh, reads as if you imply we intercept the L2's INVLPG. >>> Yet the INVLPG intercept gets cleared when the domain uses >>> NPT (and your original change also didn't alter any intercept >>> settings). Hence I'm still lost how hap_invlpg() can be

Re: [Xen-devel] hap_invlpg() vs INVLPGA

On 01/02/16 10:00, Jan Beulich wrote: On 01.02.16 at 09:14, wrote: >> On 01/02/16 09:04, Jan Beulich wrote: > This, otoh, reads as if you imply we intercept the L2's INVLPG. > Yet the INVLPG intercept gets cleared when the domain uses > NPT (and your original

Re: [Xen-devel] hap_invlpg() vs INVLPGA

On 29/01/16 14:57, Egger, Christoph wrote: > On 29/01/16 14:24, Jan Beulich wrote: >> Christoph, >> >> in commit dd6de3ab99 ("Implement Nested-on-Nested") you added >> code to hap_invlpg() supposedly emulating INVLPGA. I've been >> stumbling across th

Re: [Xen-devel] hap_invlpg() vs INVLPGA

On 29/01/16 14:24, Jan Beulich wrote: > Christoph, > > in commit dd6de3ab99 ("Implement Nested-on-Nested") you added > code to hap_invlpg() supposedly emulating INVLPGA. I've been > stumbling across this a number of times in the past, not being able > to make the connection between (a) VMX/EPT

Re: [Xen-devel] hap_invlpg() vs INVLPGA

On 29/01/16 16:53, Jan Beulich wrote: >>>> On 29.01.16 at 15:02, <cheg...@amazon.de> wrote: >> On 29/01/16 14:57, Egger, Christoph wrote: >>> On 29/01/16 14:24, Jan Beulich wrote: >>>> Christoph, >>>> >>>> in commit dd6de3

Re: [Xen-devel] [PATCH] x86/mce: fix misleading indentation in init_nonfatal_mce_checker().

On 22/01/16 15:47, Andrew Cooper wrote: > On 22/01/16 14:38, Ian Campbell wrote: >> Debian bug 812166[0] reported this build failure due to >> Wmisleading-indentation with gcc-6: >> >> non-fatal.c: In function 'init_nonfatal_mce_checker': >> non-fatal.c:103:2: error: statement is indented as if it

Re: [Xen-devel] [PATCH v4 04/10] x86/hvm: Collect information of TSC scaling ratio

On 17/01/16 22:58, Haozhong Zhang wrote: > Both VMX TSC scaling and SVM TSC ratio use the 64-bit TSC scaling ratio, > but the number of fractional bits of the ratio is different between VMX > and SVM. This patch adds the architecture code to collect the number of > fractional bits and other

Re: [Xen-devel] [PATCH XEN v6 20/32] tools/libs/foreignmemory: Support err == NULL to map.

On 2015/12/09 13:22, Wei Liu wrote: > On Thu, Dec 03, 2015 at 11:22:17AM +, Ian Campbell wrote: >> The existing xc_map_foreign_bulk-like interface encourages callers to >> miss error checking for partial failure (by forgetting to scan the err >> array). >> >> Add support for passing err==NULL

Re: [Xen-devel] [PATCH v2 00/14] Add VMX TSC scaling support

Did you consider nested virtualization? L1 hypervisor may have a different tsc scaling and L2 guest again may have a different tsc scale ratio. Christoph On 2015/12/06 22:14, Haozhong Zhang wrote: > I have tested this patchset on both Intel and AMD systems. > > For the test on AMD systems, I

Re: [Xen-devel] [PATCH v2 4/4] tools/xen-mceinj: Pass in GPA when injecting through MSR_MCI_ADDR

On 2015/09/16 7:35, Haozhong Zhang wrote: > This patch removes the address translation in xen-mceinj which > translates the guest physical address passed-in through the argument of > '-p' to the host machine address. Instead, xen-mceinj now passes a flag > MC_MSRINJ_F_GPADDR to ask do_mca() in the

Re: [Xen-devel] [PATCH v2 1/4] x86/mce: Fix code style

On 2015/09/16 7:35, Haozhong Zhang wrote: > Remove trailing whitespaces and fix indentations in mce.c and xen_mca.h. > > Signed-off-by: Haozhong Zhang Acked-by: Christoph Egger > --- > xen/arch/x86/cpu/mcheck/mce.c | 10 +- >

Re: [Xen-devel] [PATCH v2 3/4] x86/mce: Translate passed-in GPA to host machine address

On 2015/09/16 7:35, Haozhong Zhang wrote: > This patch adds a new flag MC_MSRINJ_F_GPADDR to > xen_mc_msrinject.mcinj_flags, and makes do_mca() to translate the > guest physical address passed-in through > xen_mc_msrinject.mcinj_msr[i].value to the host machine address if > this flag is present. >

Re: [Xen-devel] [PATCH v2 2/4] tools/xen-mceinj: Fix code style

On 2015/09/16 7:35, Haozhong Zhang wrote: > Remove trailing whitespaces in xen-mceinj.c. > > Signed-off-by: Haozhong Zhang Acked-by: Christoph Egger > --- > tools/tests/mce-test/tools/xen-mceinj.c | 66 > - > 1

Re: [Xen-devel] [PATCH 2/4] tools/mceinject: Fix code style

On 2015/09/15 10:29, Haozhong Zhang wrote: > Remove trailing spaces in xen-mceinj.c. > > Signed-off-by: Haozhong Zhang Acked-by: Christoph Egger > --- > tools/tests/mce-test/tools/xen-mceinj.c | 16 > 1 file changed, 8

Re: [Xen-devel] [PATCH 1/4] x86/mce: Fix code style

On 2015/09/15 10:29, Haozhong Zhang wrote: > Remove trailing spaces and fix indentations in mce.c and xen-mca.h. > > Signed-off-by: Haozhong Zhang Acked-by: Christoph Egger > --- > xen/arch/x86/cpu/mcheck/mce.c | 10 +- >

Re: [Xen-devel] [PATCH 3/4] x86/mce: Translate passed-in GPA to host machine address

On 2015/09/15 10:29, Haozhong Zhang wrote: > This patch adds a new flag MC_MSRINJ_F_GPADDR to > xen_mc_msrinject.mcinj_flags, and makes do_mca() to translate the > guest physical address passed-in through > xen_mc_msrinject.mcinj_msr[i].value to the host machine address if > this flag is present.

Re: [Xen-devel] [PATCH 4/4] tools/xen-mceinj: Pass in GPA when injecting through MSR_MCI_ADDR

On 2015/09/15 12:02, Wei Liu wrote: > I don't know this piece of code so my comments might be stupid. > > On Tue, Sep 15, 2015 at 04:29:40PM +0800, Haozhong Zhang wrote: >> This patch removes the address translation in xen-mceinj which >> translates the guest physical address passed-in through

Re: [Xen-devel] [PATCH 4/4] tools/xen-mceinj: Pass in GPA when injecting through MSR_MCI_ADDR

On 2015/09/15 10:29, Haozhong Zhang wrote: > This patch removes the address translation in xen-mceinj which > translates the guest physical address passed-in through the argument > of '-p' to the host machine address. > > Signed-off-by: Haozhong Zhang Comments inline.

Re: [Xen-devel] [PATCH 4/4] tools/xen-mceinj: Pass in GPA when injecting through MSR_MCI_ADDR

On 2015/09/15 12:28, Haozhong Zhang wrote: > On Tue, Sep 15, 2015 at 12:17:01PM +0200, Egger, Christoph wrote: >> On 2015/09/15 10:29, Haozhong Zhang wrote: >>> This patch removes the address translation in xen-mceinj which >>> translates the guest physical address pas

Re: [Xen-devel] [PATCH] x86/MCE: allow overriding the CMCI threshold

On 2015/01/12 9:44, Jan Beulich wrote: We've had reports of systems where CMCIs would surface at a relatively high rate during certain periods of time, without them apparently causing subsequent more severe problems (see Xeon E7-8800/4800/2800 specification clarification SC1). Give the admin a

Re: [Xen-devel] [PATCH v4 1/2] gnttab: Introduce rwlock to protect updates to grant table state

On 2015/01/12 16:09, Jan Beulich wrote: On 09.01.15 at 16:12, cheg...@amazon.de wrote: @@ -899,26 +899,27 @@ __gnttab_unmap_common( op-frame = (unsigned long)(op-dev_bus_addr PAGE_SHIFT); +read_lock(lgt-lock); if ( unlikely(op-handle = lgt-maptrack_limit) ) { +

Re: [Xen-devel] [PATCH v3 1/2] gnttab: Introduce rwlock to protect updates to grant table state

On 2015/01/09 15:10, Jan Beulich wrote: On 09.01.15 at 14:05, cheg...@amazon.de wrote: On 2014/12/18 12:37, Jan Beulich wrote: On 03.12.14 at 15:29, cheg...@amazon.de wrote: --- a/xen/common/grant_table.c +++ b/xen/common/grant_table.c [...] @@ -944,6 +944,7 @@ __gnttab_unmap_common(

Re: [Xen-devel] [PATCH 0/2] gnttab: Improve scaleability

On 2014/12/02 12:00, Andrew Cooper wrote: On 02/12/14 10:06, Christoph Egger wrote: This patch series changes the grant table locking to a more fain grained locking protocol. The result is a performance boost measured with blkfront/blkback. Document the locking protocol. [PATCH 1/2] gnttab:

Re: [Xen-devel] [PATCH 1/2] gnttab: Introduce rwlock to protect updates to grant table state

On 2014/12/02 13:35, Julien Grall wrote: Hi Christoph, On 02/12/14 10:06, Christoph Egger wrote: diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index 522c43d..37c13b1 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -4565,7 +4565,7 @@ int xenmem_add_to_physmap_one(

Re: [Xen-devel] [PATCH 1/2] gnttab: Introduce rwlock to protect updates to grant table state

On 2014/12/02 14:08, Julien Grall wrote: Hi, On 02/12/14 13:03, Egger, Christoph wrote: On 2014/12/02 13:35, Julien Grall wrote: Hi Christoph, On 02/12/14 10:06, Christoph Egger wrote: diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index 522c43d..37c13b1 100644 --- a/xen/arch/x86