at used to use AUDIO_FUNC, because there is no intermediate
state using __FUNCTION__.
If I'm reading it correctly, the rebase conflict is limited to a slight
rewording of the commit message for 3/46, and one line in 1/46 to the
definition of AUDIO_FUNC (that will no longer be present)
other compilers than msc and gcc?
>
> Let me rephrase the question: do we really support compilers that don't
> understand __func__? The presence of numerous unconditional uses of
> __func__ in the tree means the answer is no. Let's replace AUDIO_FUNC
> by plain __func__.
Answered e
c
> +++ b/hw/mips/gt64xxx_pci.c
> @@ -33,7 +33,7 @@
> //#define DEBUG
>
> #ifdef DEBUG
> -#define DPRINTF(fmt, ...) fprintf(stderr, "%s: " fmt, __FUNCTION__,
> ##__VA_ARGS__)
> +#define DPRINTF(fmt, ...) fprintf(stderr, "%s: " fmt, __func__,
> ##__VA_ARGS__)
> #else
>
pport for multi-page shared rings")
>
> Signed-off-by: Olaf Hering <o...@aepfle.de>
> ---
> hw/block/xen_disk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <ebl...@redhat.com>
--
Eric Blake, Principal Software Engineer
Re
On 07/28/2017 07:48 AM, Olaf Hering wrote:
> On Fri, Jul 28, Eric Blake wrote:
>
>> This version is prone to multiplication overflow (well, maybe not, but
>> you have to audit for that). Wouldn't it be better to use:
>
> What could go wrong?
> qemu will die
f * sizeof(uint32_t));
This version is prone to multiplication overflow (well, maybe not, but
you have to audit for that). Wouldn't it be better to use:
domids = g_new0(blkdev->nr_ring_ref, uint32_t)
which preserves the safety of g_malloc0_n?
--
Eric Blake, Principal Software Engineer
Red Hat,
the
information to reset requests.
Signed-off-by: Eric Blake <ebl...@redhat.com>
Acked-by: David Gibson <da...@gibson.dropbear.id.au> [ppc parts]
Reviewed-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> [SPARC part]
Reviewed-by: Cornelia Huck <cornelia.h...@de.ibm.com> [s390x part
rid of the weird #defines for VMRESET_*
as synonyms for bools.
Signed-off-by: Eric Blake <ebl...@redhat.com>
---
v9: one more stray FIXME
v8: s/FIXME/TODO/, include SHUTDOWN_CAUSE__MAX now rather than later,
tweak comment on GUEST_SHUTDOWN to mention suspend
v7: drop 'bool report
the
information to reset requests.
Signed-off-by: Eric Blake <ebl...@redhat.com>
Acked-by: David Gibson <da...@gibson.dropbear.id.au> [ppc parts]
Reviewed-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> [SPARC part]
Reviewed-by: Cornelia Huck <cornelia.h...@de.ibm.com> [s390x part
rid of the weird #defines for VMRESET_*
as synonyms for bools.
Signed-off-by: Eric Blake <ebl...@redhat.com>
---
v8: s/FIXME/TODO/, include SHUTDOWN_CAUSE__MAX now rather than later,
tweak comment on GUEST_SHUTDOWN to mention suspend
v7: drop 'bool report' from qemu_system_reset(), reorde
On 05/09/2017 02:20 PM, Eric Blake wrote:
> On 05/09/2017 02:04 PM, Stefano Stabellini wrote:
>> CID: 1374836
>>
>> Signed-off-by: Stefano Stabellini <sstabell...@kernel.org>
>> CC: anthony.per...@citrix.com
>> CC: gr...@kaod.org
>> CC: aneesh.ku...
On 05/09/2017 02:04 PM, Stefano Stabellini wrote:
> Assert that the return value is not an error. This issue was found by
> Coverity.
>
> CID: 1374831
>
> Signed-off-by: Stefano Stabellini <sstabell...@kernel.org>
> CC: gr...@kaod.org
> CC: pbonz...@redhat.com
>
ix.com
> CC: gr...@kaod.org
> CC: aneesh.ku...@linux.vnet.ibm.com
> CC: Eric Blake <ebl...@redhat.com>
> ---
> hw/9pfs/xen-9p-backend.c | 2 +-
> hw/xen/xen_backend.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
Reviewed-by: Eric Blake <ebl...@
gt; 1 file changed, 2 insertions(+)
Reviewed-by: Eric Blake <ebl...@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
___
On 05/09/2017 06:56 AM, Markus Armbruster wrote:
> Eric Blake <ebl...@redhat.com> writes:
>
>> Time to wire up all the call sites that request a shutdown or
>> reset to use the enum added in the previous patch.
>>
>> It would have been less churn to keep
ever calls qemu_set_cloexec(-1) (previously
it would ignore the EBADF failures, now it will abort) - such callers
are arguably broken, so that's okay by me.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
get rid of the weird #defines for VMRESET_*
as synonyms for bools.
Signed-off-by: Eric Blake <ebl...@redhat.com>
---
v7: drop 'bool report' from qemu_system_reset(), reorder enum to put
HOST_ERROR == 1, improve commit message
v6: make ShutdownCause internal-only, add SHUTDOWN_CAUSE_N
the
information to reset requests.
Replay adds a FIXME to preserve the cause across the replay stream,
that will be tackled in the next patch.
Signed-off-by: Eric Blake <ebl...@redhat.com>
Acked-by: David Gibson <da...@gibson.dropbear.id.au> [ppc parts]
Reviewed-by: Mark Cave-Ayland &l
> + F_SETFD, FD_CLOEXEC) == -1) {
> +goto out;
Directly calling fcntl(F_SETFD) without first reading fcntl(F_GETFD) is
(theoretically) incorrect. Better might be using qemu_set_cloexec()
instead of open-coding something.
--
Eric Blake, Principal Software Engineer
Red Hat, In
On 05/08/2017 01:26 PM, Markus Armbruster wrote:
> Eric Blake <ebl...@redhat.com> writes:
>
>> We want to track why a guest was shutdown; in particular, being able
>> to tell the difference between a guest request (such as ACPI request)
>> and host request (suc
On 05/08/2017 12:26 AM, David Gibson wrote:
> On Fri, May 05, 2017 at 02:38:08PM -0500, Eric Blake wrote:
>> Time to wire up all the call sites that request a shutdown or
>> reset to use the enum added in the previous patch.
>>
>> It would have been less ch
-sites that can trigger a reset/shutdown (big
enough that it was worth splitting from this patch).
Signed-off-by: Eric Blake <ebl...@redhat.com>
---
v6: make ShutdownCause internal-only, add SHUTDOWN_CAUSE_NONE so that
comparison to 0 still works, tweak initial FIXME values
v5: no change
the
information to reset requests.
Replay adds a FIXME to preserve the cause across the replay stream,
that will be tackled in the next patch.
Signed-off-by: Eric Blake <ebl...@redhat.com>
Acked-by: David Gibson <da...@gibson.dropbear.id.au> [ppc parts]
Reviewed-by: Mark Cave-Ayland &l
On 04/28/2017 09:42 AM, Markus Armbruster wrote:
> Eric Blake <ebl...@redhat.com> writes:
>
>> We want to track why a guest was shutdown; in particular, being able
>> to tell the difference between a guest request (such as ACPI request)
>> and host request (suc
/02/08/faster-syscall-trap-redux/
makes it sound like the triple-fault = reset is exploited by existing OS
(dating back to days of targetting 286 machines), so it is bare-metal
behavior that we have to faithfully emulate as a guest-triggered reset,
and not something where the guest has wedged itself
ithout a reset - and a triple fault
seems to fall into the category of the guest getting itself wedged
rather than actually trying to reset)? Except patch 3 only used
SHUTDOWN_TYPE_HOST_ERROR in the xen portion of the patch.
So if any x86 expert has an opinion on where triple-fault handling is
emula
On 04/28/2017 03:08 AM, Dr. David Alan Gilbert wrote:
> * Eric Blake (ebl...@redhat.com) wrote:
>> We want to track why a guest was shutdown; in particular, being able
>> to tell the difference between a guest request (such as ACPI request)
>> and host request (such as SIGI
a reset/shutdown. Since QAPI
generates enums starting at 0, it's easier if we use a different
number as our sentinel that no request has happened yet. Most of
the changes are in vl.c, but xen was using things externally.
Signed-off-by: Eric Blake <ebl...@redhat.com>
---
v4: s/Shutdo
rence between a host- and guest-initiated
shutdown (for now, the replayed event is always attributed to host).
See also https://bugzilla.redhat.com/1384007
Signed-off-by: Eric Blake <ebl...@redhat.com>
---
v5: drop accidental addition of unrelated files
v4: s/ShutdownType/ShutdownCause/, no thanks
-file scripts/cocci-macro-file.h --dir . --in-place
then touched up manually to fix a couple of '?:' back to original
spacing, as well as avoiding a long line in monitor.c.
Signed-off-by: Eric Blake <ebl...@redhat.com>
Reviewed-by: Markus Armbruster <arm...@redhat.com>
---
v5: reba
a reset/shutdown. Since QAPI
generates enums starting at 0, it's easier if we use a different
number as our sentinel that no request has happened yet. Most of
the changes are in vl.c, but xen was using things externally.
Signed-off-by: Eric Blake <ebl...@redhat.com>
---
v4: s/Shutdo
rence between a host- and guest-initiated
shutdown (for now, the replayed event is always attributed to host).
See also https://bugzilla.redhat.com/1384007
Signed-off-by: Eric Blake <ebl...@redhat.com>
---
v3: retitle again, fix qemu-iotests, use enum rather than raw bool
in all callers
v2: retit
a reset/shutdown. Since QAPI
generates enums starting at 0, it's easier if we use a different
number as our sentinel that no request has happened yet. Most of
the changes are in vl.c, but xen was using things externally.
Signed-off-by: Eric Blake <ebl...@redhat.com>
---
v3: new patch
---
On 04/19/2017 05:22 PM, Eric Blake wrote:
> Libvirt would like to be able to distinguish between a SHUTDOWN
> event triggered solely by guest request and one triggered by a
> SIGTERM or other action on the host. qemu_kill_report() is
> already able to tell whether a shutdown w
On 04/20/2017 11:18 AM, Markus Armbruster wrote:
> Eric Blake <ebl...@redhat.com> writes:
>
>> On 04/20/2017 06:59 AM, Markus Armbruster wrote:
>>
>>>
>>> No objection to Alistair's idea to turn this into an enumeration.
>>
>> Question
the guest running
/usr/sbin/poweroff to trigger an ACPI or other hardware-specific
shutdown sequence)
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
___
ered) be handled by having qemu_system_shutdown_request()
with no arguments call
qemu_system_shutdown_request_reason(SHUTDOWN_GUEST). I'm just worried
that doing it that way makes it easy for yet another new host shutdown
method to use the wrong wrapper.
>
> Looks sane on first glance.
ses / kernel and
> halts CPUs, but the virtual machine is still active (and a 'reset' in the
> monitor can start it again. /usr/sbin/poweroff is what actually does the
> ACPI poweroff to trigger QEMU to exit[1]
I'm thinking of this wording:
triggered by a guest request (such as th
On 04/19/2017 05:36 PM, Alistair Francis wrote:
> On Wed, Apr 19, 2017 at 3:22 PM, Eric Blake <ebl...@redhat.com> wrote:
>> Libvirt would like to be able to distinguish between a SHUTDOWN
>> event triggered solely by guest request and one triggered by a
>> SIGTERM
/bugzilla.redhat.com/1384007
Signed-off-by: Eric Blake <ebl...@redhat.com>
---
I did not wire up the RESET event to report guest-triggered, although
I had to plumb that through all the guests since qemu has options that
allow remapping reset to shutdown. It's easy to add that if we want
it
-file scripts/cocci-macro-file.h --dir . --in-place
and needed only one touch-up in monitor.c to avoid a long line.
Signed-off-by: Eric Blake <ebl...@redhat.com>
---
v4: no change
v3: new patch
---
block.c | 45 +++--
bloc
On 04/11/2017 12:12 PM, Markus Armbruster wrote:
> Eric Blake <ebl...@redhat.com> writes:
>
>> We now have macros in place to make it less verbose to add a scalar
>> to QDict and QList, so use them. To make this patch smaller to
>> review, a couple of subdirectorie
-file scripts/cocci-macro-file.h --dir . --in-place
and needed only one touch-up in monitor.c to avoid a long line.
Signed-off-by: Eric Blake <ebl...@redhat.com>
---
block.c | 45 +++--
blockdev.c
edhat.com>
> Date: Wed May 18 11:11:55 2016 +0200
>
> coccinelle: add g_assert_cmp* to macro file
>
> This helps applying semantic patches to unit tests.
>
> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
Didn't even realize it existed. I've updated my
On 01/19/2017 08:38 AM, Eric Blake wrote:
> On 01/19/2017 03:25 AM, Markus Armbruster wrote:
>> Eric Blake <ebl...@redhat.com> writes:
>>
>>> Quite a few users of qdict_put() were manually wrapping a
>>> non-QObject. We can make such call-sites shorte
On 01/19/2017 03:25 AM, Markus Armbruster wrote:
> Eric Blake <ebl...@redhat.com> writes:
>
>> Quite a few users of qdict_put() were manually wrapping a
>> non-QObject. We can make such call-sites shorter, by providing
>> common macros to do the tedious work. Also s
Quite a few users of qdict_put() were manually wrapping a
non-QObject. We can make such call-sites shorter, by providing
common macros to do the tedious work. Also shorten nearby
qdict_put_obj(,,QOBJECT()) sequences.
Signed-off-by: Eric Blake <ebl...@redhat.com>
Reviewed-by: Alberto
Quite a few users of qdict_put() were manually wrapping a
non-QObject. We can make such call-sites shorter, by providing
common macros to do the tedious work. Also shorten nearby
qdict_put_obj(,,QOBJECT()) sequences.
Signed-off-by: Eric Blake <ebl...@redhat.com>
---
I'm okay if you w
.
>
> Fixes f313520 ("xen_disk: add discard support")
>
> Signed-off-by: Olaf Hering <o...@aepfle.de>
> ---
Qualifies as a bug fix, so requesting 2.8 inclusion.
Reviewed-by: Eric Blake <ebl...@redhat.com>
--
Eric Blake eblake redhat com+1-919-301-3266
Libvi
On 11/22/2016 11:00 AM, Olaf Hering wrote:
> On Tue, Nov 22, Eric Blake wrote:
>
>> if (sec_start + sec_count < sec_count ||
>> sec_start > (INT64_MAX >> BDRV_SECTOR_BITS) - sec_count) {
>> return false;
>> }
>
> My point was: how d
On 11/22/2016 10:12 AM, Olaf Hering wrote:
> On Fri, Nov 18, Eric Blake wrote:
>
>> if (sec_start > (INT64_MAX >> BDRV_SECTOR_BITS) - sec_count)
>
> I have looked at this for a while now and cant spot how this would cover
> all cases. Are you saying there should b
On 11/18/2016 11:41 AM, Olaf Hering wrote:
> On Fri, Nov 18, Eric Blake wrote:
>
>> On 11/18/2016 04:24 AM, Olaf Hering wrote:
>>> +/* Overflowing byte limit? */
>>> +if ((sec_start + sec_count) > ((INT64_MAX + INT_MAX) >>
>>> BDRV_
q);
> +struct blkif_request_discard *req = (void *)>req;
...but C doesn't require a cast to void*. As long as you are touching
this, you could remove the cast (unless I'm missing something, and the
cast is also there to cast away const).
> +if (!blk_split_discard(ioreq, req->sect
On 11/18/2016 08:19 AM, Olaf Hering wrote:
> Am 18. November 2016 14:43:18 MEZ, schrieb Eric Blake <ebl...@redhat.com>:
>> On 11/18/2016 04:24 AM, Olaf Hering wrote:
>>> The guest sends discard requests as u64 sector/count pairs, but the
>>> block layer opera
t is, blk_aio_pdiscard() calls into bdrv_co_pdiscard() which is
supposed to be fragmenting things as needed. Can you trace what is
going wrong there? You shouldn't have to reimplement fragementation if
the block layer is doing it correctly.
--
Eric Blake eblake redhat com+1-919-301-32
atever fields we want here }
whether we want all the fields to be flattened in the nvdimm case, vs.
nested (for back-compat) under a 'data' dict in the 'dimm' case, or
whether we want both uses to be nested under a 'data' dict for
consistency, is a matter of taste.
-
t size in bytes of the NVDIMM device
> +#
> +# Since 2.8
> +##
> +{ 'struct': 'NvdimmInfo',
> + 'data': {'mem-path' : 'str', 'slot': 'int', 'spa': 'int', 'length': 'int'}
> }
> +
> +##
> +# @query-nvdimms:
> +#
> +# Returns information about each NVDIMM device
>
On 09/27/2016 04:20 AM, Fam Zheng wrote:
> 9c5ce8db2 switched the type of qemu_uuid and this should have followed.
> Fix it.
>
> Signed-off-by: Fam Zheng <f...@redhat.com>
> ---
> hw/xenpv/xen_domainbuild.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
R
gister_types(void)
>> type_register_static(_info);
>> }
>>
>> -type_init(xenbe_register_types);
>> +type_init(xenbe_register_types);
>> \ No newline at end of file
>
> Looks like this change does not belong to this patch.
For that matter, we prefer
style is VERY difficult to read.
Please consider using a leading > before every line that you are quoting
(rather than pasting it verbatim as if you had written it), and include
a blank line both before and after every line that you insert, to call
visual attention to what is your reply vs
layer.
Signed-off-by: Eric Blake <ebl...@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
---
v2: tweak commit message for grep'ability
---
include/sysemu/block-backend.h | 9 -
block/block-backend.c | 25 +++--
block/mirror.c
some manual
cleanups (such as fixing whitespace to keep checkpatch happy).
Signed-off-by: Eric Blake <ebl...@redhat.com>
---
v8: rewrite commit message, claim authorship, rebase to latest
v7: rebase to latest master
v6: rebase to latest master
---
qapi-schema.json | 49 ++
some manual
cleanups (such as fixing whitespace to keep checkpatch happy).
Signed-off-by: Eric Blake <ebl...@redhat.com>
---
v8: rewrite commit message, claim authorship, rebase to latest
v7: rebase to latest master
v6: rebase to latest master
---
qapi-schema.json | 49 ++
Change sector-based blk_discard(), blk_co_discard(), and
blk_aio_discard() to instead be byte-based *_pdiscard()
functions. NBD gets a lot simpler now that ignoring the
unaligned portion of a byte-based discard request is handled
under the hood by the block layer.
Signed-off-by: Eric Blake <
On 06/16/2016 07:15 AM, Markus Armbruster wrote:
> Eric Blake <ebl...@redhat.com> writes:
>
>> From: Kővágó, Zoltán <dirty.ice...@gmail.com>
>>
>> Except qapi-schema.json, this patch was generated by:
>>
>> find . -name .git -prune -o -type
>
> ---
> hw/usb/xen-usb.c | 5 +
> include/hw/xen/xen.h | 1 -
> 2 files changed, 1 insertion(+), 5 deletions(-)
>
Reviewed-by: Eric Blake <ebl...@redhat.com>
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
ways rejected
'hubport', we can now make that explicit by having the two unions be
slightly different; but that means we must manually map between the
two structures.
Signed-off-by: Eric Blake <ebl...@redhat.com>
---
v7: rebase to latest master
v6: rebase to latest master
---
qapi-
Sector-based blk_aio_readv() and blk_aio_writev() should die; switch
to byte-based blk_aio_preadv() and blk_aio_pwritev() instead.
Signed-off-by: Eric Blake <ebl...@redhat.com>
---
hw/block/xen_disk.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/hw
Sector-based blk_aio_readv() and blk_aio_writev() should die; switch
to byte-based blk_aio_preadv() and blk_aio_pwritev() instead.
Signed-off-by: Eric Blake <ebl...@redhat.com>
---
hw/block/xen_disk.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/hw
ways rejected
'hubport', we can now make that explicit by having the two unions be
slightly different; but that means we must manually map between the
two structures.
Signed-off-by: Eric Blake <ebl...@redhat.com>
---
v6: rebase to latest master
---
hw/arm/musicpal.c| 2 +-
PV, etc.
>>
>
> That's not sufficient though. The IDE device must not be enumerated by the OS
> and, in Windows at least, that enumeration occurs before the PV frontend has
> started up.
...all before getting to the real new content of the message? It is not
only okay to t
mplementing a
workaround that operates FAT in such a way that it never uses a common
namespace was sufficient to avoid any legal questions about whether that
code conflicts with a patent on a common namespace, sidestepping the
longer question of any legal battle over the patent itself.
--
Eric Blake eb
changed, 4 insertions(+), 2 deletions(-)
ACK.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
___
Xen-devel mailing list
Xen-devel@lists.xen.org
{
error_set(errp, QERR_QMP_EXTRA_MEMBER, arg_name);
return NULL;
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
___
Xen
| 7 ++-
5 files changed, 47 insertions(+), 5 deletions(-)
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
freeze for 2.3, and this is a new feature. Is it
still going to make it, or should you adjust this patch to say 'since 2.4'?
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
(-)
ACK.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
dist' is run when configured --without-libxl, then
it still includes both files in the tarball.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
still need this comment?
ACK with that resolved.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
___
Xen-devel mailing list
Xen-devel
for the man page docs.
[Someday, I'd like to add an API or modify an existing capability API
that returns XML to make it possible to query at runtime what formats
are supported by the format-{to,from}-native calls - but that doesn't
have to hold up this series]
--
Eric Blake eblake redhat com+1-919
/html/xen-devel/2015-01/msg00690.html
Yay - this series compiled on RHEL 5, with no extra efforts on my part.
I'll review the individual patches as well, but we're already looking
better.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
-readwrite;
for correct typing.
I'd wait for John to confirm that Coverity is happy, but ACK if you fix
the spots I pointed out.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
be patched to do so; although that only shows
what the client side supports (and not necessarily what the remote
server side supports).
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
leftover generated
files. But if you also want to explicitly ignore the generated files in
.gitignore, go for it.
ACK 1-9, and I'm liking the initial work of 10-12 other than the
Coverity issues that it introduces.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http
conditional so that
xen_xl.c is attempted only when new-enough xenlight support exists (the
same way that src/libxl is avoided when only older xen is present). It
may be as simple as making the file conditional on HAVE_LIBXL, although
I haven't yet tried that.
--
Eric Blake eblake redhat com+1-919
nicely with everything else in the distro.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http
type
#
-# Since: 1.5
+# @xenstubdoms: TPM xenstubdoms type (since 2.3)## Since 1.5
Missing newlines.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
meant by commit. You aren't adding the *.patch
files to a repository, but sending them as email.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
88 matches
Mail list logo
