Re: [Xen-devel] [PATCH 1/2] Revert "x86/hvm: disable pkeys for guests in non-paging mode"

On Wed, 2017-05-31 at 08:44 +0100, Andrew Cooper wrote: > On 31/05/2017 08:09, Han, Huaitong wrote: > > On Fri, 2017-05-26 at 18:03 +0100, Andrew Cooper wrote: > >> This reverts commit c41e0266dd59ab50b7a153157e9bd2a3ad114b53. > >> > >> When determining Acce

Re: [Xen-devel] [PATCH 1/2] Revert "x86/hvm: disable pkeys for guests in non-paging mode"

yielded too. Reviewed-by: Huaitong Han <huaitong@intel.com> > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> > --- > CC: Jan Beulich <jbeul...@suse.com> > CC: Jun Nakajima <jun.nakaj...@intel.com> > CC: Kevin Tian <kevin.t...@intel.co

Re: [Xen-devel] [PATCH] x86/cpuid: fix dom0 crash on skylake machine

Y, I think it works well, and more better. to Luwei: you can test if the problem is solved. On Wed, 2016-06-01 at 10:03 +0100, Andrew Cooper wrote: > On 01/06/16 05:58, Luwei Kang wrote: > > CPUID.0XD.0X0.EAX is from machine value for dom0, and dom0 kernel will > > xsetbv > > with

Re: [Xen-devel] [PATCH] x86/cpuid: fix dom0 crash on skylake machine

etbv > >> with xfeatures_mask that is from CPUID.0XD.0X0.EAX, but handle_xsetbv has > >> ingored XSTATE_PKRU with hardware protection fault emulation, so dom0 > >> kernel > >> will crash on skylake machine with PKRU support. > >> > >> Signed-o

Re: [Xen-devel] [PATCH] x86/cpuid: fix dom0 crash on skylake machine

m0 kernel > will crash on skylake machine with PKRU support. > > Signed-off-by: Luwei Kang <luwei.k...@intel.com> Signed-off-by: Huaitong Han <huaitong@intel.com> > --- > xen/arch/x86/traps.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/xen/arch/x86/t

Re: [Xen-devel] Xen 4.7 Development Update

On Mon, 2016-02-29 at 11:17 +, Wei Liu wrote: > > * Memory protection-key support > - Huaitong Han The patches have been merged into staging branch. ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH V8 5/5] x86/hvm: pkeys, add pkeys support for cpuid handling

gt; CPUID.7.0.ECX[4]:OSPKE and it reflects the support setting of > > CR4.PKE. > > > > X86_FEATURE_OSXSAVE depends on guest X86_FEATURE_XSAVE, but > > cpu_has_xsave > > function reflects hypervisor X86_FEATURE_XSAVE, it is fixed too. > > > > Signed-off-by: Huaito

Re: [Xen-devel] [PATCH V8 2/5] x86/hvm: pkeys, add pkeys support for guest_walk_tables

rved bit violations. > > 4.The access is not an instruction fetch. > > 5.The access is to a user page. > > 6.PKRU.AD=1 > > or The access is a data write and PKRU.WD=1 > > and either CR0.WP=1 or it is a user access. > > > > Signed-off-by:

Re: [Xen-devel] Xen 4.7 Development Update

On Mon, 2016-02-01 at 10:45 +, Wei Liu wrote: > This email only tracks big items for xen.git tree. Please reply for > items you > woulk like to see in 4.7 so that people have an idea what is going on > and > prioritise accordingly. > > You're welcome to provide description and use cases of

Re: [Xen-devel] [PATCH V9 1/5] x86/hvm: pkeys, disable pkeys for guests in non-paging mode

mode, To emulate this > > behavior, pkeys > > needs to be manually disabled when guest switches to non-paging > > mode. > > > > Signed-off-by: Huaitong Han <huaitong@intel.com> > > Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com> > > So

Re: [Xen-devel] [PATCH V9 0/5] x86/hvm: pkeys, add memory protection-key support

On Thu, 2016-02-04 at 13:20 +0800, Huaitong Han wrote: > On Thu, 2016-02-04 at 04:56 +, Tian, Kevin wrote: > > > From: Huaitong Han > > > Sent: Wednesday, February 03, 2016 10:12 PM > > > > > > The PKRU register (protection key rights for user pages) is a 32 > > > -bit register > > > with the

Re: [Xen-devel] [PATCH V9 0/5] x86/hvm: pkeys, add memory protection-key support

On Thu, 2016-02-04 at 04:56 +, Tian, Kevin wrote: > > From: Huaitong Han > > Sent: Wednesday, February 03, 2016 10:12 PM > > > > The PKRU register (protection key rights for user pages) is a 32 > > -bit register > > with the following format: for each i (0 ≤ i ≤ 15), PKRU[2i] is the > >

Re: [Xen-devel] [PATCH V6 4/5] xen/mm: Clean up pfec handling in gva_to_gfn

On Wed, 2016-01-27 at 09:34 +, Tim Deegan wrote: > Hi, > > At 07:22 + on 27 Jan (1453879344), Han, Huaitong wrote: > > On Tue, 2016-01-26 at 14:30 +, Tim Deegan wrote: > > > This seems OK. But can you please: > > > - Add this new adjustment once

Re: [Xen-devel] [PATCH V6 4/5] xen/mm: Clean up pfec handling in gva_to_gfn

On Tue, 2016-01-26 at 14:30 +, Tim Deegan wrote: > Hi, > > At 15:30 +0800 on 19 Jan (1453217458), Huaitong Han wrote: > > At the moment, the pfec argument to gva_to_gfn has two functions: > > > > * To inform guest_walk what kind of access is happenind > > > > * As a value to pass back into

Re: [Xen-devel] [PATCH V6 0/5] x86/hvm: pkeys, add memory protection-key support

On Mon, 2016-01-25 at 08:25 -0700, Jan Beulich wrote: > > > > On 19.01.16 at 08:30, wrote: > > Changes in v6: > > *2 patches merged are not included. > > *Don't write XSTATE_PKRU to PV's xcr0. > > *Use "if()" instead of "?:" in cpuid handling patch. > > *Update read_pkru

Re: [Xen-devel] [PATCH V6 2/5] x86/hvm: pkeys, add pkeys support for guest_walk_tables

On Mon, 2016-01-25 at 08:46 -0700, Jan Beulich wrote: > > > > On 19.01.16 at 08:30, wrote: > > > > +write_cr4(cr4 | X86_CR4_PKE); > > +asm volatile (".byte 0x0f,0x01,0xee" > > +: "=a" (pkru) : "c" (0) : "dx"); > > +write_cr4(cr4); > > I think you

Re: [Xen-devel] [PATCH V4 4/6] x86/hvm: pkeys, add pkeys support for guest_walk_tables

On Mon, 2015-12-21 at 08:32 -0700, Jan Beulich wrote: > > > > On 21.12.15 at 08:21, wrote: > > --- a/xen/arch/x86/mm/guest_walk.c > > +++ b/xen/arch/x86/mm/guest_walk.c > > @@ -90,6 +90,55 @@ static uint32_t set_ad_bits(void *guest_p, void > > *walk_p, int set_dirty) > >

Re: [Xen-devel] [PATCH V4 6/6] x86/hvm: pkeys, add pkeys support for cpuid handling

On Tue, 2015-12-22 at 01:30 -0700, Jan Beulich wrote: > > > > On 22.12.15 at 03:54, wrote: > > On Mon, 2015-12-21 at 08:07 -0700, Jan Beulich wrote: > > > > > > On 21.12.15 at 08:21, wrote: > > > > @@ -4600,6 +4600,14 @@ void hvm_cpuid(unsigned int

Re: [Xen-devel] [PATCH V4 6/6] x86/hvm: pkeys, add pkeys support for cpuid handling

On Mon, 2015-12-21 at 08:07 -0700, Jan Beulich wrote: > > > > On 21.12.15 at 08:21, wrote: > > @@ -4600,6 +4600,14 @@ void hvm_cpuid(unsigned int input, unsigned > > int *eax, unsigned int *ebx, > > /* Don't expose INVPCID to non-hap hvm. */ > > if (

Re: [Xen-devel] [V3 PATCH 7/9] x86/hvm: pkeys, add pkeys support for guest_walk_tables

On Wed, 2015-12-16 at 15:36 +, George Dunlap wrote: > [Adding Tim, the previous mm maintainer] > > On 11/12/15 09:16, Wu, Feng wrote: > > > > +{ > > > > +void *xsave_addr; > > > > +unsigned int pkru = 0; > > > > +bool_t pkru_ad, pkru_wd; > > > > + > > > > +bool_t uf = !!(pfec

Re: [Xen-devel] [V3 PATCH 7/9] x86/hvm: pkeys, add pkeys support for guest_walk_tables

On Wed, 2015-12-16 at 02:12 -0700, Jan Beulich wrote: > > > > On 16.12.15 at 10:03, wrote: > > On Wed, 2015-12-16 at 01:32 -0700, Jan Beulich wrote: > > > > > > On 16.12.15 at 09:16, wrote: > > > > On Tue, 2015-12-15 at 02:02 -0700, Jan Beulich

Re: [Xen-devel] [V3 PATCH 7/9] x86/hvm: pkeys, add pkeys support for guest_walk_tables

On Wed, 2015-12-16 at 01:32 -0700, Jan Beulich wrote: > > > > On 16.12.15 at 09:16, wrote: > > On Tue, 2015-12-15 at 02:02 -0700, Jan Beulich wrote: > > > Well, I wouldn't want you to introduce a brand new function, but > > > instead just factor out the necessary piece

Re: [Xen-devel] [V3 PATCH 7/9] x86/hvm: pkeys, add pkeys support for guest_walk_tables

On Tue, 2015-12-15 at 02:02 -0700, Jan Beulich wrote: > > > > On 15.12.15 at 09:14, wrote: > > On Fri, 2015-12-11 at 02:26 -0700, Jan Beulich wrote: > > > > > > On 10.12.15 at 19:19, wrote: > > > > On 07/12/15 09:16, Huaitong Han wrote: > > > > >

Re: [Xen-devel] [V3 PATCH 7/9] x86/hvm: pkeys, add pkeys support for guest_walk_tables

On Fri, 2015-12-11 at 02:26 -0700, Jan Beulich wrote: > > > > On 10.12.15 at 19:19, wrote: > > On 07/12/15 09:16, Huaitong Han wrote: > > > +if ( likely(!pte_pkeys) ) > > > +return 0; > > > + > > > +/* Update vcpu xsave area */ > > > +fpu_xsave(vcpu);

Re: [Xen-devel] [V3 PATCH 7/9] x86/hvm: pkeys, add pkeys support for guest_walk_tables

On Thu, 2015-12-10 at 18:19 +, George Dunlap wrote: > On 07/12/15 09:16, Huaitong Han wrote: > > +{ > > +void *xsave_addr; > > +unsigned int pkru = 0; > > +bool_t pkru_ad, pkru_wd; > > + > > +bool_t uf = !!(pfec & PFEC_user_mode); > > +bool_t wf = !!(pfec &

Re: [Xen-devel] [V3 PATCH 7/9] x86/hvm: pkeys, add pkeys support for guest_walk_tables

On Thu, 2015-12-10 at 18:59 +, Andrew Cooper wrote: > On 07/12/15 09:16, Huaitong Han wrote: > > + > > +/* PKRU dom0 is always zero */ > > +if ( likely(!pte_pkeys) ) > > +return 0; > > This is not an architectural restriction (as far as I can tell). Xen > must never make

Re: [Xen-devel] [V2 PATCH 9/9] x86/hvm: pkeys, add pkeys support for gva2gfn funcitons

On Wed, 2015-12-02 at 04:35 -0700, Jan Beulich wrote: > >>> On 27.11.15 at 10:52, wrote: > > --- a/xen/arch/x86/hvm/hvm.c > > +++ b/xen/arch/x86/hvm/hvm.c > > @@ -4304,7 +4304,8 @@ static enum hvm_copy_result > > __hvm_clear(paddr_t addr, int size) > > p2m_type_t

Re: [Xen-devel] [V2 PATCH 7/9] x86/hvm: pkeys, add pkeys support for guest_walk_tables

On Tue, 2015-12-01 at 20:30 +, Andrew Cooper wrote: > > +#include > > I can see why you need xstate.h, but I why do you need i387.h ? Use vcpu_save_fpu functions. > > + > > if ( pse2M ) > > { > > /* Special case: this guest VA is in a PSE superpage, so > > there's > > @@

Re: [Xen-devel] [V2 PATCH 1/9] x86/hvm: pkeys, add pkeys support for cpuid handling

On Wed, 2015-12-02 at 04:06 -0700, Jan Beulich wrote: > > > ) > > > +*ecx &= ~cpufeat_mask(X86_FEATURE_PKU); > > > + > > > +if ( (count == 0) && cpu_has_pku ) > > > +*ecx |= (v->arch.hvm_vcpu.guest_cr[4] & X86_CR4_PKE) > > > ? > > > +

Re: [Xen-devel] [V2 PATCH 8/9] x86/hvm: pkeys, add xstate support for pkeys

On Wed, 2015-12-02 at 04:31 -0700, Jan Beulich wrote: > > > > On 02.12.15 at 08:20, wrote: > > > Does this even compile? There is already > > > > > > static void *get_xsave_addr(void *xsave, unsigned int > > > xfeature_idx) > > > > > > higher in the same file. > > > >

Re: [Xen-devel] [V2 PATCH 8/9] x86/hvm: pkeys, add xstate support for pkeys

> Does this even compile? There is already > > static void *get_xsave_addr(void *xsave, unsigned int xfeature_idx) > > higher in the same file. > > That function should be augmented to take a struct xsave_struct > *xsave, > look at whether the representation is compressed or not, and use the

Re: [Xen-devel] [V2 PATCH 0/9] x86/hvm: pkeys, add memory protection-key support

On Fri, 2015-11-27 at 12:59 +, Andrew Cooper wrote: > Just for my own understand, do you have a sample use-case for > protection > keys? > > As everything can WRPKRU, I cant see how it would actually be useful. > Clearly there is a usecase or you (Intel) wouldn't have gone to the > effort of

Re: [Xen-devel] Xen 4.7 Development Update

On Mon, 2015-11-09 at 16:15 +, Wei Liu wrote: > = Timeline = > > We now adopt a fixed cut-off date scheme. We will release twice a > year. The upcoming 4.7 timeline are as followed: > > * Last posting date: March 18, 2016 > * Hard code freeze: April 1, 2016 > * RC1: TBD > * Release: July 1,

Re: [Xen-devel] Does Xen support nested VM migration

On Wed, 2015-07-01 at 08:50 +0100, Andrew Cooper wrote: On 01/07/2015 03:49, Han, Huaitong wrote: Hi, all, When I create a L1 guest with nestedhvm=1, and create a L2 guest in L1 guest, then migrate L1 guest, but the operation fails, and I find the bugfix requires a lot of work

Re: [Xen-devel] [V6] x86/cpuidle: get accurate C0 value with xenpm tool

On Thu, 2015-05-21 at 07:50 +0100, Jan Beulich wrote: On 21.05.15 at 08:40, huaitong@intel.com wrote: @@ -329,7 +340,7 @@ static uint64_t acpi_pm_ticks_elapsed(uint64_t t1, uint64_t t2) } uint64_t (*__read_mostly cpuidle_get_tick)(void) = get_acpi_pm_tick; -static uint64_t

Re: [Xen-devel] [V5] x86/cpuidle: get accurate C0 value with xenpm tool

On Wed, 2015-05-20 at 02:42 +, Han, Huaitong wrote: On Tue, 2015-05-19 at 10:01 +0100, Jan Beulich wrote: On 14.05.15 at 07:23, huaitong@intel.com wrote: @@ -1172,7 +1196,10 @@ int pmstat_get_cx_stat(uint32_t cpuid, struct pm_cx_stat *stat) { struct

Re: [Xen-devel] [V5] x86/cpuidle: get accurate C0 value with xenpm tool

On Tue, 2015-05-19 at 10:01 +0100, Jan Beulich wrote: On 14.05.15 at 07:23, huaitong@intel.com wrote: @@ -1172,7 +1196,10 @@ int pmstat_get_cx_stat(uint32_t cpuid, struct pm_cx_stat *stat) { struct acpi_processor_power *power = processor_powers[cpuid]; uint64_t

Re: [Xen-devel] [V3] x86/cpuidle: get accurate C0 value with xenpm tool

decrease. Signed-off-by: Huaitong Han huaitong@intel.com Please address all comments on the previous iteration before re-submitting. Jan ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [V3] x86/cpuidle: get accurate C0 value with xenpm tool

Get it, thanks On Mon, 2015-05-11 at 09:00 +0100, Jan Beulich wrote: On 11.05.15 at 08:50, huaitong@intel.com wrote: On Fri, 2015-05-08 at 11:11 +0100, Jan Beulich wrote: On 08.05.15 at 11:40, huaitong@intel.com wrote: All comments has been addressed, just changelog is written

Re: [Xen-devel] [V4] x86/cpuidle: get accurate C0 value with xenpm tool

On Mon, 2015-05-11 at 12:10 +0100, Jan Beulich wrote: On 11.05.15 at 11:34, huaitong@intel.com wrote: --- ChangeLog: V4: delete pointless initializers and hard tabs. Thanks, but ... V3: 1.Don't use tick_to_ns inside lock in print_acpi_power. ... note that this also was

Re: [Xen-devel] [V3] x86/cpuidle: get accurate C0 value with xenpm tool

. Signed-off-by: Huaitong Han huaitong@intel.com Please address all comments on the previous iteration before re-submitting. Jan ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [V2] x86/cpuidle: get accurate C0 value with xenpm tool

All accepted. -Original Message- From: Jan Beulich [mailto:jbeul...@suse.com] Sent: Monday, May 4, 2015 10:01 PM To: Han, Huaitong Cc: xen-devel@lists.xen.org Subject: Re: [V2] x86/cpuidle: get accurate C0 value with xenpm tool On 04.05.15 at 15:23, huaitong@intel.com wrote

Re: [Xen-devel] [v1] x86/cpuidle: get accurate C0 value with xenpm tool

-Original Message- From: Jan Beulich [mailto:jbeul...@suse.com] Sent: Thursday, April 16, 2015 4:49 PM To: Han, Huaitong Cc: xen-devel@lists.xen.org Subject: Re: [v1] x86/cpuidle: get accurate C0 value with xenpm tool On 16.04.15 at 08:03, huaitong@intel.com wrote: When checking