[Xen-devel] [PATCH 6/9 v2] xl: Improve return and exit codes of list related functions.

flush_stream(), list_domains(), list_vm(), main_list() and main_vm_list() are fixed. Signed-off-by: Harmandeep Kaur <write.harmand...@gmail.com> --- v2: No changes. --- tools/libxl/xl_cmdimpl.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/tools

[Xen-devel] [PATCH 5/9 v2] xl: Improve return and exit codes of pause, destroy and shutdown related functions.

destroy_domain(), wait_for_domain_deaths(), shutdown_domain(), reboot_domain(), main_pause(), main_unpause(), main_destroy() and main_shutdown_or_reboot() are fixed. Signed-off-by: Harmandeep Kaur <write.harmand...@gmail.com> --- v2: No changes. --- tools/libxl/xl_cmdimpl.

[Xen-devel] [PATCH 7/9 v2] xl: Improve return and exit codes of create, config_update and rename related functions.

create_domain(), string_realloc_append(), main_create(), main_config_update() and main_rename() are fixed. Signed-off-by: Harmandeep Kaur <write.harmand...@gmail.com> --- v2: Add create_domain() Remove main_sharing() --- tools/libxl/xl_cmdimpl.

[Xen-devel] [PATCH 9/9 v2] xl: Improve return and exit codes of domain id and name related functions.

find_domain(), main_domid() and main_domname() are fixed. Signed-off-by: Harmandeep Kaur <write.harmand...@gmail.com> --- v2: Add find_domain(). --- tools/libxl/xl_cmdimpl.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tools/libxl/xl_cmdimpl.c b/tools

[Xen-devel] [PATCH 8/9 v2] xl : Improve return and exit codes debugging, special keys and triggering related functions.

button_press(), main_trigger(), main_sysrq(), main_debug_keys() and main_dmesg() are fixed. Signed-off-by: Harmandeep Kaur <write.harmand...@gmail.com> --- v2: Add main_sysrq(), main_debug_keys(), main_dmesg() Remove xvasprintf(), main_remus() --- tools/libxl/xl_cmdimpl.

[Xen-devel] [PATCH 0/9 v2] xl: convert exit codes related to domain subcommands to EXIT_[SUCCESS|FAILURE]

*main_foo() is treated somewhat as a regular main(), it is changed to return EXIT_SUCCESS or EXIT_FAILURE. *Functions that are not main_foo(), are changed to do 'return 0' or 'return 1', and then 0/1 is taken care in the main_foo() functions that calls them. *Functions in xl_cmdimpl.c related to

[Xen-devel] [PATCH 3/9 v2] xl: Improve return and exit codes of migrate related functions.

-by: Harmandeep Kaur <write.harmand...@gmail.com> --- v2: Add CHK_SYSCALL, MUST micros. Add xvasprintf(). --- tools/libxl/xl_cmdimpl.c | 58 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/tools/libxl/xl_cmdimpl.c b/tools

[Xen-devel] [PATCH 1/9 v2] xl: Improve return and exit codes of memory related functions.

Return and exit codes of freemem(), set_memory_max(), main_memmax(), set_memory_target(), main_memset() and main_sharing() in the file xl_cmdimpl are fixed. Add comment to explain return vaule of parse_mem_size_kb(). Signed-off-by: Harmandeep Kaur <write.harmand...@gmail.com> --- v2: Add c

[Xen-devel] [PATCH 4/9 v2] xl: Improve return and exit codes of console, vnc and core dump related functions.

autoconnect_vncviewer(), main_console(), main_vncviewer(), core_dump_domain() and main_dump_core() in the file xl_cmdimpl are fixed. Signed-off-by: Harmandeep Kaur <write.harmand...@gmail.com> --- v2: Add autoconnect_vncviewer(). --- tools/libxl/xl_cmdimpl.c | 14 +++--- 1 file c

[Xen-devel] [PATCH 2/9 v2] xl: Improve return and exit codes of restore and save related functions.

save_domain(), main_restore(), main_save() and main_remus() in the file xl_cmdimpl are fixed. Signed-off-by: Harmandeep Kaur <write.harmand...@gmail.com> --- v2: Add main_remus(). Remove create_domain(). --- tools/libxl/xl_cmdimpl.c | 22 +++--- 1 file changed, 11 inse

[Xen-devel] [PATCH v5] libxl: handle failure of xc_version() in libxl_get_version_info()

is updated. Callers of the function libxl_get_version_info() are already prepared to deal with a NULL return value. Coverity ID 1351217 Signed-off-by: Harmandeep Kaur <write.harmand...@gmail.com> Reviewed-by: Dario Faggioli <dario.faggi...@citrix.com> --- v2: Change local variable rc t

Re: [Xen-devel] [PATCH v4] libxl: handle failure of xc_version() in libxl_get_version_info()

On Tue, Mar 1, 2016 at 7:18 PM, Ian Jackson <ian.jack...@eu.citrix.com> wrote: > Harmandeep Kaur writes ("[PATCH v4] libxl: handle failure of xc_version() in > libxl_get_version_info()"): >> Check the return value of xc_version() and return NULL if it >> fails.

[Xen-devel] [PATCH] xl: Improve return and exit codes of parse_config_data().

Turning parse_config_data() exit codes towards using the EXIT_[SUCCESS|FAILURE] constants, instead of instead of arbitrary numbers or libxl return codes. - for main_*: arbitrary -> EXIT_SUCCESS|EXIT_FAILURE. - for internal fucntion: arbitrary -> 0/1. Signed-off-by: Harmandee

[Xen-devel] False positive coverity bug id: 1351218

This is about a Coverity bug (included in the end), which I think is a false positive. I don't think pagesize can be zero in any case. pagesize = 1 << (((flags >> TMEM_POOL_PAGESIZE_SHIFT) & TMEM_POOL_PAGESIZE_MASK) + 12); Which means "pagesize > bufsize" will always

Re: [Xen-devel] [PATCH] libxl: fix handling returns in libxl_get_version_info()

On Thu, Feb 11, 2016 at 3:18 PM, Dario Faggioli <dario.faggi...@citrix.com> wrote: > Hi Harmandeep, > > So, I think the code in this patch is ok. Still, a few comments... > > On Thu, 2016-02-11 at 14:00 +0530, Harmandeep Kaur wrote: >> Avoid handling issue of the

Re: [Xen-devel] [PATCH] libxl: fix handling returns in libxl_get_version_info()

On Fri, Feb 12, 2016 at 4:30 PM, Dario Faggioli <dario.faggi...@citrix.com> wrote: > On Fri, 2016-02-12 at 16:22 +0530, Harmandeep Kaur wrote: >> On Thu, Feb 11, 2016 at 3:18 PM, Dario Faggioli >> <dario.faggi...@citrix.com> wrote: >> > >> > Anot

[Xen-devel] [PATCH v3] libxc: fix leak of t_info in xc_tbuf_get_size()

Avoid leaking the memory mapping of the trace buffer Coverity ID 1351228 Signed-off-by: Harmandeep Kaur <write.harmand...@gmail.com> Reviewed-by: Dario Faggioli <dario.faggi...@citrix.com> --- v2: call to unmapping function reduced to one from two v3: passed corr

[Xen-devel] [PATCH v2] libxl: fix handling of returns in libxl_get_version_info()

Check the return value of xc_version() and return NULL if it fails. libxl_get_version_info() can also return NULL now. Callers of the function libxl_get_version_info() are already prepared to deal with returning NULL on failure of xc_version(). Coverity ID 1351217 Signed-off-by: Harmandeep Kaur

Re: [Xen-devel] [PATCH v2] libxl: fix handling of returns in libxl_get_version_info()

On Fri, Feb 12, 2016 at 6:39 PM, Dario Faggioli <dario.faggi...@citrix.com> wrote: > On Fri, 2016-02-12 at 12:31 +, Wei Liu wrote: >> On Fri, Feb 12, 2016 at 05:00:40PM +0530, Harmandeep Kaur wrote: >> > >> > +info->xen_version_major = r >> 16; &g

[Xen-devel] [PATCH v3] libxl: fix handling of returns in libxl_get_version_info()

in various info fields only if all calls to xc_version go error-free. Coverity ID 1351217 Signed-off-by: Harmandeep Kaur <write.harmand...@gmail.com> --- v2: Change local variable rc to r. Remove xen_version. Better readiblity of blocks of code. v3: Group all calls to xc_version(

[Xen-devel] [PATCH v2] libxc: fix leak of t_info in xc_tbuf_get_size()

Avoid leaking the memory mapping of the trace buffer Coverity ID 1351228 Signed-off-by: Harmandeep Kaur <write.harmand...@gmail.com> --- v2: call to unmapping function reduced to one from two --- tools/libxc/xc_tbuf.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff

[Xen-devel] [PATCH] libxl: fix handling returns in libxl_get_version_info()

Avoid handling issue of the return value of xc_version() in many cases. Coverity ID 1351217 Signed-off-by: Harmandeep Kaur <write.harmand...@gmail.com> --- tools/libxl/libxl.c | 39 ++- 1 file changed, 30 insertions(+), 9 deletions(-) diff --git a

[Xen-devel] [PATCH v2] libxc: fix leak in xc_offline_page error path

Avoid leaking the mapping of the m2p in one of the possible failure cases. Coverity CID 1351225 Signed-off-by: Harmandeep Kaur <write.harmand...@gmail.com> --- v2: update commit message and changelog --- tools/libxc/xc_offline_page.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Xen-devel] [PATCH] libxc: Fix CID 1351225 resource leak

Signed-off-by: Harmandeep Kaur <write.harmand...@gmail.com> --- tools/libxc/xc_offline_page.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libxc/xc_offline_page.c b/tools/libxc/xc_offline_page.c index bc91d51..3248a34 100644 --- a/tools/libxc/xc_offline_page.c

[Xen-devel] [PATCH] libxc: Fix CID 1351228 resource leak

Signed-off-by: Harmandeep Kaur <write.harmand...@gmail.com> --- tools/libxc/xc_tbuf.c | 4 1 file changed, 4 insertions(+) diff --git a/tools/libxc/xc_tbuf.c b/tools/libxc/xc_tbuf.c index 695939a..f06f566 100644 --- a/tools/libxc/xc_tbuf.c +++ b/tools/libxc/xc_tbuf.c @@ -70,9 +70,13

Re: [Xen-devel] Error booting Xen

On Wed, Feb 3, 2016 at 6:25 PM, Dario Faggioli <dario.faggi...@citrix.com> wrote: > On Wed, 2016-02-03 at 17:05 +0530, Harmandeep Kaur wrote: >> On Wed, Feb 3, 2016 at 1:53 PM, Dario Faggioli >> <dario.faggi...@citrix.com> wrote: >> > >> Maybe I faile

Re: [Xen-devel] Error booting Xen

ttp://paste2.org/5PDz9bP1 and then I created a guest with config (http://paste2.org/azvj25Hg) and http://paste2.org/cgKna0j1 log was presented at terminal. I hope this helps. Thanks and regards, Harmandeep Kaur > And this too? > > Can you please do that? :-) > > Regards, > Dari

Re: [Xen-devel] Error booting Xen

Latest set looks good. No boot issues. No resets. Full log at http://paste2.org/NxHNW4vn Sorry I don't know much about source of last few lines. I was just tracing in xen when these came. I was unable to create them again. I will inform you if I get these again. Regards, Harmandeep On Wed, Jan

Re: [Xen-devel] Error booting Xen

I tried to apply your patches but it seems to have some merge conflicts with latest staging branch. ~/xen$ git apply ~/Downloads/x86-xsaves-init.patch error: patch failed: xen/arch/x86/hvm/hvm.c:2094 error: xen/arch/x86/hvm/hvm.c: patch does not apply Do you mind having a look ? Regards,

Re: [Xen-devel] Error booting Xen

I tried 3rd patch together with earlier two. I'm afraid the problem is not solved completely. Full log goes here, http://paste2.org/KEAetMHb Regards, Harmandeep On Tue, Jan 26, 2016 at 6:53 PM, Jan Beulich wrote: On 26.01.16 at 14:13, wrote:

Re: [Xen-devel] Error booting Xen

Last time, I did absolutely nothing. System was idle and it crashed just after the login. Now, I booted the system again and this time, there is no reset. But, performance of the system is very slow. Browser (Mozilla Firefox) freezes a lot. Also, before applying patches, when I used to disabe

Re: [Xen-devel] Error booting Xen

On Tue, Jan 26, 2016 at 11:58 PM, Dario Faggioli <dario.faggi...@citrix.com> wrote: > On Tue, 2016-01-26 at 23:32 +0530, Harmandeep Kaur wrote: >> Last time, I did absolutely nothing. System was idle >> and it crashed just after the login. Now, I booted the >>

Re: [Xen-devel] Error booting Xen

Regards, Harman On Tue, Jan 26, 2016 at 6:21 PM, Harmandeep Kaur <write.harmand...@gmail.com> wrote: > Hi guys, > > I tried the patch and I am very happy to inform you > all that the patch has solved my problem. Now I am > able to boot Xen without disabling XSAVE. I have >

Re: [Xen-devel] Error booting Xen

Hi guys, I tried the patch and I am very happy to inform you all that the patch has solved my problem. Now I am able to boot Xen without disabling XSAVE. I have full log of boot at http://paste2.org/gVW0Z9nm (if any one is interested. also "XXX Hello, this is my first mod :)" is printed by my

Re: [Xen-devel] Error booting Xen

On Thu, Jan 21, 2016 at 8:44 PM, Dario Faggioli wrote: > On Wed, 2016-01-20 at 03:06 -0700, Jan Beulich wrote: >> > > > On 19.01.16 at 20:55, wrote: >> > >> > $ 'addr2line -e xen-syms 82d0801c1cce' returns >> >

Re: [Xen-devel] Error booting Xen

On Tue, Jan 19, 2016 at 10:38 PM, Dario Faggioli wrote: > On Tue, 2016-01-19 at 17:02 +, Andrew Cooper wrote: >> On 19/01/16 16:47, Jan Beulich wrote: >> > > > > On 19.01.16 at 17:27, wrote: >> > > Adding 'xsave=0' is working for now.

Re: [Xen-devel] Error booting Xen

> On Mon, 2016-01-18 at 18:09 +, Andrew Cooper wrote: > > On 18/01/16 18:03, Harmandeep Kaur wrote: > > > Hi, > > > > > > I tried to boot Xen (cloned from git clone > > > git://xenbits.xen.org/xen.git), but it stucks > > > in a infinite

Re: [Xen-devel] Error booting Xen

Hi, Adding 'xsave=0' is working for now. Thank you all for your help :) Regards, Harman On Tue, Jan 19, 2016 at 8:37 PM, Andrew Cooper wrote: > On 19/01/16 14:51, Dario Faggioli wrote: >> On Tue, 2016-01-19 at 06:36 -0700, Jan Beulich wrote: >> On 18.01.16 at

[Xen-devel] Error booting Xen

Hi, I tried to boot Xen (cloned from git clone git://xenbits.xen.org/xen.git), but it stucks in a infinite loop. I got the log via serial. You can inspect it at http://paste2.org/YCpkzbpG If anybody has encountered this issue before, I will appreciate any help. Regards, Harmandeep Kaur

Re: [Xen-devel] Blank screen while booting xen

On Mon, Jan 11, 2016 at 11:36 PM, Konrad Rzeszutek Wilk <konrad.w...@oracle.com> wrote: > On Mon, Jan 11, 2016 at 11:15:43PM +0530, Harmandeep Kaur wrote: >> On Mon, Jan 11, 2016 at 11:00 PM, Konrad Rzeszutek Wilk >> <konrad.w...@oracle.com> wrote: >> > On M

Re: [Xen-devel] Blank screen while booting xen

On Mon, Jan 11, 2016 at 8:23 PM, Konrad Rzeszutek Wilk <konrad.w...@oracle.com> wrote: > On Mon, Jan 11, 2016 at 12:57:27AM +0530, Harmandeep Kaur wrote: >> Hi, >> >> I tried to modify and compile some of Xen 4.7's code >> (cloned from git clone git://xen

Re: [Xen-devel] Blank screen while booting xen

On Mon, Jan 11, 2016 at 11:00 PM, Konrad Rzeszutek Wilk <konrad.w...@oracle.com> wrote: > On Mon, Jan 11, 2016 at 10:56:07PM +0530, Harmandeep Kaur wrote: >> On Mon, Jan 11, 2016 at 8:23 PM, Konrad Rzeszutek Wilk >> <konrad.w...@oracle.com> wrote: >> > On M

[Xen-devel] Blank screen while booting xen

iate any help. Regards, Harmandeep Kaur Outreachy Intern ---PATCH- >From c814c4ac0028bdef0082561ad6cd69570502c3ba Mon Sep 17 00:00:00 2001 From: Harmandeep Kaur <write.harmand...@gmail.com> Date: Tue, 29

[Xen-devel] Garbled serial console output

Hi, I tried to setup xen serial console with this guide, http://wiki.xen.org/wiki/Xen_Serial_Console I am using RS232 -USB cable for this purpose. I am on Ubuntu 15.10 (4.2.0-19-generic). xl info http://paste2.org/F2UgY5yz My output is garbled. http://paste2.org/tZveaAGU I will appreciate any

[Xen-devel] Introduction by Outreachy intern

Hi, I am Harmandeep Kaur, Outreachy intern for December 2015 – March 2016 round from India. I will be working on the project “Introducing PowerClamp-like driver for Xen” with Dario Faggioli and George Dunlap. More info about the project on my blog https://harmanio.wordpress.com/ Looking forward

[Xen-devel] [PATCH] sched_credit: Remove cpu argument to __runq_insert()

__runq_insert() takes two arguments, cpu and svc. However, the cpu argument is redundant because we can get all the information we need about cpu from svc. Signed-off-by: Harmandeep Kaur <write.harmand...@gmail.com> --- xen/common/sched_credit.c | 11 +-- 1 file changed, 5 inse

Re: [Xen-devel] [PATCH] sched_credit: Remove cpu argument to __runq_insert()

On Fri, Oct 30, 2015 at 10:16 PM, Dario Faggioli <dario.faggi...@citrix.com> wrote: > On Fri, 2015-10-30 at 20:39 +0530, Harmandeep Kaur wrote: > > __runq_insert() takes two arguments, cpu and svc. However, > > the cpu argument is redundant because we can get all the > >

[Xen-devel] [PATCH v6 1/5] xl: convert main() exit codes to EXIT_[SUCCESS|FAILURE]

() as if they are returning a process exit status and not a function return value) Signed-off-by: Harmandeep Kaur <write.harmand...@gmail.com> Reviewed-by: Dario Faggioli <dario.faggi...@citrix.com> Acked-by: Wei Liu <wei.l...@citrix.com> --- v5->v6: No changes. v4->v5: No changes. v3->v4: Al

[Xen-devel] [PATCH v6 2/5] xl: improve return and exit codes of scheduling related functions

ed-off-by: Harmandeep Kaur <write.harmand...@gmail.com> Reviewed-by: Dario Faggioli <dario.faggi...@citrix.com> Acked-by: Wei Liu <wei.l...@citrix.com> --- v5->v6: Corrected coding style. v4->v5: Improved coding style. v3->v4: No changes. v2->v3: Reverted removal of 'rc' in

[Xen-devel] [PATCH v6 4/5] xl: improve return and exit codes of parse related functions

Turning cpupools related functions exit codes towards using the EXIT_[SUCCESS|FAILURE] constants, instead of instead of arbitrary numbers or libxl return codes. Signed-off-by: Harmandeep Kaur <write.harmand...@gmail.com> Reviewed-by: Dario Faggioli <dario.faggi...@citrix.com> Acked

[Xen-devel] [PATCH v6 3/5] xl: improve return and exit codes of vcpu related functions

Turning vcpu manipulation functions exit codes toward using the EXIT_[SUCCESS|FAILURE] constants, instead of instead of arbitrary numbers or libxl return codes. Signed-off-by: Harmandeep Kaur <write.harmand...@gmail.com> Reviewed-by: Dario Faggioli <dario.faggi...@citrix.com> Acked

[Xen-devel] [PATCH v6 5/5] xl: improve return and exit codes of parse related functions

touch parse_config_data() which is big enough to deserve its own patch. Signed-off-by: Harmandeep Kaur <write.harmand...@gmail.com> Reviewed-by: Dario Faggioli <dario.faggi...@citrix.com> Acked-by: Wei Liu <wei.l...@citrix.com> --- v5->v6: No changes. v4->v5: No changes. v3->v4:

[Xen-devel] [PATCH v6 0/5] xl: convert exit codes to EXIT_[SUCCESS|FAILURE]

roject.org/archives/html/xen-devel/2015-10/msg02872.html *v4 of this patch: http://lists.xenproject.org/archives/html/xen-devel/2015-10/msg02947.html *v5 of this patch: http://lists.xenproject.org/archives/html/xen-devel/2015-10/msg02990.html Signed-off-by: Harmandeep Kaur <write.harmand

[Xen-devel] [PATCH v3 4/5] xl: improve return and exit codes of cpupool related functions

Turning cpupools related functions exit codes towards using the EXIT_[SUCCESS|FAILURE] constants, instead of instead of arbitrary numbers or libxl return codes. Signed-off-by: Harmandeep Kaur <write.harmand...@gmail.com> --- v2->v3: Edited changelog. tools/libxl/xl_cmdim

[Xen-devel] [PATCH v3 3/5] xl: improve return and exit codes of vcpu related functions

Turning vcpu manipulation functions exit codes toward using the EXIT_[SUCCESS|FAILURE] constants, instead of instead of arbitrary numbers or libxl return codes. Signed-off-by: Harmandeep Kaur <write.harmand...@gmail.com> --- v2->v3: Fixed return of main_vcpuset. tools/libxl/xl_cmdim

[Xen-devel] [PATCH v3 1/5] xl: convert main() exit codes to EXIT_[SUCCESS|FAILURE]

() as if they are returning a process exit status and not a function return value) Signed-off-by: Harmandeep Kaur <write.harmand...@gmail.com> --- v2->v3: Commented more precisely and aligned comment properly. v1->v2: Applied new approach (main() functions return EXIT_SUCCESS/FAILURE and other functi

[Xen-devel] [PATCH v3 2/5] xl: improve return and exit codes of scheduling related functions

ed-off-by: Harmandeep Kaur <write.harmand...@gmail.com> --- v2->v3: Reverted removal of 'rc' in sched_domain_output(). tools/libxl/xl_cmdimpl.c | 139 +++ 1 file changed, 67 insertions(+), 72 deletions(-) diff --git a/tools/libxl/xl_cmdimpl.c b/tools/lib

[Xen-devel] [PATCH v3 0/5] xl: convert exit codes to EXIT_[SUCCESS|FAILURE]

this patch: https://www.mail-archive.com/xen-devel@lists.xen.org/msg42850.html *v1 of this patch: http://lists.xenproject.org/archives/html/xen-devel/2015-10/msg02497.html *v2 of this patch: http://lists.xenproject.org/archives/html/xen-devel/2015-10/msg02623.html Signed-off-by: Harmandeep Kaur <

[Xen-devel] [PATCH v3 5/5] xl: improve return and exit codes of parse related functions

touch parse_config_data() which is big enough to deserve its own patch. Signed-off-by: Harmandeep Kaur <write.harmand...@gmail.com> --- v2->v3: Reverted return of parse_mem_size_kb() to -1. And exculded out of scope changes. tools/libxl/xl_cmdimpl.c | 51

[Xen-devel] [PATCH v5 1/5] xl: convert main() exit codes to EXIT_[SUCCESS|FAILURE]

() as if they are returning a process exit status and not a function return value) Signed-off-by: Harmandeep Kaur <write.harmand...@gmail.com> Reviewed-by: Dario Faggioli <dario.faggi...@citrix.com> Acked-by: Wei Liu <wei.l...@citrix.com> --- v4->v5: No changes. v3->v4: Aligned comment correctly

[Xen-devel] [PATCH v5 5/5] xl: improve return and exit codes of parse related functions

touch parse_config_data() which is big enough to deserve its own patch. Signed-off-by: Harmandeep Kaur <write.harmand...@gmail.com> Reviewed-by: Dario Faggioli <dario.faggi...@citrix.com> Acked-by: Wei Liu <wei.l...@citrix.com> --- v4->v5: No changes. v3->v4: Exculded out of scope ch

[Xen-devel] [PATCH v5 3/5] xl: improve return and exit codes of vcpu related functions

Turning vcpu manipulation functions exit codes toward using the EXIT_[SUCCESS|FAILURE] constants, instead of instead of arbitrary numbers or libxl return codes. Signed-off-by: Harmandeep Kaur <write.harmand...@gmail.com> Reviewed-by: Dario Faggioli <dario.faggi...@citrix.com> Acked

[Xen-devel] [PATCH v5 2/5] xl: improve return and exit codes of scheduling related functions

ed-off-by: Harmandeep Kaur <write.harmand...@gmail.com> Reviewed-by: Dario Faggioli <dario.faggi...@citrix.com> Acked-by: Wei Liu <wei.l...@citrix.com> --- v4->v5: Corrected coding style. v3->v4: No changes. v2->v3: Reverted removal of 'rc' in sched_domain_output().

[Xen-devel] [PATCH v5 4/5] xl: improve return and exit codes of cpupool related functions

Turning cpupools related functions exit codes towards using the EXIT_[SUCCESS|FAILURE] constants, instead of instead of arbitrary numbers or libxl return codes. Signed-off-by: Harmandeep Kaur <write.harmand...@gmail.com> Reviewed-by: Dario Faggioli <dario.faggi...@citrix.com> Acked

[Xen-devel] [PATCH v5 0/5] xl: convert exit codes to EXIT_[SUCCESS|FAILURE]

roject.org/archives/html/xen-devel/2015-10/msg02872.html *v4 of this patch: http://lists.xenproject.org/archives/html/xen-devel/2015-10/msg02947.html Signed-off-by: Harmandeep Kaur <write.harmand...@gmail.com> --- ___ Xen-devel mailin

[Xen-devel] [PATCH v4 5/5] xl: improve return and exit codes of parse related functions

touch parse_config_data() which is big enough to deserve its own patch. Signed-off-by: Harmandeep Kaur <write.harmand...@gmail.com> Reviewed-by: Dario Faggioli <dario.faggi...@citrix.com> --- v3->v4: Exculded out of scope changes. v2->v3: Reverted return of parse_mem_size_kb() to -1.

[Xen-devel] [PATCH v4 3/5] xl: improve return and exit codes of vcpu related functions

Turning vcpu manipulation functions exit codes toward using the EXIT_[SUCCESS|FAILURE] constants, instead of instead of arbitrary numbers or libxl return codes. Signed-off-by: Harmandeep Kaur <write.harmand...@gmail.com> Reviewed-by: Dario Faggioli <dario.faggi...@citrix.com>

[Xen-devel] [PATCH v4 2/5] xl: improve return and exit codes of scheduling related functions

ed-off-by: Harmandeep Kaur <write.harmand...@gmail.com> Reviewed-by: Dario Faggioli <dario.faggi...@citrix.com> --- v3->v4: No changes. v2->v3: Reverted removal of 'rc' in sched_domain_output(). tools/libxl/xl_cmdimpl.c | 139 +++ 1 file chang

[Xen-devel] [PATCH v4 1/5] xl: convert main() exit codes to EXIT_[SUCCESS|FAILURE]

() as if they are returning a process exit status and not a function return value) Signed-off-by: Harmandeep Kaur <write.harmand...@gmail.com> Acked-by: Wei Liu <wei.l...@citrix.com> Reviewed-by: Dario Faggioli <dario.faggi...@citrix.com> --- v3->v4: Aligned comment correctly. v2->v3: Commented mo

[Xen-devel] [PATCH v4 4/5] xl: improve return and exit codes of cpupool related functions

Turning cpupools related functions exit codes towards using the EXIT_[SUCCESS|FAILURE] constants, instead of instead of arbitrary numbers or libxl return codes. Signed-off-by: Harmandeep Kaur <write.harmand...@gmail.com> Reviewed-by: Dario Faggioli <dario.faggi...@citrix.com>

[Xen-devel] [PATCH v4 0/5] xl: convert exit codes to EXIT_[SUCCESS|FAILURE]

roject.org/archives/html/xen-devel/2015-10/msg02872.html Signed-off-by: Harmandeep Kaur <write.harmand...@gmail.com> --- ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

[Xen-devel] [PATCH 2/3] xl: convert vcpu related return codes to EXIT_[SUCCESS|FAILURE]

turning vcpu manipulation functions xl exit codes toward using the EXIT_[SUCCESS|FAILURE] macros, instead of instead of arbitrary numbers or libxl return codes. Signed-off-by: Harmandeep Kaur <write.harmand...@gmail.com> --- tools/libxl/xl_cmdimpl.

[Xen-devel] [PATCH 3/3] xl: convert cpupool related return codes to EXIT_[SUCCESS|FAILURE]

turning cpupools related functions xl exit codes towards using the EXIT_[SUCCESS|FAILURE] macros, instead of instead of arbitrary numbers or libxl return codes. Signed-off-by: Harmandeep Kaur <write.harmand...@gmail.com> --- tools/libxl/xl_cmdimpl.

[Xen-devel] [PATCH 1/3] xl: convert scheduling related return codes to EXIT_[SUCCESS|FAILURE]

turning scheduling related functions xl exit codes towards using the EXIT_[SUCCESS|FAILURE] macros, instead of instead of arbitrary numbers or libxl return codes. Signed-off-by: Harmandeep Kaur <write.harmand...@gmail.com> --- tools/libxl/xl_cmdimpl.

Re: [Xen-devel] [PATCH 3/3] xl: convert cpupool related return codes to EXIT_[SUCCESS|FAILURE]

On Fri, Oct 23, 2015 at 5:40 PM, Dario Faggioli wrote: > > int main_cpupooldestroy(int argc, char **argv) > > @@ -7580,13 +7580,13 @@ int main_cpupooldestroy(int argc, char > > **argv) > > if (libxl_cpupool_qualifier_to_cpupoolid(ctx, pool, , > > NULL) || > >

[Xen-devel] [PATCH v2 5/5] xl: improve return and exit codes of parse related functions

turning parsing related functions xl exit codes towards using the EXIT_[SUCCESS|FAILURE] macros, instead of instead of arbitrary numbers or libxl return codes. it doesn't include parse_config_data() which is big enough to deserve its own patch Signed-off-by: Harmandeep Kaur <write.harm

[Xen-devel] [PATCH v2 2/5] xl: improve return and exit codes of scheduling related functions

turning scheduling related functions xl exit codes towards using the EXIT_[SUCCESS|FAILURE] macros, instead of instead of arbitrary numbers or libxl return codes. Signed-off-by: Harmandeep Kaur <write.harmand...@gmail.com> --- tools/libxl/xl_cmdimpl.c

[Xen-devel] [PATCH v2 4/5] xl: improve return and exit codes of cpupool related functions

turning cpupools related functions xl exit codes towards using the EXIT_[SUCCESS|FAILURE] macros, instead of instead of arbitrary numbers or libxl return codes. Signed-off-by: Harmandeep Kaur <write.harmand...@gmail.com> --- tools/libxl/xl_cmdimpl.

[Xen-devel] [PATCH v2 3/5] xl: improve return and exit codes of vcpu related functions

turning vcpu manipulation functions xl exit codes toward using the EXIT_[SUCCESS|FAILURE] macros, instead of instead of arbitrary numbers or libxl return codes. Signed-off-by: Harmandeep Kaur <write.harmand...@gmail.com> --- tools/libxl/xl_cmdimpl.c | 20 ++-- 1 file chang

[Xen-devel] [PATCH v2 1/5] xl: convert exit codes to EXIT_[SUCCESS|FAILURE]

() as if they are returning a process exit status and not a function return value) Signed-off-by: Harmandeep Kaur <write.harmand...@gmail.com> --- tools/libxl/xl.c | 12 ++-- tools/libxl/xl.h | 6 ++ 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/tools/libxl/xl.c b/tools/libxl/xl.c

[Xen-devel] [PATCH v2 0/5] xl: convert exit codes to EXIT_[SUCCESS|FAILURE]

this patch: https://www.mail-archive.com/xen-devel@lists.xen.org/msg42850.html *v1 of this patch http://lists.xenproject.org/archives/html/xen-devel/2015-10/msg02497.html Signed-off-by: Harmandeep Kaur <write.harmand...@gmail.com> --- ___ Xen-devel