Re: [Xen-devel] [v3,11/41] mips: reuse asm-generic/barrier.h

ctures. > > Does that help? This is crazy! smp_rmb started out being strictly stronger than smp_read_barrier_depends, when did this stop being the case? -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org

Re: [Xen-devel] tcp: refine TSO autosizing causes performance regression on Xen

rendering such hints incorrect. Cheers, -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ___ Xen-devel mailing list Xen-devel@lists.xen.org http

[Xen-devel] [0/4] net: net_rx_action fixes and clean-ups

, -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

[Xen-devel] [PATCH 1/4] net: Move napi polling code out of net_rx_action

This patch creates a new function napi_poll and moves the napi polling code from net_rx_action into it. Signed-off-by: Herbert Xu herb...@gondor.apana.org.au --- net/core/dev.c | 98 +++-- 1 file changed, 54 insertions(+), 44 deletions

[Xen-devel] [PATCH 3/4] net: Always poll at least one device in net_rx_action

We should only perform the softnet_break check after we have polled at least one device in net_rx_action. Otherwise a zero or negative setting of netdev_budget can lock up the whole system. Signed-off-by: Herbert Xu herb...@gondor.apana.org.au --- net/core/dev.c |7 +++ 1 file changed

[Xen-devel] [PATCH 2/4] net: Detect drivers that reschedule NAPI and exhaust budget

The commit d75b1ade567ffab085e8adbbdacf0092d10cd09c (net: less interrupt masking in NAPI) required drivers to leave poll_list empty if the entire budget is consumed. We have already had two broken drivers so let's add a check for this. Signed-off-by: Herbert Xu herb...@gondor.apana.org.au

[Xen-devel] [PATCH 4/4] net: Rearrange loop in net_rx_action

This patch rearranges the loop in net_rx_action to reduce the amount of jumping back and forth when reading the code. Signed-off-by: Herbert Xu herb...@gondor.apana.org.au --- net/core/dev.c | 26 -- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/net

[Xen-devel] virtio_net: Fix napi poll list corruption

belatedly realised that it was virtio_net which caused the stall even though the virtio_net poll was still functioning perfectly after IPsec stalled. Signed-off-by: Herbert Xu herb...@gondor.apana.org.au diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index b8bd719..5ca9771 100644

[Xen-devel] net: Detect drivers that reschedule NAPI and exhaust budget

On Sat, Dec 20, 2014 at 11:23:27AM +1100, Herbert Xu wrote: A similar bug exists in virtio_net. In order to detect other drivers doing this we should add something like this. -- 8 -- The commit d75b1ade567ffab085e8adbbdacf0092d10cd09c (net: less interrupt masking in NAPI) required drivers

Re: [Xen-devel] net: Detect drivers that reschedule NAPI and exhaust budget

to leave poll_list empty if the entire budget is consumed. We have already had two broken drivers so let's add a check for this. Signed-off-by: Herbert Xu herb...@gondor.apana.org.au diff --git a/net/core/dev.c b/net/core/dev.c index f411c28..47fdc5c 100644 --- a/net/core/dev.c +++ b/net/core/dev.c