[Xen-devel] [PATCH V2 2/3] docs: fix typo in xl-disk-configuration.txt

Signed-off-by: Jim Fehlig <jfeh...@suse.com> Acked-by: Ian Campbell <ian.campb...@citrix.com> --- docs/misc/xl-disk-configuration.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/misc/xl-disk-configuration.txt b/docs/misc/xl-disk-configuration.txt i

[Xen-devel] [PATCH V2 3/3] docs: add more info about target= in disk config

target= in disk config can be used to convey arbitrary configuration information to backends. Add a bit more info to xl-disk-configuration.txt to clarify this, including some simple nbd and rbd qdisk configurations. Signed-off-by: Jim Fehlig <jfeh...@suse.com> --- docs/misc/x

[Xen-devel] [PATCH V2 1/3] libxlu_cfg: reject unknown characters following '\'

of discarding the '\' and unknown character, reject the string and set error to EINVAL. Signed-off-by: Jim Fehlig <jfeh...@suse.com> Acked-by: Ian Campbell <ian.campb...@citrix.com> --- tools/libxl/libxlu_cfg.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tools/libxl/libxlu_c

[Xen-devel] [PATCH V2 0/3] libxl and docs: small improvements in qdisk support

reviewing xl-disk-configuration.txt, which is improved a bit in patch3 wrt target= syntax. V2: Add forgotten SOB in all patches Improve patch3 doc text Jim Fehlig (3): libxlu_cfg: reject unknown characters following '\' docs: fix typo in xl-disk-configuration.txt docs: add more info about target

[Xen-devel] [PATCH 2/3] docs: fix typo in xl-disk-configuration.txt

--- docs/misc/xl-disk-configuration.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/misc/xl-disk-configuration.txt b/docs/misc/xl-disk-configuration.txt index 6a2118d..29f6ddb 100644 --- a/docs/misc/xl-disk-configuration.txt +++ b/docs/misc/xl-disk-configuration.txt

[Xen-devel] [PATCH 0/3] libxl and docs: small improvements in qdisk support

reviewing xl-disk-configuration.txt, which is improved a bit in patch3 wrt target= syntax. Jim Fehlig (3): libxlu_cfg: reject unknown characters following '\' docs: fix typo in xl-disk-configuration.txt docs: add more info about target= in disk config docs/misc/xl-disk-configuration.txt | 12

[Xen-devel] [PATCH 1/3] libxlu_cfg: reject unknown characters following '\'

When dequoting config strings in xlu__cfgl_dequote(), unknown characters following a '\', and the '\' itself, are discarded. E.g. a disk configuration string containing rbd:pool/image:mon_host=192.168.0.100\:6789 would be dequoted as rbd:pool/image:mon_host=192.168.0.1006789 Instead of

[Xen-devel] [PATCH 3/3] docs: add more info about target= in disk config

target= in disk config can be used to convey arbitrary configuration information to backends. Add a bit more info to xl-disk-configuration.txt to clarify this, including some simple nbd and rbd qdisk configurations. --- docs/misc/xl-disk-configuration.txt | 10 +- 1 file changed, 9

Re: [Xen-devel] [PATCH 0/4] xl: consolidate adhoc parsers

Wei Liu wrote: > This patch series consolidates adhoc parsers in xl. Hi Wei, I never tested or reviewed this series after seeing Ian's comments. Did you have time to work on a V2? Or did I miss a V2? :-) Let me know if I can help. Regards, Jim ___

[Xen-devel] [PATCH 3/4] xenconfig: support xl<->xml conversion of rbd disk devices

of config is not handled in this patch, but can be done in a follow-up patch. Also add a test for the conversions. Signed-off-by: Jim Fehlig <jfeh...@suse.com> --- src/xenconfig/xen_xl.c | 145 +-- tests/xlconfigdata/test-rbd-multihost-noauth.cfg |

[Xen-devel] [PATCH 1/4] xenconfig: replace text 'xm' with 'xl' in xlconfigtest

While at it, improve a few comments. No functional change. Signed-off-by: Jim Fehlig <jfeh...@suse.com> --- tests/xlconfigtest.c | 34 +++--- 1 file changed, 19 insertions(+), 15 deletions(-) diff --git a/tests/xlconfigtest.c b/tests/xlconfigtest.c index 4

[Xen-devel] [PATCH 4/4] libxl: add support for rbd qdisk

the pdev_path field of libxl_device_disk struct. libxl then passes the URL to qemu for cosumption by the rbd backend. Signed-off-by: Jim Fehlig <jfeh...@suse.com> --- src/libxl/libxl_conf.c | 192 - 1 file changed, 191 insertions(+), 1 de

[Xen-devel] [PATCH 0/4] libxl: support qemu's network-based block backends

s support for converting rbd info between xl and xml config formats. Patch 4 adds support for rbd disks in the libxl driver. Jim Fehlig (4): xenconfig: replace text 'xm' with 'xl' in xlconfigtest xenconfig: produce key=value disk config syntax in xl formatter xenconfig: support xl<->

[Xen-devel] [PATCH 2/4] xenconfig: produce key=value disk config syntax in xl formatter

. Signed-off-by: Jim Fehlig <jfeh...@suse.com> --- src/xenconfig/xen_xl.c | 27 ++- .../test-disk-positional-parms-full.cfg| 26 +++ .../test-disk-positional-parms-full.xml| 54 ++ .../test-disk-positional

Re: [Xen-devel] [PATCH v4 1/2] libxl: add p2p migration

On 02/05/2016 01:45 PM, Joao Martins wrote: > Introduce support for VIR_MIGRATE_PEER2PEER in libvirt migration. > Most of the changes occur at the source and no modifications at > the receiver. > > In P2P mode there is only the Perform phase so we must handle the > connection with the destination

Re: [Xen-devel] [PATCH v4 2/2] libxl: keepalive messages support

On 02/05/2016 01:45 PM, Joao Martins wrote: > This patch introduces keep alive messages support for P2P migration > and it adds two new configuration entries namely 'keepalive_interval' > 'keepalive_count' to control it. Behavior of these entries is the > same as qemu driver thus the description

Re: [Xen-devel] [RFC] support more qdisk types

On 02/03/2016 07:53 PM, Jim Fehlig wrote: > On 02/03/2016 02:56 AM, Ian Campbell wrote: >> On Tue, 2016-02-02 at 15:06 -0700, Jim Fehlig wrote: >>>> And extending >>>> the structure seems to be the right thing to do. >>> So what do you think of the a

Re: [Xen-devel] [PATCH v3 1/3] libxl: add p2p migration

On 02/03/2016 12:36 PM, Joao Martins wrote: > > On 02/02/2016 11:41 PM, Jim Fehlig wrote: >> Also, if the connection dies, how are we informed about that? >> Would that be done via the connect close callback that was removed in this >> version? It is not clear to me

Re: [Xen-devel] [RFC] support more qdisk types

On 02/03/2016 02:56 AM, Ian Campbell wrote: > On Tue, 2016-02-02 at 15:06 -0700, Jim Fehlig wrote: >>> And extending >>> the structure seems to be the right thing to do. >> So what do you think of the approach in the RFC patch? It adds discrete >> knobs in >&g

Re: [Xen-devel] [libvirt test] 79891: regressions - FAIL

osstest service owner wrote: > flight 79891 libvirt real [real] > http://logs.test-lab.xenproject.org/osstest/logs/79891/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: > build-amd64-libvirt 5 libvirt-build

Re: [Xen-devel] [RFC] support more qdisk types

Wei Liu wrote: > On Mon, Jan 25, 2016 at 05:25:02PM -0700, Jim Fehlig wrote: >> I would like to hear the community's opinion on supporting more qdisk types >> in >> xl/libxl, e.g. nbd, rbd, iSCSI, etc. I prefer supporting additional qdisk >> types >> in libxl o

Re: [Xen-devel] [PATCH v3 1/3] libxl: add p2p migration

Joao Martins wrote: > Introduce support for VIR_MIGRATE_PEER2PEER in libvirt migration. > Most of the changes occur at the source and no modifications > at the receiver. > > In P2P mode there is only the Perform phase so we must handle > the connection with the destination and actually perform

Re: [Xen-devel] [PATCH v3 2/3] libxl: move begin phase job handling

Joao Martins wrote: > > On 02/02/2016 01:23 AM, Jim Fehlig wrote: >> On 01/20/2016 12:00 PM, Joao Martins wrote: >>> . From libxlMigrationBegin to libxlDomainMigrateBegin3Params(). >>> This is a preparatory patch to be able to begin a job in the >>> per

Re: [Xen-devel] [PATCH v3 2/3] libxl: move begin phase job handling

On 01/20/2016 12:00 PM, Joao Martins wrote: > . From libxlMigrationBegin to libxlDomainMigrateBegin3Params(). > This is a preparatory patch to be able to begin a job in the > perform phase. > > Signed-off-by: Joao Martins > --- > src/libxl/libxl_driver.c| 18

Re: [Xen-devel] [PATCH v3 1/3] libxl: add p2p migration

On 01/20/2016 12:00 PM, Joao Martins wrote: > Introduce support for VIR_MIGRATE_PEER2PEER in libvirt migration. > Most of the changes occur at the source and no modifications > at the receiver. > > In P2P mode there is only the Perform phase so we must handle > the connection with the destination

Re: [Xen-devel] [RFC] support more qdisk types

Konrad Rzeszutek Wilk wrote: > On Wed, Jan 27, 2016 at 07:42:49PM -0700, Jim Fehlig wrote: >> On 01/27/2016 02:09 PM, Konrad Rzeszutek Wilk wrote: >>> On Wed, Jan 27, 2016 at 02:25:51PM -0600, Doug Goldstein wrote: >>>> On 1/27/16 12:32 PM, Konrad Rzeszutek Wilk wro

Re: [Xen-devel] [RFC] support more qdisk types

On 01/27/2016 11:32 AM, Konrad Rzeszutek Wilk wrote: > On Mon, Jan 25, 2016 at 05:25:02PM -0700, Jim Fehlig wrote: >> I would like to hear the community's opinion on supporting more qdisk types >> in >> xl/libxl, e.g. nbd, rbd, iSCSI, etc. I prefer supporting addit

Re: [Xen-devel] [RFC] support more qdisk types

On 01/27/2016 02:09 PM, Konrad Rzeszutek Wilk wrote: > On Wed, Jan 27, 2016 at 02:25:51PM -0600, Doug Goldstein wrote: >> On 1/27/16 12:32 PM, Konrad Rzeszutek Wilk wrote: >>> On Mon, Jan 25, 2016 at 05:25:02PM -0700, Jim Fehlig wrote: >>>> I would like t

Re: [Xen-devel] [RFC] support more qdisk types

On 01/27/2016 01:25 PM, Doug Goldstein wrote: > On 1/27/16 12:32 PM, Konrad Rzeszutek Wilk wrote: >> On Mon, Jan 25, 2016 at 05:25:02PM -0700, Jim Fehlig wrote: >>> I would like to hear the community's opinion on supporting more qdisk types >>> in >>> xl/libxl,

[Xen-devel] [RFC] support more qdisk types

the proposal. Suggests, comments, and feedback warmly welcomed. Regards, Jim >From 3a6aeb434506c620dd122b9ff19656bcdd35f081 Mon Sep 17 00:00:00 2001 From: Jim Fehlig <jfeh...@suse.com> Date: Mon, 25 Jan 2016 16:57:42 -0700 Subject: [PATCH] [RFC] support more qdisk types Extend xl-disk-conf

Re: [Xen-devel] disk=['file://..xvda'] not working for boot disks anymore?

On 01/22/2016 02:54 PM, Konrad Rzeszutek Wilk wrote: > On Fri, Jan 22, 2016 at 03:59:09PM -0500, Boris Ostrovsky wrote: >> On 01/22/2016 03:54 PM, Konrad Rzeszutek Wilk wrote: >>> Hey, >>> >>> This parameter >>> disk = >>>

Re: [Xen-devel] [PATCH LIBVIRT v2] libxl: Support cmdline= in xl config files

Ian Campbell wrote: > On Wed, 2016-01-20 at 11:16 -0700, Jim Fehlig wrote: >> Ian Campbell wrote: >>> ... and consolidate the cmdline/extra/root parsing to facilitate doing >>> so. >>> >>> The logic is the same as xl's parse_cmdline f

Re: [Xen-devel] [PATCH LIBVIRT v3] libxl: Support cmdline= in xl config files

Ian Campbell wrote: > ... and consolidate the cmdline/extra/root parsing to facilitate doing > so. > > The logic is the same as xl's parse_cmdline from the current xen.git master > branch (e6f0e099d2c17de47fd86e817b1998db903cab61). > > On the formatting side switch to producing cmdline= instead

Re: [Xen-devel] [PATCH v2] libxl: dispose libxl_dominfo after libxl_domain_info()

Joao Martins wrote: > As suggested in a previous thread [0] this patch adds some missing calls > to libxl_dominfo_{init,dispose} when doing some of the libxl_domain_info > operations which would otherwise lead to memory leaks. > > [0] >

Re: [Xen-devel] [PATCH] libxl: dispose libxl_dominfo after libxl_domain_info()

Joao Martins wrote: > As suggested in a previous thread [0] this patch adds some missing calls > to libxl_dominfo_dispose when doing some of the libxl_domain_info > operations which would otherwise lead to memory leaks. > > [0] >

Re: [Xen-devel] [PATCH LIBVIRT v2] libxl: Support cmdline= in xl config files

Ian Campbell wrote: > ... and consolidate the cmdline/extra/root parsing to facilitate doing > so. > > The logic is the same as xl's parse_cmdline from the current xen.git master > branch (e6f0e099d2c17de47fd86e817b1998db903cab61). > > In order to introduce a use of VIR_WARN for logging I had to

Re: [Xen-devel] [PATCH V13 5/5] xl: add pvusb commands

On 01/19/2016 11:11 AM, Ian Jackson wrote: > Chunyan Liu writes ("[PATCH V13 5/5] xl: add pvusb commands"): >> Add pvusb commands: usbctrl-attach, usbctrl-detach, usb-list, >> usbdev-attach and usbdev-detach. > Thanks for swapping this with the other patch. It is better now. > >> +=item B I I >

Re: [Xen-devel] [PATCH LIBVIRT] libxl: Support cmdline= in xl config files

On 01/19/2016 05:03 AM, Ian Campbell wrote: > I went to ping this but noticed that I had sent it to "jimfehlig" (i.e. no > domain), so no wonder there was no reply! > > To: line fixed here, let me know if you would prefer a resend. That would be much appreciated, thanks! > > Ian. > > On Wed,

Re: [Xen-devel] [PATCH 03/28] libxl: Provide libxl__dm_support_*

On 01/15/2016 02:56 AM, Ian Campbell wrote: > On Thu, 2016-01-14 at 11:31 -0700, Jim Fehlig wrote: >> Ian Campbell wrote: >>> On Mon, 2016-01-11 at 10:00 -0700, Jim Fehlig wrote: >>>> On 01/07/2016 10:13 AM, Ian Campbell wrote: >>>>> On Tue,

Re: [Xen-devel] [PATCH 03/28] libxl: Provide libxl__dm_support_*

Ian Campbell wrote: > On Mon, 2016-01-11 at 10:00 -0700, Jim Fehlig wrote: >> On 01/07/2016 10:13 AM, Ian Campbell wrote: >>> On Tue, 2015-12-22 at 18:44 +, Ian Jackson wrote: >>>> This allows code elsewhere in libxl to find out what options a device

Re: [Xen-devel] [PATCH 03/28] libxl: Provide libxl__dm_support_*

On 01/07/2016 10:13 AM, Ian Campbell wrote: > On Tue, 2015-12-22 at 18:44 +, Ian Jackson wrote: >> This allows code elsewhere in libxl to find out what options a device >> model executable supports. This is done by searching the usage >> message for fixed strings. > Has anyone (ever, not

Re: [Xen-devel] Missing libvirt+libxl functionality (Was: Re: [Xen-users] Programmatic administration of Xen machines)

On 01/08/2016 05:46 AM, Ian Campbell wrote: > On Thu, 2016-01-07 at 22:54 -0700, Jim Fehlig wrote: >>>> I had even more trouble, e.g. I wasn't able to use non-standard block >>>> scripts (neither via /etc/xen/scripts/block-XXX nor via a script >>>>

Re: [Xen-devel] [libvirt] [PATCH V2 0/3] Xen: Support vif outging bandwidth QoS

On 01/08/2016 09:45 AM, Michal Privoznik wrote: > On 05.01.2016 02:08, Jim Fehlig wrote: >> Happy New Year! >> >> This small series adds support for specifying vif outgoing rate limits >> in Xen. The first patch adds support for converting rate limits between >> se

Re: [Xen-devel] [libvirt] [PATCH 2/2] libxl: support vif outgoing bandwidth QoS

On 01/07/2016 07:48 AM, Michal Privoznik wrote: > On 29.12.2015 02:09, Jim Fehlig wrote: >> The libxl_device_nic structure supports specifying an outgoing rate >> limit based on a time interval and bytes allowed per interval. In xl >> config a rate limit is specifi

Re: [Xen-devel] [libvirt] [PATCH 1/2] xenconfig: support parsing and formatting vif bandwidth

On 01/07/2016 07:48 AM, Michal Privoznik wrote: > On 29.12.2015 02:09, Jim Fehlig wrote: >> Both xm and xl config have long supported specifying vif rate >> limiting, e.g. >> >> vif = [ 'mac=00:16:3E:74:3d:76,bridge=br0,rate=10MB/s' ] >> >> A

Re: [Xen-devel] Missing libvirt+libxl functionality (Was: Re: [Xen-users] Programmatic administration of Xen machines)

On 01/04/2016 05:37 AM, Ian Campbell wrote: > On Mon, 2016-01-04 at 13:31 +0100, Andreas Pflug wrote: >> Am 04.01.16 um 13:13 schrieb Ian Campbell: >>> On Mon, 2016-01-04 at 12:47 +0100, Andreas Pflug wrote: Am 04.01.16 um 12:36 schrieb Ian Campbell: > Sorry to hijack this thread. >

[Xen-devel] [PATCH V2 3/3] libxl: support vif outgoing bandwidth QoS

eak, burst, and floor attributes in units of KB/s. This patch supports the outgoing bandwidth limit by converting the average KB/s to bytes per interval based on the same default interval (50ms) used by xl. Signed-off-by: Jim Fehlig <jfeh...@suse.com> --- src/libxl/l

[Xen-devel] [PATCH V2 1/3] xenconfig: support vif bandwidth in sexpr parser and formatter

, the old xen driver will now be able to handle vif 'rate' setting when communicating with xend. Signed-off-by: Jim Fehlig <jfeh...@suse.com> --- I used a bit of code from libxlu_vif.c to implement xenParseSxprVifRate() instead of using the libxlutil lib directly, since rate limiting applies to t

[Xen-devel] [PATCH V2 2/3] xenconfig: support vif bandwidth in xm and xl parser and formatter

. ... Also add a unit test to check the conversion logic. Signed-off-by: Jim Fehlig <jfeh...@suse.com> --- src/xenconfig/xen_common.c | 30 +++ tests/xlconfigdata/test-vif-rate.cfg | 26 tests/xlconfigdata/test-vif-rate.xm

[Xen-devel] [PATCH V2 0/3] Xen: Support vif outging bandwidth QoS

. V1 here https://www.redhat.com/archives/libvir-list/2015-December/msg00899.html In V2 I've extended support to include the sexpr config format Jim Fehlig (3): xenconfig: support vif bandwidth in sexpr parser and formatter xenconfig: support vif bandwidth in xm and xl parser and formatter

[Xen-devel] [PATCH 0/2] Xen: Support vif outging bandwidth QoS

to the libxl driver. Jim Fehlig (2): xenconfig: support parsing and formatting vif bandwidth libxl: support vif outgoing bandwidth QoS src/libxl/libxl_conf.c | 39 ++ src/xenconfig/xen_common.c | 77 tests/xlconfigdata/test

[Xen-devel] [PATCH 2/2] libxl: support vif outgoing bandwidth QoS

eak, burst, and floor attributes in units of KB/s. This patch supports the outgoing bandwidth limit by converting the average KB/s to bytes per interval based on the same default interval (50ms) used by xl. Signed-off-by: Jim Fehlig <jfeh...@suse.com> --- src/libxl/l

[Xen-devel] [PATCH 1/2] xenconfig: support parsing and formatting vif bandwidth

. ... Also add a unit test to check the conversion logic. Signed-off-by: Jim Fehlig <jfeh...@suse.com> --- I used a bit of code from libxlu_vif.c to implement xenParseVifRate() instead of using the libxlutil lib directly, since in theory rate limiting applies to the o

Re: [Xen-devel] [libvirt] [PATCH V2] Xen: support maxvcpus in xm and xl config

On 12/18/2015 04:47 AM, Michal Privoznik wrote: > On 15.12.2015 23:20, Jim Fehlig wrote: >> From: Ian Campbell <ian.campb...@citrix.com> >> >> xend prior to 4.0 understands vcpus as maxvcpus and vcpu_avail >> as a bit map of which cpus are online (default is

Re: [Xen-devel] [libvirt bisection] complete build-i386-libvirt

On 12/14/2015 09:26 PM, osstest service owner wrote: > branch xen-unstable > xenbranch xen-unstable > job build-i386-libvirt > testid libvirt-build > > Tree: libvirt git://libvirt.org/libvirt.git > Tree: libvirt_gnulib git://git.sv.gnu.org/gnulib.git > Tree: qemu

Re: [Xen-devel] [PATCH v3 8/8] libxl: implement virDomainGetJobStats

On 12/03/2015 12:29 PM, Joao Martins wrote: > > On 12/03/2015 06:48 PM, Jim Fehlig wrote: >> Joao Martins wrote: >>> Introduces support for domainGetJobStats which has the same >>> info as domainGetJobInfo but in a slightly different format. >>> Another diff

[Xen-devel] [PATCH V2] Xen: support maxvcpus in xm and xl config

, not a bit mask), which is particularly crucial on ARM where MAX_VIRT_CPUS == 1 (since all guests are expected to support vcpu placement, and therefore only the boot vcpu's info lives in the shared info page). Existing tests adjusted accordingly, and new tests added for the 'maxvcpus' setting. Si

Re: [Xen-devel] [libvirt] [PATCH LIBVIRT] libxl: Use libxentoollog in preference to libxenctrl if available.

On 12/14/2015 04:37 AM, Ian Campbell wrote: > On Mon, 2015-12-14 at 11:15 +, Daniel P. Berrange wrote: >> On Thu, Dec 10, 2015 at 11:38:36AM +, Ian Campbell wrote: >>> Upstream Xen is in the process of splitting the (stable API) xtl_* >>> interfaces out from the (unstable API) libxenctrl

Re: [Xen-devel] [libvirt test] 65654: regressions - FAIL

On 12/14/2015 03:41 AM, Stefano Stabellini wrote: > On Fri, 11 Dec 2015, Ian Jackson wrote: >> Ian Campbell writes ("Re: [libvirt test] 65654: regressions - FAIL"): >>> On Fri, 2015-12-11 at 15:18 +, osstest service owner wrote: flight 65654 libvirt real [real]

Re: [Xen-devel] [PATCH v2] libxl: update check-xl-disk-parse

ead added support for parsing it in libxlu_disk_l.l :-) Looks good to me. Tested-by: Jim Fehlig <jfeh...@suse.com> Regards, Jim ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [libvirt] [FOR 1.3.0 PATCH] conf: add net device prefix for Xen

Daniel P. Berrange wrote: > On Mon, Dec 07, 2015 at 10:59:32PM -0700, Jim Fehlig wrote: >> On 12/07/2015 11:52 AM, Daniel P. Berrange wrote: >>> On Mon, Dec 07, 2015 at 09:42:21AM -0700, Jim Fehlig wrote: >>>> In commit d2e5538b1, the libxl driver was change

Re: [Xen-devel] [libvirt] [FOR 1.3.0 PATCH] conf: add net device prefix for Xen

On 12/07/2015 11:52 AM, Daniel P. Berrange wrote: > On Mon, Dec 07, 2015 at 09:42:21AM -0700, Jim Fehlig wrote: >> In commit d2e5538b1, the libxl driver was changed to copy interface >> names autogenerated by libxl to the corresponding network def in the >> domain's virDomainD

[Xen-devel] [FOR 1.3.0 PATCH] conf: add net device prefix for Xen

, allowing the autogenerated names to be excluded when parsing and formatting inactive config. Signed-off-by: Jim Fehlig <jfeh...@suse.com> --- This is an alternative approach to Joao's fix for this regression https://www.redhat.com/archives/libvir-list/2015-December/msg00197.html I

Re: [Xen-devel] [PATCH v2] libxl: free ifname on libxlDomainMigrationPrepareDef

On 12/04/2015 12:45 PM, Joao Martins wrote: > Commit d2e5538b1 changes virDomainDef to include ifnames > that autogenerated by libxl, and that are also cleared > on domain cleanup. One place that's missing is on > migration, when domain xml is sent to dst libvirtd and > would contain ifnames from

Re: [Xen-devel] [libvirt] [PATCH v2] libxl: free ifname on libxlDomainMigrationPrepareDef

On 12/06/2015 10:04 AM, Jim Fehlig wrote: > On 12/04/2015 12:45 PM, Joao Martins wrote: >> Commit d2e5538b1 changes virDomainDef to include ifnames >> that autogenerated by libxl, and that are also cleared >> on domain cleanup. One place that's missing is on >> migrati

Re: [Xen-devel] [libvirt] [PATCH v2] libxl: free ifname on libxlDomainMigrationPrepareDef

On 12/06/2015 10:59 AM, Jim Fehlig wrote: > On 12/06/2015 10:04 AM, Jim Fehlig wrote: >> On 12/04/2015 12:45 PM, Joao Martins wrote: >>> Commit d2e5538b1 changes virDomainDef to include ifnames >>> that autogenerated by libxl, and that are also cleared >>>

Re: [Xen-devel] [PATCH v2] libxl: add p2p migration

On 12/03/2015 12:18 PM, Joao Martins wrote: > > On 12/02/2015 11:27 PM, Jim Fehlig wrote: >> On 11/10/2015 08:32 AM, Joao Martins wrote: >>> Introduce support for VIR_MIGRATE_PEER2PEER in libxl driver >>> for supporting migration in Openstack. Most of the c

Re: [Xen-devel] [PATCH LIBVIRT v1 1/2] libxl: Correct value for xendConfigVersion to xen{Parse, Format}ConfigCommon

On 11/26/2015 09:59 AM, Ian Campbell wrote: > libxlConnectDomainXMLFromNative calls both xenParseXM and xenParseXL > with cfg->verInfo->xen_version_major, however AFAICT they both (either > inherently, or through there use of xenParseConfigCommon expect a > value from xenConfigVersionEnum (which

Re: [Xen-devel] [PATCH v3 8/8] libxl: implement virDomainGetJobStats

Joao Martins wrote: > Introduces support for domainGetJobStats which has the same > info as domainGetJobInfo but in a slightly different format. > Another difference is that virDomainGetJobStats can also > retrieve info on the most recently completed job. Though so > far this is only used in the

Re: [Xen-devel] [PATCH v2 2/2] libxl: implement virDomainInterfaceStats

On 12/02/2015 06:02 AM, Joao Martins wrote: > > On 12/02/2015 12:45 AM, Jim Fehlig wrote: >> On 11/23/2015 11:57 AM, Joao Martins wrote: >>> Introduce support for domainInterfaceStats API call for querying >>> network interface statistics. Consequently it also

Re: [Xen-devel] [PATCH v2] libxl: add p2p migration

On 11/10/2015 08:32 AM, Joao Martins wrote: > Introduce support for VIR_MIGRATE_PEER2PEER in libxl driver > for supporting migration in Openstack. Most of the changes > occur at the source and no modifications at the receiver. > > In P2P mode there is only the Perform phase so we must handle > the

Re: [Xen-devel] [osstest test] 64958: regressions - trouble: broken/fail/pass

On 11/25/2015 08:32 AM, Ian Campbell wrote: > On Wed, 2015-11-25 at 14:37 +, Ian Campbell wrote: >> 2015-11-21 23:06:44 Z executing ssh ... root@172.16.144.44 virsh >> domxml-from-native xen-xl /etc/xen/debian.jessie.guest.osstest.cfg > >> /etc/xen/debian.jessie.guest.osstest.cfg.xml >>

Re: [Xen-devel] [PATCH v2 1/2] libxl: rename libxlConsoleCallback

On 11/23/2015 11:56 AM, Joao Martins wrote: > . to a more generic name i.e. libxlDomainStartCallback, > since it will now cover another case other than the console. > > Signed-off-by: Joao Martins > --- > src/libxl/libxl_domain.c | 4 ++-- > 1 file changed, 2

Re: [Xen-devel] [PATCH v2 2/2] libxl: implement virDomainInterfaceStats

On 11/23/2015 11:57 AM, Joao Martins wrote: > Introduce support for domainInterfaceStats API call for querying > network interface statistics. Consequently it also enables the > use of `virsh domifstat ` command plus > seeing the interfaces names instead of "-" when doing > `virsh domiflist `. >

Re: [Xen-devel] [libvirt] [PATCH RFC] libxl: use libxl_event_wait to process libxl events

On 11/23/2015 01:59 PM, Jim Fehlig wrote: > > Thanks for your comments and ACK'ing the change . I'll submit a V2 that > retains > handling of shutdown event in a thread. While testing V2, I noticed occasionally missing a shutdown event. I can see from the logs that domain_death_xswa

Re: [Xen-devel] [PATCH 1/3] libxl: add libxl_domain_config to libxlDomainObjPrivate

On 11/20/2015 05:40 PM, Joao Martins wrote: > > On 11/20/2015 07:05 PM, Jim Fehlig wrote: >> On 11/19/2015 04:45 PM, Joao Martins wrote: >> >> You're not going to be happy with me... >> >>> This new field in libxlDomainObjPrivate is named "config

Re: [Xen-devel] [PATCH RFC] libxl: use libxl_event_wait to process libxl events

On 11/23/2015 04:24 AM, Ian Jackson wrote: > Jim Fehlig writes ("[PATCH RFC] libxl: use libxl_event_wait to process libxl > events"): >> Prior to this patch, libxl events were delivered to libvirt via >> the libxlDomainEventHandler callback registered with libxl. >

Re: [Xen-devel] [PATCH 1/3] libxl: add libxl_domain_config to libxlDomainObjPrivate

On 11/19/2015 04:45 PM, Joao Martins wrote: You're not going to be happy with me... > This new field in libxlDomainObjPrivate is named "config" > and is kept while the domain is active. While this sounded like a good idea when I mentioned it, I'm now worried that the config will quickly become

Re: [Xen-devel] [PATCH 3/3] libxl: implement virDomainInterfaceStats

On 11/19/2015 04:45 PM, Joao Martins wrote: > Introduce support for domainInterfaceStats API call for querying > network interface statistics. Consequently it also enables the > use of `virsh domifstat ` command plus > seeing the interfaces names instead of "-" when doing > `virsh domiflist `. >

Re: [Xen-devel] [PATCH RFC] libxl: use libxl_event_wait to process libxl events

On 11/20/2015 08:31 AM, Ian Campbell wrote: > On Fri, 2015-11-13 at 14:36 -0700, Jim Fehlig wrote: >> Prior to this patch, libxl events were delivered to libvirt via >> the libxlDomainEventHandler callback registered with libxl. >> Documenation in $xensrc/tools/libxl

Re: [Xen-devel] [libvirt] [PATCH v3 1/8] libxl: implement virDomainGetCPUStats

On 11/16/2015 07:59 PM, Jim Fehlig wrote: > On 11/13/2015 06:14 AM, Joao Martins wrote: > @@ -5233,6 +5342,7 @@ static virHypervisorDriver libxlHypervisorDriver = { > #endif > .nodeGetFreeMemory = libxlNodeGetFreeMemory, /* 0.9.0 */ > .nodeGet

Re: [Xen-devel] [PATCH v3 5/8] libxl: implement virDomainBlockStats

On 11/13/2015 06:14 AM, Joao Martins wrote: > Introduce initial support for domainBlockStats API call that > allow us to query block device statistics. openstack nova > uses this API call to query block statistics, alongside > virDomainMemoryStats and virDomainInterfaceStats. Note that > this

Re: [Xen-devel] [PATCH v3 2/8] libxl: implement virDomainMemorystats

On 11/18/2015 11:05 AM, Joao Martins wrote: > > On 11/17/2015 11:15 PM, Jim Fehlig wrote: >> Joao Martins wrote: >>> Introduce support for domainMemoryStats API call, which >>> consequently enables the use of `virsh dommemstat` command to >>> query for me

Re: [Xen-devel] [PATCH v3 4/8] util: add virDiskNameParse to handle disk and partition idx

On 11/13/2015 06:14 AM, Joao Martins wrote: > Introduce a new helper function "virDiskNameParse" which extends > virDiskNameToIndex but handling both disk index and partition index. > Also rework virDiskNameToIndex to be based on virDiskNameParse. > A test is also added for this function testing

Re: [Xen-devel] [PATCH v3 6/8] libxl: implement virConnectGetAllDomainStats

On 11/13/2015 06:14 AM, Joao Martins wrote: > Introduce support for connectGetAllDomainStats call that > allow us to _all_ domain(s) statistics including network, block, allows us to get > cpus and memory. Changes are rather mechanical and mostly > take care of the format to export the data. > >

Re: [Xen-devel] [PATCH v3 2/8] libxl: implement virDomainMemorystats

Joao Martins wrote: > Introduce support for domainMemoryStats API call, which > consequently enables the use of `virsh dommemstat` command to > query for memory statistics of a domain. We support > the following statistics: balloon info, available and currently > in use. swap-in, swap-out,

Re: [Xen-devel] [PATCH v3 3/8] libxl: implement virDomainInterfaceStats

Joao Martins wrote: > > On 11/17/2015 02:48 AM, Jim Fehlig wrote: >> On 11/13/2015 06:14 AM, Joao Martins wrote: >>> Introduce support for domainInterfaceStats API call for querying >>> network interface statistics. Consequently it also enables the >>

Re: [Xen-devel] [PATCH v3 3/8] libxl: implement virDomainInterfaceStats

On 11/13/2015 06:14 AM, Joao Martins wrote: > Introduce support for domainInterfaceStats API call for querying > network interface statistics. Consequently it also enables the > use of `virsh domifstat ` command. > > After succesful guest creation we fill the network > interfaces names based on

Re: [Xen-devel] [PATCH v3 2/8] libxl: implement virDomainMemorystats

On 11/13/2015 06:14 AM, Joao Martins wrote: > Introduce support for domainMemoryStats API call, which > consequently enables the use of `virsh dommemstat` command to > query for memory statistics of a domain. We support > the following statistics: balloon info, available and currently > in use.

Re: [Xen-devel] [PATCH v3 1/8] libxl: implement virDomainGetCPUStats

On 11/13/2015 06:14 AM, Joao Martins wrote: > Introduce support for domainGetCPUStats API call and consequently > allow us to use `virsh cpu-stats`. The latter returns a more brief > output than the one provided by`virsh vcpuinfo`. > > Signed-off-by: Joao Martins > ---

Re: [Xen-devel] [PATCH V2] libxl: relax readonly check introduced by XSA-142 fix

On 11/12/2015 07:40 PM, Jim Fehlig wrote: > The fix for XSA-142 is quite a big hammer, rejecting readonly > disk configuration even when the requested backend is known to > support readonly. While it is true that qemu doesn't support > readonly for emulated IDE or AHCI disks > >

[Xen-devel] [PATCH RFC] libxl: use libxl_event_wait to process libxl events

atch moves processing of libxl events to a thread, where libxl_event_wait() is used to collect events. This allows processing libxl events asynchronously in libvirt, avoiding the deadlock. Reported-by: max ustermann <usterman...@web.de> Signed-off-by: Jim Fehlig <jfeh...@suse.com> --- The on

Re: [Xen-devel] build issue due to '-Werror=cast-align' on ARM (armhf) [was: Re: [libvirt test] 63528: regressions - FAIL]

On 11/13/2015 10:00 AM, Dario Faggioli wrote: > Hello, > > The Xen Project's automated test suite is failing at running its > libvirt tests for a few time, like this: > > On Wed, 2015-11-04 at 09:04 +, osstest service owner wrote: >> flight 63528 libvirt real [real] >>

[Xen-devel] [PATCH V2] libxl: relax readonly check introduced by XSA-142 fix

when creating and emulated IDE or AHCI disk, but allows it when the backend is known to support readonly. Signed-off-by: Jim Fehlig <jfeh...@suse.com> --- V2: Along with IDE+readonly, blacklist AHCI+readonly since it is not supported by qemu either. tools/libxl/libxl_dm.

Re: [Xen-devel] [RFC] libxl: relax readonly check introduced by XSA-142 fix

Stefano Stabellini wrote: > On Wed, 11 Nov 2015, Jim Fehlig wrote: > >> Hi All, >> >> Apologies for only noticing the fix for XSA-142 as it starting flowing to our >> various downstreams. The current fix seems like quite a big hammer IMO. qemu >> doe

Re: [Xen-devel] [RFC] libxl: relax readonly check introduced by XSA-142 fix

Ian Campbell wrote: > On Thu, 2015-11-12 at 08:45 -0700, Jim Fehlig wrote: >> >>> The commit message doesn't say anything about AHCI. Are AHCI disks >>> actually emulated correctly by QEMU with readonly=on? >> I just double checked, and good thing since AHCI

[Xen-devel] [RFC] libxl: relax readonly check introduced by XSA-142 fix

creating and emulated IDE disk, but allows it when the backend is known to support readonly. Regards, Jim >From 3d58f93b58ab544b9ee168b7bbaf59de1c5532ce Mon Sep 17 00:00:00 2001 From: Jim Fehlig <jfeh...@suse.com> Date: Tue, 10 Nov 2015 11:33:44 -0700 Subject: [PATCH] libxl: relax reado

Re: [Xen-devel] [PATCH v8] run QEMU as non-root

Ian Campbell wrote: > On Tue, 2015-10-06 at 14:13 +0100, Stefano Stabellini wrote: >> On Mon, 5 Oct 2015, Ian Campbell wrote: >>> On Mon, 2015-10-05 at 16:53 +0100, Stefano Stabellini wrote: > Wasn't there some code to plumb this into xl at one point? Did that > get > dropped along the

Re: [Xen-devel] [libvirt test] 62376: regressions - FAIL

On 09/27/2015 02:35 AM, osstest service owner wrote: flight 62376 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/62376/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 5 libvirt-build

Re: [Xen-devel] [xen-unstable test] 62004: regressions - FAIL

On 09/17/2015 01:07 AM, Ian Campbell wrote: On Thu, 2015-09-17 at 01:22 +, osstest service owner wrote: flight 62004 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/62004/ test-amd64-amd64-libvirt-pairpass

<    1   2   3   4   >