[Xen-devel] [PATCH V2 3/3] libxl: drop virDomainObj lock when destroying a domain

2015-04-01 Thread Jim Fehlig
A destroy operation can take considerable time on large memory domains due to scrubbing the domain' memory. The operation is running in the context of a job, so unlocking the domain and allowing query operations is safe. Signed-off-by: Jim Fehlig jfeh...@suse.com --- V2: Unchanged src/libxl

[Xen-devel] [PATCH V2 2/3] libxl: acquire a job when destroying a domain

2015-04-01 Thread Jim Fehlig
A job should be acquired at the beginning of a domain destroy operation, not at the end when cleaning up the domain. Fix two occurrences of this late job acquisition in the libxl driver. Doing so renders libxlDomainCleanupJob unused, so it is removed. Signed-off-by: Jim Fehlig jfeh...@suse.com

[Xen-devel] [PATCH V2 0/3] libxl: domain destroy fixes

2015-04-01 Thread Jim Fehlig
V2 of a small series to fix issues wrt domain destroy https://www.redhat.com/archives/libvir-list/2015-March/msg01337.html Comments from Konrad and Martin are addressed in this version. Jim Fehlig (3): libxl: Move job acquisition in libxlDomainStart to callers libxl: acquire a job when

Re: [Xen-devel] [libvirt] [PATCH V2] libxl: fix dom0 balloon logic

2015-03-31 Thread Jim Fehlig
Martin Kletzander wrote: On Tue, Mar 24, 2015 at 02:43:42PM -0600, Jim Fehlig wrote: Recent testing on large memory systems revealed a bug in the Xen xl tool's freemem() function. When autoballooning is enabled, freemem() is used to ensure enough memory is available to start a domain

Re: [Xen-devel] [PATCH 0/3] libxl: domain destroy fixes

2015-03-30 Thread Jim Fehlig
Jim Fehlig wrote: Konrad Rzeszutek Wilk wrote: On Wed, Mar 25, 2015 at 02:08:33PM -0600, Jim Fehlig wrote: This small series of patches fixes some issues wrt domain destroy in the libxl driver. The primary motivation for this work is to prevent locking the virDomainObj during

Re: [Xen-devel] [PATCH 2/3] libxl: acquire a job when destroying a domain

2015-03-26 Thread Jim Fehlig
Konrad Rzeszutek Wilk wrote: On Wed, Mar 25, 2015 at 02:08:35PM -0600, Jim Fehlig wrote: A job should be acquired at the beginning of a domain destroy operation, not at the end when cleaning up the domain. Fix two occurances of this late job acquisition in the libxl driver. Doing so

Re: [Xen-devel] [PATCH] libxl: Fix memory leak if pthread_create fails.

2015-03-26 Thread Jim Fehlig
Konrad Rzeszutek Wilk wrote: If we fail to create the thread we leak the shutdown_info structure. Nice catch, thanks! ACK and pushed. Regards, Jim Signed-off-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com --- src/libxl/libxl_domain.c | 3 ++- 1 file changed, 2 insertions(+), 1

Re: [Xen-devel] [PATCH 3/3] libxl: drop virDomainObj lock when destroying a domain

2015-03-26 Thread Jim Fehlig
Ian Campbell wrote: On Wed, 2015-03-25 at 14:08 -0600, Jim Fehlig wrote: A destroy operation can take considerable time on large memory domains due to scrubbing the domain' memory. The operation is running in the context of a job, so unlocking the domain and allowing query operations

[Xen-devel] [PATCH 2/3] libxl: acquire a job when destroying a domain

2015-03-25 Thread Jim Fehlig
A job should be acquired at the beginning of a domain destroy operation, not at the end when cleaning up the domain. Fix two occurances of this late job acquisition in the libxl driver. Doing so renders libxlDomainCleanup unused, so it is removed. Signed-off-by: Jim Fehlig jfeh...@suse.com

[Xen-devel] [PATCH 1/3] libxl: Move job acquisition in libxlDomainStart to callers

2015-03-25 Thread Jim Fehlig
Let callers of libxlDomainStart decide when it is appropriate to acquire a job on the associated virDomainObj. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_domain.c | 24 -- src/libxl/libxl_driver.c | 53 +++- 2

[Xen-devel] [PATCH 0/3] libxl: domain destroy fixes

2015-03-25 Thread Jim Fehlig
. I'll contact the stable branch maintainers and ask them to include these commits in the next Xen 4.4.x and 4.5.x releases. Jim Fehlig (3): libxl: Move job acquisition in libxlDomainStart to callers libxl: acquire a job when destroying a domain libxl: drop virDomainObj lock when destroying

[Xen-devel] [PATCH 3/3] libxl: drop virDomainObj lock when destroying a domain

2015-03-25 Thread Jim Fehlig
A destroy operation can take considerable time on large memory domains due to scrubbing the domain' memory. The operation is running in the context of a job, so unlocking the domain and allowing query operations is safe. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_domain.c

Re: [Xen-devel] [PATCH OSSTEST 04/12] toolstack: distinguish local and remote migration support

2015-03-25 Thread Jim Fehlig
Ian Campbell wrote: On Mon, 2015-02-09 at 11:09 +, Wei Liu wrote: Libvirt supports migrating a guest to remote host but not local host. Jim, is that right? Opps, I missed this mail. Sorry for the delay. Yes, that is correct # virsh migrate --live test-pv

Re: [Xen-devel] [libvirt] [PATCH 00/10] libxl: switch driver to use a single libxl_ctx

2015-03-24 Thread Jim Fehlig
Michal Privoznik wrote: On 18.02.2015 04:56, Jim Fehlig wrote: This series is a follow up to https://www.redhat.com/archives/libvir-list/2015-February/msg00024.html It goes a step further and changes the libxl driver to use one, driver-wide libxl_ctx. Currently the libxl driver has one

[Xen-devel] [PATCH V2] libxl: fix dom0 balloon logic

2015-03-24 Thread Jim Fehlig
, potentially interesting divergences. Signed-off-by: Jim Fehlig jfeh...@suse.com --- V2: Actually use libxl_wait_for_memory_target(), instead of libxl_wait_for_free_memory() src/libxl/libxl_domain.c | 55 +++- 1 file changed, 26 insertions(+), 29

Re: [Xen-devel] [PATCH] libxl: fix dom0 balloon logic

2015-03-24 Thread Jim Fehlig
Stefano Stabellini wrote: On Mon, 23 Mar 2015, Ian Campbell wrote: (just ccing the other tools maintainers, in particular Stefano who knows what this stuff is supposed to do...) On Fri, 2015-03-20 at 17:10 -0600, Jim Fehlig wrote: Recent testing on large memory systems revealed

[Xen-devel] [PATCH] libxl: fix dom0 balloon logic

2015-03-20 Thread Jim Fehlig
, potentially interesting divergences. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_domain.c | 57 1 file changed, 28 insertions(+), 29 deletions(-) diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c index 407a9bd..ff78133

Re: [Xen-devel] [PATCH 3/3] libxl: Domain destroy: fork

2015-03-20 Thread Jim Fehlig
Ian Campbell wrote: On Tue, 2015-03-17 at 09:30 -0600, Jim Fehlig wrote: diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c index b6541d4..b43db1a 100644 --- a/tools/libxl/libxl.c +++ b/tools/libxl/libxl.c @@ -1481,6 +1481,10 @@ static void domain_destroy_callback(libxl__egc *egc

Re: [Xen-devel] [PATCH 1/3] libxl: In domain death search, start search at first domid we want

2015-03-18 Thread Jim Fehlig
Ian Campbell wrote: On Tue, 2015-03-17 at 09:30 -0600, Jim Fehlig wrote: From: Ian Jackson ian.jack...@eu.citrix.com From: Ian Jackson ian.jack...@eu.citrix.com When domain_death_xswatch_callback needed a further call to xc_domain_getinfolist it would restart it with the last domain

Re: [Xen-devel] [PATCH 2/3] libxl: Domain destroy: unlock userdata earlier

2015-03-18 Thread Jim Fehlig
Ian Campbell wrote: On Tue, 2015-03-17 at 17:34 +, Wei Liu wrote: On Tue, Mar 17, 2015 at 09:30:58AM -0600, Jim Fehlig wrote: From: Ian Jackson ian.jack...@eu.citrix.com Unlock the userdata before we actually call xc_domain_destroy. This leaves open the possibility that other

Re: [Xen-devel] OpenStack - Libvirt+Xen CI overview

2015-03-17 Thread Jim Fehlig
Bob Ball wrote: For the last few weeks Anthony and I have been working on creating a CI environment to run against all OpenStack jobs. We're now in a position where we can share the current status, overview of how it works and next steps. We actively want to support involvement in this

[Xen-devel] [PATCH 2/3] libxl: Domain destroy: unlock userdata earlier

2015-03-17 Thread Jim Fehlig
...@eu.citrix.com CC: Wei Liu wei.l...@citrix.com Reviewed-by: Jim Fehlig jfeh...@suse.com Tested-by: Jim Fehlig jfeh...@suse.com --- Addressed off-list comments from Wei Liu tools/libxl/libxl.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c

[Xen-devel] [PATCH 1/3] libxl: In domain death search, start search at first domid we want

2015-03-17 Thread Jim Fehlig
, we now need evg to compute the arguments to getinfolist. Signed-off-by: Ian Jackson ian.jack...@eu.citrix.com Reported-by: Jim Fehlig jfeh...@suse.com Reviewed-by: Jim Fehlig jfeh...@suse.com Tested-by: Jim Fehlig jfeh...@suse.com --- tools/libxl/libxl.c | 15 +++ 1 file changed, 7

[Xen-devel] [PATCH 3/3] libxl: Domain destroy: fork

2015-03-17 Thread Jim Fehlig
Jackson ian.jack...@eu.citrix.com Reviewed-by: Jim Fehlig jfeh...@suse.com Tested-by: Jim Fehlig jfeh...@suse.com --- tools/libxl/libxl.c | 57 tools/libxl/libxl_internal.h | 1 + 2 files changed, 53 insertions(+), 5 deletions(-) diff --git

[Xen-devel] [PATCH 0/3] libxl: Fixes from Ian Jackson

2015-03-17 Thread Jim Fehlig
This is a small series of libxl patches I received off-list from Ian Jackson. The patches fix a few issues I found when converting the libvirt libxl driver to use a single libxl_ctx. Patch 2 has been modified slightly to address off-list comments from Wei Liu. Ian Jackson (3): libxl: In

Re: [Xen-devel] [libvirt test] 36071: tolerable all pass - PUSHED

2015-03-11 Thread Jim Fehlig
Ian Campbell wrote: On Tue, 2015-03-10 at 17:59 +, xen.org wrote: flight 36071 libvirt real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/36071/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 10

Re: [Xen-devel] [PATCH 2/4] libxl_wait_for_memory_target: wait as long as dom0 is making progress

2015-03-06 Thread Jim Fehlig
Stefano Stabellini wrote: Decrement wait_secs only if dom0 is making no progress toward reaching the balloon target, otherwise loop again for free. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Tested-by: Mike Latimer mlati...@suse.com --- tools/libxl/libxl.c |

Re: [Xen-devel] [PATCH 0/4] fix freemem loop

2015-03-06 Thread Jim Fehlig
Stefano Stabellini wrote: On Fri, 6 Mar 2015, Ian Campbell wrote: This is missing my point. We need to consider the case of a modified libvirt with the old, broken, libxl too. For that case, we might want to make sure that the new timeout passed to libxl_wait_for_memory_target is

Re: [Xen-devel] [xen-unstable test] 35257: regressions - FAIL

2015-03-02 Thread Jim Fehlig
Ian Campbell wrote: On Mon, 2015-03-02 at 11:14 +, Ian Jackson wrote: Jim Fehlig writes (Re: [Xen-devel] [xen-unstable test] 35257: regressions - FAIL): ... In my experience, if ERROR is insufficient, INFO and WARNING don't help. DEBUG is needed. Where does virtd's

Re: [Xen-devel] [xen-unstable test] 35257: regressions - FAIL

2015-02-27 Thread Jim Fehlig
Ian Campbell wrote: On Thu, 2015-02-26 at 20:14 +, xen.org wrote: flight 35257 xen-unstable real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/35257/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run:

Re: [Xen-devel] [xen-unstable test] 35257: regressions - FAIL

2015-02-27 Thread Jim Fehlig
Ian Campbell wrote: On Fri, 2015-02-27 at 10:48 +, Wei Liu wrote: On Fri, Feb 27, 2015 at 09:42:29AM +, Ian Campbell wrote: On Thu, 2015-02-26 at 20:14 +, xen.org wrote: flight 35257 xen-unstable real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/35257/

Re: [Xen-devel] [PATCH 3/3] libxl: libxl__device_from_disk should retrieve backend from xenstore

2015-02-26 Thread Jim Fehlig
Wei Liu wrote: On Wed, Feb 11, 2015 at 10:18:18AM -0700, Jim Fehlig wrote: At minimum, libvirt will populate the pdev_path, vdev, backend, and format fields. If backend and format (which, in libvirt-speack correspond to the 'name' and 'type' attributes on the optional driver element

Re: [Xen-devel] [libvirt] [PATCH 0/2] libxl: fix handling of fd and timer registrations

2015-02-17 Thread Jim Fehlig
Jim Fehlig wrote: Anthony PERARD wrote: On Mon, Feb 02, 2015 at 05:00:34PM -0700, Jim Fehlig wrote: This small series fixes some assertions we occasionally see in the libxl driver when running libvirt-TCK. The assertions were due to races between destroying per-domain libxl_ctx

[Xen-devel] [PATCH 00/10] libxl: switch driver to use a single libxl_ctx

2015-02-17 Thread Jim Fehlig
suggestions for further debugging tips appreciated. Jim Fehlig (10): libxl: remove redundant calls to libxl_evdisable_domain_death libxl: use libxl_ctx passed to libxlConsoleCallback libxl: use driver-wide ctx in fd and timer event handling libxl: Move setup of child processing code

[Xen-devel] [PATCH 09/10] libxl: remove per-domain libxl_ctx

2015-02-17 Thread Jim Fehlig
instead of per-domain ctx's. One downside to using a single libxl_ctx is there are no longer per-domain log files for log messages emitted by libxl. Messages for all domains will be sent to /var/log/libvirt/libxl/libxl-driver.log. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl

[Xen-devel] [PATCH 06/10] libxl: use global libxl_ctx in event handler

2015-02-17 Thread Jim Fehlig
Change the domain event handler code to use the driver-wide libxl_ctx instead of the domain-specific one. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_domain.c | 37 + 1 file changed, 25 insertions(+), 12 deletions(-) diff --git a/src/libxl

[Xen-devel] [PATCH 04/10] libxl: Move setup of child processing code to driver initialization

2015-02-17 Thread Jim Fehlig
-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_domain.c | 10 -- src/libxl/libxl_driver.c | 11 +++ 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c index 4872abe..0fc03f7 100644 --- a/src/libxl/libxl_domain.c

[Xen-devel] [PATCH 05/10] libxl: move event registration to driver initialization

2015-02-17 Thread Jim Fehlig
Register a domain event handler with the driver-wide libxl_ctx during driver initialization. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_domain.c | 21 ++--- src/libxl/libxl_domain.h | 15 +++ src/libxl/libxl_driver.c | 9 + 3 files changed

[Xen-devel] [PATCH 03/10] libxl: use driver-wide ctx in fd and timer event handling

2015-02-17 Thread Jim Fehlig
. There have also been rumors about such deadlocks during parallel OpenStack Tempest runs. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_domain.c | 234 +-- src/libxl/libxl_driver.c | 201 +++- 2 files

[Xen-devel] [PATCH 02/10] libxl: use libxl_ctx passed to libxlConsoleCallback

2015-02-17 Thread Jim Fehlig
Instead of using the libxl_ctx in the libxlDomainObjPrivatePtr, use the ctx passed to the callback. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_domain.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c

[Xen-devel] [PATCH 10/10] libxl: change libxl log stream to ERROR log level

2015-02-17 Thread Jim Fehlig
The DEBUG log level is very verbose and can quickly fill a filesystem hosting /var/log/libvirt/libxl/ Signed-off-by: Jim Fehlig jfeh...@suse.com --- Ideally, the log level should match what is configured in libvirtd.conf. Are the logging knob settings available in the drivers

[Xen-devel] [PATCH 07/10] libxl: remove unnecessary libxlDomainEventsRegister

2015-02-17 Thread Jim Fehlig
This function now only enables domain death events. Simply call libxl_evenable_domain_death() instead of an unnecessary wrapper. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_domain.c | 32 +++- src/libxl/libxl_domain.h | 5 - src/libxl

[Xen-devel] [PATCH 08/10] libxl: make libxlDomainFreeMem static

2015-02-17 Thread Jim Fehlig
libxlDomainFreeMem() is only used in libxl_domain.c and thus should be declared static. While at it, change the signature to take a libxl_ctx instead of libxlDomainObjPrivatePtr, since only the libxl_ctx is needed. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_domain.c | 16

[Xen-devel] [PATCH 01/10] libxl: remove redundant calls to libxl_evdisable_domain_death

2015-02-17 Thread Jim Fehlig
Domain death watch is already disabled in libxlDomainCleanup. No need to disable it a second and third time. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_domain.c | 8 1 file changed, 8 deletions(-) diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c

Re: [Xen-devel] [PATCH 3/3] libxl: libxl__device_from_disk should retrieve backend from xenstore

2015-02-11 Thread Jim Fehlig
Wei Liu wrote: On Tue, Feb 10, 2015 at 11:01:46AM +, Ian Jackson wrote: Wei Liu writes ([PATCH 3/3] libxl: libxl__device_from_disk should retrieve backend from xenstore): ... if backend is not set by caller. Acked-by: Ian Jackson ian.jack...@eu.citrix.com as far as it

Re: [Xen-devel] [PATCH 0/2] libxl: fix handling of fd and timer registrations

2015-02-09 Thread Jim Fehlig
Anthony PERARD wrote: On Mon, Feb 02, 2015 at 05:00:34PM -0700, Jim Fehlig wrote: This small series fixes some assertions we occasionally see in the libxl driver when running libvirt-TCK. The assertions were due to races between destroying per-domain libxl_ctx and receiving fd and timer

Re: [Xen-devel] [libvirt test] 34168: tolerable all pass - PUSHED

2015-02-09 Thread Jim Fehlig
Ian Campbell wrote: Jim, Thought you might like to know that we are now testing actually starting a guest with libvirt in osstest and this is the first pass. Nice! I'll keep an eye out for any regressions. Currently we don't test migration (which is why that appears to have failed),

[Xen-devel] [PATCH RFC] libxl: set disk defaults in remove/destroy functions

2015-01-26 Thread Jim Fehlig
a suitable backend when not specified, so I think this recommendation should be symmetrical in the add and remove operations. Regards, Jim From 48f5dc7b80384538ff343af46379efefe51986be Mon Sep 17 00:00:00 2001 From: Jim Fehlig jfeh...@suse.com Date: Mon, 26 Jan 2015 15:30:20 -0700 Subject: [PATCH

[Xen-devel] libvirt domXML - libxl_domain_config conversion testing

2015-01-23 Thread Jim Fehlig
Hi All, I've been attempting to revive the libvirt domXML - libxl_domain_config tests originally started by Daniel all the way back in May! https://www.redhat.com/archives/libvir-list/2014-May/msg01102.html In a reply to patch5 of the series, Ian Campbell noted that the doc produced by

Re: [Xen-devel] [PATCH OSSTEST v2 18/18] WIP: libvirt: migration + save/restore support. [and 1 more messages]

2015-01-21 Thread Jim Fehlig
Ian Jackson wrote: Jim Fehlig writes (Re: [PATCH OSSTEST v2 18/18] WIP: libvirt: migration + save/restore support.): You can get around this by disabling TLS in /etc/libvirt/libvirtd.conf. Then simply use ssh to connect to the dst host, e.g. 'virsh migrate --live dom xen+ssh://dst-host

[Xen-devel] [PATCH] tests: fix xlconfigtest build failure

2015-01-20 Thread Jim Fehlig
in commit 4ed5fb91 by too much copy and paste from xmconfigtest. Signed-off-by: Jim Fehlig jfeh...@suse.com --- tests/Makefile.am| 17 - tests/xlconfigtest.c | 4 ++-- 2 files changed, 14 insertions(+), 7 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index

Re: [Xen-devel] [libvirt bisection] complete build-armhf-libvirt

2015-01-20 Thread Jim Fehlig
Signed-off-by: Jim Fehlig jfeh...@suse.com I've sent a patch to fix the issue https://www.redhat.com/archives/libvir-list/2015-January/msg00709.html Sadly, I never tested the original series --without-xen. With the above patch, I've ensured 'make distcheck' passes with the following

Re: [Xen-devel] [PATCH OSSTEST v2 18/18] WIP: libvirt: migration + save/restore support.

2015-01-20 Thread Jim Fehlig
Ian Jackson wrote: Ian Campbell writes ([PATCH OSSTEST v2 18/18] WIP: libvirt: migration + save/restore support.): Note that this remains stubbed out, since making it actually work requires more work (i.e. I need to figure out what is involved, seem to need TLS and a CA etc...)

Re: [Xen-devel] [PATCH V3] libxl: Set path to console on domain startup.

2015-01-16 Thread Jim Fehlig
VIR_STRDUP. Remove the code from OpenConsole as it is now a duplicate. CC: Jim Fehlig jfeh...@suse.com CC: Ian Campbell ian.campb...@citrix.com CC: Ian Jackson ian.jack...@eu.citrix.com --- src/libxl/libxl_domain.c | 47 --- src/libxl

[Xen-devel] [PATCH V5 2/3] tests: Tests for the xen-xl parser

2015-01-14 Thread Jim Fehlig
From: Kiarie Kahurani davidkiar...@gmail.com Add disk and spice config tests for the xen_xl config parser Signed-off-by: Kiarie Kahurani davidkiar...@gmail.com Signed-off-by: Jim Fehlig jfeh...@suse.com --- V5: Enable spice test. Fix invalid config in the test data files and an actual bug

[Xen-devel] [PATCH V5 1/3] Introduce support for parsing/formatting Xen xl config format

2015-01-14 Thread Jim Fehlig
recently has the corresponding header file been included. A check for the header is done in configure.ac. If not found, xlu_disk_parse() is declared externally. Signed-off-by: Kiarie Kahurani davidkiar...@gmail.com Signed-off-by: Jim Fehlig jfeh...@suse.com --- V5: Address a few V4 issues noted

Re: [Xen-devel] [libvirt] [PATCH V4 1/3] Introduce support for parsing/formatting Xen xl config format

2015-01-14 Thread Jim Fehlig
Eric Blake wrote: On 01/13/2015 04:47 PM, Jim Fehlig wrote: +++ b/src/Makefile.am @@ -1005,6 +1005,10 @@ XENCONFIG_SOURCES = \ xenconfig/xen_common.c xenconfig/xen_common.h \ xenconfig/xen_sxpr.c xenconfig/xen_sxpr.h

[Xen-devel] [PATCH V5 0/3] Parser for xen-xl config format

2015-01-14 Thread Jim Fehlig
V5 of xen-xl parser. V4 was close https://www.redhat.com/archives/libvir-list/2015-January/msg00429.html but the tests did not exersice the spice parsing/formatting code. It is now fixed in V5, along with addressing a few V4 comments from eblake. Jim Fehlig (1): Introduce support

[Xen-devel] [PATCH V5 3/3] libxl: Add support for parsing/formating Xen XL config

2015-01-14 Thread Jim Fehlig
From: Kiarie Kahurani davidkiar...@gmail.com Now that xenconfig supports parsing and formatting Xen's XL config format, integrate it into the libxl driver's connectDomainXML{From,To}Native functions. Signed-off-by: Kiarie Kahurani davidkiar...@gmail.com Signed-off-by: Jim Fehlig jfeh...@suse.com

Re: [Xen-devel] [libvirt] [PATCH V4 2/3] tests: Tests for the xen-xl parser

2015-01-13 Thread Jim Fehlig
Eric Blake wrote: On 01/13/2015 08:53 AM, Jim Fehlig wrote: From: Kiarie Kahurani davidkiar...@gmail.com add tests for the xen_xl config parser Signed-off-by: Kiarie Kahurani davidkiar...@gmail.com Signed-off-by: Jim Fehlig jfeh...@suse.com --- V4: Only build xlconfigtest when libxl

[Xen-devel] [PATCH V4 1/3] Introduce support for parsing/formatting Xen xl config format

2015-01-13 Thread Jim Fehlig
recently has the corresponding header file been included. A check for the header is done in configure.ac. If not found, xlu_disk_parse() is declared externally. Signed-off-by: Kiarie Kahurani davidkiar...@gmail.com Signed-off-by: Jim Fehlig jfeh...@suse.com --- V4: Use Xen's libxlutil to parse disk

[Xen-devel] [PATCH V4 0/3] Parser for xen-xl config format

2015-01-13 Thread Jim Fehlig
simplified the series quite a bit and eliminates the potential of the copied flex parser diverging from the canonical source in xen.git. [1] https://www.redhat.com/archives/libvir-list/2014-December/msg00765.html [2] http://lists.xen.org/archives/html/xen-devel/2015-01/msg00690.html Jim Fehlig (1

[Xen-devel] [PATCH V4 3/3] libxl: Add support for parsing/formating Xen XL config

2015-01-13 Thread Jim Fehlig
From: Kiarie Kahurani davidkiar...@gmail.com Now that xenconfig supports parsing and formatting Xen's XL config format, integrate it into the libxl driver's connectDomainXML{From,To}Native functions. Signed-off-by: Kiarie Kahurani davidkiar...@gmail.com Signed-off-by: Jim Fehlig jfeh...@suse.com

[Xen-devel] [PATCH V4 2/3] tests: Tests for the xen-xl parser

2015-01-13 Thread Jim Fehlig
From: Kiarie Kahurani davidkiar...@gmail.com add tests for the xen_xl config parser Signed-off-by: Kiarie Kahurani davidkiar...@gmail.com Signed-off-by: Jim Fehlig jfeh...@suse.com --- V4: Only build xlconfigtest when libxl is available. tests/Makefile.am| 11 ++ tests

Re: [Xen-devel] [libvirt] [PATCH V4 1/3] Introduce support for parsing/formatting Xen xl config format

2015-01-13 Thread Jim Fehlig
Eric Blake wrote: On 01/13/2015 08:53 AM, Jim Fehlig wrote: Introduce a parser/formatter for the xl config format. Since the deprecation of xm/xend, the VM config file format has diverged as new features are added to libxl. This patch adds support for parsing and formating the xl config

Re: [Xen-devel] [libvirt] [PATCH 10/12] Introduce support for parsing/formatting Xen xl config format

2015-01-12 Thread Jim Fehlig
John Ferlan wrote: On 01/10/2015 12:03 AM, Jim Fehlig wrote: Introduce a parser/formatter for the xl config format. Since the deprecation of xm/xend, the VM config file format has diverged as new features are added to libxl. This patch adds support for parsing and formating the xl

Re: [Xen-devel] [PATCH 00/12] Replace Xen xl parsing/formatting impl

2015-01-12 Thread Jim Fehlig
Ian Campbell wrote: On Fri, 2015-01-09 at 22:03 -0700, Jim Fehlig wrote: The first attempt to implement support for parsing/formatting Xen's xl disk config format copied Xen's flex-based parser into libvirt, which has proved to be challenging in the context of autotools. But as it turns

Re: [Xen-devel] [libvirt] [PATCH 10/12] Introduce support for parsing/formatting Xen xl config format

2015-01-12 Thread Jim Fehlig
Eric Blake wrote: On 01/09/2015 10:03 PM, Jim Fehlig wrote: Introduce a parser/formatter for the xl config format. Since the deprecation of xm/xend, the VM config file format has diverged as new features are added to libxl. This patch adds support for parsing and formating the xl config

Re: [Xen-devel] [libvirt] [PATCH 10/12] Introduce support for parsing/formatting Xen xl config format

2015-01-12 Thread Jim Fehlig
John Ferlan wrote: On 01/10/2015 12:03 AM, Jim Fehlig wrote: Introduce a parser/formatter for the xl config format. Since the deprecation of xm/xend, the VM config file format has diverged as new features are added to libxl. This patch adds support for parsing and formating the xl

Re: [Xen-devel] [libvirt] [PATCH 09/12] Revert src/xenconfig: Xen-xl parser

2015-01-12 Thread Jim Fehlig
Eric Blake wrote: On 01/12/2015 07:51 AM, John Ferlan wrote: On 01/10/2015 12:03 AM, Jim Fehlig wrote: This reverts commit 2c78051a14acfb7aba078d569b1632dfe0ca0853. Conflicts: src/Makefile.am Signed-off-by: Jim Fehlig jfeh...@suse.com --- .gitignore

[Xen-devel] [PATCH 09/12] Revert src/xenconfig: Xen-xl parser

2015-01-09 Thread Jim Fehlig
This reverts commit 2c78051a14acfb7aba078d569b1632dfe0ca0853. Conflicts: src/Makefile.am Signed-off-by: Jim Fehlig jfeh...@suse.com --- .gitignore| 1 - cfg.mk| 3 +- configure.ac | 1 - po/POTFILES.in

[Xen-devel] [PATCH 00/12] Replace Xen xl parsing/formatting impl

2015-01-09 Thread Jim Fehlig
from patches 3 and 4 in the first attempt. One upshot of using libxlutil instead of copying the flex source is removing the potential for source divergence. Jim Fehlig (10): Revert bootstrap.conf: add check for flex Revert src/Makefile: Fix parallel build after xen_xl_disk parser

[Xen-devel] [PATCH 10/12] Introduce support for parsing/formatting Xen xl config format

2015-01-09 Thread Jim Fehlig
by the libxl virt driver, only recently has the corresponding header file been included. A check for the header is done in configure.ac. If not found, xlu_disk_parse() is declared externally. Signed-off-by: Kiarie Kahurani davidkiar...@gmail.com Signed-off-by: Jim Fehlig jfeh...@suse.com

[Xen-devel] [PATCH 12/12] libxl: Add support for parsing/formating Xen XL config

2015-01-09 Thread Jim Fehlig
From: Kiarie Kahurani davidkiar...@gmail.com Now that xenconfig supports parsing and formatting Xen's XL config format, integrate it into the libxl driver's connectDomainXML{From,To}Native functions. Signed-off-by: Kiarie Kahurani davidkiar...@gmail.com Signed-off-by: Jim Fehlig jfeh...@suse.com

[Xen-devel] [PATCH 08/12] Revert tests: Tests for the xen-xl parser

2015-01-09 Thread Jim Fehlig
This reverts commit 6b818d3b09f4e74ac2ea1d4020896be1e6871867. Signed-off-by: Jim Fehlig jfeh...@suse.com --- tests/Makefile.am| 9 +- tests/testutilsxen.c | 50 tests/testutilsxen.h | 9 +- tests/xlconfigdata/test-new-disk.cfg

[Xen-devel] [PATCH 02/12] Revert src/Makefile: Fix parallel build after xen_xl_disk parser introduction

2015-01-09 Thread Jim Fehlig
This reverts commit 533349ff43ddf091026fbcb0d9a714d9cc570dc7. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/Makefile.am | 21 + 1 file changed, 5 insertions(+), 16 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 2eaaf11..a6ea8e0 100644 --- a/src

[Xen-devel] [PATCH 05/12] Revert build: fix xenconfig VPATH builds

2015-01-09 Thread Jim Fehlig
This reverts commit 1b21d300691a78f73d94446616a6d1f9fd88991e. Conflicts: src/Makefile.am Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/Makefile.am | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index aaa5af2..95ba12c 100644

[Xen-devel] [PATCH 04/12] Revert Revert src/Makefile.am: fix build breaker for xenconfig

2015-01-09 Thread Jim Fehlig
This reverts commit e662968fd980158e8f8d8990bb43378dbc3d036a. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Makefile.am b/src/Makefile.am index 850122a..aaa5af2 100644 --- a/src/Makefile.am +++ b/src

[Xen-devel] [PATCH 06/12] Revert src/Makefile.am: fix build breaker for xenconfig

2015-01-09 Thread Jim Fehlig
This reverts commit 703ef9667abf016ef1040eac296a81792b366932. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Makefile.am b/src/Makefile.am index 95ba12c..c7975e5 100644 --- a/src/Makefile.am +++ b/src

[Xen-devel] [PATCH 03/12] Revert src/Makefile: move the new xen_xl_disk parser code at the correct place

2015-01-09 Thread Jim Fehlig
This reverts commit edacdb3d12256af4f6e31ec65c9dd4797fb3aa0d. Signed-off-by: Jim Fehlig jfeh...@suse.com --- src/Makefile.am | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index a6ea8e0..850122a 100644

Re: [Xen-devel] [libvirt test] 33157: regressions - trouble: blocked/fail/pass/preparing/queued

2015-01-09 Thread Jim Fehlig
Dario Faggioli wrote: On Thu, 2015-01-08 at 14:56 -0700, Jim Fehlig wrote: Jim Fehlig wrote: No, not directly. But I will be doing so now. I should try to revert all this nonsense and use libxlu before it ends up in the next libvirt release. Hmm, I don't think

Re: [Xen-devel] [libvirt test] 33157: regressions - trouble: blocked/fail/pass/preparing/queued

2015-01-08 Thread Jim Fehlig
Jim Fehlig wrote: Ian Campbell wrote: I must confess that I thought you already did use libxlu... No, not directly. But I will be doing so now. I should try to revert all this nonsense and use libxlu before it ends up in the next libvirt release. Hmm, I don't think

Re: [Xen-devel] [libvirt test] 33157: regressions - trouble: blocked/fail/pass/preparing/queued

2015-01-08 Thread Jim Fehlig
xen.org wrote: flight 33157 libvirt running [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/33157/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt none executed queued

Re: [Xen-devel] [libvirt test] 33157: regressions - trouble: blocked/fail/pass/preparing/queued

2015-01-08 Thread Jim Fehlig
Ian Campbell wrote: On Thu, 2015-01-08 at 09:37 -0700, Jim Fehlig wrote: xen.org wrote: flight 33157 libvirt running [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/33157/ Regressions :-( Tests which did not succeed and are blocking, including tests which could

Re: [Xen-devel] [PATCH RFC] libxl: fix paths in capability string

2015-01-07 Thread Jim Fehlig
Wei Liu wrote: Jim, another idea: if those strings are likely to be wrong and in fact not used, can we just not print them? IMO they are useful, particularly when they are correct :-). They allow users to see which emulators are available and their complete path, which in turn can be

Re: [Xen-devel] [libvirt] [PATCH] libxl: Set path to console on domain startup

2014-12-08 Thread Jim Fehlig
Anthony PERARD wrote: Hi, I'm trying to fix an issue when using OpenStack with libvirt+xen (libxenlight). OpenStack cannot access the console output of a Xen PV guest, because the XML generated by libvirt for a domain is missing the path to the pty. The path actually appear in the XML once

Re: [Xen-devel] [libvirt] [PATCH] libxl: Set path to console on domain startup.

2014-12-08 Thread Jim Fehlig
Anthony PERARD wrote: The path to the pty of a Xen PV console is set only in virDomainOpenConsole. But this is done too late. A call to virDomainGetXMLDesc done before OpenConsole will not have the path to the pty, but a call after OpenConsole will. Hi Anthony, Thanks for the patch. Can

<    1   2   3   4