Re: [Xen-devel] [PATCH v4 14/16] kprobes: move kprobe declarations to asm-generic/kprobes.h

2016-08-29 Thread Masami Hiramatsu
On Tue, 23 Aug 2016 18:31:05 +0200 "Luis R. Rodriguez" wrote: > On Tue, Aug 23, 2016 at 12:11:40AM +0900, Masami Hiramatsu wrote: > > On Fri, 19 Aug 2016 14:34:12 -0700 > > mcg...@kernel.org wrote: > > > > > From: "Luis R. Rodriguez" >

Re: [Xen-devel] [PATCH v4 14/16] kprobes: move kprobe declarations to asm-generic/kprobes.h

2016-08-22 Thread Masami Hiramatsu
.h > @@ -542,12 +542,4 @@ static __always_inline void __write_once_size(volatile > void *p, void *res, int s > (_p1); \ > }) > > -/* Ignore/forbid kprobes attach on very low level functions marked by this > attribute: */ > -#ifdef CONFIG_KPROBES > -# define __kprobes __attribute__((__section__(".kprobes.text"))) > -# define nokprobe_inline __always_inline > -#else > -# define __kprobes > -# define nokprobe_inline inline > -#endif > #endif /* __LINUX_COMPILER_H */ > diff --git a/include/linux/kprobes.h b/include/linux/kprobes.h > index 8f6849084248..985ed79ef431 100644 > --- a/include/linux/kprobes.h > +++ b/include/linux/kprobes.h > @@ -29,7 +29,7 @@ > * and Prasanna S Panchamukhi > *added function-return probes. > */ > -#include /* for __kprobes */ > +#include > #include > #include > #include > @@ -40,9 +40,9 @@ > #include > #include > #include > +#include > > #ifdef CONFIG_KPROBES > -#include > > /* kprobe_status settings */ > #define KPROBE_HIT_ACTIVE0x0001 > @@ -51,6 +51,7 @@ > #define KPROBE_HIT_SSDONE0x0008 > > #else /* CONFIG_KPROBES */ > +#include > typedef int kprobe_opcode_t; > struct arch_specific_insn { > int dummy; > @@ -481,18 +482,4 @@ static inline int enable_jprobe(struct jprobe *jp) > return enable_kprobe(&jp->kp); > } > > -#ifdef CONFIG_KPROBES > -/* > - * Blacklist ganerating macro. Specify functions which is not probed > - * by using this macro. > - */ > -#define __NOKPROBE_SYMBOL(fname) \ > -static unsigned long __used \ > - __attribute__((section("_kprobe_blacklist"))) \ > - _kbl_addr_##fname = (unsigned long)fname; > -#define NOKPROBE_SYMBOL(fname) __NOKPROBE_SYMBOL(fname) > -#else > -#define NOKPROBE_SYMBOL(fname) > -#endif > - > #endif /* _LINUX_KPROBES_H */ > -- > 2.9.2 > -- Masami Hiramatsu ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [RFC v3 07/13] tables.h: add linker table support

2016-07-25 Thread Masami Hiramatsu
gerous, at least for these APIs we'd better change name like as FUNCTABLE_RUN etc. because LINKTABLE can contain not only function address but also some data (or address of data). Thank you, -- Masami Hiramatsu ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [RFC v3 13/13] kprobes: port blacklist kprobes to linker table

2016-07-25 Thread Masami Hiramatsu
d confirms that > this fails to work as expected. This was tested with: This is OK for me, and if you would like to make sure, please use ftrace to probe (easier than making new module) and compare debugfs/blacklist which shows all blacklisted functions, so if all the function names are sa

Re: [Xen-devel] [RFC v3 12/13] kprobes: port .kprobes.text to section range

2016-07-25 Thread Masami Hiramatsu
quot;.spinlock.text", txtname) == 0 || > strcmp(".irqentry.text", txtname) == 0 || > - strcmp(".kprobes.text", txtname) == 0 || > + strcmp(SECTION_RNG(SECTION_TEXT, kprobe), txtname) == 0 || > strcmp(".text.unlikely", txtname) == 0; > } > > diff --git a/scripts/recordmcount.pl b/scripts/recordmcount.pl > index 96e2486a6fc4..f663a7c5d6ab 100755 > --- a/scripts/recordmcount.pl > +++ b/scripts/recordmcount.pl > @@ -134,7 +134,7 @@ my %text_sections = ( > ".sched.text" => 1, > ".spinlock.text" => 1, > ".irqentry.text" => 1, > - ".kprobes.text" => 1, > + ".text.rng.kprobes.any" => 1, > ".text.unlikely" => 1, > ); > > -- > 2.8.4 > -- Masami Hiramatsu ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [RFC v3 00/13] linux: generalize sections, ranges and linker tables

2016-07-25 Thread Masami Hiramatsu
de 100644 arch/score/include/asm/sections.h > create mode 100644 arch/score/include/asm/tables.h > create mode 100644 arch/sh/include/asm/ranges.h > create mode 100644 arch/sh/include/asm/tables.h > create mode 100644 arch/sparc/include/asm/ranges.h > create mode 100644 arch/sparc/include/asm/tables.h > create mode 100644 arch/tile/include/asm/ranges.h > create mode 100644 arch/tile/include/asm/tables.h > create mode 100644 arch/um/include/asm/ranges.h > create mode 100644 arch/um/include/asm/tables.h > create mode 100644 arch/unicore32/include/asm/ranges.h > create mode 100644 arch/unicore32/include/asm/sections.h > create mode 100644 arch/unicore32/include/asm/tables.h > create mode 100644 arch/x86/include/asm/ranges.h > create mode 100644 arch/x86/include/asm/tables.h > create mode 100644 arch/xtensa/include/asm/ranges.h > create mode 100644 arch/xtensa/include/asm/sections.h > create mode 100644 arch/xtensa/include/asm/tables.h > create mode 100644 include/asm-generic/ranges.h > create mode 100644 include/asm-generic/tables.h > create mode 100644 include/linux/ranges.h > create mode 100644 include/linux/sections.h > create mode 100644 include/linux/tables.h > rename scripts/{module-common.lds => module-common.lds.S} (80%) > create mode 100644 tools/include/linux/sections.h > > -- > 2.8.4 > -- Masami Hiramatsu ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel