[Xen-devel] [PATCH v7 5/5] Scripts to create and delete xen-scsiback nodes in Linux target framework

2016-02-05 Thread Olaf Hering
Signed-off-by: Olaf Hering <o...@aepfle.de> --- tools/misc/Makefile | 4 + tools/misc/target-create-xen-scsiback.sh | 135 +++ tools/misc/target-delete-xen-scsiback.sh | 41 ++ 3 files changed, 180 insertions(+) diff --git a/tool

[Xen-devel] [PATCH v7 3/5] libxl: add support for vscsi

2016-02-05 Thread Olaf Hering
Port pvscsi support from xend to libxl: vscsi=['pdev,vdev{,options}'] xl scsi-attach xl scsi-detach xl scsi-list Signed-off-by: Olaf Hering <o...@aepfle.de> Cc: Ian Jackson <ian.jack...@eu.citrix.com> Cc: Stefano Stabellini <stefano.stabell...@eu.citrix.com> Cc: Ian C

Re: [Xen-devel] [PATCH v7 3/5] libxl: add support for vscsi

2016-02-05 Thread Olaf Hering
On Fri, Feb 05, Olaf Hering wrote: > @@ -6799,6 +7375,8 @@ int libxl_retrieve_domain_configuration(libxl_ctx *ctx, > uint32_t domid, > > MERGE(nic, nics, COMPARE_DEVID, {}); > > +MERGE(vscsictrl, vscsictrls, COMPARE_VSCSI, {}); I think the actual &quo

Re: [Xen-devel] new idl helper, append to Array

2016-02-04 Thread Olaf Hering
On Thu, Feb 04, Ian Campbell wrote: > I think the append_to variant is probably least gross. libxl_device_vscsidev_append_to_vscsictrl() would work too. This is what I will use for the time being (modulo introduced runtime bugs): void libxl_device_vscsictrl_append_vscsidev(libxl_ctx *ctx,

Re: [Xen-devel] [PATCH] tools: libxc: do not redefine evtchn_port_or_error_t in xc_evtchn_compat.c

2016-02-04 Thread Olaf Hering
On Thu, Feb 04, Ian Campbell wrote: > Reported-by: Olaf Hering <o...@aepfle.de> be05b53 + this change can be compiled in SLE11 and SLE12. Thanks. Tested-by: Olaf Hering <o...@aepfle.de> Olaf ___ Xen-devel mailing list Xen-devel@lis

Re: [Xen-devel] [PATCH v2] libxenevtchn: rename evtchn_port_or_errot_t as xenevtchn_port...

2016-02-04 Thread Olaf Hering
On Thu, Feb 04, Ian Campbell wrote: > Cc: Olaf Hering <o...@aepfle.de> Also this builds on SLE11/12. Tested-by: Olaf Hering <o...@aepfle.de> Olaf ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

[Xen-devel] new idl helper, append to Array

2016-02-04 Thread Olaf Hering
Ian, in my pvscsi code I have two copies of a helper function which appends yet another instance of something to an Array, as shown below. This is similar to the _copy variant. Is it worth to let gentypes generate such a helper, like libxl_device_vscsictrl_append_vscsidev()? While writing this I

Re: [Xen-devel] Xen 4.7 Development Update

2016-02-03 Thread Olaf Hering
On Mon, Feb 01, Wei Liu wrote: > == Toolstack == > * Libxl PVSCSI support > - Olaf Hering I will send a new variant later this week. Getting pvscsi into 4.7 will most likely require much of your time for review, I hope you guys find the time and energy to do th

Re: [Xen-devel] [PATCH 3/5] libxl: add support for vscsi

2016-02-03 Thread Olaf Hering
On Wed, Feb 03, Wei Liu wrote: > If it is to be removed, why don't you just filter it out and not have it > in JSON at all? This is provided libxl won't rely on that to do proper > clean-up I don't see the value of retaining them, and if libxl is > relying on the JSON file to do clean-up the

Re: [Xen-devel] [PATCH] tools/libxc: Provide evtchn_port_or_error_t for compat xenctrl interface

2016-02-03 Thread Olaf Hering
On Mon, Feb 01, Andrew Cooper wrote: > c/s 2d2f789 "tools: rename libxc's evtchn_port_or_error_t with an xc_ > prefix" doesn't cater for older applications which have requested > XC_WANT_COMPAT_EVTCHN_API Not sure, but I think this breaks staging at last in SLES11: [ 93s] gcc -DPIC -O1

Re: [Xen-devel] [PATCH v10 3/9] libxc: allow creating domains without emulated devices.

2016-01-31 Thread Olaf Hering
On Mon, Dec 07, Roger Pau Monne wrote: > Introduce a new flag in xc_dom_image that turns on and off the emulated > devices. This prevents creating the VGA hole, the hvm_info page and the > ioreq server pages. libxl unconditionally sets it to true for all HVM > domains at the moment. > @@ -1428,8

[Xen-devel] qemu-upstream compile failure in intel_iommu.c:vtd_context_device_invalidate

2016-01-27 Thread Olaf Hering
Compiling qemu-xen at 2ce1d30 ("xenfb.c: avoid expensive loops when prod <= out_cons") leads to this error with -O1: xen.git/tools/qemu-xen-dir/hw/i386/intel_iommu.c: In function ‘vtd_context_device_invalidate’: xen.git/tools/qemu-xen-dir/hw/i386/intel_iommu.c:911:46: error: ‘mask’ may be used

Re: [Xen-devel] [PATCH 3/5] libxl: add support for vscsi

2016-01-27 Thread Olaf Hering
On Fri, Nov 13, Olaf Hering wrote: > Port pvscsi support from xend to libxl: How should code which converts devices from xenstore to json handle devices which got marked as "to be removed"? In my pvscsi code I set XenbusStateClosing in the vscsidev, then XenbusStateReconfiguring

Re: [Xen-devel] [PATCH V13 3/5] libxl: add pvusb API

2016-01-26 Thread Olaf Hering
On Tue, Jan 19, Chunyan Liu wrote: > +++ b/tools/libxl/libxl.c > @@ -3204,7 +3204,7 @@ void > libxl__device_disk_local_initiate_detach(libxl__egc *egc, > aodev->dev = device; > aodev->callback = local_device_detach_cb; > aodev->force = 0; > -

Re: [Xen-devel] [PATCH] kdd: build using Werror

2016-01-25 Thread Olaf Hering
On Mon, Jan 25, Ian Campbell wrote: > We build most of tools using Werror and there seems to be know > deliberate reason for this to be an exception. > > Signed-off-by: Ian Campbell <ian.campb...@citrix.com> This would have caught the kdd error. Tested-by: Olaf Hering <

Re: [Xen-devel] [PATCH] kdd: Opt in to libxc compat xc_map_foreign_* intefaces.

2016-01-25 Thread Olaf Hering
On Mon, Jan 25, Ian Campbell wrote: > Reported by: Olaf Hering <o...@aepfle.de> Tested-by: Olaf Hering <o...@aepfle.de> Thanks, Olaf ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] kdd: build using Werror

2016-01-25 Thread Olaf Hering
On Mon, Jan 25, Ian Campbell wrote: > We build most of tools using Werror and there seems to be know > deliberate reason for this to be an exception. s/know/no/ ? Acked-by: Olaf Hering <o...@aepfle.de> Olaf ___ Xen-devel mailing li

Re: [Xen-devel] [PATCH] tools: avoid redefinition of typedefs

2016-01-25 Thread Olaf Hering
On Mon, Jan 25, Ian Campbell wrote: > When splitting out various functionality from libxc into tools/libs/* > I attempted to make it possible to avoid callers being unnecessarily > exposed to the xentoollog interface by providing a typedef of the > xentoollog_logger handle in each of the headers.

Re: [Xen-devel] [PATCH 1/2] tools: rename libxc's evtchn_port_or_error_t with an xc_ prefix

2016-01-25 Thread Olaf Hering
On Mon, Jan 25, Ian Campbell wrote: > This is used only for xc_evtchn_alloc_unbound and the legacy/compat > versions of the old interfaces and avoids redefining the typedef. The > evtchn_port_or_error_t name is now used only be libxenevtchn. Tested-by: Olaf Hering <o...@aepf

Re: [Xen-devel] [PATCH 2/2] tools: avoid redefinining xenevtchn_handle typedef for xc_suspend_*

2016-01-25 Thread Olaf Hering
On Mon, Jan 25, Ian Campbell wrote: > Similar to the previous xentoollog case this is not allowed. Switch to > a forward decl of the struct and use of it in the APIs. Tested-by: Olaf Hering <o...@aepfle.de> Olaf ___ Xen-devel mailing li

Re: [Xen-devel] [PATCH XEN v8 11/29] tools: Refactor foreign memory mapping into libxenforeignmemory

2016-01-25 Thread Olaf Hering
On Fri, Jan 15, Ian Campbell wrote: > libxenforeignmemory will provide a stable API and ABI for mapping > foreign domain memory (subject to appropriate privileges). I think this will break my Xen pkg build: [ 333s] kdd-xen.c: In function 'kdd_access_physical_page': [ 333s] kdd-xen.c:508:15:

Re: [Xen-devel] Missing libvirt+libxl functionality (Was: Re: [Xen-users] Programmatic administration of Xen machines)

2016-01-07 Thread Olaf Hering
On Thu, Jan 07, Jim Fehlig wrote: > The 'iscsi:iqn.2006-09.de.suse@0ac47ee2-216e-452a-a341-a12624cd0225' blob was > passed wholesale to xend, which would eat it and "do the right thing". AFAIK, > libxl is not that forgiving. I've cc'd Olaf on this thread since we recently > discussed how

Re: [Xen-devel] [PATCH v2] libxl: Introduce a template for devices with a controller

2015-12-02 Thread Olaf Hering
On Tue, Dec 01, George Dunlap wrote: > We have several outstanding patch series which add devices that have > two levels: a controller and individual devices attached to that > controller. Will likely work for pvscsi. Thanks. Acked-by: Olaf Hering <o...@aepf

Re: [Xen-devel] Build problems with xen 4.7

2015-12-01 Thread Olaf Hering
On Tue, Dec 01, M A Young wrote: > It happens if CFLAGS is set to anything as a environment variable, eg. > export CFLAGS=" " > make dist-xen This never worked. I have this in xen.spec to workaround the way %configure is implemented in rpm: %configure unset CFLAGS unset CXXFLAGS unset FFLAGS

[Xen-devel] [PATCH] tools/hotplug: quote all variables in vif-bridge

2015-11-19 Thread Olaf Hering
Cosmetics: most of the variables used in vif-bridge are already quoted. Add quoting also to the remaining shell variables. Signed-off-by: Olaf Hering <o...@aepfle.de> Cc: Ian Jackson <ian.jack...@eu.citrix.com> Cc: Stefano Stabellini <stefano.stabell...@eu.citrix.com> Cc: Ian C

[Xen-devel] [PATCH] get_maintainer: fix perl 5.22/5.24 deprecated/incompatible "\C" use

2015-11-19 Thread Olaf Hering
From: Joe Perches <j...@perches.com> Perl 5.22 emits a deprecated message when "\C" is used in a regex. Perl 5.24 will disallow it altogether. Fix it by using [A-Z] instead of \C. [ Upstream commit ce8155f7a3d59ce868ea16d8891edda4d865e873 ] Signed-off-by: Olaf Hering <o...

Re: [Xen-devel] [PATCH v5 4/4] docs: Introduce xenstore paths for guest network address information

2015-11-18 Thread Olaf Hering
On Tue, Nov 17, Paul Durrant wrote: > This patch documents paths to allow a domain to advertise an interface > name, MAC (unicast and multicast) and IP (version 4 and 6) address > information. How does the domU do that in practice? With some variant of xenstore-write or with the PV vif driver?

Re: [Xen-devel] [PATCH V8 3/7] libxl: add pvusb API

2015-11-18 Thread Olaf Hering
On Wed, Nov 18, Ian Campbell wrote: > I'd been hoping that someone involved ion this would generate a patch > adding a template for this controller+devices model to libxl.h, I've not > seen anything since George's original RFC[0] "libxl: Introduce a template > for devices with a controller". Its

Re: [Xen-devel] missing block script support for qemu in libxl

2015-11-18 Thread Olaf Hering
On Wed, Nov 18, George Dunlap wrote: > You mean, should the bug wherein HVM domains with emulated disks > (which is all of them, by default) cannot use block scripts be fixed? Yes. > Yes it should, and I'm working on it at the moment. Great. Please cc me when the patches are ready. Olaf

[Xen-devel] missing block script support for qemu in libxl

2015-11-18 Thread Olaf Hering
Why does libxl now allow script= with backend=tap|qdisk? See tools/libxl/libxl_device.c:disk_try_backend. Ideally the script should prepare the backend storage based on info from target=. Then the script should report either the dentry to be used by qemu back to libxl, or it should setup the

Re: [Xen-devel] [PATCH V8 3/7] libxl: add pvusb API

2015-11-18 Thread Olaf Hering
On Tue, Nov 17, Chun Yan Liu wrote: > I think libxl_device_usb doesn't need to be changed into libxl_device_usbdev? In case of vscsi the struct and functions names are odd. It was not obvious which one belongs to a ctrl and which one belongs to a device. In the meantime I have changed

Re: [Xen-devel] what's the equivalent function to "schedule_timeout" in xen kernel?

2015-11-16 Thread Olaf Hering
On Mon, Nov 16, Andrew Cooper wrote: > On 16/11/15 06:36, Zhangbo (Oscar) wrote: > > Hi all: > >   I'd like to SLEEP a while in xen kernel during VMEXIT, the easiest way > > is to call "udelay" or "mdelay" there. However, these 2 functions use busy > > wait to sleep, which is a waste. > >   In

[Xen-devel] [PATCH 5/5] Scripts to create and delete xen-scsiback nodes in Linux target framework

2015-11-13 Thread Olaf Hering
Signed-off-by: Olaf Hering <o...@aepfle.de> --- tools/misc/Makefile | 4 + tools/misc/target-create-xen-scsiback.sh | 135 +++ tools/misc/target-delete-xen-scsiback.sh | 41 ++ 3 files changed, 180 insertions(+) diff --git a/tool

[Xen-devel] [PATCH 1/5] vscsiif.h: fix WWN notation for p-dev property

2015-11-13 Thread Olaf Hering
The pvops kernel expects either "naa.WWN:LUN" or "h:c:t:l" in the p-dev property. Add the missing :LUN part to the comment. Signed-off-by: Olaf Hering <o...@aepfle.de> Acked-by: Ian Campbell <ian.campb...@citrix.com> Cc: Ian Campbell <ian.campb...@ci

[Xen-devel] [PATCH 0/5] libbxl: add support for pvscsi, iteration 6

2015-11-13 Thread Olaf Hering
Initial attempt was sent a year ago: http://lists.xenproject.org/archives/html/xen-devel/2014-04/msg03958.html Most comments are addressed. This version has been tested with SLES as backend and frontend. This version has been tested with pvops as backend and SLES as frontend. Olaf Hering (5):

[Xen-devel] [PATCH 3/5] libxl: add support for vscsi

2015-11-13 Thread Olaf Hering
Port pvscsi support from xend to libxl: vscsi=['pdev,vdev{,options}'] xl scsi-attach xl scsi-detach xl scsi-list Signed-off-by: Olaf Hering <o...@aepfle.de> Cc: Ian Jackson <ian.jack...@eu.citrix.com> Cc: Stefano Stabellini <stefano.stabell...@eu.citrix.com> Cc: Ian C

[Xen-devel] [PATCH 4/5] vscsiif.h: add some notes about xenstore layout

2015-11-13 Thread Olaf Hering
Signed-off-by: Olaf Hering <o...@aepfle.de> Acked-by: Ian Campbell <ian.campb...@citrix.com> Cc: Ian Campbell <ian.campb...@citrix.com> Cc: Ian Jackson <ian.jack...@eu.citrix.com> Cc: Jan Beulich <jbeul...@suse.com> Cc: Keir Fraser <k...@xen.org> Cc: Tim De

[Xen-devel] [PATCH 2/5] docs: add vscsi to xenstore-paths.markdown

2015-11-13 Thread Olaf Hering
Signed-off-by: Olaf Hering <o...@aepfle.de> Acked-by: Ian Campbell <ian.campb...@citrix.com> Cc: Ian Campbell <ian.campb...@citrix.com> Cc: Ian Jackson <ian.jack...@eu.citrix.com> Cc: Jan Beulich <jbeul...@suse.com> Cc: Keir Fraser <k...@xen.org> Cc: Tim

Re: [Xen-devel] [PATCH V8 3/7] libxl: add pvusb API

2015-11-13 Thread Olaf Hering
On Wed, Oct 21, Chunyan Liu wrote: > Add pvusb APIs, including: > @@ -635,6 +664,8 @@ libxl_domain_config = Struct("domain_config", [ > ("pcidevs", Array(libxl_device_pci, "num_pcidevs")), > ("rdms", Array(libxl_device_rdm, "num_rdms")), > ("dtdevs", Array(libxl_device_dtdev,

Re: [Xen-devel] [PATCH V8 3/7] libxl: add pvusb API

2015-11-12 Thread Olaf Hering
On Wed, Oct 21, Chunyan Liu wrote: > Add pvusb APIs, including: Some comments below. After a quick look I miss the proposed ctrl/device separation for pvscsi (what handles "state" changes?). But, I have to read all the other dozen+ threads about that topic first. > +

Re: [Xen-devel] [PATCH V8 5/7] xl: add pvusb commands

2015-11-12 Thread Olaf Hering
On Wed, Oct 21, Chunyan Liu wrote: > Add pvusb commands: usbctrl-attach, usbctrl-detach, usb-list, > usb-attach and usb-detach. How is this supposed to be handled in libvirt? It looks like libvirt has to copy what is done here. If thats true the logic should be in libxlu so that both xl and

[Xen-devel] [PATCH] tools/hotplug: xendomains.service conflicts with libvirt

2015-10-29 Thread Olaf Hering
Signed-off-by: Olaf Hering <o...@aepfle.de> Cc: Ian Jackson <ian.jack...@eu.citrix.com> Cc: Stefano Stabellini <stefano.stabell...@eu.citrix.com> Cc: Ian Campbell <ian.campb...@citrix.com> Cc: Wei Liu <wei.l...@citrix.com> --- This never went out via git send-email,

[Xen-devel] [PATCH v2] tools/hotplug: xendomains.service conflicts with libvirt

2015-10-29 Thread Olaf Hering
Signed-off-by: Olaf Hering <o...@aepfle.de> Cc: Ian Jackson <ian.jack...@eu.citrix.com> Cc: Stefano Stabellini <stefano.stabell...@eu.citrix.com> Cc: Ian Campbell <ian.campb...@citrix.com> Cc: Wei Liu <wei.l...@citrix.com> --- v2: correct typo, it has to be libvir

Re: [Xen-devel] [PATCH] tools/hotplug: xendomains.service conflicts with libvirt

2015-10-29 Thread Olaf Hering
On Thu, Oct 29, Wei Liu wrote: > On Thu, Oct 29, 2015 at 10:22:45AM +0000, Olaf Hering wrote: > > +Conflicts=libvirt.service > Is there a canonical source for the name of service? We should reference > that in commit message. No, its a typo. Thanks for spotting it. The ch

Re: [Xen-devel] ovmf fails to build in stagin-4.6

2015-10-27 Thread Olaf Hering
On Mon, Oct 26, Wei Liu wrote: > I think you have a stale repository. Try deleting ovmf-dir-remote ? Its always built in a new clean chroot from the same set of sources. I will see if forcing GCC49 will change anything. Olaf ___ Xen-devel mailing

Re: [Xen-devel] ovmf fails to build in stagin-4.6

2015-10-27 Thread Olaf Hering
On Tue, Oct 27, Olaf Hering wrote: > I will see if forcing GCC49 will change anything. This change works for me. --- xen.spec(revision 6) +++ xen.spec(working copy) @@ -290,6 +290,7 @@ ln -sfvbn ../qemu-xen-dir-remote tools/qemu-xen-dir-remote ln -sfvbn ../qemu-

Re: [Xen-devel] ovmf fails to build in stagin-4.6

2015-10-27 Thread Olaf Hering
Am 27.10.2015 um 11:39 schrieb Wei Liu: > The commit id in Config.mk is af9785a9ed61daea52b47f0bf448f1f228beee1e I think the staging-4.6 rev differs, but I will check my checkout script if it picks the id from the wrong branch/file. Olaf ___ Xen-devel

[Xen-devel] ovmf fails to build in stagin-4.6

2015-10-26 Thread Olaf Hering
For me ovmf fails to build in staging-4.6: ... [ 541s] + ./configure --host=x86_64-suse-linux-gnu --build=x86_64-suse-linux-gnu --program-prefix= --disable-dependency-tracking --prefix=/usr --exec-prefix=/usr --bindir=/usr/bin --sbindir=/usr/sbin --sysconfdir=/etc --datadir=/usr/share

Re: [Xen-devel] ovmf fails to build in stagin-4.6

2015-10-26 Thread Olaf Hering
On Mon, Oct 26, Wei Liu wrote: > On Mon, Oct 26, 2015 at 10:43:15AM +0100, Olaf Hering wrote: > > Does it compile for anyone? > It compiles for me -- but I'm using gcc 4.9. I noticed that just now, fails only in Tumbleweed which used gcc-5.1.1. Sorry for the

Re: [Xen-devel] ovmf fails to build in stagin-4.6

2015-10-26 Thread Olaf Hering
On Mon, Oct 26, Wei Liu wrote: > Wait, so you're using gcc-5.1.1 but OVMF is reporting gcc-4.4 (see in > the path of output string), there might be another problem with > toolchain detection then. As Linus said: detect old and known to be problematic, everything else has to be handled as

Re: [Xen-devel] [ANNOUNCE] Switching to qemu-xen.git and qemu-xen-traditional.git

2015-10-21 Thread Olaf Hering
On Wed, Oct 21, Ian Campbell wrote: > http://xenbits.xen.org/gitweb/?p=qemu-xen.git Is the HEAD warning expected? $ git clone git://xenbits.xen.org/qemu-xen qemu-xen.git $ cd $_ $ git remote show origin * remote origin Fetch URL: git://xenbits.xen.org/qemu-xen Push URL:

Re: [Xen-devel] [PATCH v7 2/3] x86: add domctl cmd to set/get CDP code/data CBM

2015-10-16 Thread Olaf Hering
On Thu, Oct 15, Wei Liu wrote: > No, because 1) staging is not using GCC5, 2) staging has debug=y. Are there enough resources to address #2? Build once with debug=y and once without? Olaf ___ Xen-devel mailing list Xen-devel@lists.xen.org

Re: [Xen-devel] [PATCH for staging] fix compile error

2015-10-16 Thread Olaf Hering
Am 16.10.2015 um 12:15 schrieb Wei Liu: > On Fri, Oct 16, 2015 at 06:03:36PM +0800, He Chen wrote: >> In non-debug build ASSERT_UNREACHABLE is nop and some compilers will Should be "all compilers" ;-) Olaf ___ Xen-devel mailing list

Re: [Xen-devel] RFC: Survey on release cycle

2015-10-15 Thread Olaf Hering
On Thu, Oct 15, Ian Campbell wrote: > On Mon, 2015-10-12 at 18:32 +0100, Wei Liu wrote: > > > # 6 months release cycle + current stable release scheme > # 6 months release cycle + extended security support > > +1 to either of these, but +2 for picking one of them. +1, as Ian said. > (not

Re: [Xen-devel] [PATCH v7 2/3] x86: add domctl cmd to set/get CDP code/data CBM

2015-10-15 Thread Olaf Hering
On Thu, Oct 15, Wei Liu wrote: > On Thu, Oct 15, 2015 at 04:57:16PM +0200, Olaf Hering wrote: > > gcc5 does not like ASSERT_UNREACHABLE(), whatever is in staging fails: > Is it because in non-debug build ASSERT_UNREACHABLE is nop? That might explain it. Does the staging build test ca

Re: [Xen-devel] [PATCH v7 2/3] x86: add domctl cmd to set/get CDP code/data CBM

2015-10-15 Thread Olaf Hering
On Tue, Oct 13, He Chen wrote: > +int psr_set_l3_cbm(struct domain *d, unsigned int socket, > + uint64_t cbm, enum cbm_type type) > { > +uint64_t cbm_data, cbm_code; > +switch ( type ) > { > +case PSR_CBM_TYPE_L3: > +cbm_code = cbm; > +break;

[Xen-devel] xen-4.6 compile error

2015-09-30 Thread Olaf Hering
Current xen-4.6-staging fails to compile on openSUSE 11.4 and SLES11 [ 1227s] gcc -O2 -fomit-frame-pointer -m64 -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-statement -D__XEN_TOOLS__ -MMD -MF .libxl_psr.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE

Re: [Xen-devel] xen-4.6 compile error

2015-09-30 Thread Olaf Hering
On Wed, Sep 30, Wei Liu wrote: > On Wed, Sep 30, 2015 at 03:46:35PM +0200, Olaf Hering wrote: > > [ 1227s] libxl_psr.c:342: error: declaration of 'socket' shadows a global > > declaration > I will provide a patch to fix it. Thanks. Staging is broken as well as I notic

Re: [Xen-devel] [PATCH for-4.6] libxl: don't shadow global "socket" in psr code

2015-09-30 Thread Olaf Hering
On Wed, Sep 30, Wei Liu wrote: > Change "socket" to "socketid" to fix the problem. Tested-by: Olaf Hering <o...@aepfle.de> Olaf ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 1/7] tools/hotplug: remove SELinux options from var-lib-xenstored.mount

2015-09-15 Thread Olaf Hering
On Tue, Sep 15, George Dunlap wrote: > It's very reasonable for you to expect it to be fixed on non-SELinux > systems. But what you did is fix it for non-SELinux systems by simply > breaking it on SELinux systems -- that's not at all reasonable. Konrad did some testing at that time and said 4.5

Re: [Xen-devel] [PATCH 1/7] tools/hotplug: remove SELinux options from var-lib-xenstored.mount

2015-09-14 Thread Olaf Hering
On Mon, Sep 14, George Dunlap wrote: > Well if you "know nothing about SELinux", and you don't use it, and > don't have any test systems that use it, then why did you assert > "The proper place to specify [an SELinux mount context] is /etc/fstab"? > This patchset was accepted because you

Re: [Xen-devel] [PATCH 7/7] tools/hotplug: add wrapper to start xenstored

2015-09-11 Thread Olaf Hering
On Thu, Sep 10, Ian Jackson wrote: > Wei Liu writes ("Re: [Xen-devel] [PATCH 7/7] tools/hotplug: add wrapper to > start xenstored"): > > On Thu, Sep 10, 2015 at 03:19:35PM +0100, George Dunlap wrote: > > > ExecStart=/usr/bin/env $XENSTORED --no-fork $XENSTORED_ARGS > > > > And the difference

Re: [Xen-devel] [PATCH 1/7] tools/hotplug: remove SELinux options from var-lib-xenstored.mount

2015-09-11 Thread Olaf Hering
On Thu, Sep 10, George Dunlap wrote: > On Fri, Dec 19, 2014 at 11:25 AM, Olaf Hering <o...@aepfle.de> wrote: > > Using SELinux mount options per default breaks several systems. > > Either the context= mount option is not known at all to the kernel, > > as reported fo

Re: [Xen-devel] [PATCH] unmodified-drivers: tolerate IRQF_DISABLED being undefined

2015-07-21 Thread Olaf Hering
On Mon, Jun 01, Jan Beulich wrote: On 01.06.15 at 15:56, ian.campb...@citrix.com wrote: On Mon, 2015-06-01 at 14:50 +0100, Jan Beulich wrote: It's being removed in Linux 4.1. Signed-off-by: Jan Beulich jbeul...@suse.com Not sure who should, but: I guess no-one really needs to

Re: [Xen-devel] [PATCH] blktap2: update connection handling to fix build with gcc5

2015-07-21 Thread Olaf Hering
On Mon, Jul 20, Wei Liu wrote: On Mon, Jul 20, 2015 at 11:16:34AM +0200, Olaf Hering wrote: On Mon, Jul 20, Jan Beulich wrote: On 19.07.15 at 11:33, o...@aepfle.de wrote: [ 198s] block-log.c:549:23: error: array subscript is above array bounds [-Werror=array-bounds

Re: [Xen-devel] [PATCH] unmodified-drivers: tolerate IRQF_DISABLED being undefined

2015-07-21 Thread Olaf Hering
On Tue, Jul 21, Jan Beulich wrote: Taking it to mean all maintained, that's possible, but since I can't immediately see the point I'd like to ask for some justification. Us - SUSE - apparently being the only consumer of that code, and us not using Xen 4.4 together with Linux 4.1, and our 4.5

[Xen-devel] [PATCH v2] blktap2: update connection handling to fix build with gcc5

2015-07-21 Thread Olaf Hering
: recipe for target 'block-log.o' failed [ 198s] make[5]: *** [block-log.o] Error 1 Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: Ian Campbell ian.campb...@citrix.com Cc: Wei Liu wei.l...@citrix.com

Re: [Xen-devel] [PATCH] blktap2: update connection handling to fix build with gcc5

2015-07-21 Thread Olaf Hering
On Tue, Jul 21, Jan Beulich wrote: But anyway, the primary question remains - isn't what you're seeing a compiler bug? If yes, that's imo _yet another_ reason for doing a minimal workaround (if any at all). I dont think its a compiler bug. How should the compiler know that the index variable

Re: [Xen-devel] [PATCH] blktap2: update connection handling to fix build with gcc5

2015-07-20 Thread Olaf Hering
On Mon, Jul 20, Jan Beulich wrote: On 19.07.15 at 11:33, o...@aepfle.de wrote: [ 198s] block-log.c:549:23: error: array subscript is above array bounds [-Werror=array-bounds] [ 198s] if (s-connections[i].id == id) [ 198s]^ So what makes the compiler

Re: [Xen-devel] [PATCH 1/3] libxl: fix ref counting of libxlMigrationDstArgs

2015-07-20 Thread Olaf Hering
On Thu, Jul 16, Jim Fehlig wrote: @@ -448,6 +438,8 @@ libxlDomainMigrationPrepare(virConnectPtr dconn, virObjectUnref(socks[i]); } VIR_FREE(socks); +virObjectUnref(args); This is now below the 'error' label, so args has to be initialized. [ 149s]

[Xen-devel] [PATCH] blktap2: update connection handling to fix build with gcc5

2015-07-19 Thread Olaf Hering
-log.o' failed [ 198s] make[5]: *** [block-log.o] Error 1 Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: Ian Campbell ian.campb...@citrix.com Cc: Wei Liu wei.l...@citrix.com --- This is just compile

Re: [Xen-devel] preparing for 4.4.3

2015-06-18 Thread Olaf Hering
On Thu, Jun 18, Jan Beulich wrote: With the intended four month cycle, 4.4.3 is due in about a month. Please indicate any backports you see missing yet consider required in the current staging-4.4 tree. I would like to see the gnutls changes for qemu-tradiitional be included in maintained

Re: [Xen-devel] [PATCH RFC v1] libxl: Introduce a template for devices with a controller

2015-06-17 Thread Olaf Hering
On Wed, Jun 17, Ian Campbell wrote: So, Olaf, ping... I will return to pvscsi work next week. Olaf ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v6 0/8] add xenalyze to staging

2015-06-16 Thread Olaf Hering
On Tue, Jun 16, Ian Campbell wrote: On that note, please can someone send a followup patch adding a MAINTAINERS entry, presumably nominating George as maintainer. This is already the case, tools/xentrace is listed there. Olaf ___ Xen-devel mailing

Re: [Xen-devel] [PATCH v5 2/8] xenalyze: increase NR_CPUS to 256

2015-06-16 Thread Olaf Hering
On Tue, Jun 16, Ian Campbell wrote: On Mon, 2015-06-15 at 19:58 +0200, Olaf Hering wrote: On Mon, Jun 15, Andrew Cooper wrote: In an ideal world, userspace tools like this should not really be tied to NR_CPUS or MAX_CPUS. They should get max_cpu_id from Xen and dynamically

Re: [Xen-devel] [PATCH v5 2/8] xenalyze: increase NR_CPUS to 256

2015-06-15 Thread Olaf Hering
On Mon, Jun 15, Andrew Cooper wrote: In an ideal world, userspace tools like this should not really be tied to NR_CPUS or MAX_CPUS. They should get max_cpu_id from Xen and dynamically allocate a bitmap of sufficient size. The dumps are taken on one machine and get inspected on another, which

Re: [Xen-devel] [PATCH v5 2/8] xenalyze: increase NR_CPUS to 256

2015-06-15 Thread Olaf Hering
On Thu, Jun 11, George Dunlap wrote: On 06/11/2015 12:03 PM, Julien Grall wrote: I would suggest some refactoring to remove NR_CPUS and associated code in order to avoid mis-usage later. Also, cpu_mask_t is a uint32_t, is it intentional? When xenalyze was originally written back in

Re: [Xen-devel] [PATCH v5 2/8] xenalyze: increase NR_CPUS to 256

2015-06-11 Thread Olaf Hering
On Wed, Jun 10, Julien Grall wrote: There is also a variable MAX_CPUS defined to 256. which is used every. You are right, while forwarding an old patch (from memory) I changed the wrong place. MAX_CPUS is already at 256 so no change is strictly neccessary. I suggest to drop that patch from

Re: [Xen-devel] [PATCH v5 1/8] xenalyze: add to tools/xentrace/

2015-06-11 Thread Olaf Hering
On Thu, Jun 11, George Dunlap wrote: First, it looks like maybe this wasn't based on 24308507be1d, but on 8083183a7238? At least there seems to be changes in it that aren't in the other one. Where is 8083183a7238? I have this as HEAD: # changeset: 150:24308507be1d # tag: tip #

[Xen-devel] [PATCH v6 7/8] xenalyze: remove argp_program_version

2015-06-11 Thread Olaf Hering
Since xenalyze is now upstream its Open Source and part of the given release. Signed-off-by: Olaf Hering o...@aepfle.de Acked-by: George Dunlap george.dun...@eu.citrix.com Acked-by: Wei Liu wei.l...@citrix.com Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Stefano Stabellini stefano.stabell

[Xen-devel] [PATCH v6 0/8] add xenalyze to staging

2015-06-11 Thread Olaf Hering
- add patch to bump NR_CPUS Olaf Hering (8): xenalyze: add to tools/xentrace/ xenalyze: print newline after unknown hvm events xenalyze: include odd mmio states in default output xenalyze: handle TRC_TRACE_WRAP_BUFFER xenalyze: handle more events in sched_process xenalyze: remove

[Xen-devel] [PATCH v6 5/8] xenalyze: handle more events in sched_process

2015-06-11 Thread Olaf Hering
Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: Ian Campbell ian.campb...@citrix.com Cc: Wei Liu wei.l...@citrix.com --- tools/xentrace/xenalyze.c | 73

[Xen-devel] [PATCH v6 3/8] xenalyze: include odd mmio states in default output

2015-06-11 Thread Olaf Hering
Signed-off-by: Olaf Hering o...@aepfle.de Acked-by: George Dunlap george.dun...@eu.citrix.com Acked-by: Wei Liu wei.l...@citrix.com Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: Ian Campbell ian.campb...@citrix.com Cc: Wei Liu wei.l

[Xen-devel] [PATCH v6 2/8] xenalyze: print newline after unknown hvm events

2015-06-11 Thread Olaf Hering
Signed-off-by: Olaf Hering o...@aepfle.de Acked-by: George Dunlap george.dun...@eu.citrix.com Acked-by: Wei Liu wei.l...@citrix.com Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: Ian Campbell ian.campb...@citrix.com Cc: Wei Liu wei.l

[Xen-devel] [PATCH v6 8/8] xenalyze: remove unused private cpumask_t

2015-06-11 Thread Olaf Hering
Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: Ian Campbell ian.campb...@citrix.com Cc: Wei Liu wei.l...@citrix.com --- tools/xentrace/analyze.h | 13 - 1 file changed, 13 deletions

[Xen-devel] [PATCH v6 6/8] xenalyze: remove trailing whitespaces

2015-06-11 Thread Olaf Hering
Result of sed -i 's@[[:blank:]]\+$@@' tools/xentrace/xenalyze.c Signed-off-by: Olaf Hering o...@aepfle.de Acked-by: George Dunlap george.dun...@eu.citrix.com Acked-by: Wei Liu wei.l...@citrix.com Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc

[Xen-devel] [PATCH v6 4/8] xenalyze: handle TRC_TRACE_WRAP_BUFFER

2015-06-11 Thread Olaf Hering
Signed-off-by: Olaf Hering o...@aepfle.de Acked-by: George Dunlap george.dun...@eu.citrix.com Acked-by: Wei Liu wei.l...@citrix.com Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: Ian Campbell ian.campb...@citrix.com Cc: Wei Liu wei.l

Re: [Xen-devel] [PATCH v4 0/9] add xenalyze to staging

2015-06-09 Thread Olaf Hering
On Wed, Jun 03, Julien Grall wrote: xentrace is not working as we don't have the infrastructure for ARM in Xen. Why is that? After a very quick look __trace_var is available unconditionally. Olaf ___ Xen-devel mailing list Xen-devel@lists.xen.org

Re: [Xen-devel] [PATCH v4 7/9] xenalyze: handle more events in sched_process

2015-06-09 Thread Olaf Hering
On Tue, Jun 02, George Dunlap wrote: On 05/23/2015 09:24 AM, Olaf Hering wrote: void sched_process(struct pcpu_info *p) +fprintf(warn, %s: event:%x (min:%x sub:%x main:%x)\n, +__func__, ri-event, ri-evt.minor, ri-evt.sub, ri-evt.main

[Xen-devel] [PATCH v5 7/8] xenalyze: remove trailing whitespaces

2015-06-09 Thread Olaf Hering
Result of sed -i 's@[[:blank:]]\+$@@' tools/xentrace/xenalyze.c Signed-off-by: Olaf Hering o...@aepfle.de Acked-by: George Dunlap george.dun...@eu.citrix.com Acked-by: Wei Liu wei.l...@citrix.com Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc

[Xen-devel] [PATCH v5 6/8] xenalyze: handle more events in sched_process

2015-06-09 Thread Olaf Hering
Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: Ian Campbell ian.campb...@citrix.com Cc: Wei Liu wei.l...@citrix.com --- tools/xentrace/xenalyze.c | 73

[Xen-devel] [PATCH v5 2/8] xenalyze: increase NR_CPUS to 256

2015-06-09 Thread Olaf Hering
To match the hypervisor default which was introduced in 9da0c5b63933b9912e3903190601661813954d0d, bump the limit. Signed-off-by: Olaf Hering o...@aepfle.de Acked-by: George Dunlap george.dun...@eu.citrix.com Acked-by: Wei Liu wei.l...@citrix.com Cc: Ian Jackson ian.jack...@eu.citrix.com Cc

[Xen-devel] [PATCH v5 8/8] xenalyze: remove argp_program_version

2015-06-09 Thread Olaf Hering
Since xenalyze is now upstream its Open Source and part of the given release. Signed-off-by: Olaf Hering o...@aepfle.de Acked-by: George Dunlap george.dun...@eu.citrix.com Acked-by: Wei Liu wei.l...@citrix.com Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Stefano Stabellini stefano.stabell

[Xen-devel] [PATCH v5 5/8] xenalyze: handle TRC_TRACE_WRAP_BUFFER

2015-06-09 Thread Olaf Hering
Signed-off-by: Olaf Hering o...@aepfle.de Acked-by: George Dunlap george.dun...@eu.citrix.com Acked-by: Wei Liu wei.l...@citrix.com Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: Ian Campbell ian.campb...@citrix.com Cc: Wei Liu wei.l

[Xen-devel] [PATCH v5 4/8] xenalyze: include odd mmio states in default output

2015-06-09 Thread Olaf Hering
Signed-off-by: Olaf Hering o...@aepfle.de Acked-by: George Dunlap george.dun...@eu.citrix.com Acked-by: Wei Liu wei.l...@citrix.com Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: Ian Campbell ian.campb...@citrix.com Cc: Wei Liu wei.l

[Xen-devel] [PATCH v5 3/8] xenalyze: print newline after unknown hvm events

2015-06-09 Thread Olaf Hering
Signed-off-by: Olaf Hering o...@aepfle.de Acked-by: George Dunlap george.dun...@eu.citrix.com Acked-by: Wei Liu wei.l...@citrix.com Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: Ian Campbell ian.campb...@citrix.com Cc: Wei Liu wei.l

[Xen-devel] [PATCH v5 0/8] add xenalyze to staging

2015-06-09 Thread Olaf Hering
to tools/xentrace changes between v1 and v2: - move to tools/xentrace/xenalyze - drop patch which touches sched_switch_process - add patch to remove argp_program_version - add patch to bump NR_CPUS Olaf Hering (8): xenalyze: add to tools/xentrace/ xenalyze: increase NR_CPUS to 256 xenalyze

Re: [Xen-devel] xen-unstable build fails with XEN_DUMP_DIR undeclader in xl_cmdimpl.c

2015-06-09 Thread Olaf Hering
On Mon, Jun 08, Fabio Fantoni wrote: I saw that config/Paths.mk contains: XEN_DUMP_DIR := /var/lib/xen/dump But build fails with: xl_cmdimpl.c: In function âhandle_domain_deathâ: xl_cmdimpl.c:2330:33: error: âXEN_DUMP_DIRâ undeclared (first use in this function)

Re: [Xen-devel] [PATCH v4 0/9] add xenalyze to staging

2015-06-09 Thread Olaf Hering
On Wed, Jun 03, Ian Campbell wrote: On Sat, 2015-05-23 at 08:24 +, Olaf Hering wrote: Having xenalyze in the source tree makes it much easier to keep private debug code in hypervisor and xenalyze in sync. It helped alot while debugging the root cause for commit

[Xen-devel] [PATCH v4 3/9] xenalyze: increase NR_CPUS to 256

2015-05-23 Thread Olaf Hering
To match the hypervisor default which was introduced in 9da0c5b63933b9912e3903190601661813954d0d, bump the limit. Signed-off-by: Olaf Hering o...@aepfle.de Acked-by: George Dunlap george.dun...@eu.citrix.com Acked-by: Wei Liu wei.l...@citrix.com Cc: Ian Jackson ian.jack...@eu.citrix.com Cc

<    1   2   3   4   5   6   7   8   9   >