Re: [Xen-devel] io.c:164:d25v0 Weird HVM ioemulation status 1. domain_crash called from io.c:165

2015-04-24 Thread Olaf Hering
On Fri, Apr 24, Sander Eikelenboom wrote: (XEN) [2015-04-24 11:55:47.802] domain_crash called from io.c:165 Since i haven't seen it before, it's probably hard to replicate. I see it all time on my beloved ProBook. With an ordinary domU.cfg. name=fv-13.1-pvscsi

[Xen-devel] [PATCH] libxl: remove duplicate check for pci subsystem type

2015-04-24 Thread Olaf Hering
Both attach and detach functions get called only if the type matches. Signed-off-by: Olaf Hering o...@aepfle.de Cc: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_driver.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index d76efda

Re: [Xen-devel] [PATCH v4 3/5] libxl: add support for vscsi

2015-04-22 Thread Olaf Hering
On Tue, Apr 21, Konrad Rzeszutek Wilk wrote: On Fri, Apr 17, 2015 at 08:30:58AM +, Olaf Hering wrote: +=item Bvscsi=[ VSCSI_SPEC_STRING, VSCSI_SPEC_STRING, ...] + +Specifies the PVSCSI devices to be provided to the guest. PVSCSI passes +dom0 SCSI devices as-is to the guest. s/dom0

Re: [Xen-devel] [PATCH v4 1/5] vscsiif.h: fix WWN notation for p-dev property

2015-04-21 Thread Olaf Hering
On Tue, Apr 21, Konrad Rzeszutek Wilk wrote: On Fri, Apr 17, 2015 at 08:30:56AM +, Olaf Hering wrote: The pvops kernel expects either naa.WWN:LUN or h:c:t:l in the p-dev property. Add the missing :LUN part to the comment. What about the older kernels that had said driver? Which older

Re: [Xen-devel] [PATCH v4 1/5] vscsiif.h: fix WWN notation for p-dev property

2015-04-21 Thread Olaf Hering
On Tue, Apr 21, Konrad Rzeszutek Wilk wrote: On Tue, Apr 21, 2015 at 04:35:17PM +0200, Olaf Hering wrote: On Tue, Apr 21, Konrad Rzeszutek Wilk wrote: On Fri, Apr 17, 2015 at 08:30:56AM +, Olaf Hering wrote: The pvops kernel expects either naa.WWN:LUN or h:c:t:l in the p-dev

[Xen-devel] [PATCH 1/2] libxl: pass environment to device model

2015-04-20 Thread Olaf Hering
Prepare device-model setup functions to pass also environment variables to the spawned process. This is required for upcoming changes which will set DISPLAY and XAUTHORITY for SDL. Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Stefano Stabellini

[Xen-devel] [PATCH 2/2] libxl: set DISPLAY and XAUTHORITY if sdl is enabled

2015-04-20 Thread Olaf Hering
With this change the following domU.cfg will show the VM window on the local dom0 display, instead of the remote side (it via ssh -X login): vnc=0 sdl=1 display=:0 xauthority=/run/gdm/auth-for-olaf-nMXhOi/database Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian Jackson ian.jack

Re: [Xen-devel] [PATCH] libxl: initialize vfb defbools in libxlMakeVfb

2015-04-20 Thread Olaf Hering
On Mon, Apr 20, Ian Campbell wrote: If what you said were true then an assert would be a rather harsh overreaction to an application coding error. Currently both libxl and libvirt are coded that way. Since the sdl code path in libvirt was never executed the crash in libxlMakeVfbList was not

Re: [Xen-devel] [PATCH] libxl: initialize vfb defbools in libxlMakeVfb

2015-04-20 Thread Olaf Hering
On Mon, Apr 20, Ian Campbell wrote: It makes no sense to do that at init time, the whole purpose of a defbool is to allow the calling application to choose a value or to explicitly leave it as a request to for the default (which might vary depending on other selections). Yes, and thats why

Re: [Xen-devel] [PATCH] libxl: initialize vfb defbools in libxlMakeVfb

2015-04-20 Thread Olaf Hering
On Mon, Apr 20, Ian Campbell wrote: On Fri, 2015-04-17 at 13:40 -0600, Jim Fehlig wrote: On 04/17/2015 11:19 AM, Olaf Hering wrote: If the domU configu has sdl enabled libvirtd crashes: libvirtd[5158]: libvirtd: libxl.c:343: libxl_defbool_val: Assertion `!libxl_defbool_is_default(db

Re: [Xen-devel] [PATCH 2/2] libxl: set DISPLAY and XAUTHORITY if sdl is enabled

2015-04-20 Thread Olaf Hering
On Mon, Apr 20, Olaf Hering wrote: With this change the following domU.cfg will show the VM window on the local dom0 display, instead of the remote side (it via ssh -X login): vnc=0 sdl=1 display=:0 xauthority=/run/gdm/auth-for-olaf-nMXhOi/database libvirt works as well

Re: [Xen-devel] [PATCH V3 1/6] libxl: export some functions for pvusb use

2015-04-20 Thread Olaf Hering
On Sun, Apr 19, Chunyan Liu wrote: +++ b/tools/libxl/libxl_internal.h +_hidden int libxl__device_nextid(libxl__gc *gc, uint32_t domid, char *device); +_hidden int libxl__resolve_domid(libxl__gc *gc, const char *name, + uint32_t *domid); +/* generic

Re: [Xen-devel] [PATCH] libxl: initialize vfb defbools in libxlMakeVfb

2015-04-18 Thread Olaf Hering
On Fri, Apr 17, Jim Fehlig wrote: On 04/17/2015 11:19 AM, Olaf Hering wrote: +libxl_defbool_set(x_vfb-vnc.enable, 0); Not shown here, but just before the switch is libxl_device_vfb_init(x_vfb); which IIUC (looking at the impl in $xensrc/tools/libxl/_libxl_types.c

Re: [Xen-devel] [PATCH] libxl: initialize vfb defbools in libxlMakeVfb

2015-04-18 Thread Olaf Hering
On Fri, Apr 17, Jim Fehlig wrote: On 04/17/2015 11:59 AM, Olaf Hering wrote: On Fri, Apr 17, Olaf Hering wrote: If the domU configu has sdl enabled libvirtd crashes: libvirtd[5158]: libvirtd: libxl.c:343: libxl_defbool_val: Assertion `!libxl_defbool_is_default(db)' failed. Initialize

Re: [Xen-devel] converting gatewaydev= from domU.cfg to libvirt.xml fails

2015-04-18 Thread Olaf Hering
On Fri, Apr 17, Jim Fehlig wrote: On 04/17/2015 12:50 PM, Olaf Hering wrote: How should this be converted? /etc/init.d/boot.local tap=xentap tunctl -pt ${tap} ip addr add 1.1.1.1/29 dev ${tap} ip link set up dev ${tap} domU.cfg vif=[ 'mac=00:16:3e:13:01:00,ip=1.1.1.2,type=vif

[Xen-devel] [PATCH v4 3/5] libxl: add support for vscsi

2015-04-17 Thread Olaf Hering
Port pvscsi support from xend to libxl: vscsi=['pdev,vdev{,options}'] xl scsi-attach xl scsi-detach xl scsi-list Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: Ian Campbell ian.campb

[Xen-devel] [PATCH v4 0/5] libbxl: add support for pvscsi, iteration 4

2015-04-17 Thread Olaf Hering
/msg03958.html Most comments are addressed. This version has been tested with SLES as backend and frontend. This version has been tested with pvops as backend and SLES as frontend. Olaf Hering (5): vscsiif.h: fix WWN notation for p-dev property docs: add vscsi to xenstore-paths.markdown

[Xen-devel] [PATCH v4 5/5] Scripts to create and delete xen-scsiback nodes in Linux target framework

2015-04-17 Thread Olaf Hering
Signed-off-by: Olaf Hering o...@aepfle.de --- tools/misc/Makefile | 4 ++ tools/misc/target-create-xen-scsiback.sh | 94 tools/misc/target-delete-xen-scsiback.sh | 39 + 3 files changed, 137 insertions(+) diff --git a/tools/misc

[Xen-devel] [PATCH v4 2/5] docs: add vscsi to xenstore-paths.markdown

2015-04-17 Thread Olaf Hering
Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian Campbell ian.campb...@citrix.com Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Jan Beulich jbeul...@suse.com Cc: Keir Fraser k...@xen.org Cc: Tim Deegan t...@xen.org --- docs/misc/xenstore-paths.markdown | 10 ++ 1 file changed, 10

[Xen-devel] [PATCH v4 4/5] vscsiif.h: add some notes about xenstore layout

2015-04-17 Thread Olaf Hering
Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian Campbell ian.campb...@citrix.com Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Jan Beulich jbeul...@suse.com Cc: Keir Fraser k...@xen.org Cc: Tim Deegan t...@xen.org --- xen/include/public/io/vscsiif.h | 68

[Xen-devel] [PATCH v4 1/5] vscsiif.h: fix WWN notation for p-dev property

2015-04-17 Thread Olaf Hering
The pvops kernel expects either naa.WWN:LUN or h:c:t:l in the p-dev property. Add the missing :LUN part to the comment. Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian Campbell ian.campb...@citrix.com Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Jan Beulich jbeul...@suse.com Cc: Keir Fraser k

Re: [Xen-devel] [PATCH v4 2/5] docs: add vscsi to xenstore-paths.markdown

2015-04-17 Thread Olaf Hering
On Fri, Apr 17, Olaf Hering wrote: @@ -302,6 +307,10 @@ A virtual keyboard device backend. Described by A virtual network device backend. Described by [xen/include/public/io/netif.h][NETIF] + ~/backend/vscsi/$DOMID/$DEVID/* [] + +A PV SCSI backend. Described in [pvscsi.txt

[Xen-devel] crash in efi_runtime_call

2015-04-17 Thread Olaf Hering
Since booting xen fails on my ProBook unless I specify maxcpus=1 I tried the EFI firmware today. To my surprise it boots and finds all cpus. But once some efi driver in dom0 is loaded xen crashes. The same happens with xen-4.4 as included in SLE12. ... (XEN) Xen call trace: (XEN)

Re: [Xen-devel] crash in efi_runtime_call

2015-04-17 Thread Olaf Hering
On Fri, Apr 17, Konrad Rzeszutek Wilk wrote: The /noexitboot will inhibit Xen from calling ExitBootServices. How is that supposed to be passed to xen.efi? Looks like I have no cmdline interface. Olaf ___ Xen-devel mailing list

[Xen-devel] [PATCH] libxl: include a XLU_Config in _libxlDriverConfig

2015-04-17 Thread Olaf Hering
Upcoming changes for vscsi will use libxlutil.so to prepare the configuration for libxl. The helpers needs a xlu struct for logging. Provide one and reuse the existing output as log target. Signed-off-by: Olaf Hering o...@aepfle.de Cc: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_conf.c | 6

Re: [Xen-devel] [PATCH] libxl: initialize allocated libxl_device_vfb array

2015-04-17 Thread Olaf Hering
On Fri, Apr 17, Olaf Hering wrote: Its already allocated by calloc, but the init function sets -devid. Scratch that one, libxlMakeVfb already calls libxl_device_vfb_init. Somehow I missed that. Olaf ___ Xen-devel mailing list Xen-devel@lists.xen.org

[Xen-devel] [PATCH] libxl: initialize allocated libxl_device_vfb array

2015-04-17 Thread Olaf Hering
Its already allocated by calloc, but the init function sets -devid. Just in case anything cares. Signed-off-by: Olaf Hering o...@aepfle.de Cc: Jim Fehlig jfeh...@suse.com --- src/libxl/libxl_conf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libxl/libxl_conf.c b/src/libxl

[Xen-devel] [PATCH] libxl: initialize vfb defbools in libxlMakeVfb

2015-04-17 Thread Olaf Hering
If the domU configu has sdl enabled libvirtd crashes: libvirtd[5158]: libvirtd: libxl.c:343: libxl_defbool_val: Assertion `!libxl_defbool_is_default(db)' failed. Initialize the relevant defbool variables in libxl_device_vfb. Signed-off-by: Olaf Hering o...@aepfle.de Cc: Jim Fehlig jfeh

[Xen-devel] converting gatewaydev= from domU.cfg to libvirt.xml fails

2015-04-17 Thread Olaf Hering
How should this be converted? /etc/init.d/boot.local tap=xentap tunctl -pt ${tap} ip addr add 1.1.1.1/29 dev ${tap} ip link set up dev ${tap} domU.cfg vif=[ 'mac=00:16:3e:13:01:00,ip=1.1.1.2,type=vif,gatewaydev=xentap,script=vif-route' ] The result from convert-xml xen-xl domU,cfg is:

[Xen-devel] building xen and libvirt with odd --prefix fails

2015-04-16 Thread Olaf Hering
My xen is configured with --prefix=/odd/path --enable-rpath. My libvirt is configured with env PKG_CONFIG_PATH=/odd/path/share/pkgconfig bash -x autogen.sh --without-xen --with-libxl. Now make in libvirt fails to find xen/xen.h needed by xenconfig/xen_common.c, I think it expects it in

Re: [Xen-devel] building xen and libvirt with odd --prefix fails

2015-04-16 Thread Olaf Hering
On Thu, Apr 16, Olaf Hering wrote: And initially I did not pass the matching --prefix to libvirts configure. Even with matching --prefix libvirt does not look in $prefix/include for xen/xen.h, even with --includedir=$prefix/include. Using env CFLAGS=-I/odd/path/include CPPFLAGS=-I/odd/path

Re: [Xen-devel] [PATCH 2/9] raisin: use timestamps for dpkg Version to avoid versions that start with letters

2015-04-15 Thread Olaf Hering
On Wed, Apr 15, Stefano Stabellini wrote: -Version: $(git show --oneline | head -1 | cut -d -f 1) +Version: $(date +%s) Maybe this should be for humans, like 'date +%Y%m%d.%H%M%S'? Olaf ___ Xen-devel mailing list Xen-devel@lists.xen.org

Re: [Xen-devel] [PATCH 1/2] Introduce configure option --with-system-qemu-traditional

2015-04-15 Thread Olaf Hering
On Wed, Apr 15, Stefano Stabellini wrote: tools/configure.ac | 51 +++- tools/libxl/libxl_dm.c | 11 ++- 2 files changed, 39 insertions(+), 23 deletions(-) This change should be mentioned in the INSTALL file. Olaf

Re: [Xen-devel] wating for backend changes (was Re: [PATCH v3 4/4] libxl: add support for vscsi)

2015-04-14 Thread Olaf Hering
On Fri, Apr 10, Olaf Hering wrote: How is new code supposed to wait for backend changes? Right now there are two APIs for that: - libxl__wait_for_backend loops for a while until it returns an error. - libxl__ev_devstate_wait registers a watch and a timer. In case of pvscsi

Re: [Xen-devel] [PATCH] hvmloader: fix building error

2015-04-08 Thread Olaf Hering
On Wed, Apr 08, Wen Congyang wrote: On 04/08/2015 03:21 PM, Olaf Hering wrote: On Wed, Apr 08, Wen Congyang wrote: commit b9245b75 introduces a building error: make[1]: Entering directory `/root/work/xen/tools/firmware/hvmloader' gcc -O1 -fno-omit-frame-pointer -m32 -march=i686 -g

Re: [Xen-devel] sudden hang on boot on AMD Notebook

2015-04-08 Thread Olaf Hering
On Tue, Apr 07, Konrad Rzeszutek Wilk wrote: You might also want to use 'sync_console'. This does not give any extra info in the case of the reported hang. Olaf ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] sudden hang on boot on AMD Notebook

2015-04-07 Thread Olaf Hering
On Mon, Mar 30, Olaf Hering wrote: Just last week I was running staging to test pvscsi on this HP ProBook 6555b, since around Wednesday I think. But todays staging fails to boot. So I started a bisect in xen/, but every attempt to boot xen.gz results in a hang at the same place. Even going

Re: [Xen-devel] sudden hang on boot on AMD Notebook

2015-04-02 Thread Olaf Hering
On Wed, Apr 01, Konrad Rzeszutek Wilk wrote: You can also use the USB EHCI debug port. It works great on laptops. Is there an howto for that? Olaf ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] ENC:[Xen-users] Failed to insert 'xen_evtchn': No such device

2015-04-02 Thread Olaf Hering
On Wed, Apr 01, Carlos Gustavo Ramirez Rodriguez wrote: Hello DEVs, can anyone help me? Ian Campbell pointed me that maybe you could help me, here is the link to the last e-mail line that started this problem fixing: http://lists.xenproject.org/archives/html/xen-users/2015-04/msg9.html

Re: [Xen-devel] sudden hang on boot on AMD Notebook

2015-04-02 Thread Olaf Hering
On Wed, Apr 01, Olaf Hering wrote: On Wed, Apr 01, Ian Campbell wrote: Key handlers are only available via serial, I think, and not VGA which it sounds like what Olaf is looking at. This laptop has a serial port, and thats what I used to grab the output. No reaction there. Just today I

Re: [Xen-devel] ENC:[Xen-users] Failed to insert 'xen_evtchn': No such device

2015-04-02 Thread Olaf Hering
On Thu, Apr 02, Carlos Gustavo Ramirez Rodriguez wrote: systemctl enable xen-qemu-dom0-disk-backend.service systemctl enable xen-init-dom0.service systemctl enable xenconsoled.service These MAGIC lines did the trick! Thanks for the help, this solved the First Problem, BUT, if you know those

[Xen-devel] [PATCH 2/4 v2] INSTALL: mention variables for reproducible builds

2015-04-01 Thread Olaf Hering
Mention two variables introduced by commit ac977f5 (use more fixed strings to build the hypervisor). Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian Campbell ian.campb...@citrix.com Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Jan Beulich jbeul...@suse.com Cc: Keir Fraser k...@xen.org Cc: Tim

[Xen-devel] [PATCH 3/4] hvmloader: add knob for fixed SMBIOS date string

2015-04-01 Thread Olaf Hering
To allow reproducible builds of hvmloader introduce a make variable SMBIOS_REL_DATE=mm/dd/ to provide a fixed date string. Without this change the hvmloader binary changes with every rebuild. Signed-off-by: Olaf Hering o...@aepfle.de Acked-by: Jan Beulich jbeul...@suse.com Cc: Keir Fraser k

[Xen-devel] [PATCH 4/4] hvmloader: add knob for fixed VGABIOS date string

2015-04-01 Thread Olaf Hering
To allow reproducible builds of hvmloader introduce a make variable VGABIOS_REL_DATE=dd Mon to provide a fixed date string. Without this change the hvmloader binary changes with every rebuild. Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Stefano

[Xen-devel] [PATCH 0/4 v2] tools: various changes

2015-04-01 Thread Olaf Hering
via a rpm spec file for example can be automated in such build environment. The current behaviour is preserved. Please review once more and apply. Thanks, Olaf Olaf Hering (4): tools/hotplug: introduce XENSTORED_ARGS= in sysconfig file. INSTALL: mention variables for reproducible builds

Re: [Xen-devel] sudden hang on boot on AMD Notebook

2015-04-01 Thread Olaf Hering
On Mon, Mar 30, Andrew Cooper wrote: On 30/03/15 13:14, Olaf Hering wrote: Just last week I was running staging to test pvscsi on this HP ProBook 6555b, since around Wednesday I think. But todays staging fails to boot. So I started a bisect in xen/, but every attempt to boot xen.gz results

Re: [Xen-devel] sudden hang on boot on AMD Notebook

2015-04-01 Thread Olaf Hering
On Wed, Apr 01, Ian Campbell wrote: Key handlers are only available via serial, I think, and not VGA which it sounds like what Olaf is looking at. This laptop has a serial port, and thats what I used to grab the output. No reaction there. Just today I noticed the blinking cursor. Will continue

[Xen-devel] sudden hang on boot on AMD Notebook

2015-03-30 Thread Olaf Hering
Just last week I was running staging to test pvscsi on this HP ProBook 6555b, since around Wednesday I think. But todays staging fails to boot. So I started a bisect in xen/, but every attempt to boot xen.gz results in a hang at the same place. Even going back to the state of 4.5.0. Any idea what

[Xen-devel] [PATCH] hotplug/Linux: add missing backslash in dom0_ip

2015-03-27 Thread Olaf Hering
Without it the actual error message is not written to xenstore. Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: Ian Campbell ian.campb...@citrix.com Cc: Wei Liu wei.l...@citrix.com --- tools/hotplug

Re: [Xen-devel] [PATCH v3 4/4] libxl: add support for vscsi

2015-03-27 Thread Olaf Hering
On Thu, Mar 26, Ian Campbell wrote: On Thu, 2015-03-26 at 13:55 +0100, Olaf Hering wrote: On Fri, Mar 13, Ian Campbell wrote: Also, should this be a defbool or not? This is a good idea. I remmeber xend had code to make sure that all devices within a vhost had the same value for feature

Re: [Xen-devel] [PATCH v3 4/4] libxl: add support for vscsi

2015-03-26 Thread Olaf Hering
On Fri, Mar 13, Ian Campbell wrote: On Fri, 2015-03-06 at 10:45 +0100, Olaf Hering wrote: +(feature_host, bool), What is this feature thing? What does !host imply? This enables raw SCSI command passthrough in xenlinux. If the flag is off then each command

Re: [Xen-devel] [PATCH v2] tools/mkrpm: improve version.release handling

2015-03-26 Thread Olaf Hering
On Wed, Mar 25, George Dunlap wrote: Reviewed-by: George Dunlap george.dun...@eu.citrix.com Tested-by: George Dunlap george.dun...@eu.citrix.com Thanks. Whoever is in charge, please backport to staging-4.5 as well. Olaf ___ Xen-devel mailing list

Re: [Xen-devel] [PATCH 5/5] hvmloader: add knob for fixed VGABIOS date string

2015-03-25 Thread Olaf Hering
On Tue, Mar 24, Ian Campbell wrote: Is it expected that they should all be settable independently? Or would one global setting be sufficient? A single timestamp would be nice, sure. If so then a single variable which can be set to something accepted by date -d which could be formatted in

Re: [Xen-devel] [PATCH 3/5] INSTALL: mention variables for reproducible builds

2015-03-25 Thread Olaf Hering
On Tue, Mar 24, Ian Campbell wrote: On Fri, 2015-03-20 at 18:24 +0100, Olaf Hering wrote: +Some components of xen and tools will include an unpredictable timestamp +into the binaries. To allow reproducible builds the following variables +can be used to provide fixed timestamps

Re: [Xen-devel] ocaml libxl bindings and KeyedUnion

2015-03-24 Thread Olaf Hering
On Fri, Mar 20, Ian Campbell wrote: On Fri, 2015-03-20 at 17:44 +0100, Olaf Hering wrote: + (dev, Struct(None, [(m, libxl_vscsi_hctl)])), + (wwn, Struct(None, [(m, string)])), + (hctl, Struct(None, [(m, libxl_vscsi_hctl)])), Aside: What is the difference

Re: [Xen-devel] [PATCH 1/5] tools/mkrpm: improve version.release handling

2015-03-24 Thread Olaf Hering
On Mon, Mar 23, George Dunlap wrote: On 03/23/2015 06:49 PM, Olaf Hering wrote: release will be anything after a dash, or 0. And an optional .$PKG_RELEASE will be appended. Just trying to decode this: So if I were using PKG_RELEASE=$(date ...), then I'd get something like xen-4.6

[Xen-devel] [PATCH v2] tools/mkrpm: improve version.release handling

2015-03-24 Thread Olaf Hering
effect that xen.gz always gets a different filename every time. Update mkrpm to recognize PKG_RELEASE=. Its value will be appended to the Release string. It can be filled with a time stamp, like: make rpmball PKG_RELEASE=`date +%Y%m%d%H%M%S` Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian

Re: [Xen-devel] [PATCH 4/5] hvmloader: add knob for fixed SMBIOS date string

2015-03-23 Thread Olaf Hering
On Mon, Mar 23, Jan Beulich wrote: On 20.03.15 at 18:24, o...@aepfle.de wrote: To allow reproducible builds of hvmloader introduce a make variable SMBIOS_REL_DATE=mm/dd/ to provide a fixed date string. Without this change the hvmloader binary changes with every rebuild. I don't

Re: [Xen-devel] [PATCH 1/5] tools/mkrpm: improve version.release handling

2015-03-23 Thread Olaf Hering
On Mon, Mar 23, George Dunlap wrote: I'm not really happy with having the massive number show up automatically when anyone makes an rpm. What would you think about adding a variable where you could set this as part of the build process? e.g., XEN_RPM_RELEASE=$(date +%Y%m%d%H%M%S) make

Re: [Xen-devel] [PATCH 1/5] tools/mkrpm: improve version.release handling

2015-03-23 Thread Olaf Hering
On Mon, Mar 23, George Dunlap wrote: xen-4.6_unstable-20150323160547.x86_64.rpm Do you want to continue to get unstable as release? My patch uses everything passed as $2 as Version string. I think thats ok. Release will be either 0 or $PKG_DATE. Olaf

Re: [Xen-devel] [PATCH 1/5] tools/mkrpm: improve version.release handling

2015-03-23 Thread Olaf Hering
On Mon, Mar 23, George Dunlap wrote: On Mon, Mar 23, 2015 at 5:52 PM, Olaf Hering o...@aepfle.de wrote: On Mon, Mar 23, George Dunlap wrote: xen-4.6_unstable-20150323160547.x86_64.rpm Do you want to continue to get unstable as release? My patch uses everything passed as $2 as Version

[Xen-devel] ocaml libxl bindings and KeyedUnion

2015-03-20 Thread Olaf Hering
Some change commited to staging earlier this week breaks ocaml bindings, as shown below. I think it was introduced between a68d1b65bb1bbb9b8db2d82695d32ac09c52a2d7..d4ea77c9d7b314001ff4e2eb7618b45f11551371: NotImplementedError: Cannot handle KeyedUnion fields which are not Structs But now that

[Xen-devel] [PATCH 5/5] hvmloader: add knob for fixed VGABIOS date string

2015-03-20 Thread Olaf Hering
To allow reproducible builds of hvmloader introduce a make variable VGABIOS_REL_DATE=dd Mon to provide a fixed date string. Without this change the hvmloader binary changes with every rebuild. Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Stefano

[Xen-devel] [PATCH 4/5] hvmloader: add knob for fixed SMBIOS date string

2015-03-20 Thread Olaf Hering
To allow reproducible builds of hvmloader introduce a make variable SMBIOS_REL_DATE=mm/dd/ to provide a fixed date string. Without this change the hvmloader binary changes with every rebuild. Signed-off-by: Olaf Hering o...@aepfle.de Cc: Keir Fraser k...@xen.org Cc: Jan Beulich jbeul

[Xen-devel] [PATCH 2/5] tools/hotplug: introduce XENSTORED_ARGS= in sysconfig file.

2015-03-20 Thread Olaf Hering
It is already used in the runlevel script and the service file. Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: Ian Campbell ian.campb...@citrix.com Cc: Wei Liu wei.l...@citrix.com --- tools/hotplug

[Xen-devel] [PATCH 3/5] INSTALL: mention variables for reproducible builds

2015-03-20 Thread Olaf Hering
Mention two variables introduced by commit ac977f5 (use more fixed strings to build the hypervisor). Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian Campbell ian.campb...@citrix.com Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Jan Beulich jbeul...@suse.com Cc: Keir Fraser k...@xen.org Cc: Tim

[Xen-devel] [PATCH 1/5] tools/mkrpm: improve version.release handling

2015-03-20 Thread Olaf Hering
of date+time. Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian Campbell ian.campb...@citrix.com Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: Wei Liu wei.l...@citrix.com Cc: George Dunlap george.dun...@eu.citrix.com --- tools/misc/mkrpm | 12

[Xen-devel] [PATCH 0/5] tools: various changes

2015-03-20 Thread Olaf Hering
builds are really just interesting for distro packages. Passing all the variables via a rpm spec file for example can be automated in such build environment. The current behaviour is preserved. Please review once more and apply. Thanks, Olaf Olaf Hering (5): tools/mkrpm: improve

Re: [Xen-devel] [PATCH v2] Build: Fix stubdom vtpm build failure

2015-03-17 Thread Olaf Hering
On Mon, Mar 16, Quan Xu wrote: Typedefs are duplicated in stubdom/vtpmmgr/tcg.h and supported compilers do not cope with current staging branch. This version finally compiles. Thanks! Olaf ___ Xen-devel mailing list Xen-devel@lists.xen.org

Re: [Xen-devel] [PATCH v3 4/4] libxl: add support for vscsi

2015-03-16 Thread Olaf Hering
On Fri, Mar 13, Wei Liu wrote: On Fri, Mar 13, 2015 at 02:45:28PM +0100, Olaf Hering wrote: On Thu, Mar 12, Ian Campbell wrote: On Thu, 2015-03-12 at 17:07 +0100, Olaf Hering wrote: Related: I see libxl_device_vscsi_dispose does now a pointer check, so I assume its required

Re: [Xen-devel] [PATCH] Build: Fix stubdom vtpm build failure

2015-03-16 Thread Olaf Hering
On Fri, Mar 13, Quan Xu wrote: Typedefs are duplicated in stubdom/vtpmmgr/tcg.h and supported compilers do not cope with current staging branch. What remains after applying this patch is this error: [ 665s] tpm2_types.h:229:19: error: redefinition of typedef 'TPM_ALGORITHM_ID' [ 665s]

Re: [Xen-devel] Xen 4.6 Development Update (two months reminder)

2015-03-13 Thread Olaf Hering
On Thu, Mar 12, Daniel Kiper wrote: IIRC, 4.3 release (and probably earlier ones) was a mess. Olaf did the work for 4.5. However, as he pointed out in another email last one is incorrect. Olaf, are you going to fix it for 4.6? I suppose it is quite simple. There are still many hardcoded

Re: [Xen-devel] Xen 4.6 Development Update (two months reminder)

2015-03-13 Thread Olaf Hering
On Thu, Mar 12, Daniel Kiper wrote: On Thu, Mar 12, 2015 at 10:21:56AM +, wei.l...@citrix.com wrote: * Rearrange and cleanup installation destination directories (/var - var/lib/xen) (fair) - Daniel Kiper If Olaf did all work then we can remove this one. What does this mean

Re: [Xen-devel] stubdom vtpm build failure in staging

2015-03-13 Thread Olaf Hering
Signed-off-by: Olaf Hering o...@aepfle.de Signed-off-by: Quan Xu quan...@intel.com .. (1) -- /dev/null +++ b/stubdom/vtpmmgr/common_types.h @@ -0,0 +1,11 @@ +#ifndef VTPM_ODD_TYPES +#define VTPM_ODD_TYPES 1 +typedef unsigned char BYTE; +typedef unsigned char BOOL; +typedef uint16_t

Re: [Xen-devel] [PATCH v3 4/4] libxl: add support for vscsi

2015-03-13 Thread Olaf Hering
On Thu, Mar 12, Ian Campbell wrote: On Thu, 2015-03-12 at 17:20 +0100, Olaf Hering wrote: On Wed, Mar 11, Ian Campbell wrote: On Fri, 2015-03-06 at 10:45 +0100, Olaf Hering wrote: +int libxl_device_vscsi_parse_pdev(libxl__gc *gc, char *pdev, unsigned int *hst

Re: [Xen-devel] [PATCH v3 4/4] libxl: add support for vscsi

2015-03-13 Thread Olaf Hering
On Wed, Mar 11, Ian Campbell wrote: On Wed, 2015-03-11 at 17:02 +0100, Olaf Hering wrote: On Wed, Mar 11, Ian Campbell wrote: On Fri, 2015-03-06 at 10:45 +0100, Olaf Hering wrote: +void libxl_device_vscsi_append_dev(libxl_ctx *ctx, libxl_device_vscsi *hst

Re: [Xen-devel] [PATCH v3 4/4] libxl: add support for vscsi

2015-03-13 Thread Olaf Hering
On Thu, Mar 12, Ian Campbell wrote: On Thu, 2015-03-12 at 17:07 +0100, Olaf Hering wrote: Related: I see libxl_device_vscsi_dispose does now a pointer check, so I assume its required to validate input in libxl_device_vscsi_get_host. Not sure what you mean, you should call

Re: [Xen-devel] [PATCH v3 4/4] libxl: add support for vscsi

2015-03-12 Thread Olaf Hering
On Wed, Mar 11, Ian Campbell wrote: On Fri, 2015-03-06 at 10:45 +0100, Olaf Hering wrote: +void libxl_device_vscsi_append_dev(libxl_ctx *ctx, libxl_device_vscsi *hst, + libxl_vscsi_dev *dev); +int libxl_device_vscsi_get_host(libxl_ctx *ctx

Re: [Xen-devel] [PATCH v3 4/4] libxl: add support for vscsi

2015-03-12 Thread Olaf Hering
On Wed, Mar 11, Ian Campbell wrote: On Fri, 2015-03-06 at 10:45 +0100, Olaf Hering wrote: +void libxl_device_vscsi_append_dev(libxl_ctx *ctx, libxl_device_vscsi *hst, + libxl_vscsi_dev *dev); +int libxl_device_vscsi_get_host(libxl_ctx *ctx

Re: [Xen-devel] [PATCH v3 4/4] libxl: add support for vscsi

2015-03-12 Thread Olaf Hering
On Wed, Mar 11, Ian Campbell wrote: On Fri, 2015-03-06 at 10:45 +0100, Olaf Hering wrote: +int libxl_device_vscsi_parse_pdev(libxl__gc *gc, char *pdev, unsigned int *hst, +unsigned int *chn, unsigned int *tgt, +unsigned int

Re: [Xen-devel] Xen 4.6 Development Update (two months reminder)

2015-03-12 Thread Olaf Hering
On Thu, Mar 12, Ian Campbell wrote: dist/install/var/xen/dump which all seems proper and correct to me. Except the last one, which should be /var/lib/xen/dump or whatever dumpdir the OS/FHS provides. Olaf ___ Xen-devel mailing list

Re: [Xen-devel] [PATCH v3 4/4] libxl: add support for vscsi

2015-03-09 Thread Olaf Hering
On Fri, Mar 06, Wei Liu wrote: +void libxl__device_vscsi_add(libxl__egc *egc, uint32_t domid, + libxl_device_vscsi *vscsi, + libxl__ao_device *aodev) You need to update this domain's JSON configuration. Cf. libxl__device_vtpm_add and

[Xen-devel] libxl__device_nextid and holes

2015-03-09 Thread Olaf Hering
I wonder if libxl__device_nextid is robust enough to handle holes. If there are 3 devices (0,1,2) of type X, and device #0 or #1 is removed with X-detach, wouldn't the code return nextid==2? The result would be that the caller will write to the wrong path. I have not veified this theory in

Re: [Xen-devel] [PATCH v3 2/4] docs: add vscsi to xenstore-paths.markdown

2015-03-06 Thread Olaf Hering
On Fri, Mar 06, Wei Liu wrote: On Fri, Mar 06, 2015 at 10:45:54AM +0100, Olaf Hering wrote: [...] ~/backend/console/$DOMID/$DEVID/* [] A PV console backend. Described in [console.txt](console.txt) @@ -403,6 +412,7 @@ ifb device used by Remus to buffer network output from

Re: [Xen-devel] [PATCH v3 3/4] docs: add pvscsi.txt

2015-03-06 Thread Olaf Hering
On Fri, Mar 06, Wei Liu wrote: On Fri, Mar 06, 2015 at 10:45:55AM +0100, Olaf Hering wrote: +== TODO === + +How to do live migration? + - pdev will likely be evaluated again on the target host if it came from + domU.cfg. But what about pdev from 'xl scsi-attach pdev vdev'? Its

Re: [Xen-devel] [PATCH v3 4/4] libxl: add support for vscsi

2015-03-06 Thread Olaf Hering
, 2015 at 10:45:56AM +0100, Olaf Hering wrote: Port pvscsi support from xend to libxl. See pvscsi.txt for details. Outstanding work is listed in the TODO section. There is no TODO section in this patch. :-) See the line above, its in pvscsi.txt. Better split this patch into two. One for libxl

[Xen-devel] [PATCH v3 4/4] libxl: add support for vscsi

2015-03-06 Thread Olaf Hering
Port pvscsi support from xend to libxl. See pvscsi.txt for details. Outstanding work is listed in the TODO section. Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: Ian Campbell ian.campb...@citrix.com

[Xen-devel] [PATCH v3 3/4] docs: add pvscsi.txt

2015-03-06 Thread Olaf Hering
Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian Campbell ian.campb...@citrix.com Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Jan Beulich jbeul...@suse.com Cc: Keir Fraser k...@xen.org Cc: Tim Deegan t...@xen.org --- docs/misc/pvscsi.txt | 188

[Xen-devel] [PATCH v3 0/4] libbxl: add support for pvscsi, iteration 3

2015-03-06 Thread Olaf Hering
has been tested with pvops as backend and SLES as frontend. Please review. The first two changes could be applied independent from the libxl changes. Olaf Olaf Hering (4): vscsiif.h: fix WWN notation for p-dev property docs: add vscsi to xenstore-paths.markdown docs: add pvscsi.txt libxl

[Xen-devel] [PATCH v3 2/4] docs: add vscsi to xenstore-paths.markdown

2015-03-06 Thread Olaf Hering
Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian Campbell ian.campb...@citrix.com Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Jan Beulich jbeul...@suse.com Cc: Keir Fraser k...@xen.org Cc: Tim Deegan t...@xen.org --- docs/misc/xenstore-paths.markdown | 10 ++ 1 file changed, 10

[Xen-devel] [PATCH v3 1/4] vscsiif.h: fix WWN notation for p-dev property

2015-03-06 Thread Olaf Hering
The pvops kernel expects either naa.WWN:LUN or h:c:t:l in the p-dev property. Add the missing :LUN part to the comment. Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian Campbell ian.campb...@citrix.com Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Jan Beulich jbeul...@suse.com Cc: Keir Fraser k

Re: [Xen-devel] [PATCH 4/4] libxl: add support for vscsi

2015-03-02 Thread Olaf Hering
On Mon, Mar 02, Olaf Hering wrote: +libxl_device_vscsi *libxl_device_vscsi_list(libxl_ctx *ctx, uint32_t domid, int *num) +fe_path = libxl__sprintf(gc, %s/device/vscsi, libxl__xs_get_dompath(gc, domid)); IanC, last year you made a comment that this path should not be trusted because

Re: [Xen-devel] [PATCH 1/4] vscsiif.h: remove reference to WWN

2015-03-02 Thread Olaf Hering
On Mon, Mar 02, Juergen Gross wrote: On 03/02/2015 11:15 AM, Olaf Hering wrote: The code in xend, xenlinux and pvops 3.18 expects the h:c:t:l notation. Remove incorrect reference to WWN because it was never supported. And its not clear how it could be supported. p-devname can be used to store

Re: [Xen-devel] [PATCH 4/4] libxl: add support for vscsi

2015-03-02 Thread Olaf Hering
On Mon, Mar 02, Olaf Hering wrote: +++ b/tools/libxl/libxl_types.idl +libxl_vscsi_hctl = Struct(vscsi_hctl, [ +(hst, uint32), +(chn, uint32), +(tgt, uint32), +(lun, uint32), +]) + +libxl_vscsi_dev = Struct(vscsi_dev, [ +(vscsi_dev_id, libxl_devid

Re: [Xen-devel] [PATCH 1/4] vscsiif.h: remove reference to WWN

2015-03-02 Thread Olaf Hering
On Mon, Mar 02, Olaf Hering wrote: On Mon, Mar 02, Juergen Gross wrote: On 03/02/2015 11:15 AM, Olaf Hering wrote: The code in xend, xenlinux and pvops 3.18 expects the h:c:t:l notation. Remove incorrect reference to WWN because it was never supported. And its not clear how it could

[Xen-devel] [PATCH 2/4] docs: add vscsi to xenstore-paths.markdown

2015-03-02 Thread Olaf Hering
Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian Campbell ian.campb...@citrix.com Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Jan Beulich jbeul...@suse.com Cc: Keir Fraser k...@xen.org Cc: Tim Deegan t...@xen.org --- NOTE: the URLS are still broken because the unstable directory does not exist

[Xen-devel] [PATCH 1/4] vscsiif.h: remove reference to WWN

2015-03-02 Thread Olaf Hering
The code in xend, xenlinux and pvops 3.18 expects the h:c:t:l notation. Remove incorrect reference to WWN because it was never supported. And its not clear how it could be supported. p-devname can be used to store a config string. Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian Campbell

[Xen-devel] [PATCH 3/4] docs: add pvscsi.txt

2015-03-02 Thread Olaf Hering
Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian Campbell ian.campb...@citrix.com Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Jan Beulich jbeul...@suse.com Cc: Keir Fraser k...@xen.org Cc: Tim Deegan t...@xen.org --- docs/misc/pvscsi.txt | 147

Re: [Xen-devel] [PATCH 3/4] docs: add pvscsi.txt

2015-03-02 Thread Olaf Hering
On Mon, Mar 02, Juergen Gross wrote: On 03/02/2015 11:16 AM, Olaf Hering wrote: +How to do live migration? + - pdev will likely be evaluated again on the target host if it came from + domU.cfg. But what about pdev from 'xl scsi-attach pdev vdev'? Its required + to adjust h:c:t:l

Re: [Xen-devel] [PATCH 4/4] libxl: add support for vscsi

2015-03-02 Thread Olaf Hering
On Mon, Mar 02, Ian Campbell wrote: On Mon, 2015-03-02 at 15:20 +0100, Olaf Hering wrote: Its used as domid/vhost/vscsi-devs/dev-vscsi_dev_id/. What name should be used to reference the devices? Also just devid even if it refers to devices private to the vscsi host? Not sure. PCI uses

<    2   3   4   5   6   7   8   9   >