on the skb allocation failure. Refill timer is now triggered
on insufficient requests or skb allocation failure.
Signed-off-by: Vineeth Remanan Pillai <vinee...@amazon.com>
Fixes: 90c311b0eeea (xen-netfront: Fix Rx stall during network stress and OOM)
Reported-by: Boris Ostrovsky <boris.o
On 01/30/2017 08:47 AM, Vineeth Remanan Pillai wrote:
On 01/29/2017 03:09 PM, Boris Ostrovsky wrote:
There are couple of problems with this patch.
1. The 'if' clause now evaluates to true on pretty much every call to
xennet_alloc_rx_buffers().
Thanks for catching this. In my testing I did
On 01/30/2017 09:06 AM, Boris Ostrovsky wrote:
On 01/30/2017 11:47 AM, Vineeth Remanan Pillai wrote:
2. It tickles a latent bug during resume where the timer triggers
before we re-connect. The trouble is that we now try to dereference
queue->rx.sring which is NULL since we disconn
On 01/29/2017 03:09 PM, Boris Ostrovsky wrote:
There are couple of problems with this patch.
1. The 'if' clause now evaluates to true on pretty much every call to
xennet_alloc_rx_buffers().
Thanks for catching this. In my testing I did not notice this - mostly
because of the nature of the
From: Vineeth Remanan Pillai <vinee...@amazon.com>
During an OOM scenario, request slots could not be created as skb
allocation fails. So the netback cannot pass in packets and netfront
wrongly assumes that there is no more work to be done and it disables
polling. This causes Rx to
On 01/18/2017 12:10 PM, David Miller wrote:
This v2 never made it into patchwork. I don't know why, so please resend it to
netdev with the accumulated reviewed-by etc. tags added.
Thanks.
Sorry about that. Will resend as a separate thread right away.
Thanks
On 01/15/2017 10:24 PM, Juergen Gross wrote:
On 13/01/17 18:55, Remanan Pillai wrote:
From: Vineeth Remanan Pillai <vinee...@amazon.com>
During an OOM scenario, request slots could not be created as skb
allocation fails. So the netback cannot pass in packets and netfront
wrongly a
From: Vineeth Remanan Pillai <vinee...@amazon.com>
During an OOM scenario, request slots could not be created as skb
allocation fails. So the netback cannot pass in packets and netfront
wrongly assumes that there is no more work to be done and it disables
polling. This causes Rx to
On 01/12/2017 12:17 PM, David Miller wrote:
From: Vineeth Remanan Pillai <vinee...@amazon.com>
Date: Wed, 11 Jan 2017 23:17:17 +
@@ -1054,7 +1059,11 @@ static int xennet_poll(struct napi_struct *napi, int
budget)
napi_complete(napi);
RING_FINAL_CHECK_FOR_RES
and in the
event of this error, re-enable polling so that request slots could be
created when memory is available.
Signed-off-by: Vineeth Remanan Pillai <vinee...@amazon.com>
---
drivers/net/xen-netfront.c | 23 ---
1 file changed, 16 insertions(+), 7 deletions(-)
diff
10 matches
Mail list logo
