Re: [Xen-devel] [PATCH v4 01/14] golang/xenlight: Create stub package

2017-03-23 Thread Ronald Rojas
On Mon, Mar 20, 2017 at 05:51:03PM +, George Dunlap wrote: > On Thu, Mar 16, 2017 at 7:08 PM, Ronald Rojas <ronlad...@gmail.com> wrote: > > Create a basic Makefile to build and install libxenlight Golang > > bindings. Also add a stub package which only opens libxl con

Re: [Xen-devel] [PATCH v4 01/14] golang/xenlight: Create stub package

2017-03-23 Thread Ronald Rojas
On Mon, Mar 20, 2017 at 02:45:30PM +, George Dunlap wrote: > On Thu, Mar 16, 2017 at 7:08 PM, Ronald Rojas <ronlad...@gmail.com> wrote: > > Create a basic Makefile to build and install libxenlight Golang > > bindings. Also add a stub package which only opens libxl con

[Xen-devel] [PATCH v4 07/14] golang/xenlight: Implement libxl_scheduler enumeration

2017-03-16 Thread Ronald Rojas
Include both constants and a Stringification for libxl_scheduler. Signed-off-by: George Dunlap <george.dun...@citrix.com> Signed-off-by: Ronald Rojas <ronlad...@gmail.com> --- CC: xen-devel@lists.xen.org CC: george.dun...@citrix.com CC: ian.jack...@eu.citrix.com CC: wei.l...@citrix.co

[Xen-devel] [PATCH v4 09/14] golang/xenlight: Implement Domain operations

2017-03-16 Thread Ronald Rojas
Add calls for the following Domain related functionality - libxl_domain_pause - libxl_domain_shutdown - libxl_domain_reboot - libxl_list_domain Signed-off-by: Ronald Rojas <ronlad...@gmail.com> --- CC: xen-devel@lists.xen.org CC: george.dun...@citrix.com CC: ian.jack...@eu.citrix.com CC:

[Xen-devel] [PATCH v4 13/14] golang/xenlight: Implement ActionOnShutdown and DomainConfig

2017-03-16 Thread Ronald Rojas
Applied enumeration and implemented toC method for ActionOnShutdown Implemented struct and implemented toC method for DomainConfig Signed-off-by: Ronald Rojas <ronlad...@gmail.com> --- CC: xen-devel@lists.xen.org CC: george.dun...@citrix.com CC: ian.jack...@eu.citrix.com CC: wei.l...@citr

[Xen-devel] [PATCH v4 11/14] golang/xenlight: Implement get console path operations

2017-03-16 Thread Ronald Rojas
Implement Golang enumeration of libxl_console_type as ConsoleType Implement the following libxl functions: - libxl_console_get_tty - libxl_primary_console_get_tty Signed-off-by: Ronald Rojas <ronlad...@gmail.com> --- CC: xen-devel@lists.xen.org CC: george.dun...@citrix.com CC: ia

[Xen-devel] [PATCH v4 12/14] golang/xenlight: Created boilerplate code for device related structs

2017-03-16 Thread Ronald Rojas
Created boilerplate struct and toC methods for the following structs: - KeyValueList - DomainBuildInfo - DeviceNic - DevicePci - DeviceRdm - DeviceDtdev - DeviceVfb - DeviceVkb - DeviceVtpm - DeviceChannel - DeviceUsbctrl - DeviceUsbdev Signed-off-by: Ronald Rojas <ronlad...@gmail.

[Xen-devel] [PATCH v4 14/14] golang/xenlight: Implement domain create/destroy operations

2017-03-16 Thread Ronald Rojas
Implemented DomainCreateNew and DomainDestroy methods Signed-off-by: Ronald Rojas <ronlad...@gmail.com> --- CC: xen-devel@lists.xen.org CC: george.dun...@citrix.com CC: ian.jack...@eu.citrix.com CC: wei.l...@citrix.com --- --- tools/golang/xenlight/xenlight.g

[Xen-devel] [PATCH v4 10/14] golang/xenlight: Implement Vcpuinfo and ListVcpu

2017-03-16 Thread Ronald Rojas
Include Golang version of libxl_vcpu_info as VcpuInfo Add a Golang call for libxl_list_vcpu as ListVcpu Signed-off-by: Ronald Rojas <ronlad...@gmail.com> --- CC: xen-devel@lists.xen.org CC: george.dun...@citrix.com CC: ian.jack...@eu.citrix.com CC: wei.l...@citrix.com --- --- tools/

[Xen-devel] [PATCH v4 08/14] golang/xenlight: Implement cpupool operations

2017-03-16 Thread Ronald Rojas
..@citrix.com> Signed-off-by: Ronald Rojas <ronlad...@gmail.com> --- Changes - Renamed CToGo functions as toGo CC: xen-devel@lists.xen.org CC: george.dun...@citrix.com CC: ian.jack...@eu.citrix.com CC: wei.l...@citrix.com --- --- tools/golang/xenlight/xenlight.go | 237 +++

[Xen-devel] [PATCH v4 06/14] golang/xenlight: Implement libxl_bitmap and helper operations

2017-03-16 Thread Ronald Rojas
Implement Bitmap type, along with helper functions. The Bitmap type is implemented interllay in a way which makes it easy to copy into and out of the C libxl_bitmap type. Signed-off-by: George Dunlap <george.dun...@citrix.com> Signed-off-by: Ronald Rojas <ronlad...@gmail.com> --- C

[Xen-devel] [PATCH v4 04/14] golang/xenlight: Implement libxl_domain_info and libxl_domain_unpause

2017-03-16 Thread Ronald Rojas
Add calls for the following host-related functionality: - libxl_domain_info - libxl_domain_unpause Include Golang version for the libxl_domain_info as DomainInfo. Signed-off-by: George Dunlap <george.dun...@citrix.com> Signed-off-by: Ronald Rojas <ronlad...@gmail.com> --- Change

[Xen-devel] [PATCH v4 01/14] golang/xenlight: Create stub package

2017-03-16 Thread Ronald Rojas
will be added in next patch. Signed-off-by: Ronald Rojas <ronlad...@gmail.com> Signed-off-by: George Dunlap <george.dun...@citrix.com> --- Changes: - Added global logger variable and destroyed the logger instance when closing the context. - Whitespace fixes - Commented out CONFI

[Xen-devel] [PATCH v4 02/14] golang/xenlight: Add error constants and standard handling

2017-03-16 Thread Ronald Rojas
Create error type Errorxl for throwing proper xenlight errors. Update Ctx functions to throw Errorxl errors. Signed-off-by: Ronald Rojas <ronlad...@gmail.com> --- CC: xen-devel@lists.xen.org CC: george.dun...@citrix.com CC: ian.jack...@eu.citrix.com CC: wei.l...@citrix.com --- --- tools/

[Xen-devel] [PATCH RFC v3 7/8] golang/xenlight: Implement libxl_scheduler enumeration

2017-03-09 Thread Ronald Rojas
Include both constants and a Stringification for libxl_scheduler. Signed-off-by: George Dunlap <george.dun...@citrix.com> Signed-off-by: Ronald Rojas <ronlad...@gmail.com> --- CC: xen-devel@lists.xen.org CC: george.dun...@citrix.com CC: ian.jack...@eu.citrix.com CC: wei.l..

[Xen-devel] [PATCH RFC v3 8/8] golang/xenlight: Implement cpupool operations

2017-03-09 Thread Ronald Rojas
..@citrix.com> Signed-off-by: Ronald Rojas <ronlad...@gmail.com> --- CC: xen-devel@lists.xen.org CC: george.dun...@citrix.com CC: ian.jack...@eu.citrix.com CC: wei.l...@citrix.com --- tools/golang/xenlight/xenlight.go | 238 ++ 1 file changed, 238 ins

[Xen-devel] [PATCH RFC v3 6/8] golang/xenlight: Implement libxl_bitmap and helper operations

2017-03-09 Thread Ronald Rojas
Implement Bitmap type, along with helper functions. The Bitmap type is implemented interllay in a way which makes it easy to copy into and out of the C libxl_bitmap type. Signed-off-by: George Dunlap <george.dun...@citrix.com> Signed-off-by: Ronald Rojas <ronlad...@gmail.com> --- C

[Xen-devel] [PATCH RFC v3 2/8] golang/xenlight: Add error constants and standard handling

2017-03-09 Thread Ronald Rojas
Create error type Errorxl for throwing proper xenlight errors. Update Ctx functions to throw Errorxl errors. Signed-off-by: Ronald Rojas <ronlad...@gmail.com> --- CC: xen-devel@lists.xen.org CC: george.dun...@citrix.com CC: ian.jack...@eu.citrix.com CC: wei.l...@citrix.com --- --- tools/

[Xen-devel] [PATCH RFC v3 5/8] golang/xenlight: Add tests host related functionality functions

2017-03-09 Thread Ronald Rojas
Create tests for the following functions: - GetVersionInfo - GetPhysinfo - GetDominfo - GetMaxCpus - GetOnlineCpus - GetMaxNodes - GetFreeMemory Signed-off-by: Ronald Rojas <ronlad...@gmail.com> Signed-off-by: George Dunlap <george.dun...@citrix.com> --- changes since last versio

[Xen-devel] [PATCH RFC v3 1/8] golang/xenlight: Create stub package

2017-03-09 Thread Ronald Rojas
will be added in next patch. Signed-off-by: Ronald Rojas <ronlad...@gmail.com> Signed-off-by: George Dunlap <george.dun...@citrix.com> --- Changes: - Added global logger variable and destroyed the logger instance when closing the context. - Whitespace fixes CC: xen-devel@list

[Xen-devel] [PATCH RFC v3 4/8] golang/xenlight: Implement libxl_domain_info and libxl_domain_unpause

2017-03-09 Thread Ronald Rojas
Add calls for the following host-related functionality: - libxl_domain_info - libxl_domain_unpause Include Golang version for the libxl_domain_info as DomainInfo. Signed-off-by: George Dunlap <george.dun...@citrix.com> Signed-off-by: Ronald Rojas <ronlad...@gmail.com> --- Change

Re: [Xen-devel] [PATCH v2 4/5] golang/xenlight: Implement libxl_domain_info and libxl_domain_unpause

2017-03-03 Thread Ronald Rojas
On Fri, Mar 03, 2017 at 03:15:51PM +, George Dunlap wrote: > On 02/03/17 16:07, Ronald Rojas wrote: > > Add calls for the following host-related functionality: > > - libxl_domain_info > > - libxl_domain_unpause > > > > Include Golang version for the li

Re: [Xen-devel] [PATCH v2 3/5] golang/xenlight: Add host-related functionality

2017-03-03 Thread Ronald Rojas
On Fri, Mar 03, 2017 at 02:54:56PM +, George Dunlap wrote: > On 02/03/17 16:07, Ronald Rojas wrote: > > Add calls for the following host-related functionality: > > - libxl_get_max_cpus > > - libxl_get_online_cpus > > - libxl_get_max_nodes > > - libxl_get_fre

Re: [Xen-devel] [PATCH v2 5/5] golang/xenlight: Add tests host related functionality functions

2017-03-02 Thread Ronald Rojas
On Thu, Mar 02, 2017 at 05:53:00PM +, George Dunlap wrote: > On 02/03/17 17:36, Ian Jackson wrote: > > Ronald Rojas writes ("[PATCH v2 5/5] golang/xenlight: Add tests host > > related functionality functions"): > >> Create tests for the followin

[Xen-devel] [PATCH v2 4/5] golang/xenlight: Implement libxl_domain_info and libxl_domain_unpause

2017-03-02 Thread Ronald Rojas
Add calls for the following host-related functionality: - libxl_domain_info - libxl_domain_unpause Include Golang version for the libxl_domain_info as DomainInfo. Signed-off-by: George Dunlap <george.dun...@citrix.com> Signed-off-by: Ronald Rojas <ronlad...@gmail.com> --- Change

[Xen-devel] [PATCH v2 2/5] golang/xenlight: Add error constants and standard handling

2017-03-02 Thread Ronald Rojas
Create error type Errorxl for throwing proper xenlight errors. Update Ctx functions to throw Errorxl errors. Signed-off-by: Ronald Rojas <ronlad...@gmail.com> --- Changes since last patch: - Whitespace fixes CC: xen-devel@lists.xen.org CC: george.dun...@citrix.com CC: ian.jack...@eu.citr

[Xen-devel] [PATCH v2 1/5] golang/xenlight: Create stub package

2017-03-02 Thread Ronald Rojas
will be added in next patch. Signed-off-by: Ronald Rojas <ronlad...@gmail.com> Signed-off-by: George Dunlap <george.dun...@citrix.com> --- Changes: - Changed GPL Lisense to LGPL Lisense - Initialized xentoollog_logger for storing error messages - Moved manual-enable config opt

Re: [Xen-devel] [PATCH RFC 1/8] golang/xenlight: Create stub package

2017-01-26 Thread Ronald Rojas
On Wed, Jan 25, 2017 at 05:16:47PM +, George Dunlap wrote: > On Mon, Jan 23, 2017 at 4:43 PM, Ronald Rojas <ronlad...@gmail.com> wrote: > > > +func (Ctx *Context) Open() (err error) { > > + if Ctx.ctx != nil { > > + return >

Re: [Xen-devel] [PATCH RFC 1/8] golang/xenlight: Create stub package

2017-01-26 Thread Ronald Rojas
On Wed, Jan 25, 2017 at 04:55:38PM +, Wei Liu wrote: > On Mon, Jan 23, 2017 at 11:43:30AM -0500, Ronald Rojas wrote: > [...] > > + > > +subdir-distclean-firmware: .phony > > + $(MAKE) -C firmware distclean > > + > > This looks unrelated. You're corr

[Xen-devel] [PATCH RFC 1/8] golang/xenlight: Create stub package

2017-01-23 Thread Ronald Rojas
will be added in next patch. Signed-off-by: Ronald Rojas <ronlad...@gmail.com> --- tools/Makefile| 17 tools/golang/xenlight/Makefile| 31 ++ tools/golang/xenlight/xenlight.go | 86 +++ 3 files change

[Xen-devel] [PATCH RFC 6/8] golang/xenlight: Implement libxl_bitmap and helper operations

2017-01-23 Thread Ronald Rojas
Implement Bitmap type, along with helper functions. The Bitmap type is implemented interllay in a way which makes it easy to copy into and out of the C libxl_bitmap type. Signed-off-by: George Dunlap <george.dun...@citrix.com> Signed-off-by: Ronald Rojas <ronlad...@gmail.com> ---

[Xen-devel] [PATCH RFC 4/8] golang/xenlight: Implement libxl_domain_info and libxl_domain_unpause

2017-01-23 Thread Ronald Rojas
Add calls for the following host-related functionality: - libxl_domain_info - libxl_domain_unpause Include Golang version for the libxl_domain_info as DomainInfo. Signed-off-by: George Dunlap <george.dun...@citrix.com> Signed-off-by: Ronald Rojas <ronlad...@gmail.com> --- tools/gol

[Xen-devel] [PATCH RFC 8/8] golang/xenlight: Implement cpupool operations

2017-01-23 Thread Ronald Rojas
..@citrix.com> Signed-off-by: Ronald Rojas <ronlad...@gmail.com> --- tools/golang/xenlight/xenlight.go | 238 ++ 1 file changed, 238 insertions(+) diff --git a/tools/golang/xenlight/xenlight.go b/tools/golang/xenlight/xenlight.go index 0990f07..c856284 100

[Xen-devel] [PATCH RFC 7/8] golang/xenlight: Implement libxl_scheduler enumeration

2017-01-23 Thread Ronald Rojas
Include both constants and a Stringification for libxl_scheduler. Signed-off-by: George Dunlap <george.dun...@citrix.com> Signed-off-by: Ronald Rojas <ronlad...@gmail.com> --- tools/golang/xenlight/xenlight.go | 62 +++ 1 file changed, 62 inserti

[Xen-devel] [PATCH RFC 2/8] golang/xenlight: Add error constants and standard handling

2017-01-23 Thread Ronald Rojas
Create error type Errorxl for throwing proper xenlight errors. Update Ctx functions to throw Errorxl errors. Signed-off-by: Ronald Rojas <ronlad...@gmail.com> --- tools/golang/xenlight/xenlight.go | 75 ++- 1 file changed, 74 insertions(+), 1 de

Re: [Xen-devel] [PATCH RFC 1/8] golang/xenlight: Create stub package

2017-01-19 Thread Ronald Rojas
On Thu, Jan 19, 2017 at 12:03:22PM +, Wei Liu wrote: > On Wed, Jan 18, 2017 at 02:56:39PM -0500, Ronald Rojas wrote: > > > diff --git a/tools/golang/xenlight/Makefile b/tools/golang/xenlight/Makefile > > new file mode 100644 > > index 000..a45336b > >

Re: [Xen-devel] [PATCH RFC 2/8] golang/xenlight: Add error constants and standard handling

2017-01-19 Thread Ronald Rojas
On Wed, Jan 18, 2017 at 11:16:31PM +0100, Dario Faggioli wrote: > On Wed, 2017-01-18 at 14:56 -0500, Ronald Rojas wrote: > > Create error type Errorxl for throwing proper xenlight > > errors. > > > > Update Ctx functions to throw Errorxl errors. > > > &

Re: [Xen-devel] [PATCH RFC 1/8] golang/xenlight: Create stub package

2017-01-18 Thread Ronald Rojas
On Wed, Jan 18, 2017 at 11:10:32PM +0100, Dario Faggioli wrote: > Hey, > > I'm afraid I can't comment on nothing, as I'm not at all into go. > > But there's a thing that I've noticed while skipping the patch out of > curiosity... > > On Wed, 2017-01-18 at 14:56 -

[Xen-devel] [PATCH RFC 6/8] tools/xenlight: Implement libxl_scheduler enumeration

2017-01-18 Thread Ronald Rojas
Include both constants and a Stringification for libxl_scheduler. Signed-off-by: George Dunlap <george.dun...@citrix.com> Signed-off-by: Ronald Rojas <ronlad...@gmail.com> --- tools/golang/xenlight/xenlight.go | 72 +++ 1 file changed, 72 inserti

[Xen-devel] [PATCH RFC 2/8] golang/xenlight: Add error constants and standard handling

2017-01-18 Thread Ronald Rojas
Create error type Errorxl for throwing proper xenlight errors. Update Ctx functions to throw Errorxl errors. Signed-off-by: Ronald Rojas <ronlad...@gmail.com> --- tools/golang/xenlight/xenlight.go | 77 +-- 1 file changed, 73 insertions(+), 4 del

[Xen-devel] [PATCH RFC 1/8] golang/xenlight: Create stub package

2017-01-18 Thread Ronald Rojas
will be added in next patch. Signed-off-by: Ronald Rojas <ronlad...@gmail.com> --- tools/Makefile| 15 +++- tools/golang/xenlight/Makefile| 29 ++ tools/golang/xenlight/xenlight.go | 80 +++ 3 files change

[Xen-devel] [PATCH RFC 5/8] golang/xenlight: Implement libxl_bitmap and helper operations

2017-01-18 Thread Ronald Rojas
Implement Bitmap type, along with helper functions. The Bitmap type is implemented interllay in a way which makes it easy to copy into and out of the C libxl_bitmap type. Signed-off-by: George Dunlap <george.dun...@citrix.com> Signed-off-by: Ronald Rojas <ronlad...@gmail.com> ---

[Xen-devel] [PATCH RFC 4/8] golang/xenlight: Implement libxl_domain_info and libxl_domain_unpause

2017-01-18 Thread Ronald Rojas
Add calls for the following host-related functionality: - libxl_domain_info - libxl_domain_unpause Include Golang version for the libxl_domain_info as DomainInfo. Signed-off-by: George Dunlap <george.dun...@citrix.com> Signed-off-by: Ronald Rojas <ronlad...@gmail.com> --- tools/gol

[Xen-devel] libxl to json return string

2017-01-12 Thread Ronald Rojas
on the IRC channel that default values are not converted to json, but is there a way to tell what is the default value for a data field? Thanks! Ronald Rojas { "threads_per_core": 1, "cores_per_socket": 4, "max_cpu_id": 3, "nr_cpus": 4, "

Re: [Xen-devel] [PATCH RFC 59/59] tools/xenlight: Create interface for xenlight info

2017-01-03 Thread Ronald Rojas
stab at breaking it down in an example order that makes some > sense to me, and then you can see what you think. I made some guidelines that I think would nicely adjust the naming convention from C to Go. I'll add it as a file below. > > Futher comments... > > On 29/12/16 01:14

Re: [Xen-devel] [PATCH RFC 59/59] tools/xenlight: Create interface for xenlight info

2016-12-29 Thread Ronald Rojas
On Thu, Dec 29, 2016 at 10:52:42AM +, Wei Liu wrote: > On Thu, Dec 29, 2016 at 10:34:34AM +, George Dunlap wrote: > > On 29/12/16 01:14, Ronald Rojas wrote: > > > Create interface to interact with libxl_verions_info > > > and libxl_physinfo. Also introduce

[Xen-devel] [PATCH RFC 54/59] controller/run: Add RunConfig.NumaDisable

2016-12-28 Thread Ronald Rojas
From: George Dunlap If RunConfig.NumaDisable is set, get each worker's WorkerConfig.SoftAffinity to the cpumap of the cpupool the VM is going to be running in. Signed-off-by: George Dunlap --- benchmark.go | 4 run.go | 35

[Xen-devel] [PATCH RFC 59/59] tools/xenlight: Create interface for xenlight info

2016-12-28 Thread Ronald Rojas
Create interface to interact with libxl_verions_info and libxl_physinfo. Also introduce proper error handling. Signed-off-by: Ronald Rojas <ronlad...@gmail.com> --- tools/golang/xenlight/libxl.go| 720 -- tools/golang/xenlight/xenlight.go

[Xen-devel] [PATCH RFC 56/59] controller/plan: Add NumaDisable to SimpleMatrix

2016-12-28 Thread Ronald Rojas
From: George Dunlap Signed-off-by: George Dunlap --- plan.go | 22 ++ 1 file changed, 22 insertions(+) diff --git a/plan.go b/plan.go index 736d9f3..b8e0c6b 100644 --- a/plan.go +++ b/plan.go @@ -26,6 +26,7 @@ type

[Xen-devel] [PATCH RFC 48/59] libxl: Add Ctx.CheckOpen

2016-12-28 Thread Ronald Rojas
From: George Dunlap To standardize the error in the case that Ctx isn't open. Add checks to all functions which call libxl functions directly. Signed-off-by: George Dunlap --- libxl.go | 48 +---

[Xen-devel] [PATCH RFC 39/59] libxl.go: Put common link flags in libxl.go

2016-12-28 Thread Ronald Rojas
From: George Dunlap ...so that the only things added in the makefile are extra flags required when linking against non-installed builds. Add in the text of the GPL while we're at it. Signed-off-by: George Dunlap --- Makefile | 3 +--

[Xen-devel] [PATCH RFC 49/59] libxl: Implement libxl_cpupool_info and Scheduler.FromString()

2016-12-28 Thread Ronald Rojas
From: George Dunlap Unify the libxl_cpupoolinfo -> CpupoolInfo translation in a function. Also make bitmapCToGo pass-by-value rather than pass-by-reference, since it only has two elements and doesn't need to be modified. Signed-off-by: George Dunlap

[Xen-devel] [PATCH RFC 29/59] report: Add basic html report

2016-12-28 Thread Ronald Rojas
From: George Dunlap Use Google's chartapi to create a (mostly) self-contained html file. Start with just scatterplots of the raw data for proof-of-concept. Signed-off-by: George Dunlap --- Makefile | 2 +- benchmark.go | 1 +

[Xen-devel] [PATCH RFC 41/59] libxl.go: Link statically rather than dynamically

2016-12-28 Thread Ronald Rojas
From: George Dunlap Link statically rather than dynamically, because Go prefers that. This also gets rid of the need for schedbench-report, so disable that from the build (although keep the rule and the dummy file around just in case. Also update README.md.

[Xen-devel] [PATCH RFC 46/59] libxl: Reorganize bitmapGotoC

2016-12-28 Thread Ronald Rojas
From: George Dunlap No need to "allocate" the structure elsewhere; passing as a return value makes usage a lot cleaner. Signed-off-by: George Dunlap --- libxl.go | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff

[Xen-devel] [PATCH RFC 34/59] controller: Make a useful config file

2016-12-28 Thread Ronald Rojas
From: George Dunlap Allow a simple "skeleton" config file which can be adapted for the particular use case. Have 'plan' expand this with the real benchmark plan. Include "sample.bench" as a template to modify. Also update the README.md accordingly. Signed-off-by:

[Xen-devel] [PATCH RFC 42/59] plan: Allow "templating" from other runs

2016-12-28 Thread Ronald Rojas
From: George Dunlap Allow 'plan' to use an existing run as a "template": load the template, discard the runs, and save the result in the new file. Use like this: ./schedbench -t 18.bench -f 20.bench plan This will make 20 with an empty plan identical to that in 18.

[Xen-devel] [PATCH RFC 47/59] libxl: Reorganize code

2016-12-28 Thread Ronald Rojas
From: George Dunlap Put all type and enumeration definitions at the top of the file, separated into "builtins" and "idl-generated". Also define Uuid as C.libxl_uud. (Not sure if this gives us the functionality we need without having to manually copy things in.)

[Xen-devel] [PATCH RFC 28/59] controller: Handle worker early death

2016-12-28 Thread Ronald Rojas
From: George Dunlap Log raw worker output. In the event of an unexpected worker death, dump the output and stop further processing. Also fix an assert that caused workers to die if the timer was too exact. Signed-off-by: George Dunlap ---

[Xen-devel] [PATCH RFC 30/59] htmlreport: Include utilization scatterplots

2016-12-28 Thread Ronald Rojas
From: George Dunlap Reformat RunRaw so that it's a more generic scatterplot, with the caller specifying the javascript tag, title, and axes. Keep them as a straight list to be displayed rather than defining them on a per-run basis. Collect a slice of utilization

[Xen-devel] [PATCH RFC 55/59] plan: Make the matrix generation more programmatic

2016-12-28 Thread Ronald Rojas
From: George Dunlap Rather than have nested loops, keep a running list of all the configs we've created so far. Then for each existing new element of the matrix, combine it with all the existing columns. Signed-off-by: George Dunlap ---

[Xen-devel] [PATCH RFC 50/59] libxl: Fix Bitmap.Max(), make Test() / Clear() more robust

2016-12-28 Thread Ronald Rojas
From: George Dunlap Bitmap.Max() should return the largest currently addressable bit; at the moment it returns the total number of bits (which is one greater than the largest addressable bit). This also implicitly fixes a bug in Test() and Clear() which would cause an

[Xen-devel] [PATCH RFC 16/59] controller: Rename an element in BenchmarkRun to be more accurate

2016-12-28 Thread Ronald Rojas
From: George Dunlap Signed-off-by: George Dunlap --- benchmark.go | 6 +++--- main.go | 6 +++--- run.go | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/benchmark.go b/benchmark.go index 2e03fe5..aaa4c98

[Xen-devel] [PATCH RFC 31/59] Make a binary that can run reports on a system without libxl

2016-12-28 Thread Ronald Rojas
From: George Dunlap To simplify report-generation and iteration, make a binary that doesn't link against libxl. Create a "dummy" Xen library that just returns errors and warnings. A better way to do this is probably to do some dlopen hackery (so we can use the same

[Xen-devel] [PATCH RFC 58/59] remove irrelevant files from old repository

2016-12-28 Thread Ronald Rojas
Signed-off-by: Ronald Rojas <ronlad...@gmail.com> --- Makefile | 31 -- benchmark.go | 467 -- htmlreport.go | 238 -- libxl.go

[Xen-devel] [PATCH RFC 43/59] libxl: Add bitmap support

2016-12-28 Thread Ronald Rojas
From: George Dunlap Make the structure compatible so that we can just copy things out or in. Use it to complete the Cpupool structure. Signed-off-by: George Dunlap --- libxl.go | 104

[Xen-devel] [PATCH RFC 14/59] benchmark: Store data in terms of worker sets and worker ids

2016-12-28 Thread Ronald Rojas
From: George Dunlap ...rather than having a single global index, in preparation for summarizing sets of workers as well as individual workers. To do this: - Define a WorkerId type which consists of the worker set + worker id within that set. Pass this to the

[Xen-devel] [PATCH RFC 51/59] controller: Make and/or modify cpupools when possible

2016-12-28 Thread Ronald Rojas
From: George Dunlap Make it possible for schedbench to modify cpupools in order to satisfy run constraints. Make a "RunConfig" option which contains the name of the pool, the scheduler, and the number of cpus. As with WorkerConfig, make these automatically inherited

[Xen-devel] [PATCH RFC 32/59] controller: Allow specification of an input file

2016-12-28 Thread Ronald Rojas
From: George Dunlap So that we can analyze data later if we want. Signed-off-by: George Dunlap --- main.go | 194 +++- 1 file changed, 106 insertions(+), 88 deletions(-) diff --git

[Xen-devel] [PATCH RFC 36/59] controller: Make 'dummy' at the level of 'run' rather than xenworker

2016-12-28 Thread Ronald Rojas
From: George Dunlap Get rid of xenworker_dummy.go and use stubs.go instead. This is much cleaner (as evidenced by the size of the file), and allows us to use libxl-based things in run.go without having to make a load of dummy libxl stub functions. Signed-off-by:

[Xen-devel] [PATCH RFC 33/59] controller: Add verbosity argument and update README with new instructions

2016-12-28 Thread Ronald Rojas
From: George Dunlap Signed-off-by: George Dunlap --- main.go | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/main.go b/main.go index ddb768c..2aa8bae 100644 --- a/main.go +++ b/main.go @@ -30,6 +30,7 @@ func

[Xen-devel] [PATCH RFC 27/59] report: Allow report verbosity to be specified

2016-12-28 Thread Ronald Rojas
From: George Dunlap Take a third argument to control the level of verbosity. Also add helpful deltas when reporting the raw results. Signed-off-by: George Dunlap --- benchmark.go | 17 +++-- main.go | 11 --- 2

[Xen-devel] [PATCH RFC 35/59] libxl: Add ListCpupool

2016-12-28 Thread Ronald Rojas
From: George Dunlap Add libxl bindings for libxl_list_cpupool(). Define the Scheduler type (based on libxl_schedler) with appropriate constants and string functions. Punt on the cpumap part of CpupoolInfo for now. Also create "xltest" command for testing libxl

[Xen-devel] [PATCH RFC 37/59] libxl.go: Provide a single global context by default

2016-12-28 Thread Ronald Rojas
From: George Dunlap Provide a single global context by default, Ctx. Allow this to be called with Ctx.Open() multiple times (but Close() only once). Move xenworker.go to use this global context instead; and open it when starting the benchmark (rather than opening and

[Xen-devel] [PATCH RFC 40/59] controller: Add / update GPL text

2016-12-28 Thread Ronald Rojas
From: George Dunlap Add it to files which are missing it; clarify the wording regarding version 2 only in others. Signed-off-by: George Dunlap --- benchmark.go | 2 +- main.go | 2 +- processworker.go | 2 +- xenworker.go |

[Xen-devel] [PATCH RFC 38/59] controller: Allow multiple schedulers in the same benchmark file

2016-12-28 Thread Ronald Rojas
From: George Dunlap First, add a RunConfig element to BenchmarkRun, which contains a (string) name of the scheduler for this run. Add run.Ready(), which if RunConfig.Scheduler is non-null, will check to see if the cpupool in which the VMs will run (either

[Xen-devel] [PATCH RFC 53/59] controller: Add WorkerConfig.SoftAffinity

2016-12-28 Thread Ronald Rojas
From: George Dunlap If the SoftAffinity is present, pass it as "cpus_soft = ..." in the config file. Signed-off-by: George Dunlap --- benchmark.go | 1 + xenworker.go | 4 2 files changed, 5 insertions(+) diff --git a/benchmark.go

[Xen-devel] [PATCH RFC 57/59] tools/blktap2: remove unused inclusion of sys/sysctl.l

2016-12-28 Thread Ronald Rojas
From: Alistair Francis That header file is not used. Removing it would avoid build error with musl libc, which doesn't have that header file. Signed-off-by: Alistair Francis Reviewed-by: Doug Goldstein [ wei: rewrote

[Xen-devel] [PATCH RFC 52/59] libxl: Implement Bitmap.String()

2016-12-28 Thread Ronald Rojas
From: George Dunlap Implement Bitmap.String, which will convert a bitmap into a string parse-able by libxl. Signed-off-by: George Dunlap --- libxl.go | 59 ++- 1 file changed, 58

[Xen-devel] [PATCH RFC 11/59] Refactor to move towards benchmark "plans" and data analysis

2016-12-28 Thread Ronald Rojas
From: George Dunlap A bit of a roll-up of lots of bits. Signed-off-by: George Dunlap --- Makefile | 4 +- benchmark.go | 256 +++ main.go | 197

[Xen-devel] [PATCH RFC 12/59] Basic 'report' functionality

2016-12-28 Thread Ronald Rojas
From: George Dunlap Go through the raw data and re-calculate throughput for each timeframe. Record for each worker the min and max of these; then take an average over the whole run. Have the report go through each and show the worker setup, as well as the avg, min,

[Xen-devel] [PATCH RFC 21/59] Report utilization statistics

2016-12-28 Thread Ronald Rojas
From: George Dunlap Refactor the min/max into a separate type. Signed-off-by: George Dunlap --- benchmark.go | 119 +-- run.go | 4 +- 2 files changed, 78 insertions(+), 45

[Xen-devel] [PATCH RFC 22/59] Use tsc for time rather than rumpkernel clock_gettime()

2016-12-28 Thread Ronald Rojas
From: George Dunlap The rumpkernel clock_gettime() drifts drastically when the system is overloaded. Switch to using a TSC timesource instead: * Use tsc_mode='native' in guest config * Read the host tsc from /proc/cpuinfo when starting a run * Pass it as an argument

[Xen-devel] [PATCH RFC 13/59] Add GPL headers / COPYING file (v2 only)

2016-12-28 Thread Ronald Rojas
From: George Dunlap Signed-off-by: George Dunlap --- benchmark.go | 18 ++ main.go | 19 +++ processworker.go | 18 ++ xenworker.go | 18 ++ 4 files changed, 73

[Xen-devel] [PATCH RFC 09/59] controller: Refactor creation and stopping of workers into WorkerList methods

2016-12-28 Thread Ronald Rojas
From: George Dunlap Signed-off-by: George Dunlap --- main.go | 59 ++- 1 file changed, 42 insertions(+), 17 deletions(-) diff --git a/main.go b/main.go index dbd6276..89e9cf3 100644 ---

[Xen-devel] [PATCH RFC 17/59] controller: Collect and display statistics on WorkerSets

2016-12-28 Thread Ronald Rojas
From: George Dunlap Introduce WorkerSetSummary, to contain WorkerSummary's and collect data for the set. For now "if false"-out reporting of individual worker averages; we can add this back in as an option later. Signed-off-by: George Dunlap

[Xen-devel] [PATCH RFC 03/59] controller: Initial attempt to generalize process / vm creation

2016-12-28 Thread Ronald Rojas
From: George Dunlap Create a "Worker" interface, and have ProcessWorker implement that interface. Rename "Worker" to "WorkerReport" to make room for the interface. Signed-off-by: George Dunlap --- main.go | 45

[Xen-devel] [PATCH RFC 19/59] Add basic libxl framework, get domain cpu_time

2016-12-28 Thread Ronald Rojas
From: George Dunlap Introduce libxl "Context" class with open, close, and dominfo. Create a global variable in xenworker.go to hold the context; open on first worker creation, close on last worker destruction. Add a new element to WorkerReport, Cputime, and print it

[Xen-devel] [PATCH RFC 26/59] Use kops rather than mops

2016-12-28 Thread Ronald Rojas
From: George Dunlap 1 million operations on my test box takes about 3ms -- meaning the minimum granularity for how long to burn cpu is far longer than typical. Make this kops instead, giving us a minimum granularity of 3us. Update most of the default workers to have

[Xen-devel] [PATCH RFC 24/59] report: Lots of changes

2016-12-28 Thread Ronald Rojas
From: George Dunlap Store raw worker reports in the worker summary for easy printing. Add "level" argument to textreport to easly switch between different levels of granularity. Report total throughput, time, and cputime for workers. When running, print plain time

[Xen-devel] [PATCH RFC 23/59] run: Don't collect results reported after command to stop guests is issued

2016-12-28 Thread Ronald Rojas
From: George Dunlap Particularly on heavily-loaded systems, this can lead to skew as some guests have already stopped processing. Signed-off-by: George Dunlap --- run.go | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff

[Xen-devel] [PATCH RFC 18/59] controller: Add cpupool global config

2016-12-28 Thread Ronald Rojas
From: George Dunlap Define WorkerConfig for worker configuration, add "Pool" as a pool in which to place the worker (currently implemented in Xen only). Add WorkerConfig options at the WorkerSet, BenchmarkRun, and BenchmarkPlan levels; allow local levels to "override"

[Xen-devel] [PATCH RFC 44/59] libxl: Implement CpupoolCreate

2016-12-28 Thread Ronald Rojas
From: George Dunlap Implement CpupoolCreate. For now, follow the lead of "xl cpupool-create", by automatically generating a new uuid each time a new cpupool is created, and by not allowing the user to attempt to set the poolid. This requires us to implement

[Xen-devel] [PATCH RFC 45/59] libxl: Implement Destroy, Add/Remove operations

2016-12-28 Thread Ronald Rojas
From: George Dunlap Also: * Implement useful Bitmap operations: SetRange(), ClearRange(), IsEmpty(), and And(). * Normalize CpupoolInfo element naming. * Implement CpupoolMakeFree, which will scan through cpupools freeing the cpus in the map. Signed-off-by: George

[Xen-devel] [PATCH RFC 25/59] main: Change default workload to something a bit more extreme

2016-12-28 Thread Ronald Rojas
From: George Dunlap Signed-off-by: George Dunlap --- main.go | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/main.go b/main.go index bb46dbc..61d3949 100644 --- a/main.go +++ b/main.go @@ -29,15 +29,15

[Xen-devel] [PATCH RFC 10/59] controller: First cut at BenchmarkParams

2016-12-28 Thread Ronald Rojas
From: George Dunlap Struct for configurable worker sets, as well as a set runtime. Signed-off-by: George Dunlap --- main.go | 75 ++--- 1 file changed, 53 insertions(+), 22

[Xen-devel] [PATCH RFC 15/59] controller: Move "running" code to a separate file

2016-12-28 Thread Ronald Rojas
From: George Dunlap Signed-off-by: George Dunlap --- Makefile | 2 +- benchmark.go | 153 -- run.go | 178 +++ 3 files

[Xen-devel] [PATCH RFC 20/59] xenworker: Use libxl_domain_unpause rather than forking xl

2016-12-28 Thread Ronald Rojas
From: George Dunlap Unpause is a time-sensitive operation; use libxl to unpause directly rather than forking and execing xl for each VM. Signed-off-by: George Dunlap --- libxl.go | 14 ++ xenworker.go | 12 ++-- 2

[Xen-devel] [PATCH RFC 07/59] controller: Introduce basic Xen functionality

2016-12-28 Thread Ronald Rojas
From: George Dunlap Rough-and-ready execution of xl commands, but they work, amazingly. Signed-off-by: George Dunlap --- Makefile | 2 +- main.go | 3 +- xenworker.go | 231

[Xen-devel] [PATCH RFC 05/59] controller: Add WorkerParams argument to Init in Worker interface

2016-12-28 Thread Ronald Rojas
From: George Dunlap For now just make it a plain []string; later make it more abstrcted. Signed-off-by: George Dunlap --- main.go | 22 +- processworker.go | 4 ++-- 2 files changed, 19 insertions(+), 7

  1   2   >