Re: [Xen-devel] [MINOR FIXES 2/2] lowmemd: fix comparison in cleanup

2017-02-20 Thread Wei Liu
On Mon, Feb 20, 2017 at 08:19:09PM +0100, Norbert Manthey wrote: > Hi Wei, > > as far as I can tell, patch 1 has already been added: > > http://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=71af7d4220227529ea43b898683d4d2e68a90ffd > Oh yes, I missed that.

Re: [Xen-devel] [MINOR FIXES 2/2] lowmemd: fix comparison in cleanup

2017-02-20 Thread Norbert Manthey
Hi Wei, as far as I can tell, patch 1 has already been added: http://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=71af7d4220227529ea43b898683d4d2e68a90ffd Best, Norbert On 02/20/2017 05:58 PM, Wei Liu wrote: On Fri, Feb 17, 2017 at 11:31:01AM +, Andrew Cooper wrote: On 17/02/17 10:47,

Re: [Xen-devel] [MINOR FIXES 2/2] lowmemd: fix comparison in cleanup

2017-02-20 Thread Wei Liu
On Fri, Feb 17, 2017 at 11:31:01AM +, Andrew Cooper wrote: > On 17/02/17 10:47, Norbert Manthey wrote: > > The variable virq_port of type uint32_t was compared to being greater than > > -1. This check always results in false for unsigned data types, resulting > > in never cleaning up the

Re: [Xen-devel] [MINOR FIXES 2/2] lowmemd: fix comparison in cleanup

2017-02-17 Thread Andrew Cooper
On 17/02/17 10:47, Norbert Manthey wrote: > The variable virq_port of type uint32_t was compared to being greater than > -1. This check always results in false for unsigned data types, resulting > in never cleaning up the memory. Furthermore, the initialization with a > negative variable for an

[Xen-devel] [MINOR FIXES 2/2] lowmemd: fix comparison in cleanup

2017-02-17 Thread Norbert Manthey
The variable virq_port of type uint32_t was compared to being greater than -1. This check always results in false for unsigned data types, resulting in never cleaning up the memory. Furthermore, the initialization with a negative variable for an unsigned type has been fixed. Signed-off-by: