Re: [Xen-devel] [OSSTEST Nested PATCH v8 3/7] Edit some APIs in TestSupport.pm for nested test

2015-04-28 Thread Ian Campbell
On Mon, 2015-04-27 at 17:36 +0800, Robert Hu wrote: > On Thu, 2015-04-23 at 00:34 +, Hu, Robert wrote: > > > -Original Message- > > > From: Ian Jackson [mailto:ian.jack...@eu.citrix.com] > > > Sent: Wednesday, April 22, 2015 8:50 PM > > > To: Ian Campbell > > > Cc: Pang, LongtaoX; xen-d

Re: [Xen-devel] [OSSTEST Nested PATCH v8 3/7] Edit some APIs in TestSupport.pm for nested test

2015-04-27 Thread Robert Hu
On Thu, 2015-04-23 at 00:34 +, Hu, Robert wrote: > > -Original Message- > > From: Ian Jackson [mailto:ian.jack...@eu.citrix.com] > > Sent: Wednesday, April 22, 2015 8:50 PM > > To: Ian Campbell > > Cc: Pang, LongtaoX; xen-devel@lists.xen.org; wei.l...@citrix.com; Hu, Robert > > Subject:

Re: [Xen-devel] [OSSTEST Nested PATCH v8 3/7] Edit some APIs in TestSupport.pm for nested test

2015-04-22 Thread Hu, Robert
> -Original Message- > From: Ian Jackson [mailto:ian.jack...@eu.citrix.com] > Sent: Wednesday, April 22, 2015 8:50 PM > To: Ian Campbell > Cc: Pang, LongtaoX; xen-devel@lists.xen.org; wei.l...@citrix.com; Hu, Robert > Subject: Re: [OSSTEST Nested PATCH v8 3/7] Edit some APIs in TestSupport.

Re: [Xen-devel] [OSSTEST Nested PATCH v8 3/7] Edit some APIs in TestSupport.pm for nested test

2015-04-22 Thread Ian Jackson
Ian Campbell writes ("Re: [OSSTEST Nested PATCH v8 3/7] Edit some APIs in TestSupport.pm for nested test"): > It will, I think, need to be integrated with the existing assignment to > $ho->{Ip} in select host, so something like: > > if ( $r{"${ident}_ip"} ) { > $ho->{Ip}= $r{"

Re: [Xen-devel] [OSSTEST Nested PATCH v8 3/7] Edit some APIs in TestSupport.pm for nested test

2015-04-22 Thread Ian Campbell
On Wed, 2015-04-22 at 08:25 +, Pang, LongtaoX wrote: > > > > -Original Message- > > From: Ian Campbell [mailto:ian.campb...@citrix.com] > > Sent: Tuesday, April 21, 2015 10:44 PM > > To: Ian Jackson > > Cc: Pang, LongtaoX; xen-devel@lists.xen.org; wei.l...@citrix.com; Hu, Robert > > S

Re: [Xen-devel] [OSSTEST Nested PATCH v8 3/7] Edit some APIs in TestSupport.pm for nested test

2015-04-22 Thread Pang, LongtaoX
> -Original Message- > From: Ian Campbell [mailto:ian.campb...@citrix.com] > Sent: Tuesday, April 21, 2015 10:44 PM > To: Ian Jackson > Cc: Pang, LongtaoX; xen-devel@lists.xen.org; wei.l...@citrix.com; Hu, Robert > Subject: Re: [OSSTEST Nested PATCH v8 3/7] Edit some APIs in TestSupport.p

Re: [Xen-devel] [OSSTEST Nested PATCH v8 3/7] Edit some APIs in TestSupport.pm for nested test

2015-04-21 Thread Ian Campbell
On Tue, 2015-04-21 at 15:30 +0100, Ian Jackson wrote: > Ian Campbell writes ("Re: [OSSTEST Nested PATCH v8 3/7] Edit some APIs in > TestSupport.pm for nested test"): > > On Tue, 2015-04-21 at 14:28 +0100, Ian Jackson wrote: > > > I'm only objecting to the involvement of the host property machinery

Re: [Xen-devel] [OSSTEST Nested PATCH v8 3/7] Edit some APIs in TestSupport.pm for nested test

2015-04-21 Thread Ian Jackson
Ian Campbell writes ("Re: [OSSTEST Nested PATCH v8 3/7] Edit some APIs in TestSupport.pm for nested test"): > On Tue, 2015-04-21 at 14:28 +0100, Ian Jackson wrote: > > I'm only objecting to the involvement of the host property machinery. > > I'm afraid I'm not 100% sure I understand, but do you j

Re: [Xen-devel] [OSSTEST Nested PATCH v8 3/7] Edit some APIs in TestSupport.pm for nested test

2015-04-21 Thread Ian Campbell
On Tue, 2015-04-21 at 14:28 +0100, Ian Jackson wrote: > Ian Campbell writes ("Re: [OSSTEST Nested PATCH v8 3/7] Edit some APIs in > TestSupport.pm for nested test"): > > On Tue, 2015-04-21 at 13:33 +0100, Ian Jackson wrote: > > > It seems to be copying information from runvars into the in-memory >

Re: [Xen-devel] [OSSTEST Nested PATCH v8 3/7] Edit some APIs in TestSupport.pm for nested test

2015-04-21 Thread Ian Jackson
Ian Campbell writes ("Re: [OSSTEST Nested PATCH v8 3/7] Edit some APIs in TestSupport.pm for nested test"): > On Tue, 2015-04-21 at 13:33 +0100, Ian Jackson wrote: > > It seems to be copying information from runvars into the in-memory > > data structure for host properties. But host properties ar

Re: [Xen-devel] [OSSTEST Nested PATCH v8 3/7] Edit some APIs in TestSupport.pm for nested test

2015-04-21 Thread Ian Campbell
On Tue, 2015-04-21 at 13:33 +0100, Ian Jackson wrote: > Ian Campbell writes ("Re: [OSSTEST Nested PATCH v8 3/7] Edit some APIs in > TestSupport.pm for nested test"): > > On Mon, 2015-04-13 at 17:19 -0400, longtao.pang wrote: > > > --- a/Osstest/TestSupport.pm > > > +++ b/Osstest/TestSupport.pm > .

Re: [Xen-devel] [OSSTEST Nested PATCH v8 3/7] Edit some APIs in TestSupport.pm for nested test

2015-04-21 Thread Ian Jackson
Ian Campbell writes ("Re: [OSSTEST Nested PATCH v8 3/7] Edit some APIs in TestSupport.pm for nested test"): > On Mon, 2015-04-13 at 17:19 -0400, longtao.pang wrote: > > --- a/Osstest/TestSupport.pm > > +++ b/Osstest/TestSupport.pm ... > > +if ( $r{"${name}_ip"} ) { > > +$setprop->("IpA

Re: [Xen-devel] [OSSTEST Nested PATCH v8 3/7] Edit some APIs in TestSupport.pm for nested test

2015-04-21 Thread Ian Campbell
On Mon, 2015-04-13 at 17:19 -0400, longtao.pang wrote: > 1. Designate vif model by make-flight. > 2. In L2 installation context, its host (L1) IP address is not queried > from DNS, but after running "ts-nested-setup + host + nested", L1 IP is > stored in runvar. > > Signed-off-by: longtao.pang >

[Xen-devel] [OSSTEST Nested PATCH v8 3/7] Edit some APIs in TestSupport.pm for nested test

2015-04-13 Thread longtao.pang
1. Designate vif model by make-flight. 2. In L2 installation context, its host (L1) IP address is not queried from DNS, but after running "ts-nested-setup + host + nested", L1 IP is stored in runvar. Signed-off-by: longtao.pang --- Changes in v8: Remove the unnecessary symbol of ';' in 'TestSuppo