Re: [Xen-devel] [PATCH] Handles the error returned by the xc_dom_allocate function

2015-11-02 Thread Ian Campbell
On Mon, 2015-10-26 at 10:40 +, Wei Liu wrote: > > + return -1; > > And, please set rv to a proper error code (presumably ENOMEM) Please don't, xc_* functions should return -1 or NULL and set errno on failure. (libxc error reporting is a bit of a mess, but this is the intention).

Re: [Xen-devel] [PATCH] Handles the error returned by the xc_dom_allocate function

2015-10-26 Thread Wei Liu
Aside from what Dario said. On Sun, Oct 25, 2015 at 03:32:24PM +0530, Lasya Venneti wrote: > --- > tools/xenstore/init-xenstore-domain.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/xenstore/init-xenstore-domain.c > b/tools/xenstore/init-xenstore-domain.c > index

[Xen-devel] [PATCH] Handles the error returned by the xc_dom_allocate function

2015-10-25 Thread Lasya Venneti
--- tools/xenstore/init-xenstore-domain.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/xenstore/init-xenstore-domain.c b/tools/xenstore/init-xenstore-domain.c index 0d12169..d17aab5 100644 --- a/tools/xenstore/init-xenstore-domain.c +++ b/tools/xenstore/init-xenstore-domain.c @@