Re: [Xen-devel] [PATCH] blktap2: update connection handling to fix build with gcc5

2015-07-21 Thread Olaf Hering
On Mon, Jul 20, Wei Liu wrote: On Mon, Jul 20, 2015 at 11:16:34AM +0200, Olaf Hering wrote: On Mon, Jul 20, Jan Beulich wrote: On 19.07.15 at 11:33, o...@aepfle.de wrote: [ 198s] block-log.c:549:23: error: array subscript is above array bounds [-Werror=array-bounds] [

Re: [Xen-devel] [PATCH] blktap2: update connection handling to fix build with gcc5

2015-07-21 Thread Jan Beulich
On 21.07.15 at 08:32, o...@aepfle.de wrote: On Mon, Jul 20, Wei Liu wrote: On Mon, Jul 20, 2015 at 11:16:34AM +0200, Olaf Hering wrote: On Mon, Jul 20, Jan Beulich wrote: On 19.07.15 at 11:33, o...@aepfle.de wrote: [ 198s] block-log.c:549:23: error: array subscript is above

Re: [Xen-devel] [PATCH] blktap2: update connection handling to fix build with gcc5

2015-07-21 Thread George Dunlap
On 07/21/2015 09:38 AM, Ian Campbell wrote: On Tue, 2015-07-21 at 00:50 -0600, Jan Beulich wrote: What is the longterm goal of that binary? It being mostly unmaintained, it's probably a candidate for removal not too far in the future. George already posted a series to remove the in tree

Re: [Xen-devel] [PATCH] blktap2: update connection handling to fix build with gcc5

2015-07-21 Thread Ian Campbell
On Tue, 2015-07-21 at 00:50 -0600, Jan Beulich wrote: What is the longterm goal of that binary? It being mostly unmaintained, it's probably a candidate for removal not too far in the future. George already posted a series to remove the in tree copy and treat blktap2 as an out of tree

Re: [Xen-devel] [PATCH] blktap2: update connection handling to fix build with gcc5

2015-07-21 Thread Olaf Hering
On Tue, Jul 21, Jan Beulich wrote: But anyway, the primary question remains - isn't what you're seeing a compiler bug? If yes, that's imo _yet another_ reason for doing a minimal workaround (if any at all). I dont think its a compiler bug. How should the compiler know that the index variable

Re: [Xen-devel] [PATCH] blktap2: update connection handling to fix build with gcc5

2015-07-21 Thread Jan Beulich
On 21.07.15 at 09:04, o...@aepfle.de wrote: On Tue, Jul 21, Jan Beulich wrote: But anyway, the primary question remains - isn't what you're seeing a compiler bug? If yes, that's imo _yet another_ reason for doing a minimal workaround (if any at all). I dont think its a compiler bug. How

Re: [Xen-devel] [PATCH] blktap2: update connection handling to fix build with gcc5

2015-07-20 Thread Wei Liu
On Mon, Jul 20, 2015 at 11:16:34AM +0200, Olaf Hering wrote: On Mon, Jul 20, Jan Beulich wrote: On 19.07.15 at 11:33, o...@aepfle.de wrote: [ 198s] block-log.c:549:23: error: array subscript is above array bounds [-Werror=array-bounds] [ 198s] if (s-connections[i].id == id)

Re: [Xen-devel] [PATCH] blktap2: update connection handling to fix build with gcc5

2015-07-20 Thread Olaf Hering
On Mon, Jul 20, Jan Beulich wrote: On 19.07.15 at 11:33, o...@aepfle.de wrote: [ 198s] block-log.c:549:23: error: array subscript is above array bounds [-Werror=array-bounds] [ 198s] if (s-connections[i].id == id) [ 198s]^ So what makes the compiler

Re: [Xen-devel] [PATCH] blktap2: update connection handling to fix build with gcc5

2015-07-20 Thread Jan Beulich
On 19.07.15 at 11:33, o...@aepfle.de wrote: blktap2 fails to build with gcc5 because it fails to recognize that there can be just one active connection (enforced in ctl_accept). Rearrange the code to handle just a single connection. Adjust two strerror calls to use errno instead -1 as

Re: [Xen-devel] [PATCH] blktap2: update connection handling to fix build with gcc5

2015-07-20 Thread Jan Beulich
On 20.07.15 at 11:16, o...@aepfle.de wrote: On Mon, Jul 20, Jan Beulich wrote: On 19.07.15 at 11:33, o...@aepfle.de wrote: [ 198s] block-log.c:549:23: error: array subscript is above array bounds [-Werror=array-bounds] [ 198s] if (s-connections[i].id == id) [ 198s]

Re: [Xen-devel] [PATCH] blktap2: update connection handling to fix build with gcc5

2015-07-20 Thread M A Young
On Mon, 20 Jul 2015, Jan Beulich wrote: On 19.07.15 at 11:33, o...@aepfle.de wrote: blktap2 fails to build with gcc5 because it fails to recognize that there can be just one active connection (enforced in ctl_accept). Rearrange the code to handle just a single connection. Adjust

[Xen-devel] [PATCH] blktap2: update connection handling to fix build with gcc5

2015-07-19 Thread Olaf Hering
blktap2 fails to build with gcc5 because it fails to recognize that there can be just one active connection (enforced in ctl_accept). Rearrange the code to handle just a single connection. Adjust two strerror calls to use errno instead -1 as input. [ 198s] block-log.c: In function