Re: [Xen-devel] [PATCH] domctl: cleanup

2015-03-03 Thread Andrew Cooper
On 03/03/15 14:40, Jan Beulich wrote: - drop redundant ret = 0 statements - drop unnecessary braces - eliminate a few single use local variables - move break statements inside case-specific braced scopes Signed-off-by: Jan Beulich jbeul...@suse.com One bug (one ret = 0 was not redundant)

[Xen-devel] [PATCH] domctl: cleanup

2015-03-03 Thread Jan Beulich
- drop redundant ret = 0 statements - drop unnecessary braces - eliminate a few single use local variables - move break statements inside case-specific braced scopes Signed-off-by: Jan Beulich jbeul...@suse.com --- a/xen/common/domctl.c +++ b/xen/common/domctl.c @@ -517,8 +517,8 @@ long

Re: [Xen-devel] [PATCH] domctl: cleanup

2015-03-03 Thread Ian Campbell
On Tue, 2015-03-03 at 14:40 +, Jan Beulich wrote: - drop redundant ret = 0 statements - drop unnecessary braces - eliminate a few single use local variables - move break statements inside case-specific braced scopes Signed-off-by: Jan Beulich jbeul...@suse.com Acked-by: Ian Campbell