Re: [Xen-devel] [PATCH] kexec: clear kexec_image slot when unloading kexec image

2017-04-04 Thread Bhavesh Davda
> That's not how we do things normally. You could have looked at a > couple of patches sent by others... > > Jan Well, naturally I tried doing that first, but due to the follies of statistical sampling, unfortunately the several patches I looked at on xen-devel didn’t have the more verbose desc

Re: [Xen-devel] [PATCH] kexec: clear kexec_image slot when unloading kexec image

2017-04-04 Thread Jan Beulich
>>> On 04.04.17 at 17:30, wrote: >> Looks like you've mixed up commit message (everything up from this >> marker) and … >> > > Sorry about that! Since it’s been a while since I posted a git patch to a > mailing list, I had to figure out what the canonical format for an e-mail > with a patch w

Re: [Xen-devel] [PATCH] kexec: clear kexec_image slot when unloading kexec image

2017-04-04 Thread Bhavesh Davda
> Looks like you've mixed up commit message (everything up from this > marker) and … > Sorry about that! Since it’s been a while since I posted a git patch to a mailing list, I had to figure out what the canonical format for an e-mail with a patch was, such that I could have a more verbose desc

Re: [Xen-devel] [PATCH] kexec: clear kexec_image slot when unloading kexec image

2017-04-04 Thread Andrew Cooper
On 03/04/17 18:44, Bhavesh Davda wrote: > When kexec_do_unload calls kexec_swap_images to get the old kexec_image to > free, it passes NULL for the new kexec_image pointer. The new slot wasn't > being > cleared in such a case, leading to a stale pointer being left behind in the > kexec_image array

Re: [Xen-devel] [PATCH] kexec: clear kexec_image slot when unloading kexec image

2017-04-04 Thread Jan Beulich
>>> On 03.04.17 at 19:44, wrote: > While theoretically this bug can be tickled simply by a sequence of 'kexec -p' > to load a kexec crash image followed by two back-to-back 'kexec -p -u' to > unload the kexec crash image, I found the following perl script to be useful > to > reliably reproduce Xe

Re: [Xen-devel] [PATCH] kexec: clear kexec_image slot when unloading kexec image

2017-04-03 Thread Daniel Kiper
On Mon, Apr 03, 2017 at 10:44:54AM -0700, Bhavesh Davda wrote: > While theoretically this bug can be tickled simply by a sequence of 'kexec -p' > to load a kexec crash image followed by two back-to-back 'kexec -p -u' to > unload the kexec crash image, I found the following perl script to be useful

[Xen-devel] [PATCH] kexec: clear kexec_image slot when unloading kexec image

2017-04-03 Thread Bhavesh Davda
While theoretically this bug can be tickled simply by a sequence of 'kexec -p' to load a kexec crash image followed by two back-to-back 'kexec -p -u' to unload the kexec crash image, I found the following perl script to be useful to reliably reproduce Xen panics as well as verify that the fix works