On Wed, May 06, Ian Campbell wrote:
> On Wed, 2015-05-06 at 10:24 +0200, Olaf Hering wrote:
> > The code flow was essentially like this:
> >
> > libxl_device_vfb_init(libxl);
> > switch(libvirt->type) {
> > case SDL:
> > libxl_defbool_set(libxl->sdl.enable, 1);
> > break;
> > case VNC
On Wed, 2015-05-06 at 10:08 +0100, Ian Campbell wrote:
> On Wed, 2015-05-06 at 10:24 +0200, Olaf Hering wrote:
> > On Fri, May 01, Ian Campbell wrote:
> >
> > > Olaf, please can you use gdb to capture the stack trace so we can fix
> > > this (and the other issue) properly in libxl instead of just
On Wed, 2015-05-06 at 10:24 +0200, Olaf Hering wrote:
> On Fri, May 01, Ian Campbell wrote:
>
> > Olaf, please can you use gdb to capture the stack trace so we can fix
> > this (and the other issue) properly in libxl instead of just hacking
> > around it in libvirt (which might also be appropriate
On Fri, May 01, Ian Campbell wrote:
> Olaf, please can you use gdb to capture the stack trace so we can fix
> this (and the other issue) properly in libxl instead of just hacking
> around it in libvirt (which might also be appropriate for compat with
> old libxl but shouldn't be done without also
On Fri, 2015-05-01 at 09:10 -0600, Jim Fehlig wrote:
> Ian Campbell wrote:
> > On Fri, 2015-04-17 at 13:57 -0600, Jim Fehlig wrote:
> >
> >> On 04/17/2015 11:59 AM, Olaf Hering wrote:
> >>
> >>> On Fri, Apr 17, Olaf Hering wrote:
> >>>
> >>>
> If the domU configu has sdl enabled
Ian Campbell wrote:
> On Fri, 2015-04-17 at 13:57 -0600, Jim Fehlig wrote:
>
>> On 04/17/2015 11:59 AM, Olaf Hering wrote:
>>
>>> On Fri, Apr 17, Olaf Hering wrote:
>>>
>>>
If the domU configu has sdl enabled libvirtd crashes:
libvirtd[5158]: libvirtd: libxl.c:343: libxl_de
On Fri, 2015-04-17 at 13:57 -0600, Jim Fehlig wrote:
> On 04/17/2015 11:59 AM, Olaf Hering wrote:
> > On Fri, Apr 17, Olaf Hering wrote:
> >
> >> If the domU configu has sdl enabled libvirtd crashes:
> >> libvirtd[5158]: libvirtd: libxl.c:343: libxl_defbool_val: Assertion
> >> `!libxl_defbool_is_d
Olaf Hering wrote:
> On Fri, Apr 17, Olaf Hering wrote:
>
>
>> If the domU configu has sdl enabled libvirtd crashes:
>> libvirtd[5158]: libvirtd: libxl.c:343: libxl_defbool_val: Assertion
>> `!libxl_defbool_is_default(db)' failed.
>>
>> Initialize the relevant defbool variables in libxl_device_
Olaf Hering wrote:
> On Fri, Apr 17, Jim Fehlig wrote:
>
>
>> On 04/17/2015 11:19 AM, Olaf Hering wrote:
>>
>>> +libxl_defbool_set(&x_vfb->vnc.enable, 0);
>>>
>> Not shown here, but just before the switch is
>>
>> libxl_device_vfb_init(x_vfb);
>>
>> which IIUC (looki
On Mon, 2015-04-20 at 12:32 +0200, Olaf Hering wrote:
> On Mon, Apr 20, Ian Campbell wrote:
>
> > It makes no sense to do that at init time, the whole purpose of a
> > defbool is to allow the calling application to choose a value or to
> > explicitly leave it as a request to for the default (which
On Mon, Apr 20, Ian Campbell wrote:
> It makes no sense to do that at init time, the whole purpose of a
> defbool is to allow the calling application to choose a value or to
> explicitly leave it as a request to for the default (which might vary
> depending on other selections).
Yes, and thats wh
On Mon, 2015-04-20 at 12:20 +0200, Olaf Hering wrote:
> On Mon, Apr 20, Ian Campbell wrote:
>
> > If what you said were true then an assert would be a rather harsh
> > overreaction to an application coding error.
>
> Currently both libxl and libvirt are coded that way. Since the sdl code
> path i
On Mon, Apr 20, Ian Campbell wrote:
> If what you said were true then an assert would be a rather harsh
> overreaction to an application coding error.
Currently both libxl and libvirt are coded that way. Since the sdl code
path in libvirt was never executed the crash in libxlMakeVfbList was not
n
On Mon, 2015-04-20 at 11:32 +0200, Olaf Hering wrote:
> On Mon, Apr 20, Ian Campbell wrote:
>
> > On Fri, 2015-04-17 at 13:40 -0600, Jim Fehlig wrote:
> > > On 04/17/2015 11:19 AM, Olaf Hering wrote:
> > > > If the domU configu has sdl enabled libvirtd crashes:
> > > > libvirtd[5158]: libvirtd: li
On Mon, Apr 20, Ian Campbell wrote:
> On Fri, 2015-04-17 at 13:40 -0600, Jim Fehlig wrote:
> > On 04/17/2015 11:19 AM, Olaf Hering wrote:
> > > If the domU configu has sdl enabled libvirtd crashes:
> > > libvirtd[5158]: libvirtd: libxl.c:343: libxl_defbool_val: Assertion
> > > `!libxl_defbool_is_
On Fri, 2015-04-17 at 13:40 -0600, Jim Fehlig wrote:
> On 04/17/2015 11:19 AM, Olaf Hering wrote:
> > If the domU configu has sdl enabled libvirtd crashes:
> > libvirtd[5158]: libvirtd: libxl.c:343: libxl_defbool_val: Assertion
> > `!libxl_defbool_is_default(db)' failed.
>
> The assertion seems h
On Fri, Apr 17, Jim Fehlig wrote:
> On 04/17/2015 11:59 AM, Olaf Hering wrote:
> >On Fri, Apr 17, Olaf Hering wrote:
> >
> >>If the domU configu has sdl enabled libvirtd crashes:
> >>libvirtd[5158]: libvirtd: libxl.c:343: libxl_defbool_val: Assertion
> >>`!libxl_defbool_is_default(db)' failed.
>
On Fri, Apr 17, Jim Fehlig wrote:
> On 04/17/2015 11:19 AM, Olaf Hering wrote:
> >+libxl_defbool_set(&x_vfb->vnc.enable, 0);
> Not shown here, but just before the switch is
>
> libxl_device_vfb_init(x_vfb);
>
> which IIUC (looking at the impl in $xensrc/tools/libxl/_libxl_types.
On 04/17/2015 11:59 AM, Olaf Hering wrote:
On Fri, Apr 17, Olaf Hering wrote:
If the domU configu has sdl enabled libvirtd crashes:
libvirtd[5158]: libvirtd: libxl.c:343: libxl_defbool_val: Assertion
`!libxl_defbool_is_default(db)' failed.
Initialize the relevant defbool variables in libxl_de
On 04/17/2015 11:19 AM, Olaf Hering wrote:
If the domU configu has sdl enabled libvirtd crashes:
libvirtd[5158]: libvirtd: libxl.c:343: libxl_defbool_val: Assertion
`!libxl_defbool_is_default(db)' failed.
The assertion seems harsh considering the offense...
Initialize the relevant defbool v
On Fri, Apr 17, Olaf Hering wrote:
> If the domU configu has sdl enabled libvirtd crashes:
> libvirtd[5158]: libvirtd: libxl.c:343: libxl_defbool_val: Assertion
> `!libxl_defbool_is_default(db)' failed.
>
> Initialize the relevant defbool variables in libxl_device_vfb.
Fix one crash, find anoth
If the domU configu has sdl enabled libvirtd crashes:
libvirtd[5158]: libvirtd: libxl.c:343: libxl_defbool_val: Assertion
`!libxl_defbool_is_default(db)' failed.
Initialize the relevant defbool variables in libxl_device_vfb.
Signed-off-by: Olaf Hering
Cc: Jim Fehlig
---
Seen in 1.2.14.
src/
22 matches
Mail list logo
