Re: [Xen-devel] [PATCH] passthrough/amd: avoid reading an uninitialized variable.

2015-04-23 Thread Suthikulpanit, Suravee
On 4/23/15, 04:25, Tim Deegan t...@xen.org wrote: At 17:44 +0100 on 16 Apr (1429206250), Tim Deegan wrote: update_intremap_entry_from_msi() doesn't write to its data pointer on some error paths, so we copying that variable into the msg would count as undefined behaviour. Signed-off-by: Tim

Re: [Xen-devel] [PATCH] passthrough/amd: avoid reading an uninitialized variable.

2015-04-23 Thread Tim Deegan
At 17:44 +0100 on 16 Apr (1429206250), Tim Deegan wrote: update_intremap_entry_from_msi() doesn't write to its data pointer on some error paths, so we copying that variable into the msg would count as undefined behaviour. Signed-off-by: Tim Deegan t...@xen.org Cc: Suravee Suthikulpanit

Re: [Xen-devel] [PATCH] passthrough/amd: avoid reading an uninitialized variable.

2015-04-17 Thread Jan Beulich
On 16.04.15 at 19:19, andrew.coop...@citrix.com wrote: On 16/04/15 17:44, Tim Deegan wrote: update_intremap_entry_from_msi() doesn't write to its data pointer on some error paths, so we copying that variable into the msg would count as undefined behaviour. Signed-off-by: Tim Deegan

[Xen-devel] [PATCH] passthrough/amd: avoid reading an uninitialized variable.

2015-04-16 Thread Tim Deegan
update_intremap_entry_from_msi() doesn't write to its data pointer on some error paths, so we copying that variable into the msg would count as undefined behaviour. Signed-off-by: Tim Deegan t...@xen.org Cc: Suravee Suthikulpanit suravee.suthikulpa...@amd.com Cc: Aravind Gopalakrishnan

Re: [Xen-devel] [PATCH] passthrough/amd: avoid reading an uninitialized variable.

2015-04-16 Thread Andrew Cooper
On 16/04/15 17:44, Tim Deegan wrote: update_intremap_entry_from_msi() doesn't write to its data pointer on some error paths, so we copying that variable into the msg would count as undefined behaviour. Signed-off-by: Tim Deegan t...@xen.org Cc: Suravee Suthikulpanit

Re: [Xen-devel] [PATCH] passthrough/amd: avoid reading an uninitialized variable.

2015-04-16 Thread Konrad Rzeszutek Wilk
On Thu, Apr 16, 2015 at 05:44:10PM +0100, Tim Deegan wrote: update_intremap_entry_from_msi() doesn't write to its data pointer on some error paths, so we copying that variable into the msg would count as undefined behaviour. Signed-off-by: Tim Deegan t...@xen.org Cc: Suravee Suthikulpanit