Re: [Xen-devel] [PATCH] ring.h: introduce macros to handle monodirectional rings with multiple req sizes

2017-02-21 Thread Stefano Stabellini
On Tue, 21 Feb 2017, Jan Beulich wrote: > >>> On 21.02.17 at 00:26, wrote: > > On Mon, 20 Feb 2017, Jan Beulich wrote: > >> >>> On 17.02.17 at 23:38, wrote: > >> But the use of inline functions here is questionable > >> in the first place - so far

Re: [Xen-devel] [PATCH] ring.h: introduce macros to handle monodirectional rings with multiple req sizes

2017-02-21 Thread Jan Beulich
>>> On 21.02.17 at 00:26, wrote: > On Mon, 20 Feb 2017, Jan Beulich wrote: >> >>> On 17.02.17 at 23:38, wrote: >> But the use of inline functions here is questionable >> in the first place - so far there are none, as they're not standard >> C89.

Re: [Xen-devel] [PATCH] ring.h: introduce macros to handle monodirectional rings with multiple req sizes

2017-02-20 Thread Stefano Stabellini
On Mon, 20 Feb 2017, Jan Beulich wrote: > >>> On 17.02.17 at 23:38, wrote: > > For all of the comments below, please understand that I'm giving > them in the understanding that pre-existing code may be similarly > problematic; we shouldn't introduce new issues though. I

Re: [Xen-devel] [PATCH] ring.h: introduce macros to handle monodirectional rings with multiple req sizes

2017-02-20 Thread Jan Beulich
>>> On 17.02.17 at 23:38, wrote: For all of the comments below, please understand that I'm giving them in the understanding that pre-existing code may be similarly problematic; we shouldn't introduce new issues though. > --- a/xen/include/public/io/ring.h > +++

Re: [Xen-devel] [PATCH] ring.h: introduce macros to handle monodirectional rings with multiple req sizes

2017-02-17 Thread Stefano Stabellini
On Fri, 17 Feb 2017, Stefano Stabellini wrote: > This patch introduces macros, structs and functions to handle rings in > the format described by docs/misc/pvcalls.markdown and > docs/misc/9pfs.markdown. The index page (struct __name##_data_intf) > contains the indexes and the grant refs to setup

[Xen-devel] [PATCH] ring.h: introduce macros to handle monodirectional rings with multiple req sizes

2017-02-17 Thread Stefano Stabellini
This patch introduces macros, structs and functions to handle rings in the format described by docs/misc/pvcalls.markdown and docs/misc/9pfs.markdown. The index page (struct __name##_data_intf) contains the indexes and the grant refs to setup two rings. Indexes page