Re: [Xen-devel] [PATCH] tools/Coverity: Audit of MISSING_BREAK defects

2015-02-24 Thread Ian Campbell
Sorry, I failed to spot the subtle s/Xen/tools/ compared with the other one. Applied. On Mon, 2015-02-23 at 10:08 +, Andrew Cooper wrote: Ping? Do I need any more acks/reviews for this patch? ~Andrew On 12/02/15 20:08, Andrew Cooper wrote: Coverity uses several heuristics to

Re: [Xen-devel] [PATCH] tools/Coverity: Audit of MISSING_BREAK defects

2015-02-13 Thread Wei Liu
On Thu, Feb 12, 2015 at 08:08:33PM +, Andrew Cooper wrote: Coverity uses several heuristics to identify when one case statement legitimately falls through into the next, and a comment as the final item in a case statement is one heuristic (the assumption being that it is a justification

Re: [Xen-devel] [PATCH] tools/Coverity: Audit of MISSING_BREAK defects

2015-02-13 Thread Andrew Cooper
On 12/02/15 20:49, Don Koch wrote: On Thu, 12 Feb 2015 20:08:33 + Andrew Cooper andrew.coop...@citrix.com wrote: Coverity uses several heuristics to identify when one case statement legitimately falls through into the next, and a comment as the final item in a case statement is one

[Xen-devel] [PATCH] tools/Coverity: Audit of MISSING_BREAK defects

2015-02-12 Thread Andrew Cooper
Coverity uses several heuristics to identify when one case statement legitimately falls through into the next, and a comment as the final item in a case statement is one heuristic (the assumption being that it is a justification for the fallthrough). Use this to perform an audit of defects and

Re: [Xen-devel] [PATCH] tools/Coverity: Audit of MISSING_BREAK defects

2015-02-12 Thread Don Koch
On Thu, 12 Feb 2015 20:08:33 + Andrew Cooper andrew.coop...@citrix.com wrote: Coverity uses several heuristics to identify when one case statement legitimately falls through into the next, and a comment as the final item in a case statement is one heuristic (the assumption being that it is