Re: [Xen-devel] [PATCH] tools/firmware: pass EXTRAVERSION to seabios build

2017-05-30 Thread Olaf Hering
On Tue, May 30, Wei Liu wrote: > subdirs-seabios-dir: EXTRAVERSION=XXX > Limit it to the one that needs the environment variable -- seabios or > ipxe. Ok, I will try it. Last time I looked environment did not work. Olaf signature.asc Description: PGP signature

Re: [Xen-devel] [PATCH] tools/firmware: pass EXTRAVERSION to seabios build

2017-05-30 Thread Wei Liu
On Tue, May 30, 2017 at 04:24:18PM +0200, Olaf Hering wrote: > On Tue, May 30, Wei Liu wrote: > > > In that case, can you confine such hackery to be seabios only? > > Is it worth the hassle? It seems only ipxe would recognize the > EXTRAVERSION. And how would I actually limit it to seabios?

Re: [Xen-devel] [PATCH] tools/firmware: pass EXTRAVERSION to seabios build

2017-05-30 Thread Olaf Hering
On Tue, May 30, Wei Liu wrote: > In that case, can you confine such hackery to be seabios only? Is it worth the hassle? It seems only ipxe would recognize the EXTRAVERSION. And how would I actually limit it to seabios? Something like "make $(filter-out subdir-seabios-dir, subdirs-$@)"? Olaf

Re: [Xen-devel] [PATCH] tools/firmware: pass EXTRAVERSION to seabios build

2017-05-30 Thread Wei Liu
On Tue, May 30, 2017 at 02:25:11PM +0200, Olaf Hering wrote: > On Tue, May 30, Wei Liu wrote: > > > What I meant was: this is passing EXTRAVERSION to all subdir targets, > > which seems unnecessary to me. And you already specified a version > > string for seabios. > > True, but

Re: [Xen-devel] [PATCH] tools/firmware: pass EXTRAVERSION to seabios build

2017-05-30 Thread Olaf Hering
On Tue, May 30, Wei Liu wrote: > What I meant was: this is passing EXTRAVERSION to all subdir targets, > which seems unnecessary to me. And you already specified a version > string for seabios. True, but scripts/buildversion.py insists on --extra 'whatever'. Olaf signature.asc Description:

Re: [Xen-devel] [PATCH] tools/firmware: pass EXTRAVERSION to seabios build

2017-05-30 Thread Wei Liu
On Tue, May 30, 2017 at 12:33:15PM +0100, Wei Liu wrote: > On Mon, May 29, 2017 at 09:57:58AM +0200, Olaf Hering wrote: > > On Fri, May 26, Ian Jackson wrote: > > > > > This seems like a real problem which should be improved. But maybe we > > > should use Xen's EXTRAVERSION by default ? > > > >

Re: [Xen-devel] [PATCH] tools/firmware: pass EXTRAVERSION to seabios build

2017-05-30 Thread Wei Liu
On Mon, May 29, 2017 at 09:57:58AM +0200, Olaf Hering wrote: > On Fri, May 26, Ian Jackson wrote: > > > This seems like a real problem which should be improved. But maybe we > > should use Xen's EXTRAVERSION by default ? > > After thinking about it, why does the tools build not just enforce a >

Re: [Xen-devel] [PATCH] tools/firmware: pass EXTRAVERSION to seabios build

2017-05-29 Thread Olaf Hering
On Fri, May 26, Ian Jackson wrote: > This seems like a real problem which should be improved. But maybe we > should use Xen's EXTRAVERSION by default ? After thinking about it, why does the tools build not just enforce a fixed string? There is no point for scripts/buildversion.py to put current

[Xen-devel] [PATCH] tools/firmware: pass EXTRAVERSION to seabios build

2017-05-26 Thread Ian Jackson
Olaf Hering writes ("[PATCH] tools/firmware: pass EXTRAVERSION to seabios build"): > Having a fixed version string in the seabios binary is cumbersome: > - it is required to write something to '.version' in the toplevel >directory of seabios-dir-remove. > - it is required to pass

[Xen-devel] [PATCH] tools/firmware: pass EXTRAVERSION to seabios build

2017-05-26 Thread Olaf Hering
Having a fixed version string in the seabios binary is cumbersome: - it is required to write something to '.version' in the toplevel directory of seabios-dir-remove. - it is required to pass EXTRAVERSION= to make. The latter is impossible without this change. For some reason an 'export