Re: [Xen-devel] [PATCH] tools: libxl: Simplify logic in libxl__realloc

2016-03-01 Thread Ian Jackson
(CC list adjusted) Ian Campbell writes ("Re: [PATCH] tools: libxl: Simplify logic in libxl__realloc"): > On Fri, 2016-02-19 at 15:34 +, Ian Jackson wrote: > > Replace the loop exit and separate test for loop overrun with an > > assert in the loop body. > > > > This simplifies the code.  It

Re: [Xen-devel] [PATCH] tools: libxl: Simplify logic in libxl__realloc

2016-02-25 Thread Ian Campbell
On Fri, 2016-02-19 at 15:34 +, Ian Jackson wrote: > Replace the loop exit and separate test for loop overrun with an > assert in the loop body. > > This simplifies the code.  It also (hopefully) avoids Coverity > thinking that gc->alloc_maxsize might change, resulting in the loop > failing to

[Xen-devel] [PATCH] tools: libxl: Simplify logic in libxl__realloc

2016-02-19 Thread Ian Jackson
Replace the loop exit and separate test for loop overrun with an assert in the loop body. This simplifies the code. It also (hopefully) avoids Coverity thinking that gc->alloc_maxsize might change, resulting in the loop failing to find the right answer but also failing to abort.