Re: [Xen-devel] [PATCH] x86/PV: hide features dependent on XSAVE when booted with "no-xsave"

2015-11-30 Thread Jan Beulich
>>> On 27.11.15 at 16:05, wrote: > On 27/11/15 11:05, Jan Beulich wrote: >> ... or when the guest has the XSAVE feature hidden by CPUID policy. >> Not doing so is at best confusing to guests. >> >> Signed-off-by: Jan Beulich > > These changes here

Re: [Xen-devel] [PATCH] x86/PV: hide features dependent on XSAVE when booted with "no-xsave"

2015-11-30 Thread Andrew Cooper
On 30/11/15 15:22, Jan Beulich wrote: On 30.11.15 at 14:36, wrote: >> On 30/11/15 11:30, Jan Beulich wrote: >>> It's not well defined whether YMM register presence >>> correlates to AVX, or is simply flagged by the respective XSTATE >>> CPUID bit (or a mixture of

Re: [Xen-devel] [PATCH] x86/PV: hide features dependent on XSAVE when booted with "no-xsave"

2015-11-30 Thread Jan Beulich
>>> On 30.11.15 at 14:36, wrote: > On 30/11/15 11:30, Jan Beulich wrote: >> It's not well defined whether YMM register presence >> correlates to AVX, or is simply flagged by the respective XSTATE >> CPUID bit (or a mixture of both). > > It is indeed not well defined,

Re: [Xen-devel] [PATCH] x86/PV: hide features dependent on XSAVE when booted with "no-xsave"

2015-11-30 Thread Jan Beulich
>>> On 30.11.15 at 16:38, wrote: > On 30/11/15 15:22, Jan Beulich wrote: > On 30.11.15 at 14:36, wrote: >>> On 30/11/15 11:30, Jan Beulich wrote: It's not well defined whether YMM register presence correlates to AVX, or is

Re: [Xen-devel] [PATCH] x86/PV: hide features dependent on XSAVE when booted with "no-xsave"

2015-11-30 Thread Andrew Cooper
On 30/11/15 16:00, Jan Beulich wrote: On 30.11.15 at 16:38, wrote: >> On 30/11/15 15:22, Jan Beulich wrote: >> On 30.11.15 at 14:36, wrote: On 30/11/15 11:30, Jan Beulich wrote: > It's not well defined whether YMM register

Re: [Xen-devel] [PATCH] x86/PV: hide features dependent on XSAVE when booted with "no-xsave"

2015-11-30 Thread Jan Beulich
>>> On 30.11.15 at 12:10, wrote: > On 30/11/15 11:08, Jan Beulich wrote: > On 30.11.15 at 11:46, wrote: >>> On 30/11/15 10:01, Jan Beulich wrote: >>> On 27.11.15 at 16:05, wrote: > On 27/11/15 11:05,

Re: [Xen-devel] [PATCH] x86/PV: hide features dependent on XSAVE when booted with "no-xsave"

2015-11-30 Thread Jan Beulich
>>> On 30.11.15 at 11:46, wrote: > On 30/11/15 10:01, Jan Beulich wrote: > On 27.11.15 at 16:05, wrote: >>> On 27/11/15 11:05, Jan Beulich wrote: ... or when the guest has the XSAVE feature hidden by CPUID policy. Not doing so

Re: [Xen-devel] [PATCH] x86/PV: hide features dependent on XSAVE when booted with "no-xsave"

2015-11-30 Thread Andrew Cooper
On 30/11/15 11:08, Jan Beulich wrote: On 30.11.15 at 11:46, wrote: >> On 30/11/15 10:01, Jan Beulich wrote: >> On 27.11.15 at 16:05, wrote: On 27/11/15 11:05, Jan Beulich wrote: > ... or when the guest has the XSAVE feature

Re: [Xen-devel] [PATCH] x86/PV: hide features dependent on XSAVE when booted with "no-xsave"

2015-11-30 Thread Andrew Cooper
On 30/11/15 10:01, Jan Beulich wrote: On 27.11.15 at 16:05, wrote: >> On 27/11/15 11:05, Jan Beulich wrote: >>> ... or when the guest has the XSAVE feature hidden by CPUID policy. >>> Not doing so is at best confusing to guests. >>> >>> Signed-off-by: Jan Beulich

Re: [Xen-devel] [PATCH] x86/PV: hide features dependent on XSAVE when booted with "no-xsave"

2015-11-30 Thread Andrew Cooper
On 30/11/15 11:30, Jan Beulich wrote: On 30.11.15 at 12:10, wrote: >> On 30/11/15 11:08, Jan Beulich wrote: >> On 30.11.15 at 11:46, wrote: On 30/11/15 10:01, Jan Beulich wrote: On 27.11.15 at 16:05,

Re: [Xen-devel] [PATCH] x86/PV: hide features dependent on XSAVE when booted with "no-xsave"

2015-11-27 Thread Andrew Cooper
On 27/11/15 11:05, Jan Beulich wrote: > ... or when the guest has the XSAVE feature hidden by CPUID policy. > Not doing so is at best confusing to guests. > > Signed-off-by: Jan Beulich These changes here are an improvement (so I don't object to taking them ahead of my