Re: [Xen-devel] [PATCH] x86/compat: correct SMEP/SMAP NOPs patching

2016-05-27 Thread Jan Beulich
>>> On 25.05.16 at 17:00, wrote: > Correct the number of single byte NOPs we want to be replaced in case > neither SMEP nor SMAP are available. > > Also simplify the expression adding these NOPs - at that location . > equals .Lcr4_orig, and removing that part of the expression fixes a > bogus ".s

Re: [Xen-devel] [PATCH] x86/compat: correct SMEP/SMAP NOPs patching

2016-05-26 Thread Andrew Cooper
On 25/05/16 16:00, Jan Beulich wrote: > Correct the number of single byte NOPs we want to be replaced in case > neither SMEP nor SMAP are available. > > Also simplify the expression adding these NOPs - at that location . > equals .Lcr4_orig, and removing that part of the expression fixes a > bogus

Re: [Xen-devel] [PATCH] x86/compat: correct SMEP/SMAP NOPs patching

2016-05-25 Thread Wei Liu
On Wed, May 25, 2016 at 09:00:49AM -0600, Jan Beulich wrote: > Correct the number of single byte NOPs we want to be replaced in case > neither SMEP nor SMAP are available. > > Also simplify the expression adding these NOPs - at that location . > equals .Lcr4_orig, and removing that part of the exp

[Xen-devel] [PATCH] x86/compat: correct SMEP/SMAP NOPs patching

2016-05-25 Thread Jan Beulich
Correct the number of single byte NOPs we want to be replaced in case neither SMEP nor SMAP are available. Also simplify the expression adding these NOPs - at that location . equals .Lcr4_orig, and removing that part of the expression fixes a bogus ".space or fill with negative value, ignored" war