Re: [Xen-devel] [PATCH] x86/emul: Reorder the user segments in x86_segment to match SReg3 encoding

2016-10-24 Thread Jan Beulich
>>> On 24.10.16 at 11:28, wrote: > On 24/10/16 10:16, Jan Beulich wrote: > On 14.10.16 at 18:13, wrote: >>> @@ -2980,8 +2964,8 @@ x86_emulate( >>> break; >>> >>> case 0x8c: /* mov Sreg,r/m */ >>> -seg =

Re: [Xen-devel] [PATCH] x86/emul: Reorder the user segments in x86_segment to match SReg3 encoding

2016-10-24 Thread Andrew Cooper
On 24/10/16 10:16, Jan Beulich wrote: On 14.10.16 at 18:13, wrote: >> @@ -2980,8 +2964,8 @@ x86_emulate( >> break; >> >> case 0x8c: /* mov Sreg,r/m */ >> -seg = decode_segment(modrm_reg); >> -generate_exception_if(seg ==

Re: [Xen-devel] [PATCH] x86/emul: Reorder the user segments in x86_segment to match SReg3 encoding

2016-10-24 Thread Jan Beulich
>>> On 14.10.16 at 18:13, wrote: > @@ -2980,8 +2964,8 @@ x86_emulate( > break; > > case 0x8c: /* mov Sreg,r/m */ > -seg = decode_segment(modrm_reg); > -generate_exception_if(seg == decode_segment_failed, EXC_UD, -1); > +seg =

[Xen-devel] [PATCH] x86/emul: Reorder the user segments in x86_segment to match SReg3 encoding

2016-10-14 Thread Andrew Cooper
This avoids needing a translation table between hardware ordering and Xen's ordering. No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich --- xen/arch/x86/x86_emulate/x86_emulate.c | 35 +++---